From patchwork Tue Jan 11 07:17:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiasheng Jiang X-Patchwork-Id: 12709554 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 792FEC433EF for ; Tue, 11 Jan 2022 07:18:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348477AbiAKHSV (ORCPT ); Tue, 11 Jan 2022 02:18:21 -0500 Received: from smtp21.cstnet.cn ([159.226.251.21]:58218 "EHLO cstnet.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233066AbiAKHST (ORCPT ); Tue, 11 Jan 2022 02:18:19 -0500 Received: from localhost.localdomain (unknown [124.16.138.126]) by APP-01 (Coremail) with SMTP id qwCowAB3fp4gL91hlu8pBg--.37098S2; Tue, 11 Jan 2022 15:17:52 +0800 (CST) From: Jiasheng Jiang To: heikki.krogerus@linux.intel.com, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Jiasheng Jiang Subject: [PATCH] usb: typec: Check error number after calling ida_simple_get Date: Tue, 11 Jan 2022 15:17:51 +0800 Message-Id: <20220111071751.590487-1-jiasheng@iscas.ac.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CM-TRANSID: qwCowAB3fp4gL91hlu8pBg--.37098S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtFy3XryfZw1fXr17AF43KFg_yoWDJwc_CF sYgrn7Xry5CF93Aw1UJ345ur9Y9a1v9r1UWFsYgan3Ja4DAr18WFWqv3s8X3WxWr48KF98 Gr12y3yIgw17ujkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUbcAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG 6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8w A2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Cr0_ Gr1UM28EF7xvwVC2z280aVAFwI0_Cr1j6rxdM28EF7xvwVC2z280aVCY1x0267AKxVW0oV Cq3wAS0I0E0xvYzxvE52x082IY62kv0487Mc02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0 I7IYx2IY67AKxVWUJVWUGwAv7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r 4UM4x0Y48IcxkI7VAKI48JM4x0x7Aq67IIx4CEVc8vx2IErcIFxwCY02Avz4vE14v_GF4l 42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJV WUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r126r1DMIIYrxkI7VAK I48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r1j6r 4UMIIF0xvE42xK8VAvwI8IcIk0rVWrJr0_WFyUJwCI42IY6I8E87Iv67AKxVWUJVW8JwCI 42IY6I8E87Iv6xkF7I0E14v26r4j6r4UJbIYCTnIWIevJa73UjIFyTuYvjfUekucDUUUU X-Originating-IP: [124.16.138.126] X-CM-SenderInfo: pmld2xxhqjqxpvfd2hldfou0/ Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org If allocation fails, the ida_simple_get() will return error number. So altmode_id_get() may return error number. And then id will be used in altmode_id_remove, causing the BUG_ON(). Or it will be assigned to alt->id. Therefore, it should be better to check it and return error if fails, like the ida_simple_get() in typec_register_port(). Fixes: 8a37d87d72f0 ("usb: typec: Bus type for alternate modes") Signed-off-by: Jiasheng Jiang --- drivers/usb/typec/class.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c index aeef453aa658..67b3670ede99 100644 --- a/drivers/usb/typec/class.c +++ b/drivers/usb/typec/class.c @@ -516,6 +516,9 @@ typec_register_altmode(struct device *parent, struct altmode *alt; int ret; + if (id < 0) + return ERR_PTR(id); + alt = kzalloc(sizeof(*alt), GFP_KERNEL); if (!alt) { altmode_id_remove(parent, id);