From patchwork Tue Jan 11 16:40:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= X-Patchwork-Id: 12710038 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC98CC433FE for ; Tue, 11 Jan 2022 16:40:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343742AbiAKQkp (ORCPT ); Tue, 11 Jan 2022 11:40:45 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240518AbiAKQkn (ORCPT ); Tue, 11 Jan 2022 11:40:43 -0500 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A48C5C06173F for ; Tue, 11 Jan 2022 08:40:42 -0800 (PST) Received: by mail-wm1-x332.google.com with SMTP id p1-20020a1c7401000000b00345c2d068bdso1812235wmc.3 for ; Tue, 11 Jan 2022 08:40:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SagTRgb0Fa7LKdm4Z4vqgY6AAgSxRW5l9yIC/I1rIDg=; b=f0hQ4KFlesVBtO/etDAq5Bd49HonkEv2i1aX+5fjk8Cc/4AhnVlRoRdydjU6kzqaYw Xxdg2ORD5gPzHnOOs/iRx1SBTxOVRUcAQCBQnwPfty+iQ3sLkvLFJyw96cO4VaTjtLKs UIWzqHzL8MyyKrsXbZCGGhZsMDlRuqdid9//Vge6G75kYhRJP5EdLqY/k9P0nsTruH9A D3kmGIBWr7Rc8eDfTnQek1SiOc0bY5CzfaasDRfUPdRlwY7Hn/MACSiovqfYodQvzNLU sY1LkFZeLqS0WmG5bCbvgNjCF8Wyos1J4BHxu1i/hSqe44q72PiP6UYzr3BnQO1B5v8k NpTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SagTRgb0Fa7LKdm4Z4vqgY6AAgSxRW5l9yIC/I1rIDg=; b=vOXHJw1CQDtU3uyHKxlItv3B7XSm8I+u0HRx+UJa04GTebuWJm0J/z7mpWKw0erk4Q k/HWLKQ0izAkPalp2XIwzbXw/P8tnWOcGyz8lttbqzV8wZO+uy9C2+A16wXLaxYar8uW fRSpYRJBSxiW8n9k64dV+8qeBFjaDsMWjGGR+rYxrpcCOQlTixK3Kw6cu00QHbdCdkw+ 6Qq+8Axn87e6atq21WCKgUpjY7im6MtgK0X9L/cCwUwmsNOVe37p/FfH4a819ctuDWBS NSA822E1LPL80hgwA1eJYnKceEUo51v6TUoAFrxB+/G2SGXV60dEsffagCdPzLBPRMfn JUKA== X-Gm-Message-State: AOAM532FC5/NYF0H4mKQPcYn0Kf/BM3RIG9bM3xFYes2nybUNHgfQME1 1Rb3qg3TJgbPMH5GJ2OMMCV1ZLPUDDlG1Q== X-Google-Smtp-Source: ABdhPJyTtUOU19cY7aTk4bYeSefvSrl37/yfVaLsMJROrxvJWhCawEo35iljG3qxvL2oHpZjigeCMA== X-Received: by 2002:a7b:c389:: with SMTP id s9mr3181175wmj.187.1641919241015; Tue, 11 Jan 2022 08:40:41 -0800 (PST) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id o38sm2536934wms.11.2022.01.11.08.40.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 08:40:40 -0800 (PST) From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Han-Wen Nienhuys , =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBC?= =?utf-8?b?amFybWFzb24=?= Subject: [PATCH 1/3] test-tool genzeros: initialize "zeros" to avoid SunCC warning Date: Tue, 11 Jan 2022 17:40:21 +0100 Message-Id: X-Mailer: git-send-email 2.35.0.rc0.844.gb5945183dcf In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org It isn't important for optimization to have this be "static", so let's just initialize it and avoid this warning on Sun Studio 12.5: "t/helper/test-genzeros.c", line 7: warning: const object should have initializer: zeros This amends code added in df7000cd910 (test-tool genzeros: generate large amounts of data more efficiently, 2021-11-02), and first tagged with v2.35.0-rc0. Signed-off-by: Ævar Arnfjörð Bjarmason --- t/helper/test-genzeros.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/t/helper/test-genzeros.c b/t/helper/test-genzeros.c index 8ca988d6216..5dc89eda0cb 100644 --- a/t/helper/test-genzeros.c +++ b/t/helper/test-genzeros.c @@ -3,8 +3,7 @@ int cmd__genzeros(int argc, const char **argv) { - /* static, so that it is NUL-initialized */ - static const char zeros[256 * 1024]; + const char zeros[256 * 1024] = { 0 }; intmax_t count; ssize_t n; From patchwork Tue Jan 11 16:40:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= X-Patchwork-Id: 12710040 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 049D8C433F5 for ; Tue, 11 Jan 2022 16:40:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244297AbiAKQkr (ORCPT ); Tue, 11 Jan 2022 11:40:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240510AbiAKQkn (ORCPT ); Tue, 11 Jan 2022 11:40:43 -0500 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B413C061748 for ; Tue, 11 Jan 2022 08:40:43 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id d19so3559435wrb.0 for ; Tue, 11 Jan 2022 08:40:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dfvuXJDeWiMaa4TkVydyxuanCqxO27LyODjAV6LXaM4=; b=AEzmwm2FFQqpi1gzuHoNCPDLRNf3jgebsjajB//cJs5iFzrQIHc+chIy+iP7MK34wa FdDusVu/Cp9XQDCLk4kBwOsXt8to1PeUJlfjtZiXi1yNNRuaZYqadVSaNFOMqjBnRIzA wKb8xHp/o/JViPAuFLqxHRPeYm/RZfa4FcPmmxUwSMcA7D+zYnpKA/lYYwNlxOyU9PS/ hxpfyrDc97DX+bYT20JtFn0FCYbmSk6bgzdKT2T2oqB9YtoHCqFSkolrS6UE+TWVaIeu /GnfqPSdXSkyDtCh7SX36l3wWJm7JXNpC3qwEyoVI1dbbDAZzu3ddrOxanlXsmhuIgIc hAWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dfvuXJDeWiMaa4TkVydyxuanCqxO27LyODjAV6LXaM4=; b=xs4ec96/TK2JuvmcdS2okFdn34wChT1GzBi4HAgtoCdqAHr5hNVP8VgtlwDoo+5n6Y LWFbDxiGAET6C9yJ3RBwimZSOxylJZvskcWAno6PEl9GTrtjO4KYOSoCEk++nBQtjGLX 4LXxhl21SJ64yhVjdj9uB3hzFBgee9s0EONC13YvBq8IAy898p1eEbVCTHGPIASZqmp0 /fJdDvaL88b2Hz58VTZ5i9sqe1hI1skJC098qBoUEMFbkPCrBJ2Q4v8D5+Ua+WTXNpCt BBczV6kqffem6v7Ji0MYijv3UvewYT6q1Kx9ZHA6rAdvFIpzRe2Vr7Zdd5/cnPjkjPGr /96Q== X-Gm-Message-State: AOAM533NCcCOeCBUNesJmPCDWfLBfHTBSvwq0mpGmosa/1zhb2dlK45i Yyw9uPdeS7yvLE5OvcjNa7hf9yE3RQcPlg== X-Google-Smtp-Source: ABdhPJz7pa8GKLe3MvYMngnFcWKU98enF6G7+ZZ0mzx4Q8sQ2Pko1GdSwCXcrvZXUn2VQnJRWhNEBQ== X-Received: by 2002:adf:e60f:: with SMTP id p15mr2946702wrm.476.1641919241731; Tue, 11 Jan 2022 08:40:41 -0800 (PST) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id o38sm2536934wms.11.2022.01.11.08.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 08:40:41 -0800 (PST) From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Han-Wen Nienhuys , =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBC?= =?utf-8?b?amFybWFzb24=?= Subject: [PATCH 2/3] reftable: remove unreachable "return" statements Date: Tue, 11 Jan 2022 17:40:22 +0100 Message-Id: X-Mailer: git-send-email 2.35.0.rc0.844.gb5945183dcf In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Remove unreachable return statements added in acb533440fc (reftable: implement refname validation, 2021-10-07) and f14bd719349 (reftable: write reftable files, 2021-10-07). This avoids the following warnings on SunCC 12.5 on gcc211.fsffrance.org: "reftable/refname.c", line 135: warning: statement not reached "reftable/refname.c", line 135: warning: statement not reached Signed-off-by: Ævar Arnfjörð Bjarmason --- reftable/refname.c | 1 - reftable/writer.c | 1 - 2 files changed, 2 deletions(-) diff --git a/reftable/refname.c b/reftable/refname.c index 95734969324..136001bc2c7 100644 --- a/reftable/refname.c +++ b/reftable/refname.c @@ -132,7 +132,6 @@ static int validate_refname(const char *name) return REFTABLE_REFNAME_ERROR; name = next + 1; } - return 0; } int validate_ref_record_addition(struct reftable_table tab, diff --git a/reftable/writer.c b/reftable/writer.c index 35c8649c9b7..70a7bf142a2 100644 --- a/reftable/writer.c +++ b/reftable/writer.c @@ -39,7 +39,6 @@ writer_reftable_block_stats(struct reftable_writer *w, uint8_t typ) return &w->stats.log_stats; } abort(); - return NULL; } /* write data, queuing the padding for the next write. Returns negative for From patchwork Tue Jan 11 16:40:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= X-Patchwork-Id: 12710039 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B20DC433EF for ; Tue, 11 Jan 2022 16:40:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343712AbiAKQkq (ORCPT ); Tue, 11 Jan 2022 11:40:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241160AbiAKQko (ORCPT ); Tue, 11 Jan 2022 11:40:44 -0500 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07876C061751 for ; Tue, 11 Jan 2022 08:40:44 -0800 (PST) Received: by mail-wm1-x32f.google.com with SMTP id c66so11474943wma.5 for ; Tue, 11 Jan 2022 08:40:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=orgxBX0mwCtQkgYN6zXHuMRCLyNHwgGkwcNyG2r7Yxc=; b=l0Nr3ApAkn9q6tXTuMqNNbyJiJJ4yFedqL4J2R7BFr3CWG2cvei0ZcXfAD0uELI06a uu/jUZnbFgHhOdiYZfW9OUI6l4exIoEBoN/KkRzT0DCrXyIhpXAxmNl2GlTnJe13Xuvm +OhBptJ5iA11ut5WUHFCdKPrMKodTViCNDsNhoNZLsdnzSXKPzl0wOyEV8Tt7T8tWYSh hoonnBLIZ2DfJLpAhdVZ2vzVnYM+Cd+Q9PeAu9otox2VS40HC65I9bdcExFf7RSN7Fze N/I8O3UDK1Ll9nI8UgajvOScejMMXsd8GA7kLO04qbBMPLI2P9AY30S/SL58++r5v7Q8 bFIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=orgxBX0mwCtQkgYN6zXHuMRCLyNHwgGkwcNyG2r7Yxc=; b=K1NtafKl26PB+w33n+AyADhGoVn8hjC8fY7EVXo0+MgFx9KJVhqXcdZ2088OK5akFZ O4seLt5p1FWhJv/PpDIz52ROzZQ/Saru51gxE5EnMr02Cl7yhF+jnGlH6QpTFVgMxfUi FrT1caMClHppWa56He91OJ6/D54LJSPIB3Tn1TyPSNis6M3dSuHTKf5HAktJLOiySjfe PsM7GjMCAXn3uncUQ+Ir0w2vOvf13Up8sePd/7XFvF/FiHvl9TbrCJKo06x+TXEYkZbH PHO2S8W/4C2NrJvYnxPJFMVvLUTxB+Snv9vxdAajpfr7gREBPU4LpGLGsz9k+M2AfFIE i3zw== X-Gm-Message-State: AOAM5316QVkRARGnCE01eb7j9T7Moow8JGQtEuKzhlt0bexQn7Ot8SHI QR9roC44IBIwM/5CgJwo63xEk7lwzpg1KQ== X-Google-Smtp-Source: ABdhPJwMUMdNxlQO523REuU/8Vr/gFwFYNFDLgj/qg5GKC3jTCHDA3es/MpCPSJ7pR9Fjo4nnLIdcQ== X-Received: by 2002:a1c:f316:: with SMTP id q22mr3180098wmq.33.1641919242413; Tue, 11 Jan 2022 08:40:42 -0800 (PST) Received: from vm.nix.is (vm.nix.is. [2a01:4f8:120:2468::2]) by smtp.gmail.com with ESMTPSA id o38sm2536934wms.11.2022.01.11.08.40.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jan 2022 08:40:41 -0800 (PST) From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= To: git@vger.kernel.org Cc: Junio C Hamano , Johannes Schindelin , Han-Wen Nienhuys , =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBC?= =?utf-8?b?amFybWFzb24=?= Subject: [PATCH 3/3] reftable tests: avoid "int" overflow, use "uint64_t" Date: Tue, 11 Jan 2022 17:40:23 +0100 Message-Id: X-Mailer: git-send-email 2.35.0.rc0.844.gb5945183dcf In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Change code added in 1ae2b8cda84 (reftable: add merged table view, 2021-10-07) to consistently use the "uint64_t" type. These "min" and "max" variables get passed in the body of this function to a function whose prototype is: [...] reftable_writer_set_limits([...], uint64_t min, uint64_t max This avoids the following warning on SunCC 12.5 on gcc211.fsffrance.org: "reftable/merged_test.c", line 27: warning: initializer does not fit or is out of range: 0xffffffff Signed-off-by: Ævar Arnfjörð Bjarmason --- reftable/merged_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/reftable/merged_test.c b/reftable/merged_test.c index 24461e8a802..b87ff495dfd 100644 --- a/reftable/merged_test.c +++ b/reftable/merged_test.c @@ -24,8 +24,8 @@ license that can be found in the LICENSE file or at static void write_test_table(struct strbuf *buf, struct reftable_ref_record refs[], int n) { - int min = 0xffffffff; - int max = 0; + uint64_t min = 0xffffffff; + uint64_t max = 0; int i = 0; int err;