From patchwork Fri Jan 14 09:05:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Garzarella X-Patchwork-Id: 12713490 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB38C433F5 for ; Fri, 14 Jan 2022 09:06:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237075AbiANJFY (ORCPT ); Fri, 14 Jan 2022 04:05:24 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:22160 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232000AbiANJFY (ORCPT ); Fri, 14 Jan 2022 04:05:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642151122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=QSqhd5EHQVjGBS9+fRjPxVdCzG4rtUKAbc2JLGcS0M8=; b=Tdmn81NDuGk/W9lmrPZvnvKxNi3F3oF85nkAc/WEiAaEMIa7WYIob3LcK3ZxWniad+wxHm p0CCmBSjYHD8j2SY3JEO95hJ82wwbcdbseHolnyrOgmYegHu1zckE7bDiecjfutkSTpUDF pjZZD6CHIx5W0ip39K17u9ZDWhvqgqg= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-280-bvAIhifIPUWykEush7XFEw-1; Fri, 14 Jan 2022 04:05:21 -0500 X-MC-Unique: bvAIhifIPUWykEush7XFEw-1 Received: by mail-pj1-f69.google.com with SMTP id k2-20020a17090a658200b001b399622095so8629962pjj.9 for ; Fri, 14 Jan 2022 01:05:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QSqhd5EHQVjGBS9+fRjPxVdCzG4rtUKAbc2JLGcS0M8=; b=gcmM5rhDpSJOcYV5Vc5fo3vC655FLcbdJlVHzDVTvPI6lfmhYWEa+iuDBc7ze478cN JSSSPYgFZ+xB2z6eCuK/muSg3VFXT8NV13ZZ85y9+wDY69HiOjW/BEz1ufaoTwORy9uY i7MciCGon3o86Fxv06BxgDdMKmjf3jZvs5Gk2SZngg8Ztbh4nxmnifDThuiridJ1iaZj 4bTn5thchZfRuvyUDL/4EdBMyAbmlxjKwWm/nQ6W3EIp8+NIWC64OWz9glCMDIEUX00T AYJYRx208idxYFToZE4P9CyCQo3iCheHFqCGUCcGkghhuK6gIaoE0g+yg1Oih3wZxrRX 2jVQ== X-Gm-Message-State: AOAM5310piwb5hJTQshMbevpJEvn5a89w1waZM7yne1uw83XnPAKXLiN mJNXys78Zlp19VbCj0Z8lwb+hWlmkolMedP593Ig0tzgRZfdnFmOeEk+KjjA8CxQg1fbT3t+nZa nFoxyt86+XNkMqpfs X-Received: by 2002:a17:902:7603:b0:148:daa7:ed7e with SMTP id k3-20020a170902760300b00148daa7ed7emr8569172pll.150.1642151119915; Fri, 14 Jan 2022 01:05:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJxW79PSPSMG4VhQolpshd54Loc7rye/TOYMJd/7+9JvMi8g1YuVwpqwFGtXO0bt0SuSVXZouw== X-Received: by 2002:a17:902:7603:b0:148:daa7:ed7e with SMTP id k3-20020a170902760300b00148daa7ed7emr8569146pll.150.1642151119627; Fri, 14 Jan 2022 01:05:19 -0800 (PST) Received: from steredhat.redhat.com (host-95-238-125-214.retail.telecomitalia.it. [95.238.125.214]) by smtp.gmail.com with ESMTPSA id c6sm5217474pfv.62.2022.01.14.01.05.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jan 2022 01:05:18 -0800 (PST) From: Stefano Garzarella To: virtualization@lists.linux-foundation.org Cc: linux-kernel@vger.kernel.org, "Michael S. Tsirkin" , stefanha@redhat.com, kvm@vger.kernel.org, netdev@vger.kernel.org, Jason Wang Subject: [PATCH v1] vhost: cache avail index in vhost_enable_notify() Date: Fri, 14 Jan 2022 10:05:08 +0100 Message-Id: <20220114090508.36416-1-sgarzare@redhat.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In vhost_enable_notify() we enable the notifications and we read the avail index to check if new buffers have become available in the meantime. We are not caching the avail index, so when the device will call vhost_get_vq_desc(), it will find the old value in the cache and it will read the avail index again. It would be better to refresh the cache every time we read avail index, so let's change vhost_enable_notify() caching the value in `avail_idx` and compare it with `last_avail_idx` to check if there are new buffers available. Anyway, we don't expect a significant performance boost because the above path is not very common, indeed vhost_enable_notify() is often called with unlikely(), expecting that avail index has not been updated. Signed-off-by: Stefano Garzarella --- v1: - improved the commit description [MST, Jason] --- drivers/vhost/vhost.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c index 59edb5a1ffe2..07363dff559e 100644 --- a/drivers/vhost/vhost.c +++ b/drivers/vhost/vhost.c @@ -2543,8 +2543,9 @@ bool vhost_enable_notify(struct vhost_dev *dev, struct vhost_virtqueue *vq) &vq->avail->idx, r); return false; } + vq->avail_idx = vhost16_to_cpu(vq, avail_idx); - return vhost16_to_cpu(vq, avail_idx) != vq->avail_idx; + return vq->avail_idx != vq->last_avail_idx; } EXPORT_SYMBOL_GPL(vhost_enable_notify);