From patchwork Wed Dec 26 19:07:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aditya Pakki X-Patchwork-Id: 10743275 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 01078746 for ; Wed, 26 Dec 2018 19:08:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E516C28795 for ; Wed, 26 Dec 2018 19:08:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D898F2879E; Wed, 26 Dec 2018 19:08:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 766B428795 for ; Wed, 26 Dec 2018 19:08:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BE558E0005; Wed, 26 Dec 2018 14:08:03 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 56E748E0001; Wed, 26 Dec 2018 14:08:03 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4844A8E0005; Wed, 26 Dec 2018 14:08:03 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) by kanga.kvack.org (Postfix) with ESMTP id 22AA18E0001 for ; Wed, 26 Dec 2018 14:08:03 -0500 (EST) Received: by mail-io1-f71.google.com with SMTP id t13so14707152ioi.3 for ; Wed, 26 Dec 2018 11:08:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:from:to:cc:subject:date :message-id; bh=ochM5m1KMB+5vlcxy5xlYUPq9FxXr2ho76d6PIZxYqg=; b=kmjxaapR9EJJHAJhJxEI0IEOdAU8K/zrJYeaN3VARc8wtUAF016YtSyUILfVPVFvVt WH/EiYC6BCfZG7NJW19GaULWKT6wgBTVuFWoYeRO77z8s7D7vIxUR+5lA6QWgb8Kpuvt d+Y3ofWqqXw1WWcEsYLaD7iFqBM6YjOfmSwjOiSB0cRe2du+mm3W9khLmVkPjvampw0N fbaehnxmdZfyj163zQNMYdkEievHOHqNbToqNgbVROCZmcVQFL1z2v/OmoJrGMi/ZE2u 369qyvAfjiE6/L9RTRiD43FFKxOEjk6dcNX7AYqJh6oFO8KavevM+C3W23voXZWucg2m tR6w== X-Gm-Message-State: AJcUukf35bWgawyB+uF7pemEUiiAqeS6qUhTNVX27cVx6kHmI1Dtsink rYyiKg9Fvytrt12E80tKYvajh4Hy3xpao32hSsHmIwKigxu4PSqJ7MsHQ9iLH79gvb/JPmDlhw3 34dQccilzEXJC8ZEmSoFr8Nbjq2UeNfkEohHnZDChpSH7ufOEHOreaguC77UiVSb12HHUtgG3jT EjO6YMzkYjNEABs7K5KR6pAqquHIDPo9w99Z5BXAXATiHWKLBaShZAoABs5k9gXw8zEFyDHazHl hP5EciROPZfni9dmcQUxzOYHnBA/TT5rwmU2YLXEu/eHXSZoJRP3f/CFhFU3OgpInjk2SLtx6fv ZQxXQk5E77qaQERnloIccE0rYYtRE+MgXJHXifc36t/gtSX0fGOr4/6YjmW4eoBXzhv/qjeFJ00 z6+yioACkgsJyvjXxiPUryAKp8xa9nBhrs6wPP5H9ysU+ZDLqkSz1vfnFxRTMMN+3BOosFeCSlB FfLP7zmfNRs0P6MOkphTyKpwhd/ioVRdCWgwDLCs8X0yqRtvNQQ4+i1DQPnDg5JxdJd2PhahA6v 6SHA+FpFqoAtu6/xdMnyyJ6VSbGAVOz6ZGvEeGWKBm7Zyuh X-Received: by 2002:a6b:cd41:: with SMTP id d62mr14689949iog.121.1545851282891; Wed, 26 Dec 2018 11:08:02 -0800 (PST) X-Google-Smtp-Source: ALg8bN447OdwTLdQLLPWAv681xQr7bw3v6ezFKi1YL+bUN6f+0Nt7GOOJ46VfKDAiAG9S4DrJqY/ X-Received: by 2002:a6b:cd41:: with SMTP id d62mr14689916iog.121.1545851282109; Wed, 26 Dec 2018 11:08:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545851282; cv=none; d=google.com; s=arc-20160816; b=v2ssDG9mlWI0QC79RO3i34u0wQZ5jpdx87sybv8VmsS7gJekEa6kPu1AIl8lWdPYAR /YUYBrJajN5ogUKyLGM3kB5JgGllCZihjhKiBmauffarV1blRuw4d2D5tZ9VVaQBPIx+ JkCwokGfYGe05Wj0H4xdsvb1UKASCyMxppoxG8uq2LWN8Gd+W0oGLX5nAYzIO0xUW4qi P9z8BPehQaQaFe2Gpr3PiOWCRoti8y8nmN0Ncvjs2LeSV4vPvLUkumPHqzwZhxnU+xwq mIMHUWSJZhCJAgTYhYQicc4xCOPgMsQS6+wGadhJsgP9Jgm0g9kDf+OFBbsuBWqjAMbR QkEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:dkim-signature; bh=ochM5m1KMB+5vlcxy5xlYUPq9FxXr2ho76d6PIZxYqg=; b=fj3eS2Rss/7Z+O2+3V8lEwnn9uHJcgCXWY3/sxLKEn28jv82MkjvDL38R5GK8Co2ms Mhxd0OfCmwkFR9nwDk16/Hy3Ug47EQPIw9iJltgv/YHw2vNhrvAef7O7Hf7FK+2fYqwC Kc/MOyFR/YE3utwvmG6oVg8V+pndfQZ69ib/e6gJRwpBcpabOqriOnGdH65D9KqbGcIW w+t4HlB4yVlyIl2Ig0gP0yX9a5E57HX8f3wY4PWVHOfrXQ31B43t94JPkEzjNlifOwdp LSBoQaip5exlWKGx+XUDunTD02puwGHmUTWqzb/h8yX1sgVNbZ6vWrIlu+elnFMIU08i Zw4Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=kwFxqb4I; spf=pass (google.com: domain of pakki001@umn.edu designates 134.84.196.205 as permitted sender) smtp.mailfrom=pakki001@umn.edu; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Received: from mta-p5.oit.umn.edu (mta-p5.oit.umn.edu. [134.84.196.205]) by mx.google.com with ESMTPS id 192si375431its.82.2018.12.26.11.08.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Dec 2018 11:08:02 -0800 (PST) Received-SPF: pass (google.com: domain of pakki001@umn.edu designates 134.84.196.205 as permitted sender) client-ip=134.84.196.205; Authentication-Results: mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=kwFxqb4I; spf=pass (google.com: domain of pakki001@umn.edu designates 134.84.196.205 as permitted sender) smtp.mailfrom=pakki001@umn.edu; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Received: from localhost (unknown [127.0.0.1]) by mta-p5.oit.umn.edu (Postfix) with ESMTP id 956E49CF for ; Wed, 26 Dec 2018 19:08:01 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p5.oit.umn.edu ([127.0.0.1]) by localhost (mta-p5.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JZfqyYiBj4sX for ; Wed, 26 Dec 2018 13:08:01 -0600 (CST) Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p5.oit.umn.edu (Postfix) with ESMTPS id 5E6A5A00 for ; Wed, 26 Dec 2018 13:08:01 -0600 (CST) Received: by mail-io1-f70.google.com with SMTP id r65so19857212iod.12 for ; Wed, 26 Dec 2018 11:08:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=ochM5m1KMB+5vlcxy5xlYUPq9FxXr2ho76d6PIZxYqg=; b=kwFxqb4I69HA5AqDxFsKEWBcg/NoeYcc/A8lJg2r9zy4NMy2L1FkP8j4BJvQe4Ffo3 e1l1vGEQwY1cpj1q2n7IRgxUhd2YpjW/yd6SQF4Joub9j2mACHS6z2exi8C/0K2IvF0P D1ePRXAzam0egWKLvO/SmgIgImmc6Pe6K/5tPCyBvh+gAzJtcZsZ2rbAJj526M/Bnl+3 hv6x6fOlG5RWSYgfkdgyqjPI9aVSOykfSa7n7p09NHL/OUA30PUKmPV9a0UobSSsfbEr GWEVaKl8Cu9wVsHpvMGDTE7wfpwPR05VfcuEpmwSe8zV6/Suyu1I3LoxdaP+sR7haCLw tGNQ== X-Received: by 2002:a6b:ee16:: with SMTP id i22mr13755738ioh.124.1545851280952; Wed, 26 Dec 2018 11:08:00 -0800 (PST) X-Received: by 2002:a6b:ee16:: with SMTP id i22mr13755727ioh.124.1545851280735; Wed, 26 Dec 2018 11:08:00 -0800 (PST) Received: from cs-u-syssec1.cs.umn.edu (cs-u-syssec1.cs.umn.edu. [134.84.121.78]) by smtp.gmail.com with ESMTPSA id r21sm13145399ita.27.2018.12.26.11.07.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 26 Dec 2018 11:08:00 -0800 (PST) From: Aditya Pakki To: pakki001@umn.edu Cc: kjlu@umn.edu, Andrew Morton , Vlastimil Babka , Michal Hocko , David Rientjes , Joonsoo Kim , Yang Shi , Johannes Weiner , Joe Perches , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm: compaction.c: Propagate return value upstream Date: Wed, 26 Dec 2018 13:07:49 -0600 Message-Id: <20181226190750.9820-1-pakki001@umn.edu> X-Mailer: git-send-email 2.17.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP In sysctl_extfrag_handler(), proc_dointvec_minmax() can return an error. The fix propagates the error upstream in case of failure. Signed-off-by: Aditya Pakki --- mm/compaction.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index 7c607479de4a..5703b4051796 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -1879,9 +1879,8 @@ int sysctl_compaction_handler(struct ctl_table *table, int write, int sysctl_extfrag_handler(struct ctl_table *table, int write, void __user *buffer, size_t *length, loff_t *ppos) { + return proc_dointvec_minmax(table, write, buffer, length, ppos); - - return 0; } #if defined(CONFIG_SYSFS) && defined(CONFIG_NUMA)