From patchwork Sun Jan 23 14:12:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 12720970 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FB4CC433F5 for ; Sun, 23 Jan 2022 14:20:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236724AbiAWOUW (ORCPT ); Sun, 23 Jan 2022 09:20:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49862 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236722AbiAWOUW (ORCPT ); Sun, 23 Jan 2022 09:20:22 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 411C7C06173B; Sun, 23 Jan 2022 06:20:22 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D4D1360C9B; Sun, 23 Jan 2022 14:20:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 987CDC340E2; Sun, 23 Jan 2022 14:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1642947621; bh=sPP73J14sFJ1BrFw8EftFhDZ6LJsU6ER5loSACvyBtQ=; h=From:To:Cc:Subject:Date:From; b=jCbKhn6d320AUbUEPCXhhjj8Z3b3TV9nET3CToXH9Tbja6BPdXmzbEca+a1yWx5po b2J2LfWrTphyL5/zBQ01js7LOnbgABtvmjPddfvDHj1D7lGUw1v5Ca5xLfIEn6fkeb eSn2nYVRvIhB00/5guw866QakBpzFXczU5HIQCjWxN8VV4MT4IIXgIgAEcfIJHOyfO ixCtFTh0ir2onzZN7i/UsGpp/Vq21VXjE09/Q/KN3d64aVIQiIQek05+xZk1OjZcK2 Ly9+8so5Y2WSAZaq+aMUhqYB/LrX2/4lCdEpfliXxjKLdRNz5XRZ2GcoHdYX/jfh/z PJ5Wi8Sj7/3ZQ== From: Jisheng Zhang To: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Jakub Kicinski , Maxime Coquelin Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: stmmac: don't stop RXC during LPI Date: Sun, 23 Jan 2022 22:12:45 +0800 Message-Id: <20220123141245.1060-1-jszhang@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org I met can't receive rx pkt issue with below steps: 0.plug in ethernet cable then boot normal and get ip from dhcp server 1.quickly hotplug out then hotplug in the ethernet cable 2.trigger the dhcp client to renew lease tcpdump shows that the request tx pkt is sent out successfully, but the mac can't receive the rx pkt. The issue can easily be reproduced on platforms with PHY_POLL external phy. If we don't allow the phy to stop the RXC during LPI, the issue is gone. I think it's unsafe to stop the RXC during LPI because the mac needs RXC clock to support RX logic. And the 2nd param clk_stop_enable of phy_init_eee() is a bool, so use false instead of 0. Signed-off-by: Jisheng Zhang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 6708ca2aa4f7..92a9b0b226b1 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -1162,7 +1162,7 @@ static void stmmac_mac_link_up(struct phylink_config *config, stmmac_mac_set(priv, priv->ioaddr, true); if (phy && priv->dma_cap.eee) { - priv->eee_active = phy_init_eee(phy, 1) >= 0; + priv->eee_active = phy_init_eee(phy, false) >= 0; priv->eee_enabled = stmmac_eee_init(priv); priv->tx_lpi_enabled = priv->eee_enabled; stmmac_set_eee_pls(priv, priv->hw, true);