From patchwork Tue Jan 25 06:04:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt Johnston X-Patchwork-Id: 12723312 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF7C5C433EF for ; Tue, 25 Jan 2022 06:18:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233223AbiAYGRt (ORCPT ); Tue, 25 Jan 2022 01:17:49 -0500 Received: from pi.codeconstruct.com.au ([203.29.241.158]:53270 "EHLO codeconstruct.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343996AbiAYGEY (ORCPT ); Tue, 25 Jan 2022 01:04:24 -0500 Received: by codeconstruct.com.au (Postfix, from userid 10001) id 9C7F0202F7; Tue, 25 Jan 2022 14:04:16 +0800 (AWST) From: Matt Johnston Cc: Kevin Darbyshire-Bryant , =?utf-8?q?Toke_H?= =?utf-8?q?=C3=B8iland-J=C3=B8rgensen?= , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, cake@lists.bufferbloat.net Subject: [PATCH net] sch_cake: diffserv8 CS1 should be bulk Date: Tue, 25 Jan 2022 14:04:10 +0800 Message-Id: <20220125060410.2691029-1-matt@codeconstruct.com.au> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The CS1 priority (index 0x08) was changed from 0 to 1 when LE (index 0x01) was added. This looks unintentional, it doesn't match the docs and CS1 shouldn't be the same tin as AF1x Signed-off-by: Matt Johnston Fixes: b8392808eb3f ("sch_cake: add RFC 8622 LE PHB support to CAKE diffserv handling") --- net/sched/sch_cake.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c index 857aaebd49f4..6ff2ddc5b812 100644 --- a/net/sched/sch_cake.c +++ b/net/sched/sch_cake.c @@ -313,7 +313,7 @@ static const u8 precedence[] = { static const u8 diffserv8[] = { 2, 0, 1, 2, 4, 2, 2, 2, - 1, 2, 1, 2, 1, 2, 1, 2, + 0, 2, 1, 2, 1, 2, 1, 2, 5, 2, 4, 2, 4, 2, 4, 2, 3, 2, 3, 2, 3, 2, 3, 2, 6, 2, 3, 2, 3, 2, 3, 2,