From patchwork Wed Jan 26 02:00:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Badhri Jagan Sridharan X-Patchwork-Id: 12724456 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA840C3525A for ; Wed, 26 Jan 2022 02:00:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236100AbiAZCA2 (ORCPT ); Tue, 25 Jan 2022 21:00:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236085AbiAZCAY (ORCPT ); Tue, 25 Jan 2022 21:00:24 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A5FDC061744 for ; Tue, 25 Jan 2022 18:00:24 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id a3-20020a056902056300b0061496fc6a45so30207341ybt.14 for ; Tue, 25 Jan 2022 18:00:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:message-id:mime-version:subject:from:to:cc; bh=kRF0DIpm+1X7TVEtpuLwufuaaYhaX1D4iAM/RZ5ifBU=; b=mZi6Fx2jqpQSFDEvYVLiX63ZP5KThUtDgI7rcawn3RPj10LWxDXuDPGG04yoak7F7e 1x/xB+OK8cjxUin+sBNf3JX50l3+WjkXkOuSvDnGZF/9zWte89txF/FeiD9/d9Y1saSy MG1iKLRDgT+vXjcfC46M2nRnqF+v7nn40d3eqiY1JrH3WdPfHQVWlEssP6NcZ/3S7bVN o8ZzZbRx8qXkJcVCMSj5OYKyca18XN0M9D9J4ZCDg+KIXqqifTcQxTeIcooJhM7smKdS CUGDTi36FCXS0fJuhq/NfG1406D0a17obNjgd6lOnriUhtSwqGE4pFmqtzLAIv+IHtOb wP5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=kRF0DIpm+1X7TVEtpuLwufuaaYhaX1D4iAM/RZ5ifBU=; b=DqOgb7AQ+NCYJYYLbeqqycOlI7M4ahe+XOi/DSdbl61XXDRyK6pdHQdGTH0ET5/mvQ lD6YS5pJdTH7FFxBy3ltUV+1h6mboKwpDNhq0S1+6Mb37E6kk7Xp52lGjt+ojOypBimg ej9IhdFXQyq0PAyLqIW5Ljs3i5PBQF9rASnW/b/i1y8MA3KsKPnqYSCC7DbApv6GSXkp BjQehjYXPqHfjwRpazNWZn+YvLA4HXkZ25ueNHYs/bUwCnWCmVG7e4LRNjVJihc3Su/C tvYR2RdmIQOFYJzO9eNYUcqEwwrFmiUTk+rtgzhBnwcWWr8j2GVcUwT88tq/w1LmTTWb c5dQ== X-Gm-Message-State: AOAM530AAQL/opwoypovgXHeNrBil0RW1E1zs4h1YZnFVExlZL4g4wo8 Ms4FlVQzRYIDMKTQCbOgwuVT55zHt0Q= X-Google-Smtp-Source: ABdhPJw8FNNdBVfZHXJw6ZBA6HllHOEcyV7zTLkyMLmy7dWR0e1lkE+Bc+w088c0EiTqQ7nAKsHZcQKslpg= X-Received: from badhri.mtv.corp.google.com ([2620:15c:211:201:f4a7:8e16:f301:160]) (user=badhri job=sendgmr) by 2002:a25:1f41:: with SMTP id f62mr32575122ybf.118.1643162422615; Tue, 25 Jan 2022 18:00:22 -0800 (PST) Date: Tue, 25 Jan 2022 18:00:15 -0800 Message-Id: <20220126020016.3159598-1-badhri@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.35.0.rc0.227.g00780c9af4-goog Subject: [PATCH v2 1/2] usb: typec: tcpm: Do not disconnect while receiving VBUS off From: Badhri Jagan Sridharan To: Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kyle Tso , stable@vger.kernel.org, Badhri Jagan Sridharan Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org With some chargers, vbus might momentarily raise above VSAFE5V and fall back to 0V before tcpm gets to read port->tcpc->get_vbus. This will report a VBUS off event causing TCPM to transition to SNK_UNATTACHED where it should be waiting in either SNK_ATTACH_WAIT or SNK_DEBOUNCED state. This patch makes TCPM avoid vbus off events while in SNK_ATTACH_WAIT or SNK_DEBOUNCED state. Stub from the spec: "4.5.2.2.4.2 Exiting from AttachWait.SNK State A Sink shall transition to Unattached.SNK when the state of both the CC1 and CC2 pins is SNK.Open for at least tPDDebounce. A DRP shall transition to Unattached.SRC when the state of both the CC1 and CC2 pins is SNK.Open for at least tPDDebounce." [23.194131] CC1: 0 -> 0, CC2: 0 -> 5 [state SNK_UNATTACHED, polarity 0, connected] [23.201777] state change SNK_UNATTACHED -> SNK_ATTACH_WAIT [rev3 NONE_AMS] [23.209949] pending state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED @ 170 ms [rev3 NONE_AMS] [23.300579] VBUS off [23.300668] state change SNK_ATTACH_WAIT -> SNK_UNATTACHED [rev3 NONE_AMS] [23.301014] VBUS VSAFE0V [23.301111] Start toggling Fixes: f0690a25a140b8 ("staging: typec: USB Type-C Port Manager (tcpm)") Cc: stable@vger.kernel.org Signed-off-by: Badhri Jagan Sridharan --- Changes since v1: - Fix typos stated by Guenter Roeck. --- drivers/usb/typec/tcpm/tcpm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index 59d4fa2443f2..3bf79f52bd34 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -5156,7 +5156,8 @@ static void _tcpm_pd_vbus_off(struct tcpm_port *port) case SNK_TRYWAIT_DEBOUNCE: break; case SNK_ATTACH_WAIT: - tcpm_set_state(port, SNK_UNATTACHED, 0); + case SNK_DEBOUNCED: + /* Do nothing, as TCPM is still waiting for vbus to reach VSAFE5V to connect */ break; case SNK_NEGOTIATE_CAPABILITIES: From patchwork Wed Jan 26 02:00:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Badhri Jagan Sridharan X-Patchwork-Id: 12724457 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E200EC63686 for ; Wed, 26 Jan 2022 02:00:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236102AbiAZCAa (ORCPT ); Tue, 25 Jan 2022 21:00:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236096AbiAZCA1 (ORCPT ); Tue, 25 Jan 2022 21:00:27 -0500 Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2A90C061747 for ; Tue, 25 Jan 2022 18:00:26 -0800 (PST) Received: by mail-yb1-xb49.google.com with SMTP id 2-20020a251302000000b006118f867dadso45366845ybt.12 for ; Tue, 25 Jan 2022 18:00:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=3UM8XKgMP3gqCK4oj/W0i074FevQzm4B+XlHTOgS0D0=; b=WCiqjcBOHA+dIeeTBnO8nVQSTbQsxMynZTM63mWgD7T1OssP7X752BVLCM3hrgzU/b 5Vnnd4fiQMmxOAjhDmjxsGFXoEyac5/ML3FKVUgybDLVS7OFze4gfDm/ipObvE+cneaf 8sIceVls3jSrRfom021ipI2HFYsBMw/+vHlkf/1qDaZsetp7xpmEJTHMmbeLriQVW6ub mMVFYefqoNMvJdgkMHyK4tDR7OAA6zJvl0l/F9s2oTqeUtYGgXTj68p7CYA12SHjDXCP KVUxmTW3l12r2ecYkfLFnqFczFrDTov1CQ09J9YYmrbWe9ILdXN8oYVavU04/n4prZkQ rU/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=3UM8XKgMP3gqCK4oj/W0i074FevQzm4B+XlHTOgS0D0=; b=rTO+od2K6C8PWx7hTAAj5LcHoStjzEG/GMut9ATadCnBjUChDz3aVJWCAyi7kTg8NS riM1jPixSr7wzOR4qgTKqfXPTdFx06tXGUaMLCrRLowq/xHKmzgMXjxD2g3g9ZsDiHyV xnFiiH8q0ZQjca5JCmOowR32yJgtzEntNANk+F3gkxcWMQnDwjIcGLBuh5SgU1uEtorf 9z0e2Xz++sFSEtAyndBeWt2yYXWOBP0g1FeHM6qTj/f6HJBhWdoRgau5BXPJFWDWLpdC GcrpYNqxdd5fkUbRCtmD1WfP1+5jBskTBpUo/CBke2hvO0UVJ4GhRuYFGpqZFR6QaZQi aD9Q== X-Gm-Message-State: AOAM533GvPgicQdYPt/wGReCtoNET2zFlmpbYWkCqCB6JkPmeS3Ho5jJ 6+bmyZ21mAPbkx3nCZ6dTGywlF6zk1w= X-Google-Smtp-Source: ABdhPJyoVZnqQZBLsKxf6oSHvLwmIBoEVumXM0KPtMB0Vm9hcHCgmRPvIETN8lhxhNoUJh6jiYCCVFd+4YQ= X-Received: from badhri.mtv.corp.google.com ([2620:15c:211:201:f4a7:8e16:f301:160]) (user=badhri job=sendgmr) by 2002:a25:b9d2:: with SMTP id y18mr34554948ybj.615.1643162426054; Tue, 25 Jan 2022 18:00:26 -0800 (PST) Date: Tue, 25 Jan 2022 18:00:16 -0800 In-Reply-To: <20220126020016.3159598-1-badhri@google.com> Message-Id: <20220126020016.3159598-2-badhri@google.com> Mime-Version: 1.0 References: <20220126020016.3159598-1-badhri@google.com> X-Mailer: git-send-email 2.35.0.rc0.227.g00780c9af4-goog Subject: [PATCH v2 2/2] usb: typec: tcpm: Do not disconnect when receiving VSAFE0V From: Badhri Jagan Sridharan To: Guenter Roeck , Heikki Krogerus , Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Kyle Tso , stable@vger.kernel.org, Badhri Jagan Sridharan Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org With some chargers, vbus might momentarily raise above VSAFE5V and fall back to 0V causing VSAFE0V to be triggered. This will report a VBUS off event causing TCPM to transition to SNK_UNATTACHED state where it should be waiting in either SNK_ATTACH_WAIT or SNK_DEBOUNCED state. This patch makes TCPM avoid VSAFE0V events while in SNK_ATTACH_WAIT or SNK_DEBOUNCED state. Stub from the spec: "4.5.2.2.4.2 Exiting from AttachWait.SNK State A Sink shall transition to Unattached.SNK when the state of both the CC1 and CC2 pins is SNK.Open for at least tPDDebounce. A DRP shall transition to Unattached.SRC when the state of both the CC1 and CC2 pins is SNK.Open for at least tPDDebounce." [23.194131] CC1: 0 -> 0, CC2: 0 -> 5 [state SNK_UNATTACHED, polarity 0, connected] [23.201777] state change SNK_UNATTACHED -> SNK_ATTACH_WAIT [rev3 NONE_AMS] [23.209949] pending state change SNK_ATTACH_WAIT -> SNK_DEBOUNCED @ 170 ms [rev3 NONE_AMS] [23.300579] VBUS off [23.300668] state change SNK_ATTACH_WAIT -> SNK_UNATTACHED [rev3 NONE_AMS] [23.301014] VBUS VSAFE0V [23.301111] Start toggling Fixes: f0690a25a140b8 ("staging: typec: USB Type-C Port Manager (tcpm)") Cc: stable@vger.kernel.org Signed-off-by: Badhri Jagan Sridharan --- Changes since v1: - Fix typos stated by Guenter Roeck. --- drivers/usb/typec/tcpm/tcpm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c index 3bf79f52bd34..0e0985355a14 100644 --- a/drivers/usb/typec/tcpm/tcpm.c +++ b/drivers/usb/typec/tcpm/tcpm.c @@ -5264,6 +5264,10 @@ static void _tcpm_pd_vbus_vsafe0v(struct tcpm_port *port) case PR_SWAP_SNK_SRC_SOURCE_ON: /* Do nothing, vsafe0v is expected during transition */ break; + case SNK_ATTACH_WAIT: + case SNK_DEBOUNCED: + /* Do nothing, still waiting for VSAFE5V to connect */ + break; default: if (port->pwr_role == TYPEC_SINK && port->auto_vbus_discharge_enabled) tcpm_set_state(port, SNK_UNATTACHED, 0);