From patchwork Thu Jan 27 17:34:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Hancock X-Patchwork-Id: 12727143 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8856AC4332F for ; Thu, 27 Jan 2022 17:36:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244675AbiA0RgC (ORCPT ); Thu, 27 Jan 2022 12:36:02 -0500 Received: from mx0d-0054df01.pphosted.com ([67.231.150.19]:7622 "EHLO mx0d-0054df01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236618AbiA0RgB (ORCPT ); Thu, 27 Jan 2022 12:36:01 -0500 Received: from pps.filterd (m0209000.ppops.net [127.0.0.1]) by mx0c-0054df01.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20RCOsjW001451; Thu, 27 Jan 2022 12:35:48 -0500 Received: from can01-qb1-obe.outbound.protection.outlook.com (mail-qb1can01lp2053.outbound.protection.outlook.com [104.47.60.53]) by mx0c-0054df01.pphosted.com (PPS) with ESMTPS id 3duu31r74n-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jan 2022 12:35:47 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XnpR+M3lZBiB9dLK+4v/FZl2n3T5QCu74NLVBb4BmSweLu4D4WRs+/ahjwqH8tdz4E89rMMN0yCS/x3N0RPRh9GxIJ0XRdCcuQkjK1DGzhpxtUFFrl9jQD8/Mabyma3k2cIEPW/v4ZZlajzrOl/9P0aAPYAgI8zrSPOJ7K2x9GynaOK2EhsMNarag1O6/hdiDAellhz65iRf+G5VzzoulG9RjMOwEKeOk+XPfhxNYeF1JHBNInk4EUkrbsV93ArSxNSBVNvD9k9mXZuHmVOrs8ZAZD0k3wjnNbamstxxQDbsYcrjzjmqlNJQtaV66MWSn5zPnBnm41+/Ap2vm2EelQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IcsjyxWh/DTTaKXBl2LFs2VaWIoIILa84jHZaP7Mfps=; b=GARBXxSBOq4ql9hMYdyGCBOohZQh1GifujHXZnOWs9YRMAKHUMD137Qoaj78t8cMOLdo1pPthXDPUsrkZPMXJ/SELPU5FJJJJlbDGGs3NnO105tK7kgNO33En36EqMizvJofDKy8nk3v4TcKK5ZqOJxF28neJePvtcwouFOh8OG/mF4mmGm/OT+N8Q6ogesyBW/HDOPmZO73YGtikKR5mXuXCwUyWIevbMrR1weGDEotXfUrfiEtVFF19VOwb4Ei/ujKs+eVstzPEX7cvF1o9gflf5GY4NRG9xfmEVrLw4fyTRl+XVQY/L2uHz4X523/F5d8M5wDb6513tscjjMuGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=calian.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IcsjyxWh/DTTaKXBl2LFs2VaWIoIILa84jHZaP7Mfps=; b=B7cL9X6ArUYu+BzhPVCqbWw7amQuaQfFJYrntIL/nuiH5XPDiLMm5UblBgwINU80vC/Om9t5WgVEGj2b9dTTZlwwlNGnuHhHWJBaa3r4hwOrwfg0TL971AvRpzV+mUSTlYJKpUzQhEmxcLFNYL+8yFtHDrJx4CNVu5TxTfbHetc= Received: from YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:6a::19) by YT2PR01MB9665.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:df::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Thu, 27 Jan 2022 17:35:47 +0000 Received: from YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM ([fe80::6929:c39f:d893:b6c8]) by YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM ([fe80::6929:c39f:d893:b6c8%2]) with mapi id 15.20.4888.020; Thu, 27 Jan 2022 17:35:47 +0000 From: Robert Hancock To: linux-iio@vger.kernel.org Cc: anand.ashok.dumbre@xilinx.com, jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org, michal.simek@xilinx.com, manish.narani@xilinx.com, devicetree@vger.kernel.org, Robert Hancock Subject: [PATCH v2 1/4] dt-bindings: iio: adc: zynqmp_ams: Add clock entry Date: Thu, 27 Jan 2022 11:34:47 -0600 Message-Id: <20220127173450.3684318-2-robert.hancock@calian.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220127173450.3684318-1-robert.hancock@calian.com> References: <20220127173450.3684318-1-robert.hancock@calian.com> X-ClientProxiedBy: CH0PR08CA0011.namprd08.prod.outlook.com (2603:10b6:610:33::16) To YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:6a::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: be077b24-29bd-4a49-5881-08d9e1bb7402 X-MS-TrafficTypeDiagnostic: YT2PR01MB9665:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2512; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: j1L/Ig7WcVZhMKUtXVlmhA8TIwqsv5GGaYdKkMHjC50OXQ01DdaMZphS6iRQ/rqDDYIGijPZyaIvfNGAZA8wq/0+qKPOkHmetWmPX4J9C4dCNQWgzMFVNFNEtZyOHoFqLWMdlDiuB4gus4xum5X1JrCD/ot1AdQ+Cdm1qaZUxyjR4b8QN6VF2tyYQ8YOD3xknVT+b3uS8AJZfCaRz13GQTFVjMYKFRd5f4Xd4JeJ0odnxhmYAXeTsjSSbN0xelReYUk5Q3fLTrbNmAWj6dS6jAbqwQ7++dr3GyRJDXc01akC44RIE26M1fRu4r4REW9E/InYRodWmtFlerJ8qKXVBqPOJU/VTPhd3uYSJyowfK8Mu8MBeIr7d3rwKXlvVcDKTMyE2/1O57FhEUR2Djf3bZkaDBg17j9sf1VCduAw8jVbQytYksf9SNUlmmF0edkDJQwC/OLIZNMdIpA9NQ9q/dCDatgWCUFar3k8+thHTi4rbBM6uqWHVhgx4J/VSYvE9mSiYuvSpoMu1LG+10RQT9yDlpM8fJyzYW//6nKW8sciTah55DRgR6IjjfqiP5/fjxJ/M9wryV25C8wd+e1EzE9yU1zUJkCuUKwKkBZf6Arlff+EKlO/wLDgZnB+VhVOMBVQF1yjvqT3tUYIXd3uSt363zPC5l8/HjH3sdn3ZNyb5qohRyqab6X+ubCvAglQH9bEx2DlOggJrPju3E+OFw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(8676002)(86362001)(4326008)(6486002)(66946007)(66476007)(8936002)(44832011)(6916009)(5660300002)(2906002)(107886003)(26005)(6512007)(1076003)(186003)(2616005)(52116002)(316002)(36756003)(38100700002)(6506007)(38350700002)(508600001)(83380400001)(20210929001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: fU1rooAhkOdbWpvKqFXzcdvcTdnSmahW03HvFB4aQp1VveAqgsiWLxR+1lFClQQcs8xAJxyidG5XkmoZ7zZgtJ3dRxuziU6n5ce/UIeHKZhtXdGiEWMbe8Sv8gkyWJcjSHc8fiHSUPtS9YaQUPDhkmoi8QOj4hDHXsJ6yck9lNJz6ql9frpi0wU9SoIe3HGFMfF9Z5NPGMKTZLcW3PB1HPftbAvpnh9wDPVNR/6BzaW1fsUTlpIPH5zpxDy1EaqsMDqQd/Gtxob0BmmANF1zQvW1JiTTeh4uneu3UXh6cKeGMBQJQF/Lxn+wQ5VjyN3tgSG8q3DLflp93fhCfC+vwSxxH686bXFDgZy7GF1bOsg/fPv0AGb59RlcPzl7fMfjQwZRhWimjXDFBY18R476RA2LYTkzAtrFexCaPAfiv9Df+PkOnkbo1vnxSqb2kba2ZXlgDc9aul+8gGnvL1pURYApQ5nAeEvCosihy6vT38G9uLrFDbieokPbz7hCcjYTHJZ8rh1IU5DgCRKaBGFYGrF/O21BqNVOsaPtCqvZ5nsdKxwbZviniOOR4evC8VY5SvYYXw/EWh4+uG3OYVh/+9S5WDeXT42z3FZkpDQlUsvTVbNnZgOSecoZXAaELwvt++ia+XpqFgYxjhoiwpr+LhquUxOumNX4/GIWHAgUelfJQ8NhragcCSgh/cxGuArNAVahxMIPgGvRAMjYWPwhCLUgsdrU9acee7Jf9yn7ye2jXGOOrmLn7i7mjZb9J+noHM0/KPTccTstS8BlqjavEzP6bqLcX6Du9o4GbRCG//PIX9tj3aZgzqb7WrQKNVHqWXpB0nuH5b2dTBDF+EVaY9BbLiW+L6dy0d+E1kOeylzDaJWHJWAufFRNDfu4MM40lxOOLFk2oWM7ash5m9au97TKNfWj1UJIY0ZiSsldl//grllQkIL3yQUg4pEFUECFyOUxe9EatSSofz2TjrsZcxMxC4v585qsoz9cV9nRN/7vWRcL5IKB7OdzJb9t5wRcZQmr0zJQz9c9pJU5zTHFhHJJsc41P1WoPNPXinjM9FlCHeIoIULxTNyUg3KrvHmagKtFXQqOJYd/89WHpsteRAVq1ebUy+H+bm/u/DmB5Ce/phNISHCST7xNqDatmm2vE9aI58AHePRIawEJsZlS7adtf69nDzyTp32Tr4/aj/9ynxLSk5UBu3XNarbxyqf82LNwCXtTncD5nFVEoMnbRT8CTx2D525LZN2QZVnrb4l+PetzdSHLjnUm6ZfiW2Xlh+VmSEfnceH7cTdPwgDnX31/hJNHoEjbHr9eu2RGOA2g3aumgMFju5K3w7wIkMPH9OLXOhKrUHQZ2CIXmBDJdrutnbt0FyF+yCM3CI99n+v/99QVlcaXYZH5ZsXAmMiS75HxjaGg7W4wm9SDIgQSLF8lfE9bXmO3MOvuNmDCHVoicC6qsGspbP1skX2NOVKQvh2QFmyvwE1TSDIJpBeSwUYVHP3XIarZl2oIQolBwC0kH2WLq3aEq8sJLMUOsAxGraRVnEEy/pputXf1nxo+0uw7ZcVesSOXCboBvOpPigQLoYxmYqal3dM57uqGsdnrd8873eodnh8W2gm9Tl5IqKzRyA+kAuGbMr8ll3+08VbG7U3HbXTcdVSgFEtuhJfGxeyZ4G79NtEPhjZDXGIg5UWDuJLBCWdYZfi25zlJuOA= X-OriginatorOrg: calian.com X-MS-Exchange-CrossTenant-Network-Message-Id: be077b24-29bd-4a49-5881-08d9e1bb7402 X-MS-Exchange-CrossTenant-AuthSource: YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2022 17:35:47.2330 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 23b57807-562f-49ad-92c4-3bb0f07a1fdf X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sXwVQIV5hbOm80BLSoVUDEZPOqa/xjl7TYDOoPrPLZ0FKcb9JmIpe9jDOzIYHedP7QFVDiuD6ZX/M/GvNzKNC083DZJ3m9uD4JDKj7vJTNA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT2PR01MB9665 X-Proofpoint-ORIG-GUID: NuuTzdrnnvgwbG6n_7BuLR7TsHW2aHWz X-Proofpoint-GUID: NuuTzdrnnvgwbG6n_7BuLR7TsHW2aHWz X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-27_03,2022-01-27_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 phishscore=0 spamscore=0 adultscore=0 priorityscore=1501 bulkscore=0 clxscore=1015 mlxscore=0 lowpriorityscore=0 mlxlogscore=676 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2201270102 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org The AMS driver DT binding was missing the clock entry, which is actually mandatory according to the driver implementation. Add this in. Fixes: 39dd2d1e251d ("dt-bindings: iio: adc: Add Xilinx AMS binding documentation") Signed-off-by: Robert Hancock Reviewed-by: Rob Herring --- .../devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml b/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml index 87992db389b2..3698b4b0900f 100644 --- a/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml +++ b/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml @@ -92,6 +92,10 @@ properties: description: AMS Controller register space maxItems: 1 + clocks: + items: + - description: AMS reference clock + ranges: description: Maps the child address space for PS and/or PL. @@ -181,12 +185,15 @@ properties: required: - compatible - reg + - clocks - ranges additionalProperties: false examples: - | + #include + bus { #address-cells = <2>; #size-cells = <2>; @@ -196,6 +203,7 @@ examples: interrupt-parent = <&gic>; interrupts = <0 56 4>; reg = <0x0 0xffa50000 0x0 0x800>; + clocks = <&zynqmp_clk AMS_REF>; #address-cells = <1>; #size-cells = <1>; #io-channel-cells = <1>; From patchwork Thu Jan 27 17:34:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Hancock X-Patchwork-Id: 12727146 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 013B6C433EF for ; Thu, 27 Jan 2022 17:36:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244679AbiA0RgL (ORCPT ); Thu, 27 Jan 2022 12:36:11 -0500 Received: from mx0c-0054df01.pphosted.com ([67.231.159.91]:13689 "EHLO mx0c-0054df01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244676AbiA0RgK (ORCPT ); Thu, 27 Jan 2022 12:36:10 -0500 Received: from pps.filterd (m0208999.ppops.net [127.0.0.1]) by mx0c-0054df01.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20RCIlZM006794; Thu, 27 Jan 2022 12:35:49 -0500 Received: from can01-qb1-obe.outbound.protection.outlook.com (mail-qb1can01lp2054.outbound.protection.outlook.com [104.47.60.54]) by mx0c-0054df01.pphosted.com (PPS) with ESMTPS id 3duu8kr833-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jan 2022 12:35:49 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BS6gl7Kogu6oBqXjm+opL3yoJJWXhXXtWdPr9j8xFKQFRTzjS0q/aTE8zrFYUq9s7M5GD31I2n26nLwsQZp+YkeBrALJIA5B2EqEWHFLRkeV69Ep5tdMgTGxEqlDENdlW2u7p4AxgGNCrRQft0wPh2nngLBzvZGa/+BJgEsMzQxfTUUdIK3SmQmvWYEeqyPvAMJ11HqroUt8iBXiSO7stbnCMaf7l7OL22rwWvchpwZFlwPWXB7QaFKi6qcMZ8Eu8rdodqNQykZfojgcrlURnpndyeeSaEDwfb26qVkSZJwRET0vAkoDJK7PUzy05Rg6cUWfBrpXNZ0hmcIR7gs61A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wL/iR3YAGsAgTqsClA4N74Dqd0pPKnvY+nPWyO8YLfo=; b=Q+WUznyemZ9wsH2/yGkmdGThhV7Dcfi3wI3zs5rJ28Nd8hVefl4YrWJaxOi5bbS0X+TJY+J9LEeMCdSyWLNlgEJTBukUuc7aT0nKUdFXuhuBno/FeXN7TT97FdwCKXdJIYbAk/JXy3koH+2vEe7S+OSA9FYbPwq4IMJzA24lBRomecKh2wDWdnBpfOif73hHdUQYBSCfZeZ3RBMZPxS88fpfBRQtXyLR/UyXl1xC2hYCDILxCcFh2eN5CrehJ1Tpn3Jz2CHacUDrNP06CJaH3vT6ec6RFZbCq7RAb3jZTwVcXY9Kusr9KPX0jlqp1Qs36CdgB6F6KKuX2hF994j75A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=calian.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wL/iR3YAGsAgTqsClA4N74Dqd0pPKnvY+nPWyO8YLfo=; b=vDepCbGVYu4TPh13YYVJYJMcCKFQeNYmQ+v0t9cmxa0VWJEcWO9dHFO34UUpp2AVDqCygm7sLKSQTQTmAL4HMyPLW1ZFyeI7igqcwC0QmbRIUulAhjueYxnsV3zD/AwA9l2K7uZHeynr8m0J0YOTB9f2z//SJgI0UcIaq4Dagg8= Received: from YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:6a::19) by YT2PR01MB9665.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:df::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Thu, 27 Jan 2022 17:35:48 +0000 Received: from YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM ([fe80::6929:c39f:d893:b6c8]) by YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM ([fe80::6929:c39f:d893:b6c8%2]) with mapi id 15.20.4888.020; Thu, 27 Jan 2022 17:35:48 +0000 From: Robert Hancock To: linux-iio@vger.kernel.org Cc: anand.ashok.dumbre@xilinx.com, jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org, michal.simek@xilinx.com, manish.narani@xilinx.com, devicetree@vger.kernel.org, Robert Hancock , Michael Tretter Subject: [PATCH v2 2/4] iio: adc: xilinx-ams: Fixed missing PS channels Date: Thu, 27 Jan 2022 11:34:48 -0600 Message-Id: <20220127173450.3684318-3-robert.hancock@calian.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220127173450.3684318-1-robert.hancock@calian.com> References: <20220127173450.3684318-1-robert.hancock@calian.com> X-ClientProxiedBy: CH0PR08CA0011.namprd08.prod.outlook.com (2603:10b6:610:33::16) To YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:6a::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a2eae544-21bf-4f73-536c-08d9e1bb749d X-MS-TrafficTypeDiagnostic: YT2PR01MB9665:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6108; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UdheU+BhwlfDfLaWOzEoS+aEy9ggQgiqb+wJ+GtKawdG3+HVbWgyjLknieiO9aphXSOBCxtS8w4ZKjsjqVT4a/pii+zji7g7Uy8uZ4fvG0rf7VJ7eEsnuRohIWDcnqmXstbFMdr831+gK1sG2zTwEBEd0hHRfJX1lhYXeq8bkWz2p1ZRzDYIDwOiMjp4eQYs7/G2Sq0x9IJPubSGCzm2NZAcRLAG4EA5DGGtZ46y5ZVUtLpL624MekNK875jUPuhXYKammFVkOWN5p79RN8o3cG5on6a0BVtUu86GQqHoJI0wQ2p07ps8aGsx7xru0hfoyL2kh3EgH7TreWdE6dKdetT3llgbRCv/FNKZ8NSXNiXINxDwkbrR6iQVYjzBDLv+ufQ+3pmoz6eyfr+GI48NE1desI2OUaE33dIQZ2ROCfj0PPyb8IPsjxMIAgrXNKYj0vhQizZd4RDuMHJ9jH35Hsw7EeZQFw7BfHcDt5qNI+5b7LNUJIEd0sU83b/F+egiGp7h6CHzpILYKAzA31ie3oWATLSBB4npYHSzH6SOBw/BYnKNmsNthvNkfh3wpIjpYgT96sg42jraOt2NuUnmACUBNjz5rdjY6HaHHciYZgUsPtCtUGQOe+Jplkl+LbvpT7iN8nLmCxNTS+c6pyK7IFJgY9k5pW60JUanjxcxhPROtvb0CUw8HfqkegUasy/0wtVN/p2NGp8+0rNE5ujGA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(8676002)(86362001)(4326008)(6486002)(66946007)(66476007)(8936002)(4744005)(44832011)(6916009)(5660300002)(2906002)(26005)(6512007)(54906003)(1076003)(186003)(2616005)(52116002)(316002)(36756003)(38100700002)(6506007)(38350700002)(508600001)(20210929001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: AmsfCu3i4P0MqyUKVXuK/G4G7TI3FqbV174qvNNHlA9EDWRkhGEFDJBmDwmHLsZchunPKlDIDLcyb31UXn4r0NHrsnJ3QbrSaPfNpXMyZK9ka+w7JvmvhQhj26UrGyA+P7YFf3VQcZ8SSlNentwvzj4/QxA3uCZAd51xuXh9bo9ImrocvJXcqGhi3P9DrPzKXZR+VKxPiWrafkG6/Cnw1+yYieXfVSrMg7UNfZbtyVx8Y1rwD04KWtPv4BLVvzfzGnqGs5DAN1WaQIMXa8pf2qhsNfACo1zYjGUdtdUqeOPKcBnfrQqkSI979hm0OmQIVz32tLx21RDmRVpzvmqJvzH/2eIM+n4ec8nVocUGlQ3j/JPtXHzRPTeMEHVaFnQIoOtdwfL/dLDJdcOUzLS00xCsOij8dEg3IY2mTez0Z/RnLoi2EQZmp1ZTauDJCqTc4QMqxr8M1Nso8m5y0Y7uuIzKK1Qj10RntLsd/AeJzRj+Aex9/KWFdyRNC/7S9wlDQL+l2GJTYEgIXMta55JrkpRYU4qHngAnHOkt1RhaoYLvV0+4zdNvsEl5ZIgK7CYXR5FfKzYzz4FaGE8BYbgIanEKx5OINhZIPaKQCyMfM/Xa9SryDlwITLd6VfkUZCS3p3bsjwbYASxsV5LsvYGja94AKKevnSouNJ6OmXnaD41aZ4eZJxHC4rwsiCYgDl0Uoo2z9wDeN4BaNvark2CGYwlYkD8sT8CKJ+GO9k18i10vSzxXHUsCIIE2ZmM9iSuUs08OHnl44kcEeZQFpaKb9666KhKjsvdGXGbqgRS6QOX20aQkVxc49soEBU2zJ3WpJIwaZ4H3UB3JJaL/aRMtWNuGqbt5j5w28L7C+gwJFG/oZKJuNZvkndCJ5dQu+jduretwSJLw3KhniX2/k2Ft73KeDqj2RtpxdrvMxss2TdG9s/TIc46kyVZ8Ikl64yBmViYZzPDAICKJtrr0Zcvmx0AYpaBh2VhtTSOD8+hvAwtjy4Aq08T38dvFaNpvreEFPFYackw9XS44EkxlIu9JVPgl9KqxR4Tmtj06DTpuKUlxnlK6LlammkEyOWiFwuoMYwl8jFru4CYYS5WnVGeo9x6w7sqeKZ0o6JaGh72WmVkBRYanJnrMFRms9e8tAzgJxAlHRdZPJJkDvbXqztbXuOTuC0iwORRmZLZBFXjqUqylGcsHL8KolOKPpjn/SpYs6Vbjce1jA31T7a3SUGILy5xqSvey7JQzpuV6QigtjBxkqK5zMLGkYZznrl7DOfMV0CRNbdIbD3ayKhL7+TWRRfoFLJJW3sKDUZIbHQyQXFkP1POGibTSahd52Rh2ib0EUyxSh+zWOcucq4OmhUUU4xsyswjuIN0En1WvqIXtlIvCo//YqvY62hQ4e1rhv31j4KShMS4DKjBjj7SZoVRb55ejFao30j8mG4h7SdVlusX6TnJdUXfffJijhPnTZXzJedVkQ8R00Vl0lDzLNLpGscXRylWFC0HnBh9hS0CZ84L+uSyho3aXEs0Lf1TkUMZnFwuwTs3UQwR/chNUTl7ZCm/8agVYe7hzhXA7vPknhsF7Wdy+y4vh3CGa+TPutaOdC9qcgHwzZv8p8944Rypf+Wzxo67MAJvtxeKjb0RnL6/dYGsHhOixpaRP1rBl0ou4Sg9d5RjKlMC9sDJFPNv8pUP0yNOmJ27EnHvWOT+4V60= X-OriginatorOrg: calian.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2eae544-21bf-4f73-536c-08d9e1bb749d X-MS-Exchange-CrossTenant-AuthSource: YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2022 17:35:48.2487 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 23b57807-562f-49ad-92c4-3bb0f07a1fdf X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6fvz9iUGPqQdRQnn6DHcnYQwrLr2r3/uNoGH8+tvTVwIom0VujRM5KadzwM10Jjv8Vsojf/iW0TPWnteqdVNJGbNnb3krN/WWNfsuNxrHvE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT2PR01MB9665 X-Proofpoint-GUID: o8Sj35fI0SmZY4ofcUsXqlf4Wx6E2L7U X-Proofpoint-ORIG-GUID: o8Sj35fI0SmZY4ofcUsXqlf4Wx6E2L7U X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-27_03,2022-01-27_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 bulkscore=0 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=736 malwarescore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2201270102 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org The code forgot to increment num_channels for the PS channel inputs, resulting in them not being enabled as they should. Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver") Signed-off-by: Robert Hancock Reviewed-by: Michael Tretter --- drivers/iio/adc/xilinx-ams.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c index 8343c5f74121..b93864362dac 100644 --- a/drivers/iio/adc/xilinx-ams.c +++ b/drivers/iio/adc/xilinx-ams.c @@ -1224,6 +1224,7 @@ static int ams_init_module(struct iio_dev *indio_dev, /* add PS channels to iio device channels */ memcpy(channels, ams_ps_channels, sizeof(ams_ps_channels)); + num_channels = ARRAY_SIZE(ams_ps_channels); } else if (fwnode_property_match_string(fwnode, "compatible", "xlnx,zynqmp-ams-pl") == 0) { ams->pl_base = fwnode_iomap(fwnode, 0); From patchwork Thu Jan 27 17:34:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Hancock X-Patchwork-Id: 12727145 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 018A1C4332F for ; Thu, 27 Jan 2022 17:36:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244677AbiA0RgJ (ORCPT ); Thu, 27 Jan 2022 12:36:09 -0500 Received: from mx0c-0054df01.pphosted.com ([67.231.159.91]:8812 "EHLO mx0c-0054df01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234612AbiA0RgI (ORCPT ); Thu, 27 Jan 2022 12:36:08 -0500 Received: from pps.filterd (m0208999.ppops.net [127.0.0.1]) by mx0c-0054df01.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20RCIlZN006794; Thu, 27 Jan 2022 12:35:50 -0500 Received: from can01-qb1-obe.outbound.protection.outlook.com (mail-qb1can01lp2054.outbound.protection.outlook.com [104.47.60.54]) by mx0c-0054df01.pphosted.com (PPS) with ESMTPS id 3duu8kr833-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jan 2022 12:35:49 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oV6CRc6CPdOJFtR5tp2ZgJUmOFWPuLU/Kxsvu+Sfh8TxnQNcPy3wD9X2AwmTHGxcbvZE27Zio+laoqQwqAzoB8VqVGwaQW2vatKC5Bgf07hW4koYKLSQ6VZe4b25RyPhMPYIi5hIwOBdJuzxgfFOSNmqHkrnHUO56xGjzEZCa6vvxV7KvZcvMpKXHWpbWVw/gZPuFwEFLPQbT6QUl2s8AiNZKBaKwXvrV44sc/riCiSpmWQ5LExwgUnZUTNEk1N3RqAKF6tSplVntjY7sGu/HaqBzbI5V5cmDQYWYNQyh8fxFksLvBkQBhk3YeoJd6QIusJBhVGMzNFpP6kOkipA2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/y8PISiJe/1qCQcj7yBIw4ZGWQZNokP3+Y0ppb1EQ7E=; b=CsEW18Dc9h62Lil/BX+WaiEDbStvgSQiaqrha0DLLClqRgsrPng2wzeqaD7x1JxODlM5F0UDEVw6zY+33o6f3JVNcqx+bucdVrKxJeG566WxwOH5szTQFghiRP4yvfeFqkZ2GW0AYu6/9yVx2KtmFgszZF9LjGEdTaC23OWyuKSG/+SKUpiS4pCNPG1xd9PN6DlYWH1LZN4HxVrHML6YPFrxzVhuknrpHjgu88/RxcR35NKBoCZHqun3uaGkMpb5Cxzz/mwwQP0F48o9ZvV8hFA6u99ax8o8eJPAjpc2hmhUcDVMMos+eRUlNHD0zCyMEdztmKMstZKpf4z3s2rBmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=calian.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/y8PISiJe/1qCQcj7yBIw4ZGWQZNokP3+Y0ppb1EQ7E=; b=WuFep9spPCDqxko82a4SC9dVmg/ZmZz4TJN1ZHHnUliBOA54FpEfCdPMGX5kmYvz31xyoLFG93PZ9l1ThTZxTaaOALl3dAdIIVjciWHIDFJ0ReGRu3+HsOYbbiN/hdWMLlis1XqEpGCa1iN/1f/27jyy+ZcN08qdZfp7iWZYzI0= Received: from YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:6a::19) by YT2PR01MB9665.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:df::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Thu, 27 Jan 2022 17:35:49 +0000 Received: from YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM ([fe80::6929:c39f:d893:b6c8]) by YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM ([fe80::6929:c39f:d893:b6c8%2]) with mapi id 15.20.4888.020; Thu, 27 Jan 2022 17:35:49 +0000 From: Robert Hancock To: linux-iio@vger.kernel.org Cc: anand.ashok.dumbre@xilinx.com, jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org, michal.simek@xilinx.com, manish.narani@xilinx.com, devicetree@vger.kernel.org, Robert Hancock , Michael Tretter Subject: [PATCH v2 3/4] iio: adc: xilinx-ams: Fixed wrong sequencer register settings Date: Thu, 27 Jan 2022 11:34:49 -0600 Message-Id: <20220127173450.3684318-4-robert.hancock@calian.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220127173450.3684318-1-robert.hancock@calian.com> References: <20220127173450.3684318-1-robert.hancock@calian.com> X-ClientProxiedBy: CH0PR08CA0011.namprd08.prod.outlook.com (2603:10b6:610:33::16) To YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:6a::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 592d5953-ee83-4eed-8247-08d9e1bb7533 X-MS-TrafficTypeDiagnostic: YT2PR01MB9665:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xVHpL6q4FJrC9i7W7zCI5MHLxt8WD7FshFXysDhlVMn7Sdzyg+XzML3emVe1mewP0i73DyorMmozPzkBjHOvr+htzqcwZly4KjXdc0q+8zMC20rQ+1Wp+blkp2UNA329hZqIBOhmyA0shW/z10ThBhe5xZZGfUgx7tv813FA3nHJDHfC3MmtVZdiJ/EjDDfhv2WJR+OtyuolIbOh2hTr29L/ifJVgzoq0ayuN66cuBGJo/vAZTOv9lIUvsVcMpW7/AH/LGoDE2qhsckjv1/gLqewsnIi9Xcph66bHE4jelhouvhjAYYiULMqPPo59NUtW7NTdaTBdPyEk9Qv27zA5ND4Oya6hbHvZFdQ4W5xj4tDLiqBIcQvCkK6PqviGpbvJJJYlbYtkXbjwr2XjikGHJvsd0HWTKEUu/Zukk5SFOyW5IT0Mk/6chd1huiZ2U1TCQGfSWccsAfXWJd4zDrl11Daw9LebsbLWPn15jmp9u1/9VcL4VSDTaE08FONCuwB4Augy/JlhK6f1YrlXMCfU0gI6tv8mdsfm1z9zR8zEkcRpbYnAC7L0qy+jT+CfmvoJjkNxIi6+7iTNeVBSrSKhOidsNketPcsZU8aoiQDyTcvIHW5fRDYCClkUpsMN5EwHWLOTx0ToAzBy6Yqa+M8blbkx4+U7VVZtcwaR5MkiQKcBCmbmZw+ZkVGLzo7JBgLp4EuRbyJvAlB9KtoBL+3ag== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(8676002)(86362001)(4326008)(6486002)(66946007)(66476007)(8936002)(44832011)(6916009)(5660300002)(2906002)(26005)(6512007)(54906003)(1076003)(186003)(2616005)(52116002)(316002)(36756003)(38100700002)(6506007)(38350700002)(508600001)(83380400001)(20210929001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1KohhPUGv4GGTiGSrwkaZgrNZQ0ZyJI3W7vnnGSjO3PmsrZD0dMWRzhSNdqCLXBRZjGGCXu+BWaLLcBk4XG/nW3gXVpScSRQQfkxXppW1ihikAjE3PQ3GABoq0OJLDA8skBjr622mp0MPxgdFyle35iAj4gX2bE+2tSv73cVj2sWpZa2SffWJrOoMGzL9X6GUVBNb9yzVvCwvXyruDnbIYVYdhsyljFMi2JrORDUsP+MP13s6hodVk5bQdU03XoMmxA2i4DCZYw7PUk1Di7CNaSJ3I+TRXACxNJIbiYOQEpgQwXLOsxQVG53g1/4hppVGJh56ocYakkWempZeS/FzyZER7A3cZCwjfEu2bDw99/3ZiiDSReAoySiAkMUww1wvOEQZJXKWpeYKyn9HTiF40/ox7vryTtQ94Oj/rpQQQUgBFTHjzKvvHEbbku5OdkIG6V9Jm/1WsuKQMfc5J7ZNnJ+QaHSFP6irZotjEeSEP1c/6bBDSQy/GtA83qwWs8P6WC1LyGK4CMtU9023BzA6RkPt9ZThnBj6K7YMs+jcHRa7Hrx2J+xteCVN1XGrnybrd+z31wwWAT8rFKPT9dJhXZsOoT0JY9U3X0m1uGRs398fevQkYc8i8Eacj0u0umPub9hiQeTHUMoplPNoMhQRm8iAuFyB0TQxZ040uNLBThelVDF5l3ev7cr0ZrocLwPORs0VS6G/9cAKfHElC94l44MqYRRnrkVBnSB2K3CoxAoRLolXr8kdSSdNOl2VVm8BIKVtVSodgQk/Gh60mTwY4bI/rAHe+tKXMP8EHJi910kmnsrNzM37WUtKyk7VxE2sjIrDlbQgZBamtJQ1dePNDzdJwG61WXS/bRPm5pcOe1vL+exotjYAdfziGwSqIjabns+Gz/XC9C2fJNOUYS7Kww0stf3mclkCHMYo5mamSxDJJasHFL/9VGTBKEqUQNUjFj/YSVb0wIQOk7Di+vrGwozgOsEZJt9gGfMHXtw0HpUhpRjLmHVtFiWEcyVjBMbr0dTJkPjcqojhkkd87AFkllIEEO0Y6AAwc06Gij1rZny7BHlEtwStL7KK2IAzFOpgkjSx43Mv6dLPvkK43HZMWxQ6A3MxXGk/j1BGKXLpO2PcL0VpqyXtQ2uQE+d15ebiiW+PDIsaBIPJmzhkD+FYb7mL0xZRK128JlQRLt6t15BcwrOueztTOok5eHylG9TBCfHFYrw+wta7Chpgnpp7EQkCguQNY8tp1pcbDx4WVd9GU6Xo8QgnXuD6/QUgqRBTnFrHcU7prfmDTbWSjFNLHrl/pajAEEURK3P0y8JPV2SUqgC/HL/Mg99qRhpyABil1a2nnkKq8/HwqoOe19EwWcWvLtB5WlwSwge4aOxQORsC3y0slaodkQ7fPBeEYgyYVzufRdxyG0ywD/tN/PyS2yIgA9NNDDyQ5vqvuw/zgJAfIoeqGDifN5jXU0kLeXui1YimKH98zZvGibcAKqxpB5qgzg8UOFl7Cu0m0RK7905S3u/9f8uQeKE+0wRc4UZzW//usiRJRyeal+ouT+XX5q4UKXQ5Fx/wSZmGtu57GGXycWDn62Ectxve9gejfPJ5jEs5DsBxh+G5sYn9Y+Tp0Tcb0+3EWmW4xIXNsstj4uMECbGSup3v6OIQHgARg6H3CC+7Im62emQC6OQWOCV7JVItPR9rXkdSry7M1tU2cI= X-OriginatorOrg: calian.com X-MS-Exchange-CrossTenant-Network-Message-Id: 592d5953-ee83-4eed-8247-08d9e1bb7533 X-MS-Exchange-CrossTenant-AuthSource: YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2022 17:35:49.2329 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 23b57807-562f-49ad-92c4-3bb0f07a1fdf X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YNeF9Ay1jnQlXD923u+IkWzBllDOxyBijLpDIODN7aesLI0y+EWocDEr9G9Fu2yB89cWnPhTvPscORUjQRrzct6A6pPx7nhRoDONQDz5Lqs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT2PR01MB9665 X-Proofpoint-GUID: DzVmOJ_e_SeiDal8XxMaqZcrngxngce3 X-Proofpoint-ORIG-GUID: DzVmOJ_e_SeiDal8XxMaqZcrngxngce3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-27_03,2022-01-27_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 bulkscore=0 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=846 malwarescore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2201270102 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Register settings used for the sequencer configuration register were incorrect, causing some inputs to not be read properly. Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver") Signed-off-by: Robert Hancock Reviewed-by: Michael Tretter --- drivers/iio/adc/xilinx-ams.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c index b93864362dac..199027c93cdc 100644 --- a/drivers/iio/adc/xilinx-ams.c +++ b/drivers/iio/adc/xilinx-ams.c @@ -91,8 +91,8 @@ #define AMS_CONF1_SEQ_MASK GENMASK(15, 12) #define AMS_CONF1_SEQ_DEFAULT FIELD_PREP(AMS_CONF1_SEQ_MASK, 0) -#define AMS_CONF1_SEQ_CONTINUOUS FIELD_PREP(AMS_CONF1_SEQ_MASK, 1) -#define AMS_CONF1_SEQ_SINGLE_CHANNEL FIELD_PREP(AMS_CONF1_SEQ_MASK, 2) +#define AMS_CONF1_SEQ_CONTINUOUS FIELD_PREP(AMS_CONF1_SEQ_MASK, 2) +#define AMS_CONF1_SEQ_SINGLE_CHANNEL FIELD_PREP(AMS_CONF1_SEQ_MASK, 3) #define AMS_REG_SEQ0_MASK GENMASK(15, 0) #define AMS_REG_SEQ2_MASK GENMASK(21, 16) From patchwork Thu Jan 27 17:34:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Hancock X-Patchwork-Id: 12727144 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E425AC433EF for ; Thu, 27 Jan 2022 17:36:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244472AbiA0RgG (ORCPT ); Thu, 27 Jan 2022 12:36:06 -0500 Received: from mx0c-0054df01.pphosted.com ([67.231.159.91]:12428 "EHLO mx0c-0054df01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244541AbiA0RgE (ORCPT ); Thu, 27 Jan 2022 12:36:04 -0500 Received: from pps.filterd (m0208999.ppops.net [127.0.0.1]) by mx0c-0054df01.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id 20RCIlZO006794; Thu, 27 Jan 2022 12:35:51 -0500 Received: from can01-qb1-obe.outbound.protection.outlook.com (mail-qb1can01lp2053.outbound.protection.outlook.com [104.47.60.53]) by mx0c-0054df01.pphosted.com (PPS) with ESMTPS id 3duu8kr835-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Jan 2022 12:35:51 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ct7UlvcdKvd6YICRagijjzN0/DCxsmjyBu7gPENWic6AaODncMHZI0u7egIpTMDMbqspwbQgwbnSJng48Ldckcy0XC0ma9vXn0gv83JiKa41JgO/vdZZHe29UhVLSyDG7N3jOD4MiT5ly3NZZvFCxe7V0vUtFS6cGU9uJtNNeVsPym47UV5iX4zwN7tV8pJ2qJEAH+UGagPY7ASZF3zhCbpClYQEyitMyogLEdw/VkkXEC8Tc6bCDV02EeLesCEioAiTpU81uZGPzc7tvIEO9zhOW+W1F5Izp8b7hk6l6EWRjCFM2hfEWI2UyOjilF2pTzyAj/gCXPFMKIDE0INA9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KwlHAXbj05qn9RWsqcRK51QW6q2ZXHSzH6cPrjoys8U=; b=e5kOGscG3kelCuu6o8A8g0yH0+mRi5i4a2oRJNkvmxVQSW0W0PHwR41qbz7uYzLNt4Iw8f+k5DNi93OZ8oOsXjyy8Uq2/TNGbUzFRukhPYiVKMuN+QDYrvROm3/xyz9RvXLH32kaMe0sBF43lRKibOAmsAtIP15marjufeIcy4fFlK2e81I5u4Tkw/hIJPuFW0/JnhDDlMa4X5XiYH1aTXwAuqS2f1jo8QXOFvc3jt4Xv6zUOspDBon/Gupuub5JvuqCV56I5YCbhFeVFKQtxBZw8Ea8go8Hv+sjFrxo8XPurSFhgvqgcUFxpjKIIgI+twSpVJxdNfTI2N4+pZIKxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=calian.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KwlHAXbj05qn9RWsqcRK51QW6q2ZXHSzH6cPrjoys8U=; b=FI6yCbOij2Wx78YXBjH4S3IN5Xq6XaeB3qIMu1U1ZB4QKz3HexhjCqeee4ClbRV8lwYYoEJMnvlRU/dlrz/WErKs4yCLITE6NNS+P9TdD0nynim1+UDPQx7/1uoYJiExBg7V1m4Iraxy+IuQOfuHIu8ELbpZkeKLCASyWdK6OzA= Received: from YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:6a::19) by YT2PR01MB9665.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:df::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Thu, 27 Jan 2022 17:35:50 +0000 Received: from YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM ([fe80::6929:c39f:d893:b6c8]) by YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM ([fe80::6929:c39f:d893:b6c8%2]) with mapi id 15.20.4888.020; Thu, 27 Jan 2022 17:35:50 +0000 From: Robert Hancock To: linux-iio@vger.kernel.org Cc: anand.ashok.dumbre@xilinx.com, jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org, michal.simek@xilinx.com, manish.narani@xilinx.com, devicetree@vger.kernel.org, Robert Hancock Subject: [PATCH v2 4/4] iio: adc: xilinx-ams: Fix single channel switching sequence Date: Thu, 27 Jan 2022 11:34:50 -0600 Message-Id: <20220127173450.3684318-5-robert.hancock@calian.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220127173450.3684318-1-robert.hancock@calian.com> References: <20220127173450.3684318-1-robert.hancock@calian.com> X-ClientProxiedBy: CH0PR08CA0011.namprd08.prod.outlook.com (2603:10b6:610:33::16) To YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:6a::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 73b1e208-a52d-4bd0-f7c6-08d9e1bb75bd X-MS-TrafficTypeDiagnostic: YT2PR01MB9665:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: imaiPYa5qIwVTmikppXcoaiUQlKmn51Q4jC+i3HkuF7vxR0amOL0r2mp8EKA+s4v9YLuhbvpW+30uJTETkbJyTrharBBxlg0414l/i5MuC9bIz5rhhMdSGE6CkLydp1L9kcNmq0KVrP1BHxlibHSNlu3s5oKfVZQeBjRUQDzs+oq9bPVhCBLXAtgGghqNSrx77AkIVlQIMBChNaURmosu2ZvxnKrhEedBKHKUmmaMnabM7ak2qSTy2DsC1HqbIDAk6ZZFR3KcVoIKdp3+EGWSvjhsQ90i8XW5cUTttHg++7BJEd2eEDQhcHwdGePK1PRy1ITWPszcedCy0HcuoNhKNruQ/p+Csu19ueTokAz7AvlflThHxQGjbHkB3Y/PjVx0LIfK1S3FfzvjHstAy63F2drtBw6ML/olM6RNdSyigBqdI9PwQ+GMbPYPr0UqbVXUgeWEZ6FQ8PeX2mR7nYY+ax8TAqudLrEUqBrKzg9PEeC2CklSL8v9okUoNw2A8ZAGQGpM21gknQpP1wqkiFIItla7FfKKg6nfkpBW5sgGV8vF5kKRewojxkHSGlF+SzNuhd6NZ4HyAaoe04gAv9ZCnDiFpiakNSXJVFJzLsxbkVj+XgEnlqOQPgj/8Bcc7ZA9KwcHDLHBER+NQZ1+3FfVAIvek9X2uqK6V9tsiraD5/Zj5jNTxqne1bxaaXVisjBZRrmwkA54+bH7Ed+lGQjKQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(66556008)(8676002)(86362001)(4326008)(6486002)(66946007)(66476007)(8936002)(44832011)(6916009)(5660300002)(2906002)(107886003)(26005)(6512007)(1076003)(186003)(2616005)(52116002)(316002)(36756003)(38100700002)(6506007)(38350700002)(508600001)(83380400001)(20210929001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rVrfpXMcg/z+tralZwa/JWu5/ul7T+FOQ1MML3buUrN8xTmtbPRQr+UX59Z5hFYVVBl1F0FSVI3j9h9YnWOAiw1OYMBjKNkeolRM9Sxn+gPsG/tMo8TGULYkekndvbLxISaDMnEkNmVdiPGSm3AY7OZsRi3PBm5v1CyjPP1BX4sj8wzEqasu3UJW7NzqD2kp7feu9UXl6lYla69nSkMj8hCNOvWpGKgjPzQ68B3CLHI237ScWI+63vFK/XY/rrYeX6QbGBSV2bUmDKl/IGEAQbj9IJdty9rS62bBnkJ2gO5LvRmbej48WDyIY55l+rIVCkYlg5LsmtCs1/cXmibMlahmXHbg/YC2Uri4ECc/m5CXSdEbEy02mImV+b6tENucY4SifiztrLXd7yr1BCqJBohgf6gvSAe8xQZfoXLwEIHLOnmsijrM1UbHgaMI2dQVSGV80K9XaV/P+jhLCaboZZS/m9ZVyP7hPDsdNhiBs4f1TmWTd6ySXFgSgXQF9Zj8fQSF5yD+MRjOguO7V6KmXwYXcmmh5+ns8PQqQB3h4IRezlCE0UnLGZlEZndIJoFUT8NfP1PSd7cLg8AqE0gDijuIruBKy3J27E+VItVGV1k3DFLqIFTXH4B8bYr9FRBkaJwURNE7kYx8u3i55nptfx9nRIn3pkQNIFEhwo37LxDMDZNZX5Gx1YRl2VfZEzWuWIlaUBdzqZhbg7ZmlCzx229p8wxdx+bBgEIpWb//MhPwPVB8C7POfaRa/hdT7S86ODNvkEp498LJReUMnS4ZZWYnWVGC+S1GIMu79OetaeaOft+f9QwtVE2W7JKd28hcHDOzSTBUGddAJq71G+2VPOmDAVyD9CCO2aS5KLRepikfXRYDPaYgENiBu/jAo3wX9PxubWoU1cGuIpRkjVg7/k/59vRhor9lEHrDlHKHJ7/apWs6YyfLfYX0XePuAO4vGnu+aiqB+NaSQoVeNYy26TINbW9CZHmAlVAxsgs+ps2BMujpyZ9vOn5RAJdOUO9KhfI67IdcYm+wM7cfSkBT94iSu2ZQy/5XX7fhKw3hPyiH8dOSj1Y1d02W8wPFTshwIsanRQuxHBY5ZPCjd57aVMa+DLSdJ7wm5V10ZYb9bA9vfxS4ZFQcttLf/OeNYl/m2ycdpbqjg61wTm2suBZdrpUQyxZUGo7JcG8Ut8vQDrpdkSPeBESDoi7zIZKPRefXDgFP/onxxQlnlwPdHUfVisLRFSxRIy5QHFL2FaXKfMt6ib9dQzZj7w00wxHm5mEGAh+61XVM6R6X8a4U84vpsMe4lMskiOdUnejzUQ/wukBUA90mgbr8yIDrB75yuerW0XeET4cUVRLq2f49av1+GpvUc/wuWLUHfHtqBztvdqBvAR5m0yvD6yVopGrdJxN9GS796zQVj9LCHChHDd9VJHVZJofRo9iaofhyKfkwNo/QRW/qRiACK0agmwbDBXX83aHx9//cycxGhz+zTkSHqNpABaUlIX62zjum7Qk5UJlP3lWTlesYKXH8cnEgsE9gBG2l2+G0ymMvKTTn4COA/PxbcITcYoZTyrFADrzcl+PniXdHwABvJp/j52nhrByQNNfZk8VNOcpJES0Yn+/G8edWErTlzYQLbwodK1PxYhtvBKTBe1dHXmhWoXDyGAqIPkvh3gvHUX128sHoBjjyS79KXlmKITL0i++DLGQ1w+4= X-OriginatorOrg: calian.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73b1e208-a52d-4bd0-f7c6-08d9e1bb75bd X-MS-Exchange-CrossTenant-AuthSource: YT3PR01MB6274.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2022 17:35:50.1403 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 23b57807-562f-49ad-92c4-3bb0f07a1fdf X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2FmtOPuiu/k2kS1uhiKW0vvFECAB/bltbxDVAq74TgstORWODQZ1vOm0QgIRVOarxMCs6Ex+0xV3xUDM2So/dKzsUGlXuEqu/MG/R7MyjNs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT2PR01MB9665 X-Proofpoint-GUID: h5YDwUsRX2hSL-bkkRjVlJ6YFpgY1_jr X-Proofpoint-ORIG-GUID: h5YDwUsRX2hSL-bkkRjVlJ6YFpgY1_jr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.816,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-27_03,2022-01-27_01,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 clxscore=1015 bulkscore=0 impostorscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=695 malwarescore=0 suspectscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2201110000 definitions=main-2201270102 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org Some of the AMS channels need to be read by switching into single-channel mode from the normal polling sequence. There was a logic issue in this switching code that could cause the first read of these channels to read back as zero. It appears that the sequencer should be set back to default mode before changing the channel selection, and the channel should be set before switching the sequencer back into single-channel mode. Also, write 1 to the EOC bit in the status register to clear it before waiting for it to become set, so that we actually wait for a new conversion to complete, and don't proceed based on a previous conversion completing. Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver") Signed-off-by: Robert Hancock --- drivers/iio/adc/xilinx-ams.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c index 199027c93cdc..7bf097fa10cb 100644 --- a/drivers/iio/adc/xilinx-ams.c +++ b/drivers/iio/adc/xilinx-ams.c @@ -530,14 +530,18 @@ static int ams_enable_single_channel(struct ams *ams, unsigned int offset) return -EINVAL; } - /* set single channel, sequencer off mode */ + /* put sysmon in a soft reset to change the sequence */ ams_ps_update_reg(ams, AMS_REG_CONFIG1, AMS_CONF1_SEQ_MASK, - AMS_CONF1_SEQ_SINGLE_CHANNEL); + AMS_CONF1_SEQ_DEFAULT); /* write the channel number */ ams_ps_update_reg(ams, AMS_REG_CONFIG0, AMS_CONF0_CHANNEL_NUM_MASK, channel_num); + /* set single channel, sequencer off mode */ + ams_ps_update_reg(ams, AMS_REG_CONFIG1, AMS_CONF1_SEQ_MASK, + AMS_CONF1_SEQ_SINGLE_CHANNEL); + return 0; } @@ -551,6 +555,8 @@ static int ams_read_vcc_reg(struct ams *ams, unsigned int offset, u32 *data) if (ret) return ret; + /* clear end-of-conversion flag, wait for next conversion to complete */ + writel(expect, ams->base + AMS_ISR_1); ret = readl_poll_timeout(ams->base + AMS_ISR_1, reg, (reg & expect), AMS_INIT_POLL_TIME_US, AMS_INIT_TIMEOUT_US); if (ret)