From patchwork Fri Dec 28 15:15:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartlomiej Zolnierkiewicz X-Patchwork-Id: 10744491 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 320E391E for ; Fri, 28 Dec 2018 15:15:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1D10628BA6 for ; Fri, 28 Dec 2018 15:15:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0BF4328BAA; Fri, 28 Dec 2018 15:15:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5352B28BA6 for ; Fri, 28 Dec 2018 15:15:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731376AbeL1PPY (ORCPT ); Fri, 28 Dec 2018 10:15:24 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:43193 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727178AbeL1PPY (ORCPT ); Fri, 28 Dec 2018 10:15:24 -0500 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20181228151522euoutp0193dbd76c12919567571bbc9aea787002~0iAQDksud2808928089euoutp010 for ; Fri, 28 Dec 2018 15:15:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20181228151522euoutp0193dbd76c12919567571bbc9aea787002~0iAQDksud2808928089euoutp010 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1546010122; bh=I67BPa+pgZ5kG6j9s+HJWMe9NcsU+8UyQR0avxZoC48=; h=To:Cc:From:Subject:Date:References:From; b=mCrrdRAA4Gos8N1HSTGEm77Ow0DtBMheu8ShU/BT2bsQfhQvzQclQen7OhYETK4aK L77FSDl6iNtthAQ5ZKNrYWyo0fcv0OyZ078d3tlyM6CPYRtMfr7dysPBPaiNTGs9G+ pCFc9UEWv0U6ebgkhorkwuooEaqZlXpcbdbyMCPo= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20181228151522eucas1p22af3daba0713791bc7998893ebfb0208~0iAPSdUfM1286512865eucas1p2U; Fri, 28 Dec 2018 15:15:22 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 10.AB.04294.90E362C5; Fri, 28 Dec 2018 15:15:21 +0000 (GMT) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20181228151521eucas1p163e845ef691ac2bd78051e6fa4c068d0~0iAOSDWCc0194301943eucas1p1q; Fri, 28 Dec 2018 15:15:21 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20181228151520eusmtrp2ecf50b5d230ab88b974be6f86dfc6033~0iAODZAa91625116251eusmtrp2k; Fri, 28 Dec 2018 15:15:20 +0000 (GMT) X-AuditID: cbfec7f4-835ff700000010c6-48-5c263e096f54 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 11.1E.04284.80E362C5; Fri, 28 Dec 2018 15:15:20 +0000 (GMT) Received: from [106.120.53.102] (unknown [106.120.53.102]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20181228151520eusmtip10cb35cd5ecf6b351cba95ecb351f19fa~0iANls-IW2295222952eusmtip1F; Fri, 28 Dec 2018 15:15:20 +0000 (GMT) To: Randy Dunlap Cc: Rob Clark , Arnd Bergmann , Ben Skeggs , David Airlie , Daniel Vetter , Stephen Rothwell , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org From: Bartlomiej Zolnierkiewicz Subject: [PATCH] drm/nouveau: fix incorrect FB_BACKLIGHT usage in Kconfig Message-ID: <6f25a4a3-3d24-e811-7c0b-bbdd8ff8aa8b@samsung.com> Date: Fri, 28 Dec 2018 16:15:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNKsWRmVeSWpSXmKPExsWy7djP87qcdmoxBtNmGFr0njvJZPF30jF2 i5fLOxgt/m+byGxx5et7NosTfR9YLd7emc5i8XzhD2aLrXuvsjtwevz+NYnRo/HGDTaPvd8W sHjsnHWX3WPzCi2P7d8esHrc7z7O5PF+31U2j8+b5AI4o7hsUlJzMstSi/TtErgyLt9aylLw n69iztPjrA2MF3m6GDk5JARMJLb2XmHvYuTiEBJYwSix6WYrC4TzhVHi6qSPUM5nRoklEw6z dTFygLX8vaMLEV/OKDFv9kFGCOc9o0Rj4w42kLkiAhoSv69cYQVJMAtMYpK4df0JE0iCTcBK YmL7KkYQW1jAU2LXy5dgDbwCdhIbOj+xgtgsAqoSDcs+M4JsExWIkOg/ow5RIihxcuYTFhCb WUBeYvvbOcwQP+xil3jwXQ3CdpHY3LkEKi4s8er4FnYIW0bi/875TCD3SAhMZ5R482spC4Sz nlFizZljTBBV1hKHj19kBVnMLKApsX6XPkTYUeLAzwdMEN/zSdx4KwhxA5/EpG3TmSHCvBId bUIQ1WoSG5ZtYINZ27VzJdQ5HhIzd/WBLRISiJX42t7BPIFRYRaSz2Yh+WwWwg0LGJlXMYqn lhbnpqcWG+WllusVJ+YWl+al6yXn525iBCap0/+Of9nBuOtP0iFGAQ5GJR7eH+9VYoRYE8uK K3MPMUpwMCuJ8Crxq8UI8aYkVlalFuXHF5XmpBYfYpTmYFES561meBAtJJCeWJKanZpakFoE k2Xi4JRqYJzleSJvPj/vni0+v+3ZdHVMFu625nqj83T9ttPVnJZ1t2M5E7LuKAVusP3xrupV 2MMTxfOnP9678NMch9CDstGXgwzfiD/I35Zc/MDght2smTWti7i14jJ528pllOYsXZDj+umm Ztr5TBYrcet3CzNi7ZkntxVkaSstV/C+cyM+yMhWlyGGV4mlOCPRUIu5qDgRAH9ptCZOAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJIsWRmVeSWpSXmKPExsVy+t/xu7ocdmoxBh1vtSx6z51ksvg76Ri7 xcvlHYwW/7dNZLa48vU9m8WJvg+sFm/vTGexeL7wB7PF1r1X2R04PX7/msTo0XjjBpvH3m8L WDx2zrrL7rF5hZbH9m8PWD3udx9n8ni/7yqbx+dNcgGcUXo2RfmlJakKGfnFJbZK0YYWRnqG lhZ6RiaWeobG5rFWRqZK+nY2Kak5mWWpRfp2CXoZl28tZSn4z1cx5+lx1gbGizxdjBwcEgIm En/v6HYxcnEICSxllNi26Bw7RFxG4vj6si5GTiBTWOLPtS42iJq3jBI7pl1iBUmICGhI/L5y hRUkwSwwiUli35HJTCAJNgEriYntqxhBbGEBT4ldL1+ygdi8AnYSGzo/gTWzCKhKNCz7DFYj KhAhcethBwtEjaDEyZlPwGxmAXWJP/MuMUPY8hLb385hnsDIPwtJ2SwkZbOQlC1gZF7FKJJa WpybnltsqFecmFtcmpeul5yfu4kRGE3bjv3cvIPx0sbgQ4wCHIxKPLw/3qvECLEmlhVX5h5i lOBgVhLhVeJXixHiTUmsrEotyo8vKs1JLT7EaAp0+ERmKdHkfGCk55XEG5oamltYGpobmxub WSiJ8543qIwSEkhPLEnNTk0tSC2C6WPi4JRqYJTYaCt5TkMk+tKf8rW7Pax836tLuy1a73Tt p/y8SvPrN2wbBS7bczolPt38mevb0aulvQa1R9h+KyaIFWpUS+yrWRvF0rmz0TDhzL3kj08X f9/s7OceK//DeaPvlNOfpy3YET3RS7N97WW2BVmrz5bJVjyaq1UQqNjwo/a6w77NrGun6rMq MiqxFGckGmoxFxUnAgC2K89qvAIAAA== X-CMS-MailID: 20181228151521eucas1p163e845ef691ac2bd78051e6fa4c068d0 X-Msg-Generator: CA X-RootMTR: 20181228151521eucas1p163e845ef691ac2bd78051e6fa4c068d0 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181228151521eucas1p163e845ef691ac2bd78051e6fa4c068d0 References: Sender: linux-fbdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Making FB_BACKLIGHT tristate by commit b4a1ed0cd18b ("fbdev: make FB_BACKLIGHT a tristate") caused unmet dependencies in some configurations: WARNING: unmet direct dependencies detected for FB_BACKLIGHT Depends on [m]: HAS_IOMEM [=y] && FB [=m] Selected by [y]: - DRM_NOUVEAU [=y] && HAS_IOMEM [=y] && DRM [=y] && PCI [=y] && MMU [=y] && DRM_NOUVEAU_BACKLIGHT [=y] Selected by [m]: - FB_NVIDIA [=m] && HAS_IOMEM [=y] && FB [=m] && PCI [=y] && FB_NVIDIA_BACKLIGHT [=y] Fix it by making DRM_NOUVEAU select BACKLIGHT_CLASS_DEVICE and BACKLIGHT_LCD_SUPPORT instead of FB_BACKLIGHT. Fixes: b4a1ed0cd18b ("fbdev: make FB_BACKLIGHT a tristate") Reported-by: Randy Dunlap Cc: Rob Clark Cc: Arnd Bergmann Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: Stephen Rothwell Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Randy Dunlap # build-tested --- I would like to merge this patch through fbdev tree for v4.21 (as it is needed to fix commit currently in fbdev tree). drivers/gpu/drm/nouveau/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/drivers/gpu/drm/nouveau/Kconfig =================================================================== --- a/drivers/gpu/drm/nouveau/Kconfig 2018-11-30 11:46:55.716464505 +0100 +++ b/drivers/gpu/drm/nouveau/Kconfig 2018-12-28 14:54:51.655965845 +0100 @@ -4,7 +4,8 @@ config DRM_NOUVEAU select FW_LOADER select DRM_KMS_HELPER select DRM_TTM - select FB_BACKLIGHT if DRM_NOUVEAU_BACKLIGHT + select BACKLIGHT_CLASS_DEVICE if DRM_NOUVEAU_BACKLIGHT + select BACKLIGHT_LCD_SUPPORT if DRM_NOUVEAU_BACKLIGHT select ACPI_VIDEO if ACPI && X86 && BACKLIGHT_CLASS_DEVICE && INPUT select X86_PLATFORM_DEVICES if ACPI && X86 select ACPI_WMI if ACPI && X86