From patchwork Mon Jan 31 15:42:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guillaume Nault X-Patchwork-Id: 12730788 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB925C433F5 for ; Mon, 31 Jan 2022 15:42:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378302AbiAaPmJ (ORCPT ); Mon, 31 Jan 2022 10:42:09 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:50469 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236278AbiAaPmJ (ORCPT ); Mon, 31 Jan 2022 10:42:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643643728; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1sW7rzPQhozZJd5bIGL105H+ak+PyChDVEsMpXF5SsA=; b=SHXNEavP4wt5WkTAG9cpyC52KbWEffO08a1QVF0ltEDyUCM/XE/I2+JkcSMhn5Cf73CIcC XGllYFLKioDIPDnyJxtHnRRUQnH9b8ojZlN6qxXNjC4gj/atSppZMEOQ5cyfTcPi8j04n6 bgRQe2EELF9Tj2uR7NJJDpckOGbm+mw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-590-Ika_AB1QOTWLbousKcE1dg-1; Mon, 31 Jan 2022 10:42:05 -0500 X-MC-Unique: Ika_AB1QOTWLbousKcE1dg-1 Received: by mail-wm1-f70.google.com with SMTP id f188-20020a1c1fc5000000b0034d79edde84so3094212wmf.0 for ; Mon, 31 Jan 2022 07:42:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1sW7rzPQhozZJd5bIGL105H+ak+PyChDVEsMpXF5SsA=; b=oOivtnn3cVXZmkK6DNyKPI++1ClIAP1ahsBr3Iq0wD73TAmErLW5H8yO8dYQ2n4cJ2 G8i/dIZX8QvFWjrSEAdAu51nK3hrs0n+eL1Bqer42iG34WqgNRz+iNMHpNJ4dD+fZeXk EVUdYmShLNjh1U1xM3E0giY6ig4bqpX7b6wALdg1M50zLm6NMKy2W2k7qCl3xbz/AuZI 976Uund/smO7A56t1kv4hD8KVHiYplWY3aG9zHEjC/rUzqMw+jSYEw7uq2uMob4xUQ2V +Qam9mXbQ6VfZeB0abBhs5g2v+VtAbeLPOc9FeieqvSUUBfTV6dWGHrWeepbJLLLZxrM 6+YA== X-Gm-Message-State: AOAM5303Zq3CmZ4N2sD+c3AzXexJqMCSmTi962r+dv2s2VaVk1NLSILX x25ySt7+p1tI43rU/i+KIWANfb8EKQVrQ5sGq7R2uE/2D/sW1KAJaU+o6wl6yxNL0SIHW8JMPpn 2X2qtbnDXIpiPgVL+ X-Received: by 2002:a05:600c:4606:: with SMTP id m6mr18884794wmo.158.1643643724084; Mon, 31 Jan 2022 07:42:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJxby5+LXKmhGyrUYjq8E3JvF/Tb4DHqOiKvlAvELRnZXgXmO2oDHs3fV9s7zGDIfs9YNcWdTw== X-Received: by 2002:a05:600c:4606:: with SMTP id m6mr18884782wmo.158.1643643723938; Mon, 31 Jan 2022 07:42:03 -0800 (PST) Received: from pc-4.home (2a01cb058918ce00dd1a5a4f9908f2d5.ipv6.abo.wanadoo.fr. [2a01:cb05:8918:ce00:dd1a:5a4f:9908:f2d5]) by smtp.gmail.com with ESMTPSA id p17sm12454713wrf.112.2022.01.31.07.42.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 07:42:03 -0800 (PST) Date: Mon, 31 Jan 2022 16:42:01 +0100 From: Guillaume Nault To: David Miller , Jakub Kicinski Cc: netdev@vger.kernel.org, Shuah Khan , linux-kselftest@vger.kernel.org, Roopa Prabhu Subject: [PATCH net-next 1/4] selftests: fib rule: Make 'getmatch' and 'match' local variables Message-ID: <6c58c82747ac8351105a0d25eefc594206d414d6.1643643083.git.gnault@redhat.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Let's restrict the scope of these variables to avoid possible interferences. Signed-off-by: Guillaume Nault --- tools/testing/selftests/net/fib_rule_tests.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh index 43ea8407a82e..f04f337dd7c6 100755 --- a/tools/testing/selftests/net/fib_rule_tests.sh +++ b/tools/testing/selftests/net/fib_rule_tests.sh @@ -115,6 +115,9 @@ fib_rule6_test_match_n_redirect() fib_rule6_test() { + local getmatch + local match + # setup the fib rule redirect route $IP -6 route add table $RTABLE default via $GW_IP6 dev $DEV onlink @@ -184,6 +187,9 @@ fib_rule4_test_match_n_redirect() fib_rule4_test() { + local getmatch + local match + # setup the fib rule redirect route $IP route add table $RTABLE default via $GW_IP4 dev $DEV onlink From patchwork Mon Jan 31 15:42:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guillaume Nault X-Patchwork-Id: 12730789 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D66BDC433EF for ; Mon, 31 Jan 2022 15:42:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379770AbiAaPmK (ORCPT ); Mon, 31 Jan 2022 10:42:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:50026 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242802AbiAaPmJ (ORCPT ); Mon, 31 Jan 2022 10:42:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643643729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hkxchTylyBIw36KxB2bjQj4NjTJ8gEN7NWBvja/ptEI=; b=OtgrpUGvsyy2TZRhrjCjDfrMqRL3pJE9NqjoBlqkwIosAY+5OPsm3AOUqkcZ/2cCD+FCm6 0g9EsnFuSn7jds4Sj4r5Zf1w0qmIZ7Dk86CukO6jaWzuewCsZ/jSyVtVr06ZEukX25IMf3 hngVqQaopH5dvbaVKT0lfHzD+lKCnM0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-343-WqJ9Tvl9NPqiwKkJkly9lQ-1; Mon, 31 Jan 2022 10:42:07 -0500 X-MC-Unique: WqJ9Tvl9NPqiwKkJkly9lQ-1 Received: by mail-wr1-f72.google.com with SMTP id m17-20020adfa3d1000000b001dd66c10c0cso4968397wrb.19 for ; Mon, 31 Jan 2022 07:42:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hkxchTylyBIw36KxB2bjQj4NjTJ8gEN7NWBvja/ptEI=; b=a6J+TlXd15zDuCk748D4i+wNAXiAWnnj4T5e+mzBrhR2/FP9Aho3f3wlRaqVAuQkd+ HxrHkwFIeKoH8ihUXqcOh2kO33Dz4mxVORxVexbWaudMnNUeHfxepo0z45aMnY2NtEYc Kw/V1K6BZdMpbryV1xH1aN5AGNJ1XoBtM02rNaZiHbR8HRK+Bo6TBufrYNthN2xNdgaF Nxx2W+YXGP3VjuSwbJxmvhuTk/QMI2FxwpnYpFXyK2/cRspCtZ8FSFkJ335B6T1y1lz1 OyWel6vZaVY5Yn1U9nzwPaDkE7sDNwvRn4+DfVmav/u6LaMT0Ue6mK+VVMY7ETVQvDzk qE0A== X-Gm-Message-State: AOAM531eh563Knsu5JByBlMuC1yBrkD6AHwEbNwsAZswRAHjBYHMFmW/ ypghURCqFAnZW4g/EXbq75H9Ty+9XGyH+c2yoUwAwXQCI4oIr1wjqZdp4UmMLom5Z688vSbRtaT X6KbgPcvatycY0meb X-Received: by 2002:adf:9dc6:: with SMTP id q6mr17692040wre.679.1643643726601; Mon, 31 Jan 2022 07:42:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJy1DwCI3Fw2wTecxht4WC3IQ8a5vpBieNVHkhHesxDAYIX779C8wLRFnFWyOh+KqnTZ7JI11A== X-Received: by 2002:adf:9dc6:: with SMTP id q6mr17692030wre.679.1643643726417; Mon, 31 Jan 2022 07:42:06 -0800 (PST) Received: from pc-4.home (2a01cb058918ce00dd1a5a4f9908f2d5.ipv6.abo.wanadoo.fr. [2a01:cb05:8918:ce00:dd1a:5a4f:9908:f2d5]) by smtp.gmail.com with ESMTPSA id i9sm14449262wry.32.2022.01.31.07.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 07:42:06 -0800 (PST) Date: Mon, 31 Jan 2022 16:42:04 +0100 From: Guillaume Nault To: David Miller , Jakub Kicinski Cc: netdev@vger.kernel.org, Shuah Khan , linux-kselftest@vger.kernel.org, Roopa Prabhu Subject: [PATCH net-next 2/4] selftests: fib rule: Drop erroneous TABLE variable Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The fib_rule6_del_by_pref() and fib_rule4_del_by_pref() functions use an uninitialised $TABLE variable. They should use $RTABLE instead. This doesn't alter the result of the test, as it just makes the grep command less specific (but since the script always uses the same table number, that doesn't really matter). Let's fix it anyway and, while there, specify the filtering parameters directly in 'ip -X rule show' to avoid the extra grep command entirely. Signed-off-by: Guillaume Nault --- tools/testing/selftests/net/fib_rule_tests.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh index f04f337dd7c6..012f9385d68c 100755 --- a/tools/testing/selftests/net/fib_rule_tests.sh +++ b/tools/testing/selftests/net/fib_rule_tests.sh @@ -96,7 +96,7 @@ fib_rule6_del() fib_rule6_del_by_pref() { - pref=$($IP -6 rule show | grep "$1 lookup $TABLE" | cut -d ":" -f 1) + pref=$($IP -6 rule show $1 table $RTABLE | cut -d ":" -f 1) $IP -6 rule del pref $pref } @@ -168,7 +168,7 @@ fib_rule4_del() fib_rule4_del_by_pref() { - pref=$($IP rule show | grep "$1 lookup $TABLE" | cut -d ":" -f 1) + pref=$($IP rule show $1 table $RTABLE | cut -d ":" -f 1) $IP rule del pref $pref } From patchwork Mon Jan 31 15:42:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guillaume Nault X-Patchwork-Id: 12730790 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5125C433EF for ; Mon, 31 Jan 2022 15:42:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379791AbiAaPmN (ORCPT ); Mon, 31 Jan 2022 10:42:13 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:43257 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350284AbiAaPmL (ORCPT ); Mon, 31 Jan 2022 10:42:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643643731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=slqi+eFgPyIV91fplcPLPuJfZVr8h1BVcJVDtOG3dfs=; b=WmGC0IhVsqq2Fjvuq0HxWAuxybYAeYyTO95UpsAmDGJYNTW6ZcnEaUwhgZxd2cqeyIgKWc zxjoHdIdiauyWzLtOXLDFnE3SmIPQoQACPxRYV02OBYN/o9sxRTpzuDIN6ZMYz92iKy/iU TOwD6Y7e9jYWTGMTpePNmwNWlvvIdJE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-124-Qh_AYZ3kNECThixScetDew-1; Mon, 31 Jan 2022 10:42:10 -0500 X-MC-Unique: Qh_AYZ3kNECThixScetDew-1 Received: by mail-wm1-f71.google.com with SMTP id q125-20020a1c4383000000b003503e10c027so3092489wma.2 for ; Mon, 31 Jan 2022 07:42:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=slqi+eFgPyIV91fplcPLPuJfZVr8h1BVcJVDtOG3dfs=; b=tecOzbr1K+WDFglQhDsjcFb1cFYarJP0TwVhMRw90kiRuG3AsokYRN9G2tHcojKckB NVlttNySeDjTagJq90VB0bd6FTav3RtFrQvLivF7kGT4RzYxgl9KB/gGYm2VVvv5R4Xh Vg/TDHvVJ9R/us0Goh8P/S5qe2m67s1IutTuuQ236bkmrwTmg1tlHdZddcMXcxl3avMP cK7YzmX2bKiBZzjCyF8OO6GLjHtG5NOWip/BvkHuuHNCRI7oMHagtcd+iWfuX4gtUwAj BMkpHi1QnssIbAm/ih9aRnLEAIi6wV71OvCHODvNkOmdBsBJJazAedswXI4uHx5wnPBk f4lg== X-Gm-Message-State: AOAM533vgmS5yNl4dIaVrqdmYmOHtWEXdg68lfEj0duJNu5IyRf02q8U u6KDzQfbBGUgfW3DJ1a7KzV47jXEMAFT5mkqwMN1Z3R1AXqkhOtkLrbLEtrFpdldRIwR0NUJbHq WZYQRHTJYo/nhvWE3 X-Received: by 2002:a05:600c:3217:: with SMTP id r23mr18796170wmp.159.1643643728867; Mon, 31 Jan 2022 07:42:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJzMLn8ts+Ww3+PnE/eJvxpKnuFYaYejpPPPVrdfW9EaLvIgjdFDBxVx65LUYPgD/7F0PC720g== X-Received: by 2002:a05:600c:3217:: with SMTP id r23mr18796158wmp.159.1643643728737; Mon, 31 Jan 2022 07:42:08 -0800 (PST) Received: from pc-4.home (2a01cb058918ce00dd1a5a4f9908f2d5.ipv6.abo.wanadoo.fr. [2a01:cb05:8918:ce00:dd1a:5a4f:9908:f2d5]) by smtp.gmail.com with ESMTPSA id p8sm13210073wrr.16.2022.01.31.07.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 07:42:08 -0800 (PST) Date: Mon, 31 Jan 2022 16:42:06 +0100 From: Guillaume Nault To: David Miller , Jakub Kicinski Cc: netdev@vger.kernel.org, Shuah Khan , linux-kselftest@vger.kernel.org, Roopa Prabhu Subject: [PATCH net-next 3/4] selftests: fib rule: Log test description Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org All callers of fib_rule6_test_match_n_redirect() and fib_rule4_test_match_n_redirect() pass a third argument containing a description of the test being run. Instead of ignoring this argument, let's use it for logging instead of printing a truncated version of the command. Signed-off-by: Guillaume Nault --- tools/testing/selftests/net/fib_rule_tests.sh | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh index 012f9385d68c..6a05e81fc81d 100755 --- a/tools/testing/selftests/net/fib_rule_tests.sh +++ b/tools/testing/selftests/net/fib_rule_tests.sh @@ -104,13 +104,14 @@ fib_rule6_test_match_n_redirect() { local match="$1" local getmatch="$2" + local description="$3" $IP -6 rule add $match table $RTABLE $IP -6 route get $GW_IP6 $getmatch | grep -q "table $RTABLE" - log_test $? 0 "rule6 check: $1" + log_test $? 0 "rule6 check: $description" fib_rule6_del_by_pref "$match" - log_test $? 0 "rule6 del by pref: $match" + log_test $? 0 "rule6 del by pref: $description" } fib_rule6_test() @@ -176,13 +177,14 @@ fib_rule4_test_match_n_redirect() { local match="$1" local getmatch="$2" + local description="$3" $IP rule add $match table $RTABLE $IP route get $GW_IP4 $getmatch | grep -q "table $RTABLE" - log_test $? 0 "rule4 check: $1" + log_test $? 0 "rule4 check: $description" fib_rule4_del_by_pref "$match" - log_test $? 0 "rule4 del by pref: $match" + log_test $? 0 "rule4 del by pref: $description" } fib_rule4_test() From patchwork Mon Jan 31 15:42:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guillaume Nault X-Patchwork-Id: 12730791 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7E0EC433FE for ; Mon, 31 Jan 2022 15:42:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379793AbiAaPmR (ORCPT ); Mon, 31 Jan 2022 10:42:17 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:39975 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350284AbiAaPmO (ORCPT ); Mon, 31 Jan 2022 10:42:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643643734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1JlgLZscDoIFop5dBhXgA1KNuotqIeX45MP+1J3nAYY=; b=YeFsNng0zShieqie30KAPYmGtfDhnkTyhyjyaoxkaXQDD6rUrPOC4gPkKFjm/x6O+QoZnw Y6lLduTuQsnWqJLcTWbcw8QaBT5tS/9hMGpBTCMR5owlN/CF3Gq40ppbzNV4BN9es2qNEQ lcf8VhOXfLzbJ40+C7ex1hSZJsZlsf0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-440-btatH3vsNJyKAT-dZ1qVIQ-1; Mon, 31 Jan 2022 10:42:13 -0500 X-MC-Unique: btatH3vsNJyKAT-dZ1qVIQ-1 Received: by mail-wm1-f69.google.com with SMTP id m3-20020a7bcb83000000b0034f75d92f27so5922276wmi.2 for ; Mon, 31 Jan 2022 07:42:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1JlgLZscDoIFop5dBhXgA1KNuotqIeX45MP+1J3nAYY=; b=8H/KxlsLn6pOH7+6U0//emxdqjjGhe8sojvk6pM+l2utwojzL0W3ofVUHcbi5TsfYn fOIiNqu/O1LpCrjijSy8AXgIJ5HtGKYl+esiP0tpvB56xl6P5mB4vqMKF22eYcQ7Y5tQ YRHoxxJA+I+OYKEV5JJziHlKWCkGYjoDpV49G6rBbbNFlGrJKvcTnhVBL8H3rsnfi7DB VKtWiGNgSwqQPkK3gK8qIOgYAJ/Hlo60kbTvfaItLwfoEh9y8lc7xRIOWsYulJPr593b gKU2gQd8VKiFTy0Uqm1/tBGfqXgCCgP+uz6+vzQMZlm/EAWtEOnogJlLrEctMS4tpg1S dCZg== X-Gm-Message-State: AOAM533H0y/BQ+C+oJmXudJL6s/JSuO2LK6X1tKVpsKFYwYmns9hOXuR qpbIc11KbK1ZsFDYhA/QIVUNejikHm35A6QSIbZeVdJnwWTS8ziMogco0xgQ0hz08QIYN0IJpmT 5j7T/+gUaLELfJC2K X-Received: by 2002:a05:6000:15c5:: with SMTP id y5mr19027260wry.656.1643643731547; Mon, 31 Jan 2022 07:42:11 -0800 (PST) X-Google-Smtp-Source: ABdhPJygQlVQ+YgRpR5xEHj4gvtNZSfcyjb7bmNGvYeSOgWRfcZ4vdWME0LKdI1icjsxp88B6wNo3A== X-Received: by 2002:a05:6000:15c5:: with SMTP id y5mr19027244wry.656.1643643731344; Mon, 31 Jan 2022 07:42:11 -0800 (PST) Received: from pc-4.home (2a01cb058918ce00dd1a5a4f9908f2d5.ipv6.abo.wanadoo.fr. [2a01:cb05:8918:ce00:dd1a:5a4f:9908:f2d5]) by smtp.gmail.com with ESMTPSA id f13sm10379789wmq.29.2022.01.31.07.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jan 2022 07:42:10 -0800 (PST) Date: Mon, 31 Jan 2022 16:42:09 +0100 From: Guillaume Nault To: David Miller , Jakub Kicinski Cc: netdev@vger.kernel.org, Shuah Khan , linux-kselftest@vger.kernel.org, Roopa Prabhu , Hangbin Liu Subject: [PATCH net-next 4/4] selftests: fib rule: Don't echo modified sysctls Message-ID: <6baa96248e33682166fa295ec98a472d02f4767a.1643643083.git.gnault@redhat.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Run sysctl in quiet mode. Echoing the modified sysctl doesn't bring any useful information. Signed-off-by: Guillaume Nault --- tools/testing/selftests/net/fib_rule_tests.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh index 6a05e81fc81d..3b0489910422 100755 --- a/tools/testing/selftests/net/fib_rule_tests.sh +++ b/tools/testing/selftests/net/fib_rule_tests.sh @@ -200,11 +200,11 @@ fib_rule4_test() # need enable forwarding and disable rp_filter temporarily as all the # addresses are in the same subnet and egress device == ingress device. - ip netns exec testns sysctl -w net.ipv4.ip_forward=1 - ip netns exec testns sysctl -w net.ipv4.conf.$DEV.rp_filter=0 + ip netns exec testns sysctl -qw net.ipv4.ip_forward=1 + ip netns exec testns sysctl -qw net.ipv4.conf.$DEV.rp_filter=0 match="from $SRC_IP iif $DEV" fib_rule4_test_match_n_redirect "$match" "$match" "iif redirect to table" - ip netns exec testns sysctl -w net.ipv4.ip_forward=0 + ip netns exec testns sysctl -qw net.ipv4.ip_forward=0 match="tos 0x10" fib_rule4_test_match_n_redirect "$match" "$match" "tos redirect to table"