From patchwork Wed Feb 2 08:17:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 12732694 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 056E2C433F5 for ; Wed, 2 Feb 2022 08:18:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BECAB10E336; Wed, 2 Feb 2022 08:18:09 +0000 (UTC) Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id C26B610F9E9 for ; Wed, 2 Feb 2022 08:18:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1643789888; x=1675325888; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=GwW1AHWp4yInCJeFGSw5ytM4s1rzTas8PEVpMvVFWZE=; b=Qv9zC3ofC1MKhwmqKxv6/1bXWrN/qG5q4CZ6CNUmF/ZgdOfXdQfJL8zr GjBFaDKS//O5cQFOT1VqWsp4SiwQ/B2uucsuwgMsArLccYJ7NCsnT5KDY NrzZLUKheLDfdvc9rI+pAJwkcV2z7ddy8GDOqqSuU0+Ia+pgqJcV7PvaA csw6tBk5deDbA5PnW9wqs2bl3dUlNvm7WVquiFSrsCpy7j2GnSidTd4tY OJlMQuBHqAPLhhftnE2UErH8leVaRdmbeRxZNE48BJRnILsI0BPYUng9q jf/3sy8z2MgRg9bLi3ocUN7asE5okWsFK3VHojmBXcy4I99+e3XTyojMf A==; X-IronPort-AV: E=Sophos;i="5.88,336,1635199200"; d="scan'208";a="21844619" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 02 Feb 2022 09:18:04 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Wed, 02 Feb 2022 09:18:04 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Wed, 02 Feb 2022 09:18:04 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1643789884; x=1675325884; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=GwW1AHWp4yInCJeFGSw5ytM4s1rzTas8PEVpMvVFWZE=; b=DfDwK33op8JtL6wyh+1gO8wZMDiWPk1fxYYujbsucFr6WRxAEYIT5jfz Bk9v4kiXQ123+VlGouHgh2Xil3ng7smA5S1UsZO0d2jDgVYZ8sZKMT8VN 4ZhUa6rE3JUoEL8tFUoxiNoeLRim3axZPKdx6HHgNUrC37px+hcwmOhfg yYtttO+Gi64oMRH8As3C9Nw2p69HG3MgPTvGIpqMVBqjNS+8a+xX19o9l DaqbTPfXy7cOwdwTFvFC6S9zLCz4nwcGhFmDZ1B7wX59aCj+lE04wSWb8 zfPL/aiInE/1A4bhLbB/ZGVC0CyNVSD8jbh+TBqO0O22zIYwChWnr/tA4 w==; X-IronPort-AV: E=Sophos;i="5.88,336,1635199200"; d="scan'208";a="21844618" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 02 Feb 2022 09:18:04 +0100 Received: from steina-w.tq-net.de (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 66AA8280075; Wed, 2 Feb 2022 09:18:04 +0100 (CET) From: Alexander Stein To: Marek Vasut , Stefan Agner , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Fabio Estevam Subject: [PATCH v2 1/2] drm: mxsfb: Use dev_err_probe() helper Date: Wed, 2 Feb 2022 09:17:54 +0100 Message-Id: <20220202081755.145716-2-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220202081755.145716-1-alexander.stein@ew.tq-group.com> References: <20220202081755.145716-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexander Stein , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Use the dev_err_probe() helper, instead of open-coding the same operation. This also adds a nice hint in /sys/kernel/debug/devices_deferred. Reviewed-by: Marek Vasut Signed-off-by: Alexander Stein --- drivers/gpu/drm/mxsfb/mxsfb_drv.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c b/drivers/gpu/drm/mxsfb/mxsfb_drv.c index 375f26d4a417..c4da358f2154 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c @@ -258,8 +258,7 @@ static int mxsfb_load(struct drm_device *drm, ret = mxsfb_attach_bridge(mxsfb); if (ret) { - if (ret != -EPROBE_DEFER) - dev_err(drm->dev, "Cannot connect bridge: %d\n", ret); + dev_err_probe(drm->dev, ret, "Cannot connect bridge\n"); goto err_vblank; } From patchwork Wed Feb 2 08:17:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 12732695 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCD92C433F5 for ; Wed, 2 Feb 2022 08:18:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0559B10F9E7; Wed, 2 Feb 2022 08:18:11 +0000 (UTC) Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id A2AF910F9E9 for ; Wed, 2 Feb 2022 08:18:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1643789888; x=1675325888; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=upUdRNc2H9LGx6pOVpcm0rc5dRiRMZ/3v9/QOVk8QmY=; b=pGhPnHINyLNH7dUevVlErbipW7MdsXelL9pfc61QZ6XAmvMsEyhOf+Vd FT/SMMFnH9HAlJaNR3D2bjqqVEJmqSkhsZAZK3PKjJZMdSiLZnDvuEXt2 mjGN5nr/L1T6ARCbLLYnBQIHkYniFv8GBVAKiVY8GOYzQJUp7XBLjKaaW mP8yYFeJF9S9KwjFe71hlmT6mbD4B80Xai9wMqLNO7G027Au4ko+GHTNB 6e4fWYphKyz8k19s1lLdXdJBfOoXi8UE7zq+ZGUe8iX+KZpYmDM8uTPzW +fGlZmDDqAHY7NI4T2p0oIPXReiz8dloiil/EUjZjhHbKrabyvnNPrwdO Q==; X-IronPort-AV: E=Sophos;i="5.88,336,1635199200"; d="scan'208";a="21844621" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 02 Feb 2022 09:18:04 +0100 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Wed, 02 Feb 2022 09:18:04 +0100 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Wed, 02 Feb 2022 09:18:04 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1643789884; x=1675325884; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=upUdRNc2H9LGx6pOVpcm0rc5dRiRMZ/3v9/QOVk8QmY=; b=hAPzMN8iZFz7B2++PM1hvSL2T7NxC9DQQUVX3Q46Vh2kkBhdK4EmymEt AbNMtdp4DZNilvi+woZZY6ubPzultbmx9AH4vmluCnFs4D/6oAI8XslaQ x5nEf0qoIoCm75XHKrRyni/m93wM1+pmJ77AeLkRRzNPWDD3i+fGOi/0v CayNVmmZKmeo8sq59wZqIzo3I7o53t8hbDuT8SeJU58IolSgYZUUcVIuU jyfyzkYjpw4QJyf49UiK7rtrmrE3I3sMcLJByajSP9LUenmdJMhl0rsE7 BLdHHD1H/wk27yLmVs98I2UEqC3ZNT+7FYVA1zKx/A2pD6seCPYJS/evw g==; X-IronPort-AV: E=Sophos;i="5.88,336,1635199200"; d="scan'208";a="21844620" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 02 Feb 2022 09:18:04 +0100 Received: from steina-w.tq-net.de (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 9A03E280065; Wed, 2 Feb 2022 09:18:04 +0100 (CET) From: Alexander Stein To: Marek Vasut , Stefan Agner , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Fabio Estevam Subject: [PATCH v2 2/2] drm: mxsfb: Fix NULL pointer dereference Date: Wed, 2 Feb 2022 09:17:55 +0100 Message-Id: <20220202081755.145716-3-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220202081755.145716-1-alexander.stein@ew.tq-group.com> References: <20220202081755.145716-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexander Stein , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" mxsfb should not never dereference the NULL pointer which drm_atomic_get_new_bridge_state is allowed to return. Assume a fixed format instead. Fixes: commit b776b0f00f24 ("drm: mxsfb: Use bus_format from the nearest bridge if present") Signed-off-by: Alexander Stein --- drivers/gpu/drm/mxsfb/mxsfb_kms.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm/mxsfb/mxsfb_kms.c index 0655582ae8ed..4cfb6c001679 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c @@ -361,7 +361,11 @@ static void mxsfb_crtc_atomic_enable(struct drm_crtc *crtc, bridge_state = drm_atomic_get_new_bridge_state(state, mxsfb->bridge); - bus_format = bridge_state->input_bus_cfg.format; + if (!bridge_state) + bus_format = MEDIA_BUS_FMT_FIXED; + else + bus_format = bridge_state->input_bus_cfg.format; + if (bus_format == MEDIA_BUS_FMT_FIXED) { dev_warn_once(drm->dev, "Bridge does not provide bus format, assuming MEDIA_BUS_FMT_RGB888_1X24.\n"