From patchwork Sat Dec 29 12:57:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 10744843 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AD7CB13BF for ; Sat, 29 Dec 2018 12:58:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9CC51289EA for ; Sat, 29 Dec 2018 12:58:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9149628A1D; Sat, 29 Dec 2018 12:58:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 42C0D289EA for ; Sat, 29 Dec 2018 12:58:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mB297IEAE1snGcheEHOFbaS67duo9nbCv0j6lBfwT7U=; b=isuTSY2J+YxIwT /LTKi/9lAFb3WNj092ioqVb83IDR8qbkiTebDzkxbf0revsCBsJX7S6DkYVtrLDmM3uuazQkbcrr0 ALIheUVsjXefnuR8DEPxbGnFU/ItfG9v1+vktBmJDUpUG3+rJ6yMaly6xi+BBorxZwqe0ezr/Wl5U kn8zWOiO4s//B73xCo1oConyKes8b5USh/y2LANvGlwmTnVE9kPojHJo9uZdLLQt47rlIbIryNPkx NmnrFKh+bYjenAEqk+q6MtsEqktQdlH67vpj3Ym6tYZeH9fVKbomqzeAMsnFYYHsDsquES/oRkhio yCpt3EFXISLo9Xj3rBmA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gdEBk-0003AC-2T; Sat, 29 Dec 2018 12:58:00 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gdEBW-0002wh-ES; Sat, 29 Dec 2018 12:57:47 +0000 Received: by mail-wm1-x341.google.com with SMTP id f188so21506483wmf.5; Sat, 29 Dec 2018 04:57:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xIicdGAZhx3oX8Do8U6owJozuwFheS9BvjevYH1ytJA=; b=vSUJsCZJay6P1s9+cUUsg4EyQY9B6g4wPoUkRr8ugPyFd3BGS7dx8WDQOHQvZTJeKJ dUTXEIadRwkCclQbLgGyaYVodzD+2fQE12cyRzh7sNQ6ud2O1TyrnO6yYqGS+GzYv5hR seYqOs5MAMtjG7Ltrqy5DkmNkRONLjnVWAp8Fx1cUow2JaSlRZNK66CUiTtb1OR0h4Ne D3lARx2Hp3r2b4Ib3diJs5ckbOayVD94K7QHwjZt4Le2IyNFrE8utt8YNY4gIh6bZ6mN 9HkhTH7Cc/AggtlefXDjnlZd7s4KU2ld+/Vw0KaPDlWZRiE/GToc+LBvjW9kKC+pwV/P xvpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xIicdGAZhx3oX8Do8U6owJozuwFheS9BvjevYH1ytJA=; b=MMaARdG4osbjdO0Rq90uNwLKfAtLTUoqZ8O1afAMNNCjN+SDZcd61thh+NYV+SxcaL cw/3wFsTsrbtLLhzh3Uw0kklIn+XwIV1kEj+85JbsBnDO8aOgy7+ixU/fzejew7V87Yi CaGtUQ6DnyT2Lkef+k+hcm6XVLkRftqGQpvXqlpgxS5E1SmOhW3FfFkJIQ1rtoL/R2CZ cOjR2KsOY8QkH/wPstRk7i2X+eYxcCiRJCsW/+WwcvHdSbZRb/yPo1O5VN646pAodn2P xBSQSQeaB/RmHsekZzt3joi/iX81feHnHtlGPwzl7J6mTac2GyjzmUx8EVqfbbKd80w/ eW1Q== X-Gm-Message-State: AJcUukcftBEIa9Ff8xN1ybKs1yO9Wq+TwGnRTe2Dno559poR7vf3gOA6 DiuY+C6IoyKYRubRmXG86P/eFcfp X-Google-Smtp-Source: ALg8bN5/l9t6q0dLNUkjDZUDqscN0lPtglIgBb1+hFQqy60FkUOIXZDXWxyVoBbpJYIP5/WaH2GCWA== X-Received: by 2002:a1c:1a43:: with SMTP id a64mr25464631wma.136.1546088254367; Sat, 29 Dec 2018 04:57:34 -0800 (PST) Received: from blackbox.darklights.net (p200300DCD7294600914F24DE1716D3FC.dip0.t-ipconnect.de. [2003:dc:d729:4600:914f:24de:1716:d3fc]) by smtp.googlemail.com with ESMTPSA id h17sm31987059wrt.59.2018.12.29.04.57.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Dec 2018 04:57:33 -0800 (PST) From: Martin Blumenstingl To: linux-amlogic@lists.infradead.org, khilman@baylibre.com, linus.walleij@linaro.org Subject: [PATCH 1/3] ARM: dts: meson8b: odroidc1: mark the SD card detection GPIO active-low Date: Sat, 29 Dec 2018 13:57:09 +0100 Message-Id: <20181229125711.5205-2-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20181229125711.5205-1-martin.blumenstingl@googlemail.com> References: <20181229125711.5205-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181229_045746_481588_50701C18 X-CRM114-Status: GOOD ( 13.66 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linus.luessing@c0d3.blue, bgolaszewski@baylibre.com, balbes-150@yandex.ru, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Martin Blumenstingl , linux@roeck-us.net Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP After commit 89a5e15bcba87d ("gpio/mmc/of: Respect polarity in the device tree") SD cards are not detected anymore. The CD GPIO is "active low" on Odroid-C1. The MMC dt-bindings specify: "[...] using the "cd-inverted" property means, that the CD line is active high, i.e. it is high, when a card is inserted". Fix the description of the SD card by marking it as GPIO_ACTIVE_LOW and drop the "cd-inverted" property. This makes the definition consistent with the existing dt-bindings and fixes the check whether an SD card is inserted. Fixes: e03efbce6bebf5 ("ARM: dts: meson8b-odroidc1: add microSD support") Signed-off-by: Martin Blumenstingl Reviewed-by: Linus Walleij Tested-by: Anand Moon --- arch/arm/boot/dts/meson8b-odroidc1.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/meson8b-odroidc1.dts b/arch/arm/boot/dts/meson8b-odroidc1.dts index 58669abda259..070d69889f3e 100644 --- a/arch/arm/boot/dts/meson8b-odroidc1.dts +++ b/arch/arm/boot/dts/meson8b-odroidc1.dts @@ -273,8 +273,7 @@ cap-sd-highspeed; disable-wp; - cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>; - cd-inverted; + cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>; vmmc-supply = <&tflash_vdd>; vqmmc-supply = <&tf_io>; From patchwork Sat Dec 29 12:57:10 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 10744845 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ED6F913BF for ; Sat, 29 Dec 2018 12:58:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DE732289EA for ; Sat, 29 Dec 2018 12:58:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D31D228A22; Sat, 29 Dec 2018 12:58:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 70C77289EA for ; Sat, 29 Dec 2018 12:58:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FgEqmwJfpvDZAo1xLooVcYfJyljQpTDg61Xd8CF03JI=; b=KZ6ZmjIF6gsW2o 5uxozi+w53xpsmQvxKS7RHULE5ditaXqyRBQdKjg53iA1seb7tOxmI48VaGGHc5y72h1oHNzVTWB7 fzIT2BRW/oeg/BLpEHWFcOe5xiv/JMy+LJwwIEUtCJWMs14Bdo0hj0xKTIyRfLX9L+WqaKoO7UbSt mybDyDIFYUDOVt5UJtSXI/AfBIQxj4r4f7txElk2xneoRzRzzKvunJbisivpVaxDUTL1LA13B3ZBO 9S03u8JV7Hr1lm9yc4Qjhwcp2xDYSMGaI6e3Iy7NMzAVW8RkbxL5TJXwnz6IGW0P3xZTziTcdLyzo rOTS5/tmtWGc9C/3FVbA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gdEBz-0003Ry-9l; Sat, 29 Dec 2018 12:58:15 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gdEBX-0002wl-Nw; Sat, 29 Dec 2018 12:57:49 +0000 Received: by mail-wr1-x441.google.com with SMTP id x10so23030967wrs.8; Sat, 29 Dec 2018 04:57:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=VlAqZUJKjhpDiruDFrlNjds26NWgcPdIHOc9gfNOZDw=; b=YWvhDm0AIwD9W5CR4hxwB9wQM2KP/7L0i9j7aD1eEFABQNrP8Svf0auI8t44vA4Aj7 u76e+fiMzYUvNuMG0Fb0p5GOm354hoN4/zjkDLwxQSkn+3zJXi3jgCFmPRhuG6fiDAtW IfEAQANGeMa5jWqjUTH7DhnF0Illwl6a0um15uy7ZmnuFZNFv0EepJPqfZroo5P23dYs UfUBbuqEfNSLLGAzqTdb2FOMOHOHGPtG/v1jiAyJ6t1+Bh/p1aq6q9EvcJkGSWJQqXyM bEkUfKYbiKB19Syc1Ppueb1YgnG6A0k36hgg4cN3fWbeKl4IGkv/jCiCell9LQqEHFzc aEPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=VlAqZUJKjhpDiruDFrlNjds26NWgcPdIHOc9gfNOZDw=; b=V7TBBI6C4JPkXCElG9RnUYdsFjF4kdBA5XJCMe/2F77ER1uDuwCZvvdczejf1Npc0x nZln8tBsTl21rhAmf0ZWUcaqQzPl1TM9RNPw8KB6tgZX+3LvDGCXnwWc0ucrIyOM++1I 4Qr0MQV1Z9oqBtKyHA8AJJI7aFcEMSQoZeZfkQjNZp0ifM/idSMPG/b0i/NqRUDCOJOP +R611ifkNScO90CAyGS5SHy+wSVtV4UEIEN/TNZW1sDwcT9Lt3bZj/JSWs2qiKCa+QWs Oes6ezlAsRKnb5D52joam0t8zfTLfmtxXp6RPolHlbNoa9JiQj7CR1kmR77bDQi2NgJV ytGg== X-Gm-Message-State: AJcUukcWuZUHtdcuRUQ13SNLR7mrKTQpEcqKsa8tgxa+k5tHh4BdBdFj nblWM61ow4cxsAWkraR83QDYyqen X-Google-Smtp-Source: ALg8bN7xzdiR3LRxK+u6K8d/bbdwUQJ88L0TyNFqvdygQEPhOt8U5L8VvlqqHSd8UJjMYifFUIQMSA== X-Received: by 2002:adf:a743:: with SMTP id e3mr27143292wrd.56.1546088255653; Sat, 29 Dec 2018 04:57:35 -0800 (PST) Received: from blackbox.darklights.net (p200300DCD7294600914F24DE1716D3FC.dip0.t-ipconnect.de. [2003:dc:d729:4600:914f:24de:1716:d3fc]) by smtp.googlemail.com with ESMTPSA id h17sm31987059wrt.59.2018.12.29.04.57.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Dec 2018 04:57:34 -0800 (PST) From: Martin Blumenstingl To: linux-amlogic@lists.infradead.org, khilman@baylibre.com, linus.walleij@linaro.org Subject: [PATCH 2/3] ARM: dts: meson8b: ec100: mark the SD card detection GPIO active-low Date: Sat, 29 Dec 2018 13:57:10 +0100 Message-Id: <20181229125711.5205-3-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20181229125711.5205-1-martin.blumenstingl@googlemail.com> References: <20181229125711.5205-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181229_045747_777055_1585DC03 X-CRM114-Status: GOOD ( 14.27 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linus.luessing@c0d3.blue, bgolaszewski@baylibre.com, balbes-150@yandex.ru, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Martin Blumenstingl , linux@roeck-us.net Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP After commit 89a5e15bcba87d ("gpio/mmc/of: Respect polarity in the device tree") SD cards are not detected anymore. The CD GPIO is "active low" on the EC-100. The MMC dt-bindings specify: "[...] using the "cd-inverted" property means, that the CD line is active high, i.e. it is high, when a card is inserted". Fix the description of the SD card by marking it as GPIO_ACTIVE_LOW and drop the "cd-inverted" property. This makes the definition consistent with the existing dt-bindings and fixes the check whether an SD card is inserted. Fixes: bbedc1f1d90e33 ("ARM: dts: meson8b: Add support for the Endless Mini (EC-100)") Signed-off-by: Martin Blumenstingl Reviewed-by: Linus Walleij --- arch/arm/boot/dts/meson8b-ec100.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/meson8b-ec100.dts b/arch/arm/boot/dts/meson8b-ec100.dts index 0872f6e3abf5..d50fc2f60fa3 100644 --- a/arch/arm/boot/dts/meson8b-ec100.dts +++ b/arch/arm/boot/dts/meson8b-ec100.dts @@ -205,8 +205,7 @@ cap-sd-highspeed; disable-wp; - cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>; - cd-inverted; + cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>; vmmc-supply = <&vcc_3v3>; }; From patchwork Sat Dec 29 12:57:11 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Blumenstingl X-Patchwork-Id: 10744849 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E94E913BF for ; Sat, 29 Dec 2018 12:58:20 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D7DED289EA for ; Sat, 29 Dec 2018 12:58:20 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CA2CD28A1D; Sat, 29 Dec 2018 12:58:20 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7172C289EA for ; Sat, 29 Dec 2018 12:58:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SHrEeTC2WDqljuLF+5KjXiE25+QBpBwBL7tapaLfFos=; b=TsuQc5Vu5m63O9 0Hs1Nim1dQjg4Fp6amMJvhDjPt8hRTvPU2x6qa3a8L7IX1rNdeblRoYi3bKYT/Ylbg9Um084WGX+e sBxs9c/laxE0KVkipYdyqEWvo7oj64+OqPGVJpjP+hYmNlXhqL2giv4WNTiQID9/d6yOC7UGbcN8G 5lKwodsJCaXiCh95Urhk3HKvyH6XWWOKt9mRWN3XTSLA1KZZn0RBiCdEX1D5XYLD3T/vpd4sFvYtZ YEiWf5TG+66CpgaelARDCNxu+7ECh6eSKbL8xiVA4DvY6+NYbrTVWfN7eWxh0N++UUsqlD+uR8rsb TVm2Bw3kZv7q0NRBt2rA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gdEC2-0003Ud-Be; Sat, 29 Dec 2018 12:58:18 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gdEBY-0002wn-U6; Sat, 29 Dec 2018 12:57:51 +0000 Received: by mail-wm1-x342.google.com with SMTP id t200so9547115wmt.0; Sat, 29 Dec 2018 04:57:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=0GgHqqxZVFXgmfbHJtxlutcHlK9nbAzoBbUIQBCbANI=; b=uwIjXHkDkkPZPetAQRlQ8Dx0nMlgoymY6ulxb1HBCaPhu8NTZtSOApAgBwpRh19a/1 bJbenQV6tpB8P8pR6L9vBsubpz0wWKquymP9F3fi7i7ljO4b3qjd/Gj/PjCPao5HNaH8 DYKyhBrVS7m5m9egGQZWVop04jtTnopuEsKIJpJLRgtvUoK7FmHfu1Thk7FodE1b/6f8 1AOVC6YL/0GSrugej4VjDM4F7gTdQseqG1gRXPEs1cUOWQyjGDokJJy/fPDrMVLaaGFS jSegRpMHu3+5vF7o2irUWR4wxk25ZbhoH5O86aobJsYfQdVsqLPB72wudis5HEm3RXWg cHUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0GgHqqxZVFXgmfbHJtxlutcHlK9nbAzoBbUIQBCbANI=; b=UyGAu9hmD/2w8b+FLHr9VdbKJrweQnaXsW0ZelU/ebpNhcZqLz9FbZhqvn6oJ1flHV s3t+HDO2YtEp43AR/45Bw2p9R2hHQcrjmTb+qLJ2LUnnc1l+PL3R4pcAwh2b8I45uIgk FIz1LA5nzAypBpgRH1IUzLn+3VPteG8IHmr/up9utYBc2Vku6etEV/JE3syWkdhIOkMI gMS+MBKY9OEn+ID4CxgKvWiVvl5XIVthSckoDTV2GfdX+K7m5Kr/ZsZH9E5PkXu7bVQR AS1XZthfsLXJcjChmL953OPqCtPEesoBFZwV6TlAeNFkOlwt5Hy5aJwsJhz0m7HW50vl mTCg== X-Gm-Message-State: AJcUukc35Wu0Tfq0LQe4JD6eC6aJNo/7eszwQkaT3DtnMikWM/HIK1KU whLy4gGlFbU0lWLFIfMM3HYdjmoe X-Google-Smtp-Source: AFSGD/Xq2dNuPD5B9Jyeeixk2jL9dKx4017uH/Ni5DQpYTDxU0ptgJE384Bv+wvOFtev/8VZrZfeOg== X-Received: by 2002:a1c:5fd7:: with SMTP id t206mr28045169wmb.145.1546088256856; Sat, 29 Dec 2018 04:57:36 -0800 (PST) Received: from blackbox.darklights.net (p200300DCD7294600914F24DE1716D3FC.dip0.t-ipconnect.de. [2003:dc:d729:4600:914f:24de:1716:d3fc]) by smtp.googlemail.com with ESMTPSA id h17sm31987059wrt.59.2018.12.29.04.57.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Dec 2018 04:57:36 -0800 (PST) From: Martin Blumenstingl To: linux-amlogic@lists.infradead.org, khilman@baylibre.com, linus.walleij@linaro.org Subject: [PATCH 3/3] ARM: dts: meson8m2: mxiii-plus: mark the SD card detection GPIO active-low Date: Sat, 29 Dec 2018 13:57:11 +0100 Message-Id: <20181229125711.5205-4-martin.blumenstingl@googlemail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20181229125711.5205-1-martin.blumenstingl@googlemail.com> References: <20181229125711.5205-1-martin.blumenstingl@googlemail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181229_045749_163482_90765B70 X-CRM114-Status: GOOD ( 14.48 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linus.luessing@c0d3.blue, bgolaszewski@baylibre.com, balbes-150@yandex.ru, linux-mmc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Martin Blumenstingl , linux@roeck-us.net Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+patchwork-linux-amlogic=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP After commit 89a5e15bcba87d ("gpio/mmc/of: Respect polarity in the device tree") SD cards are not detected anymore. The CD GPIO is "active low" on the MXIII-Plus. The MMC dt-bindings specify: "[...] using the "cd-inverted" property means, that the CD line is active high, i.e. it is high, when a card is inserted". Fix the description of the SD card by marking it as GPIO_ACTIVE_LOW and drop the "cd-inverted" property. This makes the definition consistent with the existing dt-bindings and fixes the check whether an SD card is inserted. Fixes: 35ee52bea66c74 ("ARM: dts: meson8m2: add support for the Tronsmart MXIII Plus") Signed-off-by: Martin Blumenstingl Reviewed-by: Linus Walleij --- arch/arm/boot/dts/meson8m2-mxiii-plus.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/meson8m2-mxiii-plus.dts b/arch/arm/boot/dts/meson8m2-mxiii-plus.dts index f5853610b20b..6ac02beb5fa7 100644 --- a/arch/arm/boot/dts/meson8m2-mxiii-plus.dts +++ b/arch/arm/boot/dts/meson8m2-mxiii-plus.dts @@ -206,8 +206,7 @@ cap-sd-highspeed; disable-wp; - cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_HIGH>; - cd-inverted; + cd-gpios = <&gpio CARD_6 GPIO_ACTIVE_LOW>; vmmc-supply = <&vcc_3v3>; };