From patchwork Mon Feb 7 03:09:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shin'ichiro Kawasaki X-Patchwork-Id: 12736850 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E14FCC433F5 for ; Mon, 7 Feb 2022 05:53:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234341AbiBGFut (ORCPT ); Mon, 7 Feb 2022 00:50:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350001AbiBGDLE (ORCPT ); Sun, 6 Feb 2022 22:11:04 -0500 Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2D3BC043181; Sun, 6 Feb 2022 19:11:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1644203463; x=1675739463; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=TUe9FJuEf7BWKrxSIxqPYK0eG0nCVdO3BScCuHtRrAI=; b=leIMmFvB1fNOU4iQFEHvX7KHpF9wO7gQ9e0z5xOs48vhn92d0U1RWXUi JMVEQGYTHJ2I2R+pnIGcKxuR85L2/sa3KJcMQQ2w7jf8aQVNbAJDjR4Mx CEERBX7S86t/1LBE66624X/88jZmfcSGKDmyv25TnfPEJi7c2iSEKO8RJ rKXH+QcKwGF9fsC5khI3Hfiv8oS7i+ai29oyiRNJAKW2qMOb42R7RF25N nkjRp21EpTIKZ3UVKk92PZjQYFcM/+gF3DjGJTD7rXv2Y8j28FhiZdi3X p6pRieV1zck0NgYfe3kabeeyoOdtdRdA92b4rQD9r0iUgjbNOwsM/tRI2 A==; X-IronPort-AV: E=Sophos;i="5.88,348,1635177600"; d="scan'208";a="304195990" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 07 Feb 2022 11:10:00 +0800 IronPort-SDR: FoKXDcymv3it7luYCwS9KhkSSSYmQnkBqJxoIxyZszo92L9yW747ZxZkkW3MKRf4nzbRN6AFnZ HfXK7bZ6nssBub7vxommYVbJ8bpBbsRGshMoc34te5MYDu4ZvaCkz6qgnaG3GKoFaMiB6RfP2d MNBpXdddSRm6tgq/ROVlkc7gnPPxlIfn5ttWVodoUqYnwBLZbdz9fjxQ7Bv/GwF5W8xIVIZ7EE ++OU8OTdDGQBH04DMX0ozaya6jbmPWweUatzlCFrp0PkhCFHOGwobbFl3//5MoFTcKuFEvV454 /mo0pU03RR8JQ7t7zoqpnyrc Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2022 18:41:51 -0800 IronPort-SDR: LpPZkThfz21jAcl+k6Nr9RI2EQ711559IvHwRHwYXeEiOiMkV0C+tL6mOk9d6ISpjZgpWWdBqd v3T1Zdx90vqRJ/5Kl01XcAr+mUl26N1a9GEMzERvWIL2waQxcHyBHYX/8ue/0OW9kgpj+bULdF o1EQfkogcAChzZGdmis4B0iqSH6tb9n6ENFD9FwtIecSbMcgwlDksh8pnKnmCJoaoH0KsZhVVV bupuxtyQWrvIFli0xRPDDjqU/ejN3LmCikyT+CE8e8KWnUxoT120bVRfWMKdOg3+WAHRTYbAO7 txQ= WDCIronportException: Internal Received: from shindev.dhcp.fujisawa.hgst.com (HELO shindev.fujisawa.hgst.com) ([10.149.52.173]) by uls-op-cesaip01.wdc.com with ESMTP; 06 Feb 2022 19:09:59 -0800 From: Shin'ichiro Kawasaki To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Cc: Naohiro Aota , Johannes Thumshirn , Damien Le Moal , Shin'ichiro Kawasaki Subject: [PATCH 1/7] common/rc: fix btrfs mixed mode usage in _scratch_mkfs_sized Date: Mon, 7 Feb 2022 12:09:52 +0900 Message-Id: <20220207030958.230618-2-shinichiro.kawasaki@wdc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220207030958.230618-1-shinichiro.kawasaki@wdc.com> References: <20220207030958.230618-1-shinichiro.kawasaki@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org The helper function _scratch_mkfs_sized needs a couple of improvements for btrfs. At first, the function adds --mixed option to mkfs.btrfs when the filesystem size is smaller then 256MiB, but this threshold is no longer correct and it should be 109MiB. Secondly, the --mixed option shall not be specified to mkfs.btrfs for zoned devices, since zoned devices does not allow mixing metadata blocks and data blocks. Suggested-by: Naohiro Aota Signed-off-by: Shin'ichiro Kawasaki --- common/rc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/common/rc b/common/rc index b3289de9..eb2493d1 100644 --- a/common/rc +++ b/common/rc @@ -1075,10 +1075,10 @@ _scratch_mkfs_sized() ;; btrfs) local mixed_opt= - # minimum size that's needed without the mixed option. - # Ref: btrfs-prog: btrfs_min_dev_size() - # Non mixed mode is also the default option. - (( fssize < $((256 * 1024 *1024)) )) && mixed_opt='--mixed' + # Mixed option is required when the filesystem size is small and + # the device is not zoned. Ref: btrfs-progs: btrfs_min_dev_size() + (( fssize < $((109 * 1024 * 1024)) )) && + ! _scratch_btrfs_is_zoned && mixed_opt='--mixed' $MKFS_BTRFS_PROG $MKFS_OPTIONS $mixed_opt -b $fssize $SCRATCH_DEV ;; jfs) From patchwork Mon Feb 7 03:09:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shin'ichiro Kawasaki X-Patchwork-Id: 12736855 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3147C4167E for ; Mon, 7 Feb 2022 05:53:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238901AbiBGFuz (ORCPT ); Mon, 7 Feb 2022 00:50:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350017AbiBGDLF (ORCPT ); Sun, 6 Feb 2022 22:11:05 -0500 Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB39CC043182; Sun, 6 Feb 2022 19:11:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1644203464; x=1675739464; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=d4ENreMGrlKCk5cIjSx96VRXwooXyBj4UXgKGLLw7K0=; b=EqWQ53yvJfOAnBCqwOF7PKxbDSh01WdKIwiguaE4qDM/yHah+MSSyd+V 5sRvC/fRl3L1QZgoj0Gxt0bRFkrDWIFMg/EBON+7GEnuFdO90yjfPaOyk STVVZ4/uIoyjwXfY1qeP5nWsElACRzyLqZiGKthslw9lIEvduVXIaDNXj qWJEDlG94d6kYxZeW+Euvj3r2ci/Vtb3yTcJcO38St+gGOSZey/Bt/uHZ H8org0MeoiQQjdJy3zhWWN2LjtogRmtwK0WFXIKyriYZAh0wxEIikKVb2 82ld5mhfmWikD2DdQgUiuZcqoYiEkuWq2ne5EYzJpXSxpxvcsnVzf213R g==; X-IronPort-AV: E=Sophos;i="5.88,348,1635177600"; d="scan'208";a="304195994" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 07 Feb 2022 11:10:01 +0800 IronPort-SDR: RL810I30BNe3WiresMEiSl33WzDL5gRdjuEXuL2kR7dJB+Mxkzs+FaIVNUl4K0pCpd4b4o+yo3 6HjqQPiveJlF9M0BxanTB+2QA9o2zdRrDISO230YXq24gRvEM8NLAAa73MmlzDNOp/x7fluM5G o6Z8BwcKhfnc2VL2XuU/MkMPBooi1vY1X0iSuw5L9xVAwpZdeVFpt2h0loJTbXlMnedmwu1+2s AVGNx4YwwiaxpP8/L3xm8gkfd1Mwtdu2W7UKRSZ93i08tiykkYleqTosax3tBmjn1YaMw+N+qW UqRMvYgzanK/0ckPuooYZ/U0 Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2022 18:41:52 -0800 IronPort-SDR: pbefs6HvWwLjbbNkxCYc26fmPzlaz5kZ6pE3RMjbiUypbErEzDlLiAbA1NSbQ4oEYhKS0UyXa0 5V76FmWVC1o8LfamlQr/pblChQJuWfBK4n4SbVgKpYrOvJk+T2OahaX/LG/JWaOmn/F3qjxnom vx6+vDqNaEQ8uTjiqZ31XLQYK00JpQwa4q7VGzHlLdjbtqJZJnwixeBf3cf0tyaxDsqNPIMQz8 FqEpmUzrmUDfYYk4apHmWr8Q5aD3vq/Y72HNo9GsBWGMeL/m9hdDb8oPjfYLjJx0w3qHIt6Vcd jZQ= WDCIronportException: Internal Received: from shindev.dhcp.fujisawa.hgst.com (HELO shindev.fujisawa.hgst.com) ([10.149.52.173]) by uls-op-cesaip01.wdc.com with ESMTP; 06 Feb 2022 19:10:00 -0800 From: Shin'ichiro Kawasaki To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Cc: Naohiro Aota , Johannes Thumshirn , Damien Le Moal , Shin'ichiro Kawasaki Subject: [PATCH 2/7] generic/{171,172,173,174,204}: check _scratch_mkfs_sized return code Date: Mon, 7 Feb 2022 12:09:53 +0900 Message-Id: <20220207030958.230618-3-shinichiro.kawasaki@wdc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220207030958.230618-1-shinichiro.kawasaki@wdc.com> References: <20220207030958.230618-1-shinichiro.kawasaki@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org The test cases generic/{171,172,173,174,204} call _scratch_mkfs before _scratch_mkfs_sized, and they do not check return code of _scratch_mkfs_sized. Even if _scratch_mkfs_sized failed, _scratch_mount after it cannot detect the sized mkfs failure because _scratch_mkfs already created a file system on the device. This results in unexpected test condition of the test cases. To avoid the unexpected test condition, check return code of _scratch_mkfs_sized in the test cases. Suggested-by: Naohiro Aota Signed-off-by: Shin'ichiro Kawasaki --- tests/generic/171 | 2 +- tests/generic/172 | 2 +- tests/generic/173 | 2 +- tests/generic/174 | 2 +- tests/generic/204 | 3 ++- 5 files changed, 6 insertions(+), 5 deletions(-) diff --git a/tests/generic/171 b/tests/generic/171 index fb2a6f14..f823a454 100755 --- a/tests/generic/171 +++ b/tests/generic/171 @@ -42,7 +42,7 @@ sz_bytes=$((nr_blks * 8 * blksz)) if [ $sz_bytes -lt $((32 * 1048576)) ]; then sz_bytes=$((32 * 1048576)) fi -_scratch_mkfs_sized $sz_bytes >> $seqres.full 2>&1 +_scratch_mkfs_sized $sz_bytes >> $seqres.full 2>&1 || _fail "mkfs failed" _scratch_mount >> $seqres.full 2>&1 rm -rf $testdir mkdir $testdir diff --git a/tests/generic/172 b/tests/generic/172 index ab5122fa..383824b9 100755 --- a/tests/generic/172 +++ b/tests/generic/172 @@ -40,7 +40,7 @@ umount $SCRATCH_MNT file_size=$((768 * 1024 * 1024)) fs_size=$((1024 * 1024 * 1024)) -_scratch_mkfs_sized $fs_size >> $seqres.full 2>&1 +_scratch_mkfs_sized $fs_size >> $seqres.full 2>&1 || _fail "mkfs failed" _scratch_mount >> $seqres.full 2>&1 rm -rf $testdir mkdir $testdir diff --git a/tests/generic/173 b/tests/generic/173 index 0eb313e2..e1493278 100755 --- a/tests/generic/173 +++ b/tests/generic/173 @@ -42,7 +42,7 @@ sz_bytes=$((nr_blks * 8 * blksz)) if [ $sz_bytes -lt $((32 * 1048576)) ]; then sz_bytes=$((32 * 1048576)) fi -_scratch_mkfs_sized $sz_bytes >> $seqres.full 2>&1 +_scratch_mkfs_sized $sz_bytes >> $seqres.full 2>&1 || _fail "mkfs failed" _scratch_mount >> $seqres.full 2>&1 rm -rf $testdir mkdir $testdir diff --git a/tests/generic/174 b/tests/generic/174 index 1505453e..c7a177b8 100755 --- a/tests/generic/174 +++ b/tests/generic/174 @@ -43,7 +43,7 @@ sz_bytes=$((nr_blks * 8 * blksz)) if [ $sz_bytes -lt $((32 * 1048576)) ]; then sz_bytes=$((32 * 1048576)) fi -_scratch_mkfs_sized $sz_bytes >> $seqres.full 2>&1 +_scratch_mkfs_sized $sz_bytes >> $seqres.full 2>&1 || _fail "mkfs failed" _scratch_mount >> $seqres.full 2>&1 rm -rf $testdir mkdir $testdir diff --git a/tests/generic/204 b/tests/generic/204 index a3dabb71..b5deb443 100755 --- a/tests/generic/204 +++ b/tests/generic/204 @@ -35,7 +35,8 @@ _scratch_mkfs 2> /dev/null | _filter_mkfs 2> $tmp.mkfs > /dev/null [ $FSTYP = "xfs" ] && MKFS_OPTIONS="$MKFS_OPTIONS -l size=16m -i maxpct=50" SIZE=`expr 115 \* 1024 \* 1024` -_scratch_mkfs_sized $SIZE $dbsize 2> /dev/null > $tmp.mkfs.raw +_scratch_mkfs_sized $SIZE $dbsize 2> /dev/null > $tmp.mkfs.raw \ + || _fail "mkfs failed" cat $tmp.mkfs.raw | _filter_mkfs 2> $tmp.mkfs > /dev/null _scratch_mount From patchwork Mon Feb 7 03:09:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shin'ichiro Kawasaki X-Patchwork-Id: 12736852 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFD24C4332F for ; Mon, 7 Feb 2022 05:53:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235495AbiBGFut (ORCPT ); Mon, 7 Feb 2022 00:50:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350023AbiBGDLG (ORCPT ); Sun, 6 Feb 2022 22:11:06 -0500 Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBF2CC061A73; Sun, 6 Feb 2022 19:11:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1644203465; x=1675739465; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dqFAptI4CAvK6M8wR+plx0XzaNREix5nWvG4orfRMAg=; b=XpvkIudmsVwYXdfvRVxrEu3YI9mg2Tp/0r7mkkWgvbkPayzMFBccPi8J 2hI3Wj/ynKAXTYVvF11qPRvv/Slbe7dlTDCGq54miL58QSp/BYDHx9tNL ZpGO62dnX+6nlfihJxiG4r3gnylekQ6+pm8wgGBx6ueXhmO7RB61NqbC0 hb986S+jBDvKx4PeUUMx16QhbCr/4eg5DigZ3P6YThIM9Q3RTLbHaKyCi v8QRtekxAAed2Kl9suIRrR8L2o/B2ha5iyWRBvzwZmUavrZIqV1MvPZVN FZPNUlRvlnL9yu+C1SPmKkO9bUQkgR+JHKKrnFHd9OmHFbnbmAaQ4vFl1 A==; X-IronPort-AV: E=Sophos;i="5.88,348,1635177600"; d="scan'208";a="304195997" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 07 Feb 2022 11:10:02 +0800 IronPort-SDR: SdOoGQzB2Zm48iE5HGZVuZb2pRxbnhkRHh5soKkyDrvBmM8kIWM87T3DRCkBwMnEhPfS5E7fB4 8SJVOhq231bRoc3ajO+W/kicQB1Hw5v5yQFVhArBXPG4MlvpyNU6Ux6Sy6jjFbsdoHmuQiTigI 1UqOwraOtnS3ydG07MuXgjcBVqswTYcW2E1CSUeeaSxadFE4eRUtXa5JIYwgZimqDgh1LZOfaP i2yHJbfExoUbsnB0ydYINWKW8R2IHXtDQTTCHA35xuGVY2tkUgC+MPl+3tbZzIR/kTdarQisxS zzjzimXuk+DYK0J51cZE0mad Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2022 18:41:53 -0800 IronPort-SDR: SPduAgPqpHjDHi4kbUW4++2yG6CydfIH0z+JM0CoyBFWYpKHkL333gEEPc4u5BSct9Ambige/H ShtjhnhUCR7JkbHpzn6KeZiZieYRls7iebq1Tm1Od+0Mbx0NTcZmITNwuSPBK5K9NMedUSxa2n Tv/IViTSdoiJxTiCF4yXbSb6X6PLdbJ/bXyXBbKZYl4aMRGNX+PPiww6npn+Pp/ujaNsEMkB5U KPvzgKy9uwqiES6TxvrRvIP3wWQW8J0XzXWO8md3F5xOpzSNAq+MYYVWa09bGNYt7ByOoHP0WT WXM= WDCIronportException: Internal Received: from shindev.dhcp.fujisawa.hgst.com (HELO shindev.fujisawa.hgst.com) ([10.149.52.173]) by uls-op-cesaip01.wdc.com with ESMTP; 06 Feb 2022 19:10:02 -0800 From: Shin'ichiro Kawasaki To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Cc: Naohiro Aota , Johannes Thumshirn , Damien Le Moal , Shin'ichiro Kawasaki Subject: [PATCH 3/7] ext4/021: check _scratch_mkfs_sized return code Date: Mon, 7 Feb 2022 12:09:54 +0900 Message-Id: <20220207030958.230618-4-shinichiro.kawasaki@wdc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220207030958.230618-1-shinichiro.kawasaki@wdc.com> References: <20220207030958.230618-1-shinichiro.kawasaki@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org The test cases ext4/021 calls _scratch_mkfs before _scratch_mkfs_sized, and does not check return code of _scratch_mkfs_sized. Even if _scratch_mkfs_sized failed, _scratch_mount after it cannot detect the sized mkfs failure because _scratch_mkfs already created a file system on the device. This results in unexpected test condition. To avoid the unexpected test condition, check return code of _scratch_mkfs_sized. Suggested-by: Naohiro Aota Signed-off-by: Shin'ichiro Kawasaki --- tests/ext4/021 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ext4/021 b/tests/ext4/021 index 62768c60..a9277abf 100755 --- a/tests/ext4/021 +++ b/tests/ext4/021 @@ -24,7 +24,7 @@ _scratch_unmount # With 4k block size, this amounts to 10M FS instance. fssize=$((2560 * $blocksize)) -_scratch_mkfs_sized $fssize >> $seqres.full 2>&1 +_scratch_mkfs_sized $fssize >> $seqres.full 2>&1 || _fail "mkfs failed" _require_metadata_journaling $SCRATCH_DEV offset=0 From patchwork Mon Feb 7 03:09:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shin'ichiro Kawasaki X-Patchwork-Id: 12736848 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85560C3527E for ; Mon, 7 Feb 2022 05:51:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232281AbiBGFus (ORCPT ); Mon, 7 Feb 2022 00:50:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350022AbiBGDLG (ORCPT ); Sun, 6 Feb 2022 22:11:06 -0500 Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E59FEC043181; Sun, 6 Feb 2022 19:11:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1644203465; x=1675739465; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=pgEGgT9hg08/vaCtBuyGS4ntdQzvuj9kMy+3OGsW+xU=; b=S810yoD3N+bsH3zKwnhqmUrmWH++R9UupVaFQwv81ZX5HmhYOhravRNg DEW7209MTe4rL5MASoz+7PYuDI5a5K1FlNTXyImCpcgWo7bpay2Jh9H/Y StkVGGljZiTowFxVOiX4mJj7lc+x8yBabHxKAN+Zg4D/5qwi66i4nai64 YlC8Wvg2tQgvIbidfFq2KqafQBESctHzPmaqbR4LyL658SqjrrXG4kUrV CJGFb/dg3uvMoL9hhcvxDW0l9vwgd8BBQHW5uhzjxhty63fV28cfTajw3 1g+95r/ld0tDSzR/i8FW2+rjWSd4e9A9lrlMKhzv7eYexhAjvMnNPAkGV w==; X-IronPort-AV: E=Sophos;i="5.88,348,1635177600"; d="scan'208";a="304195999" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 07 Feb 2022 11:10:03 +0800 IronPort-SDR: kRcMPuqXnSOKJcyE0LeXgcC8Ac2ZeCYg2/+SAyJlqesVPEwJtGwKk+qT75+Q4HiXdIoa0sn0is fxjSaRNWBWwtjXHlgagL7R4GWijgcELGHpCj8JUESIdg2qy50q5zfLsS+GUJ1z91hrPswUOLWU dn0b0WlGHYOcsdM/as4n6MEsPuXScLXi02tebh6b1TTAmmZj7s0y4OQ0duUxlPeqHLSb30FakM VoFLxrpaeGjBRwEXCnC8nVBiUvMny8z6Dc1mH01oOIcyfoScvglvvQXNJ6cmIoplX1NJZy868L JEhw813yHNJJTffNwVdqO260 Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2022 18:41:55 -0800 IronPort-SDR: 5Ee+xOSvnhEzGBNBQ1/NLUpdCiE2eTBv90O1aeLNAvuTzq/dzZBia/Q7exeM+PrquFe++abj+s ddna2nAYJxmvJks0W5gH1vht2V1V4HbTdZsuSR1BG7oT3vD217SLtYL3HvzyjI2WVAHQqGvi32 UuZhfVZ6VBZA7s5Ec0IVC/eKGpy4djN+QxSAP0EAUMydS0wuLh1hfMiK7zX57wk3ldrgo3Nhc7 LkBQgqR1VRBA/2hU/8TCCnObGn+U4lb0EuvtsZsIv0xM38roQYKZt3YkGsGYas4HGdvER1zLjm PJQ= WDCIronportException: Internal Received: from shindev.dhcp.fujisawa.hgst.com (HELO shindev.fujisawa.hgst.com) ([10.149.52.173]) by uls-op-cesaip01.wdc.com with ESMTP; 06 Feb 2022 19:10:03 -0800 From: Shin'ichiro Kawasaki To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Cc: Naohiro Aota , Johannes Thumshirn , Damien Le Moal , Shin'ichiro Kawasaki Subject: [PATCH 4/7] xfs/015: check _scratch_mkfs_sized return code Date: Mon, 7 Feb 2022 12:09:55 +0900 Message-Id: <20220207030958.230618-5-shinichiro.kawasaki@wdc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220207030958.230618-1-shinichiro.kawasaki@wdc.com> References: <20220207030958.230618-1-shinichiro.kawasaki@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org The test cases xfs/015 calls _scratch_mkfs before _scratch_mkfs_sized, and does not check return code of _scratch_mkfs_sized. Even if _scratch_mkfs_sized failed, _scratch_mount after it cannot detect the sized mkfs failure because _scratch_mkfs already created a file system on the device. This results in unexpected test condition. To avoid the unexpected test condition, check return code of _scratch_mkfs_sized. Suggested-by: Naohiro Aota Signed-off-by: Shin'ichiro Kawasaki --- tests/xfs/015 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/xfs/015 b/tests/xfs/015 index 86fa6336..2bb7b8d5 100755 --- a/tests/xfs/015 +++ b/tests/xfs/015 @@ -43,7 +43,7 @@ _scratch_mount _require_fs_space $SCRATCH_MNT 131072 _scratch_unmount -_scratch_mkfs_sized $((32 * 1024 * 1024)) > $tmp.mkfs.raw +_scratch_mkfs_sized $((32 * 1024 * 1024)) > $tmp.mkfs.raw || _fail "mkfs failed" cat $tmp.mkfs.raw | _filter_mkfs >$seqres.full 2>$tmp.mkfs # get original data blocks number and agcount . $tmp.mkfs From patchwork Mon Feb 7 03:09:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shin'ichiro Kawasaki X-Patchwork-Id: 12736856 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8881C46467 for ; Mon, 7 Feb 2022 05:53:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239426AbiBGFu4 (ORCPT ); Mon, 7 Feb 2022 00:50:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350034AbiBGDLM (ORCPT ); Sun, 6 Feb 2022 22:11:12 -0500 Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A0965C043181; Sun, 6 Feb 2022 19:11:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1644203470; x=1675739470; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jrDb7WChrcBycb7ZvR9SK9nmp/V2FKFvMxreqrtzbZQ=; b=PpTc6ZGTciwzmVBf/9Apt75pcJK7wmzJpIq9kmJEi+q9TwvaCjahaLN8 NF3rICkVFV3Gt8ELDS5EJlxinUgouKvLiT2bOR+As6Cdn7DiA/PFbvHCl BcXDnF625Konp4cFyG3YB5sylrmi3AfyEBcMAmmNFN7HdMawZhY+r9oue 6G5DbjAGEka/YTE0VJsr1RB4+yrX9ZZOHCsagjP1S+MydDicb4q9s+C+3 mxgaXphE1kBCNfDpz2c5jdibWIsalh2J0OxmC/egcDP7kaQb5gnc6oUVj SiRocPHs3CDx3SYxMQjVY/llQSQJY4/xJVbX+/Pa+TGvi81aAlFyaPwp5 w==; X-IronPort-AV: E=Sophos;i="5.88,348,1635177600"; d="scan'208";a="304196002" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 07 Feb 2022 11:10:04 +0800 IronPort-SDR: iULJmeWlz2b5IIRIDOC6L3dhn9fG6wfaxBDMO7RTx8bfRIOU6RpZpV0bdACznl3KD63xI8CKsX ckIEnW9Pb2AXp9X/nqU/b+I0RKx7mYzG/OQbWQFNHk71rY95PeAV/SZ6Je8V15EI45JvpFRJKb mnDyVXYUbb9OYdNQVhoqxzPf+NWj1W9IRI3LXfZ94zUMRJHt9BzsVi0jq7K1KRz+gSUK3o3aOr gbJEooN+JyzhLQ4EWNgeUY2nsuOPV9tUeu+EFO7b6WjN0vpPt74FYP1/r4PWb+/htG7PHqWZWZ jRIIczo/mm3wHKF+kIGxhxLz Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2022 18:41:56 -0800 IronPort-SDR: mAOL/XTJnr+GTNdu+F/IB1FrCEZ0h4XDppswJXlcjUrDlvcI/3Rts57c3ISGpPPGhn//9Z6BCf VqVdg3kfpFOOERPcA9PYWhkz9N+HjNJFsTmwGEnt1yH98UKB+EWYEDvQpiSQHcjvAHPNxOlCQP A9zFqZDXPJq5QC4Rdfz46OOizCls/Ynr2Wr0wUZSFXh86xlv/a3UTj6jKEIypQW8B1XGjGCc5X 6xnXQyzj4mExaBKuv+i6XhjmzCpapkqPdYdjSm5kcWaKXOrCGftuQWNXKASC1ifOGSF2/iI7du EkA= WDCIronportException: Internal Received: from shindev.dhcp.fujisawa.hgst.com (HELO shindev.fujisawa.hgst.com) ([10.149.52.173]) by uls-op-cesaip01.wdc.com with ESMTP; 06 Feb 2022 19:10:04 -0800 From: Shin'ichiro Kawasaki To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Cc: Naohiro Aota , Johannes Thumshirn , Damien Le Moal , Shin'ichiro Kawasaki Subject: [PATCH 5/7] common: rename _filter_mkfs to _xfs_filter_mkfs Date: Mon, 7 Feb 2022 12:09:56 +0900 Message-Id: <20220207030958.230618-6-shinichiro.kawasaki@wdc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220207030958.230618-1-shinichiro.kawasaki@wdc.com> References: <20220207030958.230618-1-shinichiro.kawasaki@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org The helper function works only for xfs and used only for xfs except generic/204. Rename the function to clearly indicate that the function is only for xfs. Suggested-by: Naohiro Aota Signed-off-by: Shin'ichiro Kawasaki --- common/attr | 2 +- common/filter | 2 +- common/xfs | 2 +- tests/generic/204 | 4 ++-- tests/xfs/004 | 2 +- tests/xfs/007 | 2 +- tests/xfs/010 | 2 +- tests/xfs/013 | 2 +- tests/xfs/015 | 2 +- tests/xfs/016 | 2 +- tests/xfs/029 | 2 +- tests/xfs/030 | 2 +- tests/xfs/031 | 6 +++--- tests/xfs/033 | 4 ++-- tests/xfs/041 | 2 +- tests/xfs/044 | 2 +- tests/xfs/050 | 2 +- tests/xfs/052 | 2 +- tests/xfs/058 | 2 +- tests/xfs/067 | 2 +- tests/xfs/070 | 2 +- tests/xfs/071 | 2 +- tests/xfs/073 | 2 +- tests/xfs/076 | 2 +- tests/xfs/078 | 2 +- tests/xfs/092 | 2 +- tests/xfs/104 | 6 +++--- tests/xfs/108 | 2 +- tests/xfs/109 | 2 +- tests/xfs/110 | 2 +- tests/xfs/111 | 2 +- tests/xfs/144 | 2 +- tests/xfs/153 | 2 +- tests/xfs/163 | 4 ++-- tests/xfs/168 | 6 +++--- tests/xfs/176 | 2 +- tests/xfs/178 | 2 +- tests/xfs/186 | 2 +- tests/xfs/189 | 2 +- tests/xfs/250 | 2 +- tests/xfs/259 | 2 +- tests/xfs/276 | 2 +- tests/xfs/279 | 2 +- tests/xfs/288 | 2 +- tests/xfs/292 | 4 ++-- tests/xfs/299 | 4 ++-- tests/xfs/335 | 2 +- tests/xfs/336 | 2 +- tests/xfs/337 | 2 +- tests/xfs/341 | 2 +- tests/xfs/342 | 2 +- tests/xfs/443 | 2 +- tests/xfs/448 | 2 +- tests/xfs/490 | 2 +- tests/xfs/502 | 2 +- tests/xfs/513 | 2 +- tests/xfs/530 | 2 +- tests/xfs/533 | 2 +- 58 files changed, 69 insertions(+), 69 deletions(-) diff --git a/common/attr b/common/attr index 35682d7c..964c790a 100644 --- a/common/attr +++ b/common/attr @@ -13,7 +13,7 @@ _acl_get_max() # CRC format filesystems have much larger ACL counts. The actual # number is into the thousands, but testing that meany takes too # long, so just test well past the old limit of 25. - $XFS_INFO_PROG $TEST_DIR | _filter_mkfs > /dev/null 2> $tmp.info + $XFS_INFO_PROG $TEST_DIR | _xfs_filter_mkfs > /dev/null 2> $tmp.info . $tmp.info rm $tmp.info if [ $_fs_has_crcs -eq 0 ]; then diff --git a/common/filter b/common/filter index c3db7a56..24fd0650 100644 --- a/common/filter +++ b/common/filter @@ -117,7 +117,7 @@ _filter_date() # prints filtered output on stdout, values (use eval) on stderr # Non XFS filesystems always return a 4k block size and a 256 byte inode. -_filter_mkfs() +_xfs_filter_mkfs() { case $FSTYP in xfs) diff --git a/common/xfs b/common/xfs index 713e9fe7..3435c706 100644 --- a/common/xfs +++ b/common/xfs @@ -832,7 +832,7 @@ _require_scratch_xfs_shrink() _require_scratch _require_command "$XFS_GROWFS_PROG" xfs_growfs - _scratch_mkfs_xfs | _filter_mkfs 2>$tmp.mkfs >/dev/null + _scratch_mkfs_xfs | _xfs_filter_mkfs 2>$tmp.mkfs >/dev/null . $tmp.mkfs _scratch_mount # here just to check if kernel supports, no need do more extra work diff --git a/tests/generic/204 b/tests/generic/204 index b5deb443..40d524d1 100755 --- a/tests/generic/204 +++ b/tests/generic/204 @@ -25,7 +25,7 @@ _supported_fs generic _require_scratch # get the block size first -_scratch_mkfs 2> /dev/null | _filter_mkfs 2> $tmp.mkfs > /dev/null +_scratch_mkfs 2> /dev/null | _xfs_filter_mkfs 2> $tmp.mkfs > /dev/null . $tmp.mkfs # For xfs, we need to handle the different default log sizes that different @@ -37,7 +37,7 @@ _scratch_mkfs 2> /dev/null | _filter_mkfs 2> $tmp.mkfs > /dev/null SIZE=`expr 115 \* 1024 \* 1024` _scratch_mkfs_sized $SIZE $dbsize 2> /dev/null > $tmp.mkfs.raw \ || _fail "mkfs failed" -cat $tmp.mkfs.raw | _filter_mkfs 2> $tmp.mkfs > /dev/null +cat $tmp.mkfs.raw | _xfs_filter_mkfs 2> $tmp.mkfs > /dev/null _scratch_mount # Source $tmp.mkfs to get geometry diff --git a/tests/xfs/004 b/tests/xfs/004 index f18316b3..5e83fff9 100755 --- a/tests/xfs/004 +++ b/tests/xfs/004 @@ -21,7 +21,7 @@ _cleanup() _populate_scratch() { echo "=== mkfs output ===" >>$seqres.full - _scratch_mkfs_xfs | tee -a $seqres.full | _filter_mkfs 2>$tmp.mkfs + _scratch_mkfs_xfs | tee -a $seqres.full | _xfs_filter_mkfs 2>$tmp.mkfs . $tmp.mkfs _scratch_mount # This test looks at specific behaviors of the xfs_db freesp command, diff --git a/tests/xfs/007 b/tests/xfs/007 index 4f864100..33a857e8 100755 --- a/tests/xfs/007 +++ b/tests/xfs/007 @@ -19,7 +19,7 @@ _supported_fs xfs _require_scratch _require_xfs_quota -_scratch_mkfs_xfs | _filter_mkfs > /dev/null 2> $tmp.mkfs +_scratch_mkfs_xfs | _xfs_filter_mkfs > /dev/null 2> $tmp.mkfs . $tmp.mkfs do_test() diff --git a/tests/xfs/010 b/tests/xfs/010 index 16c08b85..badac7c0 100755 --- a/tests/xfs/010 +++ b/tests/xfs/010 @@ -87,7 +87,7 @@ _require_scratch _require_xfs_mkfs_finobt _require_xfs_finobt -_scratch_mkfs_xfs "-m crc=1,finobt=1 -d agcount=2" | _filter_mkfs 2>$seqres.full +_scratch_mkfs_xfs "-m crc=1,finobt=1 -d agcount=2" | _xfs_filter_mkfs 2>$seqres.full # sparsely populate the fs such that we create records with free inodes _scratch_mount diff --git a/tests/xfs/013 b/tests/xfs/013 index 2d005753..dc39ffd6 100755 --- a/tests/xfs/013 +++ b/tests/xfs/013 @@ -89,7 +89,7 @@ _require_xfs_finobt _require_command "$KILLALL_PROG" killall _scratch_mkfs_xfs "-m crc=1,finobt=1 -d agcount=2" | \ - _filter_mkfs 2>> $seqres.full + _xfs_filter_mkfs 2>> $seqres.full _scratch_mount COUNT=20000 # number of files per directory diff --git a/tests/xfs/015 b/tests/xfs/015 index 2bb7b8d5..72842b38 100755 --- a/tests/xfs/015 +++ b/tests/xfs/015 @@ -44,7 +44,7 @@ _require_fs_space $SCRATCH_MNT 131072 _scratch_unmount _scratch_mkfs_sized $((32 * 1024 * 1024)) > $tmp.mkfs.raw || _fail "mkfs failed" -cat $tmp.mkfs.raw | _filter_mkfs >$seqres.full 2>$tmp.mkfs +cat $tmp.mkfs.raw | _xfs_filter_mkfs >$seqres.full 2>$tmp.mkfs # get original data blocks number and agcount . $tmp.mkfs _scratch_mount diff --git a/tests/xfs/016 b/tests/xfs/016 index 6337bb1f..e8094476 100755 --- a/tests/xfs/016 +++ b/tests/xfs/016 @@ -66,7 +66,7 @@ _init() _scratch_mkfs_xfs $force_opts >$tmp.mkfs0 2>&1 [ $? -ne 0 ] && \ _notrun "Cannot mkfs for this test using MKFS_OPTIONS specified" - _filter_mkfs <$tmp.mkfs0 >/dev/null 2>$tmp.mkfs + _xfs_filter_mkfs <$tmp.mkfs0 >/dev/null 2>$tmp.mkfs . $tmp.mkfs [ $logsunit -ne 0 ] && \ _notrun "Cannot run this test using log MKFS_OPTIONS specified" diff --git a/tests/xfs/029 b/tests/xfs/029 index 6e8aa4db..a3fb9cfc 100755 --- a/tests/xfs/029 +++ b/tests/xfs/029 @@ -36,7 +36,7 @@ _supported_fs xfs _require_scratch echo -_scratch_mkfs_xfs | _filter_mkfs 2>/dev/null +_scratch_mkfs_xfs | _xfs_filter_mkfs 2>/dev/null echo _scratch_xfs_logprint | filter_logprint diff --git a/tests/xfs/030 b/tests/xfs/030 index 201a9015..62066d06 100755 --- a/tests/xfs/030 +++ b/tests/xfs/030 @@ -83,7 +83,7 @@ $here/src/devzero -v -1 -n "$clear" $SCRATCH_DEV >/dev/null # now kick off the real repair test... # -_scratch_mkfs_xfs $DSIZE | _filter_mkfs 2>$tmp.mkfs +_scratch_mkfs_xfs $DSIZE | _xfs_filter_mkfs 2>$tmp.mkfs . $tmp.mkfs _check_ag 0 _check_ag -1 diff --git a/tests/xfs/031 b/tests/xfs/031 index 6e3813da..e6bbc0d4 100755 --- a/tests/xfs/031 +++ b/tests/xfs/031 @@ -82,20 +82,20 @@ echo "$MKFS_OPTIONS" | grep -q "rtinherit" && \ _create_proto 0 echo "=== one entry (shortform)" _scratch_mkfs_xfs -p $tmp.proto >$tmp.mkfs0 2>&1 -_filter_mkfs <$tmp.mkfs0 >/dev/null 2>$tmp.mkfs +_xfs_filter_mkfs <$tmp.mkfs0 >/dev/null 2>$tmp.mkfs . $tmp.mkfs _check_repair # block-form root directory & repeat _create_proto 20 echo "=== twenty entries (block form)" -_scratch_mkfs_xfs -p $tmp.proto | _filter_mkfs >/dev/null 2>&1 +_scratch_mkfs_xfs -p $tmp.proto | _xfs_filter_mkfs >/dev/null 2>&1 _check_repair # leaf-form root directory & repeat _create_proto 1000 echo "=== thousand entries (leaf form)" -_scratch_mkfs_xfs -p $tmp.proto | _filter_mkfs >/dev/null 2>&1 +_scratch_mkfs_xfs -p $tmp.proto | _xfs_filter_mkfs >/dev/null 2>&1 _check_repair # success, all done diff --git a/tests/xfs/033 b/tests/xfs/033 index d47da0d6..61ae4004 100755 --- a/tests/xfs/033 +++ b/tests/xfs/033 @@ -55,10 +55,10 @@ _require_scratch _require_no_large_scratch_dev # devzero blows away 512byte blocks, so make 512byte inodes (at least) -_scratch_mkfs_xfs | _filter_mkfs 2>$tmp.mkfs >/dev/null +_scratch_mkfs_xfs | _xfs_filter_mkfs 2>$tmp.mkfs >/dev/null . $tmp.mkfs if [ $isize -lt 512 ]; then - _scratch_mkfs_xfs -isize=512 | _filter_mkfs 2>$tmp.mkfs >/dev/null + _scratch_mkfs_xfs -isize=512 | _xfs_filter_mkfs 2>$tmp.mkfs >/dev/null . $tmp.mkfs fi diff --git a/tests/xfs/041 b/tests/xfs/041 index 05de5578..135ed410 100755 --- a/tests/xfs/041 +++ b/tests/xfs/041 @@ -41,7 +41,7 @@ _do_die_on_error=message_only agsize=32 echo -n "Make $agsize megabyte filesystem on SCRATCH_DEV and mount... " _scratch_mkfs_xfs -dsize=${agsize}m,agcount=1 2>&1 >/dev/null || _fail "mkfs failed" -bsize=`_scratch_mkfs_xfs -dsize=${agsize}m,agcount=1 2>&1 | _filter_mkfs 2>&1 \ +bsize=`_scratch_mkfs_xfs -dsize=${agsize}m,agcount=1 2>&1 | _xfs_filter_mkfs 2>&1 \ | perl -ne 'if (/dbsize=(\d+)/) {print $1;}'` onemeginblocks=`expr 1048576 / $bsize` _scratch_mount diff --git a/tests/xfs/044 b/tests/xfs/044 index e66c0cb3..8ffd2af4 100755 --- a/tests/xfs/044 +++ b/tests/xfs/044 @@ -79,7 +79,7 @@ lsize=16777216 _scratch_mkfs_xfs -lsize=$lsize,version=$lversion >$tmp.mkfs0 2>&1 [ $? -ne 0 ] && \ _notrun "Cannot mkfs for this test using MKFS_OPTIONS specified" -_filter_mkfs <$tmp.mkfs0 2>$tmp.mkfs1 +_xfs_filter_mkfs <$tmp.mkfs0 2>$tmp.mkfs1 . $tmp.mkfs1 [ $lversion -ne 1 ] && \ _notrun "Cannot run this test yet using MKFS_OPTIONS specified" diff --git a/tests/xfs/050 b/tests/xfs/050 index 1847611b..3556c85e 100755 --- a/tests/xfs/050 +++ b/tests/xfs/050 @@ -65,7 +65,7 @@ _filter_and_check_blks() _exercise() { - _scratch_mkfs_xfs | _filter_mkfs 2>$tmp.mkfs + _scratch_mkfs_xfs | _xfs_filter_mkfs 2>$tmp.mkfs cat $tmp.mkfs >>$seqres.full # keep the blocksize and data size for dd later diff --git a/tests/xfs/052 b/tests/xfs/052 index 75761022..e4c7ee6c 100755 --- a/tests/xfs/052 +++ b/tests/xfs/052 @@ -34,7 +34,7 @@ _require_nobody # setup a default run _qmount_option uquota -_scratch_mkfs_xfs | _filter_mkfs 2>$tmp.mkfs +_scratch_mkfs_xfs | _xfs_filter_mkfs 2>$tmp.mkfs cat $tmp.mkfs >>$seqres.full chmod a+w $seqres.full # arbitrary users will write here diff --git a/tests/xfs/058 b/tests/xfs/058 index 8751a7ac..0f87ec3c 100755 --- a/tests/xfs/058 +++ b/tests/xfs/058 @@ -22,7 +22,7 @@ _require_xfs_db_command "fuzz" rm -f "$seqres.full" echo "Format" -_scratch_mkfs | _filter_mkfs 2>$tmp.mkfs >> "$seqres.full" +_scratch_mkfs | _xfs_filter_mkfs 2>$tmp.mkfs >> "$seqres.full" source $tmp.mkfs do_xfs_db() diff --git a/tests/xfs/067 b/tests/xfs/067 index 3dc381bb..c733d761 100755 --- a/tests/xfs/067 +++ b/tests/xfs/067 @@ -22,7 +22,7 @@ _require_scratch # set up fs for 1K inodes isize=0 -_scratch_mkfs_xfs | _filter_mkfs >$seqres.full 2>$tmp.mkfs +_scratch_mkfs_xfs | _xfs_filter_mkfs >$seqres.full 2>$tmp.mkfs [ $? -eq 0 ] && source $tmp.mkfs if [ "$isize" -lt 1024 ]; then _scratch_mkfs_xfs -i size=1024 >>$seqres.full \ diff --git a/tests/xfs/070 b/tests/xfs/070 index 43ca7f84..9db518d7 100755 --- a/tests/xfs/070 +++ b/tests/xfs/070 @@ -76,7 +76,7 @@ _supported_fs xfs _require_scratch_nocheck _require_command "$KILLALL_PROG" killall -_scratch_mkfs | _filter_mkfs > /dev/null 2> $tmp.mkfs +_scratch_mkfs | _xfs_filter_mkfs > /dev/null 2> $tmp.mkfs test "${PIPESTATUS[0]}" -eq 0 || _fail "mkfs failed" . $tmp.mkfs # import agcount diff --git a/tests/xfs/071 b/tests/xfs/071 index 8373878a..9b425d9f 100755 --- a/tests/xfs/071 +++ b/tests/xfs/071 @@ -81,7 +81,7 @@ _supported_fs xfs [ -n "$XFS_IO_PROG" ] || _notrun "xfs_io executable not found" _require_scratch -_scratch_mkfs_xfs | _filter_mkfs 2>$tmp.mkfs +_scratch_mkfs_xfs | _xfs_filter_mkfs 2>$tmp.mkfs . $tmp.mkfs echo _scratch_mount diff --git a/tests/xfs/073 b/tests/xfs/073 index c7616b9e..d1b97313 100755 --- a/tests/xfs/073 +++ b/tests/xfs/073 @@ -131,7 +131,7 @@ _verify_copy $imgs.image $SCRATCH_DEV $SCRATCH_MNT echo echo === copying scratch device to single target, large ro device ${MKFS_XFS_PROG} -dfile,name=$imgs.source,size=100g \ - | _filter_mkfs 2>/dev/null + | _xfs_filter_mkfs 2>/dev/null rmdir $imgs.source_dir 2>/dev/null mkdir $imgs.source_dir diff --git a/tests/xfs/076 b/tests/xfs/076 index eac7410e..3cdde79e 100755 --- a/tests/xfs/076 +++ b/tests/xfs/076 @@ -61,7 +61,7 @@ _require_xfs_io_command "fpunch" _require_xfs_sparse_inodes _scratch_mkfs "-d size=50m -m crc=1 -i sparse" | - _filter_mkfs > /dev/null 2> $tmp.mkfs + _xfs_filter_mkfs > /dev/null 2> $tmp.mkfs . $tmp.mkfs # for isize _scratch_mount diff --git a/tests/xfs/078 b/tests/xfs/078 index 1f475c96..a3b75fa6 100755 --- a/tests/xfs/078 +++ b/tests/xfs/078 @@ -74,7 +74,7 @@ _grow_loop() mkfs_crc_opts="-m crc=0" fi $MKFS_XFS_PROG $mkfs_crc_opts -b size=$bsize $dparam $LOOP_DEV \ - | _filter_mkfs 2>/dev/null + | _xfs_filter_mkfs 2>/dev/null echo "*** extend loop file" _destroy_loop_device $LOOP_DEV diff --git a/tests/xfs/092 b/tests/xfs/092 index 015149e2..7e7b31fc 100755 --- a/tests/xfs/092 +++ b/tests/xfs/092 @@ -20,7 +20,7 @@ _require_scratch _require_no_large_scratch_dev MOUNT_OPTIONS="$MOUNT_OPTIONS -o inode64" -_scratch_mkfs_xfs | _filter_mkfs 2>/dev/null +_scratch_mkfs_xfs | _xfs_filter_mkfs 2>/dev/null echo Silence is golden _try_scratch_mount diff --git a/tests/xfs/104 b/tests/xfs/104 index d16f46d8..c21bd4e0 100755 --- a/tests/xfs/104 +++ b/tests/xfs/104 @@ -15,7 +15,7 @@ _begin_fstest growfs ioctl prealloc auto stress _create_scratch() { echo "*** mkfs" - _scratch_mkfs_xfs $@ | tee -a $seqres.full | _filter_mkfs 2>$tmp.mkfs + _scratch_mkfs_xfs $@ | tee -a $seqres.full | _xfs_filter_mkfs 2>$tmp.mkfs . $tmp.mkfs echo "*** mount" @@ -50,7 +50,7 @@ _supported_fs xfs _require_scratch _require_xfs_io_command "falloc" -_scratch_mkfs_xfs | tee -a $seqres.full | _filter_mkfs 2>$tmp.mkfs +_scratch_mkfs_xfs | tee -a $seqres.full | _xfs_filter_mkfs 2>$tmp.mkfs . $tmp.mkfs # extract blocksize and data size for scratch device endsize=`expr 550 \* 1048576` # stop after growing this big @@ -89,7 +89,7 @@ while [ $size -le $endsize ]; do echo "*** growing filesystem" echo "*** growing to a ${sizeb} block filesystem" >> $seqres.full xfs_growfs -D ${sizeb} $SCRATCH_MNT \ - | tee -a $seqres.full | _filter_mkfs 2>$tmp.growfs + | tee -a $seqres.full | _xfs_filter_mkfs 2>$tmp.growfs . $tmp.growfs [ `expr $size % $modsize` -eq 0 ] && wait # every 4th iteration echo AGCOUNT=$agcount | tee -a $seqres.full diff --git a/tests/xfs/108 b/tests/xfs/108 index 46070005..985b989b 100755 --- a/tests/xfs/108 +++ b/tests/xfs/108 @@ -62,7 +62,7 @@ _require_prjquota $SCRATCH_DEV # real QA test starts here rm -f $tmp.projects $seqres.full _scratch_unmount 2>/dev/null -_scratch_mkfs_xfs | _filter_mkfs 2>$tmp.mkfs +_scratch_mkfs_xfs | _xfs_filter_mkfs 2>$tmp.mkfs cat $tmp.mkfs >>$seqres.full _scratch_mount diff --git a/tests/xfs/109 b/tests/xfs/109 index 6cb6917a..e29d4795 100755 --- a/tests/xfs/109 +++ b/tests/xfs/109 @@ -78,7 +78,7 @@ if [ -n "$FASTSTART" -a -f $SCRATCH_MNT/f0 ]; then fi _scratch_unmount -_scratch_mkfs_xfs -dsize=160m,agcount=4 $faststart | _filter_mkfs 2>$tmp.mkfs +_scratch_mkfs_xfs -dsize=160m,agcount=4 $faststart | _xfs_filter_mkfs 2>$tmp.mkfs cat $tmp.mkfs >>$seqres.full _scratch_mount diff --git a/tests/xfs/110 b/tests/xfs/110 index 596057ef..734d2869 100755 --- a/tests/xfs/110 +++ b/tests/xfs/110 @@ -18,7 +18,7 @@ _require_scratch # real QA test starts here _scratch_unmount 2>/dev/null -_scratch_mkfs_xfs | _filter_mkfs 2>$tmp.mkfs +_scratch_mkfs_xfs | _xfs_filter_mkfs 2>$tmp.mkfs STR1=AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA STR2=BBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBBB diff --git a/tests/xfs/111 b/tests/xfs/111 index ede28aee..ed5a54c5 100755 --- a/tests/xfs/111 +++ b/tests/xfs/111 @@ -22,7 +22,7 @@ _require_scratch _scratch_unmount 2>/dev/null MKFS_OPTIONS="-bsize=4096" MOUNT_OPTIONS="-o noatime" -_scratch_mkfs_xfs | _filter_mkfs 2>$tmp.mkfs +_scratch_mkfs_xfs | _xfs_filter_mkfs 2>$tmp.mkfs _scratch_mount echo Create some files diff --git a/tests/xfs/144 b/tests/xfs/144 index 5abec9ae..d46eb1e2 100755 --- a/tests/xfs/144 +++ b/tests/xfs/144 @@ -24,7 +24,7 @@ _require_xfs_quota _require_scratch exercise() { - _scratch_mkfs_xfs | _filter_mkfs 2>$tmp.mkfs + _scratch_mkfs_xfs | _xfs_filter_mkfs 2>$tmp.mkfs cat $tmp.mkfs >>$seqres.full # keep the blocksize and data size for dd later diff --git a/tests/xfs/153 b/tests/xfs/153 index 37303701..d410cbed 100755 --- a/tests/xfs/153 +++ b/tests/xfs/153 @@ -70,7 +70,7 @@ _filter_and_check_blks() run_tests() { - _scratch_mkfs_xfs | _filter_mkfs 2>$tmp.mkfs + _scratch_mkfs_xfs | _xfs_filter_mkfs 2>$tmp.mkfs cat $tmp.mkfs >>$seqres.full # keep the blocksize and data size for dd later diff --git a/tests/xfs/163 b/tests/xfs/163 index 9f6dbeb8..79f420fa 100755 --- a/tests/xfs/163 +++ b/tests/xfs/163 @@ -24,7 +24,7 @@ test_shrink() _check_scratch_fs _scratch_mount - $XFS_INFO_PROG $SCRATCH_MNT 2>&1 | _filter_mkfs 2>$tmp.growfs >/dev/null + $XFS_INFO_PROG $SCRATCH_MNT 2>&1 | _xfs_filter_mkfs 2>$tmp.growfs >/dev/null . $tmp.growfs [ $ret -eq 0 -a $1 -eq $dblocks ] } @@ -38,7 +38,7 @@ echo "Format and mount" # agcount = 1 is forbidden on purpose, and need to ensure shrinking to # 2 AGs isn't feasible yet. So agcount = 3 is the minimum number now. _scratch_mkfs -dsize="$((512 * 1024 * 1024))" -dagcount=3 2>&1 | \ - tee -a $seqres.full | _filter_mkfs 2>$tmp.mkfs >/dev/null + tee -a $seqres.full | _xfs_filter_mkfs 2>$tmp.mkfs >/dev/null . $tmp.mkfs t_dblocks=$dblocks _scratch_mount >> $seqres.full diff --git a/tests/xfs/168 b/tests/xfs/168 index ffcd0df8..6b3eee30 100755 --- a/tests/xfs/168 +++ b/tests/xfs/168 @@ -19,7 +19,7 @@ _begin_fstest auto growfs shrinkfs ioctl prealloc stress create_scratch() { _scratch_mkfs_xfs $@ | tee -a $seqres.full | \ - _filter_mkfs 2>$tmp.mkfs >/dev/null + _xfs_filter_mkfs 2>$tmp.mkfs >/dev/null . $tmp.mkfs _scratch_mount @@ -48,7 +48,7 @@ _supported_fs xfs _require_scratch_xfs_shrink _require_xfs_io_command "falloc" -_scratch_mkfs_xfs | tee -a $seqres.full | _filter_mkfs 2>$tmp.mkfs >/dev/null +_scratch_mkfs_xfs | tee -a $seqres.full | _xfs_filter_mkfs 2>$tmp.mkfs >/dev/null . $tmp.mkfs # extract blocksize and data size for scratch device endsize=`expr 125 \* 1048576` # stop after shrinking this big @@ -93,7 +93,7 @@ while [ $totalcount -gt 0 ]; do [ $decb -eq 0 ] && break # get latest dblocks - $XFS_INFO_PROG $SCRATCH_MNT 2>&1 | _filter_mkfs 2>$tmp.growfs >/dev/null + $XFS_INFO_PROG $SCRATCH_MNT 2>&1 | _xfs_filter_mkfs 2>$tmp.growfs >/dev/null . $tmp.growfs size=`expr $dblocks \* $dbsize` diff --git a/tests/xfs/176 b/tests/xfs/176 index ba4aae59..57e11fd7 100755 --- a/tests/xfs/176 +++ b/tests/xfs/176 @@ -24,7 +24,7 @@ _require_xfs_io_command "falloc" _require_xfs_io_command "fpunch" _scratch_mkfs "-d size=50m -m crc=1 -i sparse" | - _filter_mkfs > /dev/null 2> $tmp.mkfs + _xfs_filter_mkfs > /dev/null 2> $tmp.mkfs . $tmp.mkfs # for isize cat $tmp.mkfs >> $seqres.full diff --git a/tests/xfs/178 b/tests/xfs/178 index a65197cd..5392b9bb 100755 --- a/tests/xfs/178 +++ b/tests/xfs/178 @@ -45,7 +45,7 @@ _supported_fs xfs # fix filesystem, new mkfs.xfs will be fine. _require_scratch -_scratch_mkfs_xfs | _filter_mkfs 2>$tmp.mkfs +_scratch_mkfs_xfs | _xfs_filter_mkfs 2>$tmp.mkfs test "${PIPESTATUS[0]}" -eq 0 || _fail "mkfs failed!" # By executing the followint tmp file, will get on the mkfs options stored in diff --git a/tests/xfs/186 b/tests/xfs/186 index b54fcf26..8a2a6995 100755 --- a/tests/xfs/186 +++ b/tests/xfs/186 @@ -124,7 +124,7 @@ _require_scratch _require_attrs _require_attr_v1 -_scratch_mkfs -i attr=2,size=512 -l lazy-count=1 | _filter_mkfs \ +_scratch_mkfs -i attr=2,size=512 -l lazy-count=1 | _xfs_filter_mkfs \ >>$seqres.full 2>$tmp.mkfs # import crc status and attr version . $tmp.mkfs diff --git a/tests/xfs/189 b/tests/xfs/189 index e601881a..437243c7 100755 --- a/tests/xfs/189 +++ b/tests/xfs/189 @@ -231,7 +231,7 @@ _require_noattr2 unset SCRATCH_RTDEV unset SCRATCH_LOGDEV -_scratch_mkfs_xfs | _filter_mkfs 2>/dev/null +_scratch_mkfs_xfs | _xfs_filter_mkfs 2>/dev/null _add_scratch_fstab _test_remount_rw diff --git a/tests/xfs/250 b/tests/xfs/250 index 8af32711..573340bb 100755 --- a/tests/xfs/250 +++ b/tests/xfs/250 @@ -54,7 +54,7 @@ _test_loop() echo "*** mkfs loop file (size=$size)" $MKFS_XFS_PROG -d $dparam \ - | _filter_mkfs 2>/dev/null + | _xfs_filter_mkfs 2>/dev/null echo "*** mount loop filesystem" mount -t xfs -o loop $LOOP_DEV $LOOP_MNT diff --git a/tests/xfs/259 b/tests/xfs/259 index 88e2f3ee..7c062c7d 100755 --- a/tests/xfs/259 +++ b/tests/xfs/259 @@ -49,7 +49,7 @@ for del in $sizes_to_check; do >/dev/null 2>&1 || echo "dd failed" lofile=$(losetup -f) losetup $lofile "$testfile" - $MKFS_XFS_PROG -l size=32m -b size=$bs $lofile | _filter_mkfs \ + $MKFS_XFS_PROG -l size=32m -b size=$bs $lofile | _xfs_filter_mkfs \ >/dev/null 2> $tmp.mkfs || echo "mkfs failed!" . $tmp.mkfs sync diff --git a/tests/xfs/276 b/tests/xfs/276 index 8cc48675..6774b819 100755 --- a/tests/xfs/276 +++ b/tests/xfs/276 @@ -29,7 +29,7 @@ _require_test_program "punch-alternating" rm -f "$seqres.full" echo "Format and mount" -_scratch_mkfs | _filter_mkfs 2> "$tmp.mkfs" >/dev/null +_scratch_mkfs | _xfs_filter_mkfs 2> "$tmp.mkfs" >/dev/null . $tmp.mkfs cat "$tmp.mkfs" > $seqres.full _scratch_mount diff --git a/tests/xfs/279 b/tests/xfs/279 index 835d187f..64563237 100755 --- a/tests/xfs/279 +++ b/tests/xfs/279 @@ -44,7 +44,7 @@ _check_mkfs() return fi echo "Passed." - cat $tmp.mkfs.full | _filter_mkfs >> $seqres.full 2>$tmp.mkfs + cat $tmp.mkfs.full | _xfs_filter_mkfs >> $seqres.full 2>$tmp.mkfs . $tmp.mkfs echo "Got sector size: $sectsz" device=`echo $@ | awk '{print $NF}'` diff --git a/tests/xfs/288 b/tests/xfs/288 index e3d230e9..ec12d0d1 100755 --- a/tests/xfs/288 +++ b/tests/xfs/288 @@ -20,7 +20,7 @@ _require_scratch _require_attrs # get block size ($dbsize) from the mkfs output -_scratch_mkfs_xfs 2>/dev/null | _filter_mkfs 2>$tmp.mkfs >/dev/null +_scratch_mkfs_xfs 2>/dev/null | _xfs_filter_mkfs 2>$tmp.mkfs >/dev/null . $tmp.mkfs _scratch_mount diff --git a/tests/xfs/292 b/tests/xfs/292 index cf501571..930504ca 100755 --- a/tests/xfs/292 +++ b/tests/xfs/292 @@ -25,12 +25,12 @@ rm -f $fsfile $XFS_IO_PROG -f -c "truncate 256g" $fsfile echo "mkfs.xfs without geometry" -mkfs.xfs -f $fsfile | _filter_mkfs 2> $tmp.mkfs > /dev/null +mkfs.xfs -f $fsfile | _xfs_filter_mkfs 2> $tmp.mkfs > /dev/null grep -E 'ddev|agcount|agsize' $tmp.mkfs | \ sed -e "s:$fsfile:FILENAME:g" echo "mkfs.xfs with cmdline geometry" -mkfs.xfs -f -d su=16k,sw=5 $fsfile | _filter_mkfs 2> $tmp.mkfs > /dev/null +mkfs.xfs -f -d su=16k,sw=5 $fsfile | _xfs_filter_mkfs 2> $tmp.mkfs > /dev/null grep -E 'ddev|agcount|agsize' $tmp.mkfs | \ sed -e "s:$fsfile:FILENAME:g" diff --git a/tests/xfs/299 b/tests/xfs/299 index a3077b0c..e6da413a 100755 --- a/tests/xfs/299 +++ b/tests/xfs/299 @@ -147,7 +147,7 @@ _exercise() } -_scratch_mkfs_xfs -m crc=1 2>/dev/null | _filter_mkfs 2>$tmp.mkfs +_scratch_mkfs_xfs -m crc=1 2>/dev/null | _xfs_filter_mkfs 2>$tmp.mkfs cat $tmp.mkfs >>$seqres.full # keep the blocksize and data size for dd later . $tmp.mkfs @@ -184,7 +184,7 @@ _exercise u echo "*** unmount" _scratch_unmount -_scratch_mkfs_xfs -m crc=1 2>/dev/null | _filter_mkfs 2>$tmp.mkfs +_scratch_mkfs_xfs -m crc=1 2>/dev/null | _xfs_filter_mkfs 2>$tmp.mkfs cat $tmp.mkfs >>$seqres.full # keep the blocksize and data size for dd later . $tmp.mkfs diff --git a/tests/xfs/335 b/tests/xfs/335 index ccc508e7..c2bb1bde 100755 --- a/tests/xfs/335 +++ b/tests/xfs/335 @@ -22,7 +22,7 @@ _require_xfs_io_command "falloc" rm -f "$seqres.full" echo "Format and mount" -_scratch_mkfs | _filter_mkfs 2>$tmp.mkfs >/dev/null +_scratch_mkfs | _xfs_filter_mkfs 2>$tmp.mkfs >/dev/null . $tmp.mkfs cat $tmp.mkfs > "$seqres.full" 2>&1 _scratch_mount diff --git a/tests/xfs/336 b/tests/xfs/336 index 279830b5..19ed8cc6 100755 --- a/tests/xfs/336 +++ b/tests/xfs/336 @@ -29,7 +29,7 @@ _require_xfs_io_command "falloc" rm -f "$seqres.full" echo "Format and mount" -_scratch_mkfs | _filter_mkfs 2>$tmp.mkfs >/dev/null +_scratch_mkfs | _xfs_filter_mkfs 2>$tmp.mkfs >/dev/null . $tmp.mkfs cat $tmp.mkfs > "$seqres.full" 2>&1 _scratch_mount diff --git a/tests/xfs/337 b/tests/xfs/337 index a2515e36..ca476e28 100755 --- a/tests/xfs/337 +++ b/tests/xfs/337 @@ -23,7 +23,7 @@ _disable_dmesg_check rm -f "$seqres.full" echo "+ create scratch fs" -_scratch_mkfs | _filter_mkfs 2>$tmp.mkfs >/dev/null +_scratch_mkfs | _xfs_filter_mkfs 2>$tmp.mkfs >/dev/null . $tmp.mkfs cat $tmp.mkfs > "$seqres.full" 2>&1 diff --git a/tests/xfs/341 b/tests/xfs/341 index f026aa37..dad1e0af 100755 --- a/tests/xfs/341 +++ b/tests/xfs/341 @@ -23,7 +23,7 @@ _require_xfs_io_command "falloc" rm -f "$seqres.full" echo "Format and mount" -_scratch_mkfs | _filter_mkfs 2>$tmp.mkfs >/dev/null +_scratch_mkfs | _xfs_filter_mkfs 2>$tmp.mkfs >/dev/null . $tmp.mkfs cat $tmp.mkfs > "$seqres.full" 2>&1 _scratch_mount diff --git a/tests/xfs/342 b/tests/xfs/342 index 1ae414eb..0922b3fe 100755 --- a/tests/xfs/342 +++ b/tests/xfs/342 @@ -22,7 +22,7 @@ _require_xfs_io_command "falloc" rm -f "$seqres.full" echo "Format and mount" -_scratch_mkfs | _filter_mkfs 2>$tmp.mkfs >/dev/null +_scratch_mkfs | _xfs_filter_mkfs 2>$tmp.mkfs >/dev/null . $tmp.mkfs cat $tmp.mkfs > "$seqres.full" 2>&1 _scratch_mount diff --git a/tests/xfs/443 b/tests/xfs/443 index f2390bf3..a236c8f8 100755 --- a/tests/xfs/443 +++ b/tests/xfs/443 @@ -31,7 +31,7 @@ _require_xfs_io_command "falloc" _require_xfs_io_command "fpunch" _require_xfs_io_command "swapext" -_scratch_mkfs | _filter_mkfs >> $seqres.full 2> $tmp.mkfs +_scratch_mkfs | _xfs_filter_mkfs >> $seqres.full 2> $tmp.mkfs _scratch_mount # get fs block size diff --git a/tests/xfs/448 b/tests/xfs/448 index 815f56cb..3cd56d4d 100755 --- a/tests/xfs/448 +++ b/tests/xfs/448 @@ -34,7 +34,7 @@ _require_no_xfs_bug_on_assert rm -f "$seqres.full" # Format and mount -_scratch_mkfs | _filter_mkfs > $seqres.full 2> $tmp.mkfs +_scratch_mkfs | _xfs_filter_mkfs > $seqres.full 2> $tmp.mkfs test "${PIPESTATUS[0]}" -eq 0 || _fail "mkfs failed" _scratch_mount diff --git a/tests/xfs/490 b/tests/xfs/490 index 8c3b0684..08a03261 100755 --- a/tests/xfs/490 +++ b/tests/xfs/490 @@ -37,7 +37,7 @@ filter_dmesg() # If enable free inode B+tree, this case will fail on xfs_dialloc_ag_update_inobt, # that's not what we want to test. Due to finobt feature is not necessary for this # test, so disable it directly. -_scratch_mkfs_xfs -m finobt=0 | _filter_mkfs 2>$tmp.mkfs >> $seqres.full +_scratch_mkfs_xfs -m finobt=0 | _xfs_filter_mkfs 2>$tmp.mkfs >> $seqres.full # On V5 filesystem, this case can't trigger bug because it doesn't read inodes # we are allocating from disk - it simply overwrites them with new inode diff --git a/tests/xfs/502 b/tests/xfs/502 index fb9a82c1..464326cc 100755 --- a/tests/xfs/502 +++ b/tests/xfs/502 @@ -25,7 +25,7 @@ _require_xfs_io_error_injection "iunlink_fallback" _require_scratch _require_test_program "t_open_tmpfiles" -_scratch_mkfs | _filter_mkfs 2> $tmp.mkfs > /dev/null +_scratch_mkfs | _xfs_filter_mkfs 2> $tmp.mkfs > /dev/null cat $tmp.mkfs >> $seqres.full . $tmp.mkfs diff --git a/tests/xfs/513 b/tests/xfs/513 index bfdfd4f6..a13f0a03 100755 --- a/tests/xfs/513 +++ b/tests/xfs/513 @@ -68,7 +68,7 @@ MKFS_OPTIONS="" do_mkfs() { echo "FORMAT: $@" | filter_loop | tee -a $seqres.full - $MKFS_XFS_PROG -f $* $LOOP_DEV | _filter_mkfs >>$seqres.full 2>$tmp.mkfs + $MKFS_XFS_PROG -f $* $LOOP_DEV | _xfs_filter_mkfs >>$seqres.full 2>$tmp.mkfs if [ "${PIPESTATUS[0]}" -ne 0 ]; then _fail "Fails on _mkfs_dev $* $LOOP_DEV" fi diff --git a/tests/xfs/530 b/tests/xfs/530 index 9c6f44d7..925a7b49 100755 --- a/tests/xfs/530 +++ b/tests/xfs/530 @@ -38,7 +38,7 @@ _require_scratch_nocheck echo "* Test extending rt inodes" -_scratch_mkfs | _filter_mkfs >> $seqres.full 2> $tmp.mkfs +_scratch_mkfs | _xfs_filter_mkfs >> $seqres.full 2> $tmp.mkfs . $tmp.mkfs echo "Create fake rt volume" diff --git a/tests/xfs/533 b/tests/xfs/533 index b85b5298..c7d470c9 100755 --- a/tests/xfs/533 +++ b/tests/xfs/533 @@ -23,7 +23,7 @@ _require_test_program "punch-alternating" _require_xfs_io_error_injection "reduce_max_iextents" _require_xfs_io_error_injection "bmap_alloc_minlen_extent" -_scratch_mkfs_sized $((1024 * 1024 * 1024)) | _filter_mkfs >> $seqres.full 2> $tmp.mkfs +_scratch_mkfs_sized $((1024 * 1024 * 1024)) | _xfs_filter_mkfs >> $seqres.full 2> $tmp.mkfs . $tmp.mkfs # Filesystems with directory block size greater than one FSB will not be tested, From patchwork Mon Feb 7 03:09:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shin'ichiro Kawasaki X-Patchwork-Id: 12736853 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4602EC43219 for ; Mon, 7 Feb 2022 05:53:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237533AbiBGFuv (ORCPT ); Mon, 7 Feb 2022 00:50:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350029AbiBGDLJ (ORCPT ); Sun, 6 Feb 2022 22:11:09 -0500 Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A646BC061A73; Sun, 6 Feb 2022 19:11:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1644203468; x=1675739468; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=PmOAO/z/5SQRJrAaX0rjm1/SDaYQLCQkeqzLnW4Z6gk=; b=VnYCrlXHBj66mX6KLgmlIkWb5oiXbf/nz9JUSmtZ7lMSdsWKDAhTj7nH 8c4yPvbI3cCh1amhjIXInc9qPeb+vESCNJbU++FXE6uAcIPysI51OQR1e d1Ve+YVq173dxM/di8qY+CaYW7wWmIA4Gwn+OiiD033qvGyO8fyArY275 ahTVta9qgABDvE9S+WMWHyXS/12QvbHyxKaB+ljq17tekUbqhtscpYn/+ hkk4Xh6gu0Wxu5LwW/nUMZVlXpe5ern7VRivHbOBKQtMyMS8anV6ELQEv Y2LSmUfF4UKUymWmlt53Vp9TRqDEO/XfI5h4C18xES/PXE+ake5Q5WGQR g==; X-IronPort-AV: E=Sophos;i="5.88,348,1635177600"; d="scan'208";a="304196004" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 07 Feb 2022 11:10:05 +0800 IronPort-SDR: NOvly8AvOHwx0Lp4kDy7AFgREhST+tC/zzv3q7W2vit4qj+eh0xFDNDCV4GoJDrT+YG5fWtr4u aKBVyCe6V7jD4/qLPupjVYi+duYOzZCtnvUgQmtT4iylP8MTwJsJDsCrkmwV9f8At0DL4HUkYO MjBBTUu4nsGWVSAJdKHZM5LCh7d1/XSy6vGARpymD/macp7/5t3q23mRRG1lRA8u7+68PzpNt5 URrrw+mcAeDHrW3u64NhoVy51553qPGGqpIG7ElCbvalxDr2foJpv7ZEjU5xOvofqjzRZ4bXZ4 K2roiOI5CtB1PnUSPoNXA19Z Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2022 18:41:57 -0800 IronPort-SDR: y+FtjjJXOV8tZCikJPK5i2nH/1nKMjHT7ybJV+u3slTEU3e17ldTQDjwBM8cXLDCOn4HIV7dYs Y78DCMvPtVthMiAVNbVmMWuqdyRdIuva2kDIN3LDiqrS3bmAaVtqVZBZWGwnzgYlvVDb93ZHPq I8QeKy6zycHSp8wpNpFyi7lV9cH73RiiV3ZHrX6axpAgH7WgxN8wpg0Lrh6PnVzHQItaf6wVtp svUFCbv5uuUBzKIMiTWsKFHBkxjT8qq7PWONCrxUCQh6A0ueV02/8brxMn1uRp3WdINR/FPuTt IfM= WDCIronportException: Internal Received: from shindev.dhcp.fujisawa.hgst.com (HELO shindev.fujisawa.hgst.com) ([10.149.52.173]) by uls-op-cesaip01.wdc.com with ESMTP; 06 Feb 2022 19:10:05 -0800 From: Shin'ichiro Kawasaki To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Cc: Naohiro Aota , Johannes Thumshirn , Damien Le Moal , Shin'ichiro Kawasaki Subject: [PATCH 6/7] common: move _xfs_filter_mkfs from common/filter to common/xfs Date: Mon, 7 Feb 2022 12:09:57 +0900 Message-Id: <20220207030958.230618-7-shinichiro.kawasaki@wdc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220207030958.230618-1-shinichiro.kawasaki@wdc.com> References: <20220207030958.230618-1-shinichiro.kawasaki@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org The helper function _xfs_filter_mkfs works only for xfs. Move it from common/filter to common/xfs. Also remove useless lines for other filesystems. Suggested-by: Naohiro Aota Signed-off-by: Shin'ichiro Kawasaki --- common/filter | 53 --------------------------------------------------- common/xfs | 43 +++++++++++++++++++++++++++++++++++++++++ 2 files changed, 43 insertions(+), 53 deletions(-) diff --git a/common/filter b/common/filter index 24fd0650..7c71be4f 100644 --- a/common/filter +++ b/common/filter @@ -115,59 +115,6 @@ _filter_date() -e 's/[A-Z][a-z][a-z] [A-z][a-z][a-z] *[0-9][0-9]* [0-9][0-9]:[0-9][0-9]:[0-9][0-9] [0-9][0-9][0-9][0-9]$/DATE/' } -# prints filtered output on stdout, values (use eval) on stderr -# Non XFS filesystems always return a 4k block size and a 256 byte inode. -_xfs_filter_mkfs() -{ - case $FSTYP in - xfs) - ;; - *) - cat - >/dev/null - perl -e 'print STDERR "dbsize=4096\nisize=256\n"' - return ;; - esac - - echo "_fs_has_crcs=0" >&2 - set - - perl -ne ' - if (/^meta-data=([\w,|\/.-]+)\s+isize=(\d+)\s+agcount=(\d+), agsize=(\d+) blks/) { - print STDERR "ddev=$1\nisize=$2\nagcount=$3\nagsize=$4\n"; - print STDOUT "meta-data=DDEV isize=XXX agcount=N, agsize=XXX blks\n"; - } - if (/^\s+=\s+sectsz=(\d+)\s+attr=(\d+)/) { - print STDERR "sectsz=$1\nattr=$2\n"; - } - if (/^\s+=\s+crc=(\d)/) { - print STDERR "_fs_has_crcs=$1\n"; - } - if (/^data\s+=\s+bsize=(\d+)\s+blocks=(\d+), imaxpct=(\d+)/) { - print STDERR "dbsize=$1\ndblocks=$2\nimaxpct=$3\n"; - print STDOUT "data = bsize=XXX blocks=XXX, imaxpct=PCT\n"; - } - if (/^\s+=\s+sunit=(\d+)\s+swidth=(\d+) blks/) { - print STDERR "sunit=$1\nswidth=$2\nunwritten=1\n"; - print STDOUT " = sunit=XXX swidth=XXX, unwritten=X\n"; - } - if (/^naming\s+=version\s+(\d+)\s+bsize=(\d+)/) { - print STDERR "dirversion=$1\ndirbsize=$2\n"; - print STDOUT "naming =VERN bsize=XXX\n"; - } - if (/^log\s+=(internal log|[\w|\/.-]+)\s+bsize=(\d+)\s+blocks=(\d+),\s+version=(\d+)/ || - /^log\s+=(internal log|[\w|\/.-]+)\s+bsize=(\d+)\s+blocks=(\d+)/) { - print STDERR "ldev=\"$1\"\nlbsize=$2\nlblocks=$3\nlversion=$4\n"; - print STDOUT "log =LDEV bsize=XXX blocks=XXX\n"; - } - if (/^\s+=\s+sectsz=(\d+)\s+sunit=(\d+) blks/) { - print STDERR "logsectsz=$1\nlogsunit=$2\n\n"; - } - if (/^realtime\s+=([\w|\/.-]+)\s+extsz=(\d+)\s+blocks=(\d+), rtextents=(\d+)/) { - print STDERR "rtdev=$1\nrtextsz=$2\nrtblocks=$3\nrtextents=$4\n"; - print STDOUT "realtime =RDEV extsz=XXX blocks=XXX, rtextents=XXX\n"; - }' -} - - # prints the bits we care about in growfs # _filter_growfs() diff --git a/common/xfs b/common/xfs index 3435c706..a3da25dd 100644 --- a/common/xfs +++ b/common/xfs @@ -1275,3 +1275,46 @@ _require_scratch_xfs_bigtime() _notrun "bigtime feature not advertised on mount?" _scratch_unmount } + +# prints filtered output on stdout, values (use eval) on stderr +# Non XFS filesystems always return a 4k block size and a 256 byte inode. +_xfs_filter_mkfs() +{ + echo "_fs_has_crcs=0" >&2 + set - + perl -ne ' + if (/^meta-data=([\w,|\/.-]+)\s+isize=(\d+)\s+agcount=(\d+), agsize=(\d+) blks/) { + print STDERR "ddev=$1\nisize=$2\nagcount=$3\nagsize=$4\n"; + print STDOUT "meta-data=DDEV isize=XXX agcount=N, agsize=XXX blks\n"; + } + if (/^\s+=\s+sectsz=(\d+)\s+attr=(\d+)/) { + print STDERR "sectsz=$1\nattr=$2\n"; + } + if (/^\s+=\s+crc=(\d)/) { + print STDERR "_fs_has_crcs=$1\n"; + } + if (/^data\s+=\s+bsize=(\d+)\s+blocks=(\d+), imaxpct=(\d+)/) { + print STDERR "dbsize=$1\ndblocks=$2\nimaxpct=$3\n"; + print STDOUT "data = bsize=XXX blocks=XXX, imaxpct=PCT\n"; + } + if (/^\s+=\s+sunit=(\d+)\s+swidth=(\d+) blks/) { + print STDERR "sunit=$1\nswidth=$2\nunwritten=1\n"; + print STDOUT " = sunit=XXX swidth=XXX, unwritten=X\n"; + } + if (/^naming\s+=version\s+(\d+)\s+bsize=(\d+)/) { + print STDERR "dirversion=$1\ndirbsize=$2\n"; + print STDOUT "naming =VERN bsize=XXX\n"; + } + if (/^log\s+=(internal log|[\w|\/.-]+)\s+bsize=(\d+)\s+blocks=(\d+),\s+version=(\d+)/ || + /^log\s+=(internal log|[\w|\/.-]+)\s+bsize=(\d+)\s+blocks=(\d+)/) { + print STDERR "ldev=\"$1\"\nlbsize=$2\nlblocks=$3\nlversion=$4\n"; + print STDOUT "log =LDEV bsize=XXX blocks=XXX\n"; + } + if (/^\s+=\s+sectsz=(\d+)\s+sunit=(\d+) blks/) { + print STDERR "logsectsz=$1\nlogsunit=$2\n\n"; + } + if (/^realtime\s+=([\w|\/.-]+)\s+extsz=(\d+)\s+blocks=(\d+), rtextents=(\d+)/) { + print STDERR "rtdev=$1\nrtextsz=$2\nrtblocks=$3\nrtextents=$4\n"; + print STDOUT "realtime =RDEV extsz=XXX blocks=XXX, rtextents=XXX\n"; + }' +} From patchwork Mon Feb 7 03:09:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shin'ichiro Kawasaki X-Patchwork-Id: 12736851 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F9A8C433FE for ; Mon, 7 Feb 2022 05:53:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237058AbiBGFuv (ORCPT ); Mon, 7 Feb 2022 00:50:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350030AbiBGDLK (ORCPT ); Sun, 6 Feb 2022 22:11:10 -0500 Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2A75C061A73; Sun, 6 Feb 2022 19:11:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1644203469; x=1675739469; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=78Zs28KpKxQ8bPUPZ5jK1PRmnWo6oej03te2uWqoGL8=; b=PZF7QaA30zZQyfJW87dihb28uHEKpHwzuvhbjxTqI5PibiuV2vb3awYR cLrQWDKo5MiaRx0yNky3fPtiVjAHkpcuASBU/FZdV5nUVlw26xL+S5uNN uvAU0b6rGGd6pnDi4/wljNaK9IX1W0g6uhzLD062CaJyp3030gxpOW3bY g/f2eRX+R7Sr2a2BZJPyRDNer2jrdUDeXh5227FZRo0VNaQTQurxd6MGY j8pCqVZc5XrSymlUMUxgtlPjn0fJ9H1d5HLGWtTjyNUVxsOgHGT4/+Oij 576/OOjpwx0wPKbr7eAm6toYFQoFQu+nfSB9uw3FFSkQEnnkS4CiW/iAr g==; X-IronPort-AV: E=Sophos;i="5.88,348,1635177600"; d="scan'208";a="304196008" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 07 Feb 2022 11:10:07 +0800 IronPort-SDR: 7iDGEH0L929p0tZV/jztdzJE9bGKXzLcz2gZ2B6Sl23BJJeHEiLXjxN/ZA4WfMe36hAGXI4LhK pYhvmPvjkkDd6YXtrCDaNS49bedWUw0z6tWwoqJQoHARrF5U10Bt1oMkrWml/fYSC5lSnMgFxQ zmQbksiDIr40VN3cx278BPQTBKFPMRR7XhVXoCJupUP+Tf3N22xijC1ZGQXkLJlPay6nzFZ10D MGT1bWU3fH79Kes3IHxesvDvdMAfpbVft7/VhXJRnqji29Za73m9il0PbfxFPJY2PyNSdLR2ia Y3+yHlKDS6bAu5Yjr8/ehhYA Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2022 18:41:58 -0800 IronPort-SDR: sfiKrR+rVbdQfys4Bir2TjDK7Yea21y0Qclmn1kaarOfo6+/pwgc1U2K4DmzeTxexTXueRU1UI IXBuBf6RulRY7HiDEb3MRzzhyI93VA+vynCnftlDW0ddkPi90ki7kg29lnVFsv6Ydck1H18FQi VKApRk/uqmDS8D1ohuj9n59oLtwNbcoBu7zaP81RAm+5wwp3pPrt3EWoN8QJqFhS87+t66TIw3 r57NHP35BFODmDxQ8HfEjLFWYbura8VHn+n+mGEw6YckVPupYcOPrxTNsAo6r+UKGc88vitERK sD4= WDCIronportException: Internal Received: from shindev.dhcp.fujisawa.hgst.com (HELO shindev.fujisawa.hgst.com) ([10.149.52.173]) by uls-op-cesaip01.wdc.com with ESMTP; 06 Feb 2022 19:10:06 -0800 From: Shin'ichiro Kawasaki To: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org Cc: Naohiro Aota , Johannes Thumshirn , Damien Le Moal , Shin'ichiro Kawasaki Subject: [PATCH 7/7] generic/204: do xfs unique preparation only for xfs Date: Mon, 7 Feb 2022 12:09:58 +0900 Message-Id: <20220207030958.230618-8-shinichiro.kawasaki@wdc.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220207030958.230618-1-shinichiro.kawasaki@wdc.com> References: <20220207030958.230618-1-shinichiro.kawasaki@wdc.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org The test case generic/204 formats the scratch device to get block size as a part of preparation. However, this preparation is required only for xfs. To simplify preparation for other filesystems, do the preparation only for xfs. Suggested-by: Naohiro Aota Signed-off-by: Shin'ichiro Kawasaki --- tests/generic/204 | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/tests/generic/204 b/tests/generic/204 index 40d524d1..ea267760 100755 --- a/tests/generic/204 +++ b/tests/generic/204 @@ -16,17 +16,18 @@ _cleanup() sync } -# Import common functions. -. ./common/filter - # real QA test starts here _supported_fs generic _require_scratch -# get the block size first -_scratch_mkfs 2> /dev/null | _xfs_filter_mkfs 2> $tmp.mkfs > /dev/null -. $tmp.mkfs +dbsize=4096 +isize=256 +if [ $FSTYP = "xfs" ]; then + # get the block size first + _scratch_mkfs 2> /dev/null | _xfs_filter_mkfs 2> $tmp.mkfs > /dev/null + . $tmp.mkfs +fi # For xfs, we need to handle the different default log sizes that different # versions of mkfs create. All should be valid with a 16MB log, so use that. @@ -37,11 +38,15 @@ _scratch_mkfs 2> /dev/null | _xfs_filter_mkfs 2> $tmp.mkfs > /dev/null SIZE=`expr 115 \* 1024 \* 1024` _scratch_mkfs_sized $SIZE $dbsize 2> /dev/null > $tmp.mkfs.raw \ || _fail "mkfs failed" -cat $tmp.mkfs.raw | _xfs_filter_mkfs 2> $tmp.mkfs > /dev/null + +if [ $FSTYP = "xfs" ]; then + cat $tmp.mkfs.raw | _xfs_filter_mkfs 2> $tmp.mkfs > /dev/null + # Source $tmp.mkfs to get geometry + . $tmp.mkfs +fi + _scratch_mount -# Source $tmp.mkfs to get geometry -. $tmp.mkfs # fix the reserve block pool to a known size so that the enospc calculations # work out correctly. Space usages is based 22500 files and 1024 reserved blocks