From patchwork Mon Feb 7 21:30:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julia Lawall X-Patchwork-Id: 12737903 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27D7AC433F5 for ; Mon, 7 Feb 2022 21:32:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=s7UNK4+V4BC3lSMP3dw4YOrlm3AHkcPCnROrM/qEIdA=; b=on2b7m07TN4HmU okf7VlzVqF21gO+hRQ6VoiOAaUQhSEeOpdeWYDpB8jsHOdhFn4sgll7omdogK95vOsxgk6AYyypIR zoe7hR5QCHm5Pt+wbezrVdETflQM2TxzicnCLuICmyP7BFhb9OP9Ue6ZEXohJRk/ZzWXX5ZJKefPN iPoCI08kZXGK1YTQMl22HuZAS7YZ0yq6R28UEvbNLy7HBL1G9aYLWFJvxzxyhnHsoaZWGEzghvllL Dmt1S7tEpT2e+MIZiRPgrEQ8RJ9FNxjmUF5038EGVje/rsF1cbnAp7/cLVd882xdLqkq/KvyZmzAr 8v7MqybDkZvEoPm3xNUw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHBad-00Bls0-DS; Mon, 07 Feb 2022 21:30:27 +0000 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nHBaZ-00Blqd-8B for linux-arm-kernel@lists.infradead.org; Mon, 07 Feb 2022 21:30:25 +0000 X-IronPort-AV: E=Sophos;i="5.88,350,1635199200"; d="scan'208";a="5266113" Received: from 173.121.68.85.rev.sfr.net (HELO hadrien) ([85.68.121.173]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 22:30:16 +0100 Date: Mon, 7 Feb 2022 22:30:15 +0100 (CET) From: Julia Lawall X-X-Sender: jll@hadrien To: Amit Kumar Mahapatra , Michal Simek , Naga Sureshkumar Relli , Mark Brown , linux-spi@vger.kernel.org cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kbuild-all@lists.01.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] spi: spi-zynqmp-gqspi: fix for_each_child.cocci warnings Message-ID: User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220207_133023_628644_8FAB616E X-CRM114-Status: UNSURE ( 9.90 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: kernel test robot for_each_available_child_of_node should have of_node_put() before break. Generated by: scripts/coccinelle/iterators/for_each_child.cocci Fixes: f0fcd7d14036 ("spi: spi-zynqmp-gqspi: Fix suspend/resume") CC: Amit Kumar Mahapatra Reported-by: kernel test robot Signed-off-by: kernel test robot Signed-off-by: Julia Lawall --- tree: https://github.com/Xilinx/linux-xlnx xlnx_rebase_v5.15 head: 1183ce490adb103e5e569b8ebd74c50c885ddc05 commit: f0fcd7d140361b1f54cfd76afb8c3afc9bf218a5 [857/872] spi: spi-zynqmp-gqspi: Fix suspend/resume :::::: branch date: 3 days ago :::::: commit date: 3 days ago Please take the patch only if it's a positive warning. Thanks! spi-zynqmp-gqspi.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/spi/spi-zynqmp-gqspi.c +++ b/drivers/spi/spi-zynqmp-gqspi.c @@ -1395,6 +1395,7 @@ static int zynqmp_qspi_probe(struct plat &rx_bus_width); if (!ret) { xqspi->rx_bus_width = rx_bus_width; + of_node_put(nc); break; } } @@ -1407,6 +1408,7 @@ static int zynqmp_qspi_probe(struct plat &tx_bus_width); if (!ret) { xqspi->tx_bus_width = tx_bus_width; + of_node_put(nc); break; } }