From patchwork Thu Feb 10 11:41:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 12741782 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63779C433EF for ; Thu, 10 Feb 2022 11:41:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 893C710E816; Thu, 10 Feb 2022 11:41:18 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB70810E815; Thu, 10 Feb 2022 11:41:16 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1DBEE61D12; Thu, 10 Feb 2022 11:41:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C632EC004E1; Thu, 10 Feb 2022 11:41:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644493275; bh=YX1gi59/HZbFW3O0Wnmg+lqGfVhLTyza+iIoN+OkqZ4=; h=From:To:Cc:Subject:Date:From; b=WdhEQGRtOpRhyZ6JWVwUVoJSQt9Imap+QU8DPJgQYnD4UI6NkPC67iN6XW2w4X4zx sRcVtwhOm9l3tiEY6pMPQlccFPEDowvg7IVRhr1hTosIlbhx0RZR6Jc21emXLIX7KY XCjFH6rdRXbkuSQVEii+16t3UZk3uWOPbmBz2dcPsjtIwfsa66vLxkxdwvOi8nMCbS aN4h77DFeEsc+PMnpyxGgfGQZzAn0a8zKoiJZtrEBK6v8mXBJvShV++3j1pbL2zItX 6FhW2VjPqdwm2xjlFNP8oPu04Cfn5eT88xdnXL2UynMZ9jwKj69rKFpOQ9cJwKrw9p JmVgwIN2YxCBw== From: Vinod Koul To: Rob Clark Subject: [PATCH 1/3] drm/msm/dpu: Remove set but unused variables Date: Thu, 10 Feb 2022 17:11:04 +0530 Message-Id: <20220210114106.290669-1-vkoul@kernel.org> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kalyan Thota , freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, David Airlie , linux-arm-msm@vger.kernel.org, Kuogee Hsieh , Abhinav Kumar , dri-devel@lists.freedesktop.org, Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Stephen Boyd , Sean Paul , Guenter Roeck , Mark Yacoub Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" We get warning: In function ‘dpu_encoder_virt_enable’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1145:33: warning: variable ‘priv’ set but not used [-Wunused-but-set-variable] 1145 | struct msm_drm_private *priv; In function ‘dpu_encoder_virt_disable’: drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:1182:33: warning: variable ‘priv’ set but not used [-Wunused-but-set-variable] 1182 | struct msm_drm_private *priv; Remove these unused but set variables Signed-off-by: Vinod Koul Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c index 1e648db439f9..132844801e92 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c @@ -1142,14 +1142,12 @@ static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc) { struct dpu_encoder_virt *dpu_enc = NULL; int ret = 0; - struct msm_drm_private *priv; struct drm_display_mode *cur_mode = NULL; dpu_enc = to_dpu_encoder_virt(drm_enc); mutex_lock(&dpu_enc->enc_lock); cur_mode = &dpu_enc->base.crtc->state->adjusted_mode; - priv = drm_enc->dev->dev_private; trace_dpu_enc_enable(DRMID(drm_enc), cur_mode->hdisplay, cur_mode->vdisplay); @@ -1179,7 +1177,6 @@ static void dpu_encoder_virt_enable(struct drm_encoder *drm_enc) static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc) { struct dpu_encoder_virt *dpu_enc = NULL; - struct msm_drm_private *priv; int i = 0; dpu_enc = to_dpu_encoder_virt(drm_enc); @@ -1188,8 +1185,6 @@ static void dpu_encoder_virt_disable(struct drm_encoder *drm_enc) mutex_lock(&dpu_enc->enc_lock); dpu_enc->enabled = false; - priv = drm_enc->dev->dev_private; - trace_dpu_enc_disable(DRMID(drm_enc)); /* wait for idle */ From patchwork Thu Feb 10 11:41:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 12741808 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 318F9C433F5 for ; Thu, 10 Feb 2022 11:48:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 164B610E81D; Thu, 10 Feb 2022 11:48:40 +0000 (UTC) X-Greylist: delayed 434 seconds by postgrey-1.36 at gabe; Thu, 10 Feb 2022 11:48:38 UTC Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9578110E81D; Thu, 10 Feb 2022 11:48:38 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 22C97CE2312; Thu, 10 Feb 2022 11:41:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 21AB9C340ED; Thu, 10 Feb 2022 11:41:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644493280; bh=H2RdFMbRP7RJJRAbgsf+fGP8lEtZwF/hA1bM/itUqRE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sPMMjUOrJ36Af0bXmXEh9TZNqVWM8Z2gvyQc9iwH6TuLRaleJsmfGneK6uljoO0C4 DHYvQxvj5PdVH+eKT0jFZNEEz9ej9L5/w9q3KG0CwXSZwQ0gINtaNShvCT3oLdT4zO u+xSeaOICJ8Z3M/kciEvTOla5F+pNkNAm8xaZcpEsDxxAPNyR2QQ31uTYtgB4Ijyui 9NWpXsR4E2a+c/hZO6/o8k+OmNgIvt0LVmvVIqnANsDCnBkYFKLr5HmBBXqrG/Yy/4 tMu+X+rvOcE2CunOqHc6PGNoREf9FxL+1CXnf1GZbAy4Lp6gGvs48liOgtZ3yK13Ef nr4dM/DxdapjQ== From: Vinod Koul To: Rob Clark Subject: [PATCH 2/3] drm/msm/dpu: Update the comment style Date: Thu, 10 Feb 2022 17:11:05 +0530 Message-Id: <20220210114106.290669-2-vkoul@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220210114106.290669-1-vkoul@kernel.org> References: <20220210114106.290669-1-vkoul@kernel.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kalyan Thota , freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, Kuogee Hsieh , Abhinav Kumar , dri-devel@lists.freedesktop.org, Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Stephen Boyd , Sean Paul , Guenter Roeck , Mark Yacoub Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The multi line comment style is wrongly used as kernel-doc comment. This gives a warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:17: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Update the style to fix this. Signed-off-by: Vinod Koul Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c index a77a5eaa78ad..9341c88a336f 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c @@ -13,7 +13,7 @@ #include "dpu_hw_mdss.h" #include "dpu_trace.h" -/** +/* * Register offsets in MDSS register file for the interrupt registers * w.r.t. to the MDP base */ From patchwork Thu Feb 10 11:41:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vinod Koul X-Patchwork-Id: 12741783 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7EE79C433F5 for ; Thu, 10 Feb 2022 11:41:29 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A124D10E817; Thu, 10 Feb 2022 11:41:28 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id C70CB10E813; Thu, 10 Feb 2022 11:41:26 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4066361D1F; Thu, 10 Feb 2022 11:41:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 325A5C340F0; Thu, 10 Feb 2022 11:41:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644493285; bh=/OutVh/eSlM2D8L/jMfWJxxmWG0tTyYf7k89K741aNo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rl5jqfj6jAysGYxqiYPgAg6AcYBKVWA+be7zn8KTweo4BrfXSQEzU4cTA5bdnlpOU 6XPvLHgV6Sb5vXd+896oDooDKmf28WoBQXSXnvY3+c6B+TKEaGbaGLCfnCpWF+faOQ Se4X4Fghg5RP0+GcYjv8frytkY6c9V+63tYTqgN33LHXIFlFM2BomvD40Ku5h4MeL6 75FDh+UaW5i4vdBD4CQgJTwpJxOTjGMk5lmbP6jhG6YBBgXqtH0oTnQ8s2jKWMQG8i bycVXyrcOQZ3RhAQ/XKHHb7oDDAmstJzrlyXlBGp2SUiaeI/dwvcNOhAuBRKzx+76P wOrOqJwyVq+pQ== From: Vinod Koul To: Rob Clark Subject: [PATCH 3/3] drm/msm/dpu: Update function parameter documentation Date: Thu, 10 Feb 2022 17:11:06 +0530 Message-Id: <20220210114106.290669-3-vkoul@kernel.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20220210114106.290669-1-vkoul@kernel.org> References: <20220210114106.290669-1-vkoul@kernel.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kalyan Thota , freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, Kuogee Hsieh , Abhinav Kumar , dri-devel@lists.freedesktop.org, Bjorn Andersson , Vinod Koul , Dmitry Baryshkov , Stephen Boyd , Sean Paul , Guenter Roeck , Mark Yacoub Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" dpu_core_irq_callback_handler() function comments seem to have become stale and emit a warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147: warning: Function parameter or member 'dpu_kms' not described in 'dpu_core_irq_callback_handler' drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c:147: warning: Excess function parameter 'arg' description in 'dpu_core_irq_callback_handler' Fix by updating the documentation Signed-off-by: Vinod Koul Reviewed-by: Dmitry Baryshkov Reviewed-by: Abhinav Kumar --- drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c index 9341c88a336f..27073fd49fee 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c @@ -140,7 +140,7 @@ static const struct dpu_intr_reg dpu_intr_set[] = { /** * dpu_core_irq_callback_handler - dispatch core interrupts - * @arg: private data of callback handler + * @dpu_kms: Pointer to DPU's KMS structure * @irq_idx: interrupt index */ static void dpu_core_irq_callback_handler(struct dpu_kms *dpu_kms, int irq_idx)