From patchwork Sat Dec 29 07:07:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Rosin X-Patchwork-Id: 10745989 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C169014E2 for ; Tue, 1 Jan 2019 21:47:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B2F33286A7 for ; Tue, 1 Jan 2019 21:47:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A77D7287AB; Tue, 1 Jan 2019 21:47:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 52744286A7 for ; Tue, 1 Jan 2019 21:47:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1CC3B6E292; Tue, 1 Jan 2019 21:47:14 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150099.outbound.protection.outlook.com [40.107.15.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id E8A5F6E0A6 for ; Sat, 29 Dec 2018 07:07:21 +0000 (UTC) Received: from AM0PR0202MB3267.eurprd02.prod.outlook.com (52.133.34.148) by AM0PR0202MB3459.eurprd02.prod.outlook.com (52.133.35.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1471.20; Sat, 29 Dec 2018 07:07:19 +0000 Received: from AM0PR0202MB3267.eurprd02.prod.outlook.com ([fe80::cdf9:e79c:8ad0:7422]) by AM0PR0202MB3267.eurprd02.prod.outlook.com ([fe80::cdf9:e79c:8ad0:7422%5]) with mapi id 15.20.1471.019; Sat, 29 Dec 2018 07:07:19 +0000 From: Peter Rosin To: "linux-kernel@vger.kernel.org" Subject: [PATCH v3 1/5] dt-bindings: display: bridge: fork out ti,ds90c185 from lvds-transmitter Thread-Topic: [PATCH v3 1/5] dt-bindings: display: bridge: fork out ti,ds90c185 from lvds-transmitter Thread-Index: AQHUn0UjTwFZ5Unco0Sw1517iPZW4g== Date: Sat, 29 Dec 2018 07:07:19 +0000 Message-ID: <20181229070649.21308-2-peda@axentia.se> References: <20181229070649.21308-1-peda@axentia.se> In-Reply-To: <20181229070649.21308-1-peda@axentia.se> Accept-Language: en-US, sv-SE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.11.0 x-originating-ip: [85.226.244.23] x-clientproxiedby: HE1PR0502CA0002.eurprd05.prod.outlook.com (2603:10a6:3:e3::12) To AM0PR0202MB3267.eurprd02.prod.outlook.com (2603:10a6:208:5::20) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR0202MB3459; 6:M7bpl6UvCXkIJOPU9Qfw7MfqKWsOPaN30se0m2Elg4M4UdhEW1IWB1XJ4vPsylCMy5IhDhJoJ3NpNIFOpBEjdc3lmOn7XJzxcTj+Zj8NmW+6BPeePnnq/NLUzryGG8k4xw/6oFWqyvXyAb8qy2T3ClAY7lqJ4lZYF9td83rYcx3bfaoJSTPM9KVRGywLGyg8IEglNtO40S1y6SiEe2lNu60Q6Mrlx36nlBn/NcUIW2yEkYU5BSeZ3AXeU4BUCAd6esjNDJRfsur3vmXHne+BDdPk9aaDHFgEMPqsGC7kOj0QVNzuL75h92eI2TyUVirtUoThkElTPP3uhRVJefBMdwU/y9qE2Snrv84Y4gD1HA/iPNwM8yu46xy37GsoFZQhXUqmrNvp6lT7CMzd2tqswVdUF6YNDvwtmgDTBijVYpUz/ipk/cl1vrwH65OGQfkABG8gt94f7qR56pHdwABn9w==; 5:ZiNc1O71NcH5/cjU5wXPZtxI3esbnf9tOFJV5jqjtCx4lJEph0oZ4w2oER855UCtzHQ6RCoAicZLXC7/idq6PuZBk3xELFDP70LoW/Ko+2jJgp/Lf1OsEJWjjJaCcIYo5RTJyJ2Y/f6hfxcb7zVynFXck3HPQElneyTzBNCNymA=; 7:rzA7qoHTDD7L5HwH+gmZTyueQJuckGY9VEEAkckDhNG4IMcC06LbmA6X44n/gOlGk1CT/Gx7iYHMulqjyiMpzQOr1v8rYryD7DgloP6GwOlvHrQMvzB8gIlozl2Gvlcr5ToyQuzSfNUWnz0pHxKGlg== x-ms-office365-filtering-correlation-id: a5e9bb04-a616-4c90-5396-08d66d5c4568 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(7021145)(8989299)(5600109)(711020)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(2017052603328)(7153060)(7193020); SRVR:AM0PR0202MB3459; x-ms-traffictypediagnostic: AM0PR0202MB3459: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(3230021)(908002)(999002)(5005026)(6040522)(8220055)(2401047)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231475)(944501520)(52105112)(6041310)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(2016111802025)(6043046)(201708071742011)(7699051)(76991095); SRVR:AM0PR0202MB3459; BCL:0; PCL:0; RULEID:; SRVR:AM0PR0202MB3459; x-forefront-prvs: 09011458FC x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(396003)(366004)(346002)(39830400003)(136003)(189003)(199004)(71200400001)(71190400001)(66066001)(6916009)(305945005)(99286004)(8676002)(81166006)(106356001)(6116002)(6436002)(81156014)(7736002)(2616005)(1076003)(86362001)(2906002)(6486002)(8936002)(476003)(74482002)(54906003)(3846002)(256004)(446003)(11346002)(486006)(68736007)(50226002)(186003)(5660300001)(316002)(36756003)(14454004)(6506007)(6512007)(508600001)(76176011)(2351001)(52116002)(97736004)(26005)(4326008)(5640700003)(386003)(25786009)(53936002)(102836004)(105586002)(2501003)(142933001); DIR:OUT; SFP:1102; SCL:1; SRVR:AM0PR0202MB3459; H:AM0PR0202MB3267.eurprd02.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: axentia.se does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: +5bm+Blk1x9G1h5YRLbnmUkckiSQz0IcASGxbJ1g5EN9Dz6AhDzAuloChrttuA+7FpU6jskqwHE0sAVk+9PtZKcfBkPzMfnEeUqcR80m7SJqJ+c86wDCXeH82OVAZOk1F2y4ve9wllXNkugj70X/vknVZK63uQ1O3olDRQCp5BWko2xtfV14cwGX54w1zZB6w1Rm/6LMuMUIEjPudAfOYSNDduhkDOt86VDOXUY5iDXM95HaSwbrhzDk+Tu1etbjd0gZVrifjSuSrQlDIhJZN5JZYbBFAcZfVsWzJi7EZN8yiaGnxXpJtaZGySlpJVA6 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-Network-Message-Id: a5e9bb04-a616-4c90-5396-08d66d5c4568 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2018 07:07:19.2280 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0202MB3459 X-Mailman-Approved-At: Tue, 01 Jan 2019 21:47:02 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , David Airlie , "dri-devel@lists.freedesktop.org" , Rob Herring , Laurent Pinchart , Peter Rosin Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP DS90C185 has a shutdown pin which does not fit in the lvds-transmitter binding, which is meant to be generic. The sister chip DS90C187 is similar to DS90C185, describe it here as well. Signed-off-by: Peter Rosin Reviewed-by: Laurent Pinchart --- .../bindings/display/bridge/lvds-transmitter.txt | 8 +--- .../bindings/display/bridge/ti,ds90c185.txt | 55 ++++++++++++++++++++++ 2 files changed, 56 insertions(+), 7 deletions(-) create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt index 50220190c203..fd39ad34c383 100644 --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt @@ -22,13 +22,7 @@ among others. Required properties: -- compatible: Must be one or more of the following - - "ti,ds90c185" for the TI DS90C185 FPD-Link Serializer - - "lvds-encoder" for a generic LVDS encoder device - - When compatible with the generic version, nodes must list the - device-specific version corresponding to the device first - followed by the generic version. +- compatible: Must be "lvds-encoder" Required nodes: diff --git a/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt b/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt new file mode 100644 index 000000000000..e575f996959a --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt @@ -0,0 +1,55 @@ +Texas Instruments FPD-Link (LVDS) Serializer +-------------------------------------------- + +The DS90C185 and DS90C187 are low-power serializers for portable +battery-powered applications that reduces the size of the RGB +interface between the host GPU and the display. + +Required properties: + +- compatible: Should be + "ti,ds90c185", "lvds-encoder" for the TI DS90C185 FPD-Link Serializer + "ti,ds90c187", "lvds-encoder" for the TI DS90C187 FPD-Link Serializer + +Optional properties: + +- powerdown-gpios: Power down control GPIO (the PDB pin, active-low) + +Required nodes: + +The devices have two video ports. Their connections are modeled using the OF +graph bindings specified in Documentation/devicetree/bindings/graph.txt. + +- Video port 0 for parallel input +- Video port 1 for LVDS output + + +Example +------- + +lvds-encoder { + compatible = "ti,ds90c185", "lvds-encoder"; + + powerdown-gpios = <&gpio 17 GPIO_ACTIVE_LOW>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + lvds_enc_in: endpoint { + remote-endpoint = <&lcdc_out_rgb>; + }; + }; + + port@1 { + reg = <1>; + + lvds_enc_out: endpoint { + remote-endpoint = <&lvds_panel_in>; + }; + }; + }; +}; From patchwork Sat Dec 29 07:07:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Rosin X-Patchwork-Id: 10745973 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 404FA746 for ; Tue, 1 Jan 2019 21:47:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 328E6286A7 for ; Tue, 1 Jan 2019 21:47:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 262C7287AB; Tue, 1 Jan 2019 21:47:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2B8FE286A7 for ; Tue, 1 Jan 2019 21:47:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A9C0D6E287; Tue, 1 Jan 2019 21:47:03 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150134.outbound.protection.outlook.com [40.107.15.134]) by gabe.freedesktop.org (Postfix) with ESMTPS id D56EB6E2A6 for ; Sat, 29 Dec 2018 07:07:27 +0000 (UTC) Received: from AM0PR0202MB3267.eurprd02.prod.outlook.com (52.133.34.148) by AM0PR0202MB3459.eurprd02.prod.outlook.com (52.133.35.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1471.20; Sat, 29 Dec 2018 07:07:25 +0000 Received: from AM0PR0202MB3267.eurprd02.prod.outlook.com ([fe80::cdf9:e79c:8ad0:7422]) by AM0PR0202MB3267.eurprd02.prod.outlook.com ([fe80::cdf9:e79c:8ad0:7422%5]) with mapi id 15.20.1471.019; Sat, 29 Dec 2018 07:07:25 +0000 From: Peter Rosin To: "linux-kernel@vger.kernel.org" Subject: [PATCH v3 2/5] dt-bindings: display: bridge: lvds-transmitter: cleanup example Thread-Topic: [PATCH v3 2/5] dt-bindings: display: bridge: lvds-transmitter: cleanup example Thread-Index: AQHUn0Um/iP7IO6lR0ueJlfs1GZeJw== Date: Sat, 29 Dec 2018 07:07:25 +0000 Message-ID: <20181229070649.21308-3-peda@axentia.se> References: <20181229070649.21308-1-peda@axentia.se> In-Reply-To: <20181229070649.21308-1-peda@axentia.se> Accept-Language: en-US, sv-SE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.11.0 x-originating-ip: [85.226.244.23] x-clientproxiedby: HE1PR0502CA0002.eurprd05.prod.outlook.com (2603:10a6:3:e3::12) To AM0PR0202MB3267.eurprd02.prod.outlook.com (2603:10a6:208:5::20) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR0202MB3459; 6:Ul0jcO4Zw7uhBfskOkd5gjK+GqUy3nGXXe7fKCTLknynkcxR7QyECRHXoS0Pj3EbQfqWbIONNn6eKw8E2JX/517U2NzLiafxyZNPKXHIedXmI27cVPZp9N2xjm0SVvIhW3k1L9RktktT2el9mRfGV93wvB4LidiZwJ2sS6UQz+VsbSZhGY8uEBhsC/NVBFaU+74VIal9A3kyHyITSlhtedfgUud3c23qKo/yU9ac7+FCfFwALXylMp39jMWPnvg1UHUKtJ1A9Eb67Ck2zkKW7Y4992B1pdXjfVmdYi2yYd6na0Si8kDbF00fqN+uP6ho/pqlqLUmQa+1VFqJvT+rqbKl6jZ5l2ur2A+G5ns8GmjXttrKz3/6nlYA68zZOMATh0AmreWKTi1rSMh8Sk1J+qEzNTuDvmHeNnfmkpBFlvNtzAjFXAGZWs5nOlobKbrLERcv4SHmimCud6NopteVUQ==; 5:/R12PXWEnLmSfJhxZsJctKL8uK5avnrM/w9iyQCIjb3G6Pxv2KMi+ql/aUM0ufc9O47FkVxYIgvBC2MLWZ1MSFmrevgD0f2/dogD3L7iFROvCEQQk+GkuUxgiYcrZKx0zXDuz3DkdpygRFCyW7BJzz/QFTvjftrAoFM5V9D11Vo=; 7:zVcGEqZyBTfyw1cLAhFoKOoZXt/6if/81Wc50F2e7ctvLnrUzAhOAevCEQ4ZGAA6jCLeH3e/4ZikEFR31fTvwLzRGx7GRWI4Cb8dzlwAC+mJYxUMo2QeTdikFTjM1U/yHY145EjeWWX6ZB8WAegXeg== x-ms-office365-filtering-correlation-id: 9e986097-7a36-4343-dbe4-08d66d5c491e x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(7021145)(8989299)(5600109)(711020)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(2017052603328)(7153060)(7193020); SRVR:AM0PR0202MB3459; x-ms-traffictypediagnostic: AM0PR0202MB3459: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(3230021)(908002)(999002)(5005026)(6040522)(8220055)(2401047)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231475)(944501520)(52105112)(6041310)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(2016111802025)(6043046)(201708071742011)(7699051)(76991095); SRVR:AM0PR0202MB3459; BCL:0; PCL:0; RULEID:; SRVR:AM0PR0202MB3459; x-forefront-prvs: 09011458FC x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(396003)(366004)(346002)(39830400003)(136003)(189003)(199004)(71200400001)(71190400001)(66066001)(6916009)(305945005)(99286004)(8676002)(81166006)(106356001)(6116002)(6436002)(81156014)(7736002)(2616005)(1076003)(86362001)(2906002)(6486002)(8936002)(476003)(74482002)(54906003)(3846002)(256004)(446003)(11346002)(486006)(68736007)(50226002)(186003)(5660300001)(316002)(36756003)(14454004)(6506007)(6512007)(508600001)(76176011)(2351001)(52116002)(97736004)(26005)(4326008)(5640700003)(386003)(25786009)(53936002)(102836004)(105586002)(2501003); DIR:OUT; SFP:1102; SCL:1; SRVR:AM0PR0202MB3459; H:AM0PR0202MB3267.eurprd02.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: axentia.se does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: EneM4bsWQwflGvr/1vUUYoPfFDJbk9s8PTVBOypCFCnX67sn7WIkeelo8dTV2ZY/ChGFfFZBCKV1QXtRWEsknnEJax5TE2KTRauFWHO2/jhCK9qTNU/aztAMUsHios/6gavU0S4SrFpcDic+kgrLUT8Ft5bfjqbpWO1n18f4oksTmAHewCSFNz7cjys3L4vCAU97uwBcWeBibAx7OgLRUOYF3w++hakKwJf4S0tD6OUPFphZkeGYOE6i6C1/h9Qhf6bc5qpgdnqs+P92yB5n+pHG5RbYPx6FwO5/xkl35XGCHN+gyWniYS0BKkIXfx8I spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-Network-Message-Id: 9e986097-7a36-4343-dbe4-08d66d5c491e X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2018 07:07:25.4154 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0202MB3459 X-Mailman-Approved-At: Tue, 01 Jan 2019 21:47:02 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , David Airlie , "dri-devel@lists.freedesktop.org" , Rob Herring , Laurent Pinchart , Peter Rosin Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Drop #address-cells and #size-cells from the root node in the example, they are unused. Reviewed-by: Rob Herring Signed-off-by: Peter Rosin Reviewed-by: Laurent Pinchart --- Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt index fd39ad34c383..36ce07c8d8e6 100644 --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.txt @@ -38,8 +38,6 @@ Example lvds-encoder { compatible = "lvds-encoder"; - #address-cells = <1>; - #size-cells = <0>; ports { #address-cells = <1>; From patchwork Sat Dec 29 07:07:31 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Rosin X-Patchwork-Id: 10745999 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9768814E2 for ; Tue, 1 Jan 2019 21:48:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 88F6C28710 for ; Tue, 1 Jan 2019 21:48:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7D885287A6; Tue, 1 Jan 2019 21:48:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0900828710 for ; Tue, 1 Jan 2019 21:48:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 131D26E2A5; Tue, 1 Jan 2019 21:48:23 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40094.outbound.protection.outlook.com [40.107.4.94]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F7B66E091 for ; Sat, 29 Dec 2018 07:07:36 +0000 (UTC) Received: from AM0PR0202MB3267.eurprd02.prod.outlook.com (52.133.34.148) by AM0PR0202MB3459.eurprd02.prod.outlook.com (52.133.35.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1471.20; Sat, 29 Dec 2018 07:07:31 +0000 Received: from AM0PR0202MB3267.eurprd02.prod.outlook.com ([fe80::cdf9:e79c:8ad0:7422]) by AM0PR0202MB3267.eurprd02.prod.outlook.com ([fe80::cdf9:e79c:8ad0:7422%5]) with mapi id 15.20.1471.019; Sat, 29 Dec 2018 07:07:31 +0000 From: Peter Rosin To: "linux-kernel@vger.kernel.org" Subject: [PATCH v3 3/5] dt-bindings: display: bridge: thc63lvdm83d: use standard powerdown-gpios Thread-Topic: [PATCH v3 3/5] dt-bindings: display: bridge: thc63lvdm83d: use standard powerdown-gpios Thread-Index: AQHUn0Uqfa9DUMI0ckWlBr9Ht0/qGA== Date: Sat, 29 Dec 2018 07:07:31 +0000 Message-ID: <20181229070649.21308-4-peda@axentia.se> References: <20181229070649.21308-1-peda@axentia.se> In-Reply-To: <20181229070649.21308-1-peda@axentia.se> Accept-Language: en-US, sv-SE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.11.0 x-originating-ip: [85.226.244.23] x-clientproxiedby: HE1PR0502CA0002.eurprd05.prod.outlook.com (2603:10a6:3:e3::12) To AM0PR0202MB3267.eurprd02.prod.outlook.com (2603:10a6:208:5::20) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR0202MB3459; 6:0P1Ma9iktOcXcyJXnji8JDM0KMzBV9GIrTNOKGoW01tsctxpL59FBDUvaPxS12VRafjxDS5WY6LmQ591BkOduq2WysrC+Fqv0C3LeJtbZnnTrQH0Y4PdclIiZaYsZyyUvmeH/GhLQ/OLgXaOdMVj/8JwZqj0gBKj4TKVE4Cd0kl5bPht9nn1XjjFre/cCHm+RkdwfW1Kevfk5GOvp0QDRZBNh27TWqNxMcsOEwxCt0xXK5Oxr4kjbfmdTDzDHKTmjDOuRHM3r6WPBuDBIOgBWOBA2/LTz9z4s0mjZ3aEL2aGkdgjHLnpokb31JrP2zVVTk3YNOpdCLlFbZntdqpUEjn46ugLH22wdwQ69FE+qqJvd36GWVOB1wUrj9aTLeVFtjSrnGzsDuwbuaaKUh9lDNMc7kRhVS5YnHmX9BupbIyKgAsicCtfhJI9gL9E1cACJkiL8OjkKROcHIwy3gZxkQ==; 5:sGddzClNouvCdyK97rSiVbBu0IRulBIS5WLZ4qJ5c8wmQgNCDGEGShroA1ccPnpT559OM4BRbubdFqg6im1Qm7ccYAbnewYTgQjQWaaIlMuqfyHHgVdoKARyxt+mBpnQ+mOvmjqls4DtaLJyGKPpVuFA2jwFH20TBfXHqvDES58=; 7:s1EPBE3//koqgKjlq4Uceghq7JPnnT9KA1z95cJi6BtyqHkVJrF4LjjDVur+lOF3W2Gp13gx18y57vn4BQZgpWp/SgzajpMDssAWBU0QxGUyHWPOyHHGhPB+EdgYLhnoQ4zwl/c+ozQcq1Eyjd+ouA== x-ms-office365-filtering-correlation-id: 4dc5473c-bf53-4367-cabd-08d66d5c4c8b x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(7021145)(8989299)(5600109)(711020)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(2017052603328)(7153060)(7193020); SRVR:AM0PR0202MB3459; x-ms-traffictypediagnostic: AM0PR0202MB3459: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(3230021)(908002)(999002)(5005026)(6040522)(8220055)(2401047)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231475)(944501520)(52105112)(6041310)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(2016111802025)(6043046)(201708071742011)(7699051)(76991095); SRVR:AM0PR0202MB3459; BCL:0; PCL:0; RULEID:; SRVR:AM0PR0202MB3459; x-forefront-prvs: 09011458FC x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(979002)(376002)(396003)(366004)(346002)(39830400003)(136003)(189003)(199004)(71200400001)(71190400001)(66066001)(6916009)(305945005)(99286004)(8676002)(81166006)(106356001)(6116002)(6436002)(81156014)(14444005)(7736002)(2616005)(1076003)(86362001)(2906002)(6486002)(8936002)(476003)(74482002)(54906003)(3846002)(256004)(446003)(11346002)(486006)(68736007)(50226002)(186003)(5660300001)(316002)(36756003)(14454004)(6506007)(6512007)(508600001)(76176011)(2351001)(52116002)(97736004)(26005)(4326008)(5640700003)(386003)(25786009)(53936002)(102836004)(105586002)(2501003)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1102; SCL:1; SRVR:AM0PR0202MB3459; H:AM0PR0202MB3267.eurprd02.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: axentia.se does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: Hl7ipg8EJV2zG7rLTEYfHNGr79MVOVfSi41pIpLxFV89GEr1eivOFijZ/JADGmQK/u5UYAlP2tWsmusHco2FRUxHDqegnuwaqz9s6ueeeHaO5CvwKPBUuKkONYS9YC99v72ywzYlHq36JtNYzAvg0rhnYUw7giIc9oGQAl/pMh1EuM9UIChctA4rKvJQZaM9VXP1W+v1UjAgg2OmM+koJ2aS3SL/1W/0GUpB/t2KuyYwI9Td/X0vFCkmQEAJSquPrZwhOCcVz2GCYC26oWEHCw71qcfS9qlfB3dTnVLDkBJ25v+vKWx3wkY7X6SpWf3B spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-Network-Message-Id: 4dc5473c-bf53-4367-cabd-08d66d5c4c8b X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2018 07:07:31.7298 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0202MB3459 X-Mailman-Approved-At: Tue, 01 Jan 2019 21:47:02 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , David Airlie , "dri-devel@lists.freedesktop.org" , Rob Herring , Laurent Pinchart , Peter Rosin Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP The name powerdown-gpios is the standard property name for the functionality covered by the previous pwdn-gpios name. This rename should be safe to do since the linux driver supporting the binding (lvds-encoder.c) never implemented the property, and no dts file names it. At least not upstream. Signed-off-by: Peter Rosin Reviewed-by: Rob Herring Reviewed-by: Laurent Pinchart --- Documentation/devicetree/bindings/display/bridge/thine,thc63lvdm83d.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvdm83d.txt b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvdm83d.txt index 527e236e9a2a..fee3c88e1a17 100644 --- a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvdm83d.txt +++ b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvdm83d.txt @@ -10,7 +10,7 @@ Required properties: Optional properties: -- pwdn-gpios: Power down control GPIO +- powerdown-gpios: Power down control GPIO (the /PWDN pin, active low). Required nodes: From patchwork Sat Dec 29 07:07:37 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Rosin X-Patchwork-Id: 10745979 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9F427746 for ; Tue, 1 Jan 2019 21:47:21 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 91066286A7 for ; Tue, 1 Jan 2019 21:47:21 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 852B4287AB; Tue, 1 Jan 2019 21:47:21 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1A53C286A7 for ; Tue, 1 Jan 2019 21:47:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7577F6E28C; Tue, 1 Jan 2019 21:47:12 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40092.outbound.protection.outlook.com [40.107.4.92]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8FF2A6E0A6 for ; Sat, 29 Dec 2018 07:07:40 +0000 (UTC) Received: from AM0PR0202MB3267.eurprd02.prod.outlook.com (52.133.34.148) by AM0PR0202MB3459.eurprd02.prod.outlook.com (52.133.35.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1471.20; Sat, 29 Dec 2018 07:07:37 +0000 Received: from AM0PR0202MB3267.eurprd02.prod.outlook.com ([fe80::cdf9:e79c:8ad0:7422]) by AM0PR0202MB3267.eurprd02.prod.outlook.com ([fe80::cdf9:e79c:8ad0:7422%5]) with mapi id 15.20.1471.019; Sat, 29 Dec 2018 07:07:37 +0000 From: Peter Rosin To: "linux-kernel@vger.kernel.org" Subject: [PATCH v3 4/5] drm/bridge: lvds-encoder: add dev helper variable in .probe() Thread-Topic: [PATCH v3 4/5] drm/bridge: lvds-encoder: add dev helper variable in .probe() Thread-Index: AQHUn0UtgZZip4D7Y0+gDT/zYJbnWw== Date: Sat, 29 Dec 2018 07:07:37 +0000 Message-ID: <20181229070649.21308-5-peda@axentia.se> References: <20181229070649.21308-1-peda@axentia.se> In-Reply-To: <20181229070649.21308-1-peda@axentia.se> Accept-Language: en-US, sv-SE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.11.0 x-originating-ip: [85.226.244.23] x-clientproxiedby: HE1PR0502CA0002.eurprd05.prod.outlook.com (2603:10a6:3:e3::12) To AM0PR0202MB3267.eurprd02.prod.outlook.com (2603:10a6:208:5::20) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR0202MB3459; 6:CADVE5MvwxUF8NS1560jT3gRBGoNfUBak1IShl81Uip2/LRk6EecyHRQ6DxTZsaKUPUHdeVuamYgHIvFwDjtr+IEy4Rlui9zyJP+YyIKL6S7Pp9SxxHh6GMGqYqad2ZG2Iex7gwvcUfPC/6UMMsvzkYiLYF3FCWtcTXYxrCfNuYbbykH8emXlIir1WPXO838v4TFLHAWjBEXFRgs3vk0wS3EcbN4HBSm90VBL5oIwruUuWuCdcZE5lRQIC8tI2lL0MgqfWSLHBpq8BpbwPCW5R4iw8HHG8NBen5odJ4Uo/MlpGMWQgoy9Po8jBlfUzMGRZ2hbSKGX3j3lVSAv31/rFVasg/3o+OeNfRwntLwjolmMFaudWDHtCPlfPvkJ8GqQCGDmcQNh0pFCAedYK1SO7A/GQC+i3hZxnODrHx7DtazBBgoUNg3bBj76SfZ72oS3M/IpdqxFA1oC4B+tNzshg==; 5:+mudUt6wyPi8820lxQwbmu+/OMG2aOuuKMmVPJBz2wdsursr0eAmVvpCtN4ehMcU25BYpuXydbt0XvR0IyLGTk4V9qYWfBQFbwLB28j+M7EOVAfmNy5xx6+JDGxs4dmhgT5PpurDvK0Ry+ByXodAkhoADcaP50b27090iXEbHZw=; 7:h2xBzv8Y656PkZQf8nYSOmcTpUCURT8gGtSu/KRP1GdAToG5f2jP+g73EZMN2d8l9XigW7p63gh4Hyog3zL9bi950kcSgHWSm48UtrSDQncPIAqxOFuf6gPRlgfsfVGzO0Rsfei1+YCdQy0sbzSSYw== x-ms-office365-filtering-correlation-id: c420e574-c896-4e11-d79e-08d66d5c503a x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(7021145)(8989299)(5600109)(711020)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(2017052603328)(7153060)(7193020); SRVR:AM0PR0202MB3459; x-ms-traffictypediagnostic: AM0PR0202MB3459: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(3230021)(908002)(999002)(5005026)(6040522)(8220055)(2401047)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231475)(944501520)(52105112)(6041310)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(2016111802025)(6043046)(201708071742011)(7699051)(76991095); SRVR:AM0PR0202MB3459; BCL:0; PCL:0; RULEID:; SRVR:AM0PR0202MB3459; x-forefront-prvs: 09011458FC x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(396003)(366004)(346002)(39830400003)(136003)(189003)(199004)(71200400001)(71190400001)(66066001)(6916009)(5024004)(305945005)(99286004)(8676002)(81166006)(106356001)(6116002)(6436002)(81156014)(7736002)(2616005)(1076003)(86362001)(575784001)(2906002)(6486002)(8936002)(476003)(74482002)(54906003)(3846002)(256004)(446003)(11346002)(486006)(68736007)(50226002)(186003)(5660300001)(316002)(36756003)(14454004)(6506007)(6512007)(508600001)(76176011)(2351001)(52116002)(97736004)(26005)(4326008)(5640700003)(386003)(25786009)(53936002)(102836004)(105586002)(2501003)(142923001); DIR:OUT; SFP:1102; SCL:1; SRVR:AM0PR0202MB3459; H:AM0PR0202MB3267.eurprd02.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: axentia.se does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: ezQzJYeJEX44jZcxTit++2WidcgfkmBM7jmNqTgncC5nVSv1PlBSi4Th5yhimeel+GzsbESVdlhEZhL50tgLTS65HanQ0jtGwikpEmjOl3ThI4ZR76wBhyfMRKhZeuU5vkDBCkdEcOI11FjF+PVlr9X75VRrg5RHWuxDpBycnXHVCRrrwjDTIX9ObnpM6CnfvFXPcjqQwat1Vdy+AfNWurpuHXCAVWAGDCzeqBzhNiB0nZIvxHRhLqmN3lzM+WUIg3gKNEOX8f4oS4uiJJZgV7fzob1+2qOH/MY8IdLBtuQcUMJ7MPMp5YH6f2vpEx2z spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-Network-Message-Id: c420e574-c896-4e11-d79e-08d66d5c503a X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2018 07:07:37.3278 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0202MB3459 X-Mailman-Approved-At: Tue, 01 Jan 2019 21:47:02 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , David Airlie , "dri-devel@lists.freedesktop.org" , Rob Herring , Laurent Pinchart , Peter Rosin Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Make the code easier to read and modify. Signed-off-by: Peter Rosin Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/bridge/lvds-encoder.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/lvds-encoder.c b/drivers/gpu/drm/bridge/lvds-encoder.c index 75b0d3f6e4de..f6770e83d49d 100644 --- a/drivers/gpu/drm/bridge/lvds-encoder.c +++ b/drivers/gpu/drm/bridge/lvds-encoder.c @@ -34,48 +34,47 @@ static struct drm_bridge_funcs funcs = { static int lvds_encoder_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; struct device_node *port; struct device_node *endpoint; struct device_node *panel_node; struct drm_panel *panel; struct lvds_encoder *lvds_encoder; - lvds_encoder = devm_kzalloc(&pdev->dev, sizeof(*lvds_encoder), - GFP_KERNEL); + lvds_encoder = devm_kzalloc(dev, sizeof(*lvds_encoder), GFP_KERNEL); if (!lvds_encoder) return -ENOMEM; /* Locate the panel DT node. */ - port = of_graph_get_port_by_id(pdev->dev.of_node, 1); + port = of_graph_get_port_by_id(dev->of_node, 1); if (!port) { - dev_dbg(&pdev->dev, "port 1 not found\n"); + dev_dbg(dev, "port 1 not found\n"); return -ENXIO; } endpoint = of_get_child_by_name(port, "endpoint"); of_node_put(port); if (!endpoint) { - dev_dbg(&pdev->dev, "no endpoint for port 1\n"); + dev_dbg(dev, "no endpoint for port 1\n"); return -ENXIO; } panel_node = of_graph_get_remote_port_parent(endpoint); of_node_put(endpoint); if (!panel_node) { - dev_dbg(&pdev->dev, "no remote endpoint for port 1\n"); + dev_dbg(dev, "no remote endpoint for port 1\n"); return -ENXIO; } panel = of_drm_find_panel(panel_node); of_node_put(panel_node); if (!panel) { - dev_dbg(&pdev->dev, "panel not found, deferring probe\n"); + dev_dbg(dev, "panel not found, deferring probe\n"); return -EPROBE_DEFER; } lvds_encoder->panel_bridge = - devm_drm_panel_bridge_add(&pdev->dev, - panel, DRM_MODE_CONNECTOR_LVDS); + devm_drm_panel_bridge_add(dev, panel, DRM_MODE_CONNECTOR_LVDS); if (IS_ERR(lvds_encoder->panel_bridge)) return PTR_ERR(lvds_encoder->panel_bridge); @@ -83,7 +82,7 @@ static int lvds_encoder_probe(struct platform_device *pdev) * but we need a bridge attached to our of_node for our user * to look up. */ - lvds_encoder->bridge.of_node = pdev->dev.of_node; + lvds_encoder->bridge.of_node = dev->of_node; lvds_encoder->bridge.funcs = &funcs; drm_bridge_add(&lvds_encoder->bridge); From patchwork Sat Dec 29 07:07:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Rosin X-Patchwork-Id: 10745981 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id ED1C714E2 for ; Tue, 1 Jan 2019 21:47:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DF966286A7 for ; Tue, 1 Jan 2019 21:47:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D3FB1287AB; Tue, 1 Jan 2019 21:47:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8A9D5286A7 for ; Tue, 1 Jan 2019 21:47:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 156D66E28E; Tue, 1 Jan 2019 21:47:13 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-eopbgr150137.outbound.protection.outlook.com [40.107.15.137]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7F2986E2A6 for ; Sat, 29 Dec 2018 07:07:47 +0000 (UTC) Received: from AM0PR0202MB3267.eurprd02.prod.outlook.com (52.133.34.148) by AM0PR0202MB3459.eurprd02.prod.outlook.com (52.133.35.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1471.20; Sat, 29 Dec 2018 07:07:45 +0000 Received: from AM0PR0202MB3267.eurprd02.prod.outlook.com ([fe80::cdf9:e79c:8ad0:7422]) by AM0PR0202MB3267.eurprd02.prod.outlook.com ([fe80::cdf9:e79c:8ad0:7422%5]) with mapi id 15.20.1471.019; Sat, 29 Dec 2018 07:07:44 +0000 From: Peter Rosin To: "linux-kernel@vger.kernel.org" Subject: [PATCH v3 5/5] drm/bridge: lvds-encoder: add powerdown-gpios support Thread-Topic: [PATCH v3 5/5] drm/bridge: lvds-encoder: add powerdown-gpios support Thread-Index: AQHUn0UxSwSuD12DD0+0q+RswKrSuQ== Date: Sat, 29 Dec 2018 07:07:43 +0000 Message-ID: <20181229070649.21308-6-peda@axentia.se> References: <20181229070649.21308-1-peda@axentia.se> In-Reply-To: <20181229070649.21308-1-peda@axentia.se> Accept-Language: en-US, sv-SE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.11.0 x-originating-ip: [85.226.244.23] x-clientproxiedby: HE1PR0502CA0002.eurprd05.prod.outlook.com (2603:10a6:3:e3::12) To AM0PR0202MB3267.eurprd02.prod.outlook.com (2603:10a6:208:5::20) x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; AM0PR0202MB3459; 6:BKBBY6XX52zs+9T4KDHYrnleUq179pgYsqqIn0ud9BUvkrOYWWca0uA0LocTOteVZ0z4WWODKqBlkTCTYScADx6GiInuB7XAVjIsK45dd5YTtg29D5Wvw2r9Mw5CcY0r3uZzycy4C3h9fXmM32jvjO7GKGHht/jD9p9+clPT1iHI/0Ku6vPCLM9o2izVPsRIs+9sA6dEwRgrjzJS3/W7PLFMPbjcalC+ZIwkybdPt0vSRtqYUF1f8M7QNOtigz/7Xup+xJ3CzWOVIj0moiPaDfKwmJzWC8LBuV9B6Ceeu4z++fW0yEXJrNai0McfzcrWgzeKfD9KNhewSJZTf+IPmVepUXeUu15LLUo8ap/3yOzcKsY1c5yXk8N+f03KyjCld0O+L0CwUGp67J4AeXPThnKYdwWgaWXW2oKranODhLrt2XgqKQv1KsBDrOtoJz2mCSqMjUETdqeRyzX/RSbTxw==; 5:Pr90yGa1JDAdFONxZovoZQyh4LeLYnHUcpCttqEZaGCg5rk8Tcbldj48ffKuazajlnmV3K5zKzXNGy4k/a+e4Xpl9zLOSWj+a7FwgzKwFEdU8TkJrMf2wBANrKQ6XkP4JwKcpNRPg4mFNOqZLjNDIEj318KCGNJ7hRfyU4DZvI0=; 7:IWbTaNjfXdmx6MW5qgyarrfpvmyTkT4dFvwIUY5zqMutQr1eaM0GQT/mPyEOLHX/RpVeAQWYqtm1XZ2VwaPRuoV8Vmh1TxIspDXtPFIUvkP6iGf4wDGQkijBnkE4j8I/tJ+qP6zBBKLcCeuzeaotKw== x-ms-office365-filtering-correlation-id: 67490965-1af6-4c23-1ec0-08d66d5c537a x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(7021145)(8989299)(5600109)(711020)(4534185)(7022145)(4603075)(4627221)(201702281549075)(8990200)(7048125)(7024125)(7027125)(7023125)(2017052603328)(7153060)(7193020); SRVR:AM0PR0202MB3459; x-ms-traffictypediagnostic: AM0PR0202MB3459: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(3230021)(908002)(999002)(5005026)(6040522)(8220055)(2401047)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231475)(944501520)(52105112)(6041310)(20161123564045)(20161123560045)(20161123558120)(20161123562045)(2016111802025)(6043046)(201708071742011)(7699051)(76991095); SRVR:AM0PR0202MB3459; BCL:0; PCL:0; RULEID:; SRVR:AM0PR0202MB3459; x-forefront-prvs: 09011458FC x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(376002)(396003)(366004)(346002)(39830400003)(136003)(189003)(199004)(71200400001)(71190400001)(66066001)(6916009)(5024004)(305945005)(99286004)(8676002)(81166006)(106356001)(6116002)(6436002)(81156014)(14444005)(7736002)(2616005)(1076003)(86362001)(2906002)(6486002)(8936002)(476003)(74482002)(54906003)(3846002)(256004)(446003)(11346002)(486006)(68736007)(50226002)(186003)(5660300001)(316002)(36756003)(14454004)(6506007)(6512007)(508600001)(76176011)(2351001)(52116002)(97736004)(26005)(4326008)(5640700003)(386003)(25786009)(53936002)(102836004)(105586002)(2501003); DIR:OUT; SFP:1102; SCL:1; SRVR:AM0PR0202MB3459; H:AM0PR0202MB3267.eurprd02.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: axentia.se does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: B4UrawAijtjhW34RsdYmJeJ4TER7e5O9MPeZcfAwgGbLctjj5dgDMVceOvxXIKQOKAnlBYTVYPaR7je0MCUKkeIhKIAFRv8fZNQ49BvABeWbUKvFKTwOMJV6Csp7nKxx/4YT3+D7CiTjbJclFuqBAMDV4XF2eXJSha8zW8WYVgHFznSGKQ18wkCe/gy/Mb4pqLjXrMpnGea8owu6H1PJyYtVIIMOtLmgm+frin34Bfd7t8TS47M8Rw8erHjqHp/Czw7tsYRakrNkIVWQFGDEg1kq1NyP6OWKV1t6xNFXQwwEuot+oGaP2zRtI7/bvbEY spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-Network-Message-Id: 67490965-1af6-4c23-1ec0-08d66d5c537a X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Dec 2018 07:07:44.6550 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR0202MB3459 X-Mailman-Approved-At: Tue, 01 Jan 2019 21:47:02 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , David Airlie , "dri-devel@lists.freedesktop.org" , Rob Herring , Laurent Pinchart , Peter Rosin Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Optionally power down the LVDS-encoder when it is not in use. Signed-off-by: Peter Rosin Reviewed-by: Laurent Pinchart --- drivers/gpu/drm/bridge/lvds-encoder.c | 34 ++++++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) diff --git a/drivers/gpu/drm/bridge/lvds-encoder.c b/drivers/gpu/drm/bridge/lvds-encoder.c index f6770e83d49d..36d8557bc097 100644 --- a/drivers/gpu/drm/bridge/lvds-encoder.c +++ b/drivers/gpu/drm/bridge/lvds-encoder.c @@ -11,11 +11,13 @@ #include #include +#include #include struct lvds_encoder { struct drm_bridge bridge; struct drm_bridge *panel_bridge; + struct gpio_desc *powerdown_gpio; }; static int lvds_encoder_attach(struct drm_bridge *bridge) @@ -28,8 +30,30 @@ static int lvds_encoder_attach(struct drm_bridge *bridge) bridge); } +static void lvds_encoder_enable(struct drm_bridge *bridge) +{ + struct lvds_encoder *lvds_encoder = container_of(bridge, + struct lvds_encoder, + bridge); + + if (lvds_encoder->powerdown_gpio) + gpiod_set_value_cansleep(lvds_encoder->powerdown_gpio, 0); +} + +static void lvds_encoder_disable(struct drm_bridge *bridge) +{ + struct lvds_encoder *lvds_encoder = container_of(bridge, + struct lvds_encoder, + bridge); + + if (lvds_encoder->powerdown_gpio) + gpiod_set_value_cansleep(lvds_encoder->powerdown_gpio, 1); +} + static struct drm_bridge_funcs funcs = { .attach = lvds_encoder_attach, + .enable = lvds_encoder_enable, + .disable = lvds_encoder_disable, }; static int lvds_encoder_probe(struct platform_device *pdev) @@ -45,6 +69,16 @@ static int lvds_encoder_probe(struct platform_device *pdev) if (!lvds_encoder) return -ENOMEM; + lvds_encoder->powerdown_gpio = devm_gpiod_get_optional(dev, "powerdown", + GPIOD_OUT_HIGH); + if (IS_ERR(lvds_encoder->powerdown_gpio)) { + int err = PTR_ERR(lvds_encoder->powerdown_gpio); + + if (err != -EPROBE_DEFER) + dev_err(dev, "powerdown GPIO failure: %d\n", err); + return err; + } + /* Locate the panel DT node. */ port = of_graph_get_port_by_id(dev->of_node, 1); if (!port) {