From patchwork Sun Feb 20 17:51:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 12752794 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7056AC433F5 for ; Sun, 20 Feb 2022 17:45:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238544AbiBTRp1 (ORCPT ); Sun, 20 Feb 2022 12:45:27 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:43532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233734AbiBTRp0 (ORCPT ); Sun, 20 Feb 2022 12:45:26 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D7874C43A for ; Sun, 20 Feb 2022 09:45:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1856060B87 for ; Sun, 20 Feb 2022 17:45:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CA856C340EB; Sun, 20 Feb 2022 17:45:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645379104; bh=OEWu8NT4+40KGN8kvAutLAcYmnhevGWaxdTDvNwf9U8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B4bWrSsmK6TUWZpVBtpJBTQp8KFgVg949wPNXobphgTg0UefkIJ9NNF7QNSVBFDUf 8plf77Zdx+rGcsPl94iwrV/LcrdxGdLHzgdPfohzy7UAXx8+V9D/PoUBqbTOAtVGKj 7W6KnOozLIdhGylrFIhA0dB/KQJZkdKXwBN/Z7GKNe98bBhmzQgZ6mM5ogaS3GgOtk QFKjEE60tEPit2n7QO0Mz2h8ZcYBdSdnXI08LR3m7Q5ZDiycdOeNpPkQS98XR/0RRn SZhTwpZYyzRJ7a6G26qD9NqRe3GH3E87tJfGRNehm9YtqXJBny+A457tLzmKa1mzrY tCczMjBAuouUw== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Paul Cercueil , Linus Walleij , Jonathan Cameron Subject: [PATCH 1/2] iio: gyro: mpu3050: Drop unused symbol exports. Date: Sun, 20 Feb 2022 17:51:48 +0000 Message-Id: <20220220175149.503495-2-jic23@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220220175149.503495-1-jic23@kernel.org> References: <20220220175149.503495-1-jic23@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org From: Jonathan Cameron This driver is built as a single module. There is an note in the makefile about SPI support being a reason to split the build in future. That support has never arrived so drop these symbol exports. Signed-off-by: Jonathan Cameron Cc: Linus Walleij Reviewed-by: Linus Walleij --- drivers/iio/gyro/mpu3050-core.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-core.c index ea387efab62d..8486261beb90 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -1261,7 +1261,6 @@ int mpu3050_common_probe(struct device *dev, return ret; } -EXPORT_SYMBOL(mpu3050_common_probe); int mpu3050_common_remove(struct device *dev) { @@ -1279,7 +1278,6 @@ int mpu3050_common_remove(struct device *dev) return 0; } -EXPORT_SYMBOL(mpu3050_common_remove); #ifdef CONFIG_PM static int mpu3050_runtime_suspend(struct device *dev) @@ -1299,7 +1297,6 @@ const struct dev_pm_ops mpu3050_dev_pm_ops = { SET_RUNTIME_PM_OPS(mpu3050_runtime_suspend, mpu3050_runtime_resume, NULL) }; -EXPORT_SYMBOL(mpu3050_dev_pm_ops); MODULE_AUTHOR("Linus Walleij"); MODULE_DESCRIPTION("MPU3050 gyroscope driver"); From patchwork Sun Feb 20 17:51:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 12752795 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B53A7C433EF for ; Sun, 20 Feb 2022 17:45:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238944AbiBTRp3 (ORCPT ); Sun, 20 Feb 2022 12:45:29 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:43546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233734AbiBTRp3 (ORCPT ); Sun, 20 Feb 2022 12:45:29 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CEFE4C43A for ; Sun, 20 Feb 2022 09:45:08 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A97D660E8F for ; Sun, 20 Feb 2022 17:45:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D0CBC340E8; Sun, 20 Feb 2022 17:45:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645379107; bh=0Wp4B5Wu8d5FljfumTcxNwSuo35Diwmq4YC69Zdcyqc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=dWmD0JDruaOTLPanfekzp5wsNm9/DA7udeb4XoQNcmo8R1OVyfvZCUpDghR5gRddF Ej6lTD53qxfgns67rk8r4pZqldY08qjwrYlFJ42x9JT5M/pS6k0//5Bc0yruuWJe/F JUxN3leoebM2sFLuO8G3eBNCqgLJBibJa/MiAU46xx8ScZVkOikCpb4hVnrc+qRxuy K/7od0uB2gG9mEfuVPffaAWvjkRo3wqnld5pxna0jDqv5WnyX5wzbYMqDTpPmtPiTs xI65eQO99079Iif+CbZX132HpiOcbT2vTLqM2oPxrJKu0fI+Y+GQfZyZyiRihsOR8q k3KSK2lVWU4ew== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Paul Cercueil , Linus Walleij , Jonathan Cameron Subject: [PATCH 2/2] iio: gyro: mpu3050: Use pm_ptr() and DEFINE_RUNTIME_DEV_PM_OPS() Date: Sun, 20 Feb 2022 17:51:49 +0000 Message-Id: <20220220175149.503495-3-jic23@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220220175149.503495-1-jic23@kernel.org> References: <20220220175149.503495-1-jic23@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org From: Jonathan Cameron Using this approach as opposed to CONFIG_PM guards allows the compiler to remove the unused code instead of doing it manually. Signed-off-by: Jonathan Cameron Cc: Linus Walleij Reviewed-by: Linus Walleij --- drivers/iio/gyro/mpu3050-core.c | 11 ++--------- drivers/iio/gyro/mpu3050-i2c.c | 2 +- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/iio/gyro/mpu3050-core.c b/drivers/iio/gyro/mpu3050-core.c index 8486261beb90..b3ecb5571057 100644 --- a/drivers/iio/gyro/mpu3050-core.c +++ b/drivers/iio/gyro/mpu3050-core.c @@ -1279,7 +1279,6 @@ int mpu3050_common_remove(struct device *dev) return 0; } -#ifdef CONFIG_PM static int mpu3050_runtime_suspend(struct device *dev) { return mpu3050_power_down(iio_priv(dev_get_drvdata(dev))); @@ -1289,15 +1288,9 @@ static int mpu3050_runtime_resume(struct device *dev) { return mpu3050_power_up(iio_priv(dev_get_drvdata(dev))); } -#endif /* CONFIG_PM */ - -const struct dev_pm_ops mpu3050_dev_pm_ops = { - SET_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend, - pm_runtime_force_resume) - SET_RUNTIME_PM_OPS(mpu3050_runtime_suspend, - mpu3050_runtime_resume, NULL) -}; +DEFINE_RUNTIME_DEV_PM_OPS(mpu3050_dev_pm_ops, mpu3050_runtime_suspend, + mpu3050_runtime_resume, NULL); MODULE_AUTHOR("Linus Walleij"); MODULE_DESCRIPTION("MPU3050 gyroscope driver"); MODULE_LICENSE("GPL"); diff --git a/drivers/iio/gyro/mpu3050-i2c.c b/drivers/iio/gyro/mpu3050-i2c.c index ef5bcbc4b45b..820133cad601 100644 --- a/drivers/iio/gyro/mpu3050-i2c.c +++ b/drivers/iio/gyro/mpu3050-i2c.c @@ -114,7 +114,7 @@ static struct i2c_driver mpu3050_i2c_driver = { .driver = { .of_match_table = mpu3050_i2c_of_match, .name = "mpu3050-i2c", - .pm = &mpu3050_dev_pm_ops, + .pm = pm_ptr(&mpu3050_dev_pm_ops), }, }; module_i2c_driver(mpu3050_i2c_driver);