From patchwork Thu Jan 3 00:21:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Matthew Wilcox X-Patchwork-Id: 10746787 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8A7C96C2 for ; Thu, 3 Jan 2019 00:21:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 79CD4281D2 for ; Thu, 3 Jan 2019 00:21:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6CB4E283C8; Thu, 3 Jan 2019 00:21:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 23580281D2 for ; Thu, 3 Jan 2019 00:21:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4DFA8E004F; Wed, 2 Jan 2019 19:21:31 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id CD3B38E0002; Wed, 2 Jan 2019 19:21:31 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B73E98E004F; Wed, 2 Jan 2019 19:21:31 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by kanga.kvack.org (Postfix) with ESMTP id 7384C8E0002 for ; Wed, 2 Jan 2019 19:21:31 -0500 (EST) Received: by mail-pf1-f198.google.com with SMTP id t2so33795703pfj.15 for ; Wed, 02 Jan 2019 16:21:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:date:from:to:cc:subject :message-id:mime-version:content-disposition:user-agent; bh=OQOpxZv95FP2XBOu61CyGnmRm4Xc+rHoB1dn4/6ZEI8=; b=DiyJ13eUt4vBV8uN/Zwl+pfxPsYGI5eVZEyGPv71X/kR7/d13l7px1malgo23Xjm2B 5cuf3D9KUrHHwEwNwdgWKbQTVxUhR1Y9gZRdxwF/V1rhzEGUIExWX9PA1C+pN/yMK9XZ clXRFBVmGdBbbCml8SCl1A0DMLXiPtnkbYQ7sqKzb5INC4CkAX8B4Higo7YKodAMwFbo NXI69oOj1Jr05HkZmmQcaBVmVNQYKbfA0EKvx5hb5K3GvB32L4Wcks1kpcclOkWXqDIc 18hLid9xCAehpkuDQCGnxTgSw0n+cge0iqhLDIASjEHWOo7w4wI4HovxTrB2KIdrO4Me M4pw== X-Gm-Message-State: AJcUukeKtN3cCafdhO5EtD18mqeDucAL5xYt/dudid5o2frmofcDB0GR e6EyZjV+8BdgnirbzywfDW7GYqWmsvlqFG0nVtA0X3wSteZ6cpdNakUWu4TwT+GThTr1cahrB0I X78HcWXA2L5tBD+knQ83vVEUalRsAKk9Q+Oc70bF2g85eQUCdg6nVLXSiLCX+r+m6nA== X-Received: by 2002:a63:5346:: with SMTP id t6mr15512350pgl.40.1546474890988; Wed, 02 Jan 2019 16:21:30 -0800 (PST) X-Google-Smtp-Source: ALg8bN5mgvAR3tWqDUrccA6kJsi13SBuwkiOi5GSYJnrpzjhSguvZzJ7LwgFqpMtmKmukGuhwF8J X-Received: by 2002:a63:5346:: with SMTP id t6mr15512316pgl.40.1546474890235; Wed, 02 Jan 2019 16:21:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546474890; cv=none; d=google.com; s=arc-20160816; b=mBugmFYRIBa6OsEDelvvZ46zlgrJStfSVLWqiwLgeBS7KNqV49+5X82hS+Wc9oBJRv hI4rrayQ5itVS9na3cbWjF2nOPoBZe+zhLCMeMIx3aeHfNqLh3QLvQczSgCHUK6MshGm wufpMfKCOQPKXjFkLrUnclM1icZEgPCHeWe7/MyuAWhnDp1K8wd8+NiXHxluMSEmXO3J hzvJld8dsjboRCoWRhWCsI4Y68raepvEG5EHaDpUPtv/hPJ05CrtCmRnhpd7xfAnfmbd oQhlN+BPOnCTgqlAee8zsGSF8vuK5ib3p9/PhyxOafV8VNpsG8jZRSUL3AXnb+l/fp/B PknA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:dkim-signature; bh=OQOpxZv95FP2XBOu61CyGnmRm4Xc+rHoB1dn4/6ZEI8=; b=0Xhj1omaxE0PrOfH6wbulCRmT06OrqWp26Tn6cVkqwgt0x9Xutlq64fHk2dCc2XuoG KxFigtfNaK1KrkWRi2vQhiZeTvhxppqiznSiEpUKxwJaVKrR5Eg8gP7ufqCwXIYNrK3R TgYuW8BXgwuL71yhATEWuSkQnOpzuRqmKNMXZmTZQdjqoNYNWS0oY85t2mtmiSsgF3GC ZTIZMOxnfYKzbH0UWOVnPufChzoZUNvtWnGIp96zUCV1JtvDljiT+5PXBirKsc0oQpFX 7teVpFMbtmIq048xaTo4KFPLQNBUkQUy4QCI7fUVifYCVpTUC2JBZ0zWcbqRVxqQBeNx AHOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=OMqhhboM; spf=pass (google.com: best guess record for domain of willy@infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom=willy@infradead.org Received: from bombadil.infradead.org (bombadil.infradead.org. [2607:7c80:54:e::133]) by mx.google.com with ESMTPS id a26si32262049pgl.282.2019.01.02.16.21.29 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 02 Jan 2019 16:21:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of willy@infradead.org designates 2607:7c80:54:e::133 as permitted sender) client-ip=2607:7c80:54:e::133; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20170209 header.b=OMqhhboM; spf=pass (google.com: best guess record for domain of willy@infradead.org designates 2607:7c80:54:e::133 as permitted sender) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Type:MIME-Version:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OQOpxZv95FP2XBOu61CyGnmRm4Xc+rHoB1dn4/6ZEI8=; b=OMqhhboM/P06ByKNvuIKuLIVND d1+GPBi17b3OquyFB7EWJYUpBjNu6APWsEl4/C3wqr+i41knmwuPdrkOr1/RDMqx983GYn19L6VBi sQPD3D1bWwInHA3todiDvqjDtBcRmcmTwRoAx5a9UA5aKHTA6Fcb/ckvz+xcOcyNJcRYRS2IamrTu 3uFJUZujpgHoKfBscNHtlSTegac1Qq6E4Sf1vvsMeZMe45221KqKEOeWPbLNlSNxgxNqmNwEbHcEw eHPCsXP60PidkM9UFBBSaqCesex7Gzn9nVcS1x0mUxviGLxTGEUn4mEwDCwWko8uZoAoE1WPnI/MW T5jcQCDQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1geqlL-0000n5-3N; Thu, 03 Jan 2019 00:21:27 +0000 Date: Wed, 2 Jan 2019 16:21:26 -0800 From: Matthew Wilcox To: Andrew Morton Cc: linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org, Christian =?iso-8859-1?q?K=F6nig?= , Jan Kara , =?iso-8859-1?q?J=E9r=F4me?= Glisse Subject: [PATCH] Initialise mmu_notifier_range correctly Message-ID: <20190103002126.GM6310@bombadil.infradead.org> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.9.2 (2017-12-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP One of the paths in follow_pte_pmd() initialised the mmu_notifier_range incorrectly. Signed-off-by: Matthew Wilcox Fixes: ac46d4f3c432 ("mm/mmu_notifier: use structure for invalidate_range_start/end calls v2") Tested-by: Dave Chinner Reviewed-by: Jérôme Glisse diff --git a/mm/memory.c b/mm/memory.c index 2dd2f9ab57f4..21a650368be0 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -4078,8 +4078,8 @@ static int __follow_pte_pmd(struct mm_struct *mm, unsigned long address, goto out; if (range) { - range->start = address & PAGE_MASK; - range->end = range->start + PAGE_SIZE; + mmu_notifier_range_init(range, mm, address & PAGE_MASK, + (address & PAGE_MASK) + PAGE_SIZE); mmu_notifier_invalidate_range_start(range); } ptep = pte_offset_map_lock(mm, pmd, address, ptlp);