From patchwork Thu Feb 24 19:15:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Magali Lemes X-Patchwork-Id: 12759153 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48D91C433FE for ; Thu, 24 Feb 2022 19:16:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7FB7E10E877; Thu, 24 Feb 2022 19:16:26 +0000 (UTC) Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by gabe.freedesktop.org (Postfix) with ESMTPS id 301D910E877; Thu, 24 Feb 2022 19:16:25 +0000 (UTC) Received: by mail-ot1-x334.google.com with SMTP id l25-20020a9d7a99000000b005af173a2875so2017429otn.2; Thu, 24 Feb 2022 11:16:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TLiWpOnxapYAVvT4QJds8jwsCUqpq+N+eb8iJ1oxqPc=; b=FoSBsHzIox96KnpJAyliB1ZiuIjpzEzM4XYDkOlGoqloV5Eo7EZVSPu2ErTj4vLJMi upYaLfSb0X91GX+xn6TnAobrbP6ERdOB5KlZcpaoe7UbiAWgiKPgTlQEtKxHSzdLcHMS lOjpOydbBexU4vm5IkOYAkImwvyLuVtkbedyi2e7M1I2TfUrXXZR7/AB5zitxIeKy/IC x1F5Q91iYENsXt8Yd24tfJgrSbsl/BS2PPenavqRHuQd9YmcfFKmky7rirOq5DXnIC0b XSj6nBARIPzqtJUo0WYZfR72ddf+6yWvaL9fNzHTsevpQcAYyyylt8lzDJ2QWRku7DVr pJNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TLiWpOnxapYAVvT4QJds8jwsCUqpq+N+eb8iJ1oxqPc=; b=3ozsQJEb6Gdm8FPY6nTs086oiYpmK4mRCiaDcYHkwTEs6i3aj4773DanyMHVGuH/GX IK2HDgctwuhPexdK3H2jqqcMYeWqgMwNaUx03YdViVEKE6QDBa7e/CLz3nEYkEKmKRM7 9FB43p0aQlB8z3gG20qucQ3sfll8lHWjvGyK1bgkfyIqs6Bikz47W57XSf7OCSNEdf09 smji0Yz7mMXzRiZ3GLpI1SMc/mq5DnGsNvYB9BOccmku4aURJMm4ogqVCzSSPhSoiNBV mrfOv7/hQ+N7rX0TJr8X1abF8IbMKU2avOz90+7VX5NAyn4vspfohWag0hS6ODvpdVEN ulIA== X-Gm-Message-State: AOAM5307rx7fX9HyPuCPg7NBaC2iFr4o84VRMb2ofS9xDCYU76jKMu94 4y0fArGAH6pIsvnHx4VKdlY= X-Google-Smtp-Source: ABdhPJzBXhUKmpv0W6RRc6cmrcAkgPuFrtLmZVXDFelgeLtmLNAIwubxdHBKS6Tl11+U/IW4kchtiQ== X-Received: by 2002:a9d:6e09:0:b0:5ad:1fcd:bfd0 with SMTP id e9-20020a9d6e09000000b005ad1fcdbfd0mr1532004otr.312.1645730183457; Thu, 24 Feb 2022 11:16:23 -0800 (PST) Received: from localhost.localdomain (189-47-54-110.dsl.telesp.net.br. [189.47.54.110]) by smtp.gmail.com with ESMTPSA id w3-20020a056830110300b005af14392276sm79509otq.62.2022.02.24.11.16.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Feb 2022 11:16:23 -0800 (PST) From: Magali Lemes To: harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch Subject: [PATCH 1/4] drm/amd/display: Adjust functions documentation Date: Thu, 24 Feb 2022 16:15:48 -0300 Message-Id: <20220224191551.69103-2-magalilemes00@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220224191551.69103-1-magalilemes00@gmail.com> References: <20220224191551.69103-1-magalilemes00@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel test robot , siqueirajordao@riseup.net, Magali Lemes , maira.canal@usp.br, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, mwen@igalia.com, dri-devel@lists.freedesktop.org, isabbasso@riseup.net Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Part of the documentation of the 'dc_process_dmub_aux_transfer_async' function was misplaced, being put together with the ‘dc_enable_dmub_notifications’ documentation. This caused the following warning: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:3757: warning: expecting prototype for dc_process_dmub_aux_transfer_async(). Prototype was for dc_enable_dmub_notifications() instead This commit fixes the warning by placing the function documentations in their right place. Reported-by: kernel test robot Signed-off-by: Magali Lemes --- drivers/gpu/drm/amd/display/dc/core/dc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index b1ce3c0cf477..61e3bb99375f 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c @@ -3737,8 +3737,8 @@ bool dc_is_dmub_outbox_supported(struct dc *dc) return dc->debug.enable_dmub_aux_for_legacy_ddc; } -/** - * dc_process_dmub_aux_transfer_async - Submits aux command to dmub via inbox message +/* + ***************************************************************************** * Function: dc_enable_dmub_notifications * * @brief @@ -3780,7 +3780,7 @@ void dc_enable_dmub_outbox(struct dc *dc) } /** - ***************************************************************************** + * dc_process_dmub_aux_transfer_async - Submits aux command to dmub via inbox message * Sets port index appropriately for legacy DDC * @dc: dc structure * @link_index: link index From patchwork Thu Feb 24 19:15:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Magali Lemes X-Patchwork-Id: 12759154 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D632FC433F5 for ; Thu, 24 Feb 2022 19:16:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EFE8F10E8A1; Thu, 24 Feb 2022 19:16:32 +0000 (UTC) Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7F40310E8A1; Thu, 24 Feb 2022 19:16:31 +0000 (UTC) Received: by mail-oi1-x22f.google.com with SMTP id 12so4311867oix.12; Thu, 24 Feb 2022 11:16:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=89DjEEGsLwYVVyD3+lmgDuUkvgmk0sfi5HizC/FoSH4=; b=nLE4O+3a20KBgtMfBCmxPYKi2/yST1qDItJARMiJsPchNEAXZvAamWBMyYOiminHO0 f+ViAwcqCo4QglNR7wsM980DfeBcDWIeXP0DYzmx/DqMcfWrtZ0qz7I2c6TyfMpnqz5e IIrErJME1K4nHTD3xFi2OsblyMCLWHZZg2NowBgylgzBMhK5gmry6+qQriY1+WUDSWE6 /aEFiwDOdPhuNf0jeGDVq+lwdlyUtTcGnYpJm+09UMFwfVMDtVx6vKhlmy/4PH4m/aKb UWZ9VWjZbyyiYhWMeuu7xRiXXM1TtorNBbw1NozVfPlBs2nnV16Te7V6YlMrspA53Cnx 9uIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=89DjEEGsLwYVVyD3+lmgDuUkvgmk0sfi5HizC/FoSH4=; b=g6DX3qi3ucy9MIJC+Hd5LuzLKd99DYiMr+3hAnuxpBvPoZdxobQNahkazOWtxacpvH g9iHawsexh4MZdTX5rOKVbf1ABQWeED1bI6hs5Y1Ujq1jRrspHCWU2RgWWH/ce+eWaNu N13FMse2zHukq3w7JM/Y8OgcJPLItNZerJ7+0PG9ubOXcihuZAxSRZASjEVNNB1fKhHq 2VvrdvEncSujYXaAKjAtiaOS9ZGowNiteeWWklgmIPwMFWjscWw9tZVsSI4ibmyDGQn+ YShZyV1AydfpGzh7wuwuuPuJRTJZ0lZTJ+nipw7mfkXK45dV0W6EQHHEEVMMparD5xXz qt/g== X-Gm-Message-State: AOAM533HTBbW7ewqHnVab/f4kBt9GYpBjDPe5EwPsUto9yCVA6QxqeuJ hXVUBlQFQzQBuVVUpUJe8Eo= X-Google-Smtp-Source: ABdhPJxkqDmRQVez9RKGPAup0tMKEJD6hMNayVig2vxoittVpi0Y4s2/5JCsUDFjoJX87Eht8C51Wg== X-Received: by 2002:a05:6871:b10:b0:d3:a3f7:89f9 with SMTP id fq16-20020a0568710b1000b000d3a3f789f9mr6920606oab.163.1645730190688; Thu, 24 Feb 2022 11:16:30 -0800 (PST) Received: from localhost.localdomain (189-47-54-110.dsl.telesp.net.br. [189.47.54.110]) by smtp.gmail.com with ESMTPSA id w3-20020a056830110300b005af14392276sm79509otq.62.2022.02.24.11.16.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Feb 2022 11:16:30 -0800 (PST) From: Magali Lemes To: harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch Subject: [PATCH 2/4] drm/amd/display: Add conditional around function Date: Thu, 24 Feb 2022 16:15:49 -0300 Message-Id: <20220224191551.69103-3-magalilemes00@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220224191551.69103-1-magalilemes00@gmail.com> References: <20220224191551.69103-1-magalilemes00@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel test robot , siqueirajordao@riseup.net, Magali Lemes , maira.canal@usp.br, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, mwen@igalia.com, dri-devel@lists.freedesktop.org, isabbasso@riseup.net Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" When CONFIG_DRM_AMD_DC_DCN is not set, the function 'dm_helpers_enable_periodic_detection' doesn't have its prototype defined, causing the following warning: drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:805:6: warning: no previous prototype for function 'dm_helpers_enable_periodic_detection' [-Wmissing-prototypes] void dm_helpers_enable_periodic_detection(struct dc_context *ctx, bool enable) ^ drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm_helpers.c:805:1: note: declare 'static' if the function is not intended to be used outside of this translation unit void dm_helpers_enable_periodic_detection(struct dc_context *ctx, bool enable) ^ static 1 warning generated. This commit silences this warning by adding a conditional directive around the mentioned function, and also corrects a small spelling error. Reported-by: kernel test robot Signed-off-by: Magali Lemes --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c index 010498ff5911..f5f39984702f 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c @@ -977,7 +977,9 @@ void dm_set_phyd32clk(struct dc_context *ctx, int freq_khz) // TODO } +#if defined(CONFIG_DRM_AMD_DC_DCN) void dm_helpers_enable_periodic_detection(struct dc_context *ctx, bool enable) { - /* TODO: add peridic detection implementation */ + /* TODO: add periodic detection implementation */ } +#endif From patchwork Thu Feb 24 19:15:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Magali Lemes X-Patchwork-Id: 12759155 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5BD6C433EF for ; Thu, 24 Feb 2022 19:16:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B361310E8A9; Thu, 24 Feb 2022 19:16:42 +0000 (UTC) Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8336E10E8A9; Thu, 24 Feb 2022 19:16:41 +0000 (UTC) Received: by mail-oi1-x236.google.com with SMTP id j2so4345718oie.7; Thu, 24 Feb 2022 11:16:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cvWS3oa5I3x2kAQ3Snct7Bstqa7gnrjNdhiuEziq/dU=; b=JkG9j4xtSW7YFux2DfQ1IWJkCHhW6PI9tpZ3Eolo5e3HTQjgG7/eJewkdn9n4nFLcJ LMv6iYPulUryfWvUfTDyp6uGHOFOvEWfPfY8a302Mstq7k4TVNT2OE5E3WybkWTZNDAM rPJVC5+IaLwafCUep7U8BUKAP/efw5JhRnbrMY0aD7jDXwkv4SBHfPdCaGVw+IkswTwt bUYNXfueXk0AlOKRAp4li5srTypoWsgWi+EjGN0erU6UrF7oN22gLb7B/7b6bd4flwGr +txPSk2EtRJjsDIMhBaZgBSmg2K/zmCNP3NEKZYfgV3ZP0xn8UGrIt6D9kCpUTU2eGGa rmAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cvWS3oa5I3x2kAQ3Snct7Bstqa7gnrjNdhiuEziq/dU=; b=JHEaCY/W4633rw08W9jtvkGTeusP0Xfwa6WY+2UxOBhw2U1R5MvBkoGHRy0To7YQZT 8ucO6Wgy+6zqql63cVB0GWyJ2cu92dGY1KwdXv7NunAtKzh673NgSmmsQS4PFocZZbFJ xdxirn2QdgI0MjU/MhVXv8Suk4bXbN5FTVOREfg1u6ZYHWsghJppJSBf3OsEvTS88lt1 7KyFyJN2htbITTJ5yuvc1pFsdUctSz8hk0x15U9ewV0yZqFheE+5NXn1dhFQE31eGHNG gpsWih8aWYU54ltbam5Oc2mMRoLIO+NEQEVBqA7T9w4ll5bCWMugFo4lnhqUWYy6xsks nkIg== X-Gm-Message-State: AOAM531W+3SUX/P+9BhLTfqobBhC7MWmCMwO2Yit99San40Jvu4jht5L KPJdYX3iady5u9D6INWC4OM= X-Google-Smtp-Source: ABdhPJwm/qYulK2RcECTOgOP4yxZGphxfccVIGc7Dihv+vNvytMvIjB30p9z1/iUQFqG7fhxa7wRhA== X-Received: by 2002:aca:643:0:b0:2d3:fce2:d82e with SMTP id 64-20020aca0643000000b002d3fce2d82emr7942829oig.209.1645730200760; Thu, 24 Feb 2022 11:16:40 -0800 (PST) Received: from localhost.localdomain (189-47-54-110.dsl.telesp.net.br. [189.47.54.110]) by smtp.gmail.com with ESMTPSA id w3-20020a056830110300b005af14392276sm79509otq.62.2022.02.24.11.16.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Feb 2022 11:16:40 -0800 (PST) From: Magali Lemes To: harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch Subject: [PATCH 3/4] drm/amd/display: Use NULL instead of 0 Date: Thu, 24 Feb 2022 16:15:50 -0300 Message-Id: <20220224191551.69103-4-magalilemes00@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220224191551.69103-1-magalilemes00@gmail.com> References: <20220224191551.69103-1-magalilemes00@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: siqueirajordao@riseup.net, Magali Lemes , maira.canal@usp.br, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, mwen@igalia.com, dri-devel@lists.freedesktop.org, isabbasso@riseup.net Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Silence the following sparse warnings: ../drivers/gpu/drm/amd/amdgpu/../display/dc/dce112/dce112_resource.c:865:16: sparse: warning: Using plain integer as NULL pointer ../drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:1588:84: sparse: warning: Using plain integer as NULL pointer ../drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2725:84: sparse: warning: Using plain integer as NULL pointer ../drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1919:16: sparse: warning: Using plain integer as NULL pointer Signed-off-by: Magali Lemes --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 2 +- drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 4 ++-- drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c | 4 +--- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c index 4367a6e0c224..cc8e60ec35c6 100644 --- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c +++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c @@ -1924,7 +1924,7 @@ static struct audio *find_first_free_audio( return pool->audios[i]; } } - return 0; + return NULL; } /* diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c index ace04e2ed34e..8378b80e8517 100644 --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c @@ -1585,7 +1585,7 @@ static enum dc_status apply_single_controller_ctx_to_hw( hws->funcs.enable_stream_timing(pipe_ctx, context, dc); } - pipe_ctx->plane_res.scl_data.lb_params.alpha_en = pipe_ctx->bottom_pipe != 0; + pipe_ctx->plane_res.scl_data.lb_params.alpha_en = pipe_ctx->bottom_pipe != NULL; pipe_ctx->stream->link->psr_settings.psr_feature_enabled = false; @@ -2722,7 +2722,7 @@ static void dce110_program_front_end_for_pipe( pipe_ctx->plane_res.xfm->funcs->transform_set_gamut_remap(pipe_ctx->plane_res.xfm, &adjust); - pipe_ctx->plane_res.scl_data.lb_params.alpha_en = pipe_ctx->bottom_pipe != 0; + pipe_ctx->plane_res.scl_data.lb_params.alpha_en = pipe_ctx->bottom_pipe != NULL; program_scaler(dc, pipe_ctx); diff --git a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c index ee55cda854bf..8104c0c67f78 100644 --- a/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c +++ b/drivers/gpu/drm/amd/display/dc/dce112/dce112_resource.c @@ -858,11 +858,9 @@ static struct clock_source *find_matching_pll( return pool->clock_sources[DCE112_CLK_SRC_PLL4]; case TRANSMITTER_UNIPHY_F: return pool->clock_sources[DCE112_CLK_SRC_PLL5]; - default: - return NULL; } - return 0; + return NULL; } static enum dc_status build_mapped_resource( From patchwork Thu Feb 24 19:15:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Magali Lemes X-Patchwork-Id: 12759156 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2F34C433FE for ; Thu, 24 Feb 2022 19:16:51 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E016110E8C0; Thu, 24 Feb 2022 19:16:50 +0000 (UTC) Received: from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com [IPv6:2607:f8b0:4864:20::22d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9096210E8B0; Thu, 24 Feb 2022 19:16:49 +0000 (UTC) Received: by mail-oi1-x22d.google.com with SMTP id j24so4317851oii.11; Thu, 24 Feb 2022 11:16:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7IUvVKF5Pch8a16lx0MT86rwIlpqNss44lNM/kW3WVs=; b=ne21DyBH+0ZWEGvMo7Kz56PYmwP1GgCVw3i0R6NVkPQJMYyrc8sPuQItlSuHxv9VRc TXB7pCjba4j8XT/WvxjkN5JbZ1sdP2juBJu7YA/ESnLTa6kEBA+4SmpalQ92HXMMye1F 4MGZrYTIq1WdT977vBFe17BmposVWu8IjvsLstrHzkC6RtNDiizXLvU2JJmv/a2ZOnSv 6E4A/Z5M/vw965DFZA5o7kFCzhF56hgh4aeI2bscy2u0xjPAuhU7qy2gCRwDTZKwYDkC kr92WaJmPK7uTAOkB7Qdp3Cb739BrYnK8/uIhE9jrM30wlrmccSBM61ZnYAtOUSDvnWG wyDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7IUvVKF5Pch8a16lx0MT86rwIlpqNss44lNM/kW3WVs=; b=OytLfId7ySkp3ITgMyYlAaAldtwO4AmbP/E7UoUR36azkDN7X3eoxhWU0ZkfzL7Rza QnoGpSPwNzqrAVs28GgXEpLs4kk2TzJ2r/SpcHYb6Lru2a5/x/uJMGlUjHygrZxX1dWQ lksKQ8FUAkcWBKQrCibpncatlJgYtFJW0O/BAYk0FB2XniswqnjSB1qKe9cI/c/4/dl6 MBrWtlbF1Z4ZpXaz1hUPRNvfqDB7/SogwMC4mw+RKyILEMvAL7UDti6lJUrFFcrb8W9D SNHIFT59UyVbN5hPm7wGBi6o0uQssKYSOgX6qw9QYYykZVAAaYa358lMLVRvLgC76s5Q cPGg== X-Gm-Message-State: AOAM530UQZ315fMZkg+W9jE2ekB9cSlHutVRKwtfY6YUv3tir/Cd+BMW cPN/N3HU4vCYqO6fcDuWXBg= X-Google-Smtp-Source: ABdhPJxoXP+tSpCWcygc2lcQGw4uSvebv9aB+dvrgCiioebX38US3T6IU0aiiIwLKSTXbzn8q6EPgw== X-Received: by 2002:a05:6870:d1ca:b0:d6:87d5:4ab7 with SMTP id b10-20020a056870d1ca00b000d687d54ab7mr5944097oac.331.1645730208809; Thu, 24 Feb 2022 11:16:48 -0800 (PST) Received: from localhost.localdomain (189-47-54-110.dsl.telesp.net.br. [189.47.54.110]) by smtp.gmail.com with ESMTPSA id w3-20020a056830110300b005af14392276sm79509otq.62.2022.02.24.11.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Feb 2022 11:16:48 -0800 (PST) From: Magali Lemes To: harry.wentland@amd.com, sunpeng.li@amd.com, Rodrigo.Siqueira@amd.com, alexander.deucher@amd.com, christian.koenig@amd.com, Xinhui.Pan@amd.com, airlied@linux.ie, daniel@ffwll.ch Subject: [PATCH 4/4] drm/amd/display: Turn functions into static Date: Thu, 24 Feb 2022 16:15:51 -0300 Message-Id: <20220224191551.69103-5-magalilemes00@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220224191551.69103-1-magalilemes00@gmail.com> References: <20220224191551.69103-1-magalilemes00@gmail.com> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel test robot , siqueirajordao@riseup.net, Magali Lemes , maira.canal@usp.br, Qingqing Zhuo , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, mwen@igalia.com, dri-devel@lists.freedesktop.org, isabbasso@riseup.net Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Silence [-Wmissing-prototypes] sparse warnings from the display folder such as: ../drivers/gpu/drm/amd/amdgpu/../display/dc/clk_mgr/dcn315/dcn315_smu.c:126:5: warning: no previous prototype for ‘dcn315_smu_send_msg_with_param’ [-Wmissing-prototypes] 126 | int dcn315_smu_send_msg_with_param( | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Cc: Qingqing Zhuo (Lillian) Reported-by: kernel test robot Signed-off-by: Magali Lemes --- .../gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c | 2 +- drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_smu.c | 4 ++-- .../gpu/drm/amd/display/dc/irq/dcn315/irq_service_dcn315.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c index d66633bef2b3..357f89b4a8e0 100644 --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_clk_mgr.c @@ -430,7 +430,7 @@ static unsigned int find_clk_for_voltage( return 0; } -void dcn315_clk_mgr_helper_populate_bw_params( +static void dcn315_clk_mgr_helper_populate_bw_params( struct clk_mgr_internal *clk_mgr, struct integrated_info *bios_info, const DpmClocks_315_t *clock_table) diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_smu.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_smu.c index a60543258a5b..831fd1494d60 100644 --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_smu.c +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn315/dcn315_smu.c @@ -123,7 +123,7 @@ static uint32_t dcn315_smu_wait_for_response(struct clk_mgr_internal *clk_mgr, u return res_val; } -int dcn315_smu_send_msg_with_param( +static int dcn315_smu_send_msg_with_param( struct clk_mgr_internal *clk_mgr, unsigned int msg_id, unsigned int param) { @@ -181,7 +181,7 @@ int dcn315_smu_set_dispclk(struct clk_mgr_internal *clk_mgr, int requested_dispc return actual_dispclk_set_mhz * 1000; } -int dcn315_smu_set_voltage_via_phyclk(struct clk_mgr_internal *clk_mgr, int requested_phyclk_khz) +static int dcn315_smu_set_voltage_via_phyclk(struct clk_mgr_internal *clk_mgr, int requested_phyclk_khz) { int actual_phypclk_set_mhz = -1; diff --git a/drivers/gpu/drm/amd/display/dc/irq/dcn315/irq_service_dcn315.c b/drivers/gpu/drm/amd/display/dc/irq/dcn315/irq_service_dcn315.c index 33367773699b..e722171f0d2d 100644 --- a/drivers/gpu/drm/amd/display/dc/irq/dcn315/irq_service_dcn315.c +++ b/drivers/gpu/drm/amd/display/dc/irq/dcn315/irq_service_dcn315.c @@ -42,7 +42,7 @@ #define DCN_BASE__INST0_SEG4 0x02403C00 #define DCN_BASE__INST0_SEG5 0 -enum dc_irq_source to_dal_irq_source_dcn315( +static enum dc_irq_source to_dal_irq_source_dcn315( struct irq_service *irq_service, uint32_t src_id, uint32_t ext_id)