From patchwork Wed Mar 2 09:02:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabian Stelzer X-Patchwork-Id: 12765670 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2D1CC433EF for ; Wed, 2 Mar 2022 09:03:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240314AbiCBJDr (ORCPT ); Wed, 2 Mar 2022 04:03:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240312AbiCBJDp (ORCPT ); Wed, 2 Mar 2022 04:03:45 -0500 Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50069.outbound.protection.outlook.com [40.107.5.69]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FBDA1A3A6 for ; Wed, 2 Mar 2022 01:02:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EdhTXTWJrF/9Jw4speVxDP7DxwcZ2/zM1t3gZLPklkK2ZQhUb8RpY8JsMjtcFYMiIn7ciY9N0f6mx050XXNFkiQD9r69LCpY+gpcekVJYzGVVKUQqepHixE00VyxlPYt3jahvM2hHUor/frVizbAINEeSOzNbR7utoQLcR3gn54mPQNJn7UqYEPHXDxnH01nijaP+/vopreTv4CG3Ho0X6UMopRzAnpc4rfrYxzIZjb1YGwqMzGhdlolZaWbMkqYS8WrNwJxIdQkWqb3pwRYcZGf7qF1DiP8s8Kdo/l45xrkFoMlXC2qFrHpv6tv6ZrThdhoryQK5iWttUlulJ1f2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6/Bn7V5PHkNUoIVQLooEWN9ExGJFGOAEtL/6M5bIJhc=; b=khJC+4NxZqD7DCzchQVCVG+Oe7ikGp2/fecuXPNuKXU9V40VlNrpQxlZnqg6PcEjV5CE3U4ug8q+2qbfZxipBeB1qSgIrylUqrIdn6K89IWEF5JuLmk0kKijzBX11iTwFmVd/8CDUt7PldcWsqSA4QiBA9IGbDIFf8Q3ppg/qif/f0TaOpo+m0eMyoHvzcCHqaf3DXLjTd0r+FTyJD6iUAV7n8QjosJvnS2HbnZMcSyuNUQsU9xyQVPSEivRPjRY6GGUVnY8hJr4ssizcupYuiPWVaGtrC3mXiuTcyo1nXWg+izB5VqHxFxXYyiaYm1qOKvH8QcxOF9BximTymH8jw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=gigacodes.de; dmarc=pass action=none header.from=gigacodes.de; dkim=pass header.d=gigacodes.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gigacodes.de; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6/Bn7V5PHkNUoIVQLooEWN9ExGJFGOAEtL/6M5bIJhc=; b=DU/Tcb6SDDO60WNBvN8FnMwyMchr69Pla/+MEvciXFutHjai2Wh2HvPYRyGPaFFoU318lqtRY9+Xd7huMFwEP8KTYIYSrKnK6I1pCfRicKBKBEeQpETZfXtbEhKOL2sfTPJc6qOaKozqtFSqgXzLyHQeJRgpzAvLvGM/7plIAyw= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=gigacodes.de; Received: from PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:12e::15) by VI1PR10MB2015.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:803:38::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Wed, 2 Mar 2022 09:02:53 +0000 Received: from PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM ([fe80::116e:6242:98da:22ba]) by PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM ([fe80::116e:6242:98da:22ba%8]) with mapi id 15.20.5038.014; Wed, 2 Mar 2022 09:02:53 +0000 From: Fabian Stelzer To: git@vger.kernel.org Cc: Fabian Stelzer , Henning Schild , "brian m . carlson" , Hans Jerry Illikainen , Junio C Hamano , Todd Zullinger Subject: [PATCH v3 1/3] gpg-interface/gpgsm: fix for v2.3 Date: Wed, 2 Mar 2022 10:02:48 +0100 Message-Id: <20220302090250.590450-1-fs@gigacodes.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220224100628.612789-1-fs@gigacodes.de> References: <20220224100628.612789-1-fs@gigacodes.de> X-ClientProxiedBy: AS9PR06CA0071.eurprd06.prod.outlook.com (2603:10a6:20b:464::22) To PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:12e::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 349744a0-3fd6-42e2-2282-08d9fc2b6f2b X-MS-TrafficTypeDiagnostic: VI1PR10MB2015:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: i+z7vlc9sr8nqMY9SIta/dZOOYDjTjHywXigo0W6+UH2p4bTGvVJZc2LVej8uPMEJGi525Vyy9Bh3Pea5wx2MbfD0qFbuKJje329uxKuEOSJsC0pXtQnn+dqFVv5cWBgHuGeZ1f+LdKcb+wFxZX+DNpBIcy6VK9i7hpysJeZry7zbgLoBpCD8cQvD+aPT+bxV7gcF5Wg4CP47gnZlVE9tX0iImKKyGED6u4GlmRKnd4WrewY09L6UQFPOi8FRHfLrgrBdvUvW3a5UQT93cmc82Ki6byVspCsO6ckuSWpTnMJs0GlHn6PD9YZDJh6kf02HUQ49qdMFOThKtUt4uvgnGOXuAuSXQASb4YiBtHpXvZTgkNx5SxE/g7MCfAk6CJxOxZAYGTklWURVgbSn37GVnlUF2kaj9uGR1UIoRrBs4ysGYigxl/cQSZiqGdAiWEREZ8UgX4BjSIUX1JIq0pg+quV325nkZFTeka96QIbeOMzqCoPs4xyK0BiEDOvwaG8Gvfq8cmbHod2HIlIaKNXA7G9Ed9B9E8ZjxAnkiH6Whuy8zGbt7gXLFNgwyB4QD1cEOchE7hjlsyB1owGFZeGwmKfo1qP91TDtgpdJJQL6UEZS5AN7ozB+D7K4Cj8IdzSrkNwWjxixs3xD+1OCgilKA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(136003)(39840400004)(396003)(376002)(346002)(36756003)(83380400001)(38100700002)(186003)(8936002)(5660300002)(1076003)(2616005)(4326008)(6916009)(8676002)(316002)(66556008)(66476007)(26005)(66946007)(86362001)(6666004)(6512007)(6506007)(54906003)(508600001)(6486002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: o0MFi7dZxlDoG0MQ4WOD3/g2kUliLJfT4sMJWxrH9GEENPY/s3Qy3CT+MPh6xQdFUBFj0Ygawr4ubGQWzqjS/+8MATBJU26++3cmlZkovisAi0tdFmw9yzwyNybR6g12LyxYOhlZkE1gEv02C71bim2K4P9uSU2byhUigdTxCHdPUfmGvEUW+Utu0xAes8vfv/DozGXpqgGPTrovniVZpZII/BJP3tjljuUjr6emp8OyO/eAZhQ8+0tes8anrsFGEGLMErRF1HoSBhmoHRIs8XyV2jjwfsn6gA16GTTKqCIAiq1NmBjBqg+cHlSEntFVwkqhcON8NkWYYuRA08CeipNU57ioZ975uPF8C6Lt/kn9BwUniEr976wkB4id0TLRmUmUpf1Ek5mrq5cMOwVW/dXc1OJViEwVm2PxO/BtmHttIreGaLc8uXoDa9XieEJG0/JdaRlCYR7mpI4Y4ayoTVY7fE6h9IT0oSOeYQDdQ7RW1AlOie1SD2HKt8kCIbT+iAJVPILZDccAYtptEsTXzMC5aJqhnOoJqJkYmuFaRtBQKEiUKBwWdT70IBdoqPdZ2/YGj8ePtNBXsqK7b4/2T/lJ1/i9POf57rrBGY5dMWBaoluUsiZXJ9NDvF1p12Sgg4H15VKmhZOxyK/4rjffmebcDs3Rf3u5b1rNYWyi/lNMx0XLEcXzRMXSG0o8lqbcH7sMSXCQ73v0GjsOYmeWd8B0tj6GYSrNDpwAXThJXh+ioyre+m1DkJL2FD5nDvPz0QRGXD1/6lg4X6dipBgnAv1VtYGPil+lPownZjtoVMqL/u0lc0D10jLxDtKNOcXPPq24C+4bC8+HYNcuZIhhJSlMcAyct42pWQIjvWONVZE3l+LUrmjZqj+LESAAi7ST/xVgs6t+KPr0RrK72hFyBkrpsr2IWARqiqeYJmkJLMd2Eypcb29E7fmAHvVvLbDEaUNEEupYkRw1ftRNlKk+acQlZQb2/+bKDDBukvZlA1RfqiNeQEhOuLTGSlZfQhRdRbvxCsz0T+1CFtWkW4gSjHi3n2CSEDy2Ely3LJNYT+fj9XCCHsdGqts7J5uJPezWw5GGLoF+DfIP8rAFvYNCFDKAJfBdu5Z46CacO3nBEMKVCaPCxiktGSoMQhErOYf2yEMHgVVQS1nLAFCU2CINizEjKFRG60CHv7t+UlxzMC0a74zS2XMBt4vnj99rcj+WD5aGTA5JZDlcYF1ni/26N+SPIeTwGcBbwaPLTcll8O+e0Du5qUOmzSdPGYYg/AhngBpc/YDsYVmiVmJQzaerjx98BWC7d3scWoc1KrvSKayiySsXR1rYkYhB3VdznniYWb5R0RnSlndmAngdnzXjJ+0AtMVteDJyOJgCo0p1vF1gZLT32lEQIayCL4BgYU6yIwREcFjZeeSOEGxicEQanfd63tpbXNvkTDRQNxKzW798C6RFICBDXSFR2NZSKxh7o0YbHrPN5fQnEzKfbbupYty+7541mwV8+O9so2aHr/EiFu2d1uZyU/jsQKnUa2KUT1DJ8ZqRDeMi0uMatY65zNntfbGgPNDxqmFgeRUAmc2b+cYvlx5tkHzn7psdbxv2Wc4F8yp7DJfDi3i4ikDDgggJYHGABYdUgEnN+6TcizOWywe8wEfrnN3Z4Fhw+AbvRLiIYMmRwmN/nhwm8+96FKyfxaWbJ8JbINvAPpGS62c= X-OriginatorOrg: gigacodes.de X-MS-Exchange-CrossTenant-Network-Message-Id: 349744a0-3fd6-42e2-2282-08d9fc2b6f2b X-MS-Exchange-CrossTenant-AuthSource: PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2022 09:02:53.1495 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 80e41b3b-ea1f-4dbc-91eb-225a572951fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: REfFRBIjoNvhmCtYJftKhhfey7vvgQ+S+KSYern0Jf46/Fc7SmQlHHfbl0KP4yHbc8C1Exe+dJjBRjIL5F2VFu42Klgndc2pQQ3511MQEgY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR10MB2015 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Checking if signing was successful will now accept '[GNUPG]: SIG_CREATED' on any beginning of a line. Not just explictly the second one anymore. Switch to gpg's `--with-colons` output format to make parsing more robust. This avoids issues where the human-readable output from gpg commands changes. Adjust error messages checking in tests for v2.3 specific output changes. Helped-By: Junio C Hamano Helped-By: Todd Zullinger --- gpg-interface.c | 9 ++++++++- t/lib-gpg.sh | 8 +++----- t/t4202-log.sh | 2 +- 3 files changed, 12 insertions(+), 7 deletions(-) diff --git a/gpg-interface.c b/gpg-interface.c index aa50224e67..280f1fa1a5 100644 --- a/gpg-interface.c +++ b/gpg-interface.c @@ -934,6 +934,7 @@ static int sign_buffer_gpg(struct strbuf *buffer, struct strbuf *signature, struct child_process gpg = CHILD_PROCESS_INIT; int ret; size_t bottom; + const char *cp; struct strbuf gpg_status = STRBUF_INIT; strvec_pushl(&gpg.args, @@ -953,7 +954,13 @@ static int sign_buffer_gpg(struct strbuf *buffer, struct strbuf *signature, signature, 1024, &gpg_status, 0); sigchain_pop(SIGPIPE); - ret |= !strstr(gpg_status.buf, "\n[GNUPG:] SIG_CREATED "); + for (cp = gpg_status.buf; + cp && (cp = strstr(cp, "[GNUPG:] SIG_CREATED ")); + cp++) { + if (cp == gpg_status.buf || cp[-1] == '\n') + break; /* found */ + } + ret |= !cp; strbuf_release(&gpg_status); if (ret) return error(_("gpg failed to sign the data")); diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh index 3e7ee1386a..6bc083ca77 100644 --- a/t/lib-gpg.sh +++ b/t/lib-gpg.sh @@ -72,12 +72,10 @@ test_lazy_prereq GPGSM ' --passphrase-fd 0 --pinentry-mode loopback \ --import "$TEST_DIRECTORY"/lib-gpg/gpgsm_cert.p12 && - gpgsm --homedir "${GNUPGHOME}" -K | - grep fingerprint: | - cut -d" " -f4 | - tr -d "\\n" >"${GNUPGHOME}/trustlist.txt" && + gpgsm --homedir "${GNUPGHOME}" -K --with-colons | + awk -F ":" "/^fpr:/ {printf \"%s S relax\\n\", \$10}" \ + >"${GNUPGHOME}/trustlist.txt" && - echo " S relax" >>"${GNUPGHOME}/trustlist.txt" && echo hello | gpgsm --homedir "${GNUPGHOME}" >/dev/null \ -u committer@example.com -o /dev/null --sign - ' diff --git a/t/t4202-log.sh b/t/t4202-log.sh index 55fac64446..d599bf4b11 100755 --- a/t/t4202-log.sh +++ b/t/t4202-log.sh @@ -2037,7 +2037,7 @@ test_expect_success GPGSM 'log --graph --show-signature for merged tag x509 miss git merge --no-ff -m msg signed_tag_x509_nokey && GNUPGHOME=. git log --graph --show-signature -n1 plain-x509-nokey >actual && grep "^|\\\ merged tag" actual && - grep "^| | gpgsm: certificate not found" actual + grep -Ei "^| | gpgsm:( failed to find the)? certificate:? not found" actual ' test_expect_success GPGSM 'log --graph --show-signature for merged tag x509 bad signature' ' From patchwork Fri Mar 4 10:25:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabian Stelzer X-Patchwork-Id: 12768931 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89DAAC433EF for ; Fri, 4 Mar 2022 10:25:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234051AbiCDK0T (ORCPT ); Fri, 4 Mar 2022 05:26:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233682AbiCDK0N (ORCPT ); Fri, 4 Mar 2022 05:26:13 -0500 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2076.outbound.protection.outlook.com [40.107.21.76]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAAD2194AB9 for ; Fri, 4 Mar 2022 02:25:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TfNAc2w6GAXM1OezgTUu/L39iVYsli6PgZkVk2elMYkigQd7PwaXlSTKTO/tGw11ph0bhlQqz2LA9UPGQNC1J21W6VTZ18tt5adJjIZvSCmV4taUySKew6rdeR7NGlrbYKa6XMWt41xA+FqJ0v0lU6cm0/+rzcOCC9nwt8yMyzLRGvO+DIeBHNV4CSQD2KZpN/ZooZUDHuqKh0Oa0LGkFWp9D+GIoUWVxIJLH88DqXKavE895asijrh+cUXIac47MYYK/N1cCtNHa+Z6+EvCHP21EZqzQJSGZ07tDqihjsVXK7oLJzloDXVTuezby626qbHUK0IMxVeOzTVwsJxSVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0gzEmdB7TOjJdgm5yNk4kfNj0jcmrRCgK//WSqqvDLg=; b=M6LGEZWIJhF3Xzld04mJPMSnum4c6+nuYOpswTzs5b66n1ZpEy9+mW009qxgwEluDiKQgO6+CwOPaTuSifJS0faQvBBw3/Te032mSqkQTwuHNT/kynKinlzDKl2vvfS+TXF07CIs5ZhwvIGcLbTI/Hjr2bcxu9YDxvJ22vzno8J0e3quYEQplP4C+HVUGMZmUZ2FS+7UeoyEwCE3D0pfsjLBpTlqFzzS4JYBHQRlh6q0IvW8OGhx3wHI+qd8tf00PzsLBIr8CCyw8P/143jBLdqDXeLou4jZVO2xuU+MbMhvCE9bSnL3CBnRJARcoVjyaJq6nPSwM3WYS8+y72C4qA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=gigacodes.de; dmarc=pass action=none header.from=gigacodes.de; dkim=pass header.d=gigacodes.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gigacodes.de; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0gzEmdB7TOjJdgm5yNk4kfNj0jcmrRCgK//WSqqvDLg=; b=gno70pZlLywOetymrsIVuFHAqbzmGjSTUElj/HfJmDFseyoKM0Wv1c3EpVT8SiNnOKDK6rfSMZbHmb6Asvt/2OONS0XLVShTVr/g+Ryl13J8X8mARnylu+XocCg+IvdJhzGSooIPSXdcVxatcaorQgBdcrdeC5rKW72G4C8djPA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=gigacodes.de; Received: from PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:12e::15) by DB6PR1001MB1222.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:b2::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.26; Fri, 4 Mar 2022 10:25:23 +0000 Received: from PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM ([fe80::116e:6242:98da:22ba]) by PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM ([fe80::116e:6242:98da:22ba%8]) with mapi id 15.20.5038.017; Fri, 4 Mar 2022 10:25:23 +0000 From: Fabian Stelzer To: git@vger.kernel.org Cc: Todd Zullinger , Henning Schild , "brian m . carlson" , Hans Jerry Illikainen , Junio C Hamano Subject: [PATCH v4 2/3] t/lib-gpg: reload gpg components after updating trustlist Date: Fri, 4 Mar 2022 11:25:18 +0100 Message-Id: <20220304102519.623896-2-fs@gigacodes.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220302090250.590450-1-fs@gigacodes.de> References: <20220302090250.590450-1-fs@gigacodes.de> X-ClientProxiedBy: FR0P281CA0037.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:48::19) To PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:12e::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 664b820e-d155-4418-6271-08d9fdc94a6b X-MS-TrafficTypeDiagnostic: DB6PR1001MB1222:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UVNucGMT4GDuwqB8veEwr5pueMq9x1IxDvY6lER1vfo/kgg6nJCzJvTKuC+9+luNCPjMgx5Y5o32O4M2ok368HtGJVwjIUH2lSen+wDeHQi6/aoB/FajRbPHTC9WHUraph8VSCG7n8YjF8+vqpwQK+oFW5vXA2IIplPe7TiQNQJbSu9Nh7P8x8749eCNw9L4fKOhexoxKwaRjLig+P8L8ZAPKQpyeZYG/DDU1lDD21YC9gNuVFHtS/UWiyqZf3JqrlW5L74j6NIwLxVmKX5OflxqtwMkpnBSninwzcb/N4yO2pIKbyukZDdD8pzIXfpCmoJS/86x7KN7kVh6nlPbIl9f+2UJi/gAVQjQrTx+QkPZ0bE2mNUM92McwEOFrAuZKk0qPAcecMINyRVXWY8zD/dFQ7C9u6atu6GoCDoBPtuvn1YNaH2ADHPiCIX4fzcmISjiTaUEG52wyEYDReSFQznrQ/IQHE6f6rr+mpWLxlx7/1lVSFOFizSrxbK8gdLEohv1NcUk82zpLU8lJOX/4V1naKUWKenWBVB9FKhvWQt1ttcwX9zsZOD7095McI3KLJCqDwbkhfJhfIaiEa8QlvaOXdYaQJm0Jl0UcufBm5Mu83jL6wBVykC729uj1BzMzGOAL1YV8mU8rKjNKvUSSg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(39830400003)(376002)(346002)(136003)(366004)(396003)(6666004)(54906003)(6916009)(38100700002)(186003)(1076003)(6506007)(6512007)(2906002)(36756003)(508600001)(6486002)(2616005)(4326008)(66946007)(8676002)(66556008)(66476007)(26005)(5660300002)(8936002)(316002)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: A6lBMdNQKsNd9uEg8Kvvu2A2ygvqdNPMIfjv4FEKh9K/9laplHT+Jfyjb1LJd+r3gyszIZI4uILUtp3m+U5BsW9clYKyew55uQrxBr9q1LqXNd8mQ9lWE//UdVgASp4H/PS9VlIHkqzTD3FT1fMcmUPWE8W1TivxdavIZaTzsVsENKnhRHVw37nYD9sNYNEeIhvon0OUIWr6ONplg3WiQvYZ08D8K8l86mjlzrFoL6D1zlftborJO7EKJb4SJ2tWAAOeIlwW+++Ocgig/nALsF3lMsRW5zinLAgMzrPooiqPcxl/Mh7R2F3aEiM6Sc4M9mpJVitjvQXyZK1rF/H+po36tuiXDAr1dy9zDr0ZrEJFxYvUZGcW0iFiJphs7AeDD1ok5kJs/1AjeqpDLnU8CnfTi9/13yoOdepAyxHPx13j8x3z9cPGe7Y7P1MvHTkvfJFyZa1+Ud5JHAE1F4LxtMP3VcJJUKf0/QEmbbtwEWYKMsSYK66JhNvZMtE3vr+f08o7Y6B2Ms5d2B3X4HMCEqIwBORk08x7freZ5JAhKTcv7fkHkhHwKu6N/X9J7UPvwxg3+8Cbvdnj5CCkS57V/J16Wcq86jOTMSkDvY3Q9QD40OTg5BW2qXEUBM7H9upXBVCrEhcrv+ocEcySiq8bUt7IffPVwWCd1jxIE5wT18eRoGTACB6MW1EyuDMSXhKGCw4RUrajJseBeaR/D2uFkvzUtY4xkOWZ9rdQ5clnoifEdeXKX4E5Q5OEvALrzhb50jD6xlovKxgNVSI+YHaE3kdicnwrJNyqRCbaTTsstD1RBuYUW7uDfetEuF+ry4CJn7JRW7Xk2wdNB8TECK94y/KydMqp3dMcVYTOF0EGQ3UYmRCT5XA6/6C7BaZbXWQwWSB1VoeDamPhHlrSmoHGG2KIKwlj9TU8vudZU+TBsLmWaVWMx7iV3JKNYyDLDcNsLf1/EQ5zGsuHzm6HFc7kL8kKVIn6D1DIn4zdS8uLX40zoGD40aZYES3aUjJxY6lGuF+9dcr51IkRXqmXwCz0ihl2Jtmgdnm+yhPYSwak/BbXrCDz8xKYIbrbSVnrfqx3RajtgkBKaPfgjQhdN+x91nM86F6Cv7MS5PnBia+PgGSPUj+pnnh9XlFcfdhEH2fiwtDh90B/bf6h4jC1NtgjN1hyE3nYx7FpZdRGV+MH/zQuLLp0rcPm61XrKutWzNiJkbe5QfN6rF73/UHhQVQWHFG970X0NGUR0UhcOFMnYIr2u0ZqyE5/uHl+bzB4jQMgU2wyuOmi2CiwyEBc4AHyNWoHT2EkX/PfIfGx7Balhk3owWC9CpeewDnjNnvmbPlerOxPLOp+YniYUg/beQcHilUhJUDjqxveklBkdXvgJUPURkNuku6wwvsfjC65/Jwv+0H3re+fZwZKvVEPjborE+xO5QT2YB8/m80KVEh7n3f6KYExkGCS+MgbRE535GrMSwgqzCn8qIPrb1v1XAtV5EZG8S5eNukQYdD5t5HOh3BGc4HuhS7lyDd4cjnO90gb20AQ6rwrAGpk8xeLLd8Oy2QAqz7enhDif7k6JnWO9pZRPgK2wPLnaaDY68x57ZWeFP93A/X2V0IOmHqErpnymOUWgMder2I1CVp+YOz/T3EGUE0mXxSJreSHsVNAAMSxWpL4N68Xmg2G2ZGW7lQRaUWCN7528wfFDKwmftBslEE= X-OriginatorOrg: gigacodes.de X-MS-Exchange-CrossTenant-Network-Message-Id: 664b820e-d155-4418-6271-08d9fdc94a6b X-MS-Exchange-CrossTenant-AuthSource: PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 10:25:22.9378 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 80e41b3b-ea1f-4dbc-91eb-225a572951fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TRBQ2ctpIaAG6VEVMo+SedEYv2eqqMZLBOTMKlJ4Qpv1mT/NhpBC3wLEAYL7Vs28/b/WghSNGBtCskRJUVC0X+deomvxUj/gjGGYnDamA3U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR1001MB1222 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Todd Zullinger With gpgsm from gnupg-2.3, the changes to the trustlist.txt do not appear to be picked up without refreshing the gpg-agent. Use the 'all' keyword to reload all of the gpg components. The scdaemon is started as a child of gpg-agent, for example. We used to have a --kill at this spot, but I removed it in 2e285e7803 (t/lib-gpg: drop redundant killing of gpg-agent, 2019-02-07). It seems like it might be necessary (again) for 2.3. Signed-off-by: Todd Zullinger --- t/lib-gpg.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh index 6bc083ca77..38e2c0f4fb 100644 --- a/t/lib-gpg.sh +++ b/t/lib-gpg.sh @@ -75,6 +75,7 @@ test_lazy_prereq GPGSM ' gpgsm --homedir "${GNUPGHOME}" -K --with-colons | awk -F ":" "/^fpr:/ {printf \"%s S relax\\n\", \$10}" \ >"${GNUPGHOME}/trustlist.txt" && + (gpgconf --reload all || : ) && echo hello | gpgsm --homedir "${GNUPGHOME}" >/dev/null \ -u committer@example.com -o /dev/null --sign - From patchwork Fri Mar 4 10:25:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabian Stelzer X-Patchwork-Id: 12768930 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DC4EC433FE for ; Fri, 4 Mar 2022 10:25:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234019AbiCDK0P (ORCPT ); Fri, 4 Mar 2022 05:26:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233758AbiCDK0O (ORCPT ); Fri, 4 Mar 2022 05:26:14 -0500 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2059.outbound.protection.outlook.com [40.107.21.59]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00A05194ABC for ; Fri, 4 Mar 2022 02:25:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZGX8r7Fmypc7zy7lJwFcZg/gK7LOlBmVd4POi+dHAS/A2DLeyhhF7j34XnbY03qZ2TO/9TnGLO7ENusN35yHQwqbs3jtyCrWRyVDNyw7QDoP8i5DVeUjkBi1zTHO67eToy+NwmHvVsxaeEZtUmEtwnPzCzi8IAxWRDvRVtZoIkVcCM1B9YaoDgj2n/B6PjySG3f462AyXBTubPQAKF4ePmW8vHc6sJVGf2E2aIg+SnMBmSrIOxA5/o8nIHjx0nsA6hVkiPQgNSYljaeUxRMBVpYDOUPaQ83hWTNJzFIVKYQEr5cGfruwPgwDiguDpvCvx+QpH1mBBZZHVt9icOwM3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oVSdiDXFIjMdIFa7p7N/jLr0vnjb76Jgq9wuTkoF8yI=; b=OcyFT/vbkwIcJvc1Lm8SbgBUNWP9VShOJ8Wxlci6xvrPQO8jmViCC04JwNz7XGMBGixtFpDeBzk5UKRkb2mFXz4dcW3y4qf+rXjV4/Kf/aQltqPxWhXhAohZJE8ycZC9jpQ+FivRe6P2iVX0r9hRlyjVi7DDHWvY42EPTGjJPope8ch40AvDP77lY+OiuDfFZ8HpWDtefFnTpX2fIUW3A0DWivfjqrfepxUA+nSB4yYDUR68r8lMabjaz/XEckMT6eqaT46eVPYhtRgvpSCmMKwDloW9nTyPlwGl3vbax2FUX2XT0Hmr0SAXABBU99pykmrbhB8Rzy+df9HSuiPEOg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=gigacodes.de; dmarc=pass action=none header.from=gigacodes.de; dkim=pass header.d=gigacodes.de; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gigacodes.de; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oVSdiDXFIjMdIFa7p7N/jLr0vnjb76Jgq9wuTkoF8yI=; b=u53JnH30Vnr3OCJGB03lvzdW5zHBoKhDZFwWnYRtsaeM84yrB1Ozy1J1YUhvGKHp8HInyqGWmrsrFXDK0BiaXYMgmmPncKnrCr9lSXN3xcrjyCfZqDSPun5jIODf2/4r92/dq0eHD0e5c45wqvJT8L64rclb/jkY0gUmBzrCj9k= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=gigacodes.de; Received: from PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:12e::15) by DB8PR10MB2572.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:10:b2::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.16; Fri, 4 Mar 2022 10:25:24 +0000 Received: from PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM ([fe80::116e:6242:98da:22ba]) by PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM ([fe80::116e:6242:98da:22ba%8]) with mapi id 15.20.5038.017; Fri, 4 Mar 2022 10:25:24 +0000 From: Fabian Stelzer To: git@vger.kernel.org Cc: Todd Zullinger , Henning Schild , "brian m . carlson" , Hans Jerry Illikainen , Junio C Hamano Subject: [PATCH v4 3/3] t/lib-gpg: kill all gpg components, not just gpg-agent Date: Fri, 4 Mar 2022 11:25:19 +0100 Message-Id: <20220304102519.623896-3-fs@gigacodes.de> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220302090250.590450-1-fs@gigacodes.de> References: <20220302090250.590450-1-fs@gigacodes.de> X-ClientProxiedBy: AM5PR0701CA0067.eurprd07.prod.outlook.com (2603:10a6:203:2::29) To PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:102:12e::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 05246ad2-e341-4105-bdf9-08d9fdc94b20 X-MS-TrafficTypeDiagnostic: DB8PR10MB2572:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RdmEe0YIGQM3fmXffoTw3Y2oWc0MmnNTPYRYE+vI3rgjGZUsLnPu7UbK41/VCeCD1qgSCpC1frsmL52xkBUABa4mq0JMpKVOwGPCRfm9RNtOJjZCRv3xUkjFykeLPSBPpJfaduTmr+oA3wIU4BPZT/Mw8EzdReDV0Zk1pMvEnsxOZCBMzcovpBOS8D6mNhgO5pzHQJBmr5+HelcRMn0fuvSAH4bZZolUXnoTCFmrCvWAje95/12P4jrhY0/XFMvj837DDk2Ej7AliYgER/EAMEfDMWGmFsSGr7yegMxZZ3WzVHAs8aqk96ipQXcaGQcbCPB7iJJxMDlC5G6cFli02uyoYQaGZLbIg3lu7798Ss6Rx9z8kQuMUSyZpfd41FvF9mXkmxsuu2C2kjaXDQO2lc/iR6LmpjNAnsQiiC7jB/rwkpZLJMvuzdhGqg9Zrk1UYHvIrWZhn9V+cJ12QNlooNWfoVnDstw7d4m5WaN1O+82iE79VP2kNBqNr1tBLGUK2dOZon14cBSUb8NLfyL0y+A6stjggDJPyNaGGNtwMsB+3CKzG6K3vX68zvqLBeJ1W54daggA5bc1XK1f5ZoB3gJhCc47GfdKD20ws/SF41sOyse6Jg68MV+rMcyOggPyLvuvNzvpT5KU4ctbeTwJvQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230001)(4636009)(136003)(376002)(366004)(39830400003)(346002)(396003)(2616005)(1076003)(86362001)(66476007)(66556008)(66946007)(316002)(6916009)(4326008)(8676002)(36756003)(186003)(26005)(38100700002)(83380400001)(54906003)(508600001)(5660300002)(6506007)(6486002)(6512007)(6666004)(8936002)(2906002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: zjMa1wRzrOlqccyvMScbRtFm0WZxBqFB92K9EIa0N4xNvsp29fDIh9ByyOX8x7hud2/BKjgGCMBCgS/2kzTNYdWLr8mKm8mIqKt3vBQAEeXMbX9WHoDvZCPsckeX7i9AJhU4qWre3QvozF6NS4eU9/2PweY4RoMBG9hPUI45vh5kDQuXWEF5tsFP/zo73/C9ZYGfDfVAbFg2gd5iaNzKCcvXTB/XoADIfmW5cpG7C486ajuBbt16uuo01lq5eSw7RfXRzWNDjegYjSL8RdMNwcqrk9/qWnIw0F6yqfcaUOf5btOjbRdQxHhPi80CA7kTdALO4Z4cXn1RNPhQcrcPe4CO1z/8Xt3NqQtExBxsQFOIf1sAHCk62MSqk5KG76d6pIUKTNsM9PdvCske7YVqwK7AzSt6ZEfT1Y+RI+bK/mYE2wkwNDEl92wgMINa2r+GxMXz7PC5hZ5zXdLfyryjXclv4IYVaVZnJ7DP8/dyLWO/sLI2KXqWjS+CsRv2YTWi/P8vPlINbA7+/cKcjOYTjK8S+IiK9/2wEjqawyLnC1xFrxtfXRdheGfYPk2VHHlOU3LbTnPlrqvoG+j56eeb9Cd0PqKPbylDVP4HUGXeZSjjMLviYGBzzsqXqwS4JysXaVEIyGhqgJQ3BPCvonFFgORkKlpiQ6ZAgTKpWJmXnhWi0mOE4mQJLOmvmhdjS8W7CuFI9/jVOHdRAQSThIkXqK2ub7bMImc9WSHrbSlsDfv0hJ71UEmbTbv9aB5308dSf/oIQrewAp7ZRDVxoP5xsV/ZDzzXgbbWvFFWGCZJw5WxgjRieYv+1VOj/mAT2HzsTJim7/WpgeNu1rULTm46ugCsaB6V2FiMK1XmJbhgd1FjpIdg7w2aaTOp01Ihz5EpmWQu8cPyJ97HlhG5yOQD2yGuAzj9GRzCrvsZLhB1yM+4YkHdczmJCUWM7WuoikKuxOza1D7jlZSTlrSZbCUUPQmqF6Qh8EMtPBAtdrEzhqDYx8arho2sf2ld3NV1NQeSClJiQKv/T5aFbl1Afl7R190+WL36JDu8aUiNZaTDIz9RUCHomKshfwLAJeuSWMUaGtUmQZi6jAINTfYPrOQxFCEi2j4Jzih/OS4kkPoQWV51/j46cpd1vAupDsKJYS/UeKTzl+Bq6OpG6jtDqQb6f4W0OzBZ1FkyJ3cWD1zVxLixTToA19lEF3ykxzqDAeTIRnSc1VvBiuUHrmtPxAVJ+F+OXrnlmsLmZro37aBsCbMnxpG69PxfdqVebVHE1LIiTGOflaQvS3Eurtntu95Sz+DBKgyK1CqUVQk58LI55mZ2lwVYCRiw6z0/QLoUUnSLhKJEnQSrMDjMMV5UgoxWTxWeLGij/o85VlvDNbVlCeBUXt359G2//RTL9O9Uf6JzABWTgxGbeHcqS0fmyfyqFKBisWPcN0Wt94mRvPSXWSnm1YCW/NwixkwXfUhVq1EOkLzxRZoRR8UUz0hFrvVY6RVnPQG9RadODjy/3qrwJRoOYqkbM8Lwwcd9+B+Rgu9NQIAJ7dzjfrPJg9aJ3r8Wb6FXvkSWYQuFd4ZB3KGXdv+FwK9MUDKXrdtz/nmuYupx/rGdxiM2VAAkL7DFAu/PJivlCo+HA91ZjtbvVRcL5/auPJIVW1kRIgpGiwkJPSPsymC6/qj2WnG4WWRArTHFckNfdeEgJeGipHuCAtJQcLY= X-OriginatorOrg: gigacodes.de X-MS-Exchange-CrossTenant-Network-Message-Id: 05246ad2-e341-4105-bdf9-08d9fdc94b20 X-MS-Exchange-CrossTenant-AuthSource: PAXPR10MB4734.EURPRD10.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 10:25:24.1576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 80e41b3b-ea1f-4dbc-91eb-225a572951fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WLqg/DhclFlXiXwQaV6Tg26rD6h9gvrw9vT6AMRWRpbgVtCt6/LOL9//9l99THa+oTJ3+ssN1UB9+R/LhelWRJ5tkJxDR85EHoMSHufBM3g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB8PR10MB2572 Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Todd Zullinger The gpg-agent is one of several processes that newer releases of GnuPG start automatically. Issue a kill to each of them to ensure they do not affect separate tests. (Yes, the separate GNUPGHOME should do that already. If we find that is case, we could drop the --kill entirely.) In terms of compatibility, the 'all' keyword was added to the --kill & --reload options in GnuPG 2.1.18. Debian and RHEL are often used as indicators of how a change might affect older systems we often try to support. - Debian Strech (old old stable), which has limited security support until June 2022, has GnuPG 2.1.18 (or 2.2.x in backports). - CentOS/RHEL 7, which is supported until June 2024, has GnuPG 2.0.22, which lacks the --kill option, so the change won't have any impact. Signed-off-by: Todd Zullinger --- t/lib-gpg.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh index 38e2c0f4fb..114785586a 100644 --- a/t/lib-gpg.sh +++ b/t/lib-gpg.sh @@ -40,7 +40,7 @@ test_lazy_prereq GPG ' # > lib-gpg/ownertrust mkdir "$GNUPGHOME" && chmod 0700 "$GNUPGHOME" && - (gpgconf --kill gpg-agent || : ) && + (gpgconf --kill all || : ) && gpg --homedir "${GNUPGHOME}" --import \ "$TEST_DIRECTORY"/lib-gpg/keyring.gpg && gpg --homedir "${GNUPGHOME}" --import-ownertrust \