From patchwork Fri Mar 4 13:12:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 12769088 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A0EBC433FE for ; Fri, 4 Mar 2022 13:14:12 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9D9B318AA; Fri, 4 Mar 2022 14:13:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9D9B318AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646399650; bh=JHCDWFBxrQjIhWTatbkxaAtDEpmE9GR8o0JCQWB19hY=; h=Date:From:To:Subject:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=bJx1Igplu+UO8v4is11dLflQUKz5Aiw48fBlwFalBvjQNseiKdXYvVPgHQCK0WF5q rkPKV2B3Kkggwss8LzhnwLtRVfZb/k1qe9wxSzDgQo6qnputaBMQ3Y8T1wCcvGf2fp ErVXfqLNBITDYDsJEuB3NPgdpFB25dQlBO3+fsac= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 36BE5F80139; Fri, 4 Mar 2022 14:13:20 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 512CEF801EC; Fri, 4 Mar 2022 14:13:19 +0100 (CET) Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 95CFEF800F2 for ; Fri, 4 Mar 2022 14:13:16 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 95CFEF800F2 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="bkf6bJC5"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="Ke67T8UY" Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 224A61WC019468; Fri, 4 Mar 2022 13:13:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : mime-version; s=corp-2021-07-09; bh=c8837bD04RWOWbGk2oP9ZX+VqRSMCnnb22sNTCCOa3E=; b=bkf6bJC5k8tz1mdCuIyMcNIxxxLCQJmpFRflOMrsKMi/Wju8L9l9ggTstSMO80p1oqaw TyFZ2DQQN5DrenzwVS9VUCSP6L7YjqXFiAbd3e9imOyxmBKcvRWFdl431HcRx9DuiBpZ 7SQ7RFeIsNCKk1UPIbMZRhv0i8EWFM3xonUrY62r8biHqsmlHuUpFgIp85D8u52g9mUo pBeLf96zoA5+HVOyeCvi/+rByM7/6KcK/+IgQnMnEtUB6Wnz3ahqX0X4OFATWrq4GI9h p9iQdYkX9tAm7jY5mw+hMbL5C9WPqpjX4zHd0O6oj+L/5n+pqob7pgrBmIduqm9zr5cD Qg== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by mx0b-00069f02.pphosted.com with ESMTP id 3ek4hrsrb7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 04 Mar 2022 13:13:13 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 224DB865080637; Fri, 4 Mar 2022 13:13:12 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2177.outbound.protection.outlook.com [104.47.58.177]) by aserp3020.oracle.com with ESMTP id 3ek4j8tw0h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 04 Mar 2022 13:13:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ky0iTpw7DBPxiToxaFIrfm4pmTgK0KmzwjM3f/Nb3gv/Mt7GDMPKgPddauHvDOS5rCtcW9r5VD+n8WbhspjgEBLvBBUe+P13LW8WDIn3SrnokUOb2ZR9E2VsQM4uaOl4/iUSrJIUqoE6TVH51qZnnxVB2GzWgMcU0TV6CWrkeIMxA7S6VBjha5jRyl+i2amCFffpFjGZfKAZL+HB+moIGUBjrHWLZG02OelMJe9nF74ZvfMkeIiLoPayySvI6v20RMOGM6Fs2DkdQfKb4OyRUXoQ4+L4ZzshYFM7hUmlwgWWJwaJOwkeo82qghFvIdj1x4R6Wek2lm6WLBypqOmhKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c8837bD04RWOWbGk2oP9ZX+VqRSMCnnb22sNTCCOa3E=; b=Dmsz77WL2c1PbR/h1dbHhz1VAWcDAeVVRFNkNaSM2/+19dqN28pkZVNCwRriwnEk9lMXeOyyqA5otqeC1W40AirOvF2Ov81JFQJXM0QtYCowbJKp4CbMSzFsZvXAU0ThVFBmFbV7T40TxJUjAMhlFrtXtr9mxPcaa0w1IkhU9nlNrVrZX4AmSIqkgFC4eAxFfibqszFyW8Tmloc99Ix62DgnTjNcxg/jkxFKDfzSX14mklWn2juGvK5A4BuL9g02Q34XA9L33+wXCQEHq0IHEOimzsduynSoTn3QnNlLLebJH8bCG+dQrp1dM2s3KbHAXVAPxfeL7+HMX1NXRXtUFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c8837bD04RWOWbGk2oP9ZX+VqRSMCnnb22sNTCCOa3E=; b=Ke67T8UY6yaaduWQ52TcY5lGD38ZBVEyMKtvQ/IiVjMcEyeyzjpNYQkjfTBU01XMLSq6NGy7qxXwg5NUlWf14sGrTTuMyFFoxF39xo1m1x1gX88hv9XZOQYcaZxaucaA//p3xnjZ7mmTzNfMIglQ4e72POXwLg7qibMAwQraRI0= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by BYAPR10MB3142.namprd10.prod.outlook.com (2603:10b6:a03:14e::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Fri, 4 Mar 2022 13:13:10 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::2c3d:92b5:42b3:c1c5]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::2c3d:92b5:42b3:c1c5%4]) with mapi id 15.20.5017.027; Fri, 4 Mar 2022 13:13:10 +0000 Date: Fri, 4 Mar 2022 16:12:56 +0300 From: Dan Carpenter To: Liam Girdwood , Meng Tang Subject: [PATCH 1/4] ASoC: amd: vg: fix signedness bug in acp5x_audio_probe() Message-ID: <20220304131256.GA28739@kili> Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: ZR0P278CA0001.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:16::11) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f05a15c0-3f23-4008-561b-08d9fde0babb X-MS-TrafficTypeDiagnostic: BYAPR10MB3142:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oFo5vwfVmMjqYcjKEsZgZbULUGTjSimPrlDG2X+gQ36YVPfJqybCcPLAnlNCcmE4iOofzzadDO52fUecUYs8ZZ2Ctec4LjGjPH86gYyGUm8txkucka8M4aUpUvzc5Cv8aqtnB3Eo0cXT0S8QBvzvmH3LvP4NERqe8yHa29KW8IrhC9rAiwowC+P7xSkhZzAnoeKL5M9vN0JF2lqyqCvwlkE/YKZQ6A4CfLSh+N7g1gQKQH+pitXcnFuhD5tZzbx+cZzldLwLUDgL3bUmySkEe9+9gJIpyqhX6xOPY0SzFG4vUT3YWPwyIa95Mw7fXtWaHORz/aO0iVx2qo3DI/RylFN6w75QUZSEk1WIIp708Z9CFadstSCgYivY1xE7ls7BYyiJ9mVPn1jsQ3wWIuWYIun/lYXWUQwFyIusJ6pToUEuEA8wuT1SDCbb4dg5ORKtYwkgBlKIjVAek4dKFbGhIiHep1MRZY8Mk7hdgn4W+qwGzPqN14YHh7cMAPrIY9poFd5WME4EGgx3jsScqRmGwTxgEm+FtG3UlBr4k3BQVW5K5Pt6w4tgyh2pi9qH6sEnkI2kNByym3VtQC3UDy74UJyNp745lrA93rDDy+dInJRL4ZAODF4bN3FKfxtgja2LSSow5olFzb4FRxi+9rtRPhh2rzVWuV4yYUKBvZYhT/0EZ/Mugnj2nyj4F7WN1wm4KC5zI7Mg4n5v5BnFuKxhkQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2365.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(7916004)(366004)(6486002)(83380400001)(186003)(26005)(1076003)(33656002)(6666004)(508600001)(52116002)(110136005)(2906002)(316002)(33716001)(54906003)(38100700002)(38350700002)(9686003)(6512007)(8936002)(6506007)(4326008)(4744005)(8676002)(66946007)(66556008)(66476007)(86362001)(5660300002)(44832011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: u9VcDKZrWNSMDejvoiFTXw4bHJwDI6hAZqV61PGEygpEzZBBFm5wsNRlj2+n658tf7laI+B9AwdcTiI15AcFP2kVRlNSSJgqXlCB9k49ne+Y7fI0mWFTFFlYxAC/XYkvytWcV7bhpcMSTIj6NUsmQFPCZwdYky0yxlJAmeScza2BhtoZ7VevCqxlXq+rBPVWb6qkLmS4c/v5OGlEm3boTDAt9LxCuAEaR2VdCQZ1xM2Ha+5IVCdJwbwJ0vIUhdjcCwSSgqIP55gzytuSBPHkSSIIs3649n6QvLiCPAaKm5V48dzHO1jP0BZFyYBPsfF3NaWzVAty/ABWf2eG0JXC6Hv12XeGXQULv+p9wJC0U3kEaOt5gWNvAWdVzbHLmlu8WZDW/k2RDbw7mi8NHZiYCQdb9tWiYQ8/spPRUglqEL+t8QPy+MTM55VCm1+RFEnZGL8GJdcZCjHHTlV52T78zrK0/M2CQ5ZmxUfao3slGrYzdxkDgAdlKd87ycDkBZCuViyyHfkK5hQcSm61gs4zu5IIHyhkS6UCswgk21DmF4Yb1MvLmvdLHbYUHRCReCfi2Qv2v8WbKKTdcB9i1lHJqFn3l3dYbCtduUsBAyasce7apMVphbjVwntF0SvwCiSJkurJLd6ExObdkJhVLcVpRsS0Z8WaREXOASv1RUG0gIV/u4dFOEZFUWO9jUExZ4IjJPoLQU/VM/xP0LVoPJjDJUjXVDKkkf8mqRNuDqEF4KRMg9FDgDe2L2EpoOpavVG3cnORZB3IrHevnNIFigp2OpoJcAynHq31OpXWAg2X+SgQoIU59tEV1GwXWQMAHwcJ1Czp0CGb0OYHLEMxueP312TWRvGKHuQ4qyEVreAaeFK0XzpNLZD/o0pjeEbayztCDbVklqPyFznP90BE5UrZIrbgSPcDb1TDc/Y9EhcY2c4o80WaquOZtl95CxYufP6yhS4z8PwFUuyBLyeSpTWSHEKDqpSNTOf8yFI2W1iguB5nlmS8MwWzxhUh0GmxxvMj4gD1YcDtUSOtOeBxeOWXarFxh07TxMPzwGHmYAYpEtfWalqQf8H9xSX1XCEav19Iy4MxRN9O2lu82BKNp7l1KISTUxNgJVzJcGQ6dSp1VeBRkqp6408uZbJbW7w5sLEcwTiRl2DbIJq+Nm/o+L8iGZFbs/f60ZtmuxfJvcLAez3pXlxVrjXUeLovOojTDjitLBYfWQRVy8gqzGO/IlvJnlCGz7Vl2iOqBatGaU2JSrA/ta+bc/eFTPfjKtTcLDlDyrB9knfcKCa7FlTizh2wX1JQ3QG4UrFL392djhFYqahYXwOTJV6poh1sZ0sVkCZ+DQQGXnYjMRq4vxzPO8j8M9GpWi4aoBaRu6w9IeIEqLJoAtlhhJ61APsakAKZPODkluRBtHDqMmouXbl+B1GH74XZv8y8KJk/vFcVGogMEwcITLNBcgpfF/1P5EF/SbMCfI8UrzgLS2vMbFHyIn3zEY49gvtPH92vZuuWQX3LzyHbhMQx+CqIASc7A10Q2e+tHewI023gAy3ENHCKgTH/BIV+P7x3urPwVVgsddB4jfg2xa3dBhDb4XGzdbeA7JCQRP782S+25AHvnyMUEgS+bN7t724nHrxb6NAdBmLAfC695gNjyO3DQ9HZpB5sf0P3D3gNk/TYnbPP/g4UsM2vCw== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: f05a15c0-3f23-4008-561b-08d9fde0babb X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 13:13:09.9476 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +4ZpkeXN1rcjAkQgkn2zCdwDfGTiWEAcL/YblksHlOg8OxMzZ4lyxVpmTFxw8v300ZVm4GK248zWrZeBTIzvBbL4rvWInGqiUUnR8ylbUBM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3142 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10275 signatures=686983 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 bulkscore=0 malwarescore=0 mlxscore=0 spamscore=0 suspectscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203040072 X-Proofpoint-GUID: B1boqkyGN3D47lAmkaAEBcbmzBxBX-XO X-Proofpoint-ORIG-GUID: B1boqkyGN3D47lAmkaAEBcbmzBxBX-XO Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, Pierre-Louis Bossart , Takashi Iwai , Mark Brown , Vijendar Mukunda X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The "adata->i2s_irq" variable is unsigned so the error handling will not work. Fixes: 87d71a128771 ("ASoC: amd: pcm-dma: Use platform_get_irq() to get the interrupt") Signed-off-by: Dan Carpenter --- sound/soc/amd/vangogh/acp5x-pcm-dma.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/amd/vangogh/acp5x-pcm-dma.c b/sound/soc/amd/vangogh/acp5x-pcm-dma.c index e4e668593b3d..31fa166df98a 100644 --- a/sound/soc/amd/vangogh/acp5x-pcm-dma.c +++ b/sound/soc/amd/vangogh/acp5x-pcm-dma.c @@ -388,9 +388,10 @@ static int acp5x_audio_probe(struct platform_device *pdev) if (!adata->acp5x_base) return -ENOMEM; - adata->i2s_irq = platform_get_irq(pdev, 0); - if (adata->i2s_irq < 0) - return -ENODEV; + status = platform_get_irq(pdev, 0); + if (status < 0) + return status; + adata->i2s_irq = status; dev_set_drvdata(&pdev->dev, adata); status = devm_snd_soc_register_component(&pdev->dev, From patchwork Fri Mar 4 13:13:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 12769089 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DC69C433EF for ; Fri, 4 Mar 2022 13:15:05 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A1A5B190E; Fri, 4 Mar 2022 14:14:13 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A1A5B190E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646399703; bh=Te9N51vVYwGUDdTzpmgXcx0jUao+FIWMyxo9IlrHnL4=; h=Date:From:To:Subject:In-Reply-To:Cc:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=GOptqRHuFw5zlcFxEsWt5WfqeY8mJ1pwkyvteo98qSwUF6w63judIrP7H6slLRYqo 0zbLJ6vM7L2Ma3eAD5PEtIVCpxjU54V4LGoUF9dnTtATCmfQ8SkPZ6dF7wb6fMYcK8 SiR4d8/oZKyw0VvD/CWj1uHVoP7uQRNP08gHPiSQ= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4139FF801EC; Fri, 4 Mar 2022 14:14:13 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6894EF801F5; Fri, 4 Mar 2022 14:14:12 +0100 (CET) Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0D931F800FA for ; Fri, 4 Mar 2022 14:14:08 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0D931F800FA Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="xvac83cy"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="HoKgtxfE" Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 224AB5uG028323; Fri, 4 Mar 2022 13:14:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=Ir1WHdhUTxtlpTlNhlwajmOOSW0sEgl6p+SRqxhLYto=; b=xvac83cyJeL65+GjOj9mo9yE5O6DA1h1tPTsJVvO3ACwiguaMcm1KUbE2topwAk9mVYz hEpLHRUaWv3NZc54GQgFjsPnWmGnA5YalyO0DzD+9XkGHMzxXIqBSf916XCsEJ2Olldf HDBiR1EDyPVhQlUNEdHhPmfNL8wTgF0Xt7gOyxJ9mew7/8R0HKUDK6O3p38Zr4WtsQhF ImYDze9SKDheHOsDww6gK887hBjZsLWzFL4M4S5MdKxJgj2lG8zJI90pZ+hJrc9ANaG+ NtxdOMIl1ERW/0u55BBO2ZT24L729R/Nob/2HJGay+0LhSoaYDJLTtF9aS4P4BPG/4+H Ww== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3ek4hw1r0b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 04 Mar 2022 13:14:06 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 224DC8P9045081; Fri, 4 Mar 2022 13:14:05 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by userp3030.oracle.com with ESMTP id 3ek4juacv9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 04 Mar 2022 13:14:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Pqz2xM8rZuknsRPPF2tlqR/HYCS1lW+aXawadkzKWJSztPiK5PScJ0akUaanCKYTCGqhP78D94mjYhk3XY2Dltzq4BNVwjsqOjyDQl0hF/r5EPF+ksfk1fY4KAtb76DEovV16QH9PLO/EY7J0ukQ9A42i3YZ2UvI202dVAyLl797Q1PPup1KaLXcW+hEkBrEeioMQWG6PKaQWEnlILEfcWGuRJODc80mnY+gkGzxxVZXZeEipmYAwVuCm9ryYn4uzSPhS2ggW9ru2SP2eTkEBOvXuYD45nVZp/02PlbAjB3E9jOxjvg60pmr/8IY9kF5VB+l/irQW11QV29BV3TMMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ir1WHdhUTxtlpTlNhlwajmOOSW0sEgl6p+SRqxhLYto=; b=huj+jN+atVeCoY4eeqpNsf4dIY/K5qWWyeTq4qJKPD5Q0D3x9Uei0JYKH2tqYcrtuRV3v+W9lYEVWABan1Mg4BH+sSDLA6P/YVm3cXtancBIxZTG5y/YwfgoEOuCFC6wJUb3+DvjdRLvbVxpALYRDA1itVcJ46uSxBjeXkWN2mmV7NPy5LuWhEXfcwPfuCoR1KMWkCqG54CtQxsKA9qFnC/CxkGsc9OLITukDxgvvyvIYYPTDq2RNHHdsTeU9zkfq357oSpCz4QpbzuMedS27SY8EmdgVO+0SrH/DXIgS+YBTFY7Va2tBqXMiBXZE3HDJz8wQo6J5XyjQgwjvCP9Sg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ir1WHdhUTxtlpTlNhlwajmOOSW0sEgl6p+SRqxhLYto=; b=HoKgtxfEVZfHKnRWytxTKwJZzzPebSChnxopcC+kdEVoq1yec0bjkSIgYiENOOhl4r/fsda+8yvIhX1ecPHEwZAGEOl8rPHyNyB7xsHhmn0AwOzto/cUGJVE2GWt+gsHujiiOhCWGNkAnklF6yTGtOUwjXWqTPIYmnOFiwsgM1I= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by BYAPR10MB3142.namprd10.prod.outlook.com (2603:10b6:a03:14e::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5017.24; Fri, 4 Mar 2022 13:14:02 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::2c3d:92b5:42b3:c1c5]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::2c3d:92b5:42b3:c1c5%4]) with mapi id 15.20.5017.027; Fri, 4 Mar 2022 13:14:02 +0000 Date: Fri, 4 Mar 2022 16:13:35 +0300 From: Dan Carpenter To: Liam Girdwood , Meng Tang Subject: [PATCH 2/4] ASoC: amd: pcm-dma: Fix signedness bug in acp_pdm_audio_probe() Message-ID: <20220304131335.GB28739@kili> Content-Disposition: inline In-Reply-To: <20220304131256.GA28739@kili> X-Mailer: git-send-email haha only kidding User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: ZR0P278CA0102.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:23::17) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 06e5f7a3-2916-4de8-682d-08d9fde0d9c0 X-MS-TrafficTypeDiagnostic: BYAPR10MB3142:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yXyhPLOpm4G/QOSGZXU9k9W1RRhRS7zpISLoumMij2xeV1C3uw1383JNHsfaCj0TV7fs9FNfQioQfcQJjkQSa1Z+6+ksa83f3nt4yJXea52mdKaNpNrlTntfkAYMxdPPLMmqvCr5of6Zzt1Sz/RwGYHsG1ybOMTa9SsXP3uk7SUAfn1OeR4b60Q2vgpB6L1yiShXensB5FKLZPGxUQxBr2yFts14jgGOzOGXuaUvV4evEaxI98ZDZyUUntfq7zi5kz4vGxWktco9UQV2okv7TdHkYgtiWPTviMmgnsmI0Gwdgdop7PtewZhWneIRknT5+nUujJNfpTbZYS7cjyzmMmdwzMNF5Jn3FFjewPKzSaXgRKp5+NeaEgof6UTbjS3PRvb+a8k3sDuFfLL8/tJo8LZCx0PjW3IQpyDl0AJxLPGphm+sIIIQImbY/7H5To9IbtqJZbOpuq3HJudBT65m/t0Qq5uiIA9QJh8yqpNGekLkBsm6U5ekm0UMOzmDi0nWKpBA3/MpzH9reHsUsE4IjEpjCcqy1RywD9tJa1qgLhNm7+NLyj6MSe4rkskSMceH4LlMHBGq7LtsHyB9aAYnFh2Ue5xh7iUMilpR4PwlbS3tkkAEaax8snzUC4KSV3QPuWzOs9o4jL+ToG5CgDdVEsC8M1IhVmDG5AK9DDEYGIvu3XJ379V/7exFw/5HnzDiQbw9+p5lPyY2Q4llex6WOw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2365.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(7916004)(366004)(6486002)(83380400001)(186003)(26005)(1076003)(33656002)(6666004)(508600001)(52116002)(110136005)(2906002)(316002)(33716001)(54906003)(38100700002)(38350700002)(9686003)(6512007)(8936002)(6506007)(4326008)(4744005)(7416002)(8676002)(66946007)(66556008)(66476007)(86362001)(5660300002)(44832011); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: StZdT22dmXEO6k+pqMVH53fRPBlW97nDDVuUGUdaXkW3sbkiDh4FUw0wOee5r91DKZhdbQXYv9x/ZqoSAJhuLJ9GcgVUe0/RNKibP/9fPdmm412ciVPksk/fp4i7Cl9R+aipC/OncZmW/DTipJD2MdqBsFpTXwwxj5kGtvmRnI7R6tLeFJ463spwD6s50+hh9JHkanhcL8ONUd5EcDviBrwCFVsNM5HADMGo6gIBJReAWCMnqi4Pt11trLjfpIcDOqbZTP+EiI9G4jjajd6tu2K+Q3rjcHBjNSmcHZkiJWJwLzVl1w2+9AH2n8bOckJD4zzoQeIQlZpbr6MtCA4d23X0Yy8Jdi+w6J7n7SToJ3tw5GFwh51lnH9k+jOPhDaH9s3pM4VaWUnIfBP0NvWYwJKBT3ajBYW95HaanduYTYJMp0ppxfZmj7jX0By/gKtacsT7bxoVsOGrOnz45NmNjRE7EFNkYTi6GSO4SAdsokdSvMzU8pf6P7c91+gQ9mUAnbORkJGcyRchQ9oXW/BUPb2u/ZdhtXuJM2E7pJiFNC4bNzUk6ss31Ui87u251a9dhRe5U7zy9YUrqr6kwnZEfgxlzzmsybubU9ByDjFjh5Ea5CLN9Jdg+/z+L0fPWMHNqLxOYXvBO5qDy0d0qdLPFYU20W0B/dd0ZlKwvbtZINXHdK3+Cpqcw5PtgtDIinsFDpNs0i2xw0MB8v8DDigTIvZLUTQoCnxO7FeKxj9H8NCPdBR+ybwgmOnKRnEzVnkuWMsmUFL2RNYeCRZBeKEEt/FZ0oBiH0MEPOLcoZUx7Thrc9yG0zO1Q9WbJHt67MIJ8MIZKFqbU890lkXQ2ByD9GVU2FtXovi3SUiYjvw5eqBUwOQX9qoBxp59EH5tam6ykVPo3rpdpYR+HAjbaHBeXPGIHcN7lh4g1bchKs0PECRz3+PkK0PoB2aOePBLwO/fmKE/IAyxhQDUrt+k35mTZWhGOqTyn9EuKhAwNM7uZzpn2bododBwBTm12dP0tQLYwqOPtbWmfEw29YMJ+oITRb0fHiqQfmtmX4a38B/AqG7i6UsU9vDXEtzHdigBYadPYYw9mWUTk/wapJzvfj/n8BD0cxHDSJRnElfCP9+7mOPOUz7AItA+QUEePk9nevINURoR/wUGQZBitgr7I8P8TY+fxezEwFciC+DniXdcyAfsYbfnfUzpf4Qk2urmInRmIiM2tW4xguvGKMzNgmWbCpIKWLodG1iE2EbL85jWHDjZpbSNq7PQraF7DJaKyJHvXebHuC9RUIdvajuJLsb37iIYmcvuHS6cOi2JjwnaOZsrXEl/NlDqfP1z2ZPeEp/iEbY4Q9f9oPucrhyS4BtCJR1TSy89E1JP73xVpZcbcryhNsxv7UrBaqMKkA3BZgZbGh1ZEkAjKhaegl+xd4sAdA3o9SXPoYvCb4WdyGMiMILO+rt4Z1qRnUr97v8uOFeihR/WrtxMNPLG7Z8njbhAs/VMUOKvQSZZ7DLNbVyIMFFqUlBXEenV8H3At8dYp0r/7VQ5edeKLKSXdMtz0ymZB621dyfs0QDxKjDdyeBKQbfLGNmxTzLBoV3BmlIv55y2uwFeHMxzVQwkrDrIEWceaISsK7EUZEg6n+MuwOoaxue0Da6YXJYt6gaTdHfcxTvKqBOULWg4d7CUBFQmFNrXkw== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 06e5f7a3-2916-4de8-682d-08d9fde0d9c0 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 13:14:02.0840 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OZkyZX73YdgPScEvEXM0hXo0mwW2WeVI2JDduNdHMtD5bKIZHpW/RlDU8q56UTqbYKP8QcJjgk5Ja7d7biKyhPwzi7HYhGsl/NBETGPtNjM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3142 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10275 signatures=686983 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203040072 X-Proofpoint-ORIG-GUID: tX19RxmE3-2sSlCV6nSCWR8qXg-IITla X-Proofpoint-GUID: tX19RxmE3-2sSlCV6nSCWR8qXg-IITla Cc: Jiapeng Chong , alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, Pierre-Louis Bossart , Takashi Iwai , Mark Brown , Ye Bin X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The "adata->pdm_irq" variable is unsigned so the error handling will not work. Fixes: 87d71a128771 ("ASoC: amd: pcm-dma: Use platform_get_irq() to get the interrupt") Signed-off-by: Dan Carpenter --- sound/soc/amd/renoir/acp3x-pdm-dma.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/amd/renoir/acp3x-pdm-dma.c b/sound/soc/amd/renoir/acp3x-pdm-dma.c index 88a242538461..8c42345ee41e 100644 --- a/sound/soc/amd/renoir/acp3x-pdm-dma.c +++ b/sound/soc/amd/renoir/acp3x-pdm-dma.c @@ -399,9 +399,10 @@ static int acp_pdm_audio_probe(struct platform_device *pdev) if (!adata->acp_base) return -ENOMEM; - adata->pdm_irq = platform_get_irq(pdev, 0); - if (adata->pdm_irq < 0) - return -ENODEV; + status = platform_get_irq(pdev, 0); + if (status < 0) + return status; + adata->pdm_irq = status; adata->capture_stream = NULL; From patchwork Fri Mar 4 13:15:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 12769091 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C17ECC433FE for ; Fri, 4 Mar 2022 13:16:51 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1161A18E4; Fri, 4 Mar 2022 14:16:00 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1161A18E4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646399810; bh=Kqm3fs4QEjHyEvgtcKu3V2lcLTsUJQjiZXcQC/KeCoY=; h=Date:From:To:Subject:In-Reply-To:Cc:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=THJKWxFxOKocAXqDPYu6PIvdhkUwPT41a6VppkuMxzWREnIlqBkZeU/P2k0j28RG2 j4jnrIqlmF0uSjxKy+sJ/gF7W8IERXI7810XjX8fkYBQxY/SqYj+FkYApFgeTcvH80 qCD4HjHc95q7vLwRsKJo54JBOOQYkPI0nxxCHMj0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id AD6C3F801F5; Fri, 4 Mar 2022 14:15:59 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id DDC94F80311; Fri, 4 Mar 2022 14:15:57 +0100 (CET) Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4BE10F800F2 for ; Fri, 4 Mar 2022 14:15:54 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4BE10F800F2 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="jTVQ/tV4"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="K8hbnpGb" Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 224A9Lae028272; Fri, 4 Mar 2022 13:15:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=eY1gZ8UbbjgFCDtXaW85iIDld65zwW49KhHxgCBcH0I=; b=jTVQ/tV45KP/M4+yCSLTNYuAJ+QEprRpYupvAGj1Akn4/ppCsJVZtthsp7aoMUXBvsXL 48G713XnO3xLNFUthSTFlDLDJiMSuMc1U5yP82/bCKcmoe0473aV/6V/h2UH1ee2fxd6 AoU3wT8E9BoYaNrBaVnO8Gxf3RNn4uN1RGiY9p4kssD04FBqJGXEPUGprFEepV9IFexA P+YdH99pSCWcyYh6abu7tsXelxIQkeX5lgAR6GRe6+orJDWB3ANiDFqF57tam86S+RDe deoQoAt+gnbNJaE5cf59twYn2T/or+Rgyx83d/9JCi1F5sXGhze5uxKizMHL1JwUhTho wQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by mx0b-00069f02.pphosted.com with ESMTP id 3ek4hw1r37-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 04 Mar 2022 13:15:53 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.1.2/8.16.1.2) with SMTP id 224DC8Nl045150; Fri, 4 Mar 2022 13:15:51 GMT Received: from nam10-dm6-obe.outbound.protection.outlook.com (mail-dm6nam10lp2107.outbound.protection.outlook.com [104.47.58.107]) by userp3030.oracle.com with ESMTP id 3ek4juafvy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 04 Mar 2022 13:15:51 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=URX3HbCH2nneibi1FKWhu9EQUAe1jxK041gs0SUPSfzvdF64GrXNTqICl+9Y0w75oubmBUd7knDH0XlCs+vPvwvLinfxlX/tU60JRiHgogDZz65CuTF6A9Xj6EpV81msRoEeElHDHm6E8x27it/475fmzuqltq4fJ1bjgVFOhoPIiIXUyesymzggs2QLj1ONwHQwy97kBdR5m7FhaEi1E265LwUip5hbBcW2Fmn1m/DxTo03Iirzpa7+G93tp+NK/+/YB/y9a+kaQ7XI5HX1TtpngW0H4oLgI3+kmRR7iMniI/4fRwtD8UU+luntdbDD09KH7aQPFjVbbMtZBObEHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eY1gZ8UbbjgFCDtXaW85iIDld65zwW49KhHxgCBcH0I=; b=JXGySqR4alVMf2mshZi8oLWLZEAJDRP8xZE6AtI8ccev2E8YTyqB9iL2lBGL2Ibi9dUYaHoDWhSuO6IzOn97QpUk8O/eX2NuIFbu8LP3gBrmc6DgmPz3nbjr0Ne8nPvc/0uwL6YiUnB6VCDwytlnPjEXn7ZyC91RaE+8LMTW85diMmrmH8JOamfeZPrE30luquQPOKcL1RF073qNwsSDz7t/U9wDeuY6bN+1zi8LI8by+hYkKG5+Uwa+BpXqqDI5FpfAvn056Q+tC1aFYdPq83h7G0I0O36cma1oUyDwCcAPckoM/lZT4PyzM0a5fRlVVMROJ9L8edZBnJLxnaOgvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eY1gZ8UbbjgFCDtXaW85iIDld65zwW49KhHxgCBcH0I=; b=K8hbnpGbNxPrFsT8xGGcfTCoq+nxt6QPK0ICbDzuFUe+XGf+mlp9KFt1LCKftyMuGSIgbVX+Jo65/V97neb/fZqBCjDhzGTz5aKOtIfOjKIg7xRQPLDIYy7yp7YDTl1tXHwghV1itKSxEkPyQEGqbkX/SrN524rHJsy1+IkW3l0= Received: from MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) by DS7PR10MB5117.namprd10.prod.outlook.com (2603:10b6:5:3a6::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5038.14; Fri, 4 Mar 2022 13:15:49 +0000 Received: from MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::2c3d:92b5:42b3:c1c5]) by MWHPR1001MB2365.namprd10.prod.outlook.com ([fe80::2c3d:92b5:42b3:c1c5%4]) with mapi id 15.20.5017.027; Fri, 4 Mar 2022 13:15:49 +0000 Date: Fri, 4 Mar 2022 16:15:34 +0300 From: Dan Carpenter To: Liam Girdwood , Meng Tang Subject: [PATCH 4/4] ASoC: amd: pcm-dma: Fix signedness bug in acp3x_audio_probe() Message-ID: <20220304131534.GD28739@kili> Content-Disposition: inline In-Reply-To: <20220304131256.GA28739@kili> X-Mailer: git-send-email haha only kidding User-Agent: Mutt/1.10.1 (2018-07-13) X-ClientProxiedBy: ZR0P278CA0141.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:40::20) To MWHPR1001MB2365.namprd10.prod.outlook.com (2603:10b6:301:2d::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1b98e40f-ebfd-4192-4b5c-08d9fde119a7 X-MS-TrafficTypeDiagnostic: DS7PR10MB5117:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ESCXnAVY4GkktGYGTJM1bRZV/0QJPbFIEgw56G+O0ei2KVwLi2bwMOiZ2WHRr3s18/80YyMsKhrdiqXwrsFHWuHZ9jZ4V5Ftd4StLL5tbnNn+qvh20TgNLfNZmoDV/90KR8eKF10x7gbHyYJBOKRtnvjkrqsrx1zPwZ17mypGpClPJr3HkLHfsRSRmx0pj9/o4md5CAIgGn5WB79hVLa1QWSHA1m674h2KpRrf1NBIHL4l/tdHf1VCVtEoXYGzR5RZZTHabvi9nTCNmh5nxB8YN2Z2FNDdY+bBTzLedK8V+CE9etJ+Jo8xvePuw7ZPUGmbu/uI8hwxXT+dDIuKOUli2SEd064r7qECFjGPrTVQRF4rodxtFOpUMFoTpsrpAb1/CC04w23El5qwX/U4csxQLECufDV/fkAaZ1yJfh+2TAoy/YvIkZXW0bTtkrapzDJJle+p7U17ycXtHC4wxKSsDdOzM3yjhhawyhIqW1BrzAqafYHN9NnGWDuWlpOzjnYw4vj1mFhH8JUYQjhmNfiL3prUL4Y4dh3YbibUIPUJgjyZgbIPDKksgeOreGHfMDUFK7dqUNZ5W6ioCoVwUmbLXZK3tb2GGjPGvGmBtG+/7G4sVi+taOkvLaf60GWLvHvG0yOdC/LtzLwlzCvH8rUYY9aZfPzzM6HsKyaSjTl2cEkPF7+3iJX6fXEKXP41Bw3+9Z4ALxcdsVV2v6Upo2sw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1001MB2365.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(7916004)(366004)(54906003)(33716001)(4744005)(316002)(66476007)(66946007)(66556008)(44832011)(38350700002)(1076003)(38100700002)(5660300002)(33656002)(508600001)(6506007)(83380400001)(6512007)(9686003)(8676002)(86362001)(26005)(6666004)(6486002)(186003)(4326008)(52116002)(8936002)(110136005)(2906002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +4iUGbkEbLHRBYhH7LvQbiVJwYb6QDQG9ab/b0So7hzOqSUf8RFHc65Au1inYPINk4wVmxMhDF99Frzs8So7BVh4+mYvs1lJC79oFiSlj1ylbCoh4McY2NtkoDZG5JK0MSu6fo735k+aVV4tgJXXdFYHMZZy7jEE13n4r4hrRoggrefP+c/QCcg9bvYRKhpFVrPva+b53c3CLoC7NufgT2+ccPw3ywGSrHg6vsITFSzuNvyufsV5+3YRnu9LMquW8+ew3P17mSeV5oxXEhQK2+5v57DdUF2Y3jRxlujXNb2P4X7Fezn5t8tP+dRisi/CJE7or0EIpG9wJNdCILu2PUiAiiCMLUIPIeiMMr+nQ7+NZr3B1ntvZHzQAKWHBQncFKF+EyDJeAqhqwMRL/HnJYI8k7+P+PV7vFIR4uoLON99z31k4hmPA5c7yPRb0/qpZotHw5O3SfQ2vx/ATHM3viQVZ1TGjIE9lNup7ax0W6wgouVC/N7yFRZOQWj0BnpTwNYXiLcNtHsz81JhY43O1s3mN19rP7Czf/T7803YRhSI+jZpBcZeOkeBvoTm8ak2Oc5CViJ1nz8M+lhcmvCnq3iC/DKMmRO/qKVnX/kCxQHKiwW4RLTVLX5Y7u58YVZf+Z9GA/2LRu1aqT6eE/8ENC3KErUgpZm+IT6jzvFgQefbEnDqnM36KKLS1cQm8tJuNj+vOb/EdoO5CjWFCfRTvw/fBj5oB5gqdlwF7+MBcT7hfGiuTP9E/w+A4onNcte2BCk1nJTyrc36FdJ57SMSojBA+D4kDVTTPNmzD86djLSPLhnnzUCVdOIKTdq0wsSpqSax9dpRBMioK8r/rz8Yd3m6rQaJlZpPmDl0+k9bCHvagdz519SXqazZY/zvyRvXbDrRNQBl8aw/zQPdfhKwr8zOdIIK9hrnOlLNOYxHV/OyD4fSo1+ppP4FPoc3bE2BCUGm1DfZS0mD3NTsQRjJyV3VUA/6YvbnCQSuSXnjPG/GKz+LFuKR8ioVmSxnLGCTsgSy2anW5A74RuXdPazeeL2NwYGv9QUQy/hqaAVE/lixyf+5gd6AbKzVr4kiYXBumAd0esuRXKwz3UPKTv64zcfzdZ0XIYwqBMQtBd7wVI++XA9RTKfrhFqGu62HM5zMf+AuNy2AqcICjzjPP3S/l+Lfx1UcYT4qsQzoQICoGwYSqmKajXQ7E87TFsxbeFMIqliw1RG+KlrZn8X5cCsaw4K5gUg0EynvilPlw47I6pG4UgzB3o3YIXzIs5KEz29WZNhA/ftqGBaZZgRhqm7xMlnjqMOL8QGL90v66UvuCRk8HAYCYd/AqyTrDXT5qLPqw/s11gH79P/t5iO9l0A+Jip3y+qpyg3FrNNUQXU9sdpW2zpDHMoUfZX2Rrm1i9lex1tRrYjjAvOTaE+HrD5VAXwxqhfVHMP5zflm1Bhx9/neKRUz4U1R2Ie8KEY7/1+hG90MvVVsV0+Vw/sIpwg8vX3tKmps1S3vgOXCKfkiqTug1rppo5ip2oPB7nWNSzjCyfjtfqKs3KWVlQEf2smne6XKdIrUF1ucui5MsBlFDXjgy6+p4ixo/4eniWgl8oLrspUKMeRMPffXw5t+9Ah6R5ECSuA0IsIFNZ2HaJbh59PxK06efTX733dvwOkTLFhYJhapxyFxYPEDWqPweCxLYQ== X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b98e40f-ebfd-4192-4b5c-08d9fde119a7 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Mar 2022 13:15:49.3404 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Jn7F7wYltrfFU+8zx5gTbdZHcwsRl6ggUOWQ7uN5gZjhr1ufa69x/kmMT8iAFtXAoGUSHtQyD8nEh6QOeiQvP2vgwtyI49hRcZGdcH5mOug= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5117 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10275 signatures=686983 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 adultscore=0 suspectscore=0 mlxlogscore=999 malwarescore=0 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000 definitions=main-2203040072 X-Proofpoint-ORIG-GUID: 6VDcKY3VjnEFbkDhmvV2NgLPmja5v7gb X-Proofpoint-GUID: 6VDcKY3VjnEFbkDhmvV2NgLPmja5v7gb Cc: alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org, Takashi Iwai , Mark Brown , Vijendar Mukunda , Gu Shengxian X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The "adata->i2s_irq" variable is unsigned so this error handling code will not work. Fixes: 87d71a128771 ("ASoC: amd: pcm-dma: Use platform_get_irq() to get the interrupt") Signed-off-by: Dan Carpenter --- sound/soc/amd/raven/acp3x-pcm-dma.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/amd/raven/acp3x-pcm-dma.c b/sound/soc/amd/raven/acp3x-pcm-dma.c index e4f8dbf0d11d..6aec11cf0a6a 100644 --- a/sound/soc/amd/raven/acp3x-pcm-dma.c +++ b/sound/soc/amd/raven/acp3x-pcm-dma.c @@ -394,9 +394,10 @@ static int acp3x_audio_probe(struct platform_device *pdev) if (!adata->acp3x_base) return -ENOMEM; - adata->i2s_irq = platform_get_irq(pdev, 0); - if (adata->i2s_irq < 0) - return -ENODEV; + status = platform_get_irq(pdev, 0); + if (status < 0) + return status; + adata->i2s_irq = status; dev_set_drvdata(&pdev->dev, adata); status = devm_snd_soc_register_component(&pdev->dev,