From patchwork Tue Mar 8 02:01:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12772889 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AB7AC433EF for ; Tue, 8 Mar 2022 02:03:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=4GCeYV+16wcxy5FVVFW0hBl2d9ltljZD0UJcF5Q+Kyw=; b=0W2zbMd479p3xS ozNTXSqsiOl3dtV9AafnhXOYyAgaJ0kNEV7e8ZmdCcpih2MRgpl5ZyZdAJlruaNuf81RPPfJKYQV/ 1u8opzyq7JIYO7XuLJUjuaq7eHSprwMe9jJ7X6/3Lo/3OLTav/y8g4g0R+j2fDpyeWf8p79W2xOuN +vBfdujt2Woi02oDkZp8UgAq307UIUgaUed1Q+FK6IlNVXelIdWNxJJTEeeO89Yl9oEyqpG4BHxoN 6GQYqeiDxmXMAo61fIG5NARlf10tK79PdAH4R43Xd6fLrLfHMrd5dE5nFNvIFCCeU7KWHbpmOxTwk DTnxJFUrQ5ItranndxsA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRPAj-002P5y-Nf; Tue, 08 Mar 2022 02:01:57 +0000 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRPAf-002P56-N7 for linux-arm-kernel@lists.infradead.org; Tue, 08 Mar 2022 02:01:55 +0000 Received: by mail-pg1-x52f.google.com with SMTP id q19so2503759pgm.6 for ; Mon, 07 Mar 2022 18:01:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id; bh=/vVnL9eYRSzGukw8SFc4KUz6RxUiiMNRCtt3A6IgWHI=; b=WPJQz9gUASBXedyL88smBZOyRA9JuY+a6vfbE+eUe337T1Tdam2Tf3OdpOD35A7R70 n4AZomhDj5LMij9G0rEak9DF6iZxzULyMTsFYg491ifyShip8mRnyv9lhVKxiuoAE3+w B1ahPQ2lO+Jb7T7wpPIbsWkHqTnRpEIcpnkTegl7jdwBLN/EhPOqAajySUM41nn4Eoq5 3kOr3qn7HUpednBBnSY+H672xEHFyQK4x7Kk205sEjbyxfxQZO4EhM7QlIIFBXE6gVmK T1rRrXRKxl9glJm7PIf4pkFV+AK/lQ7JP+fTPNh87KLBSdJmKwu7tQ+tn5Sh4mnUfwlF LkLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id; bh=/vVnL9eYRSzGukw8SFc4KUz6RxUiiMNRCtt3A6IgWHI=; b=SEtEiNIQRIjsNclthSGsb7PHyllYfBIwvcid0X5WC/L1ymiXm/ksf/uqf2ELdlYuhT bfHXWp9CfXGlS1vg/EkV8FRaMlQXNNIIQrdSYD6UWGKmTZp1C0znPHmi/gd7UiLec/Iw dPsTK6k77itvxMRQ1te1j4FXrMaePt0RMpYT/rrnqnkmN9g1HspmWKLDB7/lVdoz04yb 9fKQvB+wYqSfolSm/274uAOTKCzO1A4hHHZlJlVJnw0WQODs/YOViPW89Dg4y3eWt57/ q3AH37NrseAXoeKMbRCjtkjaWSmb08atV1scQzyHgolSrrUwbsDjF2KmeYGW5oTPbmcj j36A== X-Gm-Message-State: AOAM530yQcK6CzYM80VFEUgLLW9W6PlJY1IsioGpSFj7KflMwXNpsT0/ FMfrTvCTEwRK7RZzRbup/7A= X-Google-Smtp-Source: ABdhPJxCExbpTHk8a9vWWJJ96DNwpeeHzcqKYTbVm6C0ubr8FBGHGZ33z0smAzSg2JP/ol4UAJAeEQ== X-Received: by 2002:a63:84c1:0:b0:380:64fd:a2d4 with SMTP id k184-20020a6384c1000000b0038064fda2d4mr4690598pgd.51.1646704912369; Mon, 07 Mar 2022 18:01:52 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id pc17-20020a17090b3b9100b001bf88fe5edcsm393672pjb.9.2022.03.07.18.01.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 18:01:52 -0800 (PST) From: Miaoqian Lin To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Kuninori Morimoto , Miaoqian Lin , alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ASoC: mxs: Fix error handling in mxs_sgtl5000_probe Date: Tue, 8 Mar 2022 02:01:44 +0000 Message-Id: <20220308020146.26496-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220307_180153_788309_174C1195 X-CRM114-Status: GOOD ( 13.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This function only calls of_node_put() in the regular path. And it will cause refcount leak in error paths. For example, when codec_np is NULL, saif_np[0] and saif_np[1] are not NULL, it will cause leaks. of_node_put() will check if the node pointer is NULL, so we can call it directly to release the refcount of regular pointers. Fixes: e968194b45c4 ("ASoC: mxs: add device tree support for mxs-sgtl5000") Signed-off-by: Miaoqian Lin --- sound/soc/mxs/mxs-sgtl5000.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/mxs/mxs-sgtl5000.c b/sound/soc/mxs/mxs-sgtl5000.c index 2412dc7e65d4..746f40938675 100644 --- a/sound/soc/mxs/mxs-sgtl5000.c +++ b/sound/soc/mxs/mxs-sgtl5000.c @@ -118,6 +118,9 @@ static int mxs_sgtl5000_probe(struct platform_device *pdev) codec_np = of_parse_phandle(np, "audio-codec", 0); if (!saif_np[0] || !saif_np[1] || !codec_np) { dev_err(&pdev->dev, "phandle missing or invalid\n"); + of_node_put(codec_np); + of_node_put(saif_np[0]); + of_node_put(saif_np[1]); return -EINVAL; }