From patchwork Tue Mar 8 02:47:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12772920 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92726C433EF for ; Tue, 8 Mar 2022 02:47:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238335AbiCHCsx (ORCPT ); Mon, 7 Mar 2022 21:48:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50896 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229906AbiCHCsw (ORCPT ); Mon, 7 Mar 2022 21:48:52 -0500 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 582F61D333; Mon, 7 Mar 2022 18:47:57 -0800 (PST) Received: by mail-pl1-x633.google.com with SMTP id 9so15800345pll.6; Mon, 07 Mar 2022 18:47:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id; bh=9+rs02y8/agiJlSLF4WllYH2sVrI0f+W4mxvW+9rYxo=; b=kOsYCvCHrcNK69cLsdd1syJuU5VrntMM29u88/Zofjp5wZ0p+JUKmRoTVMQuCXa5EP x1EAnf6nugh/jSQbzGEpRJSiSnJ8p5qzUNZGg0qMKgKo4evf+xy9phi/bG+nTb474El6 me7DarfDNuPG88ioy57rONUHHnJ1DO9/oQYWGcR/nFSrW/SPhT98Hv7xM+CDvqhFgqZw r4THfZcgwMDAL5lXLSV3ZTVK3bdKNkr/p/XNktZfJ5m3tCfQwogJiyKzdCd3tnEX3bNX 8qAeFmGjbb+94ETj4VE+pKUAt6AAZH+lBipxMNlk0Q+yP58CoYhhqoYwgukRW9SE288c 2DDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id; bh=9+rs02y8/agiJlSLF4WllYH2sVrI0f+W4mxvW+9rYxo=; b=MCC10rLY73dGPOr+UZ50gckzpI3N4kKHSjZG13Q2aQNB/V1aXUJQpSKRmLHfX15j9o ZYwJuBrhczNBrdrsODleLveR0LPMc3C60ZIKpo9AuE7spynJMa1xJdgiFGZFzryYvKSL sKJu3PNaknaIRd9P/Egrw0ZGwpu6rczdn+fUH2ag/TM+BuuUoHIr8a7auOeiILNy2Cq/ tPng7FxUQe0OAlsPjnNuYeeomNc2/42Kb1X+YmgYndmFYasKw5UcbuU7NkeBMifKTiNW 78iR6W7ZNNZYfm3dLLMGxzBjSbS+IWaEZvQGR9TnoZrdmRT6DBVvkXxo0AO2BsO+CZTX 4kYQ== X-Gm-Message-State: AOAM532OYVVfOWK1cc3dZswl+NASfygFI2idb/GRRCuQ1HDpJIgYw6oc nC3xh4BrNCbKay4zKzQP3Y4= X-Google-Smtp-Source: ABdhPJx5sigmWo+hcAj/lrzhaaBiN7D4kgyoa0sNOMynzTneLnudVl/LjKzXJwdeyHer4Chiqm1Bdg== X-Received: by 2002:a17:902:e2c3:b0:151:d68e:cd0c with SMTP id l3-20020a170902e2c300b00151d68ecd0cmr13249158plc.69.1646707676850; Mon, 07 Mar 2022 18:47:56 -0800 (PST) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id g18-20020a62e312000000b004f6fe0f4cf2sm5565404pfh.102.2022.03.07.18.47.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 18:47:56 -0800 (PST) From: Miaoqian Lin To: "David S. Miller" , Jakub Kicinski , Michal Simek , Arnd Bergmann , Andrew Lunn , Miaoqian Lin , Michael Walle , Lad Prabhakar , YueHaibing , John Linn , Grant Likely , Sadanand Mutyala , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] ethernet: Fix error handling in xemaclite_of_probe Date: Tue, 8 Mar 2022 02:47:49 +0000 Message-Id: <20220308024751.2320-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org This node pointer is returned by of_parse_phandle() with refcount incremented in this function. Calling of_node_put() to avoid the refcount leak. As the remove function do. Fixes: 5cdaaa12866e ("net: emaclite: adding MDIO and phy lib support") Signed-off-by: Miaoqian Lin Reviewed-by: Andrew Lunn --- drivers/net/ethernet/xilinx/xilinx_emaclite.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_emaclite.c b/drivers/net/ethernet/xilinx/xilinx_emaclite.c index 519599480b15..77fa2cb03aca 100644 --- a/drivers/net/ethernet/xilinx/xilinx_emaclite.c +++ b/drivers/net/ethernet/xilinx/xilinx_emaclite.c @@ -1183,7 +1183,7 @@ static int xemaclite_of_probe(struct platform_device *ofdev) if (rc) { dev_err(dev, "Cannot register network device, aborting\n"); - goto error; + goto put_node; } dev_info(dev, @@ -1191,6 +1191,8 @@ static int xemaclite_of_probe(struct platform_device *ofdev) (unsigned long __force)ndev->mem_start, lp->base_addr, ndev->irq); return 0; +put_node: + of_node_put(lp->phy_node); error: free_netdev(ndev); return rc;