From patchwork Wed Mar 9 20:52:58 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Antony Antony X-Patchwork-Id: 12775582 X-Patchwork-Delegate: stephen@networkplumber.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34AA1C433EF for ; Wed, 9 Mar 2022 20:53:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235370AbiCIUyJ (ORCPT ); Wed, 9 Mar 2022 15:54:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232954AbiCIUyI (ORCPT ); Wed, 9 Mar 2022 15:54:08 -0500 Received: from a.mx.secunet.com (a.mx.secunet.com [62.96.220.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7B06CCC72 for ; Wed, 9 Mar 2022 12:53:08 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 8E0E320569; Wed, 9 Mar 2022 21:53:06 +0100 (CET) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5EjbFNw-DdHs; Wed, 9 Mar 2022 21:53:06 +0100 (CET) Received: from mailout1.secunet.com (mailout1.secunet.com [62.96.220.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 13FA8201D3; Wed, 9 Mar 2022 21:53:06 +0100 (CET) Received: from cas-essen-02.secunet.de (unknown [10.53.40.202]) by mailout1.secunet.com (Postfix) with ESMTP id 0C75780004A; Wed, 9 Mar 2022 21:53:06 +0100 (CET) Received: from mbx-essen-02.secunet.de (10.53.40.198) by cas-essen-02.secunet.de (10.53.40.202) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Wed, 9 Mar 2022 21:53:05 +0100 Received: from moon.secunet.de (172.18.149.2) by mbx-essen-02.secunet.de (10.53.40.198) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.18; Wed, 9 Mar 2022 21:53:05 +0100 Date: Wed, 9 Mar 2022 21:52:58 +0100 From: Antony Antony To: Stephen Hemminger CC: David Ahern , , Matt Ellison , Eyal Birger , Herbert Xu , Steffen Klassert Subject: [PATCH iproute2] testsuite: link xfrm delete no if_id test Message-ID: Reply-To: MIME-Version: 1.0 Content-Disposition: inline Organization: secunet X-ClientProxiedBy: cas-essen-02.secunet.de (10.53.40.202) To mbx-essen-02.secunet.de (10.53.40.198) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: dsahern@gmail.com Since kernel commit 8dce43919566 ("xfrm: interface with if_id 0 should return error") if_id should be non zero. Delete the test without if_id, which defaulted if_id to zero. Reported-by: Stephen Hemminger Signed-off-by: Antony Antony --- testsuite/tests/ip/link/add_type_xfrm.t | 15 --------------- 1 file changed, 15 deletions(-) -- 2.30.2 diff --git a/testsuite/tests/ip/link/add_type_xfrm.t b/testsuite/tests/ip/link/add_type_xfrm.t index 78ce28e0..caba0e46 100755 --- a/testsuite/tests/ip/link/add_type_xfrm.t +++ b/testsuite/tests/ip/link/add_type_xfrm.t @@ -15,18 +15,3 @@ test_on "$NEW_DEV" test_on "if_id $IF_ID" ts_ip "$0" "Del $NEW_DEV xfrm interface" link del dev $NEW_DEV - - -ts_log "[Testing Add XFRM Interface, No IF-ID]" - -PHYS_DEV="lo" -NEW_DEV="$(rand_dev)" -IF_ID="0xf" - -ts_ip "$0" "Add $NEW_DEV xfrm interface" link add dev $NEW_DEV type xfrm dev $PHYS_DEV - -ts_ip "$0" "Show $NEW_DEV xfrm interface" -d link show dev $NEW_DEV -test_on "$NEW_DEV" -test_on_not "if_id $IF_ID" - -ts_ip "$0" "Del $NEW_DEV xfrm interface" link del dev $NEW_DEV