From patchwork Sat Mar 12 16:58:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Peter X-Patchwork-Id: 12778903 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B7F50C433F5 for ; Sat, 12 Mar 2022 17:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=uUIwHUU3S9cxxcEd+kqofVQozBuY9nQUcRK4cDZmc7k=; b=SoiEHJp1J52eQo lBgH0fMcJ4ShD3pjUIQAAJz0hxwGb5m6+H6zQ2wB9sGF98nU5Ld9NfkVTRPRgzDZrehvAHMcd//Qb Hav+/rgQkcxcPnIG+qE9mRIJ8wdxptjC6gK8cV8pdgbtUf67JksLdnLoQ+Iha0s+LpG220zJnk+JO gZNto21asSVe4jp8sVkMNZB0BHLGFFgXM6EYexIHRXMeLP2LoGhZ3wfZh+Gp1ls1WhG6XaqL9JEtu nBWKD9G2Jjlhv9TOrE0q1HIDzgsaL/Oj5bYzVpx++thV11yeycjenleArffH00dEJjkfbihG7A+A+ jFrg2x8EsVv9YtsSwOJw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nT55C-001cQr-26; Sat, 12 Mar 2022 16:59:10 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nT54y-001cO2-Q1 for linux-arm-kernel@lists.infradead.org; Sat, 12 Mar 2022 16:58:58 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 96D1E5C0101; Sat, 12 Mar 2022 11:58:50 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 12 Mar 2022 11:58:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=cc:cc:content-transfer-encoding:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=fm1; bh=3Z4lX7yd1Z+rbqj8SWtm2FLJJwtkYQaLa5pn68 7U3Rg=; b=CpaiZybiXJDaDndnp5Ecq5tk+LnWD6jBobM9gIb43584TA/OkiOcT1 dfGBGf/uhKpgQoBEfLfWJVpj/+P5hgyaPXaK1Q0HGliXfYYtCjw+FnIiSkK1mC5T NtIj4wyBc+W8QAVLN8Yw+2KerSe1ibizS9f/lu756Uwgevs7fxx2SqMxDrqPRR9O tCsjl4ixKxXFGMK8Z1xuSTRGxkpRaD2teMHgBC6p5EzbcfAz6PiAsiQM5ptIYcIy L60JlipNAYJ8+ByeSfIIXyyGbQ8gEWSOYGJJaeiFM3y1cf25ZPC4gdDHZjbsb8mH hHp7GfzvMXCzHaPPgkYgDTw8yXqj7sGw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:sender :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; bh=3Z4lX7yd1Z+rbqj8SWtm2FLJJwtkY QaLa5pn687U3Rg=; b=eHhMB8/fWiDJgkWcVdh/lWt+g8LHoUbSo9xVc5qpraU0j R8kjS3l43r5HE627DlYAGKjIb+mxNnwqyjcC+me2d25SS0aNDSVW1ZLfG29ucecF t59oTbvZ6TNxl45YB+/Gr0Lqyxxvqm0EVeQkG7IAlnD96bAM/PBg8cvQqUxBh5Kp g6RqmR3Z3VxSnrpzbC8ecTrErseF2775Kpdpd9DqteQDtoCDUjS5y5LDQUbj51tu jkjzNDagq38Ng2WtDZRPgbIwCZC/mSqyfy3GICFikNYoOeh8Uh0UJH0DQBuScw8B VF74FNTkNzerACVtI19nM51U1MHNJ+1HRj2i3JoHA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddvgedgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffoggfgsedtkeertdertddtnecuhfhrohhmpefuvhgvnhcurfgv thgvrhcuoehsvhgvnhesshhvvghnphgvthgvrhdruggvvheqnecuggftrfgrthhtvghrnh epudffjeekveelgffgkeekveejffegkeejtdejtdeftefhleduheekhefgueetkefhnecu ffhomhgrihhnpeguvghvihgtvghtrhgvvgdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsvhgvnhesshhvvghnphgvthgvrhdruggv vh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 12 Mar 2022 11:58:48 -0500 (EST) From: Sven Peter To: Srinivas Kandagatla , Rob Herring Cc: Sven Peter , Krzysztof Kozlowsk , Joey Gouly , Hector Martin , Alyssa Rosenzweig , Mark Kettenis , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 1/2] dt-bindings: nvmem: Add apple,efuses Date: Sat, 12 Mar 2022 17:58:36 +0100 Message-Id: <20220312165837.40687-1-sven@svenpeter.dev> X-Mailer: git-send-email 2.30.1 (Apple Git-130) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220312_085857_043920_6F2C377F X-CRM114-Status: GOOD ( 11.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Apple SoCs come with eFuses used to store factory-programmed data such as calibration settings for the PCIe and Type-C PHY. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Sven Peter Acked-by: Rob Herring --- v2 -> v3: - added r-b tag v1 -> v2: - fixed indentation issue pointed out by Krzysztof Kozlowski .../bindings/nvmem/apple,efuses.yaml | 50 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/nvmem/apple,efuses.yaml diff --git a/Documentation/devicetree/bindings/nvmem/apple,efuses.yaml b/Documentation/devicetree/bindings/nvmem/apple,efuses.yaml new file mode 100644 index 000000000000..5ec8f2bdb3a5 --- /dev/null +++ b/Documentation/devicetree/bindings/nvmem/apple,efuses.yaml @@ -0,0 +1,50 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/nvmem/apple,efuses.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple SoC eFuse-based NVMEM + +description: | + Apple SoCs such as the M1 contain factory-programmed eFuses used to e.g. store + calibration data for the PCIe and the Type-C PHY or unique chip identifiers + such as the ECID. + +maintainers: + - Sven Peter + +allOf: + - $ref: "nvmem.yaml#" + +properties: + compatible: + items: + - enum: + - apple,t8103-efuses + - apple,t6000-efuses + - const: apple,efuses + + reg: + maxItems: 1 + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + efuse@3d2bc000 { + compatible = "apple,t8103-efuses", "apple,efuses"; + reg = <0x3d2bc000 0x1000>; + #address-cells = <1>; + #size-cells = <1>; + + ecid: efuse@500 { + reg = <0x500 0x8>; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index e127c2fb08a7..24deb0e8f731 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1771,6 +1771,7 @@ F: Documentation/devicetree/bindings/arm/apple/* F: Documentation/devicetree/bindings/i2c/apple,i2c.yaml F: Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml F: Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml +F: Documentation/devicetree/bindings/nvmem/apple,efuses.yaml F: Documentation/devicetree/bindings/pci/apple,pcie.yaml F: Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml F: Documentation/devicetree/bindings/power/apple* From patchwork Sat Mar 12 16:58:37 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sven Peter X-Patchwork-Id: 12778904 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88B6BC433EF for ; Sat, 12 Mar 2022 17:00:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=52+lcb9vIl8ldVE57pei5QxOl5wUExU+KMwt1OH+tO4=; b=ikJxEgCeXfrFWA KCLf8lXh8Xmov/hQIHU/uSojXrBIqk7vrBCSMm25J47hd+KTAmnrSltaf/0tiiG9toLodaQaLzKaI 5dhNmqAORdw1nZdaosBOZMDBbN+tgnGZs/EYJ2EPKpPQIloHPlZHHpxs1iB9AUIrRpXz4+wIpA3Cp dbB7G6W+fwupyYMKzrX16RQvFZAf2sWQomDXkAcbqMrnGwe93MT67vwI1g+dcSYNFFiZdBhyvHdLj mCh4Xzq1SZwPFWfvXvi66ej9At8rHc4XRE7HTrgDpaFvPv4MgOv17OWtssANm6Vo4r/bZFss2aDqe LDE3CKQPNYreNSW92OwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nT552-001cP8-QG; Sat, 12 Mar 2022 16:59:01 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nT54y-001cO3-RS for linux-arm-kernel@lists.infradead.org; Sat, 12 Mar 2022 16:58:58 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9872D5C00F3; Sat, 12 Mar 2022 11:58:52 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Sat, 12 Mar 2022 11:58:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svenpeter.dev; h=cc:cc:content-transfer-encoding:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=yPyexJVh3nRaxA wi8JDvJedOH1n8cn7H4dOuQSm5pMQ=; b=mP3A81rmOnDN954FUwfziId5V4zNcy EUBi5wuMsyK/0cn8QwDAfUkuGgSv43dWV2mdg9RJexoFxGHk04xWCdZJWRm3v7DQ F3Qsr2yB/ZninI302Ne3aK9u5d+HsonemWLIa7UBbLfxMbF8qbRJmABn1fOHLC3L oxWZA+oGD8skHbPnUwpXHL5Jeqy/kGIaH2QJVHBpnNhTsL4hf1vQQNTmOcm00Zy+ +4/RXVTxtKyTIiMIzhHGGCUsGGhOvbtunBFChbxTyk2/nwStDMeu79mJEh/nu8jh t1mWHm/QQ60igh4dvscBEx6uA6Yz2pb11vu/MiPcEOUJgnET3BQ9Ma+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=yPyexJ Vh3nRaxAwi8JDvJedOH1n8cn7H4dOuQSm5pMQ=; b=c7JItLhFUGX2o/he+5Vfj8 xBNZbhb543rnEkf/0ViawMFKWy8QNFEBtSKK7ILjpIbODXHy6dbfCKLxljr6gfY8 4P8GWmF5x/+peBz0SE8pNyU4DVOKQJQ9lvq3L3OtGQ/5D3IBmlnMuIMQb7mnG6/X 7shJmPSobzkP+XV9tsHjWwUDHqmyk6HLCd+O4xJ7K3BwdQLT8EnU77u+6iVwtOgn TstuKi9XP8LeLNcKw2RAzHJeJ2eUjCV51Zor1aa/19fTXV11UervhnZEV37le6M1 KEu4suaxcGusVSTx+HsyH2YsrMFZabTz6TuDr9FdMnBlA8Wsrby5XU61LCFBJMVw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddvgedgleehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefuvhgvnhcu rfgvthgvrhcuoehsvhgvnhesshhvvghnphgvthgvrhdruggvvheqnecuggftrfgrthhtvg hrnheptedvkeetleeuffffhfekteetffeggffgveehieelueefvddtueffveevlefhfeej necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhvvg hnsehsvhgvnhhpvghtvghrrdguvghv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 12 Mar 2022 11:58:50 -0500 (EST) From: Sven Peter To: Srinivas Kandagatla Cc: Sven Peter , Rob Herring , Krzysztof Kozlowsk , Joey Gouly , Hector Martin , Alyssa Rosenzweig , Mark Kettenis , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/2] nvmem: Add Apple eFuse driver Date: Sat, 12 Mar 2022 17:58:37 +0100 Message-Id: <20220312165837.40687-2-sven@svenpeter.dev> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20220312165837.40687-1-sven@svenpeter.dev> References: <20220312165837.40687-1-sven@svenpeter.dev> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220312_085857_043401_A6A2EE35 X-CRM114-Status: GOOD ( 22.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Apple SoCs contain eFuses used to store factory-programmed data such as calibration values for the PCIe or the Type-C PHY. They are organized as 32bit values exposed as MMIO. Signed-off-by: Sven Peter --- v2 -> v3: - removed .owner = THIS_MODULE again since it's already done by the core as pointed out by Krzysztof Kozlowski v1 -> v2: - fixed sparse warning about __iomem by introducing struct apple_efuses_priv as done in other nvmem drivers - make sure the driver actually works as a module by setting .owner to THIS_MODULE and adding MODULE_DEVICE_TABLE pointed out by Joey Gouly MAINTAINERS | 1 + drivers/nvmem/Kconfig | 12 ++++++ drivers/nvmem/Makefile | 2 + drivers/nvmem/apple-efuses.c | 80 ++++++++++++++++++++++++++++++++++++ 4 files changed, 95 insertions(+) create mode 100644 drivers/nvmem/apple-efuses.c diff --git a/MAINTAINERS b/MAINTAINERS index 24deb0e8f731..a93318a1dda8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1781,6 +1781,7 @@ F: drivers/i2c/busses/i2c-pasemi-core.c F: drivers/i2c/busses/i2c-pasemi-platform.c F: drivers/irqchip/irq-apple-aic.c F: drivers/mailbox/apple-mailbox.c +F: drivers/nvmem/apple-efuses.c F: drivers/pinctrl/pinctrl-apple-gpio.c F: drivers/soc/apple/* F: drivers/watchdog/apple_wdt.c diff --git a/drivers/nvmem/Kconfig b/drivers/nvmem/Kconfig index da414617a54d..bba29d1aec96 100644 --- a/drivers/nvmem/Kconfig +++ b/drivers/nvmem/Kconfig @@ -300,4 +300,16 @@ config NVMEM_BRCM_NVRAM This driver provides support for Broadcom's NVRAM that can be accessed using I/O mapping. +config NVMEM_APPLE_EFUSES + tristate "Apple eFuse support" + depends on ARCH_APPLE || COMPILE_TEST + default ARCH_APPLE + help + Say y here to enable support for reading eFuses on Apple SoCs + such as the M1. These are e.g. used to store factory programmed + calibration data required for the PCIe or the USB-C PHY. + + This driver can also be built as a module. If so, the module will + be called nvmem-apple-efuses. + endif diff --git a/drivers/nvmem/Makefile b/drivers/nvmem/Makefile index dcbbde35b6a8..1a8e54691d3e 100644 --- a/drivers/nvmem/Makefile +++ b/drivers/nvmem/Makefile @@ -61,3 +61,5 @@ obj-$(CONFIG_NVMEM_RMEM) += nvmem-rmem.o nvmem-rmem-y := rmem.o obj-$(CONFIG_NVMEM_BRCM_NVRAM) += nvmem_brcm_nvram.o nvmem_brcm_nvram-y := brcm_nvram.o +obj-$(CONFIG_NVMEM_APPLE_EFUSES) += nvmem-apple-efuses.o +nvmem-apple-efuses-y := apple-efuses.o diff --git a/drivers/nvmem/apple-efuses.c b/drivers/nvmem/apple-efuses.c new file mode 100644 index 000000000000..9b7c87102104 --- /dev/null +++ b/drivers/nvmem/apple-efuses.c @@ -0,0 +1,80 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Apple SoC eFuse driver + * + * Copyright (C) The Asahi Linux Contributors + */ + +#include +#include +#include +#include +#include + +struct apple_efuses_priv { + void __iomem *fuses; +}; + +static int apple_efuses_read(void *context, unsigned int offset, void *val, + size_t bytes) +{ + struct apple_efuses_priv *priv = context; + u32 *dst = val; + + while (bytes >= sizeof(u32)) { + *dst++ = readl_relaxed(priv->fuses + offset); + bytes -= sizeof(u32); + offset += sizeof(u32); + } + + return 0; +} + +static int apple_efuses_probe(struct platform_device *pdev) +{ + struct apple_efuses_priv *priv; + struct resource *res; + struct nvmem_config config = { + .dev = &pdev->dev, + .read_only = true, + .reg_read = apple_efuses_read, + .stride = sizeof(u32), + .word_size = sizeof(u32), + .name = "apple_efuses_nvmem", + .id = NVMEM_DEVID_AUTO, + .root_only = true, + }; + + priv = devm_kzalloc(config.dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + priv->fuses = devm_platform_get_and_ioremap_resource(pdev, 0, &res); + if (IS_ERR(priv->fuses)) + return PTR_ERR(priv->fuses); + + config.priv = priv; + config.size = resource_size(res); + + return PTR_ERR_OR_ZERO(devm_nvmem_register(config.dev, &config)); +} + +static const struct of_device_id apple_efuses_of_match[] = { + { .compatible = "apple,efuses", }, + {} +}; + +MODULE_DEVICE_TABLE(of, apple_efuses_of_match); + +static struct platform_driver apple_efuses_driver = { + .driver = { + .name = "apple_efuses", + .of_match_table = apple_efuses_of_match, + }, + .probe = apple_efuses_probe, +}; + +module_platform_driver(apple_efuses_driver); + +MODULE_AUTHOR("Sven Peter "); +MODULE_LICENSE("GPL");