From patchwork Wed Mar 16 22:55:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Herbert Xu X-Patchwork-Id: 12783245 X-Patchwork-Delegate: herbert@gondor.apana.org.au Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37906C433F5 for ; Wed, 16 Mar 2022 22:55:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229712AbiCPW4e (ORCPT ); Wed, 16 Mar 2022 18:56:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbiCPW4d (ORCPT ); Wed, 16 Mar 2022 18:56:33 -0400 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25EA11E3D2 for ; Wed, 16 Mar 2022 15:55:18 -0700 (PDT) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.103.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1nUcXy-0000Ly-NI; Thu, 17 Mar 2022 09:55:15 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Thu, 17 Mar 2022 10:55:13 +1200 Date: Thu, 17 Mar 2022 10:55:13 +1200 From: Herbert Xu To: Uwe =?iso-8859-1?q?Kleine-K=F6nig?= Cc: Simo Sorce , Eric Biggers , Linux Crypto Mailing List , kernel@pengutronix.de, Guenter Roeck , Vladis Dronov , Ard Biesheuvel , Philipp Zabel , "David S. Miller" Subject: [PATCH] crypto: arm/aes-neonbs-cbc - Select generic cbc and aes Message-ID: References: <20210913071251.GA15235@gondor.apana.org.au> <20210917002619.GA6407@gondor.apana.org.au> <20211026163319.GA2785420@roeck-us.net> <20211106034725.GA18680@gondor.apana.org.au> <729fc135-8e55-fd4f-707a-60b9a222ab97@roeck-us.net> <20211222102246.qibf7v2q4atl6gc6@pengutronix.de> <20211229110523.rsbzlkpjzwmqyvfs@pengutronix.de> <20220316163719.ud2s36e5zwmtmzef@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220316163719.ud2s36e5zwmtmzef@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Wed, Mar 16, 2022 at 05:37:19PM +0100, Uwe Kleine-König wrote: > > # CONFIG_CRYPTO_CBC is not set This was the issue. The failure occurs on registering __cbc_aes and the reason is that the neonbs cbc-aes requirs a fallback which isn't available due to CBC being disabled. I have no idea why this started occurring only with the testmgr change though as this should have been fatal all along. ---8<--- The algorithm __cbc-aes-neonbs requires a fallback so we need to select the config options for them or otherwise it will fail to register on boot-up. Fixes: 00b99ad2bac2 ("crypto: arm/aes-neonbs - Use generic cbc...") Signed-off-by: Herbert Xu diff --git a/arch/arm/crypto/Kconfig b/arch/arm/crypto/Kconfig index 2b575792363e..e4dba5461cb3 100644 --- a/arch/arm/crypto/Kconfig +++ b/arch/arm/crypto/Kconfig @@ -102,6 +102,8 @@ config CRYPTO_AES_ARM_BS depends on KERNEL_MODE_NEON select CRYPTO_SKCIPHER select CRYPTO_LIB_AES + select CRYPTO_AES + select CRYPTO_CBC select CRYPTO_SIMD help Use a faster and more secure NEON based implementation of AES in CBC,