From patchwork Fri Mar 18 11:17:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sherry Sun X-Patchwork-Id: 12785191 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D347C433EF for ; Fri, 18 Mar 2022 11:36:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IRRnLZhIQ8NdeopDIU/aWsFhpLk9G08VgvcOrTPfLkY=; b=eXM4GiXk+KFYXX 1CuGOl+2eYfSEk7/9rPJicf5TPwRV4BxcIys3FBzhgpOMJsWHE/e59QKczZH2b3/q1OKo1pHn6kKN B1oWeDMbA32u/L+3LWn7mkDspUxcJh3rK79KPY4oKJKHMr2I6WNhQn2hgBBd64O6UaIuBnqAnQmGJ zYpoPEx2JUfun7CHa40HAlJsRwZr6puWPZD+OnkbUFT/DrYcOdI6mAzXJFhOxUXZgP761SNE6PQfd 5kdoZm5cvetAGDvm8i5vXrfFWEHzRvxa2/iKiO7a+ucckuFVtZGEV891eGOfKIdpoP41ra5dVoepZ E9jIdm6+2+tp1+Y1r5rQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVAtM-001QL1-Pi; Fri, 18 Mar 2022 11:35:37 +0000 Received: from mail-ve1eur03on062a.outbound.protection.outlook.com ([2a01:111:f400:fe09::62a] helo=EUR03-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVAtJ-001QJn-RX for linux-arm-kernel@lists.infradead.org; Fri, 18 Mar 2022 11:35:35 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VvvaWFth86ra4ziMjczzUzZOEBG+pGnZAHqrL3JIiOj3K1meucr9hc/oymwhJSvjMEG1eMyAp95HODLZeXJIiB09PYHt4LWZPClitDcbPZQc+Sm3IXH91UUGBqxPAb+VDrXvabhiqJfafO7oe3/lLT75lCxyr1Z7gRTUiP+PUhxJjAxKkxiEN18weOGwU6siWUKIWnQ0JyYo/nOhDtmFmdvorr9r93iUpFcP1knY/vcsNe5FthMmfzWTplPZyH3WR5bcmOOZMI0Hue/ApmW7W2koNwl1GHf2wCOVHp24SgVglubYCL3zE63psrGI3DDKad81+wPDZi3yq2FewCmOSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kKjoFKGx2M6FU4PRdgOwVCiZQLgMB2E+LoRP5l+zZuk=; b=QRzZbfDoYgW9DIfzqAF17o3BfYS0qrOcRDfkhT4ZDAIAHNmAsnQPilrBUkfxkrbzdR1I6aaZqyFiqnVl7f+n3ktIWtMChvGxxqFKbW3zvlR5NLMRr08FNpQe0nOZ+jlvFk1JseeSECKf4jBtUbuUmI1xJl+2xQ3WgNitqaSVikM+iGqUNzLFVHrtM3yDb/9KMF49OpoN++4fzbQFL9aXQDGpEb4UDAH1oCj+cseMGk+BpoOAli1hOSXIvHVsch5qnwV+3/p1GtOoD1o0ELgLIh6Ohh2W8n+aqj2ag+vgX0m/IJe7ey3TwOgshbJ44m19fPEQPjj/ZL39S4HC1UDcPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kKjoFKGx2M6FU4PRdgOwVCiZQLgMB2E+LoRP5l+zZuk=; b=b6XCZYdCwWy+BRId7/51+YyEy9uey4GvXFg51ZHLJXXt6krdqdPBFl4FHTQz9/kxt/pT/5y7Zs0GDK0sUwAnJmiZvtPqGJthYL1MWrQ1mPOzURR12JzUZY5Vanvu7CIcXQFIn13kcRt90EPeuDhitBe7xXHmMMtzaT1YF/jw8rM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) by AM0PR04MB7108.eurprd04.prod.outlook.com (2603:10a6:208:19e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.18; Fri, 18 Mar 2022 11:20:20 +0000 Received: from AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::6972:1f59:5d1c:e557]) by AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::6972:1f59:5d1c:e557%5]) with mapi id 15.20.5081.018; Fri, 18 Mar 2022 11:20:19 +0000 From: Sherry Sun To: bp@alien8.de, mchehab@kernel.org, michal.simek@xilinx.com, tony.luck@intel.com, james.morse@arm.com, rric@kernel.org Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com Subject: [PATCH 1/2] EDAC: synopsys: Add disable_intr support for V3.X Synopsys EDAC DDR Date: Fri, 18 Mar 2022 19:17:41 +0800 Message-Id: <20220318111742.15730-2-sherry.sun@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220318111742.15730-1-sherry.sun@nxp.com> References: <20220318111742.15730-1-sherry.sun@nxp.com> X-ClientProxiedBy: SG2PR06CA0088.apcprd06.prod.outlook.com (2603:1096:3:14::14) To AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a6f639c8-e63d-4eec-e94e-08da08d148f3 X-MS-TrafficTypeDiagnostic: AM0PR04MB7108:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qk1uH7b9m9rACMamdRQmtjzZNNq61rg4TGXBuj28X2wIfQRZXJ2Qh6MJLg7IPn6y/eVsjvLYF59X7BOKL/6XGBqeOTdYNcPmqEEt8YqwCTiZeeGSkebl9HIZQs9pOjsIM/8fh8xKTvHGOPiubK6QH6PgzhJnb6GeuWynkpLWlK2b48PeZb5BeGZ64Un4pZImd22Pf329XKnNAkd8+5PR2un2N1G30QH3rx79bAxKsFEfdx3Adq9LCfdoncfCEEiXYtUWw5Evkc9Z4P9VEf/SA0jW6yyd/Bth23E9bGXFprtq0H5mye3O9ITBxObTfcQpho6SJWz0oRKMwlDcnG5Nh6SPANjYB7mWI+0JFTjzJ2n/aYxpvp2YB8vNyx9z9RVeG3C2GXRk8TTLU51N6zXfFSmN/EDCw3Q6jyKI2GRx/fpr3jfmqm/Sl6wF3/DGm4Bw3u2uRRf9smG0S7+9hMKthnx4BTOzL+UQUyiJ1WdxjcjGeWPSMLmYoCYY6KYMZeEQLfNzdiP6/uSEhlkg41f7V59xdxPDO79JzgoK45fk/Y5/4Imuh32ckYFG+O1sg1RtqbutrIn+TOrAJeXLa6zHqkRayXfP8qbmqhK6XC+P5fGpe2K3EQ21N3XtLrrC2QhaGXGYDvJJ/JYSK42UkrJ8CX7b83KD7aIMsfW+boW2oXXkVz5VYfe0VY7DCgaJBJKgbJo1AtjafCuhIZRgrrbliQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8404.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6486002)(4326008)(8676002)(66476007)(66556008)(66946007)(4744005)(6666004)(6512007)(44832011)(316002)(2906002)(83380400001)(36756003)(2616005)(26005)(186003)(1076003)(38100700002)(38350700002)(86362001)(508600001)(5660300002)(52116002)(6506007)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: e39DSRySM5lwSskYRhRiKHq7uZsnmAn3pd3kPnBuBT0yx6wMLFZUC5EwVQYnmxsy5p55VGYX9VMCpBmXhzEbLBMvKJXnyQdfd9o1E1yluEcOUMSZ+eE3cQUUnOwY+d+sYRUGrdbDNZoJ+bBIc0lhivnT1DKDHJ5Eq4aB2j3AkLEN1U4GywUOcjppEnuTsKWKNFwc68Ho8OaffTfju93xV+RtJdQIWgh3QpyNP+PSggIjumD9S0S90mklzUc2NHQeit2SA6vfYXq64gIiO6xKKaoOnyrE8Z1knQHOJ/VApvJrCVKkBl9tS50X0pYLI9RvoXlcjAki+FOuEXA34YbOkxEy35JMt7Q39cAZ2vD+2uu/GlT6rLItK0BEW0hOTmGWTXBB/WgZEtTttUmMHPSU9c/UdvnPCVvtkwFTHFSqnUGdOEFOkmmNS675Xmn9lD4j2jHgw5ikOA6xvhtMCKN3tItmRAiHMQlSfci1ThO08lUj9g4Uw70j4lzTRWYXbbQIkxl57MQIL8QANTwV4pONWaojRSVg4FrADLe9f+p5+beNOl4CSJztNI988GTCeoqqNhB6RM7v40NG7zqe2xXmU34Oc8lGswmzNEoUtnZg1XQq4HEJwGPGvsihvmOaYkxeghV7c3mEZKYswEg57JiyJy+4leTTzAie3Mze3BLjIKWwbIIAd5Ais5xZgpph8fRuOr5XoGMyvm9B5Rg9hjjqw9wXRtAdJUkKXmul3uIF+aSOziIbS89GUrQSBes/HbB7fhMaxj9NDkT2J32QoeBUBrzAjU3JdrjRwTDwZMmevb7o+Wmm2oe9KWh+NTFCIE+Ml+2M3RI5UYvsp98RvPSybql6I0KmRVPJt0BZzSgMgMHSDSGxNIjKwg7uX00yAY0Yp/IaNiAIWGsuMKcICzW9kL0FeRwKBSA8UKa4sEfwLYu0PbrQGvExxS8EJATmH/iLFoOio5M06K9lQLeRa+1aJmVdbnXojeM/jWIylcccvDXE/OPIIgWm6eJ6GwUa16XXa80Qhpa5mGMb+rKPrq2PkAQcxWlonIEG8UavcpMUOOYRGO1QuPjR+9C8zR5QI4/Pl6bOQaK4CRfjefOi8aAZVKvv4H5Y2xlK3MAfM/yrLEfg68itdL793uiOzCwRnKCT4XDyQqsRQzIu9CxRPZdmigQABpTgH7XCgDIkJOQuK/wUvWJIFG5WPQLVQiaAWHRzmOyQW7r2w59DoPqwPaD+h4Kum+Bd57Xg4fHnEX4utwQAl7vAjjGTvDkhb99EZcNWG1miKduc0oXzlBZtmlnuxQd2ZlTh6QFJypKXtojKrAwQTkG52CHL2Psk5+V9PpquLS+9onW59B4/uIzf5j1Yd3IMdw+JjvMtdRJmtxO/nDV+1HfuL6cq1fh02sjOz3cfXo2yUMRZba8i9z9Vyc+envrZSRS3fXbJFf2AjCX+6fV5xbT70MyQm8oyuDpJgBon X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6f639c8-e63d-4eec-e94e-08da08d148f3 X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2022 11:20:19.4290 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ousg/PiD6WsmVyf6Lnj/cS4fy5/ltYGDyTtE+pGJ1ubHP8Gcy80Ao7/UIC6PBFRLA1RtPoQY1MnOEESjreL3lg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7108 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220318_043533_901664_1D9D9132 X-CRM114-Status: GOOD ( 11.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org V3.X Synopsys EDAC DDR doesn't have the QOS Interrupt register, need to change to use the ECC Clear Register to disable the interrupts. Signed-off-by: Sherry Sun Acked-by: Michal Simek --- drivers/edac/synopsys_edac.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index f05ff02c0656..1b630f0be119 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -859,8 +859,11 @@ static void enable_intr(struct synps_edac_priv *priv) static void disable_intr(struct synps_edac_priv *priv) { /* Disable UE/CE Interrupts */ - writel(DDR_QOSUE_MASK | DDR_QOSCE_MASK, - priv->baseaddr + DDR_QOS_IRQ_DB_OFST); + if (priv->p_data->quirks & DDR_ECC_INTR_SELF_CLEAR) + writel(0x0, priv->baseaddr + ECC_CLR_OFST); + else + writel(DDR_QOSUE_MASK | DDR_QOSCE_MASK, + priv->baseaddr + DDR_QOS_IRQ_DB_OFST); } static int setup_irq(struct mem_ctl_info *mci, From patchwork Fri Mar 18 11:17:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sherry Sun X-Patchwork-Id: 12785192 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 56616C433EF for ; Fri, 18 Mar 2022 11:37:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=USU9exQua+iiYG3QZXpWvubSUVvh54hmMo7ZWpFGeMg=; b=tXB66f8ZOD8b+P ZdyD2tCvnl6bmL06B3MkTIV213XX4QuuVsiUa7Ii5wZZa+n/7N/GTi9/FxHQuB+vi73qd8C95K3ud KJk5o4v2TiFeB16d+HBMgCflJcCO/4f4pePQKmWVdunScBajPtVEH27WzirwMbpd9hMJujau0o6aA 74VU1LuNFd/x/5rGAxuNPXAmvtcR+bHejaZnCwNu+qGGftngADlU80UBMfJINk7QBo2dLJaE81zHQ 6kTzx28oQH4mFBorw9Z0Gb4c3hIjVov3p6NSv23Yw/9RCoRMBu1uI/UTxxOt+Ac+cYrA+Nb3YZrEr +jKkHOVz2MTmf46S1M8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVAtf-001QQf-Sg; Fri, 18 Mar 2022 11:35:56 +0000 Received: from mail-ve1eur03on061f.outbound.protection.outlook.com ([2a01:111:f400:fe09::61f] helo=EUR03-VE1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nVAtO-001QLG-Vh for linux-arm-kernel@lists.infradead.org; Fri, 18 Mar 2022 11:35:40 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NY571SHpXd9jN86bX/JdEWW7UPKyzCc9LkrxeO2/RtwBYjyhZoLHza+V3dpZ1GxyynXsaZvVSHQWSW/nBiafWwidS0C8o2cmUSakQRnGgmYRAFbZ91sY+vnpImrKGTJWFAzuTRprByV2zIXhhiNvV6J+tVZZ+tzNleFg8LohIlVpS5DEAOrR/NjXndnDo700dbvlybI5iEeui/lGKUml/PW6Ki9mc1lbJHXZKQshiIvoKAIVHJ7J9leWrhTBv/SfrZCu5dCXiQgohj3V2HFHCRoddmJ7P7J5quwzwyVCTMedRWSBSzK/5dguNEXde2mRhXAU6E5UOSNDxhhWdY3tqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pv9pWvDFcj0DiuD5mXdM3dLUCtqvlx59ezLfhJEp8nA=; b=jcXXoYXUjtX68QGxI76r9ahe22JlSnE1fCWaCzPATPtOIPCf4uZ5pjsWokliQwiOWvYr8JWO9FBsFMEoLsaU3m7iBtBBL/Rppj1tPoy4lHW0tEV2sZpgkVQ6XUA2kMNjPsib38D35SSWurO6QVGwTphOeWHHjZYAHkStE9xnEGvP9X60Juwq9C8947ijpaomdPpNuWE1XfUuHqjdOF/XbxAd89hzRlVcbZJkIRVr8XXLvP0UMKSnsBmcSJ7Qy7+Bdac9Cyz/0o2yYgJphdu1+E0Hi6DrjCuH1QgF/umQkpMpxboUMKhwyfy9SMCfi/77sdTDZNa33+CNNal2unZHBw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pv9pWvDFcj0DiuD5mXdM3dLUCtqvlx59ezLfhJEp8nA=; b=r+1N6720B4tQoGfEGm0QCQ7gVkV5xS6cp9lnomMX0ODYgSei2r3VCUQvFPyNK+cxxvYfT5/Y++3VWNrRESLq1jvCMYTa+TV6UJxZuwZCzelN8OTVyETxari7x0qNydf1USi8krhyeTH9Ll3eGSzzv1vESL7xK+pbKbnGbSjeKM0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) by AM0PR04MB7108.eurprd04.prod.outlook.com (2603:10a6:208:19e::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.18; Fri, 18 Mar 2022 11:20:36 +0000 Received: from AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::6972:1f59:5d1c:e557]) by AS8PR04MB8404.eurprd04.prod.outlook.com ([fe80::6972:1f59:5d1c:e557%5]) with mapi id 15.20.5081.018; Fri, 18 Mar 2022 11:20:36 +0000 From: Sherry Sun To: bp@alien8.de, mchehab@kernel.org, michal.simek@xilinx.com, tony.luck@intel.com, james.morse@arm.com, rric@kernel.org Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com Subject: [PATCH 2/2] EDAC: synopsys: re-enable the interrupts in intr_handler for V3.X Synopsys EDAC DDR Date: Fri, 18 Mar 2022 19:17:42 +0800 Message-Id: <20220318111742.15730-3-sherry.sun@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20220318111742.15730-1-sherry.sun@nxp.com> References: <20220318111742.15730-1-sherry.sun@nxp.com> X-ClientProxiedBy: SG2PR06CA0088.apcprd06.prod.outlook.com (2603:1096:3:14::14) To AS8PR04MB8404.eurprd04.prod.outlook.com (2603:10a6:20b:3f8::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8e160cf6-235c-4dbc-62be-08da08d152de X-MS-TrafficTypeDiagnostic: AM0PR04MB7108:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: t9cCF+xA6q+mbP+Za2GjTXJ3pydnTkDPUWCKMew4cNK66ZvlQ8p+mvtB43+/nsyPng6rUQ30tdXu6ulASx1RmEQxNpxkDZrQ24/YAny7WJbKmOaqFft9kL7Z052IS2kBgRfhLeO0IDWBadmcBQtY5ms5POdm4RpRxsDvhQrZH6JItdL0gXNl3KPU2vt8/y5OHcIw7N0yiqeZpD0mJHsisJI2aIaIrEtLCgHCBkbZYQI/U3chqPeGKrvXTtcHBimjNOvbZQ5zL7b31v+dyWjMcyugW3L2nnnos/H38BBBYJs7ZTbBvfB5UupiKUiYJQ2zU0iBecnu4UmpVwM6X8M7fK50KuQbD/iPiq1CY5ETRJStOcmvmUPw3zQq91DHnXWWoPnBwg2BeNL/tRpxq8Aljq/4f4FqNUnOAjb9roE+yQU4jvTJtcutOtL/Grmprye2KahTRA3KFLaHa+9JiMrq5+VEP5tX81hByTSPa43Ac1kJ3DL7EJ4sJ8UfPPMlHD3zbT7VDSLJ12ptczDcDqLUoezH6HYwH4DGXZLgLlIHzlj9W6WJDUpjOlYyvLGV1T44K1BnLuwOL2qD/UGEMFDdk92FQP/m/4Bdge1vo9uevwh4PGyiq2tyOWJlJT6SJH4s2OmjOEnzFDE54TRMROWQW5Mwsf7ezmmcyT+HWZIgrMN2V7uhUM/J/7oqxXBdB1BY2o8R1UUxpaMP2pWFHl4Xuw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8PR04MB8404.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6486002)(4326008)(8676002)(66476007)(66556008)(66946007)(6666004)(6512007)(44832011)(316002)(2906002)(83380400001)(36756003)(2616005)(26005)(186003)(1076003)(38100700002)(38350700002)(86362001)(508600001)(5660300002)(52116002)(6506007)(8936002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: YGCxf/iuIgrCt681isTM6dydTqmLM4lVPJjGDON9L9Al+5HZVSn1mStzoITmCUCOX8YhFgt5SMZ9KrpE8YCLhEy0b/WdwTOxRHzimDOU+e3SAJbgLpUlDR9++8NtBftEPTiIyYx3wdsKRs98M65IgmgLOXGT6s+Ho53iG6fB22Cpx1XOnAtPWi4K8/Xx0l1WGNeDS3Fb02cnoso9rVNEERT5BEbW89SbJ+9uinqA//llv2+VXQBlIs7xc3Gc7iZ7qsr7RsF3DmiN082jNE10XQ90xGIimaQaxKaeNSL84VYn+jMHl4ZNRlLkns4+px4MPDLN76+Rl/gFcvCg7j8VU6hzuMlTPnzUPgZj+5FfruhQbNeez7EOpiON+/mzy63AbtUc9WwoCquOHMJNiUdgKzt+DpWIFQEThcNpWQ1XxEtc8yD9hAJFxYekFooBm4pw7u0SRh4ox0hnaMKoxfRWv+xb/Rsno9dwvyXc533COoel8kZDGUceI9AyAnoI2pYAspdDkAjg+0UeKt76mSlHBeYIWTuICyiatFP95o7JKgFd3Wqg1QeXWSmLoEKKKxmnDFbo2EYT9RnbGplfUjqU+gBtaTvDksiCOQpFounlmwuT5zHMitz69XCL9OWMub9gj1+m8IL8fryNn0bSi5koRbeZkk6Nbtq2nfw7NScuI0CJrGMV+VI4Qa324J82HGc043PSnnoMBWfO4TA5tjZHRY2essyGCoaQOFLTY9BrFf8OuLFJ8qPCdF5i2Uy1IPlen8nvYC4sAM9StlZivy50Yqx8RHQQklyX+FwtQPkOLUYPVE2DfD9APIu152MZFzDKTT9A75cpZBkEOdafAooVGwKJa+nECEaDmxQBO6pgTO/EeaY6mctZEkl+pF+OUz4hNtyEVeR7mez9wsS5YKbj5BhT6tre9Hm1qJ6Pk0+FJcscKUdQ4gL4y1t3F0IXT3sN18fv+8mLKKr9Lr2qqMHvy3F5YyjJE5uG5dPr4u79/P+yOmj1LGiTpPDTrATgwM6YaLYPAUhGWLIv0BuaadZQvU9jLn7IJx7HE5txEysOLGVLcmF07oka26kfZforkIbx4pIPYktysTNcVbYa5UJhH8FUHjpu7WXd7ysxKKPBdoBLbd8CA0oE4LEKH2fnzJ254+gtaYR8YW70NHcFm0VPZMwY6hW+c7idKnnyJUkbfs0y++SlJSTipBscT74xvh7Srk++UENpBn88mB/gVRSFAVTf4B2sMo2d3jQjK6j7o1ue9IusfAkvOKNoycX5QqPsHMreey6QTCr9WYxnCdc/VQ5JjaKKzcL2YuqhPvnmX6MIuLFHcfzOsLSIuNKNZscDXMH1fZGYUpI/3ayt/zYlmxEyljfoVbVUpY8OHdfRb+ctiFkTz4X6X1q7kB03pi8jC5LtkDad47mfFDw/L4AvlZgSFn5+Js0mT/zpQPQL28rq9COE6ivGN3qWUmZJH5Ej X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e160cf6-235c-4dbc-62be-08da08d152de X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Mar 2022 11:20:36.0495 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6kMDucH8+g8YwD5hdz+HZe9L1iLuFLLOlJW/LtD4hOx2oRE44tTfoAA1r1TU4Wr88/tj6wi3LBvc8LGEvUBIIQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB7108 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220318_043539_061501_56F8E4D2 X-CRM114-Status: GOOD ( 11.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Since zynqmp_get_error_info() is called during CE/UE interrupt, at the end of zynqmp_get_error_info(), it wirtes 0 to ECC_CLR_OFST, which cause the CE/UE interrupts of V3.X Synopsys EDAC DDR been disabled, then the interrupt handler will be called only once, so need to re-enable the interrupts at the end of intr_handler for V3.X Synopsys EDAC DDR. Signed-off-by: Sherry Sun Acked-by: Michal Simek --- drivers/edac/synopsys_edac.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c index 1b630f0be119..3a1db34a8546 100644 --- a/drivers/edac/synopsys_edac.c +++ b/drivers/edac/synopsys_edac.c @@ -521,6 +521,8 @@ static void handle_error(struct mem_ctl_info *mci, struct synps_ecc_status *p) memset(p, 0, sizeof(*p)); } +static void enable_intr(struct synps_edac_priv *priv); + /** * intr_handler - Interrupt Handler for ECC interrupts. * @irq: IRQ number. @@ -562,6 +564,8 @@ static irqreturn_t intr_handler(int irq, void *dev_id) /* v3.0 of the controller does not have this register */ if (!(priv->p_data->quirks & DDR_ECC_INTR_SELF_CLEAR)) writel(regval, priv->baseaddr + DDR_QOS_IRQ_STAT_OFST); + else + enable_intr(priv); return IRQ_HANDLED; }