From patchwork Mon Mar 21 11:46:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12787111 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D56A2C433F5 for ; Mon, 21 Mar 2022 11:47:21 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.292940.497507 (Exim 4.92) (envelope-from ) id 1nWGV3-0003zK-A9; Mon, 21 Mar 2022 11:47:01 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 292940.497507; Mon, 21 Mar 2022 11:47:01 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nWGV3-0003zD-7B; Mon, 21 Mar 2022 11:47:01 +0000 Received: by outflank-mailman (input) for mailman id 292940; Mon, 21 Mar 2022 11:47:00 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nWGV2-0003z7-Eu for xen-devel@lists.xenproject.org; Mon, 21 Mar 2022 11:47:00 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9d45195f-a90c-11ec-8fbc-03012f2f19d4; Mon, 21 Mar 2022 12:46:58 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04lp2050.outbound.protection.outlook.com [104.47.12.50]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-20-RazywuRPO8K_vm4v-l1iHw-1; Mon, 21 Mar 2022 12:46:57 +0100 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM0PR04MB6273.eurprd04.prod.outlook.com (2603:10a6:208:137::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.22; Mon, 21 Mar 2022 11:46:56 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::fc39:fd17:1086:307a]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::fc39:fd17:1086:307a%6]) with mapi id 15.20.5081.022; Mon, 21 Mar 2022 11:46:56 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9d45195f-a90c-11ec-8fbc-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1647863218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2X6yEMK+OHgNoVyLNONBqCrM4DUfGQtj1DZaz8XZ8Xc=; b=Ia8zchv8bpEJDNtK8mlfedn9H/D9+ni5dbTRDzLo5wfLhog64B7yqhHuld8auOPEzHV+hJ wpmQ5oVmEn5hKimH4IwAyCCjjmc0d0Y3v2zQ8J6UgXAO121noiW6bvhQ8hx0H4UjwW8w87 58RQiHC4j/vzqwbllrZrGqAOWIB3gjM= X-MC-Unique: RazywuRPO8K_vm4v-l1iHw-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h7+JA3EFncm/WTWh/XTkx/SX8ZvuK13gmv+TauKcXHStVtwt8v9wEMUGOn/FN9LlyzGp4dvsdY6hh5yMs2rhTlqWSOJc1XXZb+vdVxgkn37oWXV3ePLwJu+y6FGXPxsQRQrRkuYa3xG0ngNp6XdsBK2JFMeDBsxasvY/IBbxINK7excmSb3N2PU8k3zPKMVZAbEJkQ4riKeef7dPWLHZtKyLepcZEtRWHPMLvxWoPrbK0ZRKzYFLsFC4z3cvIBaZgmY222SFWbEB5su87kPTGeHpxt0YB7oZrxeM+VsTgVy8FERa0D9SvdEooRHqx4pueZrBC8dKfxXk6YoWaqutgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2X6yEMK+OHgNoVyLNONBqCrM4DUfGQtj1DZaz8XZ8Xc=; b=TskZJrxJTJza7uS7pbZpfO5/44UU25R3pJd+9WeszWbItaig5Kqce78r7VNY/Adag8DjlBsQByLux0wnV7JJBUVvM1WqRkHzbtEYFj798XSoKdlo91HMnZcP7MdchbnwPhvxn3zh0w6a2knD7KS5Lf1Pkbk+PrfTprLFOfb1nll92VnEslcVLr1e8Dgo/162yr/4YdPKKmhHkc2ThwQiFuILUcPz8EkkQ0yqkkoLmCaXKwtsyE7yC2Fx+gEPmLKV3/EhSYK0MAZHJBgXWTx7RyPJF0DLcaCea4QZ27lLUjE808GapZrpURrVpc8kyEOhSvMox6PF1nD0o/jQ5z+gyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <057172d5-437a-347b-b5bb-d102b6b37f0a@suse.com> Date: Mon, 21 Mar 2022 12:46:54 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: Andrew Cooper , Wei Liu , =?utf-8?q?Roger_Pau_Monn=C3=A9?= , Julien Grall From: Jan Beulich Subject: [PATCH] x86/build: work around older GNU ld not leaving .got.plt empty X-ClientProxiedBy: AS9PR06CA0068.eurprd06.prod.outlook.com (2603:10a6:20b:464::32) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 35606d6f-533e-4944-9746-08da0b307fe2 X-MS-TrafficTypeDiagnostic: AM0PR04MB6273:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PKEjjx+N+ybA0P0AjR55IF3HZETGke8WwdOrcJ29fE1jgkAhNyoUZhjEnKRuonHW2ciVhfwQ/dS3Hp77HeAZerL7zdDD3SLd/oELrlZH4qpDOL1Qc3upJM3ilZQw1TnOKu3GybDvMCTal7CtKGTOQ26xNOf4eLFlyueqF1e4IWSk2EIZwMy4TqcQKtRGcpELcvppfMtc1UaYPP6j5dDlgVTl+xVdD5xJLIBqj+JfwmRWxaIZJbJwMvIvQ3qrOjvR/3Mzdm3vSdo8Xwqyfkks/JkxLKPIPzN+HdaJp0kcGKK17XML7P6xPX4R76Vfggehb+xl45Eo0nbBdWE/PEbmh7A1fCpegh5BX0Rb/AvuTCbUFZJ/kaFfJDrFVs0VWjMRHvzfrnndksBkoNwSLBtuMjePYTvji0eq+fW/p9KlNMB0CbcSPI9fB/Kt5dr4C9yGM5J8VzPhYu5Jbtnqeab7SQu3FcVnc2cA1iS+r6cBhrPt9exRB0tpVzvOz1GwYdPUuI547oNrU7OmwffLTswUZhOzAdkwbqIBy7pemUCb6XMHbf7IuL1R9wEPwR7GnpXnqUQxCHwZnw8GrONL56pAnT4BFOsLTfalErvXh7NQtwnVfpTreHAXFHg6qsAP7Og0nUKG8v8e7J2epQltVov6Vtrs3qwDoYGgB5DOri1fq2qiZoVpH47GU2Y7fIF3uPqpDeChgfyWLmMTXueijo1d9+5b5qgANkuZLquNVQHDzEyGRfwiTMJGiElojUCsWf5fndESMdDMBu8trrugWJZdKg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(8676002)(31686004)(66476007)(38100700002)(66556008)(66946007)(4326008)(316002)(508600001)(86362001)(5660300002)(31696002)(6486002)(6916009)(186003)(8936002)(26005)(6506007)(2616005)(6512007)(2906002)(36756003)(54906003)(142923001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?M449i3YBdKa0rxMCSNm18J/TbhOc?= =?utf-8?q?rRsEb78TPmZTQnruC6g/JuZj/SrQm6IZvSmlTsb3bHRKwh8BvZL7YDlbUB3jk+vOh?= =?utf-8?q?H1RjErVi9eLDr7Rd08K4EKVDA7LhMyTVKuY+AisOUuCoDkCzK/Z6Wmxm7CgPNXb3y?= =?utf-8?q?XgMTfCR/6CNh5a7O2W2LQj3IpCQxOkUWp7ol0k6v+cSn8IVDfkwr917vN50yvYO6I?= =?utf-8?q?kEPPUtfgaWdLGBMkARioLJJ3khIuEqPh/DrWX/0N9HEgwwPqrLXdgCVSytj3yge7W?= =?utf-8?q?DTnSS4yY3rg71QT28eL3Iicu0bQgASiwGwYyqMvOyLDx4W1RefQ/52QwhqyY1rdkv?= =?utf-8?q?gUFtxFBDyEyXYh446XRlz+6Luy4qDkWtkFJQvHouPG743QJWr0B9cLDwaDTYQtXgM?= =?utf-8?q?/u9MkCJaNadMnWs9zj7fUCqYS05ecQyt64XVSpXDYj5Ejw44LOvGuOG9P1UXw7mVF?= =?utf-8?q?D/3qMb08c2Pn1xmDFzmXRO8wZjxzLj3JodKCcXaLVtDnHG3pXbou7sKEEq+z9UPCa?= =?utf-8?q?6qfF2C3+69guK4AFeWQDx4qi6ZR/aFTztShZKe+S4XEaF99CMLn75bsSBDQYXigcg?= =?utf-8?q?a3jEHzR8feHonw0+QJEENhqj+F2KS+c2QqFmlfi7UYhW+Sy6+7ITjN0kZZDXGh5nq?= =?utf-8?q?d5uRm2m9Lqt975kj8cGM40iN23k0kDCh8GOYZbAjdCLlUrei8SdAXquJkk+/AYDVn?= =?utf-8?q?+D5MOUm2QsT58rdcqjgS1gEdn2Sw2jxuTJDSo8RyhfVOwBmUAVLUt3CppxqKKQEEp?= =?utf-8?q?MKRIUpjfhd15k+LQoV2K/Y7341L3UTgZQyYG/asWRqCOu6xuWEqiZtyk7D5tKeK0T?= =?utf-8?q?q1s2E+QhhVV1CHA98sh2B6U0KsV9uRAkuuk19zUD7SuLn+/WEvTuDa5n6ll6AczXx?= =?utf-8?q?5oEWqRf0yIUr2wck6fhbuS5+3DXDqqvvALE8qSSKcDeqxedVHu9RmdM8znR1ulLf4?= =?utf-8?q?Nqn4aqeyxkreAgyPSkNquaR2fA8BJlZsrQn3zPLnHYD+Lq0yFzg+ItuMM1ls5M3VS?= =?utf-8?q?0TyOq6GZAk17M2hsZsnfmCx2iRWu0kfwJALSTNr4yUU42I3kjCfDLjSKniOKdn8Qh?= =?utf-8?q?J5TM6/eAQ0pQ6jyRao6wTNVJkXfj4AWJHupZbNGERzkLaCUb+1Jf/PbEvRiVW3jKy?= =?utf-8?q?L0g53quiYg+zscdfgAjzPWKC6lfMD8yXMGCejhdXP6mBG38K2cVylAmOTSXKD9ks3?= =?utf-8?q?cLggMs7m6gh5qTZBheG0xDqeMhuoiRyuzcLaNYIGzwYYxsggvOni0tPAdpk/oi+g7?= =?utf-8?q?Tygf8JPefliQXlk/CmykgyHz4pSZkJnEZU8HzEs73UZ9kQA5HsPTX0wURcejRFP2+?= =?utf-8?q?k0zAiQq6QAkHQ4/u92imsxOnUkRRwul01911O/FG1SPpyRUCwhbGHXcH8LGMRCQop?= =?utf-8?q?xkjvbyalKT80ka?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 35606d6f-533e-4944-9746-08da0b307fe2 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Mar 2022 11:46:55.9175 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wkVoCbTRn8apzNlwZ02yu3mvX6z/v6UsW6FH9AAbPIG/nA6wvxmLNYS/CxrEnlN5fZEJ7GMlzcvoG+9JDUY6Xg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6273 The initial three entries in .got.plt are "static", i.e. present independent of actual entries allocation of which is triggered by respective relocations. When no real entries are needed, halfway recent ld discards the "static" portion of the table as well, but older GNU ld fails to do so. Fixes: dedb0aa42c6d ("x86/build: use --orphan-handling linker option if available") Reported-by: Julien Grall Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné Tested-by: Julien Grall --- a/xen/arch/x86/xen.lds.S +++ b/xen/arch/x86/xen.lds.S @@ -497,7 +497,13 @@ ASSERT(IS_ALIGNED(__bss_end, 8), #ifndef EFI ASSERT(!SIZEOF(.got), ".got non-empty") -ASSERT(!SIZEOF(.got.plt), ".got.plt non-empty") +/* + * At least GNU ld 2.30 and earlier fail to discard the generic part of + * .got.plt when no actual entries were allocated. Permit this case alongside + * the section being empty. + */ +ASSERT(!SIZEOF(.got.plt) || SIZEOF(.got.plt) == 3 * 8, + "unexpected .got.plt size") ASSERT(!SIZEOF(.igot.plt), ".igot.plt non-empty") ASSERT(!SIZEOF(.iplt), ".iplt non-empty") ASSERT(!SIZEOF(.plt), ".plt non-empty")