From patchwork Sun Jan 6 15:46:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Couder X-Patchwork-Id: 10749519 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DDD0814E5 for ; Sun, 6 Jan 2019 15:47:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C26A728914 for ; Sun, 6 Jan 2019 15:47:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B282C28917; Sun, 6 Jan 2019 15:47:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2EC5928914 for ; Sun, 6 Jan 2019 15:47:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726426AbfAFPrB (ORCPT ); Sun, 6 Jan 2019 10:47:01 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:45665 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726341AbfAFPrA (ORCPT ); Sun, 6 Jan 2019 10:47:00 -0500 Received: by mail-ed1-f66.google.com with SMTP id d39so35707822edb.12 for ; Sun, 06 Jan 2019 07:46:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CixAtOx4hrsKxD5+D+NeC1NXBvTPPG/T1rMDn8cOGpM=; b=FcZ/3WYTECle9yPpGvbC+syDARYDQ76Skgvsrggd7xFk38A7Dsmui5dGLsYw/puGop X3upAEEDoNqBju59Kf9MyKZKh4MIiajdQ7G4c6ZNLHQlowiSmztyYcnlRU5drGa8FfZd BLbA1wZyivPP9HpFwOAfMvBzztCAGGDVMC9HhlLaI/pEraUPiJ4cQOug3598Bu0qllmu Emmsvni8ZDSrayL0kctEpLwFdP9QMskCqBk7H/HfC1nclTfOIi6wmkXAX39PRnLH3x8F aV8+bw6mijZeS+1BJ9lbJQAA8hg5MZcjs8hq92QJxN8Ay9Lm20QOypYtrBBwKesFOyeu 12IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=CixAtOx4hrsKxD5+D+NeC1NXBvTPPG/T1rMDn8cOGpM=; b=TR+wmEwIrNW1XSSq6qwXwNnR5TAJBVlCQrV51s8mKIcyjrWCMEvhbcOrPA6jc8tPRN YoonYGr3QA07kbrddUwaS93EjYxGMQNqYBH7a5flLE365ZmirrnuMYlx6uTyO9/HkWKZ ugt5NB/yeWW8aQvGvT9xC6uMkF5fJXmzKe2A1ouxWScS8lOZe/Vtq7UX94Jfac00K7Ps t99k6xiRIFiDa7/5+w0Ob5rxfdHM3GUOpZ12gXF2Dd32LcQrNzI0kpZEAVe2DTTA6zVE RSUhw0edJxB601XgYIDGuSeXRiyM6tcv9eTphrDfR3jI3g+HxgtlRKIDa/UYGCA/6d9z DwGw== X-Gm-Message-State: AJcUukeWf5pS3n18sfepAhnoNU6om9r4wgKUYUeD9qAEZ2Thbn0tmohf ZaWVJOuGmVT8k+oxK24/H0f4adO9 X-Google-Smtp-Source: ALg8bN6F7xOZ+DcuYVWIQdwRrrHzL/zB3tpKLh3Z7a4l9e+7O2fS73IYB9ZVGgaIb/UguemGgQSwqg== X-Received: by 2002:a17:906:f108:: with SMTP id gv8-v6mr27354817ejb.173.1546789618821; Sun, 06 Jan 2019 07:46:58 -0800 (PST) Received: from localhost.localdomain (5.84.115.78.rev.sfr.net. [78.115.84.5]) by smtp.gmail.com with ESMTPSA id u7-v6sm16666616ejb.65.2019.01.06.07.46.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 Jan 2019 07:46:57 -0800 (PST) From: Christian Couder X-Google-Original-From: Christian Couder To: git@vger.kernel.org Cc: Junio C Hamano , =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBC?= =?utf-8?b?amFybWFzb24=?= , Duy Nguyen , Christian Couder Subject: [PATCH] helper/test-ref-store: fix "new-sha1" vs "old-sha1" typo Date: Sun, 6 Jan 2019 16:46:37 +0100 Message-Id: <20190106154637.10815-1-chriscool@tuxfamily.org> X-Mailer: git-send-email 2.20.1.26.gc246996f60 MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It looks like it is a copy-paste error made in 80f2a6097c (t/helper: add test-ref-store to test ref-store functions, 2017-03-26) to pass "old-sha1" instead of "new-sha1" to notnull() when we get the new sha1 argument from const char **argv. Signed-off-by: Christian Couder --- t/helper/test-ref-store.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/helper/test-ref-store.c b/t/helper/test-ref-store.c index e9e0541276..799fc00aa1 100644 --- a/t/helper/test-ref-store.c +++ b/t/helper/test-ref-store.c @@ -233,7 +233,7 @@ static int cmd_update_ref(struct ref_store *refs, const char **argv) { const char *msg = notnull(*argv++, "msg"); const char *refname = notnull(*argv++, "refname"); - const char *new_sha1_buf = notnull(*argv++, "old-sha1"); + const char *new_sha1_buf = notnull(*argv++, "new-sha1"); const char *old_sha1_buf = notnull(*argv++, "old-sha1"); unsigned int flags = arg_flags(*argv++, "flags"); struct object_id old_oid;