From patchwork Sun Jan 6 17:09:52 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Rene Rebe X-Patchwork-Id: 10749573 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id E0B6813AD for ; Sun, 6 Jan 2019 16:29:51 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D1C73288BC for ; Sun, 6 Jan 2019 16:29:51 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C5980288CE; Sun, 6 Jan 2019 16:29:51 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EFA31288BC for ; Sun, 6 Jan 2019 16:29:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726410AbfAFQ3u (ORCPT ); Sun, 6 Jan 2019 11:29:50 -0500 Received: from mx.exactcode.de ([144.76.154.42]:46964 "EHLO mx.exactcode.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726341AbfAFQ3u (ORCPT ); Sun, 6 Jan 2019 11:29:50 -0500 X-Greylist: delayed 1186 seconds by postgrey-1.27 at vger.kernel.org; Sun, 06 Jan 2019 11:29:49 EST DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=exactcode.de; s=x; h=Content-Transfer-Encoding:Content-Type:Mime-Version:From:Subject:Cc:To:Message-Id:Date; bh=6t12AjWSXexoBoy43ENgiRMZVTFjgEOsVd08VaM9zq4=; b=hRdVDaS24ZhLaMh/Ztr4NlwsWrn4K1yEsQnbWONfs+Rj0hbl/OHlcLhR49pabi7RmQRxA4T2TzU2RR7N3NtisfLw0/9L9ElMy//mPJcdFsLBA19Ke1nCcPf/fyAGTP2BU4n9uoicoIqYGa5hjf4yIH+QU9VbllQWgM0sPng2y4c=; Received: from exactco.de ([90.187.5.221]) by mx.exactcode.de with esmtp (Exim 4.82) (envelope-from ) id 1ggB0U-0004DN-DH; Sun, 06 Jan 2019 16:10:34 +0000 Received: from [94.25.168.29] (helo=localhost) by exactco.de with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.54) id 1ggBEX-0004OC-HQ; Sun, 06 Jan 2019 16:25:10 +0000 Date: Sun, 06 Jan 2019 18:09:52 +0100 (CET) Message-Id: <20190106.180952.2277917517304490024.rene@exactcode.com> To: linux-input@vger.kernel.org Cc: Jiri Kosina , Benjamin Tissoires Subject: [RFC] Dell XPS 15 multitouch touchpad From: Rene Rebe X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, I am testing a Dell XPS 15 all-in-one and noticed the I2C connected touchpad had only very basic mouse function. I debugged around a bit and manually modprobing hid-multitouch appears to bind this to the hid-multitouch for grearly enhanced functionatliy. Now I could probably just add hid-multitouch to some init script, but I wanted to get it to auto-load liek for my Surface Typecover. I added the ID, Synaptics, 0x7A13 to the hid-quirks for a test, but this is not yet enough to auto-load. Before I continue adding the ID all over the place, including the hid-multitouch.c, could someone shortly comment about the best, intended place for this - there are so many IDs all over the place and it is not obvious where it is necessary and where not. Thank you! René Rebe --- drivers/hid/hid-quirks.c.vanilla 2019-01-06 17:35:58.304007689 +0100 +++ drivers/hid/hid-quirks.c 2019-01-06 17:47:30.776010444 +0100 @@ -157,6 +157,7 @@ { HID_USB_DEVICE(USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_LTS2), HID_QUIRK_NO_INIT_REPORTS }, { HID_USB_DEVICE(USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_QUAD_HD), HID_QUIRK_NO_INIT_REPORTS }, { HID_USB_DEVICE(USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_TP_V103), HID_QUIRK_NO_INIT_REPORTS }, + { HID_USB_DEVICE(USB_VENDOR_ID_SYNAPTICS, 0x7A13), HID_QUIRK_MULTI_INPUT }, { HID_USB_DEVICE(USB_VENDOR_ID_TOPMAX, USB_DEVICE_ID_TOPMAX_COBRAPAD), HID_QUIRK_BADPAD }, { HID_USB_DEVICE(USB_VENDOR_ID_TOUCHPACK, USB_DEVICE_ID_TOUCHPACK_RTS), HID_QUIRK_MULTI_INPUT }, { HID_USB_DEVICE(USB_VENDOR_ID_TPV, USB_DEVICE_ID_TPV_OPTICAL_TOUCHSCREEN_8882), HID_QUIRK_NOGET }, @@ -507,6 +508,7 @@ #endif #if IS_ENABLED(CONFIG_HID_MULTITOUCH) { HID_USB_DEVICE(USB_VENDOR_ID_LG, USB_DEVICE_ID_LG_MELFAS_MT) }, + { HID_USB_DEVICE(USB_VENDOR_ID_SYNAPTICS, 0x7A13) }, #endif #if IS_ENABLED(CONFIG_HID_WIIMOTE) { HID_BLUETOOTH_DEVICE(USB_VENDOR_ID_NINTENDO, USB_DEVICE_ID_NINTENDO_WIIMOTE) },