From patchwork Sun Jan 6 22:48:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Osterlund X-Patchwork-Id: 10749759 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3683314E5 for ; Sun, 6 Jan 2019 22:48:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 28CCA284A7 for ; Sun, 6 Jan 2019 22:48:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1D2D0284ED; Sun, 6 Jan 2019 22:48:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 688DC284A7 for ; Sun, 6 Jan 2019 22:48:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726105AbfAFWsk (ORCPT ); Sun, 6 Jan 2019 17:48:40 -0500 Received: from mail-lj1-f180.google.com ([209.85.208.180]:44484 "EHLO mail-lj1-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726061AbfAFWsk (ORCPT ); Sun, 6 Jan 2019 17:48:40 -0500 Received: by mail-lj1-f180.google.com with SMTP id k19-v6so36546907lji.11 for ; Sun, 06 Jan 2019 14:48:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:user-agent:mime-version; bh=r4KQhnC5bdWXGwh2YJ0P4IjvfbVUWz/FCN0JPqnlbZ0=; b=PK3AlO31JIg8dw/TjHlBFgd8rz/vU4WUhai1WDTWoxizuV/8ekuvJLLj91udkt/YUp ZLPOkdDPYIpVpQ35VqFXimLVy7CvYCvH3V9f2uTQPPzLdsTMtGsv8ZbIOgyeMrOsBjy1 QlCDwTHdJagPkOitSRXlSFLSUDKKMJb/l8Z/3Od9DBLExi4ldrBm364zrXkDVbsM2Vxf y+KPveOIlukSNvuSS45rrItmlGC+liLqmK6SJSLLdrbkK3OLNAtkwYV2o+j1pQlxyscG bqg6hj4qakhZU3r086m4JJFTLZl5BTrKKO7V0+lrEtJHXngFlChXAbMdBRHeNTIMMx5X H90A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:user-agent :mime-version; bh=r4KQhnC5bdWXGwh2YJ0P4IjvfbVUWz/FCN0JPqnlbZ0=; b=jSFY1D1QP6rvGHLjdJyCCpusCXhuyw73bCabXRc0CJJ0rtnFdIoL8oi6Or3ZKAozKU RcrmNuy+GW5nprwI4D00+CU3YG6logQh960e2K6JrjAPWlMmYNSyUsHJfMUYhOyPlEjN 3Efb80o02gVJrQhyYEq2wgogXZZcaFOykaqL7DNtgbIpcyQR2UzeumBCQcTMgLsvn9uf BSXKa9WA+jtIaOgz10xqZxhbrRCFVVSqtTrr3YqAI1pB1bSUkInvBRcZlur8+W8ZIX1r tTLT/hD72AmpfLEnT2y421xCyKjfg28qNLlAMhVjM9BVXBEtr2C/nbSKIXTuZiXga1Ry iryw== X-Gm-Message-State: AJcUukfi268WEE5qw9TeUFTinKeovAmUoNh4mQq/8/14OjYfltN7TIuK OGCj7h5pR9+3ohyAmB8L/OdW+OAa X-Google-Smtp-Source: ALg8bN73ye+W+ktV3NVRjK3pxqBvQKohKONWZUhwDhBc0GkzzUYl/mSGdP5V6mG2ubYC8flX9anaOA== X-Received: by 2002:a2e:4a19:: with SMTP id x25-v6mr31786016lja.19.1546814917833; Sun, 06 Jan 2019 14:48:37 -0800 (PST) Received: from fractal (c-3e3f70d5.031-170-73746f28.bbcust.telenor.se. [213.112.63.62]) by smtp.gmail.com with ESMTPSA id b22sm12306881lfg.32.2019.01.06.14.48.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 06 Jan 2019 14:48:37 -0800 (PST) Date: Sun, 6 Jan 2019 23:48:32 +0100 (CET) From: Peter Osterlund X-X-Sender: petero@fractal.localdomain To: git@vger.kernel.org cc: Luke Diamand Subject: "git p4" fails when perforce login not needed Message-ID: User-Agent: Alpine 2.21 (LFD 202 2017-01-01) MIME-Version: 1.0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, When I use "git p4 sync" to update a git repository from a perforce depot, the operation fails with error message: failure accessing depot: unknown error code info When I run "p4 login -s" from a shell it reports: 'login' not necessary, no password set for this user. The following patch fixes the problem for me: Not sure if this helps, but running "p4 -G login -s | hexdump" gives: 00000000 7b 73 04 00 00 00 63 6f 64 65 73 04 00 00 00 69 |{s....codes....i| 00000010 6e 66 6f 73 05 00 00 00 6c 65 76 65 6c 69 00 00 |nfos....leveli..| 00000020 00 00 73 04 00 00 00 64 61 74 61 73 35 00 00 00 |..s....datas5...| 00000030 27 6c 6f 67 69 6e 27 20 6e 6f 74 20 6e 65 63 65 |'login' not nece| 00000040 73 73 61 72 79 2c 20 6e 6f 20 70 61 73 73 77 6f |ssary, no passwo| 00000050 72 64 20 73 65 74 20 66 6f 72 20 74 68 69 73 20 |rd set for this | 00000060 75 73 65 72 2e 30 |user.0| 00000066 Best regards, --- /usr/libexec/git-core/git-p4~ 2018-12-15 14:51:07.000000000 +0100 +++ /usr/libexec/git-core/git-p4 2019-01-06 23:23:06.934176387 +0100 @@ -332,6 +332,8 @@ die_bad_access("p4 error: {0}".format(data)) else: die_bad_access("unknown error") + elif code == "info": + return else: die_bad_access("unknown error code {0}".format(code))