From patchwork Thu Mar 31 00:17:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Henrique Barboza X-Patchwork-Id: 12796592 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9A401C433EF for ; Thu, 31 Mar 2022 00:27:18 +0000 (UTC) Received: from localhost ([::1]:49028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZiej-0005Lm-LM for qemu-devel@archiver.kernel.org; Wed, 30 Mar 2022 20:27:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37038) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZiVW-00064g-Uc; Wed, 30 Mar 2022 20:17:48 -0400 Received: from [2001:4860:4864:20::34] (port=39327 helo=mail-oa1-x34.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZiVV-000304-EJ; Wed, 30 Mar 2022 20:17:46 -0400 Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-deb9295679so16503565fac.6; Wed, 30 Mar 2022 17:17:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sOivFOrFSTEw7stIbfEnO86R22xeQdY78hcGuIajqB0=; b=WGkkchYftdejXjUKEFxSUX/Lf6SDTnx3slCandQtZpC7ptIib2cbGgWVPPbp84LMqP 0tRZCb3EHZ3kYSx19yriOtfGwKS/cSQPy4YCjT1JDZWlMyfkavJW/jMjrcfMhTO3JTgd dnIgZ9p41ItUKzf4WDxFvS4ASt3IKWsg2fv2lB4ISOJCkhw4MxSGlqcA+0F+WtBYCJLo Lqge1lWGOP+PnWGwGjNTR0fvijc7gozcUtP8jVfvVoJ5hZx4eISqedRZ4xl+mOhlIH/I roU83AgrXAibFuyN89dCK/d5Zt/GZYb48ao0cfZjX9p+jTAxbfBY6rR618JxHNKIdQc7 9BPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sOivFOrFSTEw7stIbfEnO86R22xeQdY78hcGuIajqB0=; b=I1GMgOXha0tP2K+G2ToTq8pt3V0urWu3dsH+/kCwJq9jUmVdSoGKSUARq+VTQXE4s3 9G6t0DFeZc8yHsarprFhwj8UINQ31hUyPQyh/UE3DVE6BjvbuKUVOmRRzR09C+Mnneag irvx5+HGP38zsScd8JJR6ty6+i8T9gpo4EAo4dJ82opW6bwwBneJ7tfTOT81cmVkQEFr RInPjIFky9JxX6awGPb46mWvSdnuMsx0wisjS7fWcJ0gkMnoMvBUtYAS7eUfGmxEbkrj CMagY+vKibjhF2ue7BBGH5U3CcTJf9YJ6DSPpTjA2HAW9xlUfOzzrj4lRVxohG3QnDj+ sLyg== X-Gm-Message-State: AOAM531SGfageFMA3SHWM9eQmmnjAViopwPigiS32OWuP+1eWjfqXQRU MMNkSkRv4Fif2gOybD7f1PbuAW8dVYY= X-Google-Smtp-Source: ABdhPJxZEUUWqZkTd6YI9/pIhgQAx3GauLDNqC+in6H0cArrH1miTC3ec4VSJCbpDYBy02bpe8aFRg== X-Received: by 2002:a05:6870:b02a:b0:de:aa91:898c with SMTP id y42-20020a056870b02a00b000deaa91898cmr1350236oae.25.1648685863400; Wed, 30 Mar 2022 17:17:43 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:abe8:ed:2c78:ab0c:7946]) by smtp.gmail.com with ESMTPSA id j126-20020acab984000000b002da77222b7dsm11149190oif.22.2022.03.30.17.17.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 17:17:43 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Subject: [PATCH v2 1/4] target/ppc: initialize 'val' union in kvm_get_one_spr() Date: Wed, 30 Mar 2022 21:17:14 -0300 Message-Id: <20220331001717.616938-2-danielhb413@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220331001717.616938-1-danielhb413@gmail.com> References: <20220331001717.616938-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:4860:4864:20::34 (failed) Received-SPF: pass client-ip=2001:4860:4864:20::34; envelope-from=danielhb413@gmail.com; helo=mail-oa1-x34.google.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Daniel Henrique Barboza , qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Valgrind isn't convinced that we are initializing the values we assign to env->spr[spr] because it doesn't understand that the 'val' union is being written by the kvm_vcpu_ioctl() that follows (via struct kvm_one_reg). This results in Valgrind complaining about uninitialized values every time we use env->spr in a conditional, like this instance: ==707578== Thread 1: ==707578== Conditional jump or move depends on uninitialised value(s) ==707578== at 0xA10A40: hreg_compute_hflags_value (helper_regs.c:106) ==707578== by 0xA10C9F: hreg_compute_hflags (helper_regs.c:173) ==707578== by 0xA110F7: hreg_store_msr (helper_regs.c:262) ==707578== by 0xA051A3: ppc_cpu_reset (cpu_init.c:7168) ==707578== by 0xD4730F: device_transitional_reset (qdev.c:799) ==707578== by 0xD4A11B: resettable_phase_hold (resettable.c:182) ==707578== by 0xD49A77: resettable_assert_reset (resettable.c:60) ==707578== by 0xD4994B: resettable_reset (resettable.c:45) ==707578== by 0xD458BB: device_cold_reset (qdev.c:296) ==707578== by 0x48FBC7: cpu_reset (cpu-common.c:114) ==707578== by 0x97B5EB: spapr_reset_vcpu (spapr_cpu_core.c:38) ==707578== by 0x97BABB: spapr_cpu_core_reset (spapr_cpu_core.c:209) ==707578== Uninitialised value was created by a stack allocation ==707578== at 0xB11F08: kvm_get_one_spr (kvm.c:543) Initializing 'val' has no impact in the logic and makes Valgrind output more bearable. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel Henrique Barboza Reviewed-by: David Gibson --- target/ppc/kvm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index dc93b99189..858866ecd4 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -543,10 +543,11 @@ static void kvm_get_one_spr(CPUState *cs, uint64_t id, int spr) { PowerPCCPU *cpu = POWERPC_CPU(cs); CPUPPCState *env = &cpu->env; + /* Init 'val' to avoid "uninitialised value" Valgrind warnings */ union { uint32_t u32; uint64_t u64; - } val; + } val = { }; struct kvm_one_reg reg = { .id = id, .addr = (uintptr_t) &val, From patchwork Thu Mar 31 00:17:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Henrique Barboza X-Patchwork-Id: 12796598 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA953C433F5 for ; Thu, 31 Mar 2022 00:40:56 +0000 (UTC) Received: from localhost ([::1]:40124 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZirv-0002NC-OQ for qemu-devel@archiver.kernel.org; Wed, 30 Mar 2022 20:40:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZiVY-00065U-QN; Wed, 30 Mar 2022 20:17:48 -0400 Received: from [2607:f8b0:4864:20::330] (port=38601 helo=mail-ot1-x330.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZiVX-0003B8-Ag; Wed, 30 Mar 2022 20:17:48 -0400 Received: by mail-ot1-x330.google.com with SMTP id a7-20020a9d5c87000000b005ad1467cb59so16081548oti.5; Wed, 30 Mar 2022 17:17:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SAThiALREL0XgXauyo5M0z5vH8LMryC/mz3jmxrZQMQ=; b=a1IlBj+HtbW6FskVwOQvqJqz3kac5pqfDl4YVPuxFFsb8QYYbY+EjUarOdlKkiTCkS zbiLVY/7zzypbpZah7v5xcYhoX4O6n/yiln7FofjlVSe8fnhBdf4xH7M/Hbsr7Z9jLhM Ni/2asZgARSvxGbG7sgR5Tc8V05nLQIFI29qzaHalwFkDqQvCSRyfcgnjxcsuPWvmfFJ LVy2ahdKedfMoza989vurwj2jMez3+pieMUYbgq3HeP4QBEEUQi2xRRBJdBOuMSNlUrm WXDmn9k1HqgMjXTfEfkI2wddWkT2Hnw5y4jSyKc0NfWEusTODFH4b789LlEfkLOOThL7 3f5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SAThiALREL0XgXauyo5M0z5vH8LMryC/mz3jmxrZQMQ=; b=0Lf1r2pdAQjR/84/aFnVX/BXkWNai8VVVvQTDTI98dqQW2h98duZzHcFMbd7QRvSkN DD/amswFUUk4XYTv/Ss5tId8SHLQHkMh1Go2xR6AvRBoIsnLQ/hRc2FECyE+R1LqfCN8 oARO+d5wbQt8uVRUEL+LnjTkfbvMF1nSG52PYi4FLgB8JhLv8Uozm08qRox9dkLd+JYA NKeHwoVNe0aIPLhjI3AKS3M6SSTB7bA0CmxvscUgBgWOai2U8I53H6XGRG5zdjDeappa pwfqq6fyaOqxS9AN7zfG8vkbKrvuGcKbg7YZPa171GasuY/MweSdr3VJw0nPQJNKb1wS ItVQ== X-Gm-Message-State: AOAM531etXyGasjUvYjLkpoYaG9/pRHXHkCJW7q4z+yzeYwB37FoAKno P4gsdpWbdXb4t/+XBXmpCtMo1L5ptm8= X-Google-Smtp-Source: ABdhPJwPdh1HQSwS5NcjtJE/hVwpvZS3+UwozoeCAEFY3Hrp6YF96eG9qPWUZt98HCYv7LMUAMdljA== X-Received: by 2002:a05:6830:2438:b0:5b2:5d36:fec2 with SMTP id k24-20020a056830243800b005b25d36fec2mr4785290ots.173.1648685865617; Wed, 30 Mar 2022 17:17:45 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:abe8:ed:2c78:ab0c:7946]) by smtp.gmail.com with ESMTPSA id j126-20020acab984000000b002da77222b7dsm11149190oif.22.2022.03.30.17.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 17:17:45 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Subject: [PATCH v2 2/4] target/ppc: init 'lpcr' in kvmppc_enable_cap_large_decr() Date: Wed, 30 Mar 2022 21:17:15 -0300 Message-Id: <20220331001717.616938-3-danielhb413@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220331001717.616938-1-danielhb413@gmail.com> References: <20220331001717.616938-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::330 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::330; envelope-from=danielhb413@gmail.com; helo=mail-ot1-x330.google.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Daniel Henrique Barboza , qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" 'lpcr' is used as an input of kvm_get_one_reg(). Valgrind doesn't understand that and it returns warnings as such for this function: ==55240== Thread 1: ==55240== Conditional jump or move depends on uninitialised value(s) ==55240== at 0xB011E4: kvmppc_enable_cap_large_decr (kvm.c:2546) ==55240== by 0x92F28F: cap_large_decr_cpu_apply (spapr_caps.c:523) ==55240== by 0x930C37: spapr_caps_cpu_apply (spapr_caps.c:921) ==55240== by 0x955D3B: spapr_reset_vcpu (spapr_cpu_core.c:73) ==55240== by 0x95612B: spapr_cpu_core_reset (spapr_cpu_core.c:209) ==55240== by 0x95619B: spapr_cpu_core_reset_handler (spapr_cpu_core.c:218) ==55240== by 0xD3605F: qemu_devices_reset (reset.c:69) ==55240== by 0x92112B: spapr_machine_reset (spapr.c:1641) ==55240== by 0x4FBD63: qemu_system_reset (runstate.c:444) ==55240== by 0x62812B: qdev_machine_creation_done (machine.c:1247) ==55240== by 0x5064C3: qemu_machine_creation_done (vl.c:2725) ==55240== by 0x5065DF: qmp_x_exit_preconfig (vl.c:2748) ==55240== Uninitialised value was created by a stack allocation ==55240== at 0xB01158: kvmppc_enable_cap_large_decr (kvm.c:2540) Init 'lpcr' to avoid this warning. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel Henrique Barboza --- target/ppc/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 858866ecd4..42814e1b97 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -2538,7 +2538,7 @@ int kvmppc_get_cap_large_decr(void) int kvmppc_enable_cap_large_decr(PowerPCCPU *cpu, int enable) { CPUState *cs = CPU(cpu); - uint64_t lpcr; + uint64_t lpcr = 0; kvm_get_one_reg(cs, KVM_REG_PPC_LPCR_64, &lpcr); /* Do we need to modify the LPCR? */ From patchwork Thu Mar 31 00:17:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Henrique Barboza X-Patchwork-Id: 12796596 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45C84C433F5 for ; Thu, 31 Mar 2022 00:34:57 +0000 (UTC) Received: from localhost ([::1]:60926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZim8-00058X-Ej for qemu-devel@archiver.kernel.org; Wed, 30 Mar 2022 20:34:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZiVb-00069Q-Sd; Wed, 30 Mar 2022 20:17:55 -0400 Received: from [2607:f8b0:4864:20::233] (port=43843 helo=mail-oi1-x233.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZiVZ-0003J0-Ev; Wed, 30 Mar 2022 20:17:51 -0400 Received: by mail-oi1-x233.google.com with SMTP id w127so23754902oig.10; Wed, 30 Mar 2022 17:17:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=tUCQrHFagL1zcxCWHXjLIdmlTK1pUrFFJANtan0A590=; b=MQnVoJrNVo0co+ckchZuPPuMEzEJ2+tWI5vR4BZ10xGavDiSwZ68XUCwOtJ6Tb+rL0 xk3kiHEYHiCyVSdb1ag5U3su7CDMZaCEoErUV9YJB6nzafM9TAT5LPfK2wYna9qf2e7z JvkmJD/48Gby9OQg7pZw6KAbK3xYkA1sVJw48cqUo/+UKuW4wvVbR7IVyK3lQgIXY01J yU1tokL1ZD14H+Z5lRk2qAe0Fm1e6m3r2iNoa1WfQpk2ubL9BPiDHz8TCEXNfXXViAfC 2rRmtDK/Tl6hi+x9lWFZP3A11Qai0QCPaZt8zFSIVe0c640USFVvsX0IPdHhMuC0tbF2 6f/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=tUCQrHFagL1zcxCWHXjLIdmlTK1pUrFFJANtan0A590=; b=RKg4+TLxx1PW792kJTTup93tUmKm8yai/0NlBE0gi2j5JG3wM9omb9bNGg9/t497WB ZlUT2Tz//lEOPDCFE+Y1RwdU90HURZ+VmXD8OuzMPtsPoWCrqunExO/IhRkmQMA7KZou wP0Eg4yUA4FheGoxozbqzObViZj4FYF06XXV3UEOZPfJHYMWSLTkHOuY5pPG4KCqXvtK Xqei1EXf6AGYnBzn8Aj1ej7T+dhJRtHcFiJVXD1++k7XopUOTPmOrPTCnpLXdw0soitK /KgSFWVugJT47qt9xYI232/1ikN5JWwm74YJzyQ58+LRrgi1FjVOZ+5gWCbrw2HecMen ZZOg== X-Gm-Message-State: AOAM530OZhfNsRvo6EUL3r4qHjvertbFC1XUjX3gnBXQO2Qac7YR9vot /fMHSq+mOqp4CpBGlWSY3Y+KwTqetZA= X-Google-Smtp-Source: ABdhPJyt1Y1Q+DQ2ndwyUmTy5hlGzYyodTN/wO4prd3EsNUELgk8lw81nAc/gAFQQsBmRShhQMBXTg== X-Received: by 2002:a05:6808:179a:b0:2ef:8a55:b947 with SMTP id bg26-20020a056808179a00b002ef8a55b947mr1526142oib.95.1648685868041; Wed, 30 Mar 2022 17:17:48 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:abe8:ed:2c78:ab0c:7946]) by smtp.gmail.com with ESMTPSA id j126-20020acab984000000b002da77222b7dsm11149190oif.22.2022.03.30.17.17.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 17:17:47 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Subject: [PATCH v2 3/4] target/ppc: init 'sregs' in kvmppc_put_books_sregs() Date: Wed, 30 Mar 2022 21:17:16 -0300 Message-Id: <20220331001717.616938-4-danielhb413@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220331001717.616938-1-danielhb413@gmail.com> References: <20220331001717.616938-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::233 (failed) Received-SPF: pass client-ip=2607:f8b0:4864:20::233; envelope-from=danielhb413@gmail.com; helo=mail-oi1-x233.google.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Daniel Henrique Barboza , qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Init 'sregs' to avoid Valgrind complaints about uninitialized bytes from kvmppc_put_books_sregs(): ==54059== Thread 3: ==54059== Syscall param ioctl(generic) points to uninitialised byte(s) ==54059== at 0x55864E4: ioctl (in /usr/lib64/libc.so.6) ==54059== by 0xD1FA23: kvm_vcpu_ioctl (kvm-all.c:3053) ==54059== by 0xAFB18B: kvmppc_put_books_sregs (kvm.c:891) ==54059== by 0xAFB47B: kvm_arch_put_registers (kvm.c:949) ==54059== by 0xD1EDA7: do_kvm_cpu_synchronize_post_init (kvm-all.c:2766) ==54059== by 0x481AF3: process_queued_cpu_work (cpus-common.c:343) ==54059== by 0x4EF247: qemu_wait_io_event_common (cpus.c:412) ==54059== by 0x4EF343: qemu_wait_io_event (cpus.c:436) ==54059== by 0xD21E83: kvm_vcpu_thread_fn (kvm-accel-ops.c:54) ==54059== by 0xFFEBF3: qemu_thread_start (qemu-thread-posix.c:556) ==54059== by 0x54E6DC3: start_thread (in /usr/lib64/libc.so.6) ==54059== by 0x5596C9F: clone (in /usr/lib64/libc.so.6) ==54059== Address 0x799d1cc is on thread 3's stack ==54059== in frame #2, created by kvmppc_put_books_sregs (kvm.c:851) ==54059== Uninitialised value was created by a stack allocation ==54059== at 0xAFAEB0: kvmppc_put_books_sregs (kvm.c:851) This happens because Valgrind does not consider the 'sregs' initialization done by kvm_vcpu_ioctl() at the end of the function. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel Henrique Barboza --- target/ppc/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 42814e1b97..9a2ee761d2 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -851,7 +851,7 @@ static int kvm_put_vpa(CPUState *cs) int kvmppc_put_books_sregs(PowerPCCPU *cpu) { CPUPPCState *env = &cpu->env; - struct kvm_sregs sregs; + struct kvm_sregs sregs = { }; int i; sregs.pvr = env->spr[SPR_PVR]; From patchwork Thu Mar 31 00:17:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Daniel Henrique Barboza X-Patchwork-Id: 12796594 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8793C433EF for ; Thu, 31 Mar 2022 00:33:25 +0000 (UTC) Received: from localhost ([::1]:56808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nZike-0002NN-Qu for qemu-devel@archiver.kernel.org; Wed, 30 Mar 2022 20:33:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37104) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nZiVh-0006AJ-5Q; Wed, 30 Mar 2022 20:17:58 -0400 Received: from [2001:4860:4864:20::35] (port=42704 helo=mail-oa1-x35.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nZiVf-0003PW-QV; Wed, 30 Mar 2022 20:17:56 -0400 Received: by mail-oa1-x35.google.com with SMTP id 586e51a60fabf-de3ca1efbaso23729620fac.9; Wed, 30 Mar 2022 17:17:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=91ShIgpwNWCBuBbxRpeNrUDy7Nsh7D/rbmK6SUKEBDs=; b=R6BjLQJTxu3+vmuAE2E3R3JPGlZDeoNNla2eRTpMKW1UZUpTvanoeoKa9zqp9iF/cN ySCjWXygkBdPh4QUdAS2w5mar7iakDvgMA6ws2Rv2QYZHoNPMuulUcF82ePCu6OIzCEG SG2h22zz4WKZgSCBhAoHDOc8sGxeZLByZ2kvyF6uDTLe2/BIEEgIGvfdN1tU+fcEsg31 oh0qOs4S4g6goxUyPDwLBbQQRD9YLA9mq0lRYW5cbNKpEiprRj9lUZv6egjIdGGw/Uy5 xX2Py7cV2M2PG5vclb4Fmakqy/DXwal8h0/7R5DLSkRtVTvzJOc+HE4EOncPSo2cuevx tcrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=91ShIgpwNWCBuBbxRpeNrUDy7Nsh7D/rbmK6SUKEBDs=; b=2u1t06iuApzLA2/XEStULK/QCfqu7xoMkDlDRFAD1CGALo0ZjxHB8JboLPufVq8cCT zHLS4OeK8+8gxJDjGMYabmi9e4YPrc2ijp3XaSgiBCUB1CAb8gXUM+fpWzDwJh7u2EEq f/JaKTH9hij3lPH6B/73IAWGUj7CjxvA9fh5NOBUCItWMJM/m4aJDgjxykguRIYIUxn5 CygQAiBFj1jCiIW4QR4Wi3B9Vj109Ntr8uvXTY6zAWF2WpbJYa7bwfaJnOG2yr5s3sff CzLIYEWGY1GUuMKjYLBBhjO4bu0GErHWptyBYcr3R8JNL9CUyf2YuZ2xFwuZtX01TdYe D7LA== X-Gm-Message-State: AOAM53377MY9c12w4QOw5zsNjO17w8mU6x/jnT1Exmo7TK7b8LkRYx/6 D9hiNQ2CufxCNhj3mZWmnbxTb1RseFc= X-Google-Smtp-Source: ABdhPJwUU8g+NxJe0iPLXzYsYBk7x6RO/MkJdJ1Z1syDJ50gKC+qcEd4MDqgq26zqZAX8NUPCZ652w== X-Received: by 2002:a05:6870:9611:b0:df:200f:a6dd with SMTP id d17-20020a056870961100b000df200fa6ddmr1319646oaq.299.1648685870660; Wed, 30 Mar 2022 17:17:50 -0700 (PDT) Received: from rekt.ibmuc.com ([2804:431:c7c6:abe8:ed:2c78:ab0c:7946]) by smtp.gmail.com with ESMTPSA id j126-20020acab984000000b002da77222b7dsm11149190oif.22.2022.03.30.17.17.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Mar 2022 17:17:50 -0700 (PDT) From: Daniel Henrique Barboza To: qemu-devel@nongnu.org Subject: [PATCH v2 4/4] target/ppc: init 'rmmu_info' in kvm_get_radix_page_info() Date: Wed, 30 Mar 2022 21:17:17 -0300 Message-Id: <20220331001717.616938-5-danielhb413@gmail.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220331001717.616938-1-danielhb413@gmail.com> References: <20220331001717.616938-1-danielhb413@gmail.com> MIME-Version: 1.0 X-Host-Lookup-Failed: Reverse DNS lookup failed for 2001:4860:4864:20::35 (failed) Received-SPF: pass client-ip=2001:4860:4864:20::35; envelope-from=danielhb413@gmail.com; helo=mail-oa1-x35.google.com X-Spam_score_int: -3 X-Spam_score: -0.4 X-Spam_bar: / X-Spam_report: (-0.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Daniel Henrique Barboza , qemu-ppc@nongnu.org, clg@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Init the struct to avoid Valgrind complaints about unitialized bytes, such as this one: ==39549== Syscall param ioctl(generic) points to uninitialised byte(s) ==39549== at 0x55864E4: ioctl (in /usr/lib64/libc.so.6) ==39549== by 0xD1F7EF: kvm_vm_ioctl (kvm-all.c:3035) ==39549== by 0xAF8F5B: kvm_get_radix_page_info (kvm.c:276) ==39549== by 0xB00533: kvmppc_host_cpu_class_init (kvm.c:2369) ==39549== by 0xD3DCE7: type_initialize (object.c:366) ==39549== by 0xD3FACF: object_class_foreach_tramp (object.c:1071) ==39549== by 0x502757B: g_hash_table_foreach (in /usr/lib64/libglib-2.0.so.0.7000.5) ==39549== by 0xD3FC1B: object_class_foreach (object.c:1093) ==39549== by 0xB0141F: kvm_ppc_register_host_cpu_type (kvm.c:2613) ==39549== by 0xAF87E7: kvm_arch_init (kvm.c:157) ==39549== by 0xD1E2A7: kvm_init (kvm-all.c:2595) ==39549== by 0x8E6E93: accel_init_machine (accel-softmmu.c:39) ==39549== Address 0x1fff00e208 is on thread 1's stack ==39549== in frame #2, created by kvm_get_radix_page_info (kvm.c:267) ==39549== Uninitialised value was created by a stack allocation ==39549== at 0xAF8EE8: kvm_get_radix_page_info (kvm.c:267) Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Daniel Henrique Barboza --- target/ppc/kvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c index 9a2ee761d2..a3130013b3 100644 --- a/target/ppc/kvm.c +++ b/target/ppc/kvm.c @@ -267,7 +267,7 @@ struct ppc_radix_page_info *kvm_get_radix_page_info(void) { KVMState *s = KVM_STATE(current_accel()); struct ppc_radix_page_info *radix_page_info; - struct kvm_ppc_rmmu_info rmmu_info; + struct kvm_ppc_rmmu_info rmmu_info = { }; int i; if (!kvm_check_extension(s, KVM_CAP_PPC_MMU_RADIX)) {