From patchwork Thu Mar 31 11:24:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Austin Kim X-Patchwork-Id: 12796986 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 810B0C433F5 for ; Thu, 31 Mar 2022 11:25:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Subject:Cc:To: From:Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=dVu28BnPIF86tFQ22EMGvdnnyGFhWW4tnMag2Wqew84=; b=xk1qrSINenXRYG o4dFy3i1RWEtWh/BsKPlku0f33Vi/n/zRICiuKEYjv1AW41WC1mq+nZCnq/4+2PhzHsvYwKoJASAz dYqs0kZgIhrxxOA9U+nqzT6eEWAQUOuKFm2OCZmj6VrSK1aKvqtm23Zv66UfsoRSHd7V47VEd4bAy 39qWjabzfBfEgXxEjRFumdU8dXJiim1AJVj4dUPTbfzDJleOJouJwlvdMrXeE4JRGT7F681rwdJ9G 4l7MYEh7a0Qh7rrrOkktaiHekJttq1OcVbVMdVkMadh7bDi3aF3CR+pzz7bTbi8u7n88v/dTLdMI4 Y8eMJ2Aaqs0AwWKP45WA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZsuh-0021jH-Cb; Thu, 31 Mar 2022 11:24:27 +0000 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZsue-0021gv-23 for linux-arm-kernel@lists.infradead.org; Thu, 31 Mar 2022 11:24:25 +0000 Received: by mail-pl1-x62d.google.com with SMTP id a16so6195169plh.13 for ; Thu, 31 Mar 2022 04:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=i57N+tGNg9+lxUlQKsWwq5Omt6VcQdu96X0KROKr1/k=; b=KtqlA9fX/tJSJ02dmocwpAP424iX3FqSF65XaMLx81Uaubal027nAO76/jDh9EelCQ CXOr5jfPzHhERNgPvaSFHrrdb813KKHX3/GeQQiP/Wjh+ANE3dD7DLqxWMdDW7zmZaLi WTK21c7ESmN2y5EmUTLI3rNGuBTER4hMGiqfajejPzkmaBL35k1zsfe7+j2qFDAPzQ1S Vaxonxny+3ueKDkJNqaZQOPFEYg9BNFUK8QwH28NxXJh3V29BkJvUs732E8+zEciHZBX VU4oVld459kWWj3uQZr+YhGMPBlX4xY5VKA8PnBZ6VFVqV74+A8r4eBBEqh30GsYJk7r 4fbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=i57N+tGNg9+lxUlQKsWwq5Omt6VcQdu96X0KROKr1/k=; b=rowTEflONZMXK3ljao4OVdFJnsrfMyW+XtVFlHd37LGVLI4M8N9K3jlTPA+G/ityz6 +lMcShpf2OK6hL81SIm4VI+IR5V0jMLMOw6i0UuehJ5s3mnlrJibc2toyVb0gtW9Ar0x CG7Dg8qnjCJaCm8yJsRU/x/+pwuKlILjXt4Wll3e2A/7jOXyNSPCuIhOhe0DmZhVzgOu GTCqm7cTvM+ozF+lU1JMfG+gDBOYe/kiH9ExEsMICtaiu+TSN24JZ7eM9CBS/bY8lUwI NN54ki+vKl+b0pOaUuxhcXbHAKjBqg3/ft4VjoF+nUxhd8rVTmcWxI0j1ey7Sd9PXLd1 Bt7g== X-Gm-Message-State: AOAM5327//ne+/dry2mQ+e78FF6j8t5Kw34xzaedBiTCkgI8QOwEJV3M ScN57seHJn9WmRpV6xKCp6A= X-Google-Smtp-Source: ABdhPJztcnIK6iFTn+TcQVq5JU0xh1tEw3pqrLYDdKQiAGOlzjy4M214ICBNWrIIxeKGLQSIpQ3CBQ== X-Received: by 2002:a17:902:a404:b0:14b:1100:aebc with SMTP id p4-20020a170902a40400b0014b1100aebcmr41196969plq.133.1648725861768; Thu, 31 Mar 2022 04:24:21 -0700 (PDT) Received: from raspberrypi ([49.166.114.232]) by smtp.gmail.com with ESMTPSA id nv11-20020a17090b1b4b00b001c71b0bf18bsm9998073pjb.11.2022.03.31.04.24.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 04:24:21 -0700 (PDT) Date: Thu, 31 Mar 2022 12:24:16 +0100 From: Austin Kim To: linux@armlinux.org.uk, arnd@arndb.de Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, austin.kim@lge.com, p4ranlee@gmail.com Subject: [PATCH v2] arm: kdump: add invalid input check for 'crashkernel=0' Message-ID: <20220331112416.GA1002@raspberrypi> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220331_042424_132362_110E8C6F X-CRM114-Status: GOOD ( 12.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Austin Kim Add invalid input check expression when 'crashkernel=0' is specified running kdump. Signed-off-by: Austin Kim --- arch/arm/kernel/setup.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c index 039feb7cd590..1e8a50a97edf 100644 --- a/arch/arm/kernel/setup.c +++ b/arch/arm/kernel/setup.c @@ -1004,7 +1004,8 @@ static void __init reserve_crashkernel(void) total_mem = get_total_mem(); ret = parse_crashkernel(boot_command_line, total_mem, &crash_size, &crash_base); - if (ret) + /* invalid value specified or crashkernel=0 */ + if (ret || !crash_size) return; if (crash_base <= 0) {