From patchwork Fri Apr 1 01:58:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Liu Ying X-Patchwork-Id: 12797842 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 118F1C433F5 for ; Fri, 1 Apr 2022 01:56:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3957610E464; Fri, 1 Apr 2022 01:56:50 +0000 (UTC) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00085.outbound.protection.outlook.com [40.107.0.85]) by gabe.freedesktop.org (Postfix) with ESMTPS id F10E010E464 for ; Fri, 1 Apr 2022 01:56:48 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E1fPkXveBBoB7y1CMfeWzp4h+CqU0DlBHTB6Z2KbUvTnvZU7vIXpFVBBBuHB9S/DNHOW0d3l8SwSGclSiyTqBxMM3LN79P/4nr+koMnI9IQhPEtXnnFHxKQ0gHaIpX3Hng1hPDW4MIwqXN3eSqZcoUw2cexlH+ASI+tQYJtQGsq7yBIR9FcIv7DyOOWPia3K/VG8OuR9JrGHMmNHW7xAuV93x+7mnCInSOUskJaggittk8ELUpWyN+MJlxgT6+JRRsGl3syPY0uhAyYWr1Z7Vrb+AxlyUZVXR0sYq4G1tHFU3y/tJCe3Vl4CRtAvybDfq7TPEO54sbAB/W36oUUOew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v7TwW0iIZbjcAXIVc/N0IvnmdRWcq09kzIYPajxVeTA=; b=Xb8dN1DSS5d46Mqx0UDa6JOCQ+TS8Ckt3NV3HKzaQaq5uNIu8A4qYa7pDWIo2icUR3yKq5loHd8tjNeB5wnGx+2tDAp7ECmG0uJc/h6sgEVuwXTyPCkucD3Xh/fJkLg8Nv4jNUc+ahp1aX+UfV9XkMy7/3yN7xAQcTxVIe7Touj9wyo6pOZmU+5enA2utmrk5bTGFSv7nM9I2aF5R8/PSXKModiNLUmDlpu97ZPObpwQ7JxscG/TJFQIhH9oMKXNqDSPdm48L14Mosws4ACM4dKtWNVxVyxRRFCDoMwVUwbCKO6lulK0Zh6O79leNiErptxL3W1JEPuPBAdzD1NX2A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v7TwW0iIZbjcAXIVc/N0IvnmdRWcq09kzIYPajxVeTA=; b=E+8ndxFxEnu/xcz3lZFvz9HqVssCLxP09aSMz/yOWwxTWhze7QjDPz1iZF4d1rTZsFsw5XpPT+l63oQTJmMkC97D7giGiyNYGvnraGVX5ySH3a3NxkNGT3LhY8CUNtgYioUw0CrhonVJF83XDEyUNIZ19Jed2KiPp2md6zkffa4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) by AM5PR04MB2979.eurprd04.prod.outlook.com (2603:10a6:206:9::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.21; Fri, 1 Apr 2022 01:56:46 +0000 Received: from AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::b09c:8ffe:8e02:7387]) by AM7PR04MB7046.eurprd04.prod.outlook.com ([fe80::b09c:8ffe:8e02:7387%9]) with mapi id 15.20.5123.025; Fri, 1 Apr 2022 01:56:46 +0000 From: Liu Ying To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/bridge: nwl-dsi: Drop the drm_of_panel_bridge_remove() function call Date: Fri, 1 Apr 2022 09:58:28 +0800 Message-Id: <20220401015828.2959505-1-victor.liu@nxp.com> X-Mailer: git-send-email 2.25.1 X-ClientProxiedBy: SG2PR04CA0196.apcprd04.prod.outlook.com (2603:1096:4:14::34) To AM7PR04MB7046.eurprd04.prod.outlook.com (2603:10a6:20b:113::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b82abea-23af-46bc-4d5a-08da1382e041 X-MS-TrafficTypeDiagnostic: AM5PR04MB2979:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vx/y4MpnrtsMo+ViVFprZqjVp7iAUGK+OqioU4trvVi5vU7s4uYnQHtPF5AmrppasvD4Kc5m8BUlO/DU21OtZvjpOMx1eBLUMgmkv1aD8oRucoyub+QUHIBK90H2lJhXsDm9DcAM/P9KKXhNU6RKmuxGv7CFGkIvQAo5ICJoQ27P1bFBMeW7N3Z+0NbvFR1gltKqIAFDgpjuHVVN2sW0nHpxPwKJkWjfKEShMyZ3cHSInsdaNr2d8QqCbWme8juCfl28Dh8NFHpmP72G2N5bonW+OWmJTXdMyMChmYm0s1SllqwDpkFrgi8Xk12DxyFGSyomROcmFthLyrKSxU7tv7WBjTrhCf4NMAuKNUi39b8mXPCLGaB/M8FaPdNfHZ7tUn9Tg4ID54aAYpVc51Tq/m6ADJhyLkwHT7sZsF4BnGLRaFsVuBZkKVQfN0Ohwgn3LmRKy+2Xz5xECZ6AyRZtC0bQNTr6AEW84FV6dFxmRNGpEqvlDgqwAorvAxt0f//3Xeg8omZFIJXtyCOsQsSFTQJ8WHWdKPKlhpD2sgpj9IxSScbbhb7g7Os8wgKNNtKwNk8Wm/nHtKGimPjjWJQE4ZE01WWbG6Vi/wdoGKG0faLafBKI17Parynn5aOYPHxWQKZyPL9peG5iUw3/TRfqavxOX0uEYB2t8j7SaKSgr/YIR+vilM5qVyTWxZtFtI+7a5dUvtaKPJPUB4CLgg6qYA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM7PR04MB7046.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(1076003)(2616005)(186003)(8936002)(36756003)(6512007)(2906002)(26005)(83380400001)(86362001)(5660300002)(52116002)(316002)(54906003)(38100700002)(66946007)(4326008)(6506007)(6666004)(66556008)(66476007)(38350700002)(6486002)(8676002)(508600001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?GPPBDJz3hX/cWiWyJRLsqNk/O7Xm?= =?utf-8?q?cfba7OFcjJByiui7ItKw0yf51D0xqt9W0enT8QRsNSnVofb6AtfxYynQjQcBPGr93?= =?utf-8?q?xPWTuXzkxSg6KZgBmwKNV2DF/4QtFb0DgrHVtWGjjbOj++scrxV9fiY8FvgWoFqbl?= =?utf-8?q?Sd8qFfOFFNsDJqHKCpSyrzgbpEBuj2UyK4gcAYetgUUwEsUxB1OwQFARX3WrY3svl?= =?utf-8?q?iCC5dZzT+oloj7zGrJjQW1+9iizK+YH4nSjrPcen7rTQYLBQVSftZ5jrU/Ps05xGx?= =?utf-8?q?J4KSTq3lBbwL/tLe0WqilNSnYV5Jwy3dtbFEu3USBIvHC5Glu6Rk0Jvava0IgyxpU?= =?utf-8?q?9MVGjUlbnEbmf4vuIIKxxn6DQSKuzDyP5FFDuAWeHDitxIPNLkArOvqLwYXKosqjN?= =?utf-8?q?DOAXO4Ji0690tHQKuCEtBz6XHlL3MKSBww8mm0qMaCkzp3lKvLm4UxhWN/ut8FTyC?= =?utf-8?q?95tBd53WaWB0NvkIcWwzh3HlHRDpGlDAZZOlxHP6JveP/WKq4/x+ln/MJfWMRlDP+?= =?utf-8?q?kMN6Ttjo0F809jFIQtvOACCijWrinhS0V7iR8eoUQ8uW8DfStw8plbGbrtW2HlC4s?= =?utf-8?q?NUS2nEUfaDvDP9H9TYTjNdlCgS4KHoAdtUR/XlqrrBNMULABX8gEjs37n8HgKdOKN?= =?utf-8?q?PPzxRODuezXy4psVFTNEmT0Rb2qH7dQVssHKaTzYSPcrk8Tm3eDPgKaU0hwI4UuAh?= =?utf-8?q?ZBTczGsWxC79bK/E+Ginv/FzlWSMyRF1T5/rH29xCjoS0wNlG9LfoMeY108M2IPiL?= =?utf-8?q?mQeKZvbVYbghybATbzG+ZOsk1zqL+KosE6gaCruAMRkjSbnIqwsNufihthjkpo/ch?= =?utf-8?q?9+mAMWgq5wIOWZVvLVK9FdPLEG9HXf2IlfhtDYfwuAM8P4qA5/q/tEBdgFGVSpdIB?= =?utf-8?q?PMX4OCU+hYP2gtUz0B16whbYDnK3zgjMBVPB0jMIjkR0SZ8sKc+mgqMm5oI87tJAk?= =?utf-8?q?JreF+dq+3eskMXusXX5OlAUaR/QxtSkocsQra5Tc/I2ptJ6ALWLi1Dv04HJ9TPQS5?= =?utf-8?q?6YBTb1MRJAuLJ4jGu30ejsJWP38mk7HqBx2reHKJdYORWd5MUCWsNEBAUmUD/hCsU?= =?utf-8?q?oobUKbQFSjmbPEtfMBtAHr28aGMwMIN96CNVGKt7BctVRXXQnR+uSUIwKXjmXI/AB?= =?utf-8?q?41UDOewUg2wPuH9oBJNRGvTw62e4pOkLP5tx1dpPuZBQlO6cXdHZiMtFGYLaWRm0i?= =?utf-8?q?pyFnb5XcDhe715N4WamirR6ACTBhoBrseW4sP3wFpTfu7Svj5glZjFzdiScFLz9jL?= =?utf-8?q?JOVyJ0ljrNvur3FPTFse9t+lX9AThniLzUqpaYH7BHhMXJcb+NvvwgWvyli9xJ82N?= =?utf-8?q?gJwLn+DgqmeivtDq/Q9WHeMPz6ktKN+TkTGYW6/IWMTKRiN66RHst5fUc/iANct9R?= =?utf-8?q?9MQoq2Z02I/PUwFkb6r6EoCNDgzp4wgPWa8EE0FBpjr1Z/ZROJvFV0WELccQbBOku?= =?utf-8?q?E4ZGdt2ArCEgxVUvUZC05vsnCMc9y9CGlo6VoerfYy609LeqIkiB0VJV9RfkyUJHe?= =?utf-8?q?xb1Mq1EaM1vg0EC5n37H46QIMk4Rmu2KWHdFoJ82PQBdtxockn9q6uE9xU/ZoawfX?= =?utf-8?q?nlA1LDbyBiQUEfkDxGvBzKXceXvR8j2e+g6pbSVG6iTykZA21Ye2eRuOZoNktXs6l?= =?utf-8?q?MHSKb7fZ4CjQljFXrA53tCFndpGuzeBw=3D=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b82abea-23af-46bc-4d5a-08da1382e041 X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 01:56:45.9148 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vk5k27pqoYPMzRYw+RW63tBivGDRbqbKQi+7dr7bOcTdNQ/sRY4p5fXzky+yv5GZGCdPVwaUSV+oRe0PnGgBCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR04MB2979 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?q?Guido_G=C3=BCnther?= , Jagan Teki , Robert Foss , NXP Linux Team Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Since this driver has been changed to use the resource managed devm_drm_of_get_bridge() to get bridge from ->attach(), it's unnecessary to call drm_of_panel_bridge_remove() to remove the bridge from ->detach(). So, let's drop the drm_of_panel_bridge_remove() function call. As nwl_dsi_bridge_detach() only calls drm_of_panel_bridge_remove(), it can also be dropped. Cc: Robert Foss Cc: Guido Günther Cc: Jagan Teki Cc: NXP Linux Team Signed-off-by: Liu Ying Reviewed-by: Jagan Teki --- drivers/gpu/drm/bridge/nwl-dsi.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c b/drivers/gpu/drm/bridge/nwl-dsi.c index a549da5b3f93..47859d4506b4 100644 --- a/drivers/gpu/drm/bridge/nwl-dsi.c +++ b/drivers/gpu/drm/bridge/nwl-dsi.c @@ -919,12 +919,6 @@ static int nwl_dsi_bridge_attach(struct drm_bridge *bridge, return drm_bridge_attach(bridge->encoder, panel_bridge, bridge, flags); } -static void nwl_dsi_bridge_detach(struct drm_bridge *bridge) -{ struct nwl_dsi *dsi = bridge_to_dsi(bridge); - - drm_of_panel_bridge_remove(dsi->dev->of_node, 1, 0); -} - static u32 *nwl_bridge_atomic_get_input_bus_fmts(struct drm_bridge *bridge, struct drm_bridge_state *bridge_state, struct drm_crtc_state *crtc_state, @@ -970,7 +964,6 @@ static const struct drm_bridge_funcs nwl_dsi_bridge_funcs = { .mode_set = nwl_dsi_bridge_mode_set, .mode_valid = nwl_dsi_bridge_mode_valid, .attach = nwl_dsi_bridge_attach, - .detach = nwl_dsi_bridge_detach, }; static int nwl_dsi_parse_dt(struct nwl_dsi *dsi)