From patchwork Fri Apr 1 13:35:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Lautrbach X-Patchwork-Id: 12798298 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9CC4C433EF for ; Fri, 1 Apr 2022 13:36:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240163AbiDANht (ORCPT ); Fri, 1 Apr 2022 09:37:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234797AbiDANht (ORCPT ); Fri, 1 Apr 2022 09:37:49 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 2007E182DAA for ; Fri, 1 Apr 2022 06:36:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648820159; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=jyOpF8iXSL5FtcGfyQ/43tJ/GA+/2R5Khbv7zgwvl0M=; b=e2lfddlSFBwEM9L9Rur0487+Yx91Cisdo9uRhJ1ametL3fiCfid0TgmdeFM54DeFMGjUUl HIf2qyOXPPiuxfQOjjVAYV/Fnwmr98Ccf9pbBzGaUtZf5+2uHJzbOjK5Xtd3ncclVs5Ggk RC5naj9cQDR6o2MNoqccwbeJK+4mY0k= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-662-jCKZqlqpORK3kwF02CDUQg-1; Fri, 01 Apr 2022 09:35:55 -0400 X-MC-Unique: jCKZqlqpORK3kwF02CDUQg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C2E68185A7BA for ; Fri, 1 Apr 2022 13:35:54 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1D5E34010A2D; Fri, 1 Apr 2022 13:35:53 +0000 (UTC) From: Petr Lautrbach To: selinux@vger.kernel.org Cc: Petr Lautrbach Subject: [PATCH 1/3] libsemanage: Fix USE_AFTER_FREE (CWE-672) in semanage_direct_get_module_info() Date: Fri, 1 Apr 2022 15:35:47 +0200 Message-Id: <20220401133549.122069-1-plautrba@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org >From fclose(3): Upon successful completion, 0 is returned. Otherwise, EOF is returned and errno is set to indicate the error. In either case, any further access (including another call to fclose()) to the stream results in undefined behavior. Signed-off-by: Petr Lautrbach Acked-by: James Carter --- libsemanage/src/direct_api.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libsemanage/src/direct_api.c b/libsemanage/src/direct_api.c index d83941b05ca1..d5716ce579e9 100644 --- a/libsemanage/src/direct_api.c +++ b/libsemanage/src/direct_api.c @@ -2293,6 +2293,7 @@ static int semanage_direct_get_module_info(semanage_handle_t *sh, tmp = NULL; if (fclose(fp) != 0) { + fp = NULL; ERR(sh, "Unable to close %s module lang ext file.", (*modinfo)->name); From patchwork Fri Apr 1 13:35:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Lautrbach X-Patchwork-Id: 12798299 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5679BC433F5 for ; Fri, 1 Apr 2022 13:36:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245196AbiDANhw (ORCPT ); Fri, 1 Apr 2022 09:37:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234797AbiDANhv (ORCPT ); Fri, 1 Apr 2022 09:37:51 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 81F2818383A for ; Fri, 1 Apr 2022 06:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648820161; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/APoZMCYR14ys76aaGjDb7h8Aie7VV6DLr4eQ+tun34=; b=Nl4g0hgX0sJ+qlK9uOF27DDDctHItKaD+9LX3pvcNhITPdXDGurvgFC4v8pmwDU6ol5hob mS0plVv1IMaJaK/8xNhGzY9zaX2+1rOR+4E1YJFTrBMqQf/JQ4/7Yn2cGkBk6xhjqDKDe7 lygDYYFUvwz5V/ieBHIKw2g4mBCbxYM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-378-5DeFH22TNCu3kbNal43p_g-1; Fri, 01 Apr 2022 09:36:00 -0400 X-MC-Unique: 5DeFH22TNCu3kbNal43p_g-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0E6BF811E76 for ; Fri, 1 Apr 2022 13:36:00 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5AAA540C1438; Fri, 1 Apr 2022 13:35:59 +0000 (UTC) From: Petr Lautrbach To: selinux@vger.kernel.org Cc: Petr Lautrbach Subject: [PATCH 2/3] semodule_package: Close leaking fd Date: Fri, 1 Apr 2022 15:35:48 +0200 Message-Id: <20220401133549.122069-2-plautrba@redhat.com> In-Reply-To: <20220401133549.122069-1-plautrba@redhat.com> References: <20220401133549.122069-1-plautrba@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org Signed-off-by: Petr Lautrbach --- semodule-utils/semodule_package/semodule_package.c | 1 + 1 file changed, 1 insertion(+) diff --git a/semodule-utils/semodule_package/semodule_package.c b/semodule-utils/semodule_package/semodule_package.c index 3515234e36de..bc8584b51079 100644 --- a/semodule-utils/semodule_package/semodule_package.c +++ b/semodule-utils/semodule_package/semodule_package.c @@ -73,6 +73,7 @@ static int file_to_data(const char *path, char **data, size_t * len) goto err; } if (!sb.st_size) { + close(fd); *len = 0; return 0; } From patchwork Fri Apr 1 13:35:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Lautrbach X-Patchwork-Id: 12798300 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDC58C433EF for ; Fri, 1 Apr 2022 13:36:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346406AbiDANiH (ORCPT ); Fri, 1 Apr 2022 09:38:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37434 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346407AbiDANhz (ORCPT ); Fri, 1 Apr 2022 09:37:55 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6B2F218383A for ; Fri, 1 Apr 2022 06:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1648820165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6qCEz/9ZttHm40fOppDP2qHIaDBA3UgD8dN6t0mdZVY=; b=ca1vZtMrsl9HLdc7hHkOnGWEcysfebgFbU+9iBLcYOzdogzs7grG/gi6xrZlY5Db4FL5sk xr6dhnrcjNblCRkjMfUS3raq7SgkMag8PBYmYdLQE0CZxAEcoVZ/RaN7eaUp85jp5L1ahO yPAwt/ZeUOPRauXLFKrY/ScQ9VzCHt4= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-34-RUXRU_CtN_mnyXl6i-TOJA-1; Fri, 01 Apr 2022 09:36:03 -0400 X-MC-Unique: RUXRU_CtN_mnyXl6i-TOJA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 98B9C3C00089 for ; Fri, 1 Apr 2022 13:36:03 +0000 (UTC) Received: from localhost.localdomain (unknown [10.40.194.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id D91AE40D1B9B; Fri, 1 Apr 2022 13:36:02 +0000 (UTC) From: Petr Lautrbach To: selinux@vger.kernel.org Cc: Petr Lautrbach Subject: [PATCH 3/3] mcstrans: Fir RESOURCE_LEAK and USE_AFTER_FREE coverity scan defects Date: Fri, 1 Apr 2022 15:35:49 +0200 Message-Id: <20220401133549.122069-3-plautrba@redhat.com> In-Reply-To: <20220401133549.122069-1-plautrba@redhat.com> References: <20220401133549.122069-1-plautrba@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.2 Precedence: bulk List-ID: X-Mailing-List: selinux@vger.kernel.org --- mcstrans/src/mcstrans.c | 25 ++++++++++++++++++++++++- mcstrans/src/mcstransd.c | 4 +++- 2 files changed, 27 insertions(+), 2 deletions(-) diff --git a/mcstrans/src/mcstrans.c b/mcstrans/src/mcstrans.c index d42760fdbfc2..af3f507ef718 100644 --- a/mcstrans/src/mcstrans.c +++ b/mcstrans/src/mcstrans.c @@ -632,16 +632,23 @@ add_cache(domain_t *domain, char *raw, char *trans) { map->raw = strdup(raw); if (!map->raw) { + free(map); goto err; } map->trans = strdup(trans); if (!map->trans) { + free(map->raw); + free(map); goto err; } log_debug(" add_cache (%s,%s)\n", raw, trans); - if (add_to_hashtable(domain->raw_to_trans, map->raw, map) < 0) + if (add_to_hashtable(domain->raw_to_trans, map->raw, map) < 0) { + free(map->trans); + free(map->raw); + free(map); goto err; + } if (add_to_hashtable(domain->trans_to_raw, map->trans, map) < 0) goto err; @@ -1568,6 +1575,7 @@ trans_context(const char *incon, char **rcon) { trans = compute_trans_from_raw(range, domain); if (trans) if (add_cache(domain, range, trans) < 0) { + free(trans); free(range); return -1; } @@ -1579,6 +1587,7 @@ trans_context(const char *incon, char **rcon) { ltrans = compute_trans_from_raw(lrange, domain); if (ltrans) { if (add_cache(domain, lrange, ltrans) < 0) { + free(ltrans); free(range); return -1; } @@ -1597,6 +1606,7 @@ trans_context(const char *incon, char **rcon) { utrans = compute_trans_from_raw(urange, domain); if (utrans) { if (add_cache(domain, urange, utrans) < 0) { + free(utrans); free(ltrans); free(range); return -1; @@ -1636,6 +1646,10 @@ trans_context(const char *incon, char **rcon) { } if (dashp) *dashp = '-'; + if (trans) { + free(trans); + trans = NULL; + } } if (trans) { @@ -1696,7 +1710,9 @@ untrans_context(const char *incon, char **rcon) { canonical = compute_trans_from_raw(raw, domain); if (canonical && strcmp(canonical, range)) if (add_cache(domain, raw, canonical) < 0) { + free(canonical); free(range); + free(raw); return -1; } } @@ -1704,6 +1720,7 @@ untrans_context(const char *incon, char **rcon) { free(canonical); if (add_cache(domain, raw, range) < 0) { free(range); + free(raw); return -1; } } else { @@ -1721,6 +1738,7 @@ untrans_context(const char *incon, char **rcon) { canonical = compute_trans_from_raw(lraw, domain); if (canonical) if (add_cache(domain, lraw, canonical) < 0) { + free(canonical); free(lraw); free(range); return -1; @@ -1752,6 +1770,7 @@ untrans_context(const char *incon, char **rcon) { canonical = compute_trans_from_raw(uraw, domain); if (canonical) if (add_cache(domain, uraw, canonical) < 0) { + free(canonical); free(uraw); free(lraw); free(range); @@ -1802,6 +1821,10 @@ untrans_context(const char *incon, char **rcon) { } if (dashp) *dashp = '-'; + if (raw) { + free(raw); + raw = NULL; + } } if (raw) { diff --git a/mcstrans/src/mcstransd.c b/mcstrans/src/mcstransd.c index 536c0f32f23a..42262e580386 100644 --- a/mcstrans/src/mcstransd.c +++ b/mcstrans/src/mcstransd.c @@ -328,6 +328,7 @@ process_events(struct pollfd **ufds, int *nfds) /* Setup pollfd for deletion later. */ (*ufds)[ii].fd = -1; close(connfd); + connfd = -1; /* So we don't get bothered later */ revents = revents & ~(POLLHUP); } @@ -341,10 +342,11 @@ process_events(struct pollfd **ufds, int *nfds) /* Set the pollfd up for deletion later. */ (*ufds)[ii].fd = -1; close(connfd); + connfd = -1; revents = revents & ~(POLLHUP); } - if (revents) { + if (revents && connfd != -1) { syslog(LOG_ERR, "Unknown/error events (%x) encountered" " for fd (%d)\n", revents, connfd);