From patchwork Fri Apr 1 14:37:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 12798417 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE0F4C433EF for ; Fri, 1 Apr 2022 14:38:56 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.297449.506729 (Exim 4.92) (envelope-from ) id 1naIQG-0006oE-DE; Fri, 01 Apr 2022 14:38:44 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 297449.506729; Fri, 01 Apr 2022 14:38:44 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1naIQG-0006o7-A3; Fri, 01 Apr 2022 14:38:44 +0000 Received: by outflank-mailman (input) for mailman id 297449; Fri, 01 Apr 2022 14:38:42 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1naIQE-0005di-AC for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 14:38:42 +0000 Received: from esa2.hc3370-68.iphmx.com (esa2.hc3370-68.iphmx.com [216.71.145.153]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 6b692d95-b1c9-11ec-8fbc-03012f2f19d4; Fri, 01 Apr 2022 16:38:40 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 6b692d95-b1c9-11ec-8fbc-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1648823920; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=/OHwMK2W43W0KGDBL0BTrku1ipd+E49VxB19lUZP2O0=; b=UOVl8ASfl5GShTg+P21h+ElLuscUZeI8Jji1MpaFoE4T1JFJRTvTUK1v meHz/gsMrGMtUcCOQ/uRSrLOzpdFOKmVtdSUHbPfXKWOmfg0xEg4u6QH8 CsgBkKI4EzU8dP7j8qcVvywoNTTnip+NcW/HfveEiYpWUbWoRuiyRMb2t o=; Authentication-Results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 67788491 X-Ironport-Server: esa2.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:ah1P46x90oQXAl1BAJd6t+dNxirEfRIJ4+MujC+fZmUNrF6WrkUDn GUZDTiEaP3bN2KgKdF+PYXg9BxS6JbVydViGwc9+yAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY02YHhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ Nplq428TgQtG4f1hcMaCz99A3tYPe54weqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2J8RTaaCN pNxhTxHR0XMaSUUBxAsFa0AzfWatED2KTFbpwfAzUYwyzeKl1EguFT3C/LKfvSaSMMTmVyXz krW8mK8DhwEOdi3zTue7mnqluLJhTn8Wo8ZCPu/7PECvbGI7jVNUltMDwL9+KTnzB7lMz5CF 6AK0jQ/oa8x8GmBd8TaWEWehW7emB5fZeMFRoXW9zqx4qbT5g+YAE0NQThAdMEquacKeNA66 rOat4i3XGIy6dV5XVrYr+7J9m3qZUD5OEdYPUc5oR05D84PSW3ZpjbGVZ5dHaG8lbUZ8hmgk mnR/EDSa1j+5PPnNplXH3ia21pARbCTF2bZAzk7uEr/sWuVg6b/O+SVBaDzt6ooEWpgZgDpU II4s8af9vsSKpqGiTaARu4AdJnwuarVb2CG2wY+TsR8n9hIx5JFVdoPiN2ZDB00WvvohBezO BOD0e+vzME70ISWgV9fPNvqVpVCIVnIHtX5TPHEBueikbAqHDJrCBpGPBbKt0i0yRBEufhmZ f+zLJb9ZV5HWP8P5GfnGI8gPUoDm3lWKZX7HsugkXxKENO2ORaodFvyGADQNrpgtvPV/V29H hQ2H5Li9iizmdbWO0H/2YUSMUoLPT48A5X3oNZQbemNPkxtH2RJNhMb6epJl1BN90iNqtr1w w== IronPort-HdrOrdr: A9a23:MkXqe612+7eaxtpPs0ZvFAqjBURyeYIsimQD101hICG9Lfb2qy n+ppgmPEHP5Qr5OEtApTiBUJPwJU80kqQFm7X5XI3SJzUO3VHHEGgM1/qF/9SNIVydygc/79 YeT0EdMqyIMbESt6+Ti2PZYrUdKbG8gdyVbIzlvhBQpG9RGsRdB1ATMHfnLqQ6fngxObMJUL 6nouZXrTupfnoaKuy9G3k+RuDG4/nGjojvbxIqDwMurFDmt0Lh1JfKVzyjmjsOWTJGxrkvtU DDjgzC/62m99W20AXV2WP/54lf3PHh1txALsqRjdV9EESkti+YIKBaH5GStjE8p++irH4sjd n3uh8le/9+7nvAF1vF1CfF6k3F6nID+nXiwViXjT/IusriXg83DMJHmMZwbgbZw1BIhqAw7I t7m0ai87ZHBxLJmyrwo/LSUQtxq0ayqX0+1cYOkn1kV5cEYrM5l/1UwKpsKuZOIMvG0vFoLA E3Z/uspcq+MGnqJEwxh1MfjOBFBR8Ib1e7qktrgL3m79EZpgE786Ii/r1vop4xzuNCd3B63Z W1Dk0RrsA3ciY3V9MIOA5Te7rBNoTyKSi8Q156Z26XVp06Bw== X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; d="scan'208";a="67788491" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CFiuzCjOlIrhdZYuKlhYgyK4O9dhq+9EQiDR0v4W5uEzXcpVYjz6ztXC+MASFMN6/6vP8vN8/dLL5PDLPAIGU5nddulvngYLi7bLg3AMOc88dCOBgFqM0wegndb1DgtN9RTwyfxVK2xfeemyrr4MJLoV/0XH8jWCSkKZqDHrCyjc/xRK61MuvMuCEobVpN4mjN2pJvcNxCDtX+tfyPSdflFEKgxwmTLqx8gqRnvIAFkiIhyncHtkRygRVw1QaAu+flkpNzj3qa0h6mM60Qc9/U+MwBq86dajwel7UCuw6FwEsk5Zl9qPyGjaK5cbYCCTJScdydV46YtXPo+2lK6e9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TYFUjWIXSm5BoiX9qqkGPY3DZbe1Ux6jWsFf+dsp8l0=; b=OFL9nZFLZn+gMkl8z+fQ2sPzEguNvRqHmNDHfQZ6vIr0n6xK0oFiadLxoohcRN9kljjg8R3RWd2dfIRlB5iSXY8QPTXtIf9vXz0E2qyYmyugqGNu7d4zWOA5JY1MvbL7r8DaFLMePlJY+C/jmb9QRT51P19a1+umh8AwaJPDgGhq96ekxjVgCPCeFWb2Lgf3wOZ+y8L7xMZ+AyfUx7vJ9jPQlkyesxoOYHuvtupDTjYHnkmAay8rO72HmUP0Qzd771NBId1NPZ6OttxumOmZjsp6HS+h52ndnQpBZ8quIB7TaKmvWPmBk2wOkeeIn7jY5mO2ONVOOdD5eWYW9e+dvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TYFUjWIXSm5BoiX9qqkGPY3DZbe1Ux6jWsFf+dsp8l0=; b=a2m04+EYfCt77mJM25+eh4xDxLUog3NOwy5TDN3kKDPcV+AbkrOb1p9TSupH4LI5vmZDChSL4FO58qA84DeE1viLzHxG2yGuLK+DXvU4VK8Anp1N3sSOkXmP8ZSwDspCmbwSyrNR0AovOkz6AEA5yhV449MuSwFOBlvdH/WBAnM= From: Roger Pau Monne To: CC: Roger Pau Monne , Wei Liu , Anthony PERARD Subject: [PATCH 1/2] tools/firmware: fix setting of fcf-protection=none Date: Fri, 1 Apr 2022 16:37:18 +0200 Message-ID: <20220401143720.23160-2-roger.pau@citrix.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220401143720.23160-1-roger.pau@citrix.com> References: <20220401143720.23160-1-roger.pau@citrix.com> X-ClientProxiedBy: LO3P123CA0001.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::6) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 398b9176-914b-4117-c300-08da13ed2c31 X-MS-TrafficTypeDiagnostic: SA2PR03MB5801:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rMgUV8luy/9rdP4h1BCBbx8uyNbcp6sArcm5MB1MuP9Q6uyaggosJ2X1H1i/VzqYLLdPBnKVd/5jChCGNOd/RGP3I9a92SSGdYl2OogXbTjK6w0ppyS1QybPKqnL9hI8NQw/dpaPl2x3sLhaTWIfkeNbvlMdhPEXrY9OkO68yyZnA8zCZ9htl0igVQNTVSWGblOCoiukioSf5UgQ7OBfIlWOyUWX9M4DInQB4OUm3pknI5p/fMsVs4za4sj0+QL2k2PLZtv2/kIkBk5HOZ83Nm3CrqehraUN/KzPd2r8DtK/IxKZRkUGfGdwC1FDxvONgP1nP06KQs9+NYVbiP68UJW9u5Wn41aHCO1Mr2HLjeXewRjKeln9fGCmXVsdVd3iQ7PUq/JW6H063iNlv5XkL5JF2QVTkq6ldMPhZsrhIGcezP+6wVd6nSgrFFm63230udUe2RJi7dJbOazR8Lq+nC4kinlt/O2Z7Vhg41tVxdNQGr/FXYEBk0aG9NNQg0+ufzi2saU2g6lyLFKrjgYv8Z+6VtZ0Yvfm8qpWO5B/CAJwXMnjuiYq1nqK6wLiYHL4V55LELmDCDX2u786z7xu5gvkSKBs6xEjJEUoDk+4L5UgiNj43FUQKqVQroRB82AElKKdozQo5JsERoCE9RmuQQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(5660300002)(66476007)(66556008)(36756003)(8936002)(6916009)(2906002)(66946007)(316002)(54906003)(508600001)(6486002)(6512007)(6506007)(6666004)(8676002)(4326008)(82960400001)(107886003)(186003)(38100700002)(83380400001)(26005)(2616005)(1076003)(86362001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?1WoYhQzFBJm6zMLWCGDACjMxTg4W?= =?utf-8?q?DjWG/5eMXcJx5WbwbqcD/6uop5hh2w5WHHDPjmIIA+2PQs+SAu0oqlCjnGCUxe/dv?= =?utf-8?q?mThGIAdGS4kTKVnUb40ER5osqd5azjAURPyn9XgLYXuzHaP/w1cEy0vTq2W1LRbEu?= =?utf-8?q?cRBNDxHqISEkXc4dKTaMGjWOSFaEm6JMEZneXJm7ZN/RK4cCAwsz5FiRw9nU0nl/6?= =?utf-8?q?ISoPYcOFRFDKH2zc159Uagkl1uLigmMdXC7jId6hFHkV95V3hwbPL7lfOHj3Y1hHz?= =?utf-8?q?PrKxrYg4DffleNsekx2njxwUC+RjVvUA5DgkneO/Wm9Qy1OKmeDk0mbU3KS7OElOb?= =?utf-8?q?72sCKuEAy4bppzPwMJOYmE8HeComXdBcJkRMKs00etsgaUNghEsN35y1eeckSJHR5?= =?utf-8?q?HMz9Gt9p3d26xwcw7uLAHzQu2sCsKiUhn+r0pjxTgk9JAzkwVre279AAVMTX8ySXX?= =?utf-8?q?i/5O2ZLautxAWI/jkfyC2MuGQn67KaNEFTuI0rM7KZ7M2wkJmopGwoEtrNYrMcfLp?= =?utf-8?q?vMEvtW+QDovSnXtQ76wsUk4cjlLNcUVVKSjjfqPjy2u0eeiw9HmNc0G024w6uWNKX?= =?utf-8?q?VBBpPp8Opx6V+Nscdmwh9boBjPjFCoNXpZVY9YkwYqZLGv4Pihf0o7YoaA3jQlMrq?= =?utf-8?q?1o1a8uy9iIMJKr+ADZG2GIVLERIvL/UDR2QfAr8UqmqjJIqhDDoHUHSZ8dxTiN3Lg?= =?utf-8?q?frhbcSga/9QdiB5NIf6oGzfeMXfGaIbYMM1JaH1zxYohzsc+241DM9fnDttXGC+br?= =?utf-8?q?IEBzWPWHSAKKcd/QaiQD3JNDBz+yGDj2m54PJLYUeAAzD2x+7SRPLVaMo7TrDVaBw?= =?utf-8?q?3ps2Wt3pV2OCwpKojm0Vcu3hJ8iE0aTJxVV26iSCphSYdt9WzeuFl2wNoIw+CZycF?= =?utf-8?q?INauv2NQ+SeuyKHvhMqt8XEI57er+oNI8GOgLuDOevk6uJ+CB83hYkPyOlf04Tvyc?= =?utf-8?q?uwwUM1Z15he2YqZHrwOZnJi+DcLWmzTEeHtnbD4M1vMn794O0rsu5P1Y1BRRfw6QD?= =?utf-8?q?0prtXxcc08Ty0vpoVI60DL8XEyAiKnXwA0kj+wBMba+5ihCWfYEZVZL9fxPr5zSft?= =?utf-8?q?2+qosdF9vAGMdQWZta93GtHQ+pmChfOLE/InWFXDbYIsRriSLVQzhARERQAFhEX1I?= =?utf-8?q?f35/DjovrcScAbXQ6ut+OHS+LVmxCHIO1EQk1SLh5deDBiIbNCiUMMrG2Nx4ZSDVm?= =?utf-8?q?HSfE1bgQr7pLwdw1EIlildkR2Ftr4iDCnW3YL2FvpTKbfg//f9Y+g3Ikx5eHwDeIs?= =?utf-8?q?3kEpczQHxflVXc8VOHcw5E6hXpA3thv1Q43QAH38LAGLOuv7WRaNCghHjqDAuelHy?= =?utf-8?q?kqccOPb/hUZ1NobB3lHYnu3QfKoei+UyG8aQKBMPyrgVjxlwiBARRUq564uXo22Mg?= =?utf-8?q?v2AS64KF1rRLf+yS4g0Gks8GeYQZATHM/A4hGKvFCe1oAtnv4a2xkTitrsHIL/YWO?= =?utf-8?q?C/E7BDFzA6BoH4DNeP/ZiBJNpXoUoyX9MQ8tse0j7aqiLTvj+RzdwEBuq6QjLTIkD?= =?utf-8?q?BPQNauCWkYJqUKLelKJIdy1Jdcp5/4H6/V0l3kpeNREJC2GVsWiW/fUf+AzSGOsiY?= =?utf-8?q?L8i5soLOcNrN2zDLzba4iwYgQK8k02yUnXXVndUv/e2Yl0u4ZWT826EVwG0PPmq22?= =?utf-8?q?Zx1i/bA5x6lTGlrmdSms9L9XSc+IAcotvhd+gZWynN3SdIeI31E00=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 398b9176-914b-4117-c300-08da13ed2c31 X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 14:37:39.7700 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aQWgXkrvYaOfVKwH8TN5rMWOkvBVyleRLDzg+6Xmrk0qgDbTqPzYCJJnIRHHcuYkxvgHWK1+TPYQ/xhrNgQpDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5801 X-OriginatorOrg: citrix.com Setting the fcf-protection=none option in EMBEDDED_EXTRA_CFLAGS in the Makefile doesn't get it propagated to the subdirectories, so instead set the flag in firmware/Rules.mk, like it's done for other compiler flags. Fixes: 3667f7f8f7 ('x86: Introduce support for CET-IBT') Signed-off-by: Roger Pau Monné Acked-by: Andrew Cooper --- tools/firmware/Makefile | 2 -- tools/firmware/Rules.mk | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile index 53ed4f161e..345037b93b 100644 --- a/tools/firmware/Makefile +++ b/tools/firmware/Makefile @@ -6,8 +6,6 @@ TARGET := hvmloader/hvmloader INST_DIR := $(DESTDIR)$(XENFIRMWAREDIR) DEBG_DIR := $(DESTDIR)$(DEBUG_DIR)$(XENFIRMWAREDIR) -EMBEDDED_EXTRA_CFLAGS += -fcf-protection=none - SUBDIRS-y := SUBDIRS-$(CONFIG_OVMF) += ovmf-dir SUBDIRS-$(CONFIG_SEABIOS) += seabios-dir diff --git a/tools/firmware/Rules.mk b/tools/firmware/Rules.mk index 9f78a7dec9..efbbc73a45 100644 --- a/tools/firmware/Rules.mk +++ b/tools/firmware/Rules.mk @@ -13,6 +13,8 @@ endif CFLAGS += -Werror +EMBEDDED_EXTRA_CFLAGS += -fcf-protection=none + $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) # Extra CFLAGS suitable for an embedded type of environment. From patchwork Fri Apr 1 14:37:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 12798410 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27F7EC433EF for ; Fri, 1 Apr 2022 14:38:11 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.297444.506718 (Exim 4.92) (envelope-from ) id 1naIPX-00062o-5G; Fri, 01 Apr 2022 14:37:59 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 297444.506718; Fri, 01 Apr 2022 14:37:59 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1naIPX-00062h-0L; Fri, 01 Apr 2022 14:37:59 +0000 Received: by outflank-mailman (input) for mailman id 297444; Fri, 01 Apr 2022 14:37:57 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1naIPV-00060A-6P for xen-devel@lists.xenproject.org; Fri, 01 Apr 2022 14:37:57 +0000 Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id 5061d88b-b1c9-11ec-a405-831a346695d4; Fri, 01 Apr 2022 16:37:55 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 5061d88b-b1c9-11ec-a405-831a346695d4 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=citrix.com; s=securemail; t=1648823875; h=from:to:cc:subject:date:message-id:in-reply-to: references:content-transfer-encoding:mime-version; bh=gOh+MbI5/vyzNf9U+I3QlasMd5sBpWWXSGlu8Dw3/pI=; b=NUvYvASnsug4bdXo2/oQbPdmjgRtXXKpeC8puzsXKT5JxWnhoAcE6RKi GlCb82M9S9nMMoyZ4IAZPcZ9k9t/ISkS4ixX14OSMYTgxJ3kBXHJXy2lK 4sK4pGxW4+9wsd+GXXjc7/SAP53nLho3OHX8RpnIqnINsWBJcEAoiibb7 A=; Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com X-SBRS: 5.1 X-MesageID: 67673382 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.156.83 X-Policy: $RELAYED IronPort-Data: A9a23:GMiM8qxFqMnmyzK23KR6t+cIxirEfRIJ4+MujC+fZmUNrF6WrkUAm 2RNUDrSPa6LZmHweIwna9+38EoF7JPQzINjHQc9/iAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX9JZS5LwbZj2NY02YHhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ NplvJ/tTiMVPYvwvssYVxN5EC9aB+pGweqSSZS/mZT7I0zudnLtx7NlDV0sPJ1e8eFyaY1M3 aVGcnZXNEnF3r/ohuLgIgVvrp1LwM3DJoQQt2sm1TjEJf0nXYrCU+PB4towMDIY2J8QQq2FN 5BxhTxHYzvcSEdGBVguCpMbnMOZi1/iSBZJgQfAzUYwyzeKl1EguFT3C/LOYcCDT8hRmkeep 0rF8n7/DxVcM8aQoRKa9lq8i+mJmjn0MKoQCbm5+/hCkFCVgGsJB3U+RVa95PW0lEO6c9ZeM FAPvDojq7Ao806mRcW7WAe3yFaGtBMBX9tbE8Uh9RqAjKHT5m6k6nMsF2AbLoZ87YlvGGJsh gThc87V6SJHub7ITlah9ZGoixy3PSI0LmEmX2gEdF5QizX8m70bghXKR9dlNae6iNzpBD39q wy3QDgCa6Y71pBSifjilbzTq3f1/8WSEFZpjunCdjj9hj6VcrJJcGBBBbLzyf9bZLiUQVCa1 JTvs5jPtbteZX1hecHkfQnsIF1Lz6vdWNE/qQQ2d3XEy9hL0yT8FWy3yGsiTHqFyu5eJVfUj Lb74Gu9HqN7MnqwdrNQaImsEcksxqWIPY27CqCLM4AUOskgKVLvEMRSiai4hT+FfK8Ey/xXB HtmWZz0USZy5VpPklJauNvxIZd0n3tjlAs/tLjwzgi90Kr2WZJmYextDbd6VchgtPnsiFyMq 753bpLWoz0CALyWSnSGquY7cAFVRUXX8Lir8qS7gMbYeVE4cIzgYteMqY4cl3tNxPoNzL6Sr iDgAie1CjPX3BX6FOlDUVg6AJvHVpdjt3MreysqOFejwX84ZoizqqwYcvMKkXMProSPEdYco yE5Rvi9 IronPort-HdrOrdr: A9a23:Er8fYKp03IRFkL+FERwdgvUaV5vJL9V00zEX/kB9WHVpm5Oj+P xGzc526farslsssREb+OxpOMG7MBfhHPlOkPUs1NaZLXTbUQ6TQr2KgrGSpQEIdxeOlNK1kJ 0QCJSWa+eAfGSS7/yKmTVQeuxIqLLskNHKuQ6d9QYWcegDUdAf0+4TMHf9LqQZfngiOXJvf6 Dsmfav6gDQMUg/X4CePD0oTuLDr9rEmNbPZgMHPQcu7E2rgSmz4LD3PhCE1lNGOgk/i4sKwC zgqUjU96+ju/a0xlv10HLS1Y1fnJ/ExsFYDMKBp8AJInHHixquZq5mR7qe1QpF692H2RIPqp 3hsh0gN8N85zf4eXy0mwLk303a3DMn+xbZuCilqEqmhfa8aCMxCsJHi44cWADe8VAcsNZ117 8O936FtrJMZCmw0xjV1pztbVVHh0C0qX0tnao4lHpES7YTb7dXsMg24F5VKpEdByj3gbpXXN WGNPuspcq+TGnqL0ww5gJUsZ+RtzUIb1q7q3E5y4KoO2M8pgE686MarPZv6kvouqhNDqWs3N 60QZiApIs+PvP+UpgNdtvpOfHHclAlYSi8Rl56cm6XXZ3uBRr22uvKCfMOlaWXRKA= X-IronPort-AV: E=Sophos;i="5.90,227,1643691600"; d="scan'208";a="67673382" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AMgTfOOEbgSizV2T/0ybHtkedXa0//FktUTPSJRDwER5kxzzw4i/eqTD2VPDU3oglKmMGKZ5XrWMBiYPTW/CeviANQAxbk4JZVFF2pV/tfJIwOaPRPvi5pgP1OAB0NWtF85H5gxpEj60Kf36eDD+htIwx84E8vtB/46PZWIzLiXY2xJfjPhjg+9iAY5FCe4PvJ4NwuYJbspD5cj4OWbuqJvy+67jDhqzNZ+TPiBC5GpcVdqcpYfiBnmSx7gUpwEFZ4jm0ci4y4vUK7Oxnz4uroESbvTPH4wnk1ryKlHoYp0piazE/fE8VNb8PnEaZaqBJVepWpTDFsho3b3Rsuk7mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0WF9KvEYEzdfBix0SwaBl+hEi0VZ8z9aUzi13sJkjWA=; b=L8MBkNjSx7UiOtV3YJlr74jXJa/dC8RSEMdu8/jOYdM7a/MMcnl8R7b3II9DnI7RHA0hvMEOU513e+u5hJzQEtpCscSkKnE23bg7At94JisdC2zzq+RQLxxKz3gYPDwJNelnbrIU/yFQ15rYbPhLawMDhIjrN6w745gdGYQs8dhMWspEBkUEkfIfjbZ5iBd9OBbLJbu2og0L1BFrUoM9l3oQhjuNGXWp+glgOvrSyHvrRNh9BjLG+Gs61FImihbA3TxX/9jdGKJlOLsoBgiUNIDEQdjDB9mDdm38JnX4cxr3KxYifL99A+l6ngZ8tTId7Hzax4fA1KF+HYsx8r8T+w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.onmicrosoft.com; s=selector2-citrix-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0WF9KvEYEzdfBix0SwaBl+hEi0VZ8z9aUzi13sJkjWA=; b=mXiXkw5Yt5kRS6giOh+cEpU8uozIBNKu0/ZIaQiSaUZ+Pvlfh+wkxrT3yapsEFWgE8OR9X+78zQHT7X9/8urwAmqZZsFb1ltrFR3IYis1OFOjsXocdzu+fR6oVZ+FB0rVcsuoUBCdXqK/LRfUEe3IPU3AEMQMtrfy4aU4CmM3Yk= From: Roger Pau Monne To: CC: Roger Pau Monne , Andrew Cooper , George Dunlap , Jan Beulich , Julien Grall , Stefano Stabellini , Wei Liu , Anthony PERARD Subject: [PATCH 2/2] tools/firmware: do not add a .note.gnu.property section Date: Fri, 1 Apr 2022 16:37:19 +0200 Message-ID: <20220401143720.23160-3-roger.pau@citrix.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220401143720.23160-1-roger.pau@citrix.com> References: <20220401143720.23160-1-roger.pau@citrix.com> X-ClientProxiedBy: LO3P123CA0002.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:ba::7) To DS7PR03MB5608.namprd03.prod.outlook.com (2603:10b6:5:2c9::18) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4879c129-b41f-4751-3986-08da13ed2f5f X-MS-TrafficTypeDiagnostic: SN2PR03MB2398:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1P2d7j14NLWb4FNcf3AY92rRol3skARChpdxMy9nqtO23ede1eWIc8eJLeoevqdFR9HVDqcl8sBi2VVLIKMKRTvEd1FBxL9zGX2ROLAVAA+5CYmmK/yyxKqhaqy1+WYmZLONWEUVzj4kNpDVqCaS1E8JDd8/BOmkxxu47k2uMwh+bFv+igFg9XfhE0STmY9JfQebNrYl5WVgNXX6/df1oCuJT0qgzFgw2NghBB9Oq+ylSej1rtqWxBpX1lN2k2HnmVlLQaq1HV4WYjJ6jPN609vuhcCc7+PYQ+oF8nFLrxRYwIdetiBXPh6OWGLULOrdDopxQPgRvk9VDLEENNMAGnL/RJdhuXT1/y3SenJmjHp3QqLaJuR2KIcNLtW3esRbW0456DxcW6HpWZS2rnS9IQbxNt4ronPl2GjCbA1Kr1PsK7uh3J8hvIqAd4aa7gylKYdlTjKOOA7wnanLmwvEIT3OhipgAweVqQ4iKAEPo9ZuT3HOJGGrm2smWz1TQkFfrNrMCvKpjjHZb8eVNwbGoQxetdgqnhoI8GU8GoTG3zpUmnA7RDAXSCFe2xDDAaf9Qg5gUrg66f4+oEbQD3pVfMuYuS3ypWZR9lLRtm/qClcvHGpTppk4UJrDs1jpIsRQ6enIGNBixptmFjkrcOzK9kCO4Q2a8oP1FkT/N6yONl9nbZZxbUi8JQGHi3lXd8zYvLFRuIihoQmYAzgM1WR59w== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS7PR03MB5608.namprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(36756003)(6916009)(107886003)(54906003)(316002)(38100700002)(82960400001)(66946007)(2906002)(6506007)(5660300002)(508600001)(83380400001)(6486002)(66476007)(8936002)(2616005)(86362001)(66556008)(26005)(4326008)(6512007)(8676002)(6666004)(186003)(1076003)(142923001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?loR+6gwbjHGbJpUnWOfsG1zceA1p?= =?utf-8?q?kbbbIWg4QnLePeH/vp3v7YPIXR8WsJAFpwLMdTBABBlkp1g0+Ak2mIvm73nUmYsg8?= =?utf-8?q?6j43xUfkPgj0ipKQvfhQT9n16MFCjl8Z4/a5dT88rmKsy3G4xArj4wNZwwVcZifYD?= =?utf-8?q?LmlHAnAeVg2kNEebz9IBf9u08C6k9vKhPZ8mChjjVqsZgbCB1sHqNDn+rzwXnAg8b?= =?utf-8?q?YuM4/JWZpaGYC9HnHyadQEKs/iNf09O/iZZeR8VeI7CpL2Vp1AHvQ7e6D/uB+8CG4?= =?utf-8?q?2GHhLGe7tlESjdtjNQnogkp0yij1HgCtiw5HuFm23Y0xcHLmGUj/o/eMmyp9xOrg6?= =?utf-8?q?1emx/PqJT6ViBzg98FXY2kefx8ePmfFNZ98NJDy/qKVBMkUCEindejYcfotym+3ty?= =?utf-8?q?l7JSMsCRsvBIxE2Et9uF7Czri+aYGP3CIlzbJaeYs6ep778wzdOfLpoepqZ+lzF/B?= =?utf-8?q?NdCNfwmqyH0jjQeSN4pnfi7O8dvMKXwh7H5jodngeQfzsb4GwRiYt+m3f0vuFDj+6?= =?utf-8?q?q68slijMnKvrC/IquYjd3UXYhYOVIbJp5OTXf3mbiQ6NrLiWT/RZ9/818lDqy21I5?= =?utf-8?q?tJjksFkWCoyIG6r1wOJ2vgh94O7kpUIMkflfpMM8hWhd/ZZRAlB0rHgbm7CmYgrjr?= =?utf-8?q?FYTvk5J6tpHHdi2/2tSPnkeZaD2hu8HzdFzIOzjpetgVQEXQMFO8mGeoOBBrQ9xfM?= =?utf-8?q?H4e68ibNwLoY63RvX64TO1Sm3VSjlghh8UgKFRjvbMpnnRjCcAh50LftPD42IkUgs?= =?utf-8?q?Fh1CS9WlmLmIJbqZRcBpiMoqUH2a+8ekn70wSIB/HSnnEiRkFZiSIIdT6oUOeR0dh?= =?utf-8?q?DXP+dOwn0iH4bmcRGc/JfVfGPYlThbVX0+jxly8oqvk5SPc4lSX+ojJEZc2c1Tnzh?= =?utf-8?q?iTq2W5+NZb/q6RZG7ncq1iEAyQL1WczE1gO01/cRJt2d2xsz2GyXvGhcv1d748Y+N?= =?utf-8?q?bwnEqMBTuBqWyviIbE27uKcWgOyZGtK/0fFmullazP9LGGGQBHvLcJPfUh8ZNrrQc?= =?utf-8?q?rmdXqir6/PaRc7PaYzjC3Xasrpr1YfbSbK0BsTZqubddtomJ05Kvz+J2UxIriXHlg?= =?utf-8?q?xJkaJMvbahoxtkG8Nf5BdhVG0cURJimuG84oxmyoRb7HMH1W6u/4UOhmg9DyMIJog?= =?utf-8?q?Ji0372OsuVqxuTD6FRxgukH1uOK/RoztAQdUFu1ki27d4r5UhX0yWbFXFfFDVIKha?= =?utf-8?q?jyFYOVqffWaK9bd1wS8YjHzw+VTaRFS7/jsj18iBLQLDIcSfAdtbcY773p6vOroUX?= =?utf-8?q?UZ47Su29+nt9PLgCNr903z7vtoeXN5BPnaWhggEI7951uiLtgws/l/2qV7HbrVa2N?= =?utf-8?q?MMV/y+pIGTV2bULv0yIiHrBqSnHth4P3HKFOjIiMvBUpnC7Ycxc4BX4cKBrpSJyWJ?= =?utf-8?q?UVfuW9gQPM4v6YpYX4m0Lbzhh1K6dfldptWAf1R6DoSBODeaOT4Rb1HzgpAk6zB6k?= =?utf-8?q?3A9cSD2eyqIV1UvEcaGuQv5BIue6buL+udwEeMnHTl22LgbJ9cr3Ewr5nNSEq9CzF?= =?utf-8?q?zPJQr8q/Rry78UjMtKvc3luIGt/U0vlzFPxlqW1cQWxs3dEpDJIs4B5nmAFCONxKK?= =?utf-8?q?+cGE3ErwPhXBHdebw7bodPmScuBCkR8zrotYqWyDT6q+sEmxvqIHcfXVeI3zjcoy7?= =?utf-8?q?i8Eo209p29SCG7z6sJrKy+XVc9VnX0ZNebH/E7VPRUX9J6mz9dmRo=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 4879c129-b41f-4751-3986-08da13ed2f5f X-MS-Exchange-CrossTenant-AuthSource: DS7PR03MB5608.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Apr 2022 14:37:45.1011 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 335836de-42ef-43a2-b145-348c2ee9ca5b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xs8EzV7g9bMEf+3u3v+XTywaSxqHcohSjgBFURAe0FySyIcHEU1p2R3VIj0kxM5AwIUYM5mypDqD//XbdRPn2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR03MB2398 X-OriginatorOrg: citrix.com Prevent the assembler from creating a .note.gnu.property section on the output objects, as it's not useful for firmware related binaries, and breaks the resulting rombios image. This requires modifying the cc-option Makefile macro so it can test assembler options (by replacing the usage of the -S flag with -c) and also stripping the -Wa, prefix if present when checking for the test output. Signed-off-by: Roger Pau Monné Acked-by: Andrew Cooper --- Config.mk | 2 +- tools/firmware/Rules.mk | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/Config.mk b/Config.mk index f56f7dc334..82832945e5 100644 --- a/Config.mk +++ b/Config.mk @@ -91,7 +91,7 @@ PYTHON_PREFIX_ARG ?= --prefix="$(prefix)" # # Usage: cflags-y += $(call cc-option,$(CC),-march=winchip-c6,-march=i586) cc-option = $(shell if test -z "`echo 'void*p=1;' | \ - $(1) $(2) -S -o /dev/null -x c - 2>&1 | grep -- $(2) -`"; \ + $(1) $(2) -c -o /dev/null -x c - 2>&1 | grep -- $(2:-Wa$(comma)%=%) -`"; \ then echo "$(2)"; else echo "$(3)"; fi ;) # cc-option-add: Add an option to compilation flags, but only if supported. diff --git a/tools/firmware/Rules.mk b/tools/firmware/Rules.mk index efbbc73a45..1cbe666f5e 100644 --- a/tools/firmware/Rules.mk +++ b/tools/firmware/Rules.mk @@ -15,6 +15,10 @@ CFLAGS += -Werror EMBEDDED_EXTRA_CFLAGS += -fcf-protection=none +# Do not add the .note.gnu.property section to any of the firmware objects: it +# breaks the rombios binary and is not useful for firmware anyway. +EMBEDDED_EXTRA_CFLAGS += -Wa$$(comma)-mx86-used-note=no + $(call cc-options-add,CFLAGS,CC,$(EMBEDDED_EXTRA_CFLAGS)) # Extra CFLAGS suitable for an embedded type of environment.