From patchwork Fri Apr 1 15:56:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 12798486 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 040DFC433EF for ; Fri, 1 Apr 2022 16:28:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235819AbiDAQ1s (ORCPT ); Fri, 1 Apr 2022 12:27:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54004 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234975AbiDAQ10 (ORCPT ); Fri, 1 Apr 2022 12:27:26 -0400 Received: from conuserg-11.nifty.com (conuserg-11.nifty.com [210.131.2.78]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DEEB164D0D; Fri, 1 Apr 2022 08:57:03 -0700 (PDT) Received: from grover.RMN.KIBA.LAB.jp (133-32-177-133.west.xps.vectant.ne.jp [133.32.177.133]) (authenticated) by conuserg-11.nifty.com with ESMTP id 231FuN80009424; Sat, 2 Apr 2022 00:56:24 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-11.nifty.com 231FuN80009424 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1648828584; bh=PlEZwHX2+oLbHS/OqLyTr6a9Ci0j5vWgM7qqdsKDhzc=; h=From:To:Cc:Subject:Date:From; b=ow5IqK3pQ4IJMKql6ksgcJN7wkIsnA8Ups89tDhP45d4FRq/wJYky4S59luOnrIgh 9QaoBMD24OLkzdraqnKEMq+Uyp+A23zYu2Zry4/sWh+suZXE1zQ4UTgbbhfVqgWn8d YhuNF/nyk2lOPdyy+bf2vhGasY17nawl83qc3PJAFYIa1g2jNTFHo7RADGf1gdUKBr wQat478uKPxbQwzKblmIQQB4ZdPyNE0IO+lQBakoRmxZVEUSImFOQrONZwghU+oy0D 9r3ycCufKlv82DQUvFc0FQCbBHW+Kw7B+CFfoAe6c+tJEs1G+RWoQ5FXk00/JMnaQh UaHlWLnQ71oRQ== X-Nifty-SrcIP: [133.32.177.133] From: Masahiro Yamada To: linux-kbuild@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Masahiro Yamada , Mark Brown , Michal Marek , Nick Desaulniers Subject: [PATCH] modpost: restore the warning message for missing symbol versions Date: Sat, 2 Apr 2022 00:56:10 +0900 Message-Id: <20220401155610.1280262-1-masahiroy@kernel.org> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kbuild@vger.kernel.org This log message was accidentally chopped off. I was wondering why this happened, but checking the ML log, Mark precisely followed my suggestion [1]. I just used "..." because I was too lazy to type the sentence fully. Sorry for the confusion. [1]: https://lore.kernel.org/all/CAK7LNAR6bXXk9-ZzZYpTqzFqdYbQsZHmiWspu27rtsFxvfRuVA@mail.gmail.com/ Fixes: 4a6795933a89 ("kbuild: modpost: Explicitly warn about unprototyped symbols") Cc: Mark Brown Signed-off-by: Masahiro Yamada Acked-by: Mark Brown Reviewed-by: Nick Desaulniers --- scripts/mod/modpost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index d10f93aac1c8..ed9d056d2108 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -674,7 +674,7 @@ static void handle_modversion(const struct module *mod, unsigned int crc; if (sym->st_shndx == SHN_UNDEF) { - warn("EXPORT symbol \"%s\" [%s%s] version ...\n" + warn("EXPORT symbol \"%s\" [%s%s] version generation failed, symbol will not be versioned.\n" "Is \"%s\" prototyped in ?\n", symname, mod->name, mod->is_vmlinux ? "" : ".ko", symname);