From patchwork Fri Apr 1 16:39:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Palmer Dabbelt X-Patchwork-Id: 12798494 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F500C433F5 for ; Fri, 1 Apr 2022 16:42:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:From:Cc:MIME-Version:Message-Id:Date :Subject:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=S1Iq606BlMg/WrwAR62bwC7DUbiomyUe9/VN1nDRXXA=; b=cNZMJOrauk91Hb D4l64kyARD6Z14QFLte7bdK07mw+AOwmrogCTYs0+ZrKE2iDrPuQ328Tr8R6EGeK8jYoi68rb1CMM IvLbmOI5lTVMMtPh1zRwBPAXUej9zmoLAFT8422NZ1kDVsQEyJHlxjs4/CR8iQk5Uv4M5dwxCncTZ KUsQySqvjwJu8tIqq8390/BsljbGWxs4Pfur6oilaYgbSsSgcLYOVKSOKRoI4SGyIRxQajWVjus9o X6qo1tlM+lOWkMp2iBI3vXwZBFX4wOnFy2EoGglRHzhKptQBYSYJM7g64VL2GEpCDBMOEQcEHSK4q uTVIi9jMIU2BAr++b3OQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1naKLS-006aLF-HP; Fri, 01 Apr 2022 16:41:54 +0000 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1naKLP-006aK7-Ul for linux-riscv@lists.infradead.org; Fri, 01 Apr 2022 16:41:53 +0000 Received: by mail-pg1-x530.google.com with SMTP id q19so2811221pgm.6 for ; Fri, 01 Apr 2022 09:41:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=subject:date:message-id:mime-version:content-transfer-encoding:cc :from:to; bh=qFBAvnSg79zoT3+JHM3vRs2zXL9WFcit8FJyzU3capc=; b=Us9JNrHb8FSQA4yTPo9jEb5jZcr9MnUGvOzX0HJAQCEJXT/eL24QXIXcLjAkg8q6Kl HeCP8i0HPITMmBTyTOiKz4oxtxFFmv23M8iIV7Y+Bkq8/Tjkt3enC2MT03L9eVRCjhGv WK/EbevIn/hV3WIBoDuxL1zntTpJdCVehsc053Ajjx6LlY4LcaGAhj87+Kpy0e1vaCG7 KVaRkPKD/4KYlvT97s1lFo+8gQtO5ne2j91rbWGKqL5WZRFgve4EdR7buLFyxj/YzNJ3 0UGgPy4Sp+hXDWYd/ObktV48tCsv4pMsUQuTbUSvxdX3VI3W5YFXOah8r6FuSGtHy0DI YqXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:date:message-id:mime-version :content-transfer-encoding:cc:from:to; bh=qFBAvnSg79zoT3+JHM3vRs2zXL9WFcit8FJyzU3capc=; b=3NWoEzTmha67G/oIxj0tFptJKOFbNdea1R5JvVQrHeoSZvPMkVMg1n/UOiBoe5jAUP iqK7Xhs95qZ+mfgJHYvrLN8v9/YwUH3+tjRC3NMpoPrICRsVmxWPCNhXpWFiobIEe+Ty oV7H92vNdu5+6lJ6W3WPdCiZLDhKcYwxaiEVayFWCHYVMuD73AJqOlCR3wxE93J9pMFC Af/Lt0vOc4jwKNkSoZPGi/5CzA/ltiGcjIe33iYzIQBbFYnw9wY6bLGjcv0EnJSRNhia +DKh9mVeOBgtHofVR0JTCGO4UdpXtmmhdYXOfN8Qc7XSzl931BinIyPGwAeUM3nTp178 QCmQ== X-Gm-Message-State: AOAM531Msc8YL+xRkHmftvRdM4QZJvRxfZNftrxfKzNi+k/HgaWVH1+6 Sbxd6dqTL2sNEl35ij9W6ElNOmK/Cdi/+oE5 X-Google-Smtp-Source: ABdhPJwes6GB4QofFG33x08DcMvHD/tGHasWxDQKJg/phGDL3vN9pemPhlXzw0y3X93EX8EhZ203Hw== X-Received: by 2002:a05:6a00:b87:b0:4fa:a79a:72e7 with SMTP id g7-20020a056a000b8700b004faa79a72e7mr11808231pfj.68.1648831309069; Fri, 01 Apr 2022 09:41:49 -0700 (PDT) Received: from localhost (76-210-143-223.lightspeed.sntcca.sbcglobal.net. [76.210.143.223]) by smtp.gmail.com with ESMTPSA id m7-20020a056a00080700b004fb28fafc4csm3812953pfk.97.2022.04.01.09.41.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Apr 2022 09:41:48 -0700 (PDT) Subject: [PATCH] habanalabs: Elide a warning on 32-bit targets Date: Fri, 1 Apr 2022 09:39:09 -0700 Message-Id: <20220401163909.20343-1-palmer@rivosinc.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Cc: ogabbay@kernel.org, Arnd Bergmann , Greg KH , ynudelman@habana.ai, obitton@habana.ai, fkassabri@habana.ai, daniel.vetter@ffwll.ch, ttayar@habana.ai, sozeri@habana.ai, bjauhari@habana.ai, linux-kernel@vger.kernel.org, Palmer Dabbelt From: Palmer Dabbelt To: linux-riscv@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220401_094152_253788_B2AF3584 X-CRM114-Status: GOOD ( 13.79 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org From: Palmer Dabbelt This double-cast pattern looks a bit awkward, but it already exists elsewhere in the driver. Without this patch I get drivers/misc/habanalabs/common/memory.c: In function ‘alloc_device_memory’: drivers/misc/habanalabs/common/memory.c:153:49: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] 153 | (u64) gen_pool_dma_alloc_align(vm->dram_pg_pool, | ^ which ends up promoted to a build error in my test setup. Signed-off-by: Palmer Dabbelt Reviewed-by: Oded Gabbay --- I don't know anything about this driver, I'm just pattern-matching the warning away. --- drivers/misc/habanalabs/common/memory.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/misc/habanalabs/common/memory.c b/drivers/misc/habanalabs/common/memory.c index e008d82e4ba3..f1fc79c1fc10 100644 --- a/drivers/misc/habanalabs/common/memory.c +++ b/drivers/misc/habanalabs/common/memory.c @@ -150,12 +150,12 @@ static int alloc_device_memory(struct hl_ctx *ctx, struct hl_mem_in *args, for (i = 0 ; i < num_pgs ; i++) { if (is_power_of_2(page_size)) phys_pg_pack->pages[i] = - (u64) gen_pool_dma_alloc_align(vm->dram_pg_pool, - page_size, NULL, - page_size); + (u64) (uintptr_t) gen_pool_dma_alloc_align(vm->dram_pg_pool, + page_size, NULL, + page_size); else - phys_pg_pack->pages[i] = (u64) gen_pool_alloc(vm->dram_pg_pool, - page_size); + phys_pg_pack->pages[i] = (u64) (uintptr_t) gen_pool_alloc(vm->dram_pg_pool, + page_size); if (!phys_pg_pack->pages[i]) { dev_err(hdev->dev, "Failed to allocate device memory (out of memory)\n");