From patchwork Mon Apr 4 13:25:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12800210 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99417C433F5 for ; Mon, 4 Apr 2022 13:28:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=bdvunGVJImU6Oyv9gZcT3z044nUwUl2t1w+bx/pnM9w=; b=eyGUIjxaFMzgbB B3SbjETq/j0l9H+uZr2YfLWgu5rBhauAEqJ8nFCsi0h2rLTVzuOS12ekdPoE8OJU0Y8vG1eerwi+o /3z6irNZCrBPFCgxZG4evzHLODbdgjXGwL/jAfwElYIurAt1XOBA3xWTmOp0Qmea2DAOv9sBSs56M vimBZbVvjmbsQnEjoVKxzv/QITa84tOMle8KlEx/ZgmBGw2GkxG6eWfijIsP8xFR4MzJ7nagVtg6x oNt+a99WMnntDButVaYyP4+NmhpNn2BT8NRwMkv42KqPbefkhB0qLPZfhdO/bym3vdZgxFKgIvCQz 8lyBGiEV+Lg4Wme0dGQA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbMjg-00F6R8-KK; Mon, 04 Apr 2022 13:27:13 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nbMiW-00F63E-FC; Mon, 04 Apr 2022 13:26:01 +0000 Received: by mail-pl1-x636.google.com with SMTP id n9so3455845plc.4; Mon, 04 Apr 2022 06:26:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=FlBsVFEKh4j3VAt6LeTKFsoKsuruo0DcZ5wQSPKgGVo=; b=gZxNZUcVpHlb+PC0mU029qi8y3yaBV33LkmOZB+zCVqsXIYEND5s0ftLAFjpG+DSvG 3fre2ImlaHs0IToAEnvx8Ge+DDk9/z+wpD4ZGw38SCtRfsEbEO4pjAklfsQgrWcCtlq+ /NChUBrxhCdkVoxZCR6VfOXHeSigso1sRZ7Fc/pZ1khBXeg8xEX1EpjsMh7+AVabZYn2 8yv09bnMza+Qfv1P1GRodT8QGwJ1rbgkjTpmC0siV2jwaa8Rslz2GWkomEftev/V7mHa ewRE3nXenMD+InkvCKfXlyVm/K04usRxrRtQbfpqdnt9H2c9hJBLDrzbLpkOlOI6OBTZ IbFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=FlBsVFEKh4j3VAt6LeTKFsoKsuruo0DcZ5wQSPKgGVo=; b=DTTHfXCY7/UaLP8sayerf2F3oivyvEg5Vl8bJ+HdyANDz94qhYfjA8yoE3K8NTsA4B FoWjVZMCPGK7rvBtpZq8xAm8qB+Qkd2NY8ossJCV6DoEJQq6cK9mRU0/aId0pJufZ5hY D8IIVq8sGvZ19bcNFI30tC4rnpg6ohq6YgyDM5gaJmsgOwbzmLyFChYrJ2NWTqust+KF EowutUeG3oY9C463J/B9iJPBWzQoUld+AW/AOJh1bUqQAZX32OdhSnFixrmJx6H+7M6V 0qQnbB32w/tPcjVkrp+DsMXpHV1dlfVvEAPswUj7207rLCTiarXbhLuwoFeM2Kzrka/L U9Hw== X-Gm-Message-State: AOAM530fh+fec242KPJmSdyXmFhd9QVojzFR7zSm93dYGt6ncTAUE3+a 3oV4IgBDq2hvoMnrjJ/LGn8= X-Google-Smtp-Source: ABdhPJx3+zSJdu5DehSeyrC7q6wpVT/4HVSBzcFwjxsrzsTyJC0b4HFVuDHkH2ecj14ojRx2BF95tA== X-Received: by 2002:a17:903:2285:b0:154:c94:c5b7 with SMTP id b5-20020a170903228500b001540c94c5b7mr22253plh.64.1649078759509; Mon, 04 Apr 2022 06:25:59 -0700 (PDT) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id j3-20020a056a00234300b004faabba358fsm12617039pfj.14.2022.04.04.06.25.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Apr 2022 06:25:59 -0700 (PDT) From: Miaoqian Lin To: Eddie Huang , Sean Wang , Alessandro Zummo , Alexandre Belloni , Matthias Brugger , Tianping Fang , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Cc: linmq006@gmail.com Subject: [PATCH] rtc: mt6397: Fix potential NULL dereference in mtk_rtc_probe Date: Mon, 4 Apr 2022 13:25:53 +0000 Message-Id: <20220404132553.28064-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220404_062600_547966_9DEDC91E X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org platform_get_resource() may return NULL, add proper check to avoid potential NULL dereferencing. Fixes: fc2979118f3f ("rtc: mediatek: Add MT6397 RTC driver") Signed-off-by: Miaoqian Lin Reviewed-by: AngeloGioacchino Del Regno --- drivers/rtc/rtc-mt6397.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/rtc/rtc-mt6397.c b/drivers/rtc/rtc-mt6397.c index 80dc479a6ff0..07c6679366e0 100644 --- a/drivers/rtc/rtc-mt6397.c +++ b/drivers/rtc/rtc-mt6397.c @@ -269,6 +269,9 @@ static int mtk_rtc_probe(struct platform_device *pdev) return -ENOMEM; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); + if (!res) + return -EINVAL; + rtc->addr_base = res->start; rtc->data = of_device_get_match_data(&pdev->dev);