From patchwork Wed Apr 6 07:16:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijaya Krishna Nivarthi X-Patchwork-Id: 12803241 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4286C433F5 for ; Wed, 6 Apr 2022 11:53:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231263AbiDFLzY (ORCPT ); Wed, 6 Apr 2022 07:55:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230197AbiDFLy6 (ORCPT ); Wed, 6 Apr 2022 07:54:58 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5318E4B56BC; Wed, 6 Apr 2022 00:16:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1649229408; x=1680765408; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=eZgkX31W2F848kSTM0Ibd6wFCkEDF2xnvFIhQPHSqw0=; b=kwptq01BJN0c+EmNJXSyuVjnrcmWP9BPVxHXVjcWD/8Y9D+G5KVFizGI +TjKdkA9kT5TIIhMKBqvI0rZFjWAN68WLxBMOktYMmFokrsWu73F01BnB L9lpI9Obzp5uaQEF7uZlI4dgRNYqdZHxDyPtZhUiNb7VvZHIQ93uYzHz+ Q=; Received: from ironmsg07-lv.qualcomm.com ([10.47.202.151]) by alexa-out.qualcomm.com with ESMTP; 06 Apr 2022 00:16:35 -0700 X-QCInternal: smtphost Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by ironmsg07-lv.qualcomm.com with ESMTP/TLS/AES256-SHA; 06 Apr 2022 00:16:34 -0700 X-QCInternal: smtphost Received: from hu-vnivarth-hyd.qualcomm.com (HELO hu-sgudaval-hyd.qualcomm.com) ([10.213.111.166]) by ironmsg02-blr.qualcomm.com with ESMTP; 06 Apr 2022 12:46:31 +0530 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 3994820) id BF6093B51; Wed, 6 Apr 2022 12:46:30 +0530 (+0530) From: Vijaya Krishna Nivarthi To: agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: quic_msavaliy@quicinc.com, dianders@chromium.org, Vijaya Krishna Nivarthi Subject: [V3 1/3] arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold Date: Wed, 6 Apr 2022 12:46:00 +0530 Message-Id: <1649229362-31183-2-git-send-email-quic_vnivarth@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1649229362-31183-1-git-send-email-quic_vnivarth@quicinc.com> References: <1649229362-31183-1-git-send-email-quic_vnivarth@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org WLAN rail was leaking power during RBSC/sleep even after turning BT off. Change sleep pinctrl configuration to handle same. Signed-off-by: Vijaya Krishna Nivarthi --- v3: apply same change to active state and other sc7280*.dts* as well v2: used bias-bus-hold as per review comments v1: intial patch used bias-disable for sleep pinctrl in sc7280-idp only --- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi index ecbf2b8..bddee8b 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi @@ -400,10 +400,10 @@ &qup_uart7_cts { /* - * Configure a pull-down on CTS to match the pull of - * the Bluetooth module. + * Configure a bias-bus-hold on CTS to lower power usage + * when BT is turned off. */ - bias-pull-down; + bias-bus-hold; }; &qup_uart7_rts { @@ -495,10 +495,10 @@ pins = "gpio28"; function = "gpio"; /* - * Configure a pull-down on CTS to match the pull of - * the Bluetooth module. + * Configure a bias-bus-hold on CTS to lower power usage + * when BT is turned off. */ - bias-pull-down; + bias-bus-hold; }; qup_uart7_sleep_rts: qup-uart7-sleep-rts { From patchwork Wed Apr 6 07:16:01 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijaya Krishna Nivarthi X-Patchwork-Id: 12803183 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F3BBC433FE for ; Wed, 6 Apr 2022 10:53:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347658AbiDFKzf (ORCPT ); Wed, 6 Apr 2022 06:55:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235926AbiDFKyk (ORCPT ); Wed, 6 Apr 2022 06:54:40 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D8675149A6; Wed, 6 Apr 2022 00:16:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1649229413; x=1680765413; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=9TeuMS7+p5ddyvbPjNkA+5PT44Jh0Ru6bQlomVn3lo4=; b=HNiycbBQKPYzYVP0pDqCSs7Lqp+pAf0xphrIGahiThF+kQXe/P3nEJh0 bmnAqiFJp4gMuK9WlTTo1utqPObxhSG5U0JMFjSqhX6OEl5Gy1gW2yoV5 J2LFlRQr1y21oWeLICl91tzphwjpPCece39ycC1Iz4rmHgSsGYqG7r6y6 w=; Received: from ironmsg07-lv.qualcomm.com ([10.47.202.151]) by alexa-out.qualcomm.com with ESMTP; 06 Apr 2022 00:16:37 -0700 X-QCInternal: smtphost Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by ironmsg07-lv.qualcomm.com with ESMTP/TLS/AES256-SHA; 06 Apr 2022 00:16:35 -0700 X-QCInternal: smtphost Received: from hu-vnivarth-hyd.qualcomm.com (HELO hu-sgudaval-hyd.qualcomm.com) ([10.213.111.166]) by ironmsg02-blr.qualcomm.com with ESMTP; 06 Apr 2022 12:46:33 +0530 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 3994820) id A941F3B51; Wed, 6 Apr 2022 12:46:32 +0530 (+0530) From: Vijaya Krishna Nivarthi To: agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: quic_msavaliy@quicinc.com, dianders@chromium.org, Vijaya Krishna Nivarthi Subject: [V3 2/3] arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold Date: Wed, 6 Apr 2022 12:46:01 +0530 Message-Id: <1649229362-31183-3-git-send-email-quic_vnivarth@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1649229362-31183-1-git-send-email-quic_vnivarth@quicinc.com> References: <1649229362-31183-1-git-send-email-quic_vnivarth@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org WLAN rail was leaking power during RBSC/sleep even after turning BT off. Change sleep pinctrl configuration to handle same. Signed-off-by: Vijaya Krishna Nivarthi --- v3: apply same change to active state and other sc7280*.dts* as well v2: used bias-bus-hold as per review comments v1: intial patch used bias-disable for sleep pinctrl in sc7280-idp only --- arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts index 1779d96..eb43ce5 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r0.dts @@ -859,10 +859,10 @@ ap_ec_spi: &spi8 { &qup_uart7_cts { /* - * Configure a pull-down on CTS to match the pull of - * the Bluetooth module. + * Configure a bias-bus-hold on CTS to lower power usage + * when BT is turned off. */ - bias-pull-down; + bias-bus-hold; }; &qup_uart7_rts { @@ -1267,10 +1267,10 @@ ap_ec_spi: &spi8 { pins = "gpio28"; function = "gpio"; /* - * Configure a pull-down on CTS to match the pull of - * the Bluetooth module. + * Configure a bias-bus-hold on CTS to lower power usage + * when BT is turned off. */ - bias-pull-down; + bias-bus-hold; }; qup_uart7_sleep_rts: qup-uart7-sleep-rts { From patchwork Wed Apr 6 07:16:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijaya Krishna Nivarthi X-Patchwork-Id: 12803240 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13AA0C433FE for ; Wed, 6 Apr 2022 11:53:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230249AbiDFLzW (ORCPT ); Wed, 6 Apr 2022 07:55:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230263AbiDFLy5 (ORCPT ); Wed, 6 Apr 2022 07:54:57 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2096D2DBFF1; Wed, 6 Apr 2022 00:16:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1649229404; x=1680765404; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=G8TAxFuMIH2k2HAYU7fzVN3wL8YmlGxi1x8C6tasnho=; b=xypWVrB73Siu4NHZtcB2SgV+cBlneJ71qSOTF+80qifkROoacMV14oSb ulI5uMOys0d/uryyEavFTea+RAnH8TRz7Ggp70KY5yrY/PZvEDtiMj/uV aS09iCyLM5xrI5mqKhgNZBSlMEWZ2dLMQlHgoDRAaxbdvgy4rvcVWYrdB c=; Received: from ironmsg-lv-alpha.qualcomm.com ([10.47.202.13]) by alexa-out.qualcomm.com with ESMTP; 06 Apr 2022 00:16:37 -0700 X-QCInternal: smtphost Received: from ironmsg02-blr.qualcomm.com ([10.86.208.131]) by ironmsg-lv-alpha.qualcomm.com with ESMTP/TLS/AES256-SHA; 06 Apr 2022 00:16:35 -0700 X-QCInternal: smtphost Received: from hu-vnivarth-hyd.qualcomm.com (HELO hu-sgudaval-hyd.qualcomm.com) ([10.213.111.166]) by ironmsg02-blr.qualcomm.com with ESMTP; 06 Apr 2022 12:46:34 +0530 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 3994820) id 0F7223B51; Wed, 6 Apr 2022 12:46:34 +0530 (+0530) From: Vijaya Krishna Nivarthi To: agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: quic_msavaliy@quicinc.com, dianders@chromium.org, Vijaya Krishna Nivarthi Subject: [V3 3/3] arch: arm64: dts: qcom: Configure cts sleep pinctrl to bias-bus-hold Date: Wed, 6 Apr 2022 12:46:02 +0530 Message-Id: <1649229362-31183-4-git-send-email-quic_vnivarth@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1649229362-31183-1-git-send-email-quic_vnivarth@quicinc.com> References: <1649229362-31183-1-git-send-email-quic_vnivarth@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org WLAN rail was leaking power during RBSC/sleep even after turning BT off. Change sleep pinctrl configuration to handle same. Signed-off-by: Vijaya Krishna Nivarthi --- v3: apply same change to active state and other sc7280*.dts* as well v2: used bias-bus-hold as per review comments v1: intial patch used bias-disable for sleep pinctrl in sc7280-idp only --- arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi index b833ba1..602ebd4 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi @@ -398,8 +398,11 @@ mos_bt_uart: &uart7 { /* For mos_bt_uart */ &qup_uart7_cts { - /* Configure a pull-down on CTS to match the pull of the Bluetooth module. */ - bias-pull-down; + /* + * Configure a bias-bus-hold on CTS to lower power usage + * when BT is turned off. + */ + bias-bus-hold; }; /* For mos_bt_uart */ @@ -490,10 +493,10 @@ mos_bt_uart: &uart7 { pins = "gpio28"; function = "gpio"; /* - * Configure a pull-down on CTS to match the pull of - * the Bluetooth module. + * Configure a bias-bus-hold on CTS to lower power usage + * when BT is turned off. */ - bias-pull-down; + bias-bus-hold; }; /* For mos_bt_uart */