From patchwork Thu Apr 7 07:35:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 12804571 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AFC3C43217 for ; Thu, 7 Apr 2022 07:37:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241936AbiDGHjz (ORCPT ); Thu, 7 Apr 2022 03:39:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241943AbiDGHjx (ORCPT ); Thu, 7 Apr 2022 03:39:53 -0400 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2054.outbound.protection.outlook.com [40.107.101.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FE3DC53 for ; Thu, 7 Apr 2022 00:37:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VAX3INCodU2gHhSY/B1GfrCp7vadaX3Gc6Tzk29Ss27tnwtTlbIde0JEjqBvAp7imYtjwknVU4qEeOs5ssEUVUZ/E8SV3k/l9bLhmBKRX0+K81M6vg6UR4BshxhiblSAPO7Jfx1yFrREkXteD8ch7/xFg7ExLOYbCKHQgR7KP/vhlPtO7F/HKK6hNePT7yeW6IA0YFZtqLS6trM95hsDNljgueZdeS6F2K8Dt0N6kQKfyGimi6JTB3C39iBqIosPY8kFuYyy+s7G1fK1TXiHkud+vD/J0NSkE/HrFBehtptQ56bxePO2k7R+bjcGMtuYmDnh75RhEMVgKHp5SgHTxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QlNYJFvb6XBmB166Ih+QgfI8zyj7dS/CPcKWL/35OGI=; b=CVq8uWhOlXIB/yPWVhGFkKH6t8eshhKjFvyOu5U7rccWC0ziH/OlT77PtVtmPWkFRk8zbWWzCTPnKVtxICWf9uANqlPztGDUNNT4SGmIy0UDLL1rUFebvbLEkQmIjSDsL0+Vh8FR5zXU1janDqtwpdgRzOEteTHqm2h7bJX516U1FNehGoNVgudbsgkvrnFaP0yd7K7IQucBIb9lE6ykcCEm6EdZPmx0o3cCoTHY4+xQuG5IQpEqW967OFy7AMhXm9wVwaBCk6FtiOaCxQ0MyGwzkC6S0Ntxuw6XyuqiyCqztKbNnElJMOmbsyzECe3+0DpEh/Ns5VL+rdGnZeuADQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QlNYJFvb6XBmB166Ih+QgfI8zyj7dS/CPcKWL/35OGI=; b=DKxumlfN4KI68Dml6WqIEiTWQmmGWl3VIqlfLfP5sm/V92mrQr3q+9SRy1Ogob+dBnliHLVxP4GHJ+LY/RbFNkZE5XAsNmRhK6KSv0wUGpiEG4k0KcQmv5OSPBlRASAQTKSK0WhZ5uLLCxQlCevVmwq7i7islqbs2zSfDHUyy/vaReDQ4+Ucy5U/1iZAbE8yrWt96Td5gB0TywqG0cvMY8/0++4+7E4T3d+0iPECTPR+xIMQ2RUD4VTJJWaxQfHkj2XO0dj36DSpsc0FwUeN96eMBJOi4TtoBgUwwnNmtHb4fTJgffrxW6fKZ8pc48DbrfUzi5CWdnwILkKUiAWf8A== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) by BN9PR12MB5228.namprd12.prod.outlook.com (2603:10b6:408:101::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr 2022 07:37:44 +0000 Received: from DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2]) by DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2%2]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022 07:37:44 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, petrm@nvidia.com, jianbol@nvidia.com, roid@nvidia.com, vladbu@nvidia.com, olteanv@gmail.com, simon.horman@corigine.com, baowen.zheng@corigine.com, marcelo.leitner@gmail.com, Ido Schimmel Subject: [PATCH net-next 01/14] net/sched: matchall: Take verbose flag into account when logging error messages Date: Thu, 7 Apr 2022 10:35:20 +0300 Message-Id: <20220407073533.2422896-2-idosch@nvidia.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220407073533.2422896-1-idosch@nvidia.com> References: <20220407073533.2422896-1-idosch@nvidia.com> X-ClientProxiedBy: VI1PR08CA0225.eurprd08.prod.outlook.com (2603:10a6:802:15::34) To DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 24449de2-c78e-4612-8b34-08da186980ce X-MS-TrafficTypeDiagnostic: BN9PR12MB5228:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LmrZfNUSTrnuaDnSOVoMTUS4wkIAsJc9WGuU7TkF1tZIatoO3AU4rp/r9cSajeMT9ED+fzAeyO9aW9vglr4XDAwpsQmTpYD3LvAODFdiYOED2OHpweuQOsuLejObzg9o+OWjPsGk8q/XIUkLl4itsu/rloMpsobqfItk9khB8+9Lxop3aepBthp79JFuwliftMnpocss7DkJNq5vXwj/35j2KIQDXDVoxeV1keIWqIEoHHBqaMPgstTACWyPqLdlvVlUP8asCmHJox8d1/WSHhjXBlTk9JdK23XoiTrL5yDpMIfy5X6jI9PlHYSSeirYIHAxoD7BSOQQNawhuUhhHUJSP53UcPO7d5BSX0rkOPuEyhs1uqA3h2oRIubErq7/Owvbo4JWCmQ/qvY/oMw/9V3QwhvPe/APj/b5zgYOwIrGcqy/zvJZaaty2QMZnfMpcj4h53YGZgRZQ4U+K2Fqnh3UQDtfJ5yz8aEtlmPWQXM0CCiDZJgio+jt6tLg2skjKNaNJwQ/bBEwanPoY327lUTbf4VM2jAzK9ko+K4JCzXYn0oHURu/rWrfYUIxatSdzFKDQI6qx7N0sqeG4wJBWgR9mk46HL18oOchugyA65Uug4bLrzn5oN0+87TptxYHu7pV5+abK29uCa2eDlHvBg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4337.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(36756003)(6666004)(4326008)(8676002)(66476007)(66556008)(66946007)(6506007)(38100700002)(5660300002)(8936002)(316002)(2906002)(15650500001)(6916009)(1076003)(107886003)(26005)(186003)(83380400001)(2616005)(6512007)(508600001)(86362001)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 07Qk6r1UOg7FRcD+UDx41yBap4fuP9Jp7ry/gl+QWpX4gTUBG25JVVCdhEDKkh6/RtYmKGduemE5E3fHI5N9O6YSy9NFHeST2TIvXacoFz8pLlMSpFtixK/q2R1u69NoCNx+fK7gKAp65H7xdgeKDwh87fUEeCXdY3VxxeGkJDY6kxkaJfxjVB1Yb6E239FFVUIEhXZUb5HOiAJsyMv3emxJhjJIAo4Y61wDWfB0Vr4P9RASL9aZ2+F2AY6dSmGWbTQ5FqpiquZ1/dMaZjGufVmjgArdx5SFdQ7bHZl190ydZdZqfFFzPfWmq1plf8biJyH1+lRZfwonjeAl9ltjt/RXUejpSKOvkXBnKZOv7Vtq1YEhm7CiN6B4pUT7UUvnNjMMTSXyS1I4L/NkWu7vLN3sprnrR40DYapdx9jJSXJHd9pBthFO4fx40g6o66/1DXXdK3L6RzDjU5EYshDJoagkbUA7HBEK5VisXCcf1nVLRLiY/7y3Iu3g9gEr/nYRkamJ2TViVwOZGB9JyK7JpHiWuS4IjvQGFG7a+MJqDmAJ2VmcYzAJqUiVZINM7EmFLWxS25NhfsADQ3AzWi0GAc077HfeY75k3TF2jDoSQiJbEM2Lqzt4IraFIdUe5R72IoLcj6i8/OV63cENF1Syx/a17PxB7zWIwLuroUh3oSphWpzDT6OTfYtrb3Qi1sQfus+w6I0CR1a3whfXn3YmoFiQjJoM3bldZ+kKdhlPvr2as3cee/uXx48JKn3gBEGfL8pZRk2O+Wf+AhbQ8lA59Wg6/vfdIePdLJA7cX/CqdX17gTLxOakD5+HcLKVazG1sDylsji3uwtenGR4pOWAv+AB8STxNBsGGn7l3zHMw44wLlCD+/3iS7aYEh2UBm/eemS4htYFgnL3HXBvfqbhQRl5qReAkw1b0ahVqM0HubULMIeL5znn1btOV6CaN/eDgqkVnF6Y1WfeszDkl553Iqb7cPbwGnQchHN2r/fgtAEMN2/gWl8KO89YUGkKgMUz8d0RCWWsi0FrGNHIHZuSpWPMlsoZA9VCTDoshwtAzsauJYxWmabRR5tLHZl2meupIQivlrPO3TnRujI8hHxSRdDahjmiWd5BH+A/dpFl8RPbcNV6wShjohOHQHOVahId520ppbJOPyd4nu5bD2XjjqR7KIWpWLFIzNw/eqQvqcsrcD3kaCDI2kU3CaWlTewg7A7iWF0VDTEUEcIp9idDPgryMWsWdcfgm5sWuwg8LSZ+Mzfqqj2nbnaB5al9kqrZpL8sAS8Jq9zalJCP9LYb3KMQI26/IhHweFTt3WpwZGn+3dINeamBttN8jrn4yOcCsoO2verFCm9jDQtZ/V9iGkMX58TR4CpYV5QFjHUcVurjLxMdelkqQyQlgDgjtUZwNY0QUPQvuX1/68p9FHXyagjpb7utzkWt+Ju7EPvfpCCwhq4D6UYB0RLbiyBwTnyZDyhGHOwSzeydXT2iwhENJYr3bi0TrRikICj9+D34QJmqhk34wcl3g5sNEb0/Z2ShzhQzHhTMpcIMospuo6bUQjlLCIb6gW6np9FO1Tk/80WcHR334xaA15wIWNGGLF6SxnMq7gwdKfnnd0/+6IF+WpbAMS1O9aJQTzVxiEqZeF6/lwnXQL9NQDBPK1t9dCHqQzWTRjqVguzhRXzj0z+GBdi3lmwot2w9N2wHUEFvOmrticVcwkoaCNntIOehDbu4m2Um65sCtaZpqw7lwSIEow== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 24449de2-c78e-4612-8b34-08da186980ce X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4337.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:37:44.0029 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 599o0PydulJh+OEbKl7AFDBOoTVNKUTm+dzD+f/mS3HplM5/h69Mxvx+vKCTKRAvSnQ62ha+V3RvszrOUgjVVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5228 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The verbose flag was added in commit 81c7288b170a ("sched: cls: enable verbose logging") to avoid suppressing logging of error messages that occur "when the rule is not to be exclusively executed by the hardware". However, such error messages are currently suppressed when setup of flow action fails. Take the verbose flag into account to avoid suppressing error messages. This is done by using the extack pointer initialized by tc_cls_common_offload_init(), which performs the necessary checks. Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata --- net/sched/cls_matchall.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/net/sched/cls_matchall.c b/net/sched/cls_matchall.c index ca5670fd5228..37283b306924 100644 --- a/net/sched/cls_matchall.c +++ b/net/sched/cls_matchall.c @@ -101,12 +101,10 @@ static int mall_replace_hw_filter(struct tcf_proto *tp, if (err) { kfree(cls_mall.rule); mall_destroy_hw_filter(tp, head, cookie, NULL); - if (skip_sw) - NL_SET_ERR_MSG_MOD(extack, "Failed to setup flow action"); - else - err = 0; + NL_SET_ERR_MSG_MOD(cls_mall.common.extack, + "Failed to setup flow action"); - return err; + return skip_sw ? err : 0; } err = tc_setup_cb_add(block, tp, TC_SETUP_CLSMATCHALL, &cls_mall, @@ -305,11 +303,10 @@ static int mall_reoffload(struct tcf_proto *tp, bool add, flow_setup_cb_t *cb, err = tc_setup_offload_action(&cls_mall.rule->action, &head->exts); if (err) { kfree(cls_mall.rule); - if (add && tc_skip_sw(head->flags)) { - NL_SET_ERR_MSG_MOD(extack, "Failed to setup flow action"); - return err; - } - return 0; + NL_SET_ERR_MSG_MOD(cls_mall.common.extack, + "Failed to setup flow action"); + + return add && tc_skip_sw(head->flags) ? err : 0; } err = tc_setup_cb_reoffload(block, tp, add, cb, TC_SETUP_CLSMATCHALL, From patchwork Thu Apr 7 07:35:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 12804572 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20826C433F5 for ; Thu, 7 Apr 2022 07:38:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241949AbiDGHj4 (ORCPT ); Thu, 7 Apr 2022 03:39:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32922 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241956AbiDGHjx (ORCPT ); Thu, 7 Apr 2022 03:39:53 -0400 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2056.outbound.protection.outlook.com [40.107.101.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 74D5413F48 for ; Thu, 7 Apr 2022 00:37:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P6tkwlC9FkpDALdU/Q7mIhiMNTEs7rw9Val1dfMAHZkUfBgsLl+YgnToJpC+m95dC+AhmaMlaXHqS6Qv6JLK1DqR8lYPUmbM4ImJkAbaH5mawH4G5RzmW48h/LtL4BngwP2PuBCD42aQFSJaPeqE2Eotkacy1/jeWg/xepoPc1aFmlUp4+YKyktPfIcrPKH4hXBbTTYfa3kwz/7Ydsiz9Hbf5dbCU9MlJ6PjDEC96FTKORnYZOq2gEakEHMqQS6EFRstNLSSFsMJhpQz7sjAAV35CiwWNt1+7FgdxwWwLFZ/uDfBDQbzzKS0jS7hTSZMOZgElbLxVKEe6tXuOpkccA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CGVxqSTzIRgRb0rue+YVWQ59TFoeR6zPuzqQ//DkOrA=; b=CE8rpIlndHSTNx2QSGdduT+1j+iCs2ruqOwH5TFrpIFLkouWJPrR/knZpMtNxDOL2Js7aydadapvlytgEkUMJW7TNhBwv0y6H58vkwEBOwfggRRAnNkzgI7xJLarj8Zg5E0YKIF8TH4c01t3sZbSD88FGVTqtV7pfnIq9TvLfm8ww9oNNjy9U1Q/hkq7YIATahhbWcHU2rlQj0t84Ds+7OIRn9mWGz8NpNcaKjy4dOaN7QPls8IROjA+GTFX+epCtOAPTiP4l7Ve7INB3DgM02m0HFYdI7sP2ZeYve0ITxm0GMOmp2XFt2pbIMv+aMNYJrN5dp2Yxg8+5ElokZUFjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CGVxqSTzIRgRb0rue+YVWQ59TFoeR6zPuzqQ//DkOrA=; b=tF4uRWsNdOdPm0xdYddLdao9i8aK6FGP+T1waIXTh1qnIMhcDQZIrckWNvgaI8T73Apadrk5Lcx8C/AMX9rpft6aJn9SOoWFKIedkd21Sp6C5ZvgKH9+GwZQRNMHusvp52ie4sujYimAncjaAcDV4oyaj/Z1Z0uiPrl7S9kwwr+75Sh1CZgRQk8Sc57morl4BgnbId7zneaqUXJs6PXH1a6ZbkoyCtbxcRGKQNwFOHhoSYI4f9xqc3iUOtvyG/m+ZeUZ0TyNKgDxhHezWjN/BnMl9wAFmGTvDuw/iaaPuyEWI9h0/fQX268huXsrvQDjDSrcnv1H1S2i29u3YTVAlA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) by BN9PR12MB5228.namprd12.prod.outlook.com (2603:10b6:408:101::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr 2022 07:37:50 +0000 Received: from DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2]) by DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2%2]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022 07:37:50 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, petrm@nvidia.com, jianbol@nvidia.com, roid@nvidia.com, vladbu@nvidia.com, olteanv@gmail.com, simon.horman@corigine.com, baowen.zheng@corigine.com, marcelo.leitner@gmail.com, Ido Schimmel Subject: [PATCH net-next 02/14] net/sched: flower: Take verbose flag into account when logging error messages Date: Thu, 7 Apr 2022 10:35:21 +0300 Message-Id: <20220407073533.2422896-3-idosch@nvidia.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220407073533.2422896-1-idosch@nvidia.com> References: <20220407073533.2422896-1-idosch@nvidia.com> X-ClientProxiedBy: VI1PR02CA0044.eurprd02.prod.outlook.com (2603:10a6:802:14::15) To DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6007500c-60e4-429b-300d-08da18698473 X-MS-TrafficTypeDiagnostic: BN9PR12MB5228:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sjoW10giK8bbA9/ycFDrD8cZu2LNHBvZ6XOcg/A93VqmV5DFsO4eVe3HJgcJIAPDuYvjsr3fxFg5Q2P5uFQXu+MZNN5RNl05ZcUxb8oGT3iVf1e7IDQfpkFKu0YZf+T0w2S0xnE8MvT6Gz1WMfCKBLfZAxL8357qsyZi03xZBfXFIcbe1DmsFNgcnu0RnbN0JheVVywkKvZuACmNQYlMMjcApajbSS4b/mJRWnoJ3YprZkAjSDMIK98ai+i7g1D/oxxC4OMFx5DEdK5+oc6IrhgxOC9z8o8AWNncHvIch9JSlI/YGnkFm2EIQK+viZz3TXwAt7X7xxdZ1J0wyOyzGBiDWH0Pv29NBT0avLCVUg7LgULF6LfoKQBE89T6z5PxAvr/WrsF1d584NhBeQdAYCt3LXpxF+SVXgUtnnaHGRX6LZO17KxJBnoCJiWMLx5C58Rv6gFhOGIhFzIgXRqcWJxPTRi2NSJfsFBTVXMi6T+FUUR/RPGHoX9L3D7xBxcfebHfKrhIgoggdbPulZCydQNOAuXrNFUs7NfkGuYN60kbZ7++2Uo1yhm3VPPPsBBs9hxF4xiSLZDF76PY3JWFGF5iY3uuIewHEyINWhmZ+6o0g/GEaW/IOV0xuJscbBgnsdMrxyLxbY6AvunKio008A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4337.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(36756003)(6666004)(4326008)(8676002)(66476007)(66556008)(66946007)(6506007)(38100700002)(5660300002)(8936002)(316002)(2906002)(15650500001)(6916009)(1076003)(107886003)(26005)(186003)(83380400001)(2616005)(6512007)(508600001)(86362001)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: goJUezMr/ac7sVSsttKOTh8Ma3eMYqQ7iE6hXHpIOK+6/qwpQhwBn3c9IWweBsbZ6V4U/FUUNYkl4GIyyaZMq/zlYyAERV0BgaWEO1hWYacWESRcqbdSA3s2In8ZksC6ipQrAzpyQSV0hKms3i2YV5MXLVnex10OKwTU01UI1T2Q6AFK/BzZ+4NdYWQltIVRBL9UvekuCRqtQU+CzPwZz2LQzuQ1zQfwHWwkbuuz93F/VPqUJncaoIca+/Xs4c0MkN3NcKup6OJQwMZi5gnvRiwRNHdd103WlzuubKjZR4sNjozTDPUjM/04GW8SRvoxuV8PUFXkighp1zrds2MynCeT1CnxptbChZMdayh3e042u/vL2b1bHKbL+nKrhgf5Y1DrGjq5hydHEi+FCO2mL6FUPG5zq4EhONfH2/JwJPU+UQroYBtxqpA/gfUxsjqYGRXziQQHOOaLE2gAHYAo2NAlsSBdYkMU9Hj1mrxqmcec3kZPtGKdMR9C0IbeTX/aDgwO6snIZQQz1c7GwDbqkSV7SNm8wnyRkB8vXhfYqd3kopMa65bEnqUi/XCEOFqpJ2djy/swZCKSEkr0aw1XniKWzJ2xgKcJ4/OlIXORYzVzXuD69FANYB58KpdsxE3RYMSkkMtG+TcEAcWkahTTOPaMYJP+5thgxQv491bs4EXC73tQFEMmuJnv+mGDMeIX3C1IF++lYbIfqdaESC5qeAMTkXnQbZfUhmlc5zxJbPC67ZNNRUiUx7EZ0whVGbvH8AB5wh7Bom6vXoW+XOqAJXK51Wb+WVrP2B0K5wDqgTYI7ew4o/ckrvaIJSiyRF+v4S7dTEtaPDVHBmwRQpwIvyHSD3cocGzquI3rbsTpVSmvsSr16f1njD0t+6xGSAn1a7EESdnKLvvv6RjK1SxSmMhNPynjfOC6+izkygd3Q2duOCRqHZ0kMgyzo29B2NVj5EX74j0+BSjmNczGWvFKsKrPwcA9kHPJFvjZusDDJP1glAYVUmmreemgMG+OfoH7dl8pCcn5kr6bMIkjCryKC08/NTYZYsgRexetFiBF7GHmbvRRQO0wIMIeBWSCHKG1Jit/1v9GD11Y4jBfNH1iQ6G6a+jlQMlF2E03Hdg0pq8o+W3Gl5/HmI43gZ03qaS9cvCdxoFL1g/Hn4pdVzbHz+wvTB5KXTTACiIYAJnrpsEq77UR6zssjU4gIsNcrPjWuSJeNPhdULDc81+ciivsDV2SkBeYoDRMh2HtRgiLoyIdH+n9DN/OsBwWEQs0aG/iLgjbSKqJCC2WtOfL2939JwAg4PkfR2n0DiSvqLzuKZQDqNGd9uCRy5gBdBwvILIBj3A/StS79ky5ih50TT73XMNRjwo11+9sc3KchQtz9v+m/yYeDdtSm/3kNgIWKdfKsS3b1TcC/DvU0cMnHuh0ol8NY9XLM7QbcpeFFy4wKxBr81OmqDcCSHLXd4rsTKBdrq5vS2S2ESMwvbzeaEl3/k2+Gl7b3bLRGr80t+ynqJmnASX7tK6WBNiEoEiew9BDulSKKQY9irKpo8WWGyGLry34+QZHA3qdrDYGxHtwrkN91xLC0HT8SnEajNpf8cZuOZS4OwQzab+aCCLi1EluzDOquxl2lwUEvxWEGommWrc6oEzy4xtI3sNaZFJ/LHUGgXkJjFQRdj7zRcFd3/LEwOqevhKvJDsUNy9fepMKaSb9UbhpQDSud2Ywj+2T9Kee0de0x3pWC+vsMQN612aPLg== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6007500c-60e4-429b-300d-08da18698473 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4337.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:37:49.9890 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: kma597SRAQTDG+uRWpHlMkjB6mptSbgjYvNTeZEkzNpuiHPaCTkosjPBFT5Mt6XdSPJlrJbleIcHTxJNBb321Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5228 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The verbose flag was added in commit 81c7288b170a ("sched: cls: enable verbose logging") to avoid suppressing logging of error messages that occur "when the rule is not to be exclusively executed by the hardware". However, such error messages are currently suppressed when setup of flow action fails. Take the verbose flag into account to avoid suppressing error messages. This is done by using the extack pointer initialized by tc_cls_common_offload_init(), which performs the necessary checks. Before: # tc filter add dev dummy0 ingress pref 1 proto ip flower dst_ip 198.51.100.1 action police rate 100Mbit burst 10000 # tc filter add dev dummy0 ingress pref 2 proto ip flower verbose dst_ip 198.51.100.1 action police rate 100Mbit burst 10000 After: # tc filter add dev dummy0 ingress pref 1 proto ip flower dst_ip 198.51.100.1 action police rate 100Mbit burst 10000 # tc filter add dev dummy0 ingress pref 2 proto ip flower verbose dst_ip 198.51.100.1 action police rate 100Mbit burst 10000 Warning: cls_flower: Failed to setup flow action. Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata --- net/sched/cls_flower.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index c80fc49c0da1..70e95ce28ffd 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -467,11 +467,10 @@ static int fl_hw_replace_filter(struct tcf_proto *tp, err = tc_setup_offload_action(&cls_flower.rule->action, &f->exts); if (err) { kfree(cls_flower.rule); - if (skip_sw) { - NL_SET_ERR_MSG_MOD(extack, "Failed to setup flow action"); - return err; - } - return 0; + NL_SET_ERR_MSG_MOD(cls_flower.common.extack, + "Failed to setup flow action"); + + return skip_sw ? err : 0; } err = tc_setup_cb_add(block, tp, TC_SETUP_CLSFLOWER, &cls_flower, @@ -2357,8 +2356,9 @@ static int fl_reoffload(struct tcf_proto *tp, bool add, flow_setup_cb_t *cb, err = tc_setup_offload_action(&cls_flower.rule->action, &f->exts); if (err) { kfree(cls_flower.rule); + NL_SET_ERR_MSG_MOD(cls_flower.common.extack, + "Failed to setup flow action"); if (tc_skip_sw(f->flags)) { - NL_SET_ERR_MSG_MOD(extack, "Failed to setup flow action"); __fl_put(f); return err; } From patchwork Thu Apr 7 07:35:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 12804573 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C3D1C433F5 for ; Thu, 7 Apr 2022 07:38:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241954AbiDGHkE (ORCPT ); Thu, 7 Apr 2022 03:40:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241952AbiDGHj6 (ORCPT ); Thu, 7 Apr 2022 03:39:58 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2089.outbound.protection.outlook.com [40.107.223.89]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E21FB3EF24 for ; Thu, 7 Apr 2022 00:37:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QEXmdsC55rizrIaFkFruE5ldqVYpyOdTCfcbl6q3FYwvss03sPhQFdP4Hw1+PuND//J/6cX9EyRHkU107tf0rTtMDRZ1znQkyAhFUNDM2t6Xg5frBpKGLsdECYj53VZDVUtxx0i23RP3XXurqCUzajIKxMWq6+ZIFwiZnbonzgZ/q91UgUFMqXe2uqUa+sEzMv4AElYH6z0ErYW8pMc4SBtU7avPUMYWlGqcfH+Lk0QsH9B7WEB30BK29J8KyXBUKqFMiLBEZgtF4j8FdJ4gYj6WwOvUYPRdZEpllP+5Ck4l4YoDeES2j1yiTwDwikALqxH6Cbm21Tvu45EMahmA3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lXZ1Ezroy5uPL38/RX9gI3SseevwHbxB3nhfJq8RfFM=; b=Xxejq9OcqHwm6yvrcmdSrWmrIYeXmAHarPT+fhWK3DUg3brOrnEOEplpojxePrTnYGFakW3Kp4amEwk6Qw3OtN99EZgv26Ojr/YKA664Ct0xd0+DubUIGeOd+AZQl0cbWDpYMHNR+Y4FBSdrCfvAeE2ixT9Olxf7+1guvuoaYpp2LmnJWl3AB1wFB4E2OGJxrcInh9808ioMmVSDAlgYCiWl5NTkLOEWIa7lw0Oi4/ZTiTY1S9vtSEcLEtf1+1ufxQrE1pVgcLXV/wuFblWXGczvWcAeyn1BJtZh4QiqZQs+p7O/us3ByIa7niKFW1AIAB27XQ8DjcIGUE6v1SoBCg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lXZ1Ezroy5uPL38/RX9gI3SseevwHbxB3nhfJq8RfFM=; b=seJ/ZrXVg6SuxHkmdL20Wm7LjOpPW/2UDETrxFgX/5zE3i0i6NDOGcJihjcpLODCRE/TwAPLyuAM1624jYhARznTMAhARvfhDb2fAZxxyDjQq9U1ehITcc4Hipnoy1536wj8zpt8dzxXDlP5+L5qzn58P9oB9oqCb2QnMRpxo7EB4DiMWR/qxyn04JSreXFZV8BrGx4AizfmS+bCuoi5OegHFm561BIX9rL8Lt4BtWfUKYg/GUeiBI8WFFyNaa5iMGbjqKBv/d9VNlZnP4J859hnvQlgBybP/JLK9C73lywoN2Iv1UTzz4dc5Qna8AYHceas66rFR+wzyvZiePBckg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) by DM5PR1201MB0188.namprd12.prod.outlook.com (2603:10b6:4:56::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr 2022 07:37:57 +0000 Received: from DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2]) by DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2%2]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022 07:37:57 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, petrm@nvidia.com, jianbol@nvidia.com, roid@nvidia.com, vladbu@nvidia.com, olteanv@gmail.com, simon.horman@corigine.com, baowen.zheng@corigine.com, marcelo.leitner@gmail.com, Ido Schimmel Subject: [PATCH net-next 03/14] net/sched: act_api: Add extack to offload_act_setup() callback Date: Thu, 7 Apr 2022 10:35:22 +0300 Message-Id: <20220407073533.2422896-4-idosch@nvidia.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220407073533.2422896-1-idosch@nvidia.com> References: <20220407073533.2422896-1-idosch@nvidia.com> X-ClientProxiedBy: VI1P194CA0059.EURP194.PROD.OUTLOOK.COM (2603:10a6:803:3c::48) To DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 91ee9266-2a63-4b85-19d8-08da18698897 X-MS-TrafficTypeDiagnostic: DM5PR1201MB0188:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uINeOSIBiQTCQ+SIqFSFWVf/aYexTB+m/Ti1R6zeAToZzQMLvp8LL/pXkboPxyEbJJEwFTFxj0NlgiTKn8sdcJHfTdeLIdFigU/64bYkmW+t4LCi923aAR+KsH85DUK8Pd2TSotbwSaOcjNyCQY8nFJatxAyB5/2znG176dFHWPet7Sc8XX/jH3N4pg2kh4T/9WEEA6MjlsplG9P9P42dG8KqzChbEcYInm/vMsJ3Sk0yhmtwP8kqCPObILYCp+o0bAr1yeUISeANvD+NvUkf+Jh5uTHJPzxUPAUZLLiR80CznqbkqXWPLyyCW75Jcd73ldMNeVKtIE5ARs4CGtiJGW/tnlTgmjGvifilXqFUhaEn9AImwFkU8zJ3KMYcYDN5mWYpnmDgAR0KDc3eehZQRzRHOUweqMHPXDhIU1rfXvo2ZPsDLcyo2emvokqm5hJax23voPl46HlR4Y/9uPqbU/V3wzme456XGlDQBAl39pa++UHTBscoqLl8vKL8oRBnP9gUZTsvbclzzSR2rzpRHG8IKxXTrFhBzjzR+bFC1TdAcFH1XUGyk2NaCLsCQBGj6cIWEWqZSyXVWFPdwk1YLWJNKPkX1VOMVp3jVo7FDuHArv/cWCg7j+tu2emqX+svtdsWGNKYypiMBNgCQDNwg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4337.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(107886003)(6666004)(38100700002)(186003)(26005)(2906002)(6512007)(83380400001)(30864003)(6506007)(1076003)(36756003)(316002)(6916009)(508600001)(6486002)(4326008)(66946007)(7416002)(66476007)(86362001)(8936002)(8676002)(2616005)(5660300002)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: onngeOf+yWwGTaOYHRBFS6IbWtK/IxuN5htDuBX1llY6RI1JJyagAmLXrsbKq9MfWFYk4j9TVQBnDBiTwx1yxVwTPhdIY669oJAVPt04nxppFe7y04XxB2RJCY6Nfl19mSOYYduyk2jKOtrt7d5sKRO6+FMWvnXp9/tFizTZaLVPSTyIoc/a56i+e2FQA2SMo8/5rk635tX1hR+bVZOIEIHpJgWXw1xI8IJqeUjIfua8mGZoIY98i7LgfhSexFDg3HBeAj7BWsG2bjHOFxMEWQio/9ag9CBONWkOd1Tad7+qmfynredukwe6pQ0sH2MaIRYE5oz8Mh2sQEQgyIYI/lIdvXjvUXQvdGdQ3TTpz9y9yPYwiOahlrgfcvPJssz1jKiEaSqfR3ztA8jGZq7s41GzmrqiIXG+S+l2PEZx5zyFFThIRZ+hsNLk2RRnVdZ3qjtjrYTtuTmhwp4k3VmUxpJsXN0cCDM7WpW1o4uAPT+XgmWWEgqF8sX19CpExCoQ0+5JdSdw/7QFy7AYHT0pSqYXPtqY6+Kd3+cjIDbEKXU63OPaeOP895JBsjOMhvI2QYlDzzbiMsjK2DZETmUwzGlwxyWLjTOEMTRuFCejtj7M7Y9ujB6FToKoxqUJ6IYDJuChoZqs0TAzA5lP85fd7hUQ5EWAmuV7KdVemGjgncL7aQjjx44TFjBq7dW0aCq6sG7kKjRc7wgWNiCvxI5wFcxKpGuVOjTpkGTnPyOFAsVFp6JN0QP+lEww49Rey7MyOPPD8D7S+Gfex2AXATZFiGiPNj7w4sUFDacE9+DMdo/x/9XYBZjuihsT9vYPg7djQCYG9/sIV8Sobz0ftgwiSfISiULSqGF3XYalErPB8vItPerLkYwuZS8XtYThwTHp2f3cIlKtkjfgHR4ZSZ2ypeO/IB5a+tWFzB17OoyXG24x34PfttLrT33zR/lyi3kSkztYm20oH5mGr2cJC6OWmPi4Gf8PLpmzvFDziRgwVkiOT3/cyJeph3HDibs0cGkjAVtjw1uWoO13WMLhe/WGIBEq+62obSXoOofCu09zCMKCUh34LaYzj8HoXV4Y8hd+oJoGRPAgSmXucDcos6zCoP8Q4o5qSSkEmuGoG2c9YGuWkpEPgGWbcK5MUJwPmsbUelp6c4znqLaGhRsyL3T6lWale1z8mkcC4gNgi/2Lf8P7t3x7lyHh3zrgMvJ4F8hY3vGs7EfUD9Gg76ScpZ+XMKiGHwhpm+nN3xjpmcVBOR6dLm/Sc866Z5N8aQ1UY02Im0CmxyPawZUYHDKQrTD1mhFvIR+gAzIic0ol/bHOIvIoSF82jvByptEEBI4puawh0lzTydYEntX19+6lk/Z2oWrHAv10z9sPp0bINOq6dUKUre5F2wWY9nlSp8G+VU84dwAyRLFL6a1NOyU5TWicHeLl1Ak/E/ztEJlNVxMu9i60U+EJwsJ/G7AJDnwzP+3IjtvPY1d6A84l9rOAj4BMFj4zjhj4YL6bekU2MlUgPcp9zRZYgHnFcKmJPNeGoYCulOJx0TN6gqKjFLbrvyAxENzQ4A8QgYCTJKCYZy7Lw3OXn2OpTxQIQCLQ19i4zfB688IMeD+Kh5ZSwsuHJnqK5wxxlwp3mpGRffaD7xSHv5omhg5FyTuR0FUaUQ4eiLEEDcC/0IKPY3wQpJ/fPNKr3l/4f4eScWDl88Y9/z3Lm5//Gm5TmY4OjLSiQ4isKw4n0Cwm7ZcTt3xhSQbzFSUouw== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 91ee9266-2a63-4b85-19d8-08da18698897 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4337.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:37:57.0312 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VI0Ks9vuE/dzVMEYo7UZI47ZZDeEN/Qek9ZOvNOyTs7Tbh5blV+IbOcrFUpTXwYSroCtWlv51z4U9GqMDOrh+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0188 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The callback is used by various actions to populate the flow action structure prior to offload. Pass extack to this callback so that the various actions will be able to report accurate error messages to user space. Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata --- include/net/act_api.h | 3 ++- include/net/pkt_cls.h | 6 ++++-- net/sched/act_api.c | 4 ++-- net/sched/act_csum.c | 3 ++- net/sched/act_ct.c | 3 ++- net/sched/act_gact.c | 3 ++- net/sched/act_gate.c | 3 ++- net/sched/act_mirred.c | 3 ++- net/sched/act_mpls.c | 3 ++- net/sched/act_pedit.c | 3 ++- net/sched/act_police.c | 3 ++- net/sched/act_sample.c | 3 ++- net/sched/act_skbedit.c | 3 ++- net/sched/act_tunnel_key.c | 3 ++- net/sched/act_vlan.c | 3 ++- net/sched/cls_api.c | 16 ++++++++++------ net/sched/cls_flower.c | 6 ++++-- net/sched/cls_matchall.c | 6 ++++-- 18 files changed, 50 insertions(+), 27 deletions(-) diff --git a/include/net/act_api.h b/include/net/act_api.h index 3049cb69c025..9cf6870b526e 100644 --- a/include/net/act_api.h +++ b/include/net/act_api.h @@ -134,7 +134,8 @@ struct tc_action_ops { (*get_psample_group)(const struct tc_action *a, tc_action_priv_destructor *destructor); int (*offload_act_setup)(struct tc_action *act, void *entry_data, - u32 *index_inc, bool bind); + u32 *index_inc, bool bind, + struct netlink_ext_ack *extack); }; struct tc_action_net { diff --git a/include/net/pkt_cls.h b/include/net/pkt_cls.h index a3b57a93228a..8cf001aed858 100644 --- a/include/net/pkt_cls.h +++ b/include/net/pkt_cls.h @@ -547,10 +547,12 @@ tcf_match_indev(struct sk_buff *skb, int ifindex) } int tc_setup_offload_action(struct flow_action *flow_action, - const struct tcf_exts *exts); + const struct tcf_exts *exts, + struct netlink_ext_ack *extack); void tc_cleanup_offload_action(struct flow_action *flow_action); int tc_setup_action(struct flow_action *flow_action, - struct tc_action *actions[]); + struct tc_action *actions[], + struct netlink_ext_ack *extack); int tc_setup_cb_call(struct tcf_block *block, enum tc_setup_type type, void *type_data, bool err_stop, bool rtnl_held); diff --git a/net/sched/act_api.c b/net/sched/act_api.c index 4f51094da9da..da9733da9868 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -195,7 +195,7 @@ static int offload_action_init(struct flow_offload_action *fl_action, if (act->ops->offload_act_setup) { spin_lock_bh(&act->tcfa_lock); err = act->ops->offload_act_setup(act, fl_action, NULL, - false); + false, extack); spin_unlock_bh(&act->tcfa_lock); return err; } @@ -271,7 +271,7 @@ static int tcf_action_offload_add_ex(struct tc_action *action, if (err) goto fl_err; - err = tc_setup_action(&fl_action->action, actions); + err = tc_setup_action(&fl_action->action, actions, extack); if (err) { NL_SET_ERR_MSG_MOD(extack, "Failed to setup tc actions for offload"); diff --git a/net/sched/act_csum.c b/net/sched/act_csum.c index e0f515b774ca..22847ee009ef 100644 --- a/net/sched/act_csum.c +++ b/net/sched/act_csum.c @@ -696,7 +696,8 @@ static size_t tcf_csum_get_fill_size(const struct tc_action *act) } static int tcf_csum_offload_act_setup(struct tc_action *act, void *entry_data, - u32 *index_inc, bool bind) + u32 *index_inc, bool bind, + struct netlink_ext_ack *extack) { if (bind) { struct flow_action_entry *entry = entry_data; diff --git a/net/sched/act_ct.c b/net/sched/act_ct.c index b1f502fce595..8af9d6e5ba61 100644 --- a/net/sched/act_ct.c +++ b/net/sched/act_ct.c @@ -1584,7 +1584,8 @@ static void tcf_stats_update(struct tc_action *a, u64 bytes, u64 packets, } static int tcf_ct_offload_act_setup(struct tc_action *act, void *entry_data, - u32 *index_inc, bool bind) + u32 *index_inc, bool bind, + struct netlink_ext_ack *extack) { if (bind) { struct flow_action_entry *entry = entry_data; diff --git a/net/sched/act_gact.c b/net/sched/act_gact.c index bde6a6c01e64..db84a0473cc1 100644 --- a/net/sched/act_gact.c +++ b/net/sched/act_gact.c @@ -253,7 +253,8 @@ static size_t tcf_gact_get_fill_size(const struct tc_action *act) } static int tcf_gact_offload_act_setup(struct tc_action *act, void *entry_data, - u32 *index_inc, bool bind) + u32 *index_inc, bool bind, + struct netlink_ext_ack *extack) { if (bind) { struct flow_action_entry *entry = entry_data; diff --git a/net/sched/act_gate.c b/net/sched/act_gate.c index d56e73843a4b..fd5155274733 100644 --- a/net/sched/act_gate.c +++ b/net/sched/act_gate.c @@ -619,7 +619,8 @@ static int tcf_gate_get_entries(struct flow_action_entry *entry, } static int tcf_gate_offload_act_setup(struct tc_action *act, void *entry_data, - u32 *index_inc, bool bind) + u32 *index_inc, bool bind, + struct netlink_ext_ack *extack) { int err; diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c index 39acd1d18609..70a6a4447e6b 100644 --- a/net/sched/act_mirred.c +++ b/net/sched/act_mirred.c @@ -460,7 +460,8 @@ static void tcf_offload_mirred_get_dev(struct flow_action_entry *entry, } static int tcf_mirred_offload_act_setup(struct tc_action *act, void *entry_data, - u32 *index_inc, bool bind) + u32 *index_inc, bool bind, + struct netlink_ext_ack *extack) { if (bind) { struct flow_action_entry *entry = entry_data; diff --git a/net/sched/act_mpls.c b/net/sched/act_mpls.c index b9ff3459fdab..23fcfa5605df 100644 --- a/net/sched/act_mpls.c +++ b/net/sched/act_mpls.c @@ -385,7 +385,8 @@ static int tcf_mpls_search(struct net *net, struct tc_action **a, u32 index) } static int tcf_mpls_offload_act_setup(struct tc_action *act, void *entry_data, - u32 *index_inc, bool bind) + u32 *index_inc, bool bind, + struct netlink_ext_ack *extack) { if (bind) { struct flow_action_entry *entry = entry_data; diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c index 31fcd279c177..dc12d502c4fe 100644 --- a/net/sched/act_pedit.c +++ b/net/sched/act_pedit.c @@ -488,7 +488,8 @@ static int tcf_pedit_search(struct net *net, struct tc_action **a, u32 index) } static int tcf_pedit_offload_act_setup(struct tc_action *act, void *entry_data, - u32 *index_inc, bool bind) + u32 *index_inc, bool bind, + struct netlink_ext_ack *extack) { if (bind) { struct flow_action_entry *entry = entry_data; diff --git a/net/sched/act_police.c b/net/sched/act_police.c index f4d917705263..77c17e9b46d1 100644 --- a/net/sched/act_police.c +++ b/net/sched/act_police.c @@ -442,7 +442,8 @@ static int tcf_police_act_to_flow_act(int tc_act, u32 *extval) } static int tcf_police_offload_act_setup(struct tc_action *act, void *entry_data, - u32 *index_inc, bool bind) + u32 *index_inc, bool bind, + struct netlink_ext_ack *extack) { if (bind) { struct flow_action_entry *entry = entry_data; diff --git a/net/sched/act_sample.c b/net/sched/act_sample.c index 9a22cdda6bbd..2f7f5e44d28c 100644 --- a/net/sched/act_sample.c +++ b/net/sched/act_sample.c @@ -291,7 +291,8 @@ static void tcf_offload_sample_get_group(struct flow_action_entry *entry, } static int tcf_sample_offload_act_setup(struct tc_action *act, void *entry_data, - u32 *index_inc, bool bind) + u32 *index_inc, bool bind, + struct netlink_ext_ack *extack) { if (bind) { struct flow_action_entry *entry = entry_data; diff --git a/net/sched/act_skbedit.c b/net/sched/act_skbedit.c index ceba11b198bb..8cd8e506c9c9 100644 --- a/net/sched/act_skbedit.c +++ b/net/sched/act_skbedit.c @@ -328,7 +328,8 @@ static size_t tcf_skbedit_get_fill_size(const struct tc_action *act) } static int tcf_skbedit_offload_act_setup(struct tc_action *act, void *entry_data, - u32 *index_inc, bool bind) + u32 *index_inc, bool bind, + struct netlink_ext_ack *extack) { if (bind) { struct flow_action_entry *entry = entry_data; diff --git a/net/sched/act_tunnel_key.c b/net/sched/act_tunnel_key.c index 23aba03d26a8..3c6f40478c81 100644 --- a/net/sched/act_tunnel_key.c +++ b/net/sched/act_tunnel_key.c @@ -808,7 +808,8 @@ static int tcf_tunnel_encap_get_tunnel(struct flow_action_entry *entry, static int tcf_tunnel_key_offload_act_setup(struct tc_action *act, void *entry_data, u32 *index_inc, - bool bind) + bool bind, + struct netlink_ext_ack *extack) { int err; diff --git a/net/sched/act_vlan.c b/net/sched/act_vlan.c index 883454c4f921..8c89bce99cbd 100644 --- a/net/sched/act_vlan.c +++ b/net/sched/act_vlan.c @@ -369,7 +369,8 @@ static size_t tcf_vlan_get_fill_size(const struct tc_action *act) } static int tcf_vlan_offload_act_setup(struct tc_action *act, void *entry_data, - u32 *index_inc, bool bind) + u32 *index_inc, bool bind, + struct netlink_ext_ack *extack) { if (bind) { struct flow_action_entry *entry = entry_data; diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index 2957f8f5cea7..dd711ae048ff 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -3513,11 +3513,13 @@ EXPORT_SYMBOL(tc_cleanup_offload_action); static int tc_setup_offload_act(struct tc_action *act, struct flow_action_entry *entry, - u32 *index_inc) + u32 *index_inc, + struct netlink_ext_ack *extack) { #ifdef CONFIG_NET_CLS_ACT if (act->ops->offload_act_setup) - return act->ops->offload_act_setup(act, entry, index_inc, true); + return act->ops->offload_act_setup(act, entry, index_inc, true, + extack); else return -EOPNOTSUPP; #else @@ -3526,7 +3528,8 @@ static int tc_setup_offload_act(struct tc_action *act, } int tc_setup_action(struct flow_action *flow_action, - struct tc_action *actions[]) + struct tc_action *actions[], + struct netlink_ext_ack *extack) { int i, j, index, err = 0; struct tc_action *act; @@ -3551,7 +3554,7 @@ int tc_setup_action(struct flow_action *flow_action, entry->hw_stats = tc_act_hw_stats(act->hw_stats); entry->hw_index = act->tcfa_index; index = 0; - err = tc_setup_offload_act(act, entry, &index); + err = tc_setup_offload_act(act, entry, &index, extack); if (!err) j += index; else @@ -3570,13 +3573,14 @@ int tc_setup_action(struct flow_action *flow_action, } int tc_setup_offload_action(struct flow_action *flow_action, - const struct tcf_exts *exts) + const struct tcf_exts *exts, + struct netlink_ext_ack *extack) { #ifdef CONFIG_NET_CLS_ACT if (!exts) return 0; - return tc_setup_action(flow_action, exts->actions); + return tc_setup_action(flow_action, exts->actions, extack); #else return 0; #endif diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index 70e95ce28ffd..acf827b0e30a 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -464,7 +464,8 @@ static int fl_hw_replace_filter(struct tcf_proto *tp, cls_flower.rule->match.key = &f->mkey; cls_flower.classid = f->res.classid; - err = tc_setup_offload_action(&cls_flower.rule->action, &f->exts); + err = tc_setup_offload_action(&cls_flower.rule->action, &f->exts, + cls_flower.common.extack); if (err) { kfree(cls_flower.rule); NL_SET_ERR_MSG_MOD(cls_flower.common.extack, @@ -2353,7 +2354,8 @@ static int fl_reoffload(struct tcf_proto *tp, bool add, flow_setup_cb_t *cb, cls_flower.rule->match.mask = &f->mask->key; cls_flower.rule->match.key = &f->mkey; - err = tc_setup_offload_action(&cls_flower.rule->action, &f->exts); + err = tc_setup_offload_action(&cls_flower.rule->action, &f->exts, + cls_flower.common.extack); if (err) { kfree(cls_flower.rule); NL_SET_ERR_MSG_MOD(cls_flower.common.extack, diff --git a/net/sched/cls_matchall.c b/net/sched/cls_matchall.c index 37283b306924..7553443e1ae7 100644 --- a/net/sched/cls_matchall.c +++ b/net/sched/cls_matchall.c @@ -97,7 +97,8 @@ static int mall_replace_hw_filter(struct tcf_proto *tp, cls_mall.command = TC_CLSMATCHALL_REPLACE; cls_mall.cookie = cookie; - err = tc_setup_offload_action(&cls_mall.rule->action, &head->exts); + err = tc_setup_offload_action(&cls_mall.rule->action, &head->exts, + cls_mall.common.extack); if (err) { kfree(cls_mall.rule); mall_destroy_hw_filter(tp, head, cookie, NULL); @@ -300,7 +301,8 @@ static int mall_reoffload(struct tcf_proto *tp, bool add, flow_setup_cb_t *cb, TC_CLSMATCHALL_REPLACE : TC_CLSMATCHALL_DESTROY; cls_mall.cookie = (unsigned long)head; - err = tc_setup_offload_action(&cls_mall.rule->action, &head->exts); + err = tc_setup_offload_action(&cls_mall.rule->action, &head->exts, + cls_mall.common.extack); if (err) { kfree(cls_mall.rule); NL_SET_ERR_MSG_MOD(cls_mall.common.extack, From patchwork Thu Apr 7 07:35:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 12804574 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2BA0C433F5 for ; Thu, 7 Apr 2022 07:38:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241935AbiDGHkN (ORCPT ); Thu, 7 Apr 2022 03:40:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34070 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241955AbiDGHkG (ORCPT ); Thu, 7 Apr 2022 03:40:06 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2069.outbound.protection.outlook.com [40.107.223.69]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1598960AA2 for ; Thu, 7 Apr 2022 00:38:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Aq+Hz3KPbJnlDfD046Z12TwHWJAyWCF9hbhb1eSbruB1aEwsIs5c8mRQK20pONRnAb4sY+qUm2EoPnes7CQBPxRz7CmBq7PYaiaibA8RJu/XOUiNKT6ivzIAepB8WitmRAU97L95M6WddxAbJiMvyfg14c9IKeUGPf53VmVpS5z69Owba85l1/t8p7NIk8ylPXCsO/IgSweovB8285sR6LnY93ZJZEKgROEht/CYF07aqi91/Kis0a0FAlHV8A/AMb9gX0J2IbKGnAABj7hTBmXlGEqewbXRlN+ZibUbFfICoL84AZX4fjA7VU2VOpB5N+NlUIK+e4vuwkY28SO4TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4nAZG333hjG0276Ol3cCgvy1+Bj8+2QtMaM1S5Zt6YA=; b=dyAKr0hG+RRKrayFolgiZyJZ6x7upWJSh3NUZsZhdA9dZGLH9GgTIWkXRiU/6HjSUIr71hoV3Xc4nfVODAWiBjJK1Pqpk+ZzSkHV0jvFsyVCtYqyLXQZGjGhUv3tMhb5cX2c9L0bZPvhL1DfMbRhgDGoKP5SBASE/LaAkMMUJONkIyH8S2y9yjJavw/HlRBPvCXgrv9G85OVOWHh3MEOF1k+69AjL85wnwHvQBvPOKAA66NIz1PBA3Yi6YsY/HWSguoWlwVpssFjbqRad3mAEax9U1OD5y1oFL2h/UyejbfmYno69sUWhF9eBe98WCMcST3FNCAWxnyVhEjI69gjLA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4nAZG333hjG0276Ol3cCgvy1+Bj8+2QtMaM1S5Zt6YA=; b=l8C6KXbU2txfEu5EbDbUmuYp7QFi45x2pYnzV/ATrq5m3mnG9JY/Q5SrI8f+uLy7JZH1KyJfhPFEfAhZ2h1G2msSmrXig1rG7H3c4XiuUmnBSptSHsIfLgVQXxut3c6arvZrDYgZ0LCK3JwXOJptcyqcK0wqBTACdgbKiQ6rpK9vE9191FxXOBz5fgIVnsiGRmM3CZMQywnzBnI3gqzEtK1pSobn++NlqmnV56YwJbTmAF6d4yLSRixneYZMJbBPoqYl6G86YJeo5ogaOOQyBLXuD9/j1B1LNfV2Y5R9klU9ounaxBrMqiozdAPpW7XkGvO6nQ9u3zxuNOjaEFePxQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) by DM5PR1201MB0188.namprd12.prod.outlook.com (2603:10b6:4:56::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr 2022 07:38:03 +0000 Received: from DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2]) by DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2%2]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022 07:38:03 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, petrm@nvidia.com, jianbol@nvidia.com, roid@nvidia.com, vladbu@nvidia.com, olteanv@gmail.com, simon.horman@corigine.com, baowen.zheng@corigine.com, marcelo.leitner@gmail.com, Ido Schimmel Subject: [PATCH net-next 04/14] net/sched: act_gact: Add extack messages for offload failure Date: Thu, 7 Apr 2022 10:35:23 +0300 Message-Id: <20220407073533.2422896-5-idosch@nvidia.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220407073533.2422896-1-idosch@nvidia.com> References: <20220407073533.2422896-1-idosch@nvidia.com> X-ClientProxiedBy: VI1PR06CA0200.eurprd06.prod.outlook.com (2603:10a6:802:2c::21) To DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8079f5de-f391-4fb7-241c-08da18698c8d X-MS-TrafficTypeDiagnostic: DM5PR1201MB0188:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MRmjfTcBaS+uqNYCB85uxy1CCm9a/Ac3jhBtFaqE2B+yLVTn2kshlaThKf+fODwD4G/Nz3OIQ53EnslrsNUSfPb8WzQuKU3xC2wZzeVmzVqkEy2PmExWLnt5Wvco+IUaGQQeThH06NsPRra2xyWemYIfUjDGhbFNityC3KFLJVrklTwNQxtLQyiUh3+xWtPgq3NPwpFK1ouf2fRigO0byA0WVOQJKYrHz/wAyAw5KglQYS+lyyUzlm+9xBLGGRQHG4dk3M4PKrnbW05KVaY952ZB6y+Av9y/scy3VdzcGTDLFiCsA9kPg15eaEkWB37qm5jkhspbe1ykO0ssFFW2dUepO9g5bcL2cmJy/r6USv6ig1fNhLMEDg2JTr21TVptgcRLnrRgm9ZJzc01LhmazKUBm52MqPlPO+S8DIgqO+qGEepKLt5Sd8uXwY23aoo+BJpIgE2dVyEDj7hrcgDeicbjdiyTMajZsHc+StrAP1z63G5vcUOBKc055fPFyGi9n/l+k8sDbmeAiAx3XjmdqRDPTon+K6dpDkz+gwAYj7a9X/xExl9ylvkWiZ5h9Mu7WLn1Qwdv7BT+J/3/c5jGpq6RA5MJmRVH1kluEV6jezy9oP0Z7bAM2caeDJb2jbAH3OsWVJ5nciZopwQD+yLfRg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4337.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(107886003)(6666004)(38100700002)(186003)(15650500001)(26005)(2906002)(6512007)(83380400001)(6506007)(1076003)(36756003)(316002)(6916009)(508600001)(6486002)(4326008)(66946007)(7416002)(66476007)(86362001)(8936002)(8676002)(2616005)(5660300002)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 1J3yIKK53ma33bnp/8gvV5jXsgcP6BsllCn/tXVAcU3ajdW6lMhTVTI1DhoaKYfAc9jqKX1strDbSPazLIelGKDYhjWRpiCNKpIu7v8tmcgfVNs15A8JemxFuYF2JhS4aOCkdc8WGMSPnv5iW0MeSVjD/0PNdoMqWUNu5l8SXY3opojOkZ/om8kToqb/FrC1M1Kz4BqpkEU9cs5YG1zkIuumSAh5tqOzibOhQz4n9FVc7rKaDnkWZylsYjFVewcUnWv9J49wacwAYRv14hAATF1Ueb/lGavY/s9VVWB0xkgTh/xv4PlzfNAuq78GQMw4guRHY+I3+odmnKkx/hL0Y4eEeEkbIYiOWEzRhsoCIjVBpz+J3uof80Tmws5lrwG8VgBj5Bn864zrLE1lKsVYNMMsv6v0DVMpU83UHFUM6480zjnQesbeQdXKJy/TYFVcFQhSrhPg7aVGzB98QyKFCsqf3wxgt1QPCjDKsOUYj7ErGyJwPfThx02VP5SgIEvrTPh4SV50Nx5EMAq3T3jSh0s3929gTMi6if6X/a42Xh3ER6c2T3q5O9JKaErvsRbbXlr3ErC/Gfa4JFB10mcjzmKxEMY5sqvU3JCmA1qaddYq+w0pF1K/ZnHD45xAvTZJ5anpqqu/Ridvsk6V6ZlqICAAkE/IGO9GGlsXjxesz401hfW1jO4T2XCw7On2Gmhl/71u/jizHComDwsm/c4oQ56HdGw2BJK0qA3t5MBy/GYA2XBHyULveDyFmc16g33V7FNMsGQGjSDhUHqZugS4TBFPLjn22cTILBx/4taue0XeaXt9gQK8hDZk4pCUNZyrq+b6NIqmpuWezilk/LEsT3QvH2H25cPWxs0ft2tvFTGPde67jH7MZzJMfli5DxOFxjc0vfalZgymTWXehYHxmCDFXjXrsgbBC0evPTeJpDPreGcSVmXFVHU70mWgGq2RgDXIclmpU1H6h8aLPf+03iPoCsdAXKiRDbYjsgZsIX8gPoJgESNgcAE77avgtQUamEwd6NHk0moxQMMOLldljKLiXnX3qb7TisZ52PeNqhbLVvRM7y4wul1CzdTz3n7HLNt7FirDF2kj5pO3k6QxJ4bggx97ALu6Xna0LwnKQqzQT3hUUK4qr4YwxqYsBoSRHPKDntSKWIQ4a51Z83fnF6rqdb+WKWBZHj82hG9gdQX36cy/I7//9IvDzhb24lpGmWk7HLmKTErqdSn0jyOx/WbiUDKTCx6I/0I4V9QaTsWiP9pT4Tj5AlQTgoM2wFKN+sAlFYaneOkXMcF3RF5Euh+pUwlYD0eQb7kX8XWIyPD94q6OZyKg+cGa3OyNdncBvEJqE3Lukgucns88t2Q9sIfHeILbIKWvdLZqqnFXgTTkzCceK5chVpuaHY4fdxWGu43N+6dGCKatv+4Rm6J3cWj4nxQvlRi+FBH6Fry2084969ToyLdwKvvuzkaky99ZoaMOzK9/ApWI+4/cacVc6ahpCgZ3qZQ6U/vFK2Mhz8bxfa9KCAqC376YFM0FhPGjsa+fPoN7XRo2IywZOBtwv7IZh5Mtef3Z2atSrQhSPCkHd9Lw7LGtYC9AjOOXsVevUb+1++0LKr+WIMfx0P8jMH8LCYgURPbZv8TOeVU16nfagIojwpznsLI8+VUcIogQaT0KucdlYe60sgXloUufVYn8XYNbfKmo0yeleppH/VGSBI0aqTL/fV62frDHSU1F9hfdWWKK6vTJn4Yjf5T+1g== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8079f5de-f391-4fb7-241c-08da18698c8d X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4337.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:38:03.5976 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qFHlrcDxJntzWrupLMDiyIcVrutfmMI++SggldCROqZwPcpoJIcY2eIb/VQ8lAmGQ1TiHVqFqi9vtYCGUDoG8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0188 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org For better error reporting to user space, add extack messages when gact action offload fails. Example: # echo 1 > /sys/kernel/tracing/events/netlink/netlink_extack/enable # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action continue Error: cls_matchall: Failed to setup flow action. We have an error talking to the kernel # cat /sys/kernel/tracing/trace_pipe tc-181 [002] b..1. 105.493450: netlink_extack: msg=act_gact: Offload of "continue" action is not supported tc-181 [002] ..... 105.493466: netlink_extack: msg=cls_matchall: Failed to setup flow action # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action reclassify Error: cls_matchall: Failed to setup flow action. We have an error talking to the kernel # cat /sys/kernel/tracing/trace_pipe tc-183 [002] b..1. 124.126477: netlink_extack: msg=act_gact: Offload of "reclassify" action is not supported tc-183 [002] ..... 124.126489: netlink_extack: msg=cls_matchall: Failed to setup flow action # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action pipe action drop Error: cls_matchall: Failed to setup flow action. We have an error talking to the kernel # cat /sys/kernel/tracing/trace_pipe tc-185 [002] b..1. 137.097791: netlink_extack: msg=act_gact: Offload of "pipe" action is not supported tc-185 [002] ..... 137.097804: netlink_extack: msg=cls_matchall: Failed to setup flow action Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata --- include/net/tc_act/tc_gact.h | 15 +++++++++++++++ net/sched/act_gact.c | 10 ++++++++++ 2 files changed, 25 insertions(+) diff --git a/include/net/tc_act/tc_gact.h b/include/net/tc_act/tc_gact.h index eb8f01c819e6..832efd40e023 100644 --- a/include/net/tc_act/tc_gact.h +++ b/include/net/tc_act/tc_gact.h @@ -59,4 +59,19 @@ static inline u32 tcf_gact_goto_chain_index(const struct tc_action *a) return READ_ONCE(a->tcfa_action) & TC_ACT_EXT_VAL_MASK; } +static inline bool is_tcf_gact_continue(const struct tc_action *a) +{ + return __is_tcf_gact_act(a, TC_ACT_UNSPEC, false); +} + +static inline bool is_tcf_gact_reclassify(const struct tc_action *a) +{ + return __is_tcf_gact_act(a, TC_ACT_RECLASSIFY, false); +} + +static inline bool is_tcf_gact_pipe(const struct tc_action *a) +{ + return __is_tcf_gact_act(a, TC_ACT_PIPE, false); +} + #endif /* __NET_TC_GACT_H */ diff --git a/net/sched/act_gact.c b/net/sched/act_gact.c index db84a0473cc1..ac29d1065232 100644 --- a/net/sched/act_gact.c +++ b/net/sched/act_gact.c @@ -268,7 +268,17 @@ static int tcf_gact_offload_act_setup(struct tc_action *act, void *entry_data, } else if (is_tcf_gact_goto_chain(act)) { entry->id = FLOW_ACTION_GOTO; entry->chain_index = tcf_gact_goto_chain_index(act); + } else if (is_tcf_gact_continue(act)) { + NL_SET_ERR_MSG_MOD(extack, "Offload of \"continue\" action is not supported"); + return -EOPNOTSUPP; + } else if (is_tcf_gact_reclassify(act)) { + NL_SET_ERR_MSG_MOD(extack, "Offload of \"reclassify\" action is not supported"); + return -EOPNOTSUPP; + } else if (is_tcf_gact_pipe(act)) { + NL_SET_ERR_MSG_MOD(extack, "Offload of \"pipe\" action is not supported"); + return -EOPNOTSUPP; } else { + NL_SET_ERR_MSG_MOD(extack, "Unsupported generic action offload"); return -EOPNOTSUPP; } *index_inc = 1; From patchwork Thu Apr 7 07:35:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 12804575 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 193F7C433F5 for ; Thu, 7 Apr 2022 07:38:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241965AbiDGHkS (ORCPT ); Thu, 7 Apr 2022 03:40:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241989AbiDGHkM (ORCPT ); Thu, 7 Apr 2022 03:40:12 -0400 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2042.outbound.protection.outlook.com [40.107.223.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8B2852E3B for ; Thu, 7 Apr 2022 00:38:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AjI+oC66Tb4UxI6PgBKgdcE9EJyFLCpk8y3e3RSvAl9ANR2P7V63zBDLg3LYj6cw0QJp7lW9wmSjce/Uo/wORedameqInu7KeSYjNGM5OoMCMUDKFxmbW1pnnjNhAtqn0p51tu0sBH32nXcN2v5mcpZ7DVKRqBe20P1RCDmFBHemJ30gQmDP43AvfwmH1crS2FvUNZuvYVL+Wb568PJqYZMz+3BPEoh+FJ69zUfiL0pZz43RZJypRowzFEiEF/v2yvEbmKEWQCIxeGvPH7/8e1sR+DUJslK10aVdeSCyTFRWAum7fNR5vLi8n8PkhfNmwoLloR8EVCo8mHV84K1lGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hG60WfkarWnznb1OqkjIt2IGZ9fOdVDQsGNeN3ThKNY=; b=ilZBOt+Wm0AYG6DJoAfMShmP3Rquv4zzgVyieHHkC+e8Lve9hxp1X310f6OPUmQWOtlwgk09gro7fGE8WXwI7Mzk2GxQgLHr19bG6OIzMn2szbLxpE3Q10kTQWPWSpU/clOpHbKMKhE6WGJ3GOOnErer2j99F/Qb8MiZirwCF/IWdyLksQ7YCLfTvj3WI3TQaqugNe6+6bVA+Ixi0P/8lK12D48NadI3XarmEZ+hDxyHd5qW316ONfNS7FbwQyiHWwLUjhsT6jnlQQ6ay+qPXUz8s8squdwpo6etcoEtYirSeouX5/T0i4kgIkh05h+4JmZO+KtUB43nlxKpdyII+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hG60WfkarWnznb1OqkjIt2IGZ9fOdVDQsGNeN3ThKNY=; b=MkCARtzwPpgHlterQaEiF4RFv6sWvrU1R1rYkFbHoYBieAQkkjEau4hTXRYhxdDvkSQVMNsIagl9YopTxRXdGrHrFUspqNIl/ViDmg0v8/DhK7ibsBkfmd1IgiwkQcuIjXd3mTYHEWRbjW6L4eAbdFOfoRr2lNBT5T4+lOVU6DUFHGquxWQWgOK3dn6jusZ1HpS5G6lRsmZEJyXrIYv+KJ9Jp0wifAS8AYEakblis76Iaz0Gjxbm+El17SNiZ9eDhcv9mxIErjnvjgN61XYudarg22hhIdavyDz035DoZIXIahwQwC8XCWOh/ISCF6Bw6hJhSFcuLrDr36zw20u/Zw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) by DM5PR1201MB0188.namprd12.prod.outlook.com (2603:10b6:4:56::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr 2022 07:38:09 +0000 Received: from DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2]) by DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2%2]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022 07:38:09 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, petrm@nvidia.com, jianbol@nvidia.com, roid@nvidia.com, vladbu@nvidia.com, olteanv@gmail.com, simon.horman@corigine.com, baowen.zheng@corigine.com, marcelo.leitner@gmail.com, Ido Schimmel Subject: [PATCH net-next 05/14] net/sched: act_mirred: Add extack message for offload failure Date: Thu, 7 Apr 2022 10:35:24 +0300 Message-Id: <20220407073533.2422896-6-idosch@nvidia.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220407073533.2422896-1-idosch@nvidia.com> References: <20220407073533.2422896-1-idosch@nvidia.com> X-ClientProxiedBy: VI1PR08CA0211.eurprd08.prod.outlook.com (2603:10a6:802:15::20) To DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f504c5c4-746e-4df0-7e6c-08da18698fdf X-MS-TrafficTypeDiagnostic: DM5PR1201MB0188:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Nk5IAKfZQ8eTugyitm9/TVvFJ15mgdg4i3vxOgVLxQzAB+RSf/tnlppkegiZ90T38sWoEmqQ8QIkHA+xpnt5mad4hkt/LyepUZ9aQpHpu11dBEq/rwPlwz6waMc6EUWitPcR/oYxDH+idiHzxxD+d96fIeikvAVoW6CxvyocH3XGj9S8h/nB5f4PMoulmHhtC9CkcjEdB9L9WVuxlkYyGmEOw/DrrQ8EaylHwKllvggzT9GkncqKyx7db2T8WXeaZaqSbm3ErNIBYhublc0umCUxL4MKPFavWQyoL8/JOSzdoKG274mt6O4/MVTG5WR3WGDXWIVvMcA97x0WyDj8ku+uaa/QBNT6gHQywCa9PCfO13OlwWQtklDZVauioooMuygY9C5Bizn1tY2O3J2e3HMJiLjXkPGCSGBj2QlcRaT693LLOE3gjzhWAcYXrka6JtRNEaZHKeJ4E7TyFErgAkLOFHYDFCUXvxEA01SRMtRcXQvQk4EfG8DoffL+MnLLD8UWPN/S2yDtDGdcyR4b7JdMOAsItIjNQ1pXoT8xbF0/oku7si522hf8NTwaylmJ5EpGDit4QIMLLqAMVIwtaLtBwNhdwUrup653XnEJWBkkonXP5kgnk6rApwrOQG7xNGDqvMMfoNlHClW++YPngg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4337.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(107886003)(6666004)(38100700002)(186003)(15650500001)(26005)(2906002)(6512007)(83380400001)(6506007)(1076003)(4744005)(36756003)(316002)(6916009)(508600001)(6486002)(4326008)(66946007)(7416002)(66476007)(86362001)(8936002)(8676002)(2616005)(5660300002)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 26928baLDmeJ5OEJ0FzPgpe1b9tGpWFExiA7hZahh0yiFndv794MEptVNLpeUoJUhiNQggaOovK9XrD1oFC+bsFb0EerUpyJMPkEHPD1I2mFZlErewvoAgXmsb8LG7JqKhFTc6wxOYHAU14Dav166V+POq51THFAPvlrPgmA4nz+tnAiQt6XnaWqiH8yOGxKfFRPGupAjUbz59/4hTQwUZ9yRtoO3TH2P8Ac0fFuOOlGXKynJ+PTNrxCbM6k6wlOHXr7D4rl9bwjxd4jSYcAOft/S6g9hozQE3wXsbDhKQnV/5mETdSEZHDM2+R1+KNFMykq0c77sCIMa05QK/PfA1sTJxO3KMarKPBbtc9Zqj4uriKTNhY9mXlo6z86J1klfh+31vvYg8jWggK8diH1MWXfAgiHNxTP77w7931pkQuGpI4ILbkbJXOCKKFz9NCtCxzxKaeoD3EgF6cVsjHU4Q+crEqbxsJ131ueDvD9PLi9DbVXqPiuGFxE+H6ZxKSfxQ1RzKJ1LhzdR63cg3eWT30swoO8y2c1Edh/6WD35M2+GIw2gqJAtmQhdrz9kmLtNvuBWHIfuqLYY+OJzT0Apf+tw/mP3nz7O4q5oIQavxacvPqi98wD9VcKs6yWGFxcX7nvavXQN59+4kd1XZfGPnLfd1yui+GVpFTPSCkyOrIU2jNf6UpeTB6x3kHftpnkIPrS69Ut7HVquHlHOC7pmFsKqnpyB9t3yzA84n1gAT51ly+lzEWIDk9cfHEO82saHUgYJN0vCaXlZ8pkvp/rEQcn2PihKrY4UxEjFrnGv2jdt+j6p3Dr8z+hj85NbSB9eYHGigfB6YGokhDoHv8lgUJLItiXfv5dPmvZgkwAD/BUqf9/ojSoMTJllMzRc8BBgz+uhpU62/eX4b1+6iU63w4U3BsUKwMr0SmQ1jrq3RiJlLeEqhb9bGykWSaHZ7hRiPDiNLJvA2hZeVJtGJm51q+oH2rUcLDmYZUvA1AeeXCznO6yOc5D3kg0s4jk3VKlbLfwHpU99UYit6MrUayzP9rdzj/JpZxPIlwrhEAl/LuXmOwq4HTUGmfnMUUScHtx1+obkPYfhOOrLFeRNWrMzgrnDsL87+c8659ahjzir3B9bC7FbEUvEQhOIK9Ige/H/ozrveRzQmq1BRoJOBTyeTITGBJQZRLSpVKKcHVPCKt5pVBy/31bVXTgOPy80OShe/Wz4Q8C53zRwOEJf8F9v+c4/r4A3L90RAwm8jfAGiC1+1s58hNKYB+QL+O3jm+eTyHYg7rYY8TbXl+wNf1GytCUvxdeeFCT9ikmbzQ9QpB/T5cA7aHPYpvIW/MA+h5Fy4DdE29k7XX1MT1Mofkzlbhuv/m5bEVRmfUvG6HCfvFd3skoLZF9sn9ZUGbhcgDPqVxPYUBltShrbYzYNcIeXvx/DQUbX9OyZAbMfiR4rxK+kdx+rLA4klVmO/4t3jLX0v/bkXik47NbiOPTkAiiA4WXj8KdO8GlMyXzMXqracuY/G9D1DlPAK7OHLHjqooAaTZU1NEtzwooXVF/PY5rmAgdg7Wb5wDTScuFwkYEkWb+tnEaJdV6bVKm3AEUAoYaPZsfCAU4hE7tHgeOEaSAFprTseV8xmeh8Yg15S1/cVJPwKn4JMsCTHwsZJIlghoIDGPu8WXn2EtQW9xn6DSvaZQp+qg3D6IYtQF9MpdhVo3FghaRI4Oxy5/TN579GWeNHPG6hhqamWRzNP+MOeUvjA== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f504c5c4-746e-4df0-7e6c-08da18698fdf X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4337.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:38:09.1548 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /+/hlN989Gi+fxw2Z3FaH9MgdBTzJlHsWlKuDqAnHY0Ab5rt7uRm6UpMbjQb/vmDxQmgMdBUXjo6N/dia4KSJQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0188 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org For better error reporting to user space, add an extack message when mirred action offload fails. Currently, the failure cannot be triggered, but add a message in case the action is extended in the future to support more than ingress/egress mirror/redirect. Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata --- net/sched/act_mirred.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/act_mirred.c b/net/sched/act_mirred.c index 70a6a4447e6b..ebb92fb072ab 100644 --- a/net/sched/act_mirred.c +++ b/net/sched/act_mirred.c @@ -479,6 +479,7 @@ static int tcf_mirred_offload_act_setup(struct tc_action *act, void *entry_data, entry->id = FLOW_ACTION_MIRRED_INGRESS; tcf_offload_mirred_get_dev(entry, act); } else { + NL_SET_ERR_MSG_MOD(extack, "Unsupported mirred offload"); return -EOPNOTSUPP; } *index_inc = 1; From patchwork Thu Apr 7 07:35:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 12804576 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDEF7C433EF for ; Thu, 7 Apr 2022 07:38:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241953AbiDGHkf (ORCPT ); Thu, 7 Apr 2022 03:40:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241960AbiDGHkS (ORCPT ); Thu, 7 Apr 2022 03:40:18 -0400 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2078.outbound.protection.outlook.com [40.107.92.78]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC070140F6 for ; Thu, 7 Apr 2022 00:38:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XHvd419x+hbs9d1IRMCdRVdoDnWMIgFrO3KBrILr8tZM+f7kmM3bGzU29sgRZFpV6uX8/nbQEaP5rSEiAD/cqVh3crfcVd7U+ry07rt53GyTq+o5fbAzFmDVSDYFy+mkwrihwGCdmqHPt4gQ6vhNwhdi+ruUAwpS4GAqU9pxTpoG6VoWCIOBWNggRpAhFq9bXsziOOCVykEpTZgS9gvwOwfVdL01SOoBXOS/3b8Cj62lmPoX4LgTyLx1PcvElgdKt+YGSwKyNFlB16VctkJtdJTL5F+tiU1El3kyG+BOr57XFmIRnILZI8c4KoMs+qFBnbHozL2xd+vXKIGv2lTb1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=STaKNCJq3jTEeXRYlujUmrDLynBhQdFUSz5edI90P68=; b=YBoQverBCZHi73qaU/fbdAokYEvnIv0fbq2mjzNIdYQ6VkZbGsFyhtZoxcU8VLtrcNy29eoq/YiTIzW99jBUipTLl9h1uYYUYigR3D0KpXLiDmezeQjjb15Sgo5kzw/Pn51BQbMvPw1gENqS04jjgF9x73g2t5BCfaBW9dUPFVDu8QFpXXNyiOf5HfsFzCHNo4YyM//CLOQqDaY7W0Fnaoui1dYxXVc3Dfg+uER9F5GA4pt1WKjcdBt95mn4IUAkbuqFR6WPckmoa4T9216ECl0gBw8dC6YWp8Mra4cuMs+/MGktHqL1kl5FiElfZcUYbFYlyK6pAony7Kxtyu48hg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=STaKNCJq3jTEeXRYlujUmrDLynBhQdFUSz5edI90P68=; b=lT71C4S7NeIKm2lUro/+QcDNMc7ik5Mv4aHPSH4995csnour+EmAPNlUD7P9+z2fw5S+Ykl3FTFsfct6apkdvUK51/HxCv6y0tVlYYYrBAQodTgd6Yc+/TXRVGTIcjCDXRz5PSurMGgqu9q8pFbjOkBzQbQsbMvEcWrgOgHM/lWsz5fEVa4/tY5J8UijAYCJ+CQU55pP/Gx03CzThHJTIgXMDxquIvCbL9GC4V0eLsUP8+oX971yEQykLlx0fp5lAJVZ8HHXB21LdG3jDU8Dg3SMKSoTa2/Bqia2MJkt3JTtnXyBpCsz/BpTKIWYivMPhzqAw/CYFboSh5KKlArGZQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) by DM5PR1201MB0188.namprd12.prod.outlook.com (2603:10b6:4:56::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr 2022 07:38:15 +0000 Received: from DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2]) by DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2%2]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022 07:38:15 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, petrm@nvidia.com, jianbol@nvidia.com, roid@nvidia.com, vladbu@nvidia.com, olteanv@gmail.com, simon.horman@corigine.com, baowen.zheng@corigine.com, marcelo.leitner@gmail.com, Ido Schimmel Subject: [PATCH net-next 06/14] net/sched: act_mpls: Add extack messages for offload failure Date: Thu, 7 Apr 2022 10:35:25 +0300 Message-Id: <20220407073533.2422896-7-idosch@nvidia.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220407073533.2422896-1-idosch@nvidia.com> References: <20220407073533.2422896-1-idosch@nvidia.com> X-ClientProxiedBy: VE1PR03CA0018.eurprd03.prod.outlook.com (2603:10a6:802:a0::30) To DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 44cd679f-b1b0-4d5b-47ed-08da18699354 X-MS-TrafficTypeDiagnostic: DM5PR1201MB0188:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PZSlkIc83GV13fxe/lHfhwiPmy9Ew+fFW+wK1HnGF0h3bRc4xnWV5q07OhIhNuX9mI1/9WeNjHAvPmCT5xy/ooakr6aTXjhfqI99Rid2Yg2HJR9SeVjgguOPidlD2hTGEGgixy7U8lcyODdfgD2bPazV8AuReQmA0wo7CtvWGL/Iz8YWqLWFBr5emso1VEioPbN5ZXcze1HZCcSIgRd4Zr1//RLV/bYLOTBekiU48w8DKyQiCUwSQ/OC+V0HNzzoGpdT51eMmpI3DMc1FSoH7cpHJDi3d1Ze9ix9K9mkHBlZZ5Fdn215WhEqg3Q6PLj12DTwNliObH5shn8NEkqUymgnpcaQCFH7Enzx1cDQTaLR/68MR/m4cIMXqbVQZwzA5sbLMxBw799M22fsOokgAXpGBJGyK870KiU3T3ewiwaXAiA8J03ZZWloflTvj9C2AXzPxDW9zgt6QAc+H1IX2BnorCI+FS/iuzN31ika6+0I18pBWXukFQSDqRIRf57olFD9KoSfAkqzAju5otmwDbePlMspamMUEUHkXJRdmRvsIrRiP/x6yQS2nq/7zbGqx9ilxgNO9VhGRp9rjkFbCAhpvUCZsoIgh2m82I7MErDxrY4VTtZM/Og01ceJXken3hHwmMtRAsyDSvnUbBf71A== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4337.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(107886003)(6666004)(38100700002)(186003)(15650500001)(26005)(2906002)(6512007)(83380400001)(6506007)(1076003)(36756003)(316002)(6916009)(508600001)(6486002)(4326008)(66946007)(7416002)(66476007)(86362001)(8936002)(8676002)(2616005)(5660300002)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: /HenJFHZ/yo0lUcia+u3OBtmsNGdEtKfd+ImlEKflkhfL6nMOXmkzgheOnBHHIDFsuz8F4dGfP4Tvz5KY4bWybR+rDbF0EUw95PwuI4tKGcwD6RK+2IAHdAyNhGJyuhxo4S7ZptzUHSdkG/O1LPoWlUB4S2dCNnw7ugSM1HCBti39ZcO/aUHntJ0Lmv9nKo3uJicZvfc7MvddjJk3B/HS8QimAogU8+YK8b6O0Yurb1+d7/bQRcm/qFjqc2d0EbEMOLn+hh1Ocz+etgDclhEG5kIcXK2SZgcYKGgRXUQos3XgFvsfSU95BfHLNRpLalY3kle5W0DeoFe/6Y1f+nnuqbHBnEQt+Ez3LHVG5aYXAQCMFH51xSuWr3W5tYt1y65FTU9acFgfLu1rVapyf0L/D9PYihiFzFvVHbqH/TeQ1PrF9Zo1JBpLN7CmROLp4Bsiz/XHiy5/iaZnEZSk6W48aN8D6DqEChB0plpMKEW68/VTloAAwYhwtfSP1me5N31Zl4tlX/msxYtG6By9KWGgm1/865oJO6d1ZcCQ6YE6gU/l+OvPDKuptBu7ROVlCuCeGhSULedYJq8R3Qk996dsWcFTAsMCbn8xqugRLhxtKpQonJ2SQUeX6VeO9MPtPUBL/tBmwtcQf3nBhcbIH2cJPycOnOshMNbv9kWkbB+9KB2iB9cwst8/lcnHUwkq2Tpml9If8y3P/mSpiaaFwAaykA4Z7bs3vqcv7NnOer+xRJ6UZDmer/dLLYWeeKWrWpoQOGanEFEVkB5dz1O525tIF5uQKz6DS38zuy8SxRsO5EbDkV5AhCzJpSW6z3koGKPQbLTEIXadtMP2X9OAnKH5ZZl+S1Tmxnm85bOS8XBbmfXGQcR154v2oRN94jB3yommP1KH8cpy46e0x47IeoSiRLEHN+SLmiHrM1TQasPcSHHwWAYgrnvn71U4QvgUdv/YtR4/ifV5uxFCketLpw717fjFUAYFigPWOave/zNXwU5DTUxL3BxFMUxkqCw/vED+GZ3vEAEm+KRLsX2Hg2iHvxHRnSy5JEwrK3WkmDw8Rr4ARdpfMI9abISOaPL5OaTuhM6FnG0tlgZqCPAYSn0pmrJ+ZdXFe0CzdWEWSVp8d+0FU13IaUKuq7ua31JX3PNBFqBWsugfyQIVLeKZNrQC+cwpqbqxms9B1rmKvTaY8Z6/BsZQFU0lm5vngcpNu+DlDkUzpLfIdDoStk1MHhqcYOaWCVs338fEI7bcbyDxaIM75+qWlcy2fSDaE2kzsNgU7WsQxb/5tmq8YDNMEYBJ0h6+oWjel6SZO4Rz9MB4tJ/Pc0iNJ+h2LsLVDOCvAZiM+yaRCX8n7xqBeVPBHYXuu+pT/BiViivQSRBvseqE/dvpMWhxGfbncBXt69IMU8qXCPwcnWZsgXll0SWVfCG+8B2tk2Bt49KuPvTRR7YsMMvZCU1gvAQGMOX+OsAt5GakN80SFeEhtT8CT5CnOofqI5k7Ou7oqkWWvEzZDewduNxhXyBLwpIVM5f0XYU27G7Wo0A3oC9CWvKMWj3s4OUysO5MwoymsdCsDP+JwST4eVfF0lhbLN/B4o/H5MKKw6R6E5I/mgU/DlaSvLrg4Z8qQlWL2P6qH0N55iWOmxxRID5OmEVfV/Ts35egZBTTNZL8j7A+SanmWFLU8gvnjLCHNkMAw1slRhDqtIpOpM1FMJJ7SYx/KXi9uJaMr4MqcALEx5vYYX5dL1XkiHm3DrTPw== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 44cd679f-b1b0-4d5b-47ed-08da18699354 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4337.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:38:14.9523 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: g2zwra34EPaoOFStL59LyvQTVQ6gn8/z+xikRyYZvyn+5Jh/uxcM2k4qy5NwbjtcGQDJUqCofX9FzyRvIyEuFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0188 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org For better error reporting to user space, add extack messages when mpls action offload fails. Example: # echo 1 > /sys/kernel/tracing/events/netlink/netlink_extack/enable # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action mpls dec_ttl Error: cls_matchall: Failed to setup flow action. We have an error talking to the kernel # cat /sys/kernel/tracing/trace_pipe tc-182 [000] b..1. 18.693915: netlink_extack: msg=act_mpls: Offload not supported when "dec_ttl" option is used tc-182 [000] ..... 18.693921: netlink_extack: msg=cls_matchall: Failed to setup flow action Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata --- net/sched/act_mpls.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/net/sched/act_mpls.c b/net/sched/act_mpls.c index 23fcfa5605df..adabeccb63e1 100644 --- a/net/sched/act_mpls.c +++ b/net/sched/act_mpls.c @@ -411,7 +411,14 @@ static int tcf_mpls_offload_act_setup(struct tc_action *act, void *entry_data, entry->mpls_mangle.bos = tcf_mpls_bos(act); entry->mpls_mangle.ttl = tcf_mpls_ttl(act); break; + case TCA_MPLS_ACT_DEC_TTL: + NL_SET_ERR_MSG_MOD(extack, "Offload not supported when \"dec_ttl\" option is used"); + return -EOPNOTSUPP; + case TCA_MPLS_ACT_MAC_PUSH: + NL_SET_ERR_MSG_MOD(extack, "Offload not supported when \"mac_push\" option is used"); + return -EOPNOTSUPP; default: + NL_SET_ERR_MSG_MOD(extack, "Unsupported MPLS mode offload"); return -EOPNOTSUPP; } *index_inc = 1; From patchwork Thu Apr 7 07:35:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 12804577 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F17C433FE for ; Thu, 7 Apr 2022 07:38:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241973AbiDGHkg (ORCPT ); Thu, 7 Apr 2022 03:40:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241976AbiDGHk2 (ORCPT ); Thu, 7 Apr 2022 03:40:28 -0400 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2088.outbound.protection.outlook.com [40.107.92.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 403BB37ABD for ; Thu, 7 Apr 2022 00:38:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jK0psYbHgGP3u3h+/xjfWXCv6qY4LEohTc2OcZmhnBmce+8CUb9p/OjFIyNTo33vRl/qJJgVPgVjt2tvBlQ8bSpxynK07MHH+sJ0xqrreV/iQWlTmDl0lUmxHq22fXB5s47kQOI737so+eV8uxCciy6b09hz4I07ZkcDci5XJd2LJi0EgrCsjSKx26aEv2efZTwuoCJMEF2nBPhM1sYeJVrMxSvmpH2D6Wz2qLg/Kd17tT3MoZ1eV+TWzW3LACrkmaXN0qND6bWrqjb35u5iOBAyiQ/pcOQoydrtlUsuJapLY6z9WugqwAFz6o9ng9CZwkgEr3g/c0Iz8vnMnxTniQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Lu0R+wJsAbu0+xvNjIjLauta2rmdenitXyOP6L280q0=; b=XdNrQEvrpUKSzRPcl/zI/XMrX10ApAO0RYopjfHcZtGJJiJsNCm4mtip63jy9aEkpXqpdLvWWWVMdCxYXW2Yp8gjwkr4sM72cNLSSAuWSKXMhTDWWzuxxcYnD9szPPeigTr9ogub55tUui2kaC+cFvrHXFNu+2WaKQDNVcgG1YGUHNXQAW/qo7KD9NVYoC9suI2HIuQEG82xuYOSWGAI5STdRZn+AC5OyLEnXQL/0GbuKOB7sILsxqO58tZZ/Ds6fZ+/dRW6oH4/K34Ow8OIAsi6zrN4LmWoxBVGm75bk2IpzXSJEJS4y6PmbkSz6SbhY30ZHaL2Aw3LUOSo1TIYqA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Lu0R+wJsAbu0+xvNjIjLauta2rmdenitXyOP6L280q0=; b=OB/MghxXW9zZz/wmJWliqCZsJRQreGzOh4ICxqamL0EZCfgZ0DdsBKM8m9gTEPtrVhRxnDeWvDFbYmLwxGwrtnY0j0IoC3wiYgJLsgFdJIWMkSLX4X3iZoEeP7t1u6JcaSY0ER9l3GudFgVrWRaiKjJWd00GrtSWarHxJ25qGH4r8zBGZ3bG9NJd+UlWdYdh7X49on5WvUcQW8Z6HBsBzxGNk62BpcG661TVReopdZtJLhXQyxSIsQGSIRoKIaIHHNkDfHBPdW14WCh6oFdrpvWbHNF8zStpw5ACesjK/9FWPYU/NM37wnGa+FbStTiwNMVz1EwGHayk8xdgXprvww== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) by DM5PR1201MB0188.namprd12.prod.outlook.com (2603:10b6:4:56::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr 2022 07:38:21 +0000 Received: from DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2]) by DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2%2]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022 07:38:21 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, petrm@nvidia.com, jianbol@nvidia.com, roid@nvidia.com, vladbu@nvidia.com, olteanv@gmail.com, simon.horman@corigine.com, baowen.zheng@corigine.com, marcelo.leitner@gmail.com, Ido Schimmel Subject: [PATCH net-next 07/14] net/sched: act_pedit: Add extack message for offload failure Date: Thu, 7 Apr 2022 10:35:26 +0300 Message-Id: <20220407073533.2422896-8-idosch@nvidia.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220407073533.2422896-1-idosch@nvidia.com> References: <20220407073533.2422896-1-idosch@nvidia.com> X-ClientProxiedBy: VE1PR03CA0001.eurprd03.prod.outlook.com (2603:10a6:802:a0::13) To DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 086d814f-cc93-4f14-1879-08da186996dc X-MS-TrafficTypeDiagnostic: DM5PR1201MB0188:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YUKdKJh/DtxyMhu7Yulia33LwLmuRBP05ZvBmDdcxO3Fjtj/Co/ccssN+vNLvgG3vv+eMpboqYsTmeOQUZJwrbu/Sg9X73qtRngX/KUPxBexj7RurIgvnmb33qxg4XUcTEiEnI0f3Fs6V4o31SBxykqJcuCAZV8rx0w9M1R2OBE445Rkyns0XAaSU3CuCJdgvwiZFOa1rvAxjDNEIhw3LN1Y3LKFNLO9ecO91ww+FyJ0WrvQHFnzplUYm1RbX+MkdU498EsnXcaXfm/bPfxEuIlNGI2pkLcAQLDkHTiFSpG4Ds8t/0DuViukNb0Exq+b+msMEnYc2Gf7drwHSykkrqhO2zLfTokwbVv070hWW3oP477o86zpZsu1/vyyYV9922klXfr1quS5lcf4l0jqtMUqUtPB34hEycH0E0NO8P5M9LBi77xAX/koDcm35veWaXvstpE8azJJ7LScp07VpGpOqn4hW4hx5f9hS0kRyJa8f6jxl9N7xpx4CHFCMvzaFd3fu0Pbc5apeofrAHBVx5xiB3sbQnga3bZMgeUkmCCbTv39PCFfaNA0JZABP4tQREdCrtAq2IWpS+S0xrKXvOKsSq2KhdY+X509pidKsFYhJWWdSKYmZp1jmTjJxutQXKFTmKMX/DxhuWFgA7zFRg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4337.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(107886003)(38100700002)(186003)(15650500001)(26005)(2906002)(6512007)(83380400001)(6506007)(1076003)(4744005)(36756003)(316002)(6916009)(508600001)(6486002)(4326008)(66946007)(7416002)(66476007)(86362001)(8936002)(8676002)(2616005)(5660300002)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Vw+7OeBfbwhbaewI3Q4y/7mfSmZ2GhWJfQa5wQakZuMNyDOMLthtHJI9UWwAFRCQHGqpvrcnZbyaIxl2/w/YdEP+sP9pNONcMslITnNWbmrVc8N8r88Ph8A7Fce0vTfkq0EtUJGJ93job+2dv31e1D+IJrsPw+JOzIE7UkCR7uLDPZNv1DXm+hsCBqNm2ArLl7H2z1NBphdpBZn9/Rk363ge3Hyp5NEs+/OQp6lZaF+8Ub6EnV82wyi6pVwaM9O2+pXp5cpbC4zekuPx5IIoWVEfmphzhEkDdR5hkahrkO+xvKLntMNCb/VTt1kNH992Weedw5tglfYztHl4knuqjRJVZcjXBx0vm0qU540TyaCsTgxWHnZSY7bTkoVwAJwpDyCh5L86OMggbpg3ydALEauRubRKq3gE1zZwD9moQ+atCjA+rFauyVHQO43Wvu1RGUH3ULFEMQj0tXn9MuY70m4UIZwZe0S0QEuV3JBLXxrpubNUjOJsMMeylStdeoINhztkdFR8RSFm1IanbemVm4nthcMV5u8t26zlXbL0FXUA+9V4MqjMMmTG/bB8PxPSCcoo/aH9uQxRwbHe5ey6OapFfY8FBKZBJULd8CwcNBxKAqgDVhx8k21Pz/GfpLP1qRImZXf+w/wzzhGzLwZyqZpczBvK62AEV3dXo/8aah1BpopwXasiaKritrDTgCNioaBVAg03ifDgMZpQ3lAevsvC77g7tzcymGVtXlwZ1Y2TnXlpC78p9YfoREUJwyHx88CO3kFGainkKaksgZDF3y15yRq2JS/5czob7yctSt5+G6kXxTRc+YOg3KNX0L5YivqY1ZOa7kALd6lAiiqm2GgHsKrea7KWXyjrKy0KjHafQLYmCPOvLMIyNVlPZXgtHgxSVyX80qsN53JECd0LHGlbO5B9jgyakEpCmYOY0yXeJEHZuZYzBDQhjA47kNLQtLQJmVcQFql1e1hBkRjjB7Q3q2+/Ds5CHSIM6oZaC10hCu7rZcT2fttx7ZA2id6Ptdo6um90rtdEJvc/InLlwG7A7Vl72k7NfQoIE5g0LoHJfnOSHr3xSu1DgKR0ZUpmlv8GZbw2+mq5GFADgrXnlTJ2zyNDfPLpIVrjzKoJWxZ3jBgph3Y4aVLIWBy9+DEXTiEt8+4MXJyM/m1FqwIIVxSWe5liq7Rfv3Fea+YZauZ/qgAoKY6EZjxXurUqSmXqIG/nu8Ecqes4qvCAmWTfnDJg1UWVkzldx8uv+rQo7+0kWwUehSC3VbldVtGBiqMMujPPs5TYDjeBOPlNlLCNGfyK2AxMjM0fasgpz+ls9MDHbWUaQ51DffeUrC8F+M+8hJU6l7QCRx5XubekTWQ2g5jTe0XSSVlWn6ienZyOfi49DCfjRzEGzOpxELirLMPYNZ14gJufCfKqFSSWzSeY+fqb1OXuCvcIyh9oxr6XKWc1pwK8KhLJaMm3rm9j32/bbzwoiiEK2nqgjfRD8uy7Ti6S+0w0okwoMK2l7TFQ7lx/bZcn/lmbSjWLRXWXLnXdh9wXZEb3YI8zsofYYL6TrUAHz59GM8+Rx5J+yWu2uepO4lIsEKJssMPadQu1CdIKxdRmrW0tZzT4hXR9+pB4dPnBYOkWHnttHb7fufwIG0YUUk0uijZI1mGAPtoqIKBoi6vEXV3TVngwRRdwGxgk35inRCaf8OpckLDzkHqRgSxkcp2MsC4k+OhfvjPKwZvMT+syFIYb+9h2/WPkFu+6dw== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 086d814f-cc93-4f14-1879-08da186996dc X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4337.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:38:20.8610 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 1aaCIqoVk1SEJy8HzJ095MBGceY7ViOHmRgh3jjIu/XDAHCVKl2ha0ZejzlbUJGibXOeO7xAShUCKvQt5+yNEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0188 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org For better error reporting to user space, add an extack message when pedit action offload fails. Currently, the failure cannot be triggered, but add a message in case the action is extended in the future to support more than set/add commands. Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata --- net/sched/act_pedit.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/act_pedit.c b/net/sched/act_pedit.c index dc12d502c4fe..e01ef7f109f4 100644 --- a/net/sched/act_pedit.c +++ b/net/sched/act_pedit.c @@ -504,6 +504,7 @@ static int tcf_pedit_offload_act_setup(struct tc_action *act, void *entry_data, entry->id = FLOW_ACTION_ADD; break; default: + NL_SET_ERR_MSG_MOD(extack, "Unsupported pedit command offload"); return -EOPNOTSUPP; } entry->mangle.htype = tcf_pedit_htype(act, k); From patchwork Thu Apr 7 07:35:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 12804579 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B01C433EF for ; Thu, 7 Apr 2022 07:38:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241963AbiDGHkj (ORCPT ); Thu, 7 Apr 2022 03:40:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241987AbiDGHka (ORCPT ); Thu, 7 Apr 2022 03:40:30 -0400 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2088.outbound.protection.outlook.com [40.107.92.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C6A062134 for ; Thu, 7 Apr 2022 00:38:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IYNQ4lNdBxsQQj5AzjtfIBE5CH9Zftbc9i/OhD8Vz75Jyzb1hlAKMpBhuKSJK685hw46aeK9vl1G31CiTmh3zg14PRTOJtzh12WktfWKp9QX8Ye3lCiYGgLk/s3nXL5jUn6RER6gYsysz/VO2BF8+yoflQ7M7LS3y1JOh8Z+SSGghrqKQCiTChHqE3YrnBYa6eGFaphWSwW2c27gcPR/UJdcbCdaNw4bi65QcJ8X2s+J5AkDwAY/XfDdDcioHtHiK0rHtwFaY0K5H8GYEIKiuVhUnEdQbq+M6BwfYm5y/Hw9WontI2L245A02zM/diFMiUU9g6hI6tBjppAUAB5yRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cMP3MQ4e4iAC5wVR+3ua/JgP3E2tnc/4QlW8D+0MmG4=; b=PtTVmsSXv6ASHia5gBiUCL/7Q6XOaMnDt1dNPiauyV41LGYyyJpj2iKJD0kwg+fYTT20ZA/tfo4wWu6mp1OM1OptZ7e61dHsNXIp2fYzneB0NUY4d7zsp0ZX0q+OenOJDpm81174O4e9chX/iP5/+f2k2nEZA7mlu5hyrDgY4omnqf/PFqaffswOmJbArf21c8jE0e05rEeKYF5Djku3LNzO0+fyz9rjukQr0wI1HkPUYtXeb/HjG+b+GCD8Qs2/+m9cm5A+TkdMTVGB8hGdves1pBobfmS0/xaX8eCx+hegQeE21af4+7x1kVIEWatRgURMrK6VUUtcl2PI2PLomQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cMP3MQ4e4iAC5wVR+3ua/JgP3E2tnc/4QlW8D+0MmG4=; b=BrT73VOYLaHVcMKN6QOZEbSJOS2p3jB0XiQMlda4ftTTTusggqli/+v9smOvcmAEqGh7rzNQoXyv2ftpOl0g5/EIT+vM+83KKj534k7IFgqnl8pYKuDdpvTKURilwApztCzM2rnD7InVXsbIHqx60v60dDFRvf2KWPPxvNcZpnG0q3GC3uHTBjWKxJlrKInxCsOivGnE8FF+C3iFsMcumJWSHhTNhuOEOGPlYd4zlpdcxvVDOKG6wyq3Ao2Rtgj/q4FCgXwhCw1B+/Q82ddp1T0j2tIjyRWshEJ6u56jt6ATATOAlpzZ1Hv/63SLDbcdqcul2uuPdu68Cr2WbPZ03g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) by DM5PR1201MB0188.namprd12.prod.outlook.com (2603:10b6:4:56::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.31; Thu, 7 Apr 2022 07:38:26 +0000 Received: from DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2]) by DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2%2]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022 07:38:26 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, petrm@nvidia.com, jianbol@nvidia.com, roid@nvidia.com, vladbu@nvidia.com, olteanv@gmail.com, simon.horman@corigine.com, baowen.zheng@corigine.com, marcelo.leitner@gmail.com, Ido Schimmel Subject: [PATCH net-next 08/14] net/sched: act_police: Add extack messages for offload failure Date: Thu, 7 Apr 2022 10:35:27 +0300 Message-Id: <20220407073533.2422896-9-idosch@nvidia.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220407073533.2422896-1-idosch@nvidia.com> References: <20220407073533.2422896-1-idosch@nvidia.com> X-ClientProxiedBy: VI1PR09CA0151.eurprd09.prod.outlook.com (2603:10a6:803:12c::35) To DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7b3548d3-04e2-425f-69bc-08da18699a5a X-MS-TrafficTypeDiagnostic: DM5PR1201MB0188:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Y63IN02+ENIlY5gD0tUMOgBLIoEbPDDjyVoSBcIYtP0CMrX3sMKdt7lFKxfZxExO17wEzuiTg3LMn7enNo5AFZmURo9daU2ggRfcJGF6JAVoPMxRYFF2gMzsazWmpU0k/Mju4ycE3Qju1yo4b5reVYzcl/Y1AV8GORFp+MJHK06udm4B1hom3DI4/Hnfgt6iFd9mJFq9qST9NJxkHsvZoBr3SNlgdeFCRmuOU42ZcbuU20hI44pySBGTcAIBuOtTadjCh6AtpuY/rBNNWg4qksfag3QOFAWVpzuoGgbbUYNgT4Maa2O1pfXW631JK2ijdcRYFbA6peMsB3raJ4aLZcJm1MtISStc5a60rZSPkyljWK+29SeC1JbLfs3WrFELnu25Gilsr0xRarCWs8nxYpUy7JFFG8K382w7lgmZnvXdS16wzqEtztpOz61hUW9fPiplatQmIErgVPpzSsgC8iiFmpV6z4Yvw17LvmrnKup+fLS9e4V5cIzzMJ8EkfFZ88Jf+RgFP+INp7qgRcLGli3FfRW0GiXS739JblK88XM5gLy+arMjHiZuAPO5hhVpSknVyTjEhGDUs7KrmRDEzYm292cI1Kowu2/PURxBsPdYHP0aAXPsAwUTzFKWMRZjaVnzy0CM3w1lWCR3tND+Wg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4337.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(107886003)(38100700002)(186003)(15650500001)(26005)(2906002)(6512007)(83380400001)(6506007)(1076003)(36756003)(316002)(6916009)(508600001)(6486002)(4326008)(66946007)(7416002)(66476007)(86362001)(8936002)(8676002)(2616005)(5660300002)(66556008);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: TXvQOcPeaM9wBqsc1l9Eb3LPMaaHt4r43iqHeWrfuPH1K8ewss/8QW//Vx8XXCCrxcvvpsJmjj8e+9oD1ZicSqxRDgmNoJc3SWsv489TN8k2P+pqGx0+tTPqR+WXzOfPvVexYXWzcbT3lwZM/3KYfwEWt709aLmykS/5eBeqJkVjEZNiYp6kWIlIgm9mRtd3vjYCVe3T88YBKz31lRrp72p70DNIZdyod5BTLNDHFQbNW1F30vQDB548KbJvFcAFaQyGgGNTzlG21/CFY99/3jeSIPebAZU6ZqnnxRYb6chYvGkMCge0rqzv5OWZUVCVgM62vM9RkDZ6avNuGS9iimsolupJ2oE0EwxYIaRm5ZUUrjm97lQzqcq35YQXJwtwRD/qgXMOWnbzOMbwxp++pBWxh6PsrCxUuRneWQKnFI/+YKZhhzIoIjSEW/XDoBMz0iSBjNRx9e6S/2v+QPTm4XYnuazsa5B1HY2tpQ4850JzQ2dJ5/Q4ZF7HYYhHFbMhmPQdbrWcP33DTnzse6kN9NqXXTXiGXMN0iI4Q8pH0GjfDJpfn7aUQ4kiL5WNevpU1BWIwpatuQMwsWzyUr3ebDTQ1vv+4gwqTueuDueXlJ0Vm+oBSyoBFGNRNzKURMz+NOAEjqwivmGb/DnlrqMn8du5RCddTiujMlJZTg6CFGfHcjl7DwI8R0AEzpf4SZKfsBC+bZtenzQn2DUZVLvJLLM4b9JZj7mnN8LdN65H+k9KOnx0RGfIyhL3T9XsZNwyp2WLIoOhZHytkk32PQzTqU4AHUpaqpVaQdwsv30Ll71rAucbsbbIPTIiFB5jIqzkDOVTFK/2LC060tjBBd6xn4JZJK2hxx0jljbcMhn3gaKnNMS4fQc5FsilyqYdaFr7T2R/0RWcB8nHghxbuE/u4ezK4i/KH7NWSkkt9Zv/5DaCoI9jSaYdLP4gu8Lci+iRnaegGGfdw3KWZy1/YCwx89YhK7FCBor3xzQTYXrIyhFyOwSLa/6SHx5ZLFjqv3L2/++uBgxOzMvX488YuHt9yPdLyfFGQAHDObRbCNAaAMOowQlwR1RGH/NxXqHzibQvtTtBjLQJNOgMa+JVgQ2xjIh/YCVIqFXsDwr+mO9F+7QIEDSfoYrB7w7WUS6859xD+t4wNjcRtYrqvUDxvNTbRFwEL1zQZKaaqHfFB8lg9rZkcb6S6DlUeqRQPOwNCBphT9dOXhRLdyzjX11/XTB8Xtvy6SpXUR0ldHWgsN1Pvue0hLxNyb7EE0cLtABlmFYtuKViULhmmh5t4gSHsDXZAXE2CrljCMxD3w3AViQrEuuaZN+BtWadaXL3MBbou2J9+ybUXpwPyofzxF4qyn2jND7D0Ck5GC+vbZ6PJurEr+Qm4MSjG5zjgOyqxthKEPLsxSivHetqiX6iB5/3GRZha4PfNkR2EkVFYwjnBqmXBuyAgB6pEn6yDYL6DR8cdp2YgHs4My5yIiLE9OhzNg3P8S7p84IQCsa7ML7pQ44yMDgHgw7CyxKBXjogsEa+wSLxUIEmunLqkeZPT+nR/UBRkLn56XXnT0cAABAbE5C/bY+W0DAAeSWi89cwki5QX7Tdv6tFodrKurSiyNAsqo4aza0o/4MOjD/HO34t7HHD0hnIPReRaToQTqd3tJpGWRUytv5B/pFWzSXKjMr+IUHgt9Oeh3llXuJpe7xoycc49m7SleezvT2Sev26QciQ4ATEIKLJ8DD4kS3vykQOegry6Q== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b3548d3-04e2-425f-69bc-08da18699a5a X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4337.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:38:26.7220 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qqZLGhC/BEAAg4+xb9EjDiss/uGpvjUatfpvQO2l/Ev5n/EWM6pcF3xnq1EHxB9MQs3EkzyzsMv4TIPU/bTxuA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1201MB0188 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org For better error reporting to user space, add extack messages when police action offload fails. Example: # echo 1 > /sys/kernel/tracing/events/netlink/netlink_extack/enable # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action police rate 100Mbit burst 10000 Error: cls_matchall: Failed to setup flow action. We have an error talking to the kernel # cat /sys/kernel/tracing/trace_pipe tc-182 [000] b..1. 21.592969: netlink_extack: msg=act_police: Offload not supported when conform/exceed action is "reclassify" tc-182 [000] ..... 21.592982: netlink_extack: msg=cls_matchall: Failed to setup flow action # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action police rate 100Mbit burst 10000 conform-exceed drop/continue Error: cls_matchall: Failed to setup flow action. We have an error talking to the kernel # cat /sys/kernel/tracing/trace_pipe tc-184 [000] b..1. 38.882579: netlink_extack: msg=act_police: Offload not supported when conform/exceed action is "continue" tc-184 [000] ..... 38.882593: netlink_extack: msg=cls_matchall: Failed to setup flow action Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata --- net/sched/act_police.c | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/net/sched/act_police.c b/net/sched/act_police.c index 77c17e9b46d1..79c8901f66ab 100644 --- a/net/sched/act_police.c +++ b/net/sched/act_police.c @@ -419,7 +419,8 @@ static int tcf_police_search(struct net *net, struct tc_action **a, u32 index) return tcf_idr_search(tn, a, index); } -static int tcf_police_act_to_flow_act(int tc_act, u32 *extval) +static int tcf_police_act_to_flow_act(int tc_act, u32 *extval, + struct netlink_ext_ack *extack) { int act_id = -EOPNOTSUPP; @@ -430,12 +431,20 @@ static int tcf_police_act_to_flow_act(int tc_act, u32 *extval) act_id = FLOW_ACTION_DROP; else if (tc_act == TC_ACT_PIPE) act_id = FLOW_ACTION_PIPE; + else if (tc_act == TC_ACT_RECLASSIFY) + NL_SET_ERR_MSG_MOD(extack, "Offload not supported when conform/exceed action is \"reclassify\""); + else + NL_SET_ERR_MSG_MOD(extack, "Unsupported conform/exceed action offload"); } else if (TC_ACT_EXT_CMP(tc_act, TC_ACT_GOTO_CHAIN)) { act_id = FLOW_ACTION_GOTO; *extval = tc_act & TC_ACT_EXT_VAL_MASK; } else if (TC_ACT_EXT_CMP(tc_act, TC_ACT_JUMP)) { act_id = FLOW_ACTION_JUMP; *extval = tc_act & TC_ACT_EXT_VAL_MASK; + } else if (tc_act == TC_ACT_UNSPEC) { + NL_SET_ERR_MSG_MOD(extack, "Offload not supported when conform/exceed action is \"continue\""); + } else { + NL_SET_ERR_MSG_MOD(extack, "Unsupported conform/exceed action offload"); } return act_id; @@ -467,14 +476,16 @@ static int tcf_police_offload_act_setup(struct tc_action *act, void *entry_data, entry->police.mtu = tcf_police_tcfp_mtu(act); act_id = tcf_police_act_to_flow_act(police->tcf_action, - &entry->police.exceed.extval); + &entry->police.exceed.extval, + extack); if (act_id < 0) return act_id; entry->police.exceed.act_id = act_id; act_id = tcf_police_act_to_flow_act(p->tcfp_result, - &entry->police.notexceed.extval); + &entry->police.notexceed.extval, + extack); if (act_id < 0) return act_id; From patchwork Thu Apr 7 07:35:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 12804578 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 994E6C433F5 for ; Thu, 7 Apr 2022 07:38:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241950AbiDGHki (ORCPT ); Thu, 7 Apr 2022 03:40:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241963AbiDGHkg (ORCPT ); Thu, 7 Apr 2022 03:40:36 -0400 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2081.outbound.protection.outlook.com [40.107.101.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABF41140F6 for ; Thu, 7 Apr 2022 00:38:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fbdBJg6Xt0xtpp1Wn/Tihbc5O164tHbqyGu6oGJFIa+NWoUEof3sLy/Dl2R4nNOBKu57MHA5nm7RYgkqhhvff9DVTIr0QMHuudd//7N82nMP8uyKFv7eAi62UrVP4/0GDD9U2AEZV/noDFx/gM3VK2erCTE0+OEaW6/gYQb9K8BX88y7b5H7fHCw1GbDGbt82aEkTT443SxXOL4dZHnGzUCXmr7S1qMxmtiirwGm2oBX+hXd/RCY627rRTqkobF8AaFr36N/OHfDkbplqGcmwPmoPcBCBRipLt7XIL4A7Jt7h1U/nbyJOaXsKZotKVRzYjWobkpZCRfUorOLlxEf0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UOIgWLiMoMWEX+/rAF+HJkpjK8UaxXXLfSGPxEs8ZxM=; b=XxdlexmlWiMN3GA32vyO6kAPh64eei03+QJpByfjjH6GEdcwxxO6uXN8DH/BFJ3fFNOwnnopKF10bh3erVZfE5z/jc8DAVKrWhWi05f8h9fmngjKSTz2bWvI3nvBCCgxuXacrmdzS0J0PthxcxY6NP5Uy2IxNbJSkRUbVar7Ho39sGQjroSoaCfFMUjFLTurGVIEL34r2rBxZl+c0a2IZKMvLtx9jV6r0iivVZVgtHGITPcYzEoExbAO4vdPKmWYdzrsKuK0B3gnHo79pFTlxe5kNXse7P5FxPaVpyocoBRn5dbnCVp9Ct7kdULjB8SOdnI0eCH3EKHP/ddrQiJc/g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UOIgWLiMoMWEX+/rAF+HJkpjK8UaxXXLfSGPxEs8ZxM=; b=WStGebXUyUcBLu8sIRP25U/HUwkxj3G6HXrEuYwKJCBTJgpY6xRu3Vuql8Y0NPNyhdwPMAMvtGFdTNn1RvX9koKoa5PTF2KGEJs1ICbmQKtGQCsGbtnO8CBu0O14iqRYOvjHiMJsQODlCdhRkhwHy4bGxzznJcnVZImxZxlanhsljrdDU72EwJ9peO5s1ocAwr2kxNeukwXGMhDnp81FNWiXrE7YhcTP8bnXdayjNzZs4o462BEGmie9Q4EWvhEh6DOUmR9KjwE1TVKvETpN13QAEGxksxfrk2u5K4GuzR4VsLn8Mqck5HA1NiS2k4R5BHiYdhJet+OuNZFiDYFsZA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) by BN9PR12MB5228.namprd12.prod.outlook.com (2603:10b6:408:101::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr 2022 07:38:33 +0000 Received: from DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2]) by DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2%2]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022 07:38:33 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, petrm@nvidia.com, jianbol@nvidia.com, roid@nvidia.com, vladbu@nvidia.com, olteanv@gmail.com, simon.horman@corigine.com, baowen.zheng@corigine.com, marcelo.leitner@gmail.com, Ido Schimmel Subject: [PATCH net-next 09/14] net/sched: act_skbedit: Add extack messages for offload failure Date: Thu, 7 Apr 2022 10:35:28 +0300 Message-Id: <20220407073533.2422896-10-idosch@nvidia.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220407073533.2422896-1-idosch@nvidia.com> References: <20220407073533.2422896-1-idosch@nvidia.com> X-ClientProxiedBy: VI1PR0502CA0017.eurprd05.prod.outlook.com (2603:10a6:803:1::30) To DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4d7711d6-0464-4c4d-7a67-08da18699e01 X-MS-TrafficTypeDiagnostic: BN9PR12MB5228:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pNdSziuJRBJYS2KcnzFK1ITSgiP2AU5ODEIvLk334/zzxFSf1Qa1Ei0Vxu7TmjhXejzM3NlvGqxLOzRHfDS815dkas/HNbTTMoxmQhvzmEgursjk88HIXBaWhY2GSxvHucSXFQO1FZpDpoPRUW4Iw4IGfEE1zfdVs38F6ySOcnyOuyy1Cut3IbmlfAMEY230Chr1/al45bofUZiYd0r95LWfD0NC2JsCezcr6iE5gPbbzc6ZugzKAG2hsTtpqK0l9LiUn8WNcT3bShQpimqH6XvFsC3ugV8a8OvWI3klh1GJtivCQ/4EDwdnKW3q12zZpZjViCwrb7lYgr4cV/saBJbyvk0J1pbEaOYosZNphmxPvITs5lRBO4pfIo4V3a3rsyIZI3Qz6alQKyo8p3fLBCPLbkbjwZGb2V93tRFNw2KDuzmMzlMn1tAWo+cCfjrrhNdPVP5BJFWb05KQi+4yGEKuJ670MJXoqHw/pdwB15CCcFZmqA8AgE/9mYMzZvucPAjNQhDqcXUX0n2M3jM92AglPDZ4kTZ9oDuHKCNgJwF+L9/iQkMebvIWZUohwjJQNHXrlLTEfkROQeGg+YxTpvr5fJv706zzDqmBbOwqVy5KPtvVqpiZKSS6l8/LYcavBMl6uI0zm47PhzhA956Nyg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4337.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(36756003)(6666004)(4326008)(8676002)(66476007)(66556008)(66946007)(6506007)(38100700002)(5660300002)(8936002)(316002)(2906002)(15650500001)(6916009)(1076003)(107886003)(26005)(186003)(83380400001)(2616005)(6512007)(508600001)(86362001)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: oaYu/5t6u0juLOY91dyOUKeYSR1oArVLaTbj+mgAjUvpkkGXDOJcVAst7RZdgHUhF5VZeBTW7Hat7gozGr2W82a7BUo47+a9xdEi8mlONdGb2eX9QOX3mZWOJPJFTPWZfUiyWAy+NlARHZgMLvDQjdtoYURF9z9qXCIAkQ52qJmvRRAZC98DWEVYJFlgkPiz6X29cQKW3l8+heHx064Jpft8leFd3s+cmJbeOIsycNdaCzIHtLdo2m39NcxGn4u1nH0MbThLpIGFm3xR3N/iWu92mrhrw9yPsk5+ExqDt7PD7MIjZbC97Uq/ZANFylSjy3Oac4nAgPv2h+jM/gSAq4aqYi/ZAUEsAk4UNU7WesDv8ratm3aWjkRIKJftrSaO6dA6EpKXgo5aC+20UniJw26ouX/zjb5tc8tCiG2AIA+qowiSQv7hvH+TPj82HuuqjqiepJJPVhj+AuLOK+TNp3YTEMyz8UJ1OIuydIFriOUSHuK05PAEv3zAKafvbkRpjCJppn2poT8wkx6q0tfDIkjpULpnWVfgcZ18g2wo0OD/DHXkTMiVAyQwnqwJSH0d6JYNGulNPGmoT2cYpp20Gh+FEWNFdsuWDE+P0mP4NSmEcmJ3NF+qcAhPRVp6tuBM0wm84TxO3t1GGqhM0fuu3ZvAlEyAPDspO76Mu5b1Y01LEdrDuOul78uz+DvwVXJUwW066+H/sQOMc09G727ZZC9BkSZpE3HEMRmP+m/XNtn0Eku5izSJhdw3ani1Wem2GhLEzYVTXIrwrM2+FViNE/Wt3G2j9uG0Pw6eTMVXk/udj90DW0LNQ3kv16C+b2BphG8Hal06um6EoPvetngIdh36IhErmizsdsM/qsxlhMleYcN3i7u4XKM8Wz6s9wDBKDbDsoyE6m2sTUsqgCux9yz+G8Dbgz3lXWxvE3IGIVB0Rj8Hr7v8QD+ulA2z3DltQLTTsmErXWjuAEe24E1dc76W0dEssVQUqQzT3wtYlb7sXVuZSpUOjqQLBpMMSPIFIuCf3Cp/ycxq4CSLhpZ0uBqhcL0xLsu+TM450eiONeWGu9pCt3SVgRCKPURzyZfvaIuZVcvU2TsbeMZbGaFVrhYK5lQ8GSy/ueQQ3uuVry/iOu6fHKLng3w/dOmmB/pUmxoUoMuhGmDkNiYHbHFcWS4oOrKjbpFIjW8H4Vu5aFnaY2bnMEkpS/pYJTICaTWK1OMUW16SVGulZX67/LnN5Dc8283b8zcTTS3jHJrUAvjl1/grYqAskOKKMHEy8MiT0wa+vfzfTJLqSi4lHjoyypauTkN4Q4NU62/n3TLMOtAndSnYGY/kABbucSRufCGg1emuSxP4L/4Leca7nu56HCUt6OBOQJoB/XP0kJAh2wFPzKfNaTLd0my93GyayRqoegMfxTNCWmMQIluRe2Np7PQJFi6zFBO9S+nSVoR6IJiGZTS8oE3VJIttT4ohJZQWp85FuTyTkF9WjeSjWNT28BebDO2brZKBN9n0My4m7GfkBCdtJK7+6xTCIs0niWMpClug//hz1jyu30kiBUPQCcLsSIjwWqw26hNvsNWHmLHQIwJWQjkZxeDDscSdicMVnHw31Ziw818VLrYQiNiXb9vQWEmRiG+7OqHkYbHXB3nSH7C6d7kS/840+jAnFutddUISTpHZDAZoG36Hv/T4REcanJd3nT5qF6Yq+8eLRqvsE1nJBXzEUysIfuKk9rffF+NoZn9sz6TnWzdhGQ+vEg== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d7711d6-0464-4c4d-7a67-08da18699e01 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4337.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:38:33.0375 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zp3WV0f4riRMj5uRGwb9o2WtR18aMj/bfedX4ReaUDjidIZKJt8dCgyiwmnSusWdno8geW24doDBEGhP3ZGfUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5228 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org For better error reporting to user space, add extack messages when skbedit action offload fails. Example: # echo 1 > /sys/kernel/tracing/events/netlink/netlink_extack/enable # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action skbedit queue_mapping 1234 Error: cls_matchall: Failed to setup flow action. We have an error talking to the kernel # cat /sys/kernel/tracing/trace_pipe tc-185 [002] b..1. 31.802414: netlink_extack: msg=act_skbedit: Offload not supported when "queue_mapping" option is used tc-185 [002] ..... 31.802418: netlink_extack: msg=cls_matchall: Failed to setup flow action # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action skbedit inheritdsfield Error: cls_matchall: Failed to setup flow action. We have an error talking to the kernel # cat /sys/kernel/tracing/trace_pipe tc-187 [002] b..1. 45.985145: netlink_extack: msg=act_skbedit: Offload not supported when "inheritdsfield" option is used tc-187 [002] ..... 45.985160: netlink_extack: msg=cls_matchall: Failed to setup flow action Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata --- include/net/tc_act/tc_skbedit.h | 12 ++++++++++++ net/sched/act_skbedit.c | 7 +++++++ 2 files changed, 19 insertions(+) diff --git a/include/net/tc_act/tc_skbedit.h b/include/net/tc_act/tc_skbedit.h index 00bfee70609e..cab8229b9bed 100644 --- a/include/net/tc_act/tc_skbedit.h +++ b/include/net/tc_act/tc_skbedit.h @@ -94,4 +94,16 @@ static inline u32 tcf_skbedit_priority(const struct tc_action *a) return priority; } +/* Return true iff action is queue_mapping */ +static inline bool is_tcf_skbedit_queue_mapping(const struct tc_action *a) +{ + return is_tcf_skbedit_with_flag(a, SKBEDIT_F_QUEUE_MAPPING); +} + +/* Return true iff action is inheritdsfield */ +static inline bool is_tcf_skbedit_inheritdsfield(const struct tc_action *a) +{ + return is_tcf_skbedit_with_flag(a, SKBEDIT_F_INHERITDSFIELD); +} + #endif /* __NET_TC_SKBEDIT_H */ diff --git a/net/sched/act_skbedit.c b/net/sched/act_skbedit.c index 8cd8e506c9c9..92d0dc754207 100644 --- a/net/sched/act_skbedit.c +++ b/net/sched/act_skbedit.c @@ -343,7 +343,14 @@ static int tcf_skbedit_offload_act_setup(struct tc_action *act, void *entry_data } else if (is_tcf_skbedit_priority(act)) { entry->id = FLOW_ACTION_PRIORITY; entry->priority = tcf_skbedit_priority(act); + } else if (is_tcf_skbedit_queue_mapping(act)) { + NL_SET_ERR_MSG_MOD(extack, "Offload not supported when \"queue_mapping\" option is used"); + return -EOPNOTSUPP; + } else if (is_tcf_skbedit_inheritdsfield(act)) { + NL_SET_ERR_MSG_MOD(extack, "Offload not supported when \"inheritdsfield\" option is used"); + return -EOPNOTSUPP; } else { + NL_SET_ERR_MSG_MOD(extack, "Unsupported skbedit option offload"); return -EOPNOTSUPP; } *index_inc = 1; From patchwork Thu Apr 7 07:35:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 12804580 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57408C433EF for ; Thu, 7 Apr 2022 07:39:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241999AbiDGHk6 (ORCPT ); Thu, 7 Apr 2022 03:40:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241967AbiDGHkz (ORCPT ); Thu, 7 Apr 2022 03:40:55 -0400 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2040.outbound.protection.outlook.com [40.107.101.40]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CCE074EDCC for ; Thu, 7 Apr 2022 00:38:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EmK2MdBprnL7q+r8w+EF0ARFUTfJh8fLRqru5EvIfyIv0myuRWZ5mZqCCCYDVSAiYvf/y5NgwOmiFBIF1saVnSE/ZRT59zUdEwQMeNc70D4dbQtVbpgKwou8hSnQeUA3X6ANCoMO2rLD2cjxnWsk2nxgbFMxj+BWA5TlcO933Z/X9W9OSmcXWJ2eOfoqBdAEHrOnIdDgDFKTnYK9NqeTGgVvslJnpNWOX2dCP8IMChWEdQ6v4W3u16UeHSS9DyXdfIgjcCJ/uEzfZrqc81jEDa1/BKYh92k61/9nNhewBgt+XB1Y7M1HMxLxtCounuM8RtGVu4fJnmH0rzpvBagZjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jOpUenFEemyUnw2X5e1GI8ttcBKN1FUoP/Z+w4Sp4N4=; b=MK9PnHk2gOn+ErNlQAg1n2T3wI13EY4kJyG05BXZ59y99e3km1k079Dd/U/XroGr7KJgug3ZgQW0A4RJaCTd38TScDPmrqR7CKxeBYCRk/e8MOymXRup7d3RL7bBp28bnSB8BBRPXtmlm93Qg/BG7ZFTHuNYGU5S9KL9k/1FWbzf93XLpV1cmWB7Ij+gIFI6FpAvZQBnxglas8YpIiVWRFW26dRci7BDPUamp39TSUuzXwoPWG45pKKTQVcDIdgryzC+Qr63fJ6PIiOqNADDbSysiyqU/NVwFfsJHEUziD2IdHtz88rBmTkzfEnFizL97kx6Hkv8r1JqJKULemLpoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jOpUenFEemyUnw2X5e1GI8ttcBKN1FUoP/Z+w4Sp4N4=; b=WDcQAMhQWpv5gI2ERqZ74TX6X0IH4HHZN8dCIU0qPpvWv9ipP9qKKUGFL8J6NMN57TWFtuQWW3xvKH558nTct9+urtiKcHSpbeOUwuhQOHY7HXj3idCZCImr961nvmU2RanI2uiavbYbW44vtyERqncSX3KZeouZq4ER9HcN5P8JHT/wTYyAiBX4hvW6EfpKtJlq4BpvWHLnuyikFGwgQXYIzOiRnloyziiNapKxfaWuiHvqFnD/FtQqV6bDCsmqAXYYiPrdIwC3a4dmbW8kCzBB//C7MTlRoVzNgezrk01cPjY0wDmlqTV1mhtHVgIUCn45hioy0ewkwzudc5YEiA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) by BN9PR12MB5228.namprd12.prod.outlook.com (2603:10b6:408:101::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr 2022 07:38:39 +0000 Received: from DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2]) by DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2%2]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022 07:38:39 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, petrm@nvidia.com, jianbol@nvidia.com, roid@nvidia.com, vladbu@nvidia.com, olteanv@gmail.com, simon.horman@corigine.com, baowen.zheng@corigine.com, marcelo.leitner@gmail.com, Ido Schimmel Subject: [PATCH net-next 10/14] net/sched: act_tunnel_key: Add extack message for offload failure Date: Thu, 7 Apr 2022 10:35:29 +0300 Message-Id: <20220407073533.2422896-11-idosch@nvidia.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220407073533.2422896-1-idosch@nvidia.com> References: <20220407073533.2422896-1-idosch@nvidia.com> X-ClientProxiedBy: VI1PR06CA0183.eurprd06.prod.outlook.com (2603:10a6:803:c8::40) To DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f9c317d9-2da7-411e-da19-08da1869a1d5 X-MS-TrafficTypeDiagnostic: BN9PR12MB5228:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Pm/cQiW9FSp80YnSueBb6b2G6N0U004OikwfJRxpnZPAV/bfgNdhv78KbVEjyb+rMuOh2RRfVNNgU6PbP9oFLuA3nDIvx8Zvc9LkOQUvqNbi6r2PcYFVFS9CJUTF/SLBJis7patRbVXsJ4PHmqEjKXcl5TlCoIf3yfezQ7Z5Y0ww5M94R1kRgBf2Mqs75dafekMFdvecFYQseJtebuFnW+TLHonX+JHpvZzkBN7ohOAg+hCW3d/E+30KPpLFCEu0WT7Xnd0wJxEljkw4x7+XXjrz4648rNDtAar3UavRRnzRYeLMqbmR9/py3CJLVhJW3QFlZNZ5GPjJMtdctNw8FxTrtfPk/zHBS6jBFsWhGMUNapHqxiS2qM8/vZ1ejNuKUoHQH778MjHNfSUzFFfZ87lICYHPa+tLs8rmnZrRF14dvTej4b+ws31aOeNMJ7ZDyiVYc+5Z0dVyXU7I7aoEzv4COaj4xzoxw8ZLWMlil9ToS5RYrV3kgWjwIQ30cgRsGtnPSPM9oESHZ4I+RPiICAlIm28zhE0bizGDrQn73S+kkS4DXTNE5pvw/ih71rh0tALVTnBWFWLbLsIS1S+HJcLD6wd3Yx5RL+S+gzhWcB228lLvTbE5tYkIVcn1l4kvulnb8uC9xxVauFVQ63Mp5Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4337.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(36756003)(4744005)(6666004)(4326008)(8676002)(66476007)(66556008)(66946007)(6506007)(38100700002)(5660300002)(8936002)(316002)(2906002)(15650500001)(6916009)(1076003)(107886003)(26005)(186003)(83380400001)(2616005)(6512007)(508600001)(86362001)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Js0nbkn2GRQnEtnuvJvhYsBbTMK0hTtARbEnCSR16t4wLgEXKU07a5vMe++NsO6hdrVBO4d+5ohZ3lBVvZer10Ax+HI1gkPHAUSFpo0e6opqlBVeN8uKOIAASxx3VxS1BdMvMl+AwoDQaDRIiik0FuVenlm7PAOP9WJbsj6o9dxgbITxuYTDAKSUtpqLTNwzMXlzxbhLPVpN688U44Ir7VBoC8l1JXpBXZsIr0ZC4Rim7Z8T1NHyKf/2ZPSbdC31l3XUXlElA/AQ6iRtkHiHQM0J+Zaougi5T8/g4SPLxlsxRsYXjV9Gx8Q6YWXllKm0n1OCrFfThx2SlYQC33CidxQ4fudxfs4lKBe+qXjWRR8/cC6t5lWr11ODALybn0Wz6RDgU6cogvzcL26SIh3u578kdVoLH712BrhcHEEOOuLrwans/nA/gDXH7vPcNj5jEBl5zilwuMv16P8eYG2K+1ZPFLKkaTfUmZ3y1lporO+A6LlMAkVB8vioAdSW+F1gX9IIvROKPtdilduNSYf1Ijv+gKhA+16BqLZdUXn5InWfs30BzfXqeBLwuX70N086Qu5yhaUeuPrQUW45Xdw9LEq0MK/2caTh7mNE7or1pztFE4H4P7l/7Ip5zQ+eX/48YOPSOlfpwgoqdLagYwTICXl33JvmgzxBfjQ/LWXpXS16GWLPdjRlTFBQ72Im+8nEy9l+/bEs3T/PufH2aSNZPzJCKiIcFiccszEq+nHJyFdLAzoLoVCvuBSDTfVZ73c1IAGJgxg2/03rVs6d3IWwdB1olFkjvlmXJCxMc3FqStInOpccVG9SfuTgRlDdggqlvGoZsD7JS3frGchxabbvrYEYwB+23H91//UX2OzR90vkPd8YnZUPDczpsR7JOgrnAOMm1T3qF1pKiLONFXkQgVXt+Lx5n1nfexayyYmWRPwB6Ov8i+PVzrQ5VL+AEvneByL3i0dgWA8v3Q6lsyK9ZyKvio8AbaygwlQ+wT6DrZhmox6fQzl8H/DyqlyNMQE9qmOw6kCVHKuaYvyHuo8+VJYmU/hP2QyQL5vdkTdIVVzT5OtDxiosmDMcPRUsXEjJXJnjkhe0MQknrCHp2/1zQdSLTdaX67olCVSpb2yVJIQcpB0R7ra/4QniQY+ymmxEUHlJUN175ZHOhj0BaqjWGPwfsho5ug/bKsrUMc9PVWquZt1TneUpiXty/DC6CzodN5N77Y8OQhke9gT4EzEO9VP0/5bBsApaHjOmwcEjE4ARdX37YWa3lEs4uFllmtZoHvq7A2dV6Kr0506cxWk7mXcMaLGoKoIKzCfoiOa8YjB9gvgjbsqJHiB1/+fDGFE0+kWesbW13vsqtanMkFRheqy0UkdLiit30CczD6xtP9ROTt/6ADCSdvdvdyHfopBRIpot0xzPH06VPzagbF7dAHVNPlWcOSLDYlb5DWUwOoaH7MzD1SaAAmC1Gxcy49sD2+fKYEsP4AMiBfj03GTA22MYfJZUaM/r6bmOXTlaAe/fUbu9FHxzSLeFXtob3ljFBri/MWsmUU9R7i/Kdf1jBe4OjxV3ADQE+E4ersec3e/UV14DfDlxu22P5+1x58KswkeN31um5v6db86/feMmaxw7C7joJ9s7e3+Dz95TSaURbN+/4WJqkGpKx52OE8DS0GMsLqWkRl6U9byYOYf1xtlByHVzRbpbPKOzfEOxKGSDAzbKTd42zsld6DezYO5BSl7sn6OYOJaJUkvm4L3Ybg== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: f9c317d9-2da7-411e-da19-08da1869a1d5 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4337.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:38:39.3063 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Qv5d74eHnvY9ACefaVFtukNU91nyqwftS9ClWQtncWJQnQo5LKv6FP3RS+REIOdtuRSi7BHl90Hwj+gdbwCFhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5228 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org For better error reporting to user space, add an extack message when tunnel_key action offload fails. Currently, the failure cannot be triggered, but add a message in case the action is extended in the future to support more than set/release modes. Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata --- net/sched/act_tunnel_key.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/act_tunnel_key.c b/net/sched/act_tunnel_key.c index 3c6f40478c81..856dc23cef8c 100644 --- a/net/sched/act_tunnel_key.c +++ b/net/sched/act_tunnel_key.c @@ -824,6 +824,7 @@ static int tcf_tunnel_key_offload_act_setup(struct tc_action *act, } else if (is_tcf_tunnel_release(act)) { entry->id = FLOW_ACTION_TUNNEL_DECAP; } else { + NL_SET_ERR_MSG_MOD(extack, "Unsupported tunnel key mode offload"); return -EOPNOTSUPP; } *index_inc = 1; From patchwork Thu Apr 7 07:35:30 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 12804581 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB3AFC433F5 for ; Thu, 7 Apr 2022 07:39:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241956AbiDGHk7 (ORCPT ); Thu, 7 Apr 2022 03:40:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38316 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241977AbiDGHk5 (ORCPT ); Thu, 7 Apr 2022 03:40:57 -0400 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2055.outbound.protection.outlook.com [40.107.101.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A16E68A6E6 for ; Thu, 7 Apr 2022 00:38:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G7trG21EbbUgjXidOGGgri87FGbfQQioN2uK8Ei8IJ6PWvelSR1p2XpvFU+YRWcHlUN7vYIAQXEfhiImQF1Q1Iw81ihxaonoRnyhknC0+g8NX7IirCpfI/VwjBPf1AHOTn7l7PWP8shvgNa0kW3wfqQTAOL8i1P6PEGYhrhCaze2UODB9Y+1keZGx1fe9H2VBZJt+F4UGSZVtoZqO3P/uuBXf2BHBJNq7sAwW2NXZsgS8XRBdOYK7HNBnE2yBm+92hBIEiuNJ0dB8MzcbWEubCOBZUlM7O3TpwGFSbwgnUtyCOVdrQagse3d4T/+UVOIwYfwM+LQC4reaNIHWNFbeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eRPnBijXnUBcS01j5v717liiaWEXkrCO/+py9eisDGU=; b=VVYDIC6PrPGPWR2lkeuNtG7MI63cOmEsCjK/Dm4CMrHqz/Am8d7fx/8N5XcKde/6oX8oOh0UBzkdHZL4Aj6bLwI1GPqqGs+lQ4QmKewyMLLChlA9+0higibh8Rr0tDJL0J9aXaDXGgCBPveoyJ5YZe9/BYCebxdMnrU3pEBKidwHPG+4JyTMZD+MgZCdha1sfY+faLGXLHUbTCHusyBIQg+6BL57hrDUq0wrLhz3hYcXPK/uevZTbi7eHy81kbysKhnSavMh1kk4I0gAsZ+k/HYnjXHesgfeDJnTjR/Ph8VBZ6/Yzei4U7Zh0EnD9NaXZHSAYkxXIaQj4shaToYdtw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eRPnBijXnUBcS01j5v717liiaWEXkrCO/+py9eisDGU=; b=GvMubnhnaBJAKmH4OWQzhOt9nhtXYxZvq3QFxIMY64m1LlCuPAX+JTdPFhqXgxXVvNwYWPbleLQbqrgCRDhIPoydZPCSI0bSvPUsPh6NHHZfAzcTA6m4ErOnUJOzU7UrDoQ7qWg+x6nIuCjY0Zgj2sCM/ZEyjdWH14vuTSTj4016eBvmaZL2xWRw8n6Kis9OVN1vBIOGZKEqOsheqdzjzr43GDYmM+Nel3thc/lBfxWHP0oASNxBRyGo96IKx+CtFJhb/ZIH4dLuUQcBppU4DjIPAC3ihvse5xt4awUbGvPbKJ54XvKudIMkOBZGQD0YpaTCi2u2yRiTQzsBEVxDdw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) by BN9PR12MB5228.namprd12.prod.outlook.com (2603:10b6:408:101::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr 2022 07:38:45 +0000 Received: from DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2]) by DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2%2]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022 07:38:45 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, petrm@nvidia.com, jianbol@nvidia.com, roid@nvidia.com, vladbu@nvidia.com, olteanv@gmail.com, simon.horman@corigine.com, baowen.zheng@corigine.com, marcelo.leitner@gmail.com, Ido Schimmel Subject: [PATCH net-next 11/14] net/sched: act_vlan: Add extack message for offload failure Date: Thu, 7 Apr 2022 10:35:30 +0300 Message-Id: <20220407073533.2422896-12-idosch@nvidia.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220407073533.2422896-1-idosch@nvidia.com> References: <20220407073533.2422896-1-idosch@nvidia.com> X-ClientProxiedBy: VI1P189CA0004.EURP189.PROD.OUTLOOK.COM (2603:10a6:802:2a::17) To DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 01793513-3b1c-4a7a-7113-08da1869a564 X-MS-TrafficTypeDiagnostic: BN9PR12MB5228:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2Yzfec2u5LwS5+0wN11UKqZ1oQvxgzdUh01MJAkFegv92lIxPYIPhzcTJNDqvnXWZ7rnBSzmmv9IFjLszjASF3yQnQ+0zxxel+Ouq99ItS0Zl0hUA203f2u/Y9L7haOrWH3MtZrNX5MqyJOwTLkRNGFd9Qq+3qqIyRXO/Eedv/A43ISxG/kyAc5g+xLWXpkqmR+BJOtDF6icNCStwCCVxzksPwZiDhbUHZeyi4U7BrIAsfudgM4wE2lRiqIhsjcameyixuMO/Ft2Tw73om2vFIqQgUMsjpgfUjZS0jHXqloDvXtOw/7YLMjUEe0/ggVperW2G+gnYq6F0GjUhGm3KDSx4PkYt3Slvu6bM1P0X2Gxpnk7tomd/deKyo6TmuEJUOVGfITt8C+qj7MGyM6o8giBdO14YilJiXeQoITBcOBicZVFbPtZSTOf8Yg65Q69EQv1XCCw5vBqIY72NYp0Q/9f6NTL676XQDUvlEKGuiM/kFCr6WsYQAtXIlC8ZmG1Md8FiHkYc5JsBP6vSEJh7dOlQ0cZOdc8KStNQT4Ir5NoFr6S1WlXbxljNFbJrGtIs1PlD6iXgFkDniQLl7UZTAzbhz/IWYK+0rxcMPFz8wQJk2XRQfIG9wWySDmdGfk49V7qkzfVdAYvKT5CmtJcMg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4337.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(36756003)(4744005)(6666004)(4326008)(8676002)(66476007)(66556008)(66946007)(6506007)(38100700002)(5660300002)(8936002)(316002)(2906002)(15650500001)(6916009)(1076003)(107886003)(26005)(186003)(83380400001)(2616005)(6512007)(508600001)(86362001)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: YGlV/asSbvN3b9y7eGJhqBOua0hOSEjZmymtVsdIFGX0WRjo4n2TWbz317sXaKWMVLPGqXqA1bmiwXZvxHLSt2haYNBknPLK1SISuVNWh6LpKewNMnsNoRE9mDHyFDRXVWXI/9pQ/8OGjsFvVUJJp4ARPxp1RAKFMlwrSbaMDeX2FsqGuAOd+Q4Equ2gdTLOUHM6O3sMM5Vt8IjpTueLdKmcMiObVnSVGJvsqJ1Ccr7ECzw0zkxUHPJ2ryFFqbgTFP8bs0rUAzMB20ZqnxLYeT/zDr2p6AlSvnbjhzzpc0c5ppYXWa+zqxA5+9YvJAS7Ev+NVh35B1sfKDRl0SCGucf6YRGVjur/U70ch6baHZ0uKrygf4uOrZr3fQqyoByxKp6PBzIwQutiPf5nKFyuXiI49Ay19/b95obuzHAKFnmtoZcXiiPpfFoiItKbdnQAL9IYacIzrIoVM3G9XM+2SuPVFExfNNke9Vthim940+pMW/oBPEDT4K5dRhIkva5bFyZWXxMU0m8TH2tiRDCKXI1DStuWDZytxfqJt85UZk6QRXZaFjxA4v9p3m/XOZ+9/aE7THjrEYxJfgzEvc/tn6pQImIGPYy0T+6rozY6mwz80rOI/0NSX9id1lbkON9zd7g6XR/qJ+OsK4MZpMp8K7YSbQTUpwPhLxYNGdfDK6sNFQgD1O02gKBq4q078wkvHUFqMhoSPtKOR2IAgejXhNjuHeojMreKy0MRacySMMnffn7Q84NRyI/WrwuUApgA0h3QvpCoARpZmKU3MXJ8Jw2e2lXR48s2IiMjVE3ig+o/SkHPTzmCqlWNkQPAagtxnFy4gYwhg2aap/BLDgtNkEgAnTcwuXeBK6G3ySl1Y2QefdVT+9GLC4Qm10U+xFlGdvv18ekryJuqe49ieV26v6Nr7SAbqdwovDBrlLblLkEiRpXABy6If7oc4cgIR2/+8qFYBznTV77PPQpKUmi+TbZj9CFF6Swb3nOIvtvKfioe0as14gpzVxatvOJEgVS7B2TjiodZP+FNZuh+PTZJ7Ap3m9lKwZe5aofgmsUtD1koUf1ZYsbAC72xTTNIOz5qxtFs7RvuQ0guwc0uyp7Y/zGlUeFOb8meq+Saog4t3Lfzec5R1ULcGxLAfwInwP/A48e+diNc+6nO/Kx2pAZTngpX5ihBb0zwjvbWC8SIfIpAP9TTiUFOiLYUdsyYe8ipNjX6z4AguXgfhe1MaW7wDdwpzjeQze2c0IZ3Qgr/gxHTJIVIMCtbUdTro17T+niPygBoVDGKdgI4tHYsuJqAflm3m4+XsW4duJmioVJEkMF93k74GbeXRwB+dNmF2XcsNeGfmIR8cc157y+Mug9NwLCPYeWnt7pHp6H00sQOBtbH2tv+UA6h8fJl6RGpwvLFFy9wLv9dt3+Q772DgdreneNLQfFJb64t8ZISPCXR9eu2HY3bfNIs2UDQ9B6ksYZ3bZtiSgbuP+QEvyTq4yR+T8Tqt1XRIvzATwrM4HEnBFxRj8mr8iSGZXXMrbcaVD/7cdu/rP5Yq19DGJezQ7eENWR/UuzFPBq/Buu3yBDzDHSGL++uDth3S19sLlTCAWXvAKeB7y4U8FLe9AbftCPvy5QatoVkSJCBsGM+l4V9021enlSs/b3mLom+JmgVjYlcHQoOfEFxD8kY1AO+uCfPAbn4TMSS0O4SA/EdKnTenyU11OEiLLeIf5hnCRETC9m9rZVhMR82peFiGp46TYI4MQ== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 01793513-3b1c-4a7a-7113-08da1869a564 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4337.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:38:45.2583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t9T6HadAthNJTZ5Igjg9zCPUb8VKpZ0qSLAYnlzXminmNaRgV5pJpz8b+7JFSTzSA7werdgc0NMAvNeBgMNhhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5228 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org For better error reporting to user space, add an extack message when vlan action offload fails. Currently, the failure cannot be triggered, but add a message in case the action is extended in the future to support more than the current set of modes. Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata --- net/sched/act_vlan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/act_vlan.c b/net/sched/act_vlan.c index 8c89bce99cbd..68b5e772386a 100644 --- a/net/sched/act_vlan.c +++ b/net/sched/act_vlan.c @@ -399,6 +399,7 @@ static int tcf_vlan_offload_act_setup(struct tc_action *act, void *entry_data, tcf_vlan_push_eth(entry->vlan_push_eth.src, entry->vlan_push_eth.dst, act); break; default: + NL_SET_ERR_MSG_MOD(extack, "Unsupported vlan action mode offload"); return -EOPNOTSUPP; } *index_inc = 1; From patchwork Thu Apr 7 07:35:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 12804582 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7602DC433EF for ; Thu, 7 Apr 2022 07:39:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241955AbiDGHlA (ORCPT ); Thu, 7 Apr 2022 03:41:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241998AbiDGHk6 (ORCPT ); Thu, 7 Apr 2022 03:40:58 -0400 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2051.outbound.protection.outlook.com [40.107.101.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ACA5D1AFE8A for ; Thu, 7 Apr 2022 00:38:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AO/At8vbBJ4QhEVrQ5yqDe+UP8aW2FCjOwE7HbQu5jTY8SrDQBgwLKvhL5UqSWrcZVK74TjQW8UteTCJixdvFTVgX/QQkF1MhJFOkbqt/HeyG0oOjFfz5Sgj3QdBCxxmkl+cIFm3mm4bucGchmkeqQ9/q1+tkNCWAxIHdcbM9zxkDx8wqGBjIpauX9x1NAhl802BX7YzhHWO4uiTaGuocUeu896YLIjky1YqE8ij3l5SEC6sSGe/S6RV7vYUKqTvQuM/o3eKYvx41xwiqQJ7Gup0ydqGviVDG+CL2UDf7BN5t13xkC5p0KURIQJtvBwHzGWyWkOhP29vQLYBQh4XXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O2ljHDXK+hi6sPxoIcWMIpIRfINaxSCRHFL7w2D0m7A=; b=QYv9X/GRNA2e9Df7VedQun9BU09PgxkCWsAGmJgZii2Wyy6j4riSlOXOBPny4+ME4NrcqQ2Pv+lUPR/OqU9R5Q4E5E+oWJ/KOCb/T6y78fMl1L7vSfEyH2HTRwk9t9Rk/FGR1QcEHUPE56y2sGJ3msV5tBp7hQUakCdjqIEwtQSV/HPoM4bOq7xHhhpAWA2kRNnANwz5DMUbIKrApSLNa/gMZc6QH9HllHPq+Hq31OSqQ+VQT3sv7a3XfHW5HSt8Xrklxoi+SumHre+xCNWoRYbmhKRss/xasC/9tsmwcdjafONoAO/CP5HKtQ7M2Z6n4fwaXIXSGzJFlE0yxVuzug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O2ljHDXK+hi6sPxoIcWMIpIRfINaxSCRHFL7w2D0m7A=; b=RkiXY8/KYj956RMoHfk2Jii9u6iyQp1bCqMvW91HAtCNI/stBfbLsy+vROpm+zInxmSmMMc5aFcRVY9S9a13QKKedb0+KPHkavPLxD/N2aItG5RXxZh8Ww8uYsDzq6e9WcqnfIrFEgtG4gGZlzC1EzAhPNAeP1taQJf5f7yaQfKgCEHBd3lmfIFHKCbusSqjzizQ4bFmx5FRPHeQbFcLXyeuNOtsWCACA2XUhQ+KLAZWCMGyxNZsbm8Q3kv2c8ytMNT3GrB9lSCx3Bl2V5v4WvG4raOhQp9DT7S+vcrlwuZ4w09u/aPG2xTxl87evICZw7E5gjzx7FQ7tEa59X3fhg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) by BN9PR12MB5228.namprd12.prod.outlook.com (2603:10b6:408:101::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr 2022 07:38:51 +0000 Received: from DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2]) by DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2%2]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022 07:38:51 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, petrm@nvidia.com, jianbol@nvidia.com, roid@nvidia.com, vladbu@nvidia.com, olteanv@gmail.com, simon.horman@corigine.com, baowen.zheng@corigine.com, marcelo.leitner@gmail.com, Ido Schimmel Subject: [PATCH net-next 12/14] net/sched: cls_api: Add extack message for unsupported action offload Date: Thu, 7 Apr 2022 10:35:31 +0300 Message-Id: <20220407073533.2422896-13-idosch@nvidia.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220407073533.2422896-1-idosch@nvidia.com> References: <20220407073533.2422896-1-idosch@nvidia.com> X-ClientProxiedBy: VI1PR0102CA0043.eurprd01.prod.exchangelabs.com (2603:10a6:803::20) To DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ca10ef73-c9e0-41e2-58c6-08da1869a8e5 X-MS-TrafficTypeDiagnostic: BN9PR12MB5228:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LQiUsUaNauqYny1UO2HfjXqwkQi8ylkcDfywwWArKFLTaKA+bMsxWpCeYb5/6YcyZBcBqsc8yOIdm6wmQc0pX/h2i8QWze841244In060aSPZQK+umb6mB5S+fTYp5AQ0DGNqhYaedFmCb1KlFLqbKnb5ePd4nTrwbjDGWSQV6111939K9KR1rqjZWU70ByNWmegBq1AgFC657qjfdJ8XWmJshj9MIA+Zefxr9ESL6+AP3XJddoazpuT4w+Nxk1OhjgThLZP4M3rcOzb1fuZwCrQ4BLujSgfmSOBsDPZyMODf3/Ps0oMOByKxJBfPd4YMVWc3SVBlfAY+g+cViWhgcDTbpliqDTAwiC+GyF1Fu97AupEQYFZS4B7JmtLGXE47Zj2CZmgvftLmypQzkT8Y/+2kxL+HIS/GqNMVLyeacbZdAnr7KZOkMtbZRpAiyB5+JldtZyNPelN+Wv1er4WH+wQEEbS2Tb/71lZOmxLDTxUz1wbkzvXPuM9dbugGuhKUrx0O8QTJ0naod5p5BYXBEeiIk8pc/Lldqa5E7riQLRZAg3mqCH/M2jwE6oT+H0i6zOzuBmDzFGM06fWUTzmAU7DI4MoJxo9kCWz3ZvC2bpaTBXTGEmRIPQfM0IQkgayqSpRmHBXIwY1GAMwCw+lvQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4337.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(36756003)(6666004)(4326008)(8676002)(66476007)(66556008)(66946007)(6506007)(38100700002)(5660300002)(8936002)(316002)(2906002)(15650500001)(6916009)(1076003)(107886003)(26005)(186003)(83380400001)(2616005)(6512007)(508600001)(86362001)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: L1+WGQswp4bcdBHB0ZaofflPndC03uZ6tB+BYvdlZvMK9DF3zQ8EEtkxQXuXM0gbcsZsz+iAO/4drubtToe55ZDk59ey3brkIuCr+K+gp8Xha1n3tmeqPIsxzZTbmA4GoQtMfLI2MSY6VyWxBakcAA+UL4TagbHj1Gr+9gJ1DebCbNQY01mJse3gxSAu1TW5yG8KT1LCVHeSgLonTq6J8DrQxybKnuNx08aBnL7VqUsp7aPGM0YhLeDQvdGlvGQ0fmT3YiAFk4It4u/sdzbgqHC5gvVIPmlwZYH+ilualLosFNOQ6qbdKoIJy+NNiGrbuVv/yfjq04okxHha50FO1zGf3EWmrqzWU5XnTXL9R/PWCka2336XjAnSm8pLftaWa2EoplvUBlwb7TD0w4aWgPAYp+Gc+eXIwFw6sTllt1AtdDsojjj78nyRXXLdkQTihdbyCf4TChr55oVpLZdCcT7RhBPAKh1K+Btk7d2uQThXiKxe8u9n4ZsA6Hvqv6NS+cfwKTWMELgxCGvRpAiBeaEyQ93RsWJHkUcwW6bCMdCXescS9kJUfsJW3X8+9Ft8tUA5LIOY0Pjmi4p281OrHH6oFQAlLNlFcgtn0jLtISaxYfePQD7o4u/GLZmgzrslgtgxnK/dqjBgm4uesZQEosaGo8ZN+ygM/ETJwR+/ZkhqCM+kt7zIilJxqT57Jtsg3mtzh/eLn+Y4Ckb1UEEL/9nvOk4sYoszeqGVeeDIg3VlLXGcvRBagiuwWGKYrfh3m4z6KeKs/rehQIzedgfBIq2Stow8uTX+Fk6utus4rgKeuwzLqVrvOWlWwykBGOKIftoOl4GgLjAEl5uJd3Z7ciCQjfZOUeigiwmTT5CvnRV1p+d4Z0hd4+LQ2zu1+KRfpmIKdRNOheRSmi4G+o3QJmRXzNBdbLDCurPV77Ibzci/2+DuntV88xR6Z1SPXRczgSgySqTqRe5hDhrHWAJpBq2T6d5pd3iPcb4TXD6TEleOCvrfdthT3X5+5FiBkop6+JHFnVFIsjeFo78c9YwC0ixQTEpFKD3GiiXpmewbAZCx9+NavpguIHg3Q9H3z8CufyyNRv9lwrbWOePT5dE3NGN+ZpGGHhzYf+moYVWM/smIptkFuFDXSnxafFMUAEEtNzIvfcbzH9wQAxDGvmSRBzYZe5hh5jLePoMaCUsA1VlC24/tm8fxhYuk5rI9HpOuR+8mEyv+zUKOd8oORbX1MICESh1wFYxc7gtgLe7KjnDsR+UGn9Rhnl+oiEqvdoMESvV0jTFqzzAn+Xaw7PaxiV4f2vuC6s99dZDuE2AG8et6wgnxouddW8W57uk37KPaEkxMjv2zTMPGTBEJsWPk7pgxxX6rkh3pv+7Kt+xYIyvYSawxpAmGEXt5iPu5b0A/AXTdj+MRT1jpCpE9epp3+KhrsyolbMujbNVrN3vyyGIMNajEODcO/Io2T9nGoIdNKE1L/ymWwzOgkZ2XRSnvM8LO+QrLhiKCI4a6NDxmsbWsChjOwZvBJTTET1LDPHrcbfprryFG+2jwhN3hEA8ukH8pkR6tpj22+C8K9p3mBU80fiagDdMkGd2QXQ6P9dIVQmg+TAN6ADlcRImCMIHJRULJ0yKhfh5QgbxfyqWOXlOrSNoxnWgRfidmiihWI6CIJGUyQmTFkYjAfelLXklxgek5JlHQeY0l6F9NDM0gsg2b2D0sGkqlc40eCUxoCAYPhbQGVAZxE+rkV9E6Ix9yIw== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca10ef73-c9e0-41e2-58c6-08da1869a8e5 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4337.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:38:51.2612 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: io6DCnyIi6bJeKJcF1XkBVeLJwrq65nLiEtmkrW6CKtYI0EyWTO94VenP4UnumZNBGHet2GRj2oEnbNFYa9/8w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5228 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org For better error reporting to user space, add an extack message when the requested action does not support offload. Example: # echo 1 > /sys/kernel/tracing/events/netlink/netlink_extack/enable # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action nat ingress 192.0.2.1 198.51.100.1 Error: cls_matchall: Failed to setup flow action. We have an error talking to the kernel # cat /sys/kernel/tracing/trace_pipe tc-181 [000] b..1. 88.406093: netlink_extack: msg=Action does not support offload tc-181 [000] ..... 88.406108: netlink_extack: msg=cls_matchall: Failed to setup flow action Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata --- net/sched/cls_api.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c index dd711ae048ff..d8a22bedd026 100644 --- a/net/sched/cls_api.c +++ b/net/sched/cls_api.c @@ -3517,11 +3517,13 @@ static int tc_setup_offload_act(struct tc_action *act, struct netlink_ext_ack *extack) { #ifdef CONFIG_NET_CLS_ACT - if (act->ops->offload_act_setup) + if (act->ops->offload_act_setup) { return act->ops->offload_act_setup(act, entry, index_inc, true, extack); - else + } else { + NL_SET_ERR_MSG(extack, "Action does not support offload"); return -EOPNOTSUPP; + } #else return 0; #endif From patchwork Thu Apr 7 07:35:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 12804583 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FE0DC433FE for ; Thu, 7 Apr 2022 07:39:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241971AbiDGHlG (ORCPT ); Thu, 7 Apr 2022 03:41:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241970AbiDGHlA (ORCPT ); Thu, 7 Apr 2022 03:41:00 -0400 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2067.outbound.protection.outlook.com [40.107.101.67]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A3EF2BEE for ; Thu, 7 Apr 2022 00:38:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=frFeMFxVRiEe8DMCLO1j/BfTslqpzkJ5GwYdG2DslmB/wZrSuAjLJFUnSEIs3XqIUsu11hV1CLtGOBp0YzPMGzKTQq87TMlxxYx93euT4C/+h5JdJYGQuw47/7JlCyFT6R8m3YU+IuoqiW/ZOFS59ZToR/o+hhSpi/C6/nOAtAeaODI7VIxIO/MGKRFlcD5INt5dPeGe/fGaYaATZKLdm9WiadDq6l0Cx5vFYsL9zbl+JQXMDCLYqrgHND1K1je9UTVoZ9DCmaf/5jpADZFqKXzhEdcAGr8bthUwZc9FExQcn2BnZ1O1GwkYtqpGS6kSMg1sKbVv8tGuJRYyMhz2Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6krluR5BAwuAl6bt0zgFpEh+MOxt2TmdVoUxMAPFXd4=; b=aYYKw8UwNc0uPmIxkZORHr32VkyVXqNAmhc01Mmbt+m9eSnNy81zXnYOZEq+OCAjszbKq1X2TlJ+XmSguqFd9OsTgGS3X61AQO4r6lpV24UWEMX/hasiMIvTrkXGjaEqbTsE8s5EP7WEo78Zy+L/RxtmIHFkbJg7SUgHuyflvg8kIEgTg6b8x/9NUUImSrbTFvGct5viYYWavT3ee6CQ0nkiKRstpxe+3oGy7AJ3tt0vAFttifutCp+EJazQh45Kzqifybge/umOfqcVt7xSK/tFzLwzESiDnDPI+8PREiEOCu/bDIZTIp3TDuACoBiFERL654b/4NIuWAEb774dmg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6krluR5BAwuAl6bt0zgFpEh+MOxt2TmdVoUxMAPFXd4=; b=dALm2w3vMHENHFFSPsOf8xswqGa7apoyLzTr2OEEHaSGXrtkfY89q9MB4n0Q467+VKWecwp36tEzg1/v3qMXR7V9rZ7UxiQF7tHuY8BrrnXUybc4+fyn9ceMcYR3StZaOJR8MD8azs8hJrUT2GOCZiC4CptTdMUnTuHsx2jqWX+nPzstTkHAWKGROEx41Nj9Yr1Z44C8py4vcLgvXGLeGUxLUdL8LtcdzFZEMRcjjpqoxSj7STLbZ+3ZqMEysxA4HG9tbSXFOuWb4+m7vlN7KTVP15Yofa9WV+37R/u4Eq9LwkiY5fg/9aNH3IVgB8Zr1X7Qqby/XYVPTrMXgiBy6Q== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) by BN9PR12MB5228.namprd12.prod.outlook.com (2603:10b6:408:101::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr 2022 07:38:57 +0000 Received: from DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2]) by DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2%2]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022 07:38:57 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, petrm@nvidia.com, jianbol@nvidia.com, roid@nvidia.com, vladbu@nvidia.com, olteanv@gmail.com, simon.horman@corigine.com, baowen.zheng@corigine.com, marcelo.leitner@gmail.com, Ido Schimmel Subject: [PATCH net-next 13/14] net/sched: matchall: Avoid overwriting error messages Date: Thu, 7 Apr 2022 10:35:32 +0300 Message-Id: <20220407073533.2422896-14-idosch@nvidia.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220407073533.2422896-1-idosch@nvidia.com> References: <20220407073533.2422896-1-idosch@nvidia.com> X-ClientProxiedBy: VI1PR0102CA0040.eurprd01.prod.exchangelabs.com (2603:10a6:803::17) To DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 864919b1-65d4-44d1-eef6-08da1869ac76 X-MS-TrafficTypeDiagnostic: BN9PR12MB5228:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b7JrRGB+v4Lkrn+bPOXG2DaCaznNwtYZpHzzN7ko8X9FYWi99UFU/Zor8hlXGne4/lX/Kw//lmSIamGcWCaU98QnAk9LyJVNh65LYyVcizfYNNho6CoZCjKCoKQS6vlhVkjE0WEhG3K701cR+sFywFTYo0JbDBGpq+H73GW2jxpoZbU9Ok3GJzzSs2ChIgGAxQ2fnRFn4ks7flurpkaU0CmjTMTDn6MIDaDdHbse+wnGMJXIab0OVvc5oO1OJVD2OxRvu0++cUKIyLcEH6PX/TclVi2fcF6KQQ0bTxcixuQ6vjzMap8vX2NiDYnsQZVlcIG2E7/2Olw7bpRTPOhxQflO7Q7dLLNAUSm14dAx8GyBHygeWMxfSWtssn0K86uuCDqNXh95JXmyFOPheDlHUSDRzMH99SjdGP4aqs9dCTGeQ4mqBvaShaZD5W012ly4Xl023S+s1GeZaUGkuqGTAPGhszLN1PtMd73CRdQJwECNPxOtuRrMQwZDwzOlXhkukoXDGrVWwx2xteaSpAZHEVWIK5G6MooYc4tcNqBx7woBihtYH44DzmSash4ykhwR+1Evl8Uo3EXYonSR0d3ORUnPRgj8PRCuY8pXJ9HE1tzP1uKJtQhLxIDqgdI/w3cdXWowpWR1YnZxVSrw2Grycg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4337.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(36756003)(6666004)(4326008)(8676002)(66476007)(66556008)(66946007)(6506007)(38100700002)(5660300002)(8936002)(316002)(2906002)(15650500001)(6916009)(1076003)(107886003)(26005)(186003)(83380400001)(2616005)(6512007)(508600001)(86362001)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: c1VSjhp8FU9amA6mbOmWD6Pr+I3gegn4nvZjCwJZoiQszyseFVppnRSBUzjzpWgtQlZApK78kn9q5cgvjapmpR+TnAIyONaDyj3Rj6UfRljlLR8izA9bmxZrL/kGe0NuZsgvC1yUkaxMdAi2lpkmXAQkcX+9K8o+EXEhPiV3XMwN82hc2K0y41naeK+jGVLQxJg3eOSkMLuTYitTHBH7eOHkuQo3MCVxhfV5Hia2xAfEllpF11mGdprKB0Lv0vnuDN8rkV2FlcTV0oUPttlAmzCAvtxjHPVZslLhu2RZE2M/aV6RXBkCtI56WjDg043s6uW6XsGFO4rJPV9VzfLV3NOq2Hl796KOjGpTp8OSpt7BCLptjpI3fetmi88zcuJVYjtCTQapjB2T5RvfBjhgQ/QXCZwLuEHLk9R3p1CvUXh3sPwzQ+t0wk9YlpkKNTftXH/y0l5sEyHvTpGfGAimW52Oytb3zaL8+Qr8tBpn4hYr5dfJFGj0NoFgjRLdcvfy+jCY4FLt2/JCFJ1WMzfGXr5+4ui1SZ4f3NHb+ozLq1UmH3Z5S97YSoAH8PxCUk4eAKkPUfrGjI/LHKUYEjy+Ypi9L/lGjanzQR+gUvS2PdHYDxUTj7RD275kx82Fqwky3wFwx6z7vhF+RuRkowm2dlvGc2BaR64dkSMmO1qJ6skm0T7Kw4WPQ+Y573bAgcBsvMer7VEf4gXXF7s6stM+pb2yZYAWvvzCypWoH52VO1JLHsMPzT7lfqj4sOuilc9JRLVGagnz6/kWfvCQZwitYMMnYUFGbULCg8YqZr1owWWZF10qEA7Zgn+Y/evsAFoBz/hTxMKbg0rqnVSbHV+ca0Nnyq+DErNOEIyUbCgeZ8dZ6MiJ4/kpqaSbEXCHFOH9rO1065K0A8AzzyqCS55Pj6lxWxI/ggsnX9ccZA/ORCsLR9ZbrcMiye+89dno9+O32FuWXiZE++OMHeMKOa98LMy5uvcM7N4pXNg6HIH42vuW+MsrBj50ci22vilXlha7VH4XcQ7g6HuDZRDaymb/30A60Ov+LQAanELOe3Pg3Lxy5dfBRoKIQZ+Lnx8QHkaaUrJ+jmnbXgLiw+cw7Yq3jS41Ttc+Q3/bw9OYxgNHqC9BpdEAyQ0Dkf4im4P/dqJV8Hjja81D0/yKHj3yd1C89RuEYn8ekMZ20AIVWnXtz/yMvts2DcttKzx3/Ku54R61kYtf1uvt+v/t/rUkivpawRJhIsypScDXyBtoNBKJ9qp11nVOc70oWpLAi3wjrxBNgPoyjo0gYSmSy+fCWRwRvfWvbcVF2pRLKDwU2EzdO6xeKA4xNeRDoRXhJP0UV1eXvedmiqO7Ghoxuo86j9IZuhZvoqF1+/g/KCAN8nIhWi/TPi2KM+Vn1LE9AGzyvmaISPgw5NoG1aREiCst8z4RaXzYJH8Dy3+8cWZkgWcAsuyE14MSkU0aKkR5M97Z4jM80RinxIwLKcIaPySLs7ZKPVkWIZxnMlwZn1So4QDId8njg6txlAxybr/HTwSUDa8BBZxj7Fd39iOwPxOKPvq2Pinu8SXJUGbF5UTbqm/UGcdgCCddUFn25bjO4sxM+TH7YWYEDzi4utoG9KylqaFoGcWrEIF8keTUn1zf/xHfwMoKJ1vGeKMwUcszXJoyG3+q+ePc7SVXa/SqiEmpXiMRmGZnQ0r6+4LOon3YiJSImtZiE1QCXFv7PaV8rGcpLGksBnaVC0vD2N07BCsSdx35KQ== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 864919b1-65d4-44d1-eef6-08da1869ac76 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4337.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:38:57.1079 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: swhQxgY6wSkitYJ80s/UcZN5ezR81Qi7UN7uu6pZqaU+Jgt8LGRUQVoZ0nU25ZxSdZQ9GvmjCqvyj++54rftJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5228 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The various error paths of tc_setup_offload_action() now report specific error messages. Remove the generic messages to avoid overwriting the more specific ones. Before: # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action police rate 100Mbit burst 10000 Error: cls_matchall: Failed to setup flow action. We have an error talking to the kernel After: # tc filter add dev dummy0 ingress pref 1 proto all matchall skip_sw action police rate 100Mbit burst 10000 Error: act_police: Offload not supported when conform/exceed action is "reclassify". We have an error talking to the kernel Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata --- net/sched/cls_matchall.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/net/sched/cls_matchall.c b/net/sched/cls_matchall.c index 7553443e1ae7..06cf22adbab7 100644 --- a/net/sched/cls_matchall.c +++ b/net/sched/cls_matchall.c @@ -102,8 +102,6 @@ static int mall_replace_hw_filter(struct tcf_proto *tp, if (err) { kfree(cls_mall.rule); mall_destroy_hw_filter(tp, head, cookie, NULL); - NL_SET_ERR_MSG_MOD(cls_mall.common.extack, - "Failed to setup flow action"); return skip_sw ? err : 0; } @@ -305,8 +303,6 @@ static int mall_reoffload(struct tcf_proto *tp, bool add, flow_setup_cb_t *cb, cls_mall.common.extack); if (err) { kfree(cls_mall.rule); - NL_SET_ERR_MSG_MOD(cls_mall.common.extack, - "Failed to setup flow action"); return add && tc_skip_sw(head->flags) ? err : 0; } From patchwork Thu Apr 7 07:35:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 12804584 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AC33C433F5 for ; Thu, 7 Apr 2022 07:39:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241969AbiDGHlK (ORCPT ); Thu, 7 Apr 2022 03:41:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39050 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241957AbiDGHlG (ORCPT ); Thu, 7 Apr 2022 03:41:06 -0400 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam08on2051.outbound.protection.outlook.com [40.107.101.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 86E828D681 for ; Thu, 7 Apr 2022 00:39:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XE1uY9p1JhCfOdD37HaPJYyz8JyYXBiEGubGnCBu0BTDUoLTN3t0i9/PgfwjMkK6UNQT1McuLRh8x9ZciwO9ObQCaKPKWZMxQVDxkb8ZrDoWZEFWt8Szjo75dzRHe+LceSXxmMRgS4ro5wQn9rx3PeeRqyo2ELaYMYrsnAdgEfIWf6MpBgFlNrSqN8v9DZujqNW2z1Lv6I1AjUhsoDS29HyLSq1wO2Nv6w9v9k8N0hx7TUVQku7ubj7h/hcPXdW7cT0srHd5UDVZR2VeIO9oZ/dTiuKbeKStUuWLJeiu2q1wIZg5pJHXbzePBr0lTslO1cqnkxeDpIDCqohtirVHeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=btavt2/xzbLuqE6Uodcq3U4kRMBIJb8FT773MGPEBAI=; b=Ca/x2n4VVNXl9HwbK9/XDgjDpGPdlWivQtIWajNliQvZCbR9fe6IxL2qX6P/Xz4GriC47E9iQ1AcgO0yFYH3/vdTLPbLEmTSMFI0l9MbQdzxrjRKfsS/48bMFEl+qcOf5roKfCNbo4fFRfURXQEBUZy+4Dln9C+1kypWa8f+nCfDkXet8ZiurUoenuKn1DpwuJkcEizhWNylJuUZz+MK/VM8AHA1g/FLiAxTQielvo6iIIcWx3t2FZRFe2zOzMOUXno4JGAQsW4aO3YbcDccMAB18nIdh7U1w/UKRNVpgB7A3E0iCbQUfQQ01p4x8NYDs7KXpNR2ATCcpmjaKHSUoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=btavt2/xzbLuqE6Uodcq3U4kRMBIJb8FT773MGPEBAI=; b=eC7dKw3I65de6V/nQ9eDHO+LYGwErsVG5EvQNurs020XCDQa/WeKrDP8AtNuxfgs74ercNqRxGzpUQLViCpCw7ikkgTO82ACT0xjkB6N8I82h5zShxdV4HrT5rP0G5FUw59H1ag12kZoHMvUdOVEkCTYiAuy2+w4TtbJebMcwFh3raDnhgtyItnc8Yed3G+zzmT/u5avuTUwLW9PdUFlOXDDjQnTjgJQTNA6ppPlz1ecojupNcldCxGQ4rNresM3JtYn76IOp0UTPGGBgkqaC2LHrcqULwqzoJuyXLu44rzcafRgmItygNSc8SarVegA01xeFLdrMNRWEMObc/3nyg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) by BN9PR12MB5228.namprd12.prod.outlook.com (2603:10b6:408:101::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr 2022 07:39:03 +0000 Received: from DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2]) by DM6PR12MB4337.namprd12.prod.outlook.com ([fe80::4c9:9b43:f068:7ee2%2]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022 07:39:03 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, petrm@nvidia.com, jianbol@nvidia.com, roid@nvidia.com, vladbu@nvidia.com, olteanv@gmail.com, simon.horman@corigine.com, baowen.zheng@corigine.com, marcelo.leitner@gmail.com, Ido Schimmel Subject: [PATCH net-next 14/14] net/sched: flower: Avoid overwriting error messages Date: Thu, 7 Apr 2022 10:35:33 +0300 Message-Id: <20220407073533.2422896-15-idosch@nvidia.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20220407073533.2422896-1-idosch@nvidia.com> References: <20220407073533.2422896-1-idosch@nvidia.com> X-ClientProxiedBy: VI1P190CA0002.EURP190.PROD.OUTLOOK.COM (2603:10a6:802:2b::15) To DM6PR12MB4337.namprd12.prod.outlook.com (2603:10b6:5:2a9::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7b801d4b-0b01-4805-2992-08da1869b025 X-MS-TrafficTypeDiagnostic: BN9PR12MB5228:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2KktY1f6Ox3bMz5hDeRWqphU37Bxanpjvbz36ta3Sz8/597QM+OqFXLNBosg24MCmgyhAR5uO6v2IC/KBmgk0nLbzwKLiSM2Tpwk9qjXusYf57R0l3hBnGnVuzGFONG4PXoi/nUjD2SAntR1l0LeIb+bN3Ewf+gqFOG5VvxaxDCKGus6FEqX3bt9SVPQjoirbXBrgfrYnJXUhQVvMe32d0SZxlbg82OhDiU0NA4SBzoRrmYYf/E7fMVNsJTJejkkaQQZL58/wWJxGJ6VyIvCAKIkZDSJV7KcUkDbA9/1fzPkMPVOtwyDjwJFuVn/5E8SU91MRT8tToT/l+vhk35o7xnadEqf315+PtYz1PGT4++QpDx6xkafMUjN1wmHYqrr5DwYc9/JG+5ao2MAAfyDl259NxAtSd/+leJcpcwF9D6+qaoBsbVgptYzLwbqca705H8jSwBUx/BANl5YJ9I7NYr2lCkMfWRRKggCNtX/VKsjuMr/i6NSapoqEF78JzNcP81DF6Gzz82+19iXyyFjJSAm3AIIgwkSKQLonIvUnXa5bzrRib7DahYUsJGxbns3KyZh5/HcyscakCcij7v66d/S5pVNtpDl9dlqVerpo/pKBdY2VD3Yt9KeaDL43xhsNJz6KanKxI4S4B8RMlcxmA== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB4337.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(4636009)(366004)(7416002)(36756003)(6666004)(4326008)(8676002)(66476007)(66556008)(66946007)(6506007)(38100700002)(5660300002)(8936002)(316002)(2906002)(15650500001)(6916009)(1076003)(107886003)(26005)(186003)(83380400001)(2616005)(6512007)(508600001)(86362001)(6486002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 8En4tSsjyQoBFKU5oUadBSxmkNZH8akQzio60MhUkh8sIqqJKJ1Hu4AG4u6+OyblkuDaW+euUu6nqzwROeSz2K6t4VS/pDihgKvYFIIc7v+8bLl8hrVODoVYQ/CTC3bSl8W1tkkPwM+kv6LRIdEYmwfZZrf/0PT+gsIf+AiEJBtFpN+qghF0VtTlGDJfhdgY1moI0hvyLbc8myi0673P6Gu1dZqK1yLZOnbZfdAC+7BhUestu/VM5sHQ3W/AExQOMHmR6sk4SA+G5ORiNOGRA7MFDVTHq0TGMDiOBo529+IhZ7wB57Apc+E7Nd9JBlv4Os/p2NuTbxSE0jsMbGznm07wLl8/vL+W37okEuOAZPyTPfjCORs1cAJvTTQ4CqaU79Jh0mO8SQZ5EVNJNIW2UHcA/c5aN5LGb01Fc9IJTLx/C7+SnBOi6MyZ5gyJvLi3p8vQypa/ujujIJZES7xVpqhH5GuXxPs6VrH+bS/WNHVBTmA65fhD9cW1N3G/cuMIQqoucsjZEEpp8SaBPyXY+suTQ8yXD+uIYUKnKNoCoqM7yScOw4VV70DZtVLH1sLFJo9TWfFukV9GIq4MoblVPQbsKqxpjfZ2ikcdo9M60+dgrrOieKfMAkjORyCRAxydCFwH4y1Fdn2xBFGCzpgMrrlNeZl9bvr2GphV7FCWNpnwb0Pdk9nIEmY7kgBBUoP3hHFYebcKX1xcTA7jKk4USZ9z1INQboXGWYnO8Ajqpg4uzbSa6OYyGWtsfBTCUlbg/5nxz89B+zXCHLt8gx8t5ZAQFGwNBRnQiMtLzyoeqvpdcNFuhZ0UN8hEOWOSJ8ypD40u2tnXRZeiPc/4QnTGq9b2zAzclVp8SDgivTSwvexwVm8LUX78Khf6AhymwIZ2Yy+3nZzriVwX45Yt2imXgnhi2jVla3IlnIE3BnbNGmdZv+FAmBLT7ySOFrpSmRlRsM0LLByhDitxWWPDYmTR5YFOHcQPKlCIZnWPKzvYPPiC4aY76tVRY7XRSyWpV5fFdOFrQrbcV9BwCgjbw+UE+b0E2jL8wXKrSRS4EzWkU4IMuiEXFSZdzw1B9LblChXiQOYyDQ11rUWm9oItUGrfV7pjIa40lsqrD8vmSJra2spO/C2zNRil3wrbmjUUCfqBTW6xVe9LVT2MQFk4QgmeW5DKfUnUYSz6yCFL/eUlmEXaGHx5wur4lRDNhnjtwWcuyzTtcQ7xFZvdf4z7R4ObFsxwfF2TJ8yk8JljwzA2E73L4iVHqkY0wrwijs6SSWD0rBMJun8gFTU7gsznY5sBge/LKZGmBhCXwijuYi4QUJAvtCuzBK9RuGJraAiZ77wCVC+wTl8CAJF8HNd3c6AbJ9sPDyBH155fcmmu8a7+OBtr2nPgupIdAvDcIL84pcLVMh8yCn90uZmAbQTqSi586Ohw8B4RLnHYj787Io0u70hnX0istsH9FRT4xS6RN7dcCB2kPYZ0gt2T1nsLL2owclrEpNX3p3sZdOc60aNXhVGb0Thx0z/OdL1njt/14eAe+yXknnD2+o2tEdM6uT56wry8309VuvZV6Ddz8kErE/zpLAeyf6CpYM8Hd+BuCctAJxBEmIlW2gfIrpaES9+Psx8MrF4bXeyUpYiL6J4OSvw1gOQ6IjFp6zuPduHmGDY1ewiDOwqcxtfjWkq6dUW9XNpFa5ffnAhmV/Y+LGCAlg+x0pcoFXw9S7m9THFkdLeQ92Jk+ewY/X5Ik17nUbx3Lg== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b801d4b-0b01-4805-2992-08da1869b025 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4337.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 07:39:03.3141 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rZJ5HldIA087Vciww4KL+5wF6tvfitVLm6Jcr5wCVD8Bmx8SGYbDh8wlal8gXPMq+RyLDrgNnM14TemQvLgUyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5228 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The various error paths of tc_setup_offload_action() now report specific error messages. Remove the generic messages to avoid overwriting the more specific ones. Before: # tc filter add dev dummy0 ingress pref 1 proto ip flower skip_sw dst_ip 198.51.100.1 action police rate 100Mbit burst 10000 Error: cls_flower: Failed to setup flow action. We have an error talking to the kernel After: # tc filter add dev dummy0 ingress pref 1 proto ip flower skip_sw dst_ip 198.51.100.1 action police rate 100Mbit burst 10000 Error: act_police: Offload not supported when conform/exceed action is "reclassify". We have an error talking to the kernel Signed-off-by: Ido Schimmel Reviewed-by: Petr Machata --- net/sched/cls_flower.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index acf827b0e30a..87e030dfc328 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -468,8 +468,6 @@ static int fl_hw_replace_filter(struct tcf_proto *tp, cls_flower.common.extack); if (err) { kfree(cls_flower.rule); - NL_SET_ERR_MSG_MOD(cls_flower.common.extack, - "Failed to setup flow action"); return skip_sw ? err : 0; } @@ -2358,8 +2356,6 @@ static int fl_reoffload(struct tcf_proto *tp, bool add, flow_setup_cb_t *cb, cls_flower.common.extack); if (err) { kfree(cls_flower.rule); - NL_SET_ERR_MSG_MOD(cls_flower.common.extack, - "Failed to setup flow action"); if (tc_skip_sw(f->flags)) { __fl_put(f); return err;