From patchwork Thu Apr 7 15:01:11 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12805313 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A839EC433F5 for ; Thu, 7 Apr 2022 15:01:34 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.300861.513303 (Exim 4.92) (envelope-from ) id 1ncTdO-0000Vv-J6; Thu, 07 Apr 2022 15:01:18 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 300861.513303; Thu, 07 Apr 2022 15:01:18 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ncTdO-0000Vo-Ff; Thu, 07 Apr 2022 15:01:18 +0000 Received: by outflank-mailman (input) for mailman id 300861; Thu, 07 Apr 2022 15:01:17 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ncTdN-0000Vc-9r for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 15:01:17 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id 9261c03c-b683-11ec-8fbc-03012f2f19d4; Thu, 07 Apr 2022 17:01:15 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04lp2059.outbound.protection.outlook.com [104.47.14.59]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-14-jxtdQqawOPuZi6AuXWaE8A-1; Thu, 07 Apr 2022 17:01:14 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by PAXPR04MB9024.eurprd04.prod.outlook.com (2603:10a6:102:20f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr 2022 15:01:13 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022 15:01:13 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 9261c03c-b683-11ec-8fbc-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1649343675; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=F4Fy+HuQ1ahLRZkkeLjYi3ElgU7JhahZPR2UkCBKzmg=; b=FI5apdjok+WJLO3j8xoXfdDm4xB5+OGO8+hAlXpvnG3J/fqRjxFZQ+yTbFyJt4bjb7FDkI xPk7upn4GelO+jIgE6iBM5PDt8ej5jGLs/cFipSl5Ox0DZucvGuvjftBUpl7rpX8m6j4yK ofnKT3CztqL9r/812vVjDdxoST+3gbg= X-MC-Unique: jxtdQqawOPuZi6AuXWaE8A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vc/WwV4fq5NMpC7EaUqRWUmkKEla2Y89CH6g6ajz0b/bHsumcqwmBI9Ql6bJmB+4wl24DWKa0adWogLVuKsuRDuNE+mKjwVsB3V/2Gv/QIreB76KlwQhlA2kOAM35DSJbTPpdcHCQddMvu0oW9egjZrJBxsjs/VZ7CPLs+H6VxzPF1lCscY4ipj0j4i4b9DkaFcCv2vjXOw4zQT3MZx5IenES0wYg2irYONuVC9mQYjOu77eM2nVScmH+vUkpd22MfeGYZk9ObfHV5+P3fnKqH9Mwcgpfg5wVwivKDImycHaGe+JqwU4iINWSTb/MQTx2aydHfr4BxseGCKg50K0rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F4Fy+HuQ1ahLRZkkeLjYi3ElgU7JhahZPR2UkCBKzmg=; b=SIM8bWJAANGywSUWLnPNqrqvRUpl5H0E+xP9LDE3lLMKy7ITzum804E+V5O9bYMB1UBQX+KBBkGyolLaCviUTRD4wT4ymFhr2CmuUA+zwsY+hyaaK8rhc0v7/cn7veO8P3zpyFJW3FSXortlKUsGDQioe49PWdoDXGxLtSWSHpDgT4Q+Iw9QTTOtWFAf5y5gc2536n3WoKyaRShiGZWgrrdroYhaEE7z2GqyjZExYt2eoht36rjYsyLiEi3YN7xHzn2vqRnRGeghu0KUkGFe0mEkSABcMklbt+7GY8KVDiy/3LZAWJbYfJOu5EaAiYcfBxIaH/XklpSbb+VS4B6oIg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <56a57946-04f9-90a0-ac4c-17773347dcea@suse.com> Date: Thu, 7 Apr 2022 17:01:11 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: =?utf-8?q?Roger_Pau_Monn=C3=A9?= From: Jan Beulich Subject: [PATCH] vPCI: fix MSI-X PBA read/write gprintk()s X-ClientProxiedBy: AS8PR04CA0121.eurprd04.prod.outlook.com (2603:10a6:20b:127::6) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3eccde1b-d8b8-4bca-5418-08da18a77528 X-MS-TrafficTypeDiagnostic: PAXPR04MB9024:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /yxjJjLrwKjme6+bB7uiyadRRT/r1T+GQi4KN7S2vgLZUXyUd7jcubXI8pgXmKg9HMA7DhMdD5jm7XDdhD2XG+2SiPjCMby2nLeWkYM4d4nzaNGgLkZ5iVFWWlborq2+A4rGn/Ll96uxw4/HAtDikZpbMAcw97wCMq7h6OXLoa7gV3PMpzZYBGg9LCP02d5wsPwTIlm+pJWeKsjxUYy7z6gfaiV3KWE5/FMmoezWYs9A0KeTdRc91E37XOZEreyqpxLzvpWPExw6aHAB8RrXylUgwevy2hCsocLlva1e/N8gKbASoNvfgKIGgK3qn6xaK5r6RUcauQxsDk2B/vluxOWHQ3FsbTPAV1t8+/5/hoY8a09HWPDf7NxqzPjihQ41rSQOhmtSbYAZ9cWgRkl9zShT5+Fl9qp4O8kNJqBDXJC2JLQL4qBVNviu9BTJ8x4bShGzhqmkEJgWaMZVofOCP7lVWgyfTGVWYgiuJZWILIL2GE2/nuio6vpq5R/smEDieHIUlxXBbn2B80o3HC0PU1Qz17hfpi8Zp7TwL2y67RNSziBomOYvFWSMmMkRCDCaALh7R9DGjXOStskQ7/B/SSFp7xk2gCAajRCyqEYzhgT60c3qerZ5+Fq4Z0KrAN5fpirLlXC0oQUoM6POCbzdScln6MF/VUngdx0KElQhnEnu6aXVJ7fnMeDLLvcsxsxDYasP5qJio4yAfQ7s2LAoGMv9m8wu/vtVMQs9chL+dgE= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(2616005)(4326008)(6512007)(8676002)(6486002)(83380400001)(66476007)(66946007)(66556008)(2906002)(6506007)(38100700002)(8936002)(5660300002)(31686004)(36756003)(31696002)(6916009)(26005)(86362001)(316002)(4744005)(508600001)(186003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?c/mA3ptjpuZeUj9jMZEfgUiGYVdQ?= =?utf-8?q?xVb7RaD+7GO2X4EWR6SdP3jhUFFEddY/VYPlRzAiqtNIXaoaeT5PzgdG/NYTf5sbO?= =?utf-8?q?aLBSSjpvXHAy6iM+2ECSJOgoZqsYh0DHManx7pS6hW3xwB89avdjRqHBaRIPZytAA?= =?utf-8?q?vH4+DS+zrauSliqP25rgEtTwzdT/8Sc24HyKsLp/me+ZEHwUQIP6/OIQWDJqmWGTg?= =?utf-8?q?KrZeYmpytontm1fupCQRzZHEyiYVp2ykjN5OGEiSPLS7CMpg+Xo4Yc495DvsaR0US?= =?utf-8?q?UtLotEfRP5it8cX4YOiUNB8zym3QVjDI2Ob4VRDgE1BPy9J1ZzyB53c1MSg0nFSzB?= =?utf-8?q?DRKQ+vB1NBKz5O3ICbAGurVJrAJC1CnRcOHbXVSD0/nPmyyMYZMIAwJUDH9OCr8IK?= =?utf-8?q?wgsc7AdNEm06/EJEPom2mSuGf2ehomR9RB/li/+WoC9MkhAq/PRnWU0lxQ2+v70y8?= =?utf-8?q?eUJb8S1koDDBVZeYROllF53adfX2+PIa6iMYpZA9XlD/EGQa0FWEEkULK7xfkRKmE?= =?utf-8?q?QjcU+Ng+Jh67Pi7JBsfejPJ37KyiblHZZtdsJ+pT1XtU0SQKgnSdPTlyRVJ4rHyko?= =?utf-8?q?0f0/m+UnkySziObyETfIMC5MilvdwunaL1Tkb6UzLAjhD1XQpTl/PUU2taKWsNXjT?= =?utf-8?q?/Aib/ud5s88E37XhROTTk+V6jvyi0mWwgUW69mi1qUe6vGRGE5ZlAXzX7DCi6O5fD?= =?utf-8?q?QgRuSd0hJ9grIbiic1K1ojZQXesUMxUr5eR/UF+y1XzjAamfnh6Ni/DFtZEm32e0T?= =?utf-8?q?2pOpEOYO+oBdptpNd8uXUD6e0437NdYbTf8Mhq6vBVV0igdGb/zWmU/ms3uTxkdtT?= =?utf-8?q?jw/zNkVMg/HQiLI6kXGL+/tNK8ifnYiIyhF+lNwsw1KyQPQ+NRarKbI4j+SFbSwTl?= =?utf-8?q?ZkQl4RjMIfcHbxYoLCN7WxamgoXeC6OqfJmRT4skFQD2G5Y1LrySVl2SAOJ8u3nnN?= =?utf-8?q?ZRxufHknzKUDR/8aPOa/9udJrdVc0Ol8b0EnJ3Z3W35JkuiBGW0bKloLWaVee6IwE?= =?utf-8?q?XToBgpALO8EKCPO9dJSPt42AHPD/UB5RbCVSELUhpglp0HMvhPfXjWs8b4iC5orEW?= =?utf-8?q?Q4OIpow815zsuJzQkATTc675HR4uXloOV6kKUP20gwI+qmyceR6TJ2iHXNO+HYO+x?= =?utf-8?q?AiTum9A4NNycystSkCaA+Xhk0v91nnO9iZp9tl0d9v+7VTa0yEiHYVh18TD7hqFXb?= =?utf-8?q?2tz/8m9wDH5d/ljyS9YRq6VmgqGoW8lyOVEVs4WN5EoawO9DWrn8sH5QWs6RQmR7H?= =?utf-8?q?2zF+h0YrIbj/cCyHx8nvjRZNCq4lt1+IagrP6W9alSB6ajZEc3quEBcDfs43d1lHZ?= =?utf-8?q?Uk70l+GZdZ3J7T7tujbDUNJJJThbFIv3azQHh0aAv9TP/FitDcCu8rJhidzUmmyGw?= =?utf-8?q?rFEOgs/MfQrt86vAVJeE3wjl6SFhfcIM6Zg+sqE+2f8oPDYs92bN+54kpUWSEpu0h?= =?utf-8?q?nOMV1Ji3oRxjT5MMpr86xpSftkkpfXLktX70PfYljcpB5lfNAeNlRog2tq3r8D1Ep?= =?utf-8?q?MPkPJ0vI8RukIiQB3Zp5hBzuQrzc+QhWtp0NdcC79se7RZaxEvIIqlt3DCf1JNRW5?= =?utf-8?q?1gPMLI2g4bjPUQJBikqlu7RZtb54+4CxUeluXFHtQdXG/DxQuJrLJyD86phupL3y9?= =?utf-8?q?KtamLPz3RL1ZWyfCGAFsz0O8vWchdH7w=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3eccde1b-d8b8-4bca-5418-08da18a77528 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 15:01:13.1622 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LNW/Aj2/lhmQX3o9okIafsZKG/yGY0OHqoMdmojGYZ+JSBxB8itmacedBnUvl4ArWwlmGzDjLfNrB4Fb6o2P1A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB9024 %pp wants the address of an SBDF, not that of a PCI device. Fixes: b4f211606011 ("vpci/msix: fix PBA accesses") Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné --- I can't resist to say that this would not have happened if we hadn't made this a %p extension, but e.g. a %o one as I had proposed. --- a/xen/drivers/vpci/msix.c +++ b/xen/drivers/vpci/msix.c @@ -247,7 +247,7 @@ static int cf_check msix_read( { gprintk(XENLOG_WARNING, "%pp: unable to map MSI-X PBA, report all pending\n", - msix->pdev); + &msix->pdev->sbdf); return X86EMUL_OKAY; } @@ -332,7 +332,7 @@ static int cf_check msix_write( /* Unable to map the PBA, ignore write. */ gprintk(XENLOG_WARNING, "%pp: unable to map MSI-X PBA, write ignored\n", - msix->pdev); + &msix->pdev->sbdf); return X86EMUL_OKAY; }