From patchwork Thu Apr 7 15:04:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jan Beulich X-Patchwork-Id: 12805314 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5628C433EF for ; Thu, 7 Apr 2022 15:04:31 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.300867.513314 (Exim 4.92) (envelope-from ) id 1ncTgC-0001B1-0a; Thu, 07 Apr 2022 15:04:12 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 300867.513314; Thu, 07 Apr 2022 15:04:11 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ncTgB-0001Au-Tq; Thu, 07 Apr 2022 15:04:11 +0000 Received: by outflank-mailman (input) for mailman id 300867; Thu, 07 Apr 2022 15:04:09 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1ncTg9-0001Ao-NY for xen-devel@lists.xenproject.org; Thu, 07 Apr 2022 15:04:09 +0000 Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id f95b85f9-b683-11ec-8fbc-03012f2f19d4; Thu, 07 Apr 2022 17:04:08 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05lp2104.outbound.protection.outlook.com [104.47.17.104]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id de-mta-4-QBmmBVfaNqWFMzeG0ggKgg-1; Thu, 07 Apr 2022 17:04:07 +0200 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) by AM6PR04MB5175.eurprd04.prod.outlook.com (2603:10a6:20b:e::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5144.22; Thu, 7 Apr 2022 15:04:06 +0000 Received: from DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::914d:e08d:7798:8476]) by DU2PR04MB8616.eurprd04.prod.outlook.com ([fe80::914d:e08d:7798:8476%5]) with mapi id 15.20.5144.022; Thu, 7 Apr 2022 15:04:06 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: f95b85f9-b683-11ec-8fbc-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1649343848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jnqZVrwb0NaHLt4TFQFuycfDG5MtXpUoN1vga+mT/TI=; b=kKjl1GQ8WhKJ67h3CHP4eUVY2aGFSmIPqVEKeMERcYhOe/dxc3H8sV28dXd/5NxpMw6jtx 4WvT655MHodlgXt0EXhcXruOfDzavt9XpLHWbdLkhx+Wk59ImbXxo7vxD9Ntktr6zA5mje jItNeWRiDJG+vuEYhbh6SkUPBX2uUqE= X-MC-Unique: QBmmBVfaNqWFMzeG0ggKgg-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ctd5KEB8eG+/JwkDf9kHU8c9fQVPd0LtEwkSBtn0xoAe1OSruBKVpiC3bSiLml7A2jPuRLFRD773PnWQUuO0wSyTSHTcfvl0QMYU8OzlXMkzH9kIGYQBUT2e2o29IF4ShlIVfsLDyG733Cu2p9pmqq/eTe2xIu8Qvv+TnpmV1P/nOh5zh3GCIznAQdCL4xFxrwvRDNOSuQQFg4wcBK0hOicfsxbcsp/0CfBtXwLxKXOJBMmeXeEUVLOG14gAX/gT75KGuvpOkmlcOkvv0szHC6bOGi+gdGPWURb0Tq+lRcu3BpDFwt0E+mBi/2DIzTQPSIp/SUYtn/YYMf50+ziuZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jnqZVrwb0NaHLt4TFQFuycfDG5MtXpUoN1vga+mT/TI=; b=fpuKatJ8mjRr6S89zgKLMY6LEdEpy+vnganUa6SuNOUOZXrJZHHyx7WYGp8wytQ/AfQN4t2N/HnKAk3GktUcdB4X+/3UtM6xtUBUHHJbwQnZlxXXEBG7YnQLne9D4M90KJFYIOaffbhX8plfYsFWWmzoHawN3vLNQRgMGmR9UjIVtRC6h8bpc9I2S+jG3lR9UNQQW+UefWhl1OdRflhstkOXg73LS7aTR3lLXLqB3fon/OUoiMKZ6BYdd3TH5t+rLnFS/B0qrt5kGLch1B7RNIIV6Q3KYwH00GKYfgwlS5u69AMpWSGYVjdL82PlGulpFZWOQzI2vvyZS2sEdMEdNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Message-ID: <36f65270-8807-323f-c1bd-d14dc742ee74@suse.com> Date: Thu, 7 Apr 2022 17:04:04 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: "xen-devel@lists.xenproject.org" Cc: =?utf-8?q?Roger_Pau_Monn=C3=A9?= From: Jan Beulich Subject: [PATCH 4.14] vPCI: replace %pp X-ClientProxiedBy: AM6PR04CA0018.eurprd04.prod.outlook.com (2603:10a6:20b:92::31) To DU2PR04MB8616.eurprd04.prod.outlook.com (2603:10a6:10:2db::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b0420552-44b1-4599-697f-08da18a7dc48 X-MS-TrafficTypeDiagnostic: AM6PR04MB5175:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0iPuvNZGeZOHarYgmVi67ImqGdZKB/EWdOjasYaCG3/ihWD6gwBkmuKxap2MktInWODRbrNsnn6zIX0HlmPYh5cZlokcUMxlqcvX4VioSIRbyxIgsPktIxp0Oo78oIShalJ3fn13CUIeYAKJLBnlcvXyUKUrT/LsHsCJDW6xC3vjxwKbY9+7cc6e6jF4KYBCobSrdW6wsifDatTKE2uXuEJ23L2bn5hR0iUJWGUsoigsyIJSSSg16yRwAFHcDJKK0N4gTmQWZ/ZtjDQ4bjf86BJr1ELCXQw4ctjYMbw8TcNQAHWUPM9afvkzkJQ6hC5Oc223/Rt2KzUg8VnDpooqk/V+2P8LmRCcalAP4mdKfDZS1dr25kVZ1HyJnNhmyceYAIiyWChwR2omnRKuMZX2i3G2CIABkPU9lM4l/LR2pNIysM74eVsmTzB1tyqZTAgtSkVvJDzj23cbaVbOX0tuY0V7vCMAKoFomBhJZGzBboV8Rg5zhTP0k8HVnSO94c9cnnUmTDHZr3NcrPb2Wd/Rup6khBsdEY1Ig8yxg2PApGQ2ibJ++kVaAC83TTnqUYmP+7GKjhpr8sYqvcpxMgAeOI/ajeHjtlaEOFV0dgY+xYzgJ//HrB3xqfT1w7zudTQ+F0+CSXUodaqlkfKHKrBBtr2KT0M8dUiVMRPPAfzYQnkgDHh5ndilEjXrH+vSiKK3BLfQ34u5Hf6QB0zuhuNaSB+PlFLrFUxOD0GhQJvE30IlCO6+zEKpX6HbwpcPNAiP X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU2PR04MB8616.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(6506007)(316002)(38100700002)(66946007)(66556008)(66476007)(4326008)(8676002)(86362001)(83380400001)(31696002)(6512007)(6916009)(4744005)(508600001)(36756003)(186003)(2906002)(31686004)(2616005)(6486002)(8936002)(26005)(5660300002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?58fPnGJoco2gty/6huaf+4uHTiaf?= =?utf-8?q?Xo/FdtAo8Hpz92BpI8JGjN4Jfb1P/WOxMEVpR7tMwdAyyowE3U6k9PKdtJmEvwal+?= =?utf-8?q?kZj9aFlDrqz4Ay5XenqCynDwae+i5fQm9j3+69EbjC4WD7+DX1Dk05oAYXLqYMlpH?= =?utf-8?q?rM7qy8Y/cgAUwoSy9dvQ2/3mvE9umDCRC2UaC7Z1an5fkz7LWVnQqDPCbfVRQBMoP?= =?utf-8?q?AvpLoqh9hh/cVW0zaw2AsSJUcErsYW+ECJT9ZyUv6DqtXzoDghW7z3m5rxcIlGFIO?= =?utf-8?q?Y/z1cJDSmoSzBtxf//qmlWq/OalXbmWyGTASEW2V5mZK7CAdIhQHorsULiG7cC2fc?= =?utf-8?q?EoUvNKmrjKnEbj3Lr63BPvM4unG4kjteJH2ojbThrVUdjgkSNlKPsZIDir1/z+jwc?= =?utf-8?q?N8PlkgIIjoQr2Us57/In4CGvavPmhKA08dpSDF/72XwF62uQXH1IrKHwmeyfaJYX3?= =?utf-8?q?BO57DJaFk1OLam63Md70y8JrukhwdapcBDrvuYMqx8L29FJy3ZD256cKZySVOoKMl?= =?utf-8?q?gkZUGay7wNg27yfhK3xKA0EfTvcrymHY2pfTZ8bJNtxXm9np00luVN03vOZdOg474?= =?utf-8?q?lyk+DPNTTktCbSWq8Wf9b5ZJ/ihQDBIwK7CWV5YcKJKTAopG2rvXFr5OVQS1Z0trw?= =?utf-8?q?Mp91kLm1x2iIMwzM681pBMjSvv71nBdx/L/sWKcOTXCKBQCqXkqUuE5ejtgKxtyXE?= =?utf-8?q?EminwQVDDzrmWMFA3KlRaJj6Dq2QtVxRbrluV0OVWnU6tQTx9V6GsDOWqkJRVST+o?= =?utf-8?q?dFU6gXWHFlO1byuNznMG6NZvgdFpgEIdpLJ/L0S/dPOCYCVYU5ySRwzUGC1XoUUwC?= =?utf-8?q?QQ5wArMcDpEyNF5RpNnBKaalB0iWguqwcYi6v7v3nCU4HlSUDxfckZXi1NAIpHOV9?= =?utf-8?q?JlXeEEPIBfC27R8JR/1tnJngx2zPBRV4ptT7DRdCh2pz61ozvEM3/GQuOkb0g4q7T?= =?utf-8?q?OZHIE7WXnwGT9ACPFvVux+pUVIBojt59LbDzY1qwQFmORWYlw03qTTzL2yieoYLdx?= =?utf-8?q?FGciIT/6T34OpW71nyDwfjpPIOPoHDNDhDGi3bMzgEk9R/vw/gSKfY2tTR8LiYiyY?= =?utf-8?q?kbwjohnZU5uK16FntDaAI8O8AG9i4jpTTPTz39zlQasjeaPwEFC2NHO57LIhbkhhW?= =?utf-8?q?XxBEDU5LyqL/ivtgRvFJ58Mz5ypWZEsQ49tWVRohPLzAZvr3EMjpmFndxwDOU3qJ2?= =?utf-8?q?9IkgeQUwpIUcybE2ZOmjDMwkY5qWH67YE/SUBOSrpkk9Y/TYuAxgNnBPDDdOJ57/u?= =?utf-8?q?g4O16vhijtxXdEiwk9lq7Esv1ZG1EsKozVZSAEA8tBnD9hBROAnE6rnnGrJFAp/DR?= =?utf-8?q?TyWFlew+hSdJhW9mTARBRdUxHCcninlHF5UwHpKneX2PD5fh97t3qpybm7UJXNvPw?= =?utf-8?q?rbtIYSH5ivOE49BbUKoK/NzSBjbhXj9m75p+XwwDPyWpbYDhlbFMuau78vyq03z0Y?= =?utf-8?q?ys/7KluiP/42Izn9LQzaniO/kLcQG62icInCnSSX+4S8L4LpG0acrfVD6pO1u6dCY?= =?utf-8?q?GfypOg1o/OE0Sf9W5cv3cYaTXj/ADS07Qw5dmr9Y4/xjZYcddEyEazrD8aoSC4RK1?= =?utf-8?q?kju6m5fMa4BzLfq0seFjqZVhrzXED7URSNdnFUGYVxqy7rfM0G2UisGlzzaC9iS0u?= =?utf-8?q?0KFhU96aqZZaACzeJWioERWjWR/m5pDw=3D=3D?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0420552-44b1-4599-697f-08da18a7dc48 X-MS-Exchange-CrossTenant-AuthSource: DU2PR04MB8616.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 15:04:06.1778 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fQSvxwkFYST41l9VWqEyFLUqp5Aq864bjtFqwJpB7nZQdI18jC4QREJLfU7u8G0Q0fGygNBJ7Diq3+H8R8Z2yw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB5175 4.14 doesn't know of this format specifier extension yet. Fixes: 47188b2fdcc6 ("vpci/msix: fix PBA accesses") Signed-off-by: Jan Beulich Reviewed-by: Roger Pau Monné --- a/xen/drivers/vpci/msix.c +++ b/xen/drivers/vpci/msix.c @@ -258,8 +258,9 @@ static int msix_read(struct vcpu *v, uns if ( !pba ) { gprintk(XENLOG_WARNING, - "%pp: unable to map MSI-X PBA, report all pending\n", - msix->pdev); + "%04x:%02x:%02x.%u: unable to map MSI-X PBA, report all pending\n", + msix->pdev->seg, msix->pdev->bus, PCI_SLOT(msix->pdev->devfn), + PCI_FUNC(msix->pdev->devfn)); return X86EMUL_OKAY; } @@ -342,8 +343,10 @@ static int msix_write(struct vcpu *v, un { /* Unable to map the PBA, ignore write. */ gprintk(XENLOG_WARNING, - "%pp: unable to map MSI-X PBA, write ignored\n", - msix->pdev); + "%04x:%02x:%02x.%u: unable to map MSI-X PBA, write ignored\n", + msix->pdev->seg, msix->pdev->bus, + PCI_SLOT(msix->pdev->devfn), + PCI_FUNC(msix->pdev->devfn)); return X86EMUL_OKAY; }