From patchwork Fri Apr 8 11:09:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 12806428 X-Patchwork-Delegate: daniel.lezcano@linaro.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AF27C433F5 for ; Fri, 8 Apr 2022 11:09:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232080AbiDHLLe (ORCPT ); Fri, 8 Apr 2022 07:11:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58300 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbiDHLLd (ORCPT ); Fri, 8 Apr 2022 07:11:33 -0400 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 052711F9 for ; Fri, 8 Apr 2022 04:09:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1649416169; x=1680952169; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=IqnIPBsHWhvZbm8kM51kc2kEYT//7sWoxLqS4RXRUXI=; b=dfxjDe5ct3P7tSET9ZTcKWvchDS5rWD1FvZ8IWdKgXgS8wAME/IhXFpc VwgYosknbPyEcur/Gw7vc6cd1BJ0Fb52j+iaZ8hJtFbsECkfDYvILB9sT PoVIEz1GIaxpMa2Jqqbg324luj+YSYPgE6G+YO1UnKu3fpAzZ1VWe+hKA COWWDoaxHTd00PyjDpiHeuDkVv5QOHmd/NjhkU0HMTdiiVI2hxbkPPwBF oLhTegi2Oi9U6y3VRWcQc7UED+GpNNUmv/Bx9DJLhbUIkw1sq6GI+rinI 0P51KHTmbBQyOtxs0xYVbIP4Zl5hGIVX0XTveKD6aXuMxFMQGqHJUMD63 g==; X-IronPort-AV: E=Sophos;i="5.90,244,1643670000"; d="scan'208";a="23186343" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 08 Apr 2022 13:09:25 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 08 Apr 2022 13:09:25 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 08 Apr 2022 13:09:25 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1649416165; x=1680952165; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=IqnIPBsHWhvZbm8kM51kc2kEYT//7sWoxLqS4RXRUXI=; b=GjUw6kxmTc5yuEhvC4CFnvowXbhuug0+2HRAncY0MhS30maYSWXCjPeq PmQ2KiIh41ULg3j28VSSZRdetACwPhetnNcRg+/WVXi1pzFqPqykx5zt+ 4cBskVtTq9kOK79kOwg2YUCNskukyTZR7FBmY0QJj0np1c+gP8eqskEOy +pce9mAii/ecFI7NygB8oTMkB9xyVHyWlD9tloDu5d4WdaGmxMNiAoeWe veRllRES6RmtDr1/xQTq4TzpjNzMJcRFXEvUi9E5YxnN3vEXdH/4b4D/5 u9kcyFgwAE3vA/GoSGEFelnSmhAxw+uKywpRLzbmriiQLkeZMafZ2w/dD g==; X-IronPort-AV: E=Sophos;i="5.90,244,1643670000"; d="scan'208";a="23186342" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 08 Apr 2022 13:09:25 +0200 Received: from steina-w.tq-net.de (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 3095E280070; Fri, 8 Apr 2022 13:09:25 +0200 (CEST) From: Alexander Stein To: Daniel Lezcano , "Rafael J . Wysocki" , Amit Kucheria , Zhang Rui , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] thermal: imx8mm: Add hwmon support Date: Fri, 8 Apr 2022 13:09:19 +0200 Message-Id: <20220408110920.3809225-1-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Expose thermal sensors as HWMON devices. Signed-off-by: Alexander Stein --- drivers/thermal/imx8mm_thermal.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/thermal/imx8mm_thermal.c b/drivers/thermal/imx8mm_thermal.c index af666bd9e8d4..ca8e2c393030 100644 --- a/drivers/thermal/imx8mm_thermal.c +++ b/drivers/thermal/imx8mm_thermal.c @@ -16,6 +16,7 @@ #include #include "thermal_core.h" +#include "thermal_hwmon.h" #define TER 0x0 /* TMU enable */ #define TPS 0x4 @@ -176,6 +177,9 @@ static int imx8mm_tmu_probe(struct platform_device *pdev) goto disable_clk; } tmu->sensors[i].hw_id = i; + + if (devm_thermal_add_hwmon_sysfs(tmu->sensors[i].tzd)) + dev_warn(&pdev->dev, "failed to add hwmon sysfs attributes\n"); } platform_set_drvdata(pdev, tmu); From patchwork Fri Apr 8 11:09:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Stein X-Patchwork-Id: 12806429 X-Patchwork-Delegate: daniel.lezcano@linaro.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 709BEC433F5 for ; Fri, 8 Apr 2022 11:09:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232066AbiDHLLh (ORCPT ); Fri, 8 Apr 2022 07:11:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58378 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229487AbiDHLLf (ORCPT ); Fri, 8 Apr 2022 07:11:35 -0400 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 810FF1705D for ; Fri, 8 Apr 2022 04:09:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1649416171; x=1680952171; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DgXZH7WbSxWernALJcj9Fpx8ZlVIXSraIrzfrlCm1qs=; b=idm5KyaR2Juw1Ru3r7W/v64mMVr2CLryT2LlTGtCxUdFCNDvFXzgjH7i oTG9JtE2SsujiS65GXcgWg9caAvDjwtoHlTL84k9718k6sS/w6L/iLlGA n1q3wCCrh2luP7lpBz8A7zdvv+UbnyftKLaD8RPXd1s21LlJ+tDXVF2UI FO6LAJtHxCORkcWjIG1n08556i1z8acKooLs7LpBDJaQXyW67qoQLu1gw JQTr0A8o46wV/mgiKKv7ErhTBY4gzzAaF5hskdhvmLGpogs6aI29dLRVz +vdhuA/ut4PW/TKk6AXnPmMPySPmp6Qg2JIsZmw8OlYXETMX6+G04bH5d g==; X-IronPort-AV: E=Sophos;i="5.90,244,1643670000"; d="scan'208";a="23186346" Received: from unknown (HELO tq-pgp-pr1.tq-net.de) ([192.168.6.15]) by mx1-pgp.tq-group.com with ESMTP; 08 Apr 2022 13:09:26 +0200 Received: from mx1.tq-group.com ([192.168.6.7]) by tq-pgp-pr1.tq-net.de (PGP Universal service); Fri, 08 Apr 2022 13:09:26 +0200 X-PGP-Universal: processed; by tq-pgp-pr1.tq-net.de on Fri, 08 Apr 2022 13:09:26 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1649416166; x=1680952166; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DgXZH7WbSxWernALJcj9Fpx8ZlVIXSraIrzfrlCm1qs=; b=W3qM+hKcvN+v7GKu+0DlpUleHmypsfZJIvozJgONU/PwYmlblgWR0yjQ 8bIhl33KPcNJ5mtSYb9U+nNM+bdHeGfVvoHZJGQAko02m8sL68P/PhoR5 WyEsL0bDk89vNyE9XgDlWCHUFzOoYCcGpOY7N9J8KCcS+PBxEk4B1gBY1 pJSfyMCzbucKBiYcBxDEcfDByZzKNCST7GIULRxvIaj54ZVVB1uVfWscE YMfjO28naYmxDU7Dw52E7PTD76ETLiinPz9w0I82hbwp8hrU81d+yDszY t1ew3wdTqI7z/vDDnG9c7aQBzbDzTaw3u6CnaGCAU1xT+bD2bJU45RjlV g==; X-IronPort-AV: E=Sophos;i="5.90,244,1643670000"; d="scan'208";a="23186344" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 08 Apr 2022 13:09:26 +0200 Received: from steina-w.tq-net.de (unknown [10.123.49.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 694F9280075; Fri, 8 Apr 2022 13:09:25 +0200 (CEST) From: Alexander Stein To: Daniel Lezcano , "Rafael J . Wysocki" , Amit Kucheria , Zhang Rui , Shawn Guo , Sascha Hauer , Fabio Estevam Cc: Alexander Stein , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] thermal/drivers/thermal_helpers: Adjust output format Date: Fri, 8 Apr 2022 13:09:20 +0200 Message-Id: <20220408110920.3809225-2-alexander.stein@ew.tq-group.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220408110920.3809225-1-alexander.stein@ew.tq-group.com> References: <20220408110920.3809225-1-alexander.stein@ew.tq-group.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Outputs like this where -1 is printed as unsigned is somewhat misleading thermal thermal_zone1: Trip3[type=0,temp=48000]:trend=4,throttle=1 thermal cooling_device3: cur_state=1 thermal cooling_device3: old_target=-1, target=2 thermal cooling_device3: zone1->target=1 thermal cooling_device3: zone1->target=2 thermal cooling_device3: zone1->target=18446744073709551615 thermal cooling_device3: set to state 2 With THERMAL_NO_TARGET assigning -1 as unsigned it make sense to print the target as signed integer, even if the type is actually unsigned. Signed-off-by: Alexander Stein --- An alternative would be to change thermal_instance::target from unsigned long to long, but this would entail a lot of API & driver changes as well which looks less intriguing. drivers/thermal/thermal_helpers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/thermal_helpers.c b/drivers/thermal/thermal_helpers.c index 3edd047e144f..0d0da6670267 100644 --- a/drivers/thermal/thermal_helpers.c +++ b/drivers/thermal/thermal_helpers.c @@ -199,7 +199,7 @@ void __thermal_cdev_update(struct thermal_cooling_device *cdev) /* Make sure cdev enters the deepest cooling state */ list_for_each_entry(instance, &cdev->thermal_instances, cdev_node) { - dev_dbg(&cdev->device, "zone%d->target=%lu\n", + dev_dbg(&cdev->device, "zone%d->target=%ld\n", instance->tz->id, instance->target); if (instance->target == THERMAL_NO_TARGET) continue;