From patchwork Sat Apr 9 21:12:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Drew Fustini X-Patchwork-Id: 12808043 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (unknown [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3804C433EF for ; Sat, 9 Apr 2022 21:15:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LoBnLzpJ9yjefyrDREZejkMiH2NQMWmxAPo6DqYK488=; b=ARAT/PeSz1mzdB qCgM7S0QGJdfWDTTFJDTJ3SLM73S1er6HGIFz1Wxw23sUY+CT2xzz+HwEuuzIxN5qZOo5vZzoqLda ljX82sys9aQl+/71dF7mqVu9mbdjx7MqSF8jY2LLLBQT8h8DZMHS/ndgbffXDA0H0uKfd6jamLeX4 h7cWTmh3dP7WCRjRqcdu9AwzhW//At4Yck+YCCn4XpdBjQkDOqsJ703UlOKc7HGb2yjp7MZEY7MVP 3GpE6yuPKapfeeCEfHy0AAw20LcFJtQoS/vcMxZeeet20Zq33OAn28xgKWzGBSbyspABj/Qv+D8Ru rhBX6p6jnleVaJj4WH0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndIMw-003nJA-DT; Sat, 09 Apr 2022 21:11:42 +0000 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndIMs-003nIH-4A for linux-arm-kernel@lists.infradead.org; Sat, 09 Apr 2022 21:11:40 +0000 Received: by mail-pl1-x634.google.com with SMTP id j8so10813447pll.11 for ; Sat, 09 Apr 2022 14:11:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Y7L2Rl1Azs1qdyPqBYsqG+p3Elwf/l1kjj+FLiYmbT0=; b=DSlovrPyKrzRMXH6RmU9rxtzpuENFrLHzZOcjwuGHTEYFCWIVPC6xpiAY44LMxxp/m a47mFuEjBqpIgr6wdSujSp6VXedgqKs7meLk31oA4WXJTV+Q9RJ61nFW37J1TbhA6wFp FGOD99F1zvudg/Sj5XVOdG3DcdPWqYgX6F8juZ4bkJhZrHQ83dRcCrm2T2AYuA3/Epyd nonGKxiEVzFJ5/TWnAR9ipkkESC2vfX8P0lY0OgU2nkKbUdCdS2HPDvlrgL6I4ziVtl4 uJMvko0Sw9L6vopyQtfKtt4PIpCIBmDZ0AQM4W3/SECmghK/UtmGSkjtquvC3y66VXdA yn7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y7L2Rl1Azs1qdyPqBYsqG+p3Elwf/l1kjj+FLiYmbT0=; b=azxewdrctKhxYHOgWMSbFrXrq2Bz4x7vXS6xXj6CMjy31kFBKzSc+jwsr/XsPWZuyq 6yJTcC2RneYsrmFe5zj/rXU8DlSZTvAYhmdW4K52wBToh5lEY3QXkFjxFVmQjkTKFN+8 RP4DBi14lMbAAxjEGbLpfMAy9FhOJePFAeswPF5dWYdh7ocDbscY8une8jBufTiJa+22 a3aodEQOzE8U3/z2K9GKpIIYH5AtSe6EWrVbwvRCu5AHu7+LyvIHOYv4qyTkXYD6KDnE Ja8Fr1N88iRT43N7oLfwHMItf+quTp2gZhaR8XtYLsGdc6WZNCzqQOpgjd4CJK1d1BRl mooQ== X-Gm-Message-State: AOAM532hTUBKTWYvpLWP6tcQ+56OrXV74asWkJMBNHMPJCDjh7LIlE/h s+3DnA2ybw0egKKtJaGxNvo7RQ== X-Google-Smtp-Source: ABdhPJw5Rq+GTknDzXhuTRZefTu+M6QpC71rPXCKCsZk3sK1J0SV/wvRnzaw7+WTiuuhP1WBn+uB5w== X-Received: by 2002:a17:902:ecd2:b0:156:9992:5892 with SMTP id a18-20020a170902ecd200b0015699925892mr25158352plh.7.1649538697093; Sat, 09 Apr 2022 14:11:37 -0700 (PDT) Received: from x1.hsd1.or.comcast.net ([2601:1c2:1001:7090:925c:1a60:e433:31b7]) by smtp.gmail.com with ESMTPSA id w127-20020a627b85000000b00505a9142ce5sm1393295pfc.22.2022.04.09.14.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Apr 2022 14:11:36 -0700 (PDT) From: Drew Fustini To: Rob Herring , Krzysztof Kozlowski , Dave Gerlach , Tony Lindgren , Nishanth Menon , Santosh Shilimkar Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Drew Fustini Subject: [PATCH v2 1/2] dt-bindings: wkup-m3-ipc: Add vtt toggle gpio pin property Date: Sat, 9 Apr 2022 14:12:14 -0700 Message-Id: <20220409211215.2529387-2-dfustini@baylibre.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220409211215.2529387-1-dfustini@baylibre.com> References: <20220409211215.2529387-1-dfustini@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220409_141138_201919_936AF5A1 X-CRM114-Status: GOOD ( 14.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Document Wakeup M3 IPC property that indicates a GPIO pin is connected to the enable pin on DDR VTT regulator and can be toggled during low power mode transitions. Signed-off-by: Dave Gerlach [dfustini: converted to YAML, removed unnecessary "ti,needs-vtt-toggle"] Signed-off-by: Drew Fustini Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/soc/ti/wkup-m3-ipc.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml b/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml index d855c01ce61c..7f4a75c5fcaa 100644 --- a/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml +++ b/Documentation/devicetree/bindings/soc/ti/wkup-m3-ipc.yaml @@ -24,6 +24,14 @@ description: |+ A wkup_m3_ipc device node is used to represent the IPC registers within an SoC. + Support for VTT Toggle + ================================== + On some boards like the AM335x EVM-SK and the AM437x GP EVM, a GPIO pin is + connected to the enable pin on the DDR VTT regulator. This allows the + regulator to be disabled upon suspend and enabled upon resume. Please note + that the GPIO pin must be part of the GPIO0 module as only this GPIO module + is in the wakeup power domain. + properties: compatible: enum: @@ -51,6 +59,10 @@ properties: mbox_wkupm3 child node. maxItems: 1 + ti,vtt-gpio-pin: + $ref: /schemas/types.yaml#/definitions/uint32 + description: GPIO pin connected to enable pin on VTT regulator + required: - compatible - reg @@ -76,6 +88,7 @@ examples: interrupts = <78>; ti,rproc = <&wkup_m3>; mboxes = <&mailbox &mbox_wkupm3>; + ti,vtt-gpio-pin = <7>; }; }; ... From patchwork Sat Apr 9 21:12:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Drew Fustini X-Patchwork-Id: 12808044 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (unknown [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 276E5C433F5 for ; Sat, 9 Apr 2022 21:15:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NztQQ/MC8NmbHEBIqpU//JymugPCCJwzG3G1x80jeJQ=; b=w+lESnIfwtwdOo sdhYIs67aPPb/yiozm7F5ovWmzNADGYJ+hry/gy6A1zJoWWoMrAlZHru55KOwJkX6P3fhsdC8hP/f H98miB4Nh42cH5mdKUlbmpgSfPI50MqsZkomdAPbIMAofHawKQDHQMRxCT0mdiOjTlakvMkmpAHL4 PGza6oreWkXhdIDEgJQQaPUAef3TDf76wfma3Mm5FtbjKvRti2Jf7pC+ueRh3Bc/X5SnONKo6mOMk KFfCpFWWf0SY8nRwpIvYmCoOu1b2rlZuoex/qT2RDLrg913poM7FRctov4w6JCTu54hLtKHufd8rr x5I6ohPrftuFFX6V15gg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndINC-003nKd-Dp; Sat, 09 Apr 2022 21:11:58 +0000 Received: from mail-pf1-x432.google.com ([2607:f8b0:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndIMt-003nIj-RN for linux-arm-kernel@lists.infradead.org; Sat, 09 Apr 2022 21:11:42 +0000 Received: by mail-pf1-x432.google.com with SMTP id h19so11384735pfv.1 for ; Sat, 09 Apr 2022 14:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pTEAPxrhT32vhayLsKotad+jG3u8S5Ei8ZeMFP9woBA=; b=ltY2ugsAE2tvX0t0fGwusuBjHrIkWhDVxPoIQrjbbexUIl57nSUefymYypdhORwPmo nZSfFMjvOOPsmKIcco+TeK250sA7lXZR+IVGR+TaOyXXxB+UowaBxZCTzi2RCxI6OaWe ds5XtscH7XQGg+JDOw7rk+iVkcH9JPzCufjk1LxnK+Tln+aJ0NFA5ORdPpQooWvmN7iG zocaFH6si8iwMwyZwDnH4fclirpOndGdkebmfYXKpE+jJzZklaHSwVgKB3+6JPooHGOl aol9/p7lu7Tiv7JC33UCFIANoWfPRPpAFTnu+TtkyI4iiyoI5yiKLTHryagRyrmQ29AG 0u6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pTEAPxrhT32vhayLsKotad+jG3u8S5Ei8ZeMFP9woBA=; b=GXGA1sOTBLSkVcME+8rl6niNIkHHDchOJFvxUl0YWd7gfGPGKCBJmgzvzWQfeFwb+U LETDGbbCxZeWr+KKPMADMwdc0+8vn95C17yP2pKbkO4UMmZ8AsfRAsWHc9cTpq4Q9vlx sP3s05z4nxv7SRVjNYBxDE5+fPc69Xht7/bbZmui0OBuVlDGyGrbHEv0ui4Dp3bGKBoz Fo2kvtJeN0UfrVoSefvjoihMP1Y/0Y590wLzOxwEjMVV1zWhH6GbvmjJF26BcMKDEDc8 91WhEFJzGju2cxEW0kdhQssVYRQIKxBKMgLQARvMfMSQYfEThOOXDB51YfBCPU/lJJPB k4eg== X-Gm-Message-State: AOAM531Lhe8eczr33nzebwLTQfw0cuUWlaSMbNt3Yc2mBtMk9RnX/sUb ibqWSzslWbPuWWusfvr48TzhoQ== X-Google-Smtp-Source: ABdhPJymzHW37Rm36BtfLUtICV/UaRQVPkfm/XEMa3uQcbapqEQJGStby8/ASIO3N632qaOns6r+3w== X-Received: by 2002:a05:6a00:2405:b0:4e1:5008:adcc with SMTP id z5-20020a056a00240500b004e15008adccmr25284211pfh.35.1649538698221; Sat, 09 Apr 2022 14:11:38 -0700 (PDT) Received: from x1.hsd1.or.comcast.net ([2601:1c2:1001:7090:925c:1a60:e433:31b7]) by smtp.gmail.com with ESMTPSA id w127-20020a627b85000000b00505a9142ce5sm1393295pfc.22.2022.04.09.14.11.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Apr 2022 14:11:37 -0700 (PDT) From: Drew Fustini To: Rob Herring , Krzysztof Kozlowski , Dave Gerlach , Tony Lindgren , Nishanth Menon , Santosh Shilimkar Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Drew Fustini , Keerthy Subject: [PATCH v2 2/2] soc: ti: wkup_m3_ipc: Add support for toggling VTT regulator Date: Sat, 9 Apr 2022 14:12:15 -0700 Message-Id: <20220409211215.2529387-3-dfustini@baylibre.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220409211215.2529387-1-dfustini@baylibre.com> References: <20220409211215.2529387-1-dfustini@baylibre.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220409_141139_928120_95ED99C4 X-CRM114-Status: GOOD ( 22.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Dave Gerlach Some boards like the AM335x EVM-SK and AM437x GP EVM provide software control via a GPIO pin to toggle the DDR VTT regulator to reduce power consumption in low power states. The VTT regulator should be disabled after enabling self-refresh on suspend, and should be enabled before disabling self-refresh on resume. This is to allow proper self-refresh entry/exit commands to be transmitted to the memory. The "ti,vtt-gpio-pin" device tree property in the wkup_m3_ipc node specifies which GPIO pin to use. This property is communicated to the Wakeup Cortex M3 co-processor where the actual toggling of the GPIO pin happens in CM3 firmware [1]. Please note that the GPIO pin must be on the GPIO0 module as that module is in the wakeup power domain. [1] https://git.ti.com/cgit/processor-firmware/ti-amx3-cm3-pm-firmware/tree/src/pm_services/ddr.c?h=08.02.00.006#n190 Signed-off-by: Dave Gerlach Signed-off-by: Keerthy [dfustini: remove the unnecessary "ti,needs-vtt-toggle" property] Signed-off-by: Drew Fustini --- drivers/soc/ti/wkup_m3_ipc.c | 26 ++++++++++++++++++++++++-- include/linux/wkup_m3_ipc.h | 1 + 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c index 2f03ced0f411..247a4b57a372 100644 --- a/drivers/soc/ti/wkup_m3_ipc.c +++ b/drivers/soc/ti/wkup_m3_ipc.c @@ -40,6 +40,13 @@ #define M3_FW_VERSION_MASK 0xffff #define M3_WAKE_SRC_MASK 0xff +#define IPC_MEM_TYPE_SHIFT (0x0) +#define IPC_MEM_TYPE_MASK (0x7 << 0) +#define IPC_VTT_STAT_SHIFT (0x3) +#define IPC_VTT_STAT_MASK (0x1 << 3) +#define IPC_VTT_GPIO_PIN_SHIFT (0x4) +#define IPC_VTT_GPIO_PIN_MASK (0x3f << 4) + #define M3_STATE_UNKNOWN 0 #define M3_STATE_RESET 1 #define M3_STATE_INITED 2 @@ -215,6 +222,12 @@ static int wkup_m3_is_available(struct wkup_m3_ipc *m3_ipc) (m3_ipc->state != M3_STATE_UNKNOWN)); } +static void wkup_m3_set_vtt_gpio(struct wkup_m3_ipc *m3_ipc, int gpio) +{ + m3_ipc->vtt_conf = (1 << IPC_VTT_STAT_SHIFT) | + (gpio << IPC_VTT_GPIO_PIN_SHIFT); +} + /* Public functions */ /** * wkup_m3_set_mem_type - Pass wkup_m3 which type of memory is in use @@ -294,7 +307,8 @@ static int wkup_m3_prepare_low_power(struct wkup_m3_ipc *m3_ipc, int state) /* Program each required IPC register then write defaults to others */ wkup_m3_ctrl_ipc_write(m3_ipc, m3_ipc->resume_addr, 0); wkup_m3_ctrl_ipc_write(m3_ipc, m3_power_state, 1); - wkup_m3_ctrl_ipc_write(m3_ipc, m3_ipc->mem_type, 4); + wkup_m3_ctrl_ipc_write(m3_ipc, m3_ipc->mem_type | + m3_ipc->vtt_conf, 4); wkup_m3_ctrl_ipc_write(m3_ipc, DS_IPC_DEFAULT, 2); wkup_m3_ctrl_ipc_write(m3_ipc, DS_IPC_DEFAULT, 3); @@ -433,12 +447,13 @@ static int wkup_m3_rproc_boot_thread(void *arg) static int wkup_m3_ipc_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - int irq, ret; + int irq, ret, temp; phandle rproc_phandle; struct rproc *m3_rproc; struct resource *res; struct task_struct *task; struct wkup_m3_ipc *m3_ipc; + struct device_node *np = dev->of_node; m3_ipc = devm_kzalloc(dev, sizeof(*m3_ipc), GFP_KERNEL); if (!m3_ipc) @@ -496,6 +511,13 @@ static int wkup_m3_ipc_probe(struct platform_device *pdev) m3_ipc->ops = &ipc_ops; + if (!of_property_read_u32(np, "ti,vtt-gpio-pin", &temp)) { + if (temp >= 0 && temp <= 31) + wkup_m3_set_vtt_gpio(m3_ipc, temp); + else + dev_warn(dev, "Invalid VTT GPIO(%d) pin\n", temp); + } + /* * Wait for firmware loading completion in a thread so we * can boot the wkup_m3 as soon as it's ready without holding diff --git a/include/linux/wkup_m3_ipc.h b/include/linux/wkup_m3_ipc.h index 3f496967b538..2bc52c6381d5 100644 --- a/include/linux/wkup_m3_ipc.h +++ b/include/linux/wkup_m3_ipc.h @@ -33,6 +33,7 @@ struct wkup_m3_ipc { int mem_type; unsigned long resume_addr; + int vtt_conf; int state; struct completion sync_complete;