From patchwork Mon Apr 11 10:30:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Miaoqian Lin X-Patchwork-Id: 12808970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF682C433EF for ; Mon, 11 Apr 2022 10:41:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:To: From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=6OTa++A/MUZM2Xd9r+EwRIXbRtrsC+1+stQmhcJRnvI=; b=Z3Jy0CGb1tVoHs Ox5dp4xTYX4DW+c6nlxajxYP1/57AtC7j/syBlfyni2MoT3n8qREJuHz4ephF/4fgeIYiP6FsRmGc Iih0osZVDQSS4B8DESKjJBJr9d213z1Ctv27dFXcuwIScx2d2WIp4zVRAGEf33cudYKd3xWadIOIu FJWYRRymF8DEOdhXzDW5UpjQdJBZupAAmCW2eUe6DyGjvsg1kwCvNXf1/QfNWi3eC5dE7IkevGi9T uXT34zzzrazWieDy3c/KLdw63d8GgaFQwYePS47F/AtUCjXbHE0kc39TyU3NSMUWc8mP+CgfC7nzb qkJ2xQaY1radW38Q950w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndrSq-008QAS-8X; Mon, 11 Apr 2022 10:40:08 +0000 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ndrJh-008Lhv-Fb for linux-arm-kernel@lists.infradead.org; Mon, 11 Apr 2022 10:30:42 +0000 Received: by mail-pf1-x42a.google.com with SMTP id h10so2525852pfr.10 for ; Mon, 11 Apr 2022 03:30:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:subject:date:message-id; bh=VrMR8gvOFjWxaufbBwSvKiS63Y8OuXOfxSp4uF7zIAw=; b=bynoAbM8exJk1RavUb1cy3mTryf26m1U2TStm4n/kw7GwzM6YE+84/uNbKwfjsoWtY T9Ad79+XdDBOj4YhVgsoRhWpiJg+hu3Mg1N3O6m65iMZUmsNW6+bk4GCrLDfpX52O059 mpkL4bf22MXomVHepqv93Mf1CMjAN0nTQdftgaoqSS8zn2fnJBs/qj/HFaRbG2aULQU2 zgSpG7JTQQNtlhvCgQ6pZvzHicROL1kSegg+HciTD2M+FPuXJkp0rnCOWX1d/k2au351 0YdDWf4ZSUkT5ETpf7L8mn3kJ2maZoC+4RdBKfrtYuvhflgySZcDVaTzp0XhzL+Yx4rG lyag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id; bh=VrMR8gvOFjWxaufbBwSvKiS63Y8OuXOfxSp4uF7zIAw=; b=G/fxVdlxRaLX0qx9+JmjMxxNY76MmtJi6l8wc7U08rKTq8OPWYv7nYlPgkNZMpiu3Z 579bz0K30GUaaBmacJkxvRfad2t0fAmLjZhyHbLcaljLeqg67rAc545MZXZC6rsHGE64 KC+61KJfsSw71D5t6d3o1ETTh2BaApGpdIMJj24HLarJMYreMs5Hq9sWllJWyxBqyrCb T310aNe4N5Qp6NBEBuULhDJeHoTOhF9zrbl0kwELtgOju5oiksnohgfuaAPl6VKpUnxr 4AEjxxGyd/5d6Zm/KSZSrckOxJeh9GS7suH1vwsQI3o3aE+YqH8xgQHj78QcZ4CiWa4+ 5s4g== X-Gm-Message-State: AOAM533RlNmVK8mvb4qAeIzQCVKP4A9H7YCdqr0ZIL06M2wq0QKX0+5/ VDKlEx2I5uCr/z3c2u2fKrE= X-Google-Smtp-Source: ABdhPJx0YrCFIkJmWNOPe3U/JuGUNRw8r6HGtDaYdKEXEkFfWj4uwqx3GF4DBIzJEzmlWnwoDkFvmg== X-Received: by 2002:a05:6a00:891:b0:4fe:1262:9b4e with SMTP id q17-20020a056a00089100b004fe12629b4emr31867142pfj.21.1649673039947; Mon, 11 Apr 2022 03:30:39 -0700 (PDT) Received: from localhost.localdomain ([159.226.95.43]) by smtp.googlemail.com with ESMTPSA id s24-20020a17090a441800b001ca9b5724a6sm19450645pjg.36.2022.04.11.03.30.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Apr 2022 03:30:39 -0700 (PDT) From: Miaoqian Lin To: Jonathan Cameron , Lars-Peter Clausen , Maxime Coquelin , Alexandre Torgue , Kees Cook , Miaoqian Lin , Philippe Schenker , linux-iio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] iio: stmpe-adc: Fix wait_for_completion_timeout return value check Date: Mon, 11 Apr 2022 10:30:27 +0000 Message-Id: <20220411103032.14038-1-linmq006@gmail.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220411_033041_584972_8488866A X-CRM114-Status: GOOD ( 13.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org wait_for_completion_timeout() returns unsigned long not long. it returns 0 if timed out, and positive if completed. The check for <= 0 is ambiguous and should be == 0 here indicating timeout which is the only error case Fixes: e813dde6f833 ("iio: stmpe-adc: Use wait_for_completion_timeout") Signed-off-by: Miaoqian Lin --- drivers/iio/adc/stmpe-adc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/adc/stmpe-adc.c b/drivers/iio/adc/stmpe-adc.c index d2d405388499..d475d1c17bfc 100644 --- a/drivers/iio/adc/stmpe-adc.c +++ b/drivers/iio/adc/stmpe-adc.c @@ -61,7 +61,7 @@ struct stmpe_adc { static int stmpe_read_voltage(struct stmpe_adc *info, struct iio_chan_spec const *chan, int *val) { - long ret; + unsigned long ret; mutex_lock(&info->lock); @@ -79,7 +79,7 @@ static int stmpe_read_voltage(struct stmpe_adc *info, ret = wait_for_completion_timeout(&info->completion, STMPE_ADC_TIMEOUT); - if (ret <= 0) { + if (ret == 0) { stmpe_reg_write(info->stmpe, STMPE_REG_ADC_INT_STA, STMPE_ADC_CH(info->channel)); mutex_unlock(&info->lock);