From patchwork Mon Apr 18 08:16:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hangyu Hua X-Patchwork-Id: 12816367 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3ED10C433F5 for ; Mon, 18 Apr 2022 08:17:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=/6t86fGqMIAegrQG1vAhIcQzoAmY5y7NePHTxO0aRjk=; b=CG5Ab9oc0QGsnM O8JaseuKS0SCYlz2n5Gkt1Ztw5ycDpr8mIdinmg1v1ur1MZhlhimPnK9LSPzq/D7xgA5rRkoWoSOV Gs0wEIfTltbmsloF7BOmDpDKSs0laHJV6s4xSCQNq79y/TwFIbMb00Qe3dTbme4WVN+YMe3bFlwEi 9MD8yy08Fe+cTexCP8Z4NK7s6dI1DhW6J0lyu9hgHo+E/N81ol5hQUPgqdt+R/a4q9mcQSHmv7l+1 zGbDAx8s4l5Po9Ym6vMFuoW8NqcZwhaYEg7/EUBLDOW4epp4Mq1CXnOCgt2+eEAxnPo6GnEU3C7lx ZRajhnBKf49r61BwtqjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngMZ2-00Fxpe-2o; Mon, 18 Apr 2022 08:16:52 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ngMYy-00FxoV-Vs for linux-arm-kernel@lists.infradead.org; Mon, 18 Apr 2022 08:16:50 +0000 Received: by mail-pl1-x644.google.com with SMTP id 12so11774356pll.12 for ; Mon, 18 Apr 2022 01:16:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QuqDicbY3kF4HQHdeFb/QPn21jDri/mLpJf4XQrwT3o=; b=Cf91qwkiOFKTt4qMLq9v73fay0oIWWa+PJlaAfoWlehlU4po3BhqsIN49MGh99uXsq 4xQC18cXFAhYHB1KMlGLW2uhEljK5iDu1fsATHCWs1p/gPmzOQFmczki0721XqaT+IxJ GUEYGWevx06ZGeWVwXeL5peJ58NYCPqBOsHlPwjpyFTvoClq2WFVu42rZPe/44iBdBH4 7InQgDLAq+z0Wm8/LOwqDZyiEg1NkqX/2Maj8gqEgvdXlCK/KnWE217YXd1spF3U4zHz xN4iBZ6o3LaF9zPmz8IGEDJnrN1PPTFYU9OMG6Sipf15vnV3P2T1es2G0lE+dbGV55As PK9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=QuqDicbY3kF4HQHdeFb/QPn21jDri/mLpJf4XQrwT3o=; b=DNqGRDiD/t6jzVISTP7SF1Y0p+a7Pmf+fnSfb41NbV8Fcj2qjgIff017kHA7Va1+Rg 6mPxd6TDDZCuDvNLONEKwAYwHhrpYGgqbAJuG/FzhA0e2Ji+5tkJxbND8Rm9fKTaFGRp MSOfw+QU3FR2iQTP+HAfd6tv3awG8VEJ3+YoS7njBHcj2gOkYt63rvXygECtkq1XZEpZ lriPJar3vkF2j7dMZ7vWvk9nVvck6NXAuxnnxunqff35dTbqbyr4K8JYC4g6h9VQ70+K cEh4n5xpmqrmJsuAOwo7fkaZLHt6ZKjkBgx8D7KDPKBZTF1gfOxNjAL0kRrFldSNhM6Y 00+Q== X-Gm-Message-State: AOAM531v0HeoDJ26Qnh/t+eW+cYmTaVI7HcoEDnHtCldr/CELEIUx0/s u6mOEqrbrGjk0Y9lkFd4nT0= X-Google-Smtp-Source: ABdhPJzwGQWOC0I6R9+OHjfZ/iZ3x1t3TfAOEyesjAPVx/oKo1R9eOfSpI5WOxjRu4mpqrgcWQm9AQ== X-Received: by 2002:a17:902:f0ca:b0:158:d082:ee3a with SMTP id v10-20020a170902f0ca00b00158d082ee3amr10191448pla.151.1650269806945; Mon, 18 Apr 2022 01:16:46 -0700 (PDT) Received: from localhost.localdomain ([103.84.139.165]) by smtp.gmail.com with ESMTPSA id u10-20020a6540ca000000b0037445e95c93sm11777600pgp.15.2022.04.18.01.16.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Apr 2022 01:16:46 -0700 (PDT) From: Hangyu Hua To: alexander.shishkin@linux.intel.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, gregkh@linuxfoundation.org, mathieu.poirier@linaro.org Cc: linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hangyu Hua Subject: [PATCH] hwtracing: stm: fix possible double free in stm_register_device() Date: Mon, 18 Apr 2022 16:16:32 +0800 Message-Id: <20220418081632.35121-1-hbh25y@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220418_011649_098152_525C1F85 X-CRM114-Status: UNSURE ( 9.21 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org put_device() will call stm_device_release() to free stm when stm_register_device() fails. So there is no need to call vfree() again. Fix this by adding a return after put_device(). Fixes: 7bd1d4093c2f ("stm class: Introduce an abstraction for System Trace Module devices") Signed-off-by: Hangyu Hua --- drivers/hwtracing/stm/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c index 2712e699ba08..403b4f41bb1b 100644 --- a/drivers/hwtracing/stm/core.c +++ b/drivers/hwtracing/stm/core.c @@ -915,6 +915,7 @@ int stm_register_device(struct device *parent, struct stm_data *stm_data, /* matches device_initialize() above */ put_device(&stm->dev); + return err; err_free: vfree(stm);