From patchwork Tue Apr 19 06:28:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijaya Krishna Nivarthi X-Patchwork-Id: 12817424 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D70C433F5 for ; Tue, 19 Apr 2022 06:28:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348802AbiDSGb1 (ORCPT ); Tue, 19 Apr 2022 02:31:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348807AbiDSGbZ (ORCPT ); Tue, 19 Apr 2022 02:31:25 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7F3124596; Mon, 18 Apr 2022 23:28:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1650349722; x=1681885722; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=mPWEyqK78+whl1RR/55/QKTf0RnEp6hYbhKjoSivFGo=; b=rp7D6+bFczRondQmj5e0zFRKZ+4pBwklitSPoutobM5Qw/OMhjWfY2IN NV7XVqxNDzPPtNSqUJjCF4ksoIYyx+8TpAGbGOh1ihXdOc2qymXPG0jL/ VGhV06GOFmf3fbznygzA6b5QZ56RHd5SlVf6G3flDihEOvwbIxmZ2VWw7 U=; Received: from ironmsg07-lv.qualcomm.com ([10.47.202.151]) by alexa-out.qualcomm.com with ESMTP; 18 Apr 2022 23:28:42 -0700 X-QCInternal: smtphost Received: from ironmsg01-blr.qualcomm.com ([10.86.208.130]) by ironmsg07-lv.qualcomm.com with ESMTP/TLS/AES256-SHA; 18 Apr 2022 23:28:39 -0700 X-QCInternal: smtphost Received: from hu-vnivarth-hyd.qualcomm.com (HELO hu-sgudaval-hyd.qualcomm.com) ([10.213.111.166]) by ironmsg01-blr.qualcomm.com with ESMTP; 19 Apr 2022 11:58:25 +0530 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 3994820) id 0B6DE3C01; Tue, 19 Apr 2022 11:58:24 +0530 (+0530) From: Vijaya Krishna Nivarthi To: agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: quic_msavaliy@quicinc.com, dianders@chromium.org, Vijaya Krishna Nivarthi Subject: [V4 1/2] arch: arm64: dts: qcom: sc7280-idp: Configure cts pinctrl to bias-bus-hold Date: Tue, 19 Apr 2022 11:58:16 +0530 Message-Id: <1650349697-13540-2-git-send-email-quic_vnivarth@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1650349697-13540-1-git-send-email-quic_vnivarth@quicinc.com> References: <1650349697-13540-1-git-send-email-quic_vnivarth@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org WLAN rail was leaking power during RBSC/sleep even after turning BT off. Change sleep pinctrl configuration to handle same. Signed-off-by: Vijaya Krishna Nivarthi Reviewed-by: Douglas Anderson --- v4: modify subject of patch to indicate file it is applying to v3: apply same change to active state and other sc7280*.dts* as well v2: used bias-bus-hold as per review comments v1: intial patch used bias-disable for sleep pinctrl in sc7280-idp only --- arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi index 015a347..85e7467 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi @@ -400,10 +400,10 @@ &qup_uart7_cts { /* - * Configure a pull-down on CTS to match the pull of - * the Bluetooth module. + * Configure a bias-bus-hold on CTS to lower power usage + * when BT is turned off. */ - bias-pull-down; + bias-bus-hold; }; &qup_uart7_rts { @@ -495,10 +495,10 @@ pins = "gpio28"; function = "gpio"; /* - * Configure a pull-down on CTS to match the pull of - * the Bluetooth module. + * Configure a bias-bus-hold on CTS to lower power usage + * when BT is turned off. */ - bias-pull-down; + bias-bus-hold; }; qup_uart7_sleep_rts: qup-uart7-sleep-rts { From patchwork Tue Apr 19 06:28:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vijaya Krishna Nivarthi X-Patchwork-Id: 12817423 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33F76C433EF for ; Tue, 19 Apr 2022 06:28:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348813AbiDSGb0 (ORCPT ); Tue, 19 Apr 2022 02:31:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42568 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348792AbiDSGbV (ORCPT ); Tue, 19 Apr 2022 02:31:21 -0400 Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2CDDF23BFC; Mon, 18 Apr 2022 23:28:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1650349719; x=1681885719; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=cG1Yzcr9fSJjQUXPjwcFfaw2bSuVoeeQVhgzvUMyjTE=; b=wB6VR4O8Ff8peR0KF1PpVT2SWBz6EvNPpT92doFvSeKiaF7ZKLIv0d9U qQSu1T+awJ4gUv4ghmg4ZGEmDLQqb1k+TUMUd8s7iJHCvJYiHi+xBWtco 4BfzVeV4clOxLwZ01cFcbQDXfbI56M4QIgbNOUfNyOCx0ej4wCQcxi0Ct A=; Received: from ironmsg-lv-alpha.qualcomm.com ([10.47.202.13]) by alexa-out.qualcomm.com with ESMTP; 18 Apr 2022 23:28:39 -0700 X-QCInternal: smtphost Received: from ironmsg01-blr.qualcomm.com ([10.86.208.130]) by ironmsg-lv-alpha.qualcomm.com with ESMTP/TLS/AES256-SHA; 18 Apr 2022 23:28:37 -0700 X-QCInternal: smtphost Received: from hu-vnivarth-hyd.qualcomm.com (HELO hu-sgudaval-hyd.qualcomm.com) ([10.213.111.166]) by ironmsg01-blr.qualcomm.com with ESMTP; 19 Apr 2022 11:58:28 +0530 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 3994820) id 854473C01; Tue, 19 Apr 2022 11:58:26 +0530 (+0530) From: Vijaya Krishna Nivarthi To: agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: quic_msavaliy@quicinc.com, dianders@chromium.org, Vijaya Krishna Nivarthi Subject: [V4 2/2] arch: arm64: dts: qcom: sc7280-qcard: Configure cts pinctrl to bias-bus-hold Date: Tue, 19 Apr 2022 11:58:17 +0530 Message-Id: <1650349697-13540-3-git-send-email-quic_vnivarth@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1650349697-13540-1-git-send-email-quic_vnivarth@quicinc.com> References: <1650349697-13540-1-git-send-email-quic_vnivarth@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org WLAN rail was leaking power during RBSC/sleep even after turning BT off. Change sleep pinctrl configuration to handle same. Signed-off-by: Vijaya Krishna Nivarthi Reviewed-by: Douglas Anderson --- v4: modify subject of patch to indicate file it is applying to v3: apply same change to active state and other sc7280*.dts* as well v2: used bias-bus-hold as per review comments v1: intial patch used bias-disable for sleep pinctrl in sc7280-idp only --- arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi index b833ba1..602ebd4 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi @@ -398,8 +398,11 @@ mos_bt_uart: &uart7 { /* For mos_bt_uart */ &qup_uart7_cts { - /* Configure a pull-down on CTS to match the pull of the Bluetooth module. */ - bias-pull-down; + /* + * Configure a bias-bus-hold on CTS to lower power usage + * when BT is turned off. + */ + bias-bus-hold; }; /* For mos_bt_uart */ @@ -490,10 +493,10 @@ mos_bt_uart: &uart7 { pins = "gpio28"; function = "gpio"; /* - * Configure a pull-down on CTS to match the pull of - * the Bluetooth module. + * Configure a bias-bus-hold on CTS to lower power usage + * when BT is turned off. */ - bias-pull-down; + bias-bus-hold; }; /* For mos_bt_uart */