From patchwork Tue Apr 19 13:18:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivasa Rao Mandadapu X-Patchwork-Id: 12818203 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20957C433F5 for ; Tue, 19 Apr 2022 13:20:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7D38918C6; Tue, 19 Apr 2022 15:19:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7D38918C6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1650374409; bh=WGK9lc90B8AEGZB++shtHBM2BYQcmAWATmkLvvOJGt8=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=Cd2KVcpk3PETFW50WgamSUVKSmCVVlpRLkl+2mF0slTBu6RU55CcYNSsXcpaTtOs5 ELXMXWu4KzcXVYVZiz2rg8OE54qgX41T/kzNe/3+R9PKyCWdVG6oW58SV9hXuhZBWU i0AisOfeiOtsL5tXKnpYBmxRkoTnYAzrYzTdnKUU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 21BA1F80121; Tue, 19 Apr 2022 15:19:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CE47FF8025D; Tue, 19 Apr 2022 15:19:17 +0200 (CEST) Received: from alexa-out.qualcomm.com (alexa-out.qualcomm.com [129.46.98.28]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 14FB9F80121 for ; Tue, 19 Apr 2022 15:19:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 14FB9F80121 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="UPvcrGte" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; i=@quicinc.com; q=dns/txt; s=qcdkim; t=1650374352; x=1681910352; h=from:to:cc:subject:date:message-id:mime-version; bh=FEwok1lzjt/HO93wIkHzSCWrGpT3TbisaBs2ZCCYLc0=; b=UPvcrGteYCgoKX3EX2wb1tL2qIx3umJ82FJel0XjlgnnznAePhSpFMuM VanxcjtbDMUPqZv2ng8ym4/foAbJOxVo3DL+f5dIyoieJHz/KFeBJCZln 1j5aEOaKJW/9usnpKYFUdXfyeQRWF0gpQBdX+tdyz0aiXRp4PWODVknvj g=; Received: from ironmsg-lv-alpha.qualcomm.com ([10.47.202.13]) by alexa-out.qualcomm.com with ESMTP; 19 Apr 2022 06:19:08 -0700 X-QCInternal: smtphost Received: from nasanex01c.na.qualcomm.com ([10.47.97.222]) by ironmsg-lv-alpha.qualcomm.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Apr 2022 06:19:07 -0700 Received: from nalasex01a.na.qualcomm.com (10.47.209.196) by nasanex01c.na.qualcomm.com (10.47.97.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 19 Apr 2022 06:19:07 -0700 Received: from hu-srivasam-hyd.qualcomm.com (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.22; Tue, 19 Apr 2022 06:19:01 -0700 From: Srinivasa Rao Mandadapu To: , , , , , , , , , , , , , , , Subject: [PATCH v2] ASoC: qcom: SC7280: Update machine driver startup, shutdown callbacks Date: Tue, 19 Apr 2022 18:48:49 +0530 Message-ID: <1650374329-7279-1-git-send-email-quic_srivasam@quicinc.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nalasex01a.na.qualcomm.com (10.47.209.196) Cc: Venkata Prasad Potturu , Srinivasa Rao Mandadapu X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Update machine driver startup, shutdown callback functions to avoid sound card registration failure on other platforms. Without this change, platforms with WCD codec is failing to register sound card. Fixes: c5198db82d4c ("ASoC: qcom: Add driver support for ALC5682I-VS") Signed-off-by: Srinivasa Rao Mandadapu Co-developed-by: Venkata Prasad Potturu Signed-off-by: Venkata Prasad Potturu --- Changes Since V1: -- Update swith case in startup, shutdown callbacks for handling all dai id's -- Update commit message and add Fixes tag sound/soc/qcom/sc7280.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/sound/soc/qcom/sc7280.c b/sound/soc/qcom/sc7280.c index 4ef4034..834c081 100644 --- a/sound/soc/qcom/sc7280.c +++ b/sound/soc/qcom/sc7280.c @@ -291,13 +291,7 @@ static void sc7280_snd_shutdown(struct snd_pcm_substream *substream) SNDRV_PCM_STREAM_PLAYBACK); } break; - case MI2S_SECONDARY: - break; - case LPASS_DP_RX: - break; default: - dev_err(rtd->dev, "%s: invalid dai id 0x%x\n", __func__, - cpu_dai->id); break; } } @@ -312,14 +306,8 @@ static int sc7280_snd_startup(struct snd_pcm_substream *substream) case MI2S_PRIMARY: ret = sc7280_rt5682_init(rtd); break; - case MI2S_SECONDARY: - break; - case LPASS_DP_RX: - break; default: - dev_err(rtd->dev, "%s: invalid dai id 0x%x\n", __func__, - cpu_dai->id); - return -EINVAL; + break; } return ret; }