From patchwork Wed Apr 20 07:31:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 12819863 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91A64C433FE for ; Wed, 20 Apr 2022 07:31:35 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.308939.524874 (Exim 4.92) (envelope-from ) id 1nh4o9-0006zz-9C; Wed, 20 Apr 2022 07:31:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 308939.524874; Wed, 20 Apr 2022 07:31:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nh4o9-0006yn-3U; Wed, 20 Apr 2022 07:31:25 +0000 Received: by outflank-mailman (input) for mailman id 308939; Wed, 20 Apr 2022 07:31:23 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nh4o7-0006Tb-B8 for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 07:31:23 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dfa36ac1-c07b-11ec-8fbf-03012f2f19d4; Wed, 20 Apr 2022 09:31:21 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 268C7210ED; Wed, 20 Apr 2022 07:31:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 004C813A30; Wed, 20 Apr 2022 07:31:20 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id yNBUOsi2X2IhXAAAMHmgww (envelope-from ); Wed, 20 Apr 2022 07:31:20 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfa36ac1-c07b-11ec-8fbf-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1650439881; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CTPiijYWD7yPxL86YUqzoUHVXxb7L5u3k0/gpyUiDjo=; b=Hc5mx8MxTTQhGpiczvnm4m7uQF/GzNwq2CccsU0FB/ebKbyfENh17aJ7Hk1/EOiLy7DjmF fdO3T5Ii4hMQG/gx+KOzzWF4LVt8Q26iX4Fqzy63VsLR+ed0UQy07v2EzgB5Nt5j+4WTCu P0xrU7oZgEOREVzZQ4CZu0fA6akEsa4= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD Subject: [PATCH 1/4] tools/libs/evtchn: don't set errno to negative values Date: Wed, 20 Apr 2022 09:31:16 +0200 Message-Id: <20220420073119.16974-2-jgross@suse.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220420073119.16974-1-jgross@suse.com> References: <20220420073119.16974-1-jgross@suse.com> MIME-Version: 1.0 Setting errno to a negative value makes no sense. Signed-off-by: Juergen Gross Acked-by: Andrew Cooper --- tools/libs/evtchn/freebsd.c | 2 +- tools/libs/evtchn/minios.c | 2 +- tools/libs/evtchn/netbsd.c | 2 +- tools/libs/evtchn/solaris.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/libs/evtchn/freebsd.c b/tools/libs/evtchn/freebsd.c index c4d075350b..422836f1a1 100644 --- a/tools/libs/evtchn/freebsd.c +++ b/tools/libs/evtchn/freebsd.c @@ -58,7 +58,7 @@ int osdep_evtchn_close(xenevtchn_handle *xce) int osdep_evtchn_restrict(xenevtchn_handle *xce, domid_t domid) { - errno = -EOPNOTSUPP; + errno = EOPNOTSUPP; return -1; } diff --git a/tools/libs/evtchn/minios.c b/tools/libs/evtchn/minios.c index 65cfccfd09..8ff46de884 100644 --- a/tools/libs/evtchn/minios.c +++ b/tools/libs/evtchn/minios.c @@ -143,7 +143,7 @@ int osdep_evtchn_close(xenevtchn_handle *xce) int osdep_evtchn_restrict(xenevtchn_handle *xce, domid_t domid) { - errno = -EOPNOTSUPP; + errno = EOPNOTSUPP; return -1; } diff --git a/tools/libs/evtchn/netbsd.c b/tools/libs/evtchn/netbsd.c index 0b223c4beb..2de9cefc67 100644 --- a/tools/libs/evtchn/netbsd.c +++ b/tools/libs/evtchn/netbsd.c @@ -53,7 +53,7 @@ int osdep_evtchn_close(xenevtchn_handle *xce) int osdep_evtchn_restrict(xenevtchn_handle *xce, domid_t domid) { - errno = -EOPNOTSUPP; + errno = EOPNOTSUPP; return -1; } diff --git a/tools/libs/evtchn/solaris.c b/tools/libs/evtchn/solaris.c index 7fef88a73e..375a5f9b4f 100644 --- a/tools/libs/evtchn/solaris.c +++ b/tools/libs/evtchn/solaris.c @@ -53,7 +53,7 @@ int osdep_evtchn_close(xenevtchn_handle *xce) int osdep_evtchn_restrict(xenevtchn_handle *xce, domid_t domid) { - errno = -EOPNOTSUPP; + errno = EOPNOTSUPP; return -1; } From patchwork Wed Apr 20 07:31:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 12819862 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB6B0C4332F for ; Wed, 20 Apr 2022 07:31:35 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.308938.524859 (Exim 4.92) (envelope-from ) id 1nh4o7-0006Xk-TS; Wed, 20 Apr 2022 07:31:23 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 308938.524859; Wed, 20 Apr 2022 07:31:23 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nh4o7-0006Wx-M8; Wed, 20 Apr 2022 07:31:23 +0000 Received: by outflank-mailman (input) for mailman id 308938; Wed, 20 Apr 2022 07:31:22 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nh4o6-0006Tb-HZ for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 07:31:22 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dfbc2d0b-c07b-11ec-8fbf-03012f2f19d4; Wed, 20 Apr 2022 09:31:21 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 50E2A21118; Wed, 20 Apr 2022 07:31:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 2BDD913A30; Wed, 20 Apr 2022 07:31:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id uP1yCcm2X2IhXAAAMHmgww (envelope-from ); Wed, 20 Apr 2022 07:31:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfbc2d0b-c07b-11ec-8fbf-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1650439881; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6FxRXq43vu3ZI41xgmHwfTdmhBdkORLelAm0BLwTOuQ=; b=WtuoKBr+cHd3CbctZ9p3xKHGwbLgDxlIEb53eZqpcQxIugMjXgVFWC+Bfh5Sjrjisby+5K 4vEqxztDDGBcOJtRcRRZ56I80JDP0SCWyBenIFgUHzXlHcDgxNZQUQCWdddvf6Q4AuxID1 Id3GwYvJqVwnVA9Y3zDh9SZ4C1r6xlI= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD Subject: [PATCH 2/4] tools/libs/ctrl: don't set errno to a negative value Date: Wed, 20 Apr 2022 09:31:17 +0200 Message-Id: <20220420073119.16974-3-jgross@suse.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220420073119.16974-1-jgross@suse.com> References: <20220420073119.16974-1-jgross@suse.com> MIME-Version: 1.0 The claimed reason for setting errno to -1 is wrong. On x86 xc_domain_pod_target() will set errno to a sane value in the error case. Signed-off-by: Juergen Gross Acked-by: Andrew Cooper --- tools/libs/ctrl/xc_domain.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tools/libs/ctrl/xc_domain.c b/tools/libs/ctrl/xc_domain.c index ef62f66009..71608c00e9 100644 --- a/tools/libs/ctrl/xc_domain.c +++ b/tools/libs/ctrl/xc_domain.c @@ -1293,9 +1293,7 @@ int xc_domain_get_pod_target(xc_interface *xch, uint64_t *pod_cache_pages, uint64_t *pod_entries) { - /* On x86 (above) xc_domain_pod_target will incorrectly return -1 - * with errno==-1 on error. Do the same for least surprise. */ - errno = -1; + errno = EOPNOTSUPP; return -1; } #endif From patchwork Wed Apr 20 07:31:18 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 12819860 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0EB5BC433EF for ; Wed, 20 Apr 2022 07:31:35 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.308940.524878 (Exim 4.92) (envelope-from ) id 1nh4o9-000745-Je; Wed, 20 Apr 2022 07:31:25 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 308940.524878; Wed, 20 Apr 2022 07:31:25 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nh4o9-00072n-DY; Wed, 20 Apr 2022 07:31:25 +0000 Received: by outflank-mailman (input) for mailman id 308940; Wed, 20 Apr 2022 07:31:24 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nh4o8-0006Tb-BJ for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 07:31:24 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dfdddeec-c07b-11ec-8fbf-03012f2f19d4; Wed, 20 Apr 2022 09:31:21 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8615D2112B; Wed, 20 Apr 2022 07:31:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5694C13A30; Wed, 20 Apr 2022 07:31:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id wED1E8m2X2IhXAAAMHmgww (envelope-from ); Wed, 20 Apr 2022 07:31:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dfdddeec-c07b-11ec-8fbf-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1650439881; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8ofN2RF9Ov3D5sC5yESVJrU8I3one2H23BuRvfynNlI=; b=CFYyAfwKtHfiGQPN8PiSdhC2b12FJrOUyq3casjWcZCNkvp7W9stmazsqnXa4o/RhhTyeb MP/iSlvFo1wX/n/wZnwJjJeIbS2HQjVU/qQzGB2Hhj/P/NIyaGKm9k2L964JCsnPGxZTA+ GeWxLSGo7DqukzpY3u4yJFuYIlGl5tQ= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD Subject: [PATCH 3/4] tools/libs/guest: don't set errno to a negative value Date: Wed, 20 Apr 2022 09:31:18 +0200 Message-Id: <20220420073119.16974-4-jgross@suse.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220420073119.16974-1-jgross@suse.com> References: <20220420073119.16974-1-jgross@suse.com> MIME-Version: 1.0 Setting errno to a negative error value makes no sense. Signed-off-by: Juergen Gross Acked-by: Andrew Cooper --- tools/libs/guest/xg_dom_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/guest/xg_dom_core.c b/tools/libs/guest/xg_dom_core.c index c17cf9f712..c4f4e7f3e2 100644 --- a/tools/libs/guest/xg_dom_core.c +++ b/tools/libs/guest/xg_dom_core.c @@ -855,7 +855,7 @@ int xc_dom_devicetree_file(struct xc_dom_image *dom, const char *filename) return -1; return 0; #else - errno = -EINVAL; + errno = EINVAL; return -1; #endif } From patchwork Wed Apr 20 07:31:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?b?SsO8cmdlbiBHcm/Dnw==?= X-Patchwork-Id: 12819864 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D6270C433EF for ; Wed, 20 Apr 2022 07:31:36 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.308941.524895 (Exim 4.92) (envelope-from ) id 1nh4oB-0007U6-0C; Wed, 20 Apr 2022 07:31:27 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 308941.524895; Wed, 20 Apr 2022 07:31:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nh4oA-0007Se-PX; Wed, 20 Apr 2022 07:31:26 +0000 Received: by outflank-mailman (input) for mailman id 308941; Wed, 20 Apr 2022 07:31:25 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1nh4o9-0006Tb-Bi for xen-devel@lists.xenproject.org; Wed, 20 Apr 2022 07:31:25 +0000 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id dffdddbc-c07b-11ec-8fbf-03012f2f19d4; Wed, 20 Apr 2022 09:31:21 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id BA2DA2129B; Wed, 20 Apr 2022 07:31:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8C00F13A30; Wed, 20 Apr 2022 07:31:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 4Df0IMm2X2IhXAAAMHmgww (envelope-from ); Wed, 20 Apr 2022 07:31:21 +0000 X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: dffdddbc-c07b-11ec-8fbf-03012f2f19d4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1650439881; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nJP8UFG+Q9kAlZKRDuHPR38rUH2iyFSN6K0QfjZvvLU=; b=Ovt4EYJETbGH7VdDHAuTVyN/BTeMneYJiZxMS+aIokt9TIBLIMAXjnFd0Owa3s10y35Qae c9EGHttEJi/XCCazDcKM69R8xDJoQxcExc+g/3XzvsbTWCLCusURcU97q90mLlO1Ij6vcI aNnXVTV/gqcKSeZegnmti3RaaSlnSlY= From: Juergen Gross To: xen-devel@lists.xenproject.org Cc: Juergen Gross , Wei Liu , Anthony PERARD Subject: [PATCH 4/4] tools/libs/light: don't set errno to a negative value Date: Wed, 20 Apr 2022 09:31:19 +0200 Message-Id: <20220420073119.16974-5-jgross@suse.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220420073119.16974-1-jgross@suse.com> References: <20220420073119.16974-1-jgross@suse.com> MIME-Version: 1.0 Setting errno to a negative value makes no sense. Signed-off-by: Juergen Gross Acked-by: Andrew Cooper --- tools/libs/light/libxl_linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libs/light/libxl_linux.c b/tools/libs/light/libxl_linux.c index 8d62dfd255..27f2bce718 100644 --- a/tools/libs/light/libxl_linux.c +++ b/tools/libs/light/libxl_linux.c @@ -288,7 +288,7 @@ int libxl__pci_topology_init(libxl__gc *gc, if (i == num_devs) { LOG(ERROR, "Too many devices"); err = ERROR_FAIL; - errno = -ENOSPC; + errno = ENOSPC; goto out; }